[GitHub] [hbase] Apache-HBase commented on issue #625: HBASE-23023 upgrade shellcheck used in dockerfile
Apache-HBase commented on issue #625: HBASE-23023 upgrade shellcheck used in dockerfile URL: https://github.com/apache/hbase/pull/625#issuecomment-531451848 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 16m 53s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :blue_heart: | hadolint | 0m 0s | hadolint was not available. | | :blue_heart: | shelldocs | 0m 0s | Shelldocs was not available. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-1 Compile Tests _ | | :blue_heart: | mvndep | 5m 54s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 11s | Maven dependency ordering for patch | | :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | :blue_heart: | asflicense | 0m 0s | ASF License check generated no output? | | | | 24m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-625/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/625 | | Optional Tests | dupname asflicense hadolint shellcheck shelldocs | | uname | Linux 6502b71b9d55 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-625/out/precommit/personality/provided.sh | | git revision | branch-1 / 99e7f60 | | Max. process+thread count | 47 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-625/1/console | | versions | git=1.9.1 maven=3.0.5 shellcheck=0.7.0 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #624: HBASE-23023 upgrade shellcheck used in dockerfile
Apache-HBase commented on issue #624: HBASE-23023 upgrade shellcheck used in dockerfile URL: https://github.com/apache/hbase/pull/624#issuecomment-531450822 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 3m 34s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :blue_heart: | hadolint | 0m 0s | hadolint was not available. | | :blue_heart: | shelldocs | 0m 0s | Shelldocs was not available. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 39s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 12s | Maven dependency ordering for patch | | :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | :blue_heart: | asflicense | 0m 1s | ASF License check generated no output? | | | | 5m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-624/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/624 | | Optional Tests | dupname asflicense hadolint shellcheck shelldocs | | uname | Linux 0d93c484e9f4 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-624/out/precommit/personality/provided.sh | | git revision | master / 3583ef7476 | | Max. process+thread count | 47 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-624/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #624: HBASE-23023 upgrade shellcheck used in dockerfile
Apache-HBase commented on issue #624: HBASE-23023 upgrade shellcheck used in dockerfile URL: https://github.com/apache/hbase/pull/624#issuecomment-531450508 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-624/1/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #625: HBASE-23023 upgrade shellcheck used in dockerfile
Apache-HBase commented on issue #625: HBASE-23023 upgrade shellcheck used in dockerfile URL: https://github.com/apache/hbase/pull/625#issuecomment-531450511 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-625/1/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey opened a new pull request #625: HBASE-23023 upgrade shellcheck used in dockerfile
busbey opened a new pull request #625: HBASE-23023 upgrade shellcheck used in dockerfile URL: https://github.com/apache/hbase/pull/625 because branches-1 use an older Ubuntu we need to include a work around for a bug in the linking of the shellcheck executable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey opened a new pull request #624: HBASE-23023 upgrade shellcheck used in dockerfile
busbey opened a new pull request #624: HBASE-23023 upgrade shellcheck used in dockerfile URL: https://github.com/apache/hbase/pull/624 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23023) upgrade shellcheck used to test in nightly and precommit
[ https://issues.apache.org/jira/browse/HBASE-23023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-23023: Summary: upgrade shellcheck used to test in nightly and precommit (was: upgrade shellcheck used to test branch-1) > upgrade shellcheck used to test in nightly and precommit > > > Key: HBASE-23023 > URL: https://issues.apache.org/jira/browse/HBASE-23023 > Project: HBase > Issue Type: Task > Components: build >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > > branches-1 are using an out of date version of shellcheck. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-23023) upgrade shellcheck used to test in nightly and precommit
[ https://issues.apache.org/jira/browse/HBASE-23023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-23023: Description: all our docker images are using an out of date version of shellcheck. (was: branches-1 are using an out of date version of shellcheck.) > upgrade shellcheck used to test in nightly and precommit > > > Key: HBASE-23023 > URL: https://issues.apache.org/jira/browse/HBASE-23023 > Project: HBase > Issue Type: Task > Components: build >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > > all our docker images are using an out of date version of shellcheck. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (HBASE-23023) upgrade shellcheck used to test branch-1
Sean Busbey created HBASE-23023: --- Summary: upgrade shellcheck used to test branch-1 Key: HBASE-23023 URL: https://issues.apache.org/jira/browse/HBASE-23023 Project: HBase Issue Type: Task Components: build Reporter: Sean Busbey Assignee: Sean Busbey branches-1 are using an out of date version of shellcheck. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (HBASE-23022) download page should use HTTPS for links to archive.a.o
[ https://issues.apache.org/jira/browse/HBASE-23022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-23022. - Fix Version/s: 3.0.0 Resolution: Fixed > download page should use HTTPS for links to archive.a.o > --- > > Key: HBASE-23022 > URL: https://issues.apache.org/jira/browse/HBASE-23022 > Project: HBase > Issue Type: Bug > Components: website >Reporter: Sean Busbey >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 3.0.0 > > > Noticed this while working on some automation. We're https everywhere else in > this page, just not this link. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (HBASE-23022) download page should use HTTPS for links to archive.a.o
Sean Busbey created HBASE-23022: --- Summary: download page should use HTTPS for links to archive.a.o Key: HBASE-23022 URL: https://issues.apache.org/jira/browse/HBASE-23022 Project: HBase Issue Type: Bug Components: website Reporter: Sean Busbey Assignee: Nick Dimiduk Noticed this while working on some automation. We're https everywhere else in this page, just not this link. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] busbey commented on issue #622: Downloads page archive link should be https
busbey commented on issue #622: Downloads page archive link should be https URL: https://github.com/apache/hbase/pull/622#issuecomment-531441356 I missed that this didn't include a jira key in the commit message. I'll repush with one. next time please include it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22749) Distributed MOB compactions
[
https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929651#comment-16929651
]
HBase QA commented on HBASE-22749:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 9 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
30s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
56s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
42s{color} | {color:red} hbase-server: The patch generated 48 new + 239
unchanged - 42 fixed = 287 total (was 281) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
47s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 47s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
40s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
51s{color} | {color:red} hbase-server generated 5 new + 0 unchanged - 0 fixed =
5 total (was 0) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}300m 11s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}371m 38s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.hbase.master.MobFileCompactionChore.chore() At
MobFileCompactionChore.java:is not thrown in
org.apache.hadoop.hbase.master.MobFileCompactionChore.chore() At
MobFileCompactionChore.java:[line 106] |
| | org.apache.hadoop.hbase.mob.FileSelection defines
compareTo(FileSelection) and uses Object.equals() At
DefaultMobStoreCompactor.java:Object.equals() At
DefaultMobStoreCompactor.java:[lines 614-619] |
| | org.apache.hadoop.hbase.mob.Generation defines compareTo(Generation) and
uses Object.equals() At DefaultMobStoreCompactor.java:Object.equals() At
DefaultMobStoreCompactor.java:[lines 789-794] |
| | Unused
[GitHub] [hbase] Apache-HBase commented on issue #623: HBASE-22749: Distributed MOB compactions
Apache-HBase commented on issue #623: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/623#issuecomment-531440787 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 2m 24s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 9 new or modified test files. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 6m 46s | master passed | | :green_heart: | compile | 1m 4s | master passed | | :green_heart: | checkstyle | 1m 43s | master passed | | :green_heart: | shadedjars | 5m 30s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 43s | master passed | | :blue_heart: | spotbugs | 4m 56s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 53s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 6m 10s | the patch passed | | :green_heart: | compile | 1m 9s | the patch passed | | :green_heart: | javac | 1m 9s | the patch passed | | :broken_heart: | checkstyle | 1m 42s | hbase-server: The patch generated 48 new + 239 unchanged - 42 fixed = 287 total (was 281) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 47s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 19m 47s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :broken_heart: | javadoc | 0m 40s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | :broken_heart: | findbugs | 4m 51s | hbase-server generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) | ||| _ Other Tests _ | | :broken_heart: | unit | 300m 11s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. | | | | 371m 38s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Exception is caught when Exception is not thrown in org.apache.hadoop.hbase.master.MobFileCompactionChore.chore() At MobFileCompactionChore.java:is not thrown in org.apache.hadoop.hbase.master.MobFileCompactionChore.chore() At MobFileCompactionChore.java:[line 106] | | | org.apache.hadoop.hbase.mob.FileSelection defines compareTo(FileSelection) and uses Object.equals() At DefaultMobStoreCompactor.java:Object.equals() At DefaultMobStoreCompactor.java:[lines 614-619] | | | org.apache.hadoop.hbase.mob.Generation defines compareTo(Generation) and uses Object.equals() At DefaultMobStoreCompactor.java:Object.equals() At DefaultMobStoreCompactor.java:[lines 789-794] | | | Unused field:DefaultMobStoreCompactor.java | | | org.apache.hadoop.hbase.mob.Generations.build(List, Configuration) makes inefficient use of keySet iterator instead of entrySet iterator At DefaultMobStoreCompactor.java:of keySet iterator instead of entrySet iterator At DefaultMobStoreCompactor.java:[line 677] | | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.regionserver.TestMobStoreCompaction | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient | | | hadoop.hbase.util.TestHBaseFsckMOB | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.replication.TestReplicationSmallTests | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-623/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/623 | | JIRA Issue | HBASE-22749 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3269e41ac01f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-623/out/precommit/personality/provided.sh | | git revision |
[jira] [Commented] (HBASE-23019) Handle --skip-errorprone on branch-1
[ https://issues.apache.org/jira/browse/HBASE-23019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929650#comment-16929650 ] Sean Busbey commented on HBASE-23019: - bq. Sean Busbey have you ran into this previously? I haven't. it's been recent, but I've only been paying attention to builds specific to there recently. if we can install shellcheck without building it we should do that. > Handle --skip-errorprone on branch-1 > > > Key: HBASE-23019 > URL: https://issues.apache.org/jira/browse/HBASE-23019 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.5.0, 1.3.6, 1.4.11 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-23019.branch-1.001.patch, > HBASE-23019.branch-1.002.patch > > > Precommit builds fail on branch-1 with "Unprocessed flag(s): > --skip-errorprone". -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22027) Move non-MR parts of TokenUtil into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-22027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929647#comment-16929647 ] Sean Busbey commented on HBASE-22027: - link to the PR please? I would like to review impact on what jars get what classes prior to merge. what's the expected release note? > Move non-MR parts of TokenUtil into hbase-client > > > Key: HBASE-22027 > URL: https://issues.apache.org/jira/browse/HBASE-22027 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.1.3 >Reporter: Stig Rohde Døssing >Assignee: Stig Rohde Døssing >Priority: Major > Attachments: > 0001-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch, > 0001-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch, > 0002-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch > > > HBASE-14208 moved TokenUtil from hbase-client to hbase-server. > I have a project depending on hbase-client 1.4.4, which I'd like to upgrade > to 2.1.3. My project uses TokenUtil (specifically obtainAndCacheToken), which > is included in hbase-client 1.4.4. At the same time I also have a dependency > on Jetty 9.4, which is incompatible with the current version used by Hadoop. > I can fix this for hbase-client by using hbase-shaded-client instead, since > Jetty is shaded in this jar, but TokenUtil is only present in hbase-server as > of 2.0.0. Since there is no hbase-shaded-server, I can't use TokenUtil and > Jetty 9.4 at the same time. > TokenUtil can be split into server-only parts, and a client relevant part > that can go back to hbase-client. The TokenUtil in hbase-server can retain > the moved methods, and delegate to the util in hbase-client if backward > compatibility is a concern. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22027) Move non-MR parts of TokenUtil into hbase-client
[
https://issues.apache.org/jira/browse/HBASE-22027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929626#comment-16929626
]
HBase QA commented on HBASE-22027:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HBASE-22027 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-22027 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12962079/0002-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/903/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.0 https://yetus.apache.org |
This message was automatically generated.
> Move non-MR parts of TokenUtil into hbase-client
>
>
> Key: HBASE-22027
> URL: https://issues.apache.org/jira/browse/HBASE-22027
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.1.3
>Reporter: Stig Rohde Døssing
>Assignee: Stig Rohde Døssing
>Priority: Major
> Attachments:
> 0001-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch,
> 0001-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch,
> 0002-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch
>
>
> HBASE-14208 moved TokenUtil from hbase-client to hbase-server.
> I have a project depending on hbase-client 1.4.4, which I'd like to upgrade
> to 2.1.3. My project uses TokenUtil (specifically obtainAndCacheToken), which
> is included in hbase-client 1.4.4. At the same time I also have a dependency
> on Jetty 9.4, which is incompatible with the current version used by Hadoop.
> I can fix this for hbase-client by using hbase-shaded-client instead, since
> Jetty is shaded in this jar, but TokenUtil is only present in hbase-server as
> of 2.0.0. Since there is no hbase-shaded-server, I can't use TokenUtil and
> Jetty 9.4 at the same time.
> TokenUtil can be split into server-only parts, and a client relevant part
> that can go back to hbase-client. The TokenUtil in hbase-server can retain
> the moved methods, and delegate to the util in hbase-client if backward
> compatibility is a concern.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22027) Move non-MR parts of TokenUtil into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-22027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929625#comment-16929625 ] stack commented on HBASE-22027: --- I added you as a contributor [~Srdo] > Move non-MR parts of TokenUtil into hbase-client > > > Key: HBASE-22027 > URL: https://issues.apache.org/jira/browse/HBASE-22027 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.1.3 >Reporter: Stig Rohde Døssing >Priority: Major > Attachments: > 0001-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch, > 0001-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch, > 0002-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch > > > HBASE-14208 moved TokenUtil from hbase-client to hbase-server. > I have a project depending on hbase-client 1.4.4, which I'd like to upgrade > to 2.1.3. My project uses TokenUtil (specifically obtainAndCacheToken), which > is included in hbase-client 1.4.4. At the same time I also have a dependency > on Jetty 9.4, which is incompatible with the current version used by Hadoop. > I can fix this for hbase-client by using hbase-shaded-client instead, since > Jetty is shaded in this jar, but TokenUtil is only present in hbase-server as > of 2.0.0. Since there is no hbase-shaded-server, I can't use TokenUtil and > Jetty 9.4 at the same time. > TokenUtil can be split into server-only parts, and a client relevant part > that can go back to hbase-client. The TokenUtil in hbase-server can retain > the moved methods, and delegate to the util in hbase-client if backward > compatibility is a concern. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (HBASE-22027) Move non-MR parts of TokenUtil into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-22027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack reassigned HBASE-22027: - Assignee: Stig Rohde Døssing > Move non-MR parts of TokenUtil into hbase-client > > > Key: HBASE-22027 > URL: https://issues.apache.org/jira/browse/HBASE-22027 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.1.3 >Reporter: Stig Rohde Døssing >Assignee: Stig Rohde Døssing >Priority: Major > Attachments: > 0001-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch, > 0001-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch, > 0002-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch > > > HBASE-14208 moved TokenUtil from hbase-client to hbase-server. > I have a project depending on hbase-client 1.4.4, which I'd like to upgrade > to 2.1.3. My project uses TokenUtil (specifically obtainAndCacheToken), which > is included in hbase-client 1.4.4. At the same time I also have a dependency > on Jetty 9.4, which is incompatible with the current version used by Hadoop. > I can fix this for hbase-client by using hbase-shaded-client instead, since > Jetty is shaded in this jar, but TokenUtil is only present in hbase-server as > of 2.0.0. Since there is no hbase-shaded-server, I can't use TokenUtil and > Jetty 9.4 at the same time. > TokenUtil can be split into server-only parts, and a client relevant part > that can go back to hbase-client. The TokenUtil in hbase-server can retain > the moved methods, and delegate to the util in hbase-client if backward > compatibility is a concern. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22027) Move non-MR parts of TokenUtil into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-22027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929624#comment-16929624 ] stack commented on HBASE-22027: --- Sorry [~Srdo] We dropped this one. Patch looks good but for a minor item I noted up on the PR. Make a comment on why you removed the method and I'll commit this and pull it back to hbase-2.1.x. Thanks. > Move non-MR parts of TokenUtil into hbase-client > > > Key: HBASE-22027 > URL: https://issues.apache.org/jira/browse/HBASE-22027 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.1.3 >Reporter: Stig Rohde Døssing >Priority: Major > Attachments: > 0001-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch, > 0001-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch, > 0002-HBase-22027-Split-non-MR-related-parts-of-TokenUtil-.patch > > > HBASE-14208 moved TokenUtil from hbase-client to hbase-server. > I have a project depending on hbase-client 1.4.4, which I'd like to upgrade > to 2.1.3. My project uses TokenUtil (specifically obtainAndCacheToken), which > is included in hbase-client 1.4.4. At the same time I also have a dependency > on Jetty 9.4, which is incompatible with the current version used by Hadoop. > I can fix this for hbase-client by using hbase-shaded-client instead, since > Jetty is shaded in this jar, but TokenUtil is only present in hbase-server as > of 2.0.0. Since there is no hbase-shaded-server, I can't use TokenUtil and > Jetty 9.4 at the same time. > TokenUtil can be split into server-only parts, and a client relevant part > that can go back to hbase-client. The TokenUtil in hbase-server can retain > the moved methods, and delegate to the util in hbase-client if backward > compatibility is a concern. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-23019) Handle --skip-errorprone on branch-1
[
https://issues.apache.org/jira/browse/HBASE-23019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929604#comment-16929604
]
Hudson commented on HBASE-23019:
Results for branch branch-1
[build #1063 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1063/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1063//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1063//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1063//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Handle --skip-errorprone on branch-1
>
>
> Key: HBASE-23019
> URL: https://issues.apache.org/jira/browse/HBASE-23019
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-23019.branch-1.001.patch,
> HBASE-23019.branch-1.002.patch
>
>
> Precommit builds fail on branch-1 with "Unprocessed flag(s):
> --skip-errorprone".
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Assigned] (HBASE-22660) Probabilistic end to end tracking of cross cluster replication latency
[ https://issues.apache.org/jira/browse/HBASE-22660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang reassigned HBASE-22660: --- Assignee: Xu Cang > Probabilistic end to end tracking of cross cluster replication latency > -- > > Key: HBASE-22660 > URL: https://issues.apache.org/jira/browse/HBASE-22660 > Project: HBase > Issue Type: New Feature >Reporter: Andrew Purtell >Assignee: Xu Cang >Priority: Major > > ageOfLastShippedOp tracks replication latency forward from the point where a > source process tailing a WAL has found an edit to ship. This is not an end to > end measure. > To achieve a holistic end to end measure we should have an active process > that periodically injects sentinel values at commit time adjacent to the > WALedits carrying application data at the source and records when they are > finally processed at the sink, using a timestamp embedded in the sentinel to > measure true end to end latency for the adjacent commit. This could be done > for a configurable (and small) percentage of commits so would give a > probabilistic measure with confidence controlled by sample rate. It should be > done this way rather than by passively sampling cell timestamps because cell > timestamps can be set by the user and may not correspond to wall clock time. > We could introduce a new type of synthetic WALedit, a new global metric, and > because the adjacent commit from which we build the sentinel contains table > information we could track that too and add a per table metric. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-23019) Handle --skip-errorprone on branch-1
[
https://issues.apache.org/jira/browse/HBASE-23019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929559#comment-16929559
]
Hudson commented on HBASE-23019:
Results for branch branch-1.4
[build #1010 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1010/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1010//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1010//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1010//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Handle --skip-errorprone on branch-1
>
>
> Key: HBASE-23019
> URL: https://issues.apache.org/jira/browse/HBASE-23019
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-23019.branch-1.001.patch,
> HBASE-23019.branch-1.002.patch
>
>
> Precommit builds fail on branch-1 with "Unprocessed flag(s):
> --skip-errorprone".
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22956) [HBCK2/hbase-operator-tools] Make first release, 1.0.0
[ https://issues.apache.org/jira/browse/HBASE-22956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929549#comment-16929549 ] stack commented on HBASE-22956: --- Did compare of git to JIRA manually. hbase-operator-tools is ready to go [~psomogyi] if you want to run the release sir (IMO). See what you think. To make the RC, hopefully you just type ./dev-support/create-release/do-release-docker.sh (after ensuring a local docker is up), answer a few questions, and then a release candidate pops out the other end (~40minutes). Shout if doesn't make sense. > [HBCK2/hbase-operator-tools] Make first release, 1.0.0 > -- > > Key: HBASE-22956 > URL: https://issues.apache.org/jira/browse/HBASE-22956 > Project: HBase > Issue Type: Bug > Components: hbck2 >Reporter: stack >Priority: Major > > Make our first release of hbck2/hbase-operator-tools. > First release should have the coverage hbck1 had at least. When the parent > for this issue is done, we'll be at hbck1+. Let us release then (week or > two?). > A release will help operators who have been struggling having to build hbck2 > against different hbase versions. The release should be a "fat > jar"/completely contained with all dependency satisfied so operator can just > fire up hbck2 w/o having to build against an hbase or provide some magic mix > of jars to satisfy hbck2 tool needs. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (HBASE-23021) [hbase-operator-tools] README edits in prep for release
[ https://issues.apache.org/jira/browse/HBASE-23021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-23021. --- Fix Version/s: hbase-operator-tools-1.0.0 Hadoop Flags: Reviewed Assignee: stack Resolution: Fixed Pushed from local checkout and closed PR. Thanks for review [~busbey] > [hbase-operator-tools] README edits in prep for release > --- > > Key: HBASE-23021 > URL: https://issues.apache.org/jira/browse/HBASE-23021 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: hbase-operator-tools-1.0.0 > > > Did an edit of the READMEs to get us ready for 1.0.0 release. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work started] (HBASE-23012) Release 1.3.6
[ https://issues.apache.org/jira/browse/HBASE-23012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23012 started by Sakthi. -- > Release 1.3.6 > - > > Key: HBASE-23012 > URL: https://issues.apache.org/jira/browse/HBASE-23012 > Project: HBase > Issue Type: Task > Components: community >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Fix For: 1.3.6 > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase-operator-tools] saintstack commented on issue #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release
saintstack commented on issue #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release URL: https://github.com/apache/hbase-operator-tools/pull/32#issuecomment-531397575 It is failing because I just pushed locally instead Thanks for review @busbey This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack closed pull request #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release
saintstack closed pull request #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release URL: https://github.com/apache/hbase-operator-tools/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] busbey commented on issue #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release
busbey commented on issue #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release URL: https://github.com/apache/hbase-operator-tools/pull/32#issuecomment-531397361 For some reason merging this is failing without an explanation. Will check again when at a laptop. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts
saintstack commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts URL: https://github.com/apache/hbase-operator-tools/pull/29#issuecomment-531397025 Thanks @busbey This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] busbey closed pull request #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts
busbey closed pull request #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts URL: https://github.com/apache/hbase-operator-tools/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk merged pull request #622: Downloads page archive link should be https
ndimiduk merged pull request #622: Downloads page archive link should be https URL: https://github.com/apache/hbase/pull/622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22956) [HBCK2/hbase-operator-tools] Make first release, 1.0.0
[ https://issues.apache.org/jira/browse/HBASE-22956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22956: -- Fix Version/s: (was: hbase-operator-tools-1.0.0) > [HBCK2/hbase-operator-tools] Make first release, 1.0.0 > -- > > Key: HBASE-22956 > URL: https://issues.apache.org/jira/browse/HBASE-22956 > Project: HBase > Issue Type: Bug > Components: hbck2 >Reporter: stack >Priority: Major > > Make our first release of hbck2/hbase-operator-tools. > First release should have the coverage hbck1 had at least. When the parent > for this issue is done, we'll be at hbck1+. Let us release then (week or > two?). > A release will help operators who have been struggling having to build hbck2 > against different hbase versions. The release should be a "fat > jar"/completely contained with all dependency satisfied so operator can just > fire up hbck2 w/o having to build against an hbase or provide some magic mix > of jars to satisfy hbck2 tool needs. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (HBASE-23003) [HBCK2/hbase-operator-tools] Release-making scripts
[ https://issues.apache.org/jira/browse/HBASE-23003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-23003. --- Fix Version/s: hbase-operator-tools-1.0.0 Hadoop Flags: Reviewed Assignee: stack Resolution: Fixed Pushed this. Thanks for reviews [~psomogyi]. > [HBCK2/hbase-operator-tools] Release-making scripts > --- > > Key: HBASE-23003 > URL: https://issues.apache.org/jira/browse/HBASE-23003 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: hbase-operator-tools-1.0.0 > > Attachments: > 0001-HBASE-23003-HBCK2-hbase-operator-tools-Release-makin.patch > > > Make some scripts for creating hbase-operator-tools releases so its easy to > do and not subject to vagaries of environment or RM's attention-to-detail (or > not). -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase-operator-tools] saintstack commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts
saintstack commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts URL: https://github.com/apache/hbase-operator-tools/pull/29#issuecomment-531392410 I merged this after doing a test run by pushing from local checkout (what is here was missing execute bit -- fixed locally). Will address any subsequent issues in new PR. Thanks for review @petersomogyi This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23019) Handle --skip-errorprone on branch-1
[
https://issues.apache.org/jira/browse/HBASE-23019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929536#comment-16929536
]
Hudson commented on HBASE-23019:
Results for branch branch-1.3
[build #968 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/968/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/968//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/968//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/968//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Handle --skip-errorprone on branch-1
>
>
> Key: HBASE-23019
> URL: https://issues.apache.org/jira/browse/HBASE-23019
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-23019.branch-1.001.patch,
> HBASE-23019.branch-1.002.patch
>
>
> Precommit builds fail on branch-1 with "Unprocessed flag(s):
> --skip-errorprone".
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22567) [HBCK2] Add new methods for dealing with missing regions in META while Master is online
[
https://issues.apache.org/jira/browse/HBASE-22567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-22567:
--
Fix Version/s: (was: 1.0.0)
hbase-operator-tools-1.0.0
> [HBCK2] Add new methods for dealing with missing regions in META while Master
> is online
> ---
>
> Key: HBASE-22567
> URL: https://issues.apache.org/jira/browse/HBASE-22567
> Project: HBase
> Issue Type: New Feature
> Components: hbck2
>Affects Versions: 0.16.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Labels: hbck2
> Fix For: hbase-operator-tools-1.0.0
>
>
> Following latest discussion on HBASE-21745, this proposes an hbck2 command
> that allows for inserting back regions missing in META that still have
> *regioninfo* available in HDFS. Although this is still an interactive and
> simpler version than the old _OfflineMetaRepair_, it still relies on hdfs
> state as the source of truth, and performs META updates mostly independently
> from Master (apart from requiring Meta table been online).
> For a more detailed explanation on this command behaviour, pasting _command
> usage_ text:
> {noformat}
> To be used for scenarios where some regions may be missing in META,
> but there's still a valid 'regioninfo' metadata file on HDFS.
> This is a lighter version of 'OfflineMetaRepair' tool commonly used for
> similar issues on 1.x release line.
> This command needs META to be online. For each table name passed as
> parameter, it performs a diff between regions available in META,
> against existing regions dirs on HDFS. Then, for region dirs with
> no matches in META, it reads regioninfo metadata file and
> re-creates given region in META. Regions are re-created in 'CLOSED'
> state at META table only, but not in Masters' cache, and are not
> assigned either. A rolling Masters restart, followed by a
> hbck2 'assigns' command with all re-inserted regions is required.
> This hbck2 'assigns' command is printed for user convenience.
> WARNING: To avoid potential region overlapping problems due to ongoing
> splits, this command disables given tables while re-inserting regions.
> An example adding missing regions for tables 'table_1' and 'table_2':
> $ HBCK2 addMissingRegionsInMeta table_1 table_2
> Returns hbck2 'assigns' command with all re-inserted regions.{noformat}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22984) [HBCK2] HBCKMetaTableAccessor.deleteFromMetaTable throwing java.lang.UnsupportedOperationException at runtime
[
https://issues.apache.org/jira/browse/HBASE-22984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-22984:
--
Fix Version/s: hbase-operator-tools-1.0.0
> [HBCK2] HBCKMetaTableAccessor.deleteFromMetaTable throwing
> java.lang.UnsupportedOperationException at runtime
> -
>
> Key: HBASE-22984
> URL: https://issues.apache.org/jira/browse/HBASE-22984
> Project: HBase
> Issue Type: Bug
> Components: hbck2
>Affects Versions: 0.16.0
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Labels: hbck2
> Fix For: hbase-operator-tools-1.0.0
>
>
> Came around this while converting some UTs from HBASE-22567 to use
> *HBCKMetaTableAccessor.* When calling
> *HBCKMetaTableAccessor.deleteRegionInfo,* I'm getting error as shown below,
> because list returned by _Arrays.asList_ apparently does not implement
> _delete_ method:
> {noformat}
> java.lang.UnsupportedOperationException
> at java.util.AbstractList.remove(AbstractList.java:161)
> at org.apache.hadoop.hbase.client.HTable.delete(HTable.java:522)
> at
> org.apache.hbase.HBCKMetaTableAccessor.deleteFromMetaTable(HBCKMetaTableAccessor.java:136)
> at
> org.apache.hbase.HBCKMetaTableAccessor.deleteRegionInfo(HBCKMetaTableAccessor.java:89)
> at
> org.apache.hbase.TestHBCK2.testReportMissingRegionsInMetaSpecificTblAndNsTblAlsoMissing(TestHBCK2.java:225)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22859) [HBCK2] Fix the orphan regions on filesystem
[ https://issues.apache.org/jira/browse/HBASE-22859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22859: -- Fix Version/s: hbase-operator-tools-1.0.0 > [HBCK2] Fix the orphan regions on filesystem > > > Key: HBASE-22859 > URL: https://issues.apache.org/jira/browse/HBASE-22859 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbck2 >Reporter: Guanghao Zhang >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, hbase-operator-tools-1.0.0, 2.2.2 > > Attachments: HBASE-22859.master.001.patch, > HBASE-22859.master.005.patch > > > Plan to add this feature to HBCK2 tool firstly. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline updated HBASE-22804: - Attachment: HBASE-22804.branch-1.010.patch > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Fix For: 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1, master > > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, > HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, > HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, > HBASE-22804.branch-1.009.patch, HBASE-22804.branch-1.010.patch, > HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, > HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, > HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, > HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, > HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, > HBASE-22804.master.005.patch, HBASE-22804.master.006.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (HBASE-22691) [hbase-operator-tools] Move Checkstyle suppression file to different location
[
https://issues.apache.org/jira/browse/HBASE-22691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack resolved HBASE-22691.
---
Fix Version/s: hbase-operator-tools-1.0.0
Resolution: Fixed
This was merged. Resolving.
commit cf92e611adff3b215dce0292912b8764082fd421
Author: Jan Hentschel
Date: Sun Jul 14 18:24:52 2019 +0200
HBASE-22691 Moved Checkstyle suppression file to a different location
Signed-off-by: Sean Busbey
> [hbase-operator-tools] Move Checkstyle suppression file to different location
> -
>
> Key: HBASE-22691
> URL: https://issues.apache.org/jira/browse/HBASE-22691
> Project: HBase
> Issue Type: Improvement
> Components: hbck2
>Affects Versions: hbase-operator-tools-1.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: hbase-operator-tools-1.0.0
>
>
> The Checkstyle suppression file in the {{hbase-operator-tools}} is currently
> defined in the {{dev-support}} directory. It should be moved to a different
> location.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-21322) Add a scheduleServerCrashProcedure() API to HbckService
[ https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21322: -- Fix Version/s: hbase-operator-tools-1.0.0 > Add a scheduleServerCrashProcedure() API to HbckService > --- > > Key: HBASE-21322 > URL: https://issues.apache.org/jira/browse/HBASE-21322 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2, hbase-operator-tools-1.0.0 > > Attachments: HBASE-21322.branch-2.1.001.patch, > HBASE-21322.branch-2.addendum.patch, HBASE-21322.master.001.patch, > HBASE-21322.master.002.patch, HBASE-21322.master.003.patch, > HBASE-21322.master.004.patch, HBASE-21322.master.005.patch, > HBASE-21322.master.006.patch, Screenshot from 2018-10-17 13-35-58.png, > Screenshot from 2018-10-17 13-38-41.png, Screenshot from 2018-10-17 > 13-47-06.png > > > According to my test, if one RS is down, then all procedure logs are deleted, > it will lead to that no ServerCrashProcedure is scheduled. And restarting > master cannot help. Thus we need to schedule a ServerCrashProcedure manually > to solve the problem. I plan to add a scheduleServerCrashProcedure() API to > HbckService, then add this API to HBCK2. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-21335) Change the default wait time of HBCK2 tool
[ https://issues.apache.org/jira/browse/HBASE-21335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21335: -- Fix Version/s: hbase-operator-tools-1.0.0 > Change the default wait time of HBCK2 tool > -- > > Key: HBASE-21335 > URL: https://issues.apache.org/jira/browse/HBASE-21335 > Project: HBase > Issue Type: Bug >Reporter: Jingyun Tian >Assignee: Jingyun Tian >Priority: Critical > Fix For: 3.0.0, 2.2.0, 2.1.1, 2.0.3, hbase-operator-tools-1.0.0 > > Attachments: > 0001-HBASE-21335-Change-the-default-wait-time-of-HBCK2-to.patch, > 0002-HBASE-21335-Change-the-default-wait-time-of-HBCK2-to.patch > > > Currently default wait time is 0 and I add a condition check before that wait > time should more than 0. Thus the default wait time should be set to a number > that more than 0. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline updated HBASE-22804: - Fix Version/s: 1.3.0 1.4.0 2.0.0 2.1.5 master 2.2.1 1.5.0 > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Fix For: 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1, master > > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, > HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, > HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, > HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch, > HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, > HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, > HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, > HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, > HBASE-22804.master.006.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-21317) [hbck2] Add version, version handling, and misc override to assigns/unassigns
[ https://issues.apache.org/jira/browse/HBASE-21317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21317: -- Fix Version/s: (was: 1.0.0) hbase-operator-tools-1.0.0 > [hbck2] Add version, version handling, and misc override to assigns/unassigns > - > > Key: HBASE-21317 > URL: https://issues.apache.org/jira/browse/HBASE-21317 > Project: HBase > Issue Type: Bug > Components: hbase-operator-tools, hbck2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: hbase-operator-tools-1.0.0 > > Attachments: > 0001-HBASE-21317-hbck2-Add-version-version-handling-and.patch > > > Miscellaneous additions to hbck2 over in the hbase-operator-tools project. > * Emit version > * Fail if going against an hbase that doesn't support hbck2. > * Add override to assigns and unassigns > * Have bypass match changing its force option to be override > * Add recursive to bypass so can pass a parent and it will go find all child > procedures. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-21210) Add bypassProcedure() API to HBCK2
[ https://issues.apache.org/jira/browse/HBASE-21210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-21210: -- Fix Version/s: (was: 2.1.1) hbase-operator-tools-1.0.0 > Add bypassProcedure() API to HBCK2 > -- > > Key: HBASE-21210 > URL: https://issues.apache.org/jira/browse/HBASE-21210 > Project: HBase > Issue Type: Sub-task > Components: hbase-operator-tools, hbck2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: hbase-operator-tools-1.0.0 > > > This JIRA is for adding bypassProcedure to HBCK2 over in > hbase-operator-tools. Depends on HBASE-21023 being completed first. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929527#comment-16929527 ] Peter Somogyi commented on HBASE-22804: --- Please set the Fix version based on where the commit landed. > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, > HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, > HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, > HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch, > HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, > HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, > HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, > HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, > HBASE-22804.master.006.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase-operator-tools] asf-ci commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts
asf-ci commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts URL: https://github.com/apache/hbase-operator-tools/pull/29#issuecomment-531386856 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/105/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts
saintstack commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts URL: https://github.com/apache/hbase-operator-tools/pull/29#issuecomment-531385770 New push addresses rat failure (ran rat to make sure it good this time). Addressed some more shellcheck. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline updated HBASE-22804: - Resolution: Fixed Status: Resolved (was: Patch Available) > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, > HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, > HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, > HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch, > HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, > HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, > HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, > HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, > HBASE-22804.master.006.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929520#comment-16929520 ] Caroline commented on HBASE-22804: -- [~psomogyi] we already committed this, since the tests passed for branch-1 when I made a PR on Github. Will mark this issue as resolved. Thanks! > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, > HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, > HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, > HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch, > HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, > HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, > HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, > HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, > HBASE-22804.master.006.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase-operator-tools] asf-ci commented on issue #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release
asf-ci commented on issue #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release URL: https://github.com/apache/hbase-operator-tools/pull/32#issuecomment-531382512 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/104/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23021) [hbase-operator-tools] README edits in prep for release
[ https://issues.apache.org/jira/browse/HBASE-23021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929513#comment-16929513 ] stack commented on HBASE-23021: --- Main changes: * Underline how hbck1 differs from hbck2 and the hbck2 philosophy of one-thing-at-a time and look elsewhere for what problem is and this is not a 'god' script that is going to fix all your cluster woes and cure cancer. * Make entry and section transitions more palatable. * Try to talk up repair process. Explain fix hbase:meta first and then everything else. Bulk up general rules. > [hbase-operator-tools] README edits in prep for release > --- > > Key: HBASE-23021 > URL: https://issues.apache.org/jira/browse/HBASE-23021 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Priority: Major > > Did an edit of the READMEs to get us ready for 1.0.0 release. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase-operator-tools] saintstack commented on issue #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release
saintstack commented on issue #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release URL: https://github.com/apache/hbase-operator-tools/pull/32#issuecomment-531379132 New push addresses what @busbey found (and checkstyle complaint). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22749) Distributed MOB compactions
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929511#comment-16929511 ] Vladimir Rodionov commented on HBASE-22749: --- PR has been created. > Distributed MOB compactions > > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: HBASE-22749-branch-2.2-v4.patch, > HBASE-22749-master-v1.patch, HBase-MOB-2.0-v1.pdf, HBase-MOB-2.0-v2.1.pdf, > HBase-MOB-2.0-v2.2.pdf, HBase-MOB-2.0-v2.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22749) Distributed MOB compactions
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-22749: -- Attachment: HBASE-22749-master-v1.patch > Distributed MOB compactions > > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: HBASE-22749-branch-2.2-v4.patch, > HBASE-22749-master-v1.patch, HBase-MOB-2.0-v1.pdf, HBase-MOB-2.0-v2.1.pdf, > HBase-MOB-2.0-v2.2.pdf, HBase-MOB-2.0-v2.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22749) Distributed MOB compactions
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-22749: -- Attachment: (was: HBASE-22749-branch-2.2-v3.patch) > Distributed MOB compactions > > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: HBASE-22749-branch-2.2-v4.patch, > HBASE-22749-master-v1.patch, HBase-MOB-2.0-v1.pdf, HBase-MOB-2.0-v2.1.pdf, > HBase-MOB-2.0-v2.2.pdf, HBase-MOB-2.0-v2.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] VladRodionov opened a new pull request #623: HBASE-22749: Distributed MOB compactions
VladRodionov opened a new pull request #623: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/623 Initial patch for HBASE-22748: Distributed MOB compactions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release
saintstack commented on a change in pull request #32: HBASE-23021
[hbase-operator-tools] README edits in prep for release
URL:
https://github.com/apache/hbase-operator-tools/pull/32#discussion_r324351802
##
File path: hbase-hbck2/README.md
##
@@ -519,38 +548,50 @@ command needs to be executed later, so copy and save it
for convenience.
2. For HBase versions prior to 2.3.0, after _addFsRegionsMissingInMeta_
finished successfully and output has been saved,
restart all running HBase Masters.
-3. Once Master's are restarted and META is already online (check if Web UI is
accessible), run
+3. Once Master's are restarted and hbase:meta is already online (check if Web
UI is accessible), run
_assigns_ command from _addFsRegionsMissingInMeta_ output saved per
instructions from #1.
-NOTE: If _namespace_ region is among the missing ones, you will need to add
_--skip_ flag at the
+NOTE: If _namespace_ region is among the missing regions, you will need to add
_--skip_ flag at the
beginning of _assigns_ command returned.
-
-Should a cluster suffer a catastrophic loss of the `hbase:meta` region, a
rough rebuild is possible following the below recipe.
-In outline: stop the cluster; run the _OfflineMetaRepair_ tool which reads
directories and metadata dropped into the filesystem making a best effort at
reconstructing a viable _hbase:meta_ table; restart your cluster; inject an
assign to bring the system namespace table online; and then finally, re-assign
userspace tables you'd like enabled (the rebuilt _hbase:meta_ creates a table
with all tables offline and no regions assigned).
+Should a cluster suffer a catastrophic loss of the `hbase:meta` table, a rough
rebuild is possible using the following recipe.
+In outline, we stop the cluster; run the _HBCK2_ _OfflineMetaRepair_ tool
which reads directories and metadata dropped into the filesystem
+making a best effort at reconstructing a viable _hbase:meta_ table; restart
your cluster; inject an assign to bring the system
+namespace table online; and then finally, re-assign userspace tables you'd
like enabled (the rebuilt _hbase:meta_ creates a table with all tables offline
and no regions assigned).
Detailed rebuild recipe
Stop the cluster.
Run the rebuild _hbase:meta_ command from _HBCK2_. This will move aside the
original _hbase:meta_ and put in place a newly rebuilt one. Below is an example
of how to run the tool. It adds the `-details` flag so the tool dumps info on
the regions its found in hdfs:
-```$
HBASE_CLASSPATH_PREFIX=~/checkouts/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
./bin/hbase org.apache.hbase.hbck1.OfflineMetaRepair -details```
+```
+$
HBASE_CLASSPATH_PREFIX=~/checkouts/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
./bin/hbase org.apache.hbase.hbck1.OfflineMetaRepair -details
+```
Start the cluster up. It won’t come up fully. It will be stuck because the
_namespace_ table is not online and there is no assign procedure in the
procedure store for this contingency. The hbase master log will show this
state. Here is an example of what it will log:
-```2019-07-10 18:30:51,090 WARN [master/localhost:16000:becomeActiveMaster]
master.HMaster:
hbase:namespace,,1562808216225.725a0fe6c2c869d3d0a9ed82bfa80fa3. is NOT online;
state={725a0fe6c2c869d3d0a9ed82bfa80fa3 state=CLOSED, ts=1562808619952,
server=null}; ServerCrashProcedures=false. Master startup cannot progress, in
holding-pattern until region onlined.```
+```
+2019-07-10 18:30:51,090 WARN [master/localhost:16000:becomeActiveMaster]
master.HMaster:
hbase:namespace,,1562808216225.725a0fe6c2c869d3d0a9ed82bfa80fa3. is NOT online;
state={725a0fe6c2c869d3d0a9ed82bfa80fa3 state=CLOSED, ts=1562808619952,
server=null}; ServerCrashProcedures=false. Master startup cannot progress, in
holding-pattern until region onlined.
+```
To assign the namespace table region, you cannot use the shell. If you use the
shell, it will fail with a `PleaseHoldException` because the master is not yet
up (it is waiting for the namepace table to come online before it declares
itself ‘up’). You have to use the `HBCK2` _assigns_ command. To assign, you
will need the namespace encoded name. It shows in the log quoted above: i.e.
_725a0fe6c2c869d3d0a9ed82bfa80fa3_ in this case. You will also have to pass the
-skip command to ‘skip’ the master version check (without it, your `HBCK2`
invocation will also elicit the above `PleaseHoldException` because the master
is not yet up). Here is an example adding an assign of the namespace table:
-```$
HBASE_CLASSPATH_PREFIX=~/checkouts/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
./bin/hbase org.apache.hbase.HBCK2 -skip assigns
725a0fe6c2c869d3d0a9ed82bfa80fa3```
+```
+$
HBASE_CLASSPATH_PREFIX=~/checkouts/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
./bin/hbase org.apache.hbase.HBCK2 -skip assigns
[GitHub] [hbase] Apache-HBase commented on issue #622: Downloads page archive link should be https
Apache-HBase commented on issue #622: Downloads page archive link should be https URL: https://github.com/apache/hbase/pull/622#issuecomment-531374436 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 5m 44s | master passed | | :green_heart: | mvnsite | 20m 31s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 6m 15s | the patch passed | | :green_heart: | mvnsite | 23m 47s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | ||| _ Other Tests _ | | :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 58m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-622/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/622 | | Optional Tests | dupname asflicense mvnsite xml | | uname | Linux 39c4dc3300dc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-622/out/precommit/personality/provided.sh | | git revision | master / 1dcc8ee50c | | Max. process+thread count | 96 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-622/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] asf-ci commented on issue #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release
asf-ci commented on issue #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release URL: https://github.com/apache/hbase-operator-tools/pull/32#issuecomment-531370346 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/103/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11
Apache-HBase commented on issue #593: HBASE-22927 Upgrade Mockito version for jdk11 URL: https://github.com/apache/hbase/pull/593#issuecomment-531370102 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 47s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 10s | master passed | | :green_heart: | compile | 3m 1s | master passed | | :green_heart: | shadedjars | 4m 42s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 3m 0s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 22s | Maven dependency ordering for patch | | :broken_heart: | mvninstall | 4m 52s | root in the patch failed. | | :broken_heart: | compile | 2m 53s | root in the patch failed. | | :broken_heart: | javac | 2m 53s | root in the patch failed. | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | :broken_heart: | shadedjars | 4m 31s | patch has 10 errors when building our shaded downstream artifacts. | | :broken_heart: | hadoopcheck | 4m 51s | The patch causes 10 errors with Hadoop v2.8.5. | | :broken_heart: | hadoopcheck | 9m 56s | The patch causes 10 errors with Hadoop v2.9.2. | | :broken_heart: | hadoopcheck | 15m 10s | The patch causes 10 errors with Hadoop v3.1.2. | | :broken_heart: | javadoc | 0m 13s | hbase-shaded-check-invariants in the patch failed. | | :broken_heart: | javadoc | 2m 43s | root in the patch failed. | ||| _ Other Tests _ | | :broken_heart: | unit | 237m 58s | root in the patch failed. | | :green_heart: | asflicense | 1m 26s | The patch does not generate ASF License warnings. | | | | 288m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/593 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux e3ddd761c737 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-593/out/precommit/personality/provided.sh | | git revision | master / 1dcc8ee50c | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-compile-root.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-javac-3.1.2.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-javadoc-hbase-shaded_hbase-shaded-check-invariants.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/testReport/ | | Max. process+thread count | 5475 (vs. ulimit of 1) | | modules | C: hbase-shaded/hbase-shaded-check-invariants . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | |
[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release
busbey commented on a change in pull request #32: HBASE-23021
[hbase-operator-tools] README edits in prep for release
URL:
https://github.com/apache/hbase-operator-tools/pull/32#discussion_r324342942
##
File path: hbase-hbck2/README.md
##
@@ -519,38 +548,50 @@ command needs to be executed later, so copy and save it
for convenience.
2. For HBase versions prior to 2.3.0, after _addFsRegionsMissingInMeta_
finished successfully and output has been saved,
restart all running HBase Masters.
-3. Once Master's are restarted and META is already online (check if Web UI is
accessible), run
+3. Once Master's are restarted and hbase:meta is already online (check if Web
UI is accessible), run
_assigns_ command from _addFsRegionsMissingInMeta_ output saved per
instructions from #1.
-NOTE: If _namespace_ region is among the missing ones, you will need to add
_--skip_ flag at the
+NOTE: If _namespace_ region is among the missing regions, you will need to add
_--skip_ flag at the
beginning of _assigns_ command returned.
-
-Should a cluster suffer a catastrophic loss of the `hbase:meta` region, a
rough rebuild is possible following the below recipe.
-In outline: stop the cluster; run the _OfflineMetaRepair_ tool which reads
directories and metadata dropped into the filesystem making a best effort at
reconstructing a viable _hbase:meta_ table; restart your cluster; inject an
assign to bring the system namespace table online; and then finally, re-assign
userspace tables you'd like enabled (the rebuilt _hbase:meta_ creates a table
with all tables offline and no regions assigned).
+Should a cluster suffer a catastrophic loss of the `hbase:meta` table, a rough
rebuild is possible using the following recipe.
+In outline, we stop the cluster; run the _HBCK2_ _OfflineMetaRepair_ tool
which reads directories and metadata dropped into the filesystem
+making a best effort at reconstructing a viable _hbase:meta_ table; restart
your cluster; inject an assign to bring the system
+namespace table online; and then finally, re-assign userspace tables you'd
like enabled (the rebuilt _hbase:meta_ creates a table with all tables offline
and no regions assigned).
Detailed rebuild recipe
Stop the cluster.
Run the rebuild _hbase:meta_ command from _HBCK2_. This will move aside the
original _hbase:meta_ and put in place a newly rebuilt one. Below is an example
of how to run the tool. It adds the `-details` flag so the tool dumps info on
the regions its found in hdfs:
-```$
HBASE_CLASSPATH_PREFIX=~/checkouts/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
./bin/hbase org.apache.hbase.hbck1.OfflineMetaRepair -details```
+```
+$
HBASE_CLASSPATH_PREFIX=~/checkouts/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
./bin/hbase org.apache.hbase.hbck1.OfflineMetaRepair -details
+```
Start the cluster up. It won’t come up fully. It will be stuck because the
_namespace_ table is not online and there is no assign procedure in the
procedure store for this contingency. The hbase master log will show this
state. Here is an example of what it will log:
-```2019-07-10 18:30:51,090 WARN [master/localhost:16000:becomeActiveMaster]
master.HMaster:
hbase:namespace,,1562808216225.725a0fe6c2c869d3d0a9ed82bfa80fa3. is NOT online;
state={725a0fe6c2c869d3d0a9ed82bfa80fa3 state=CLOSED, ts=1562808619952,
server=null}; ServerCrashProcedures=false. Master startup cannot progress, in
holding-pattern until region onlined.```
+```
+2019-07-10 18:30:51,090 WARN [master/localhost:16000:becomeActiveMaster]
master.HMaster:
hbase:namespace,,1562808216225.725a0fe6c2c869d3d0a9ed82bfa80fa3. is NOT online;
state={725a0fe6c2c869d3d0a9ed82bfa80fa3 state=CLOSED, ts=1562808619952,
server=null}; ServerCrashProcedures=false. Master startup cannot progress, in
holding-pattern until region onlined.
+```
To assign the namespace table region, you cannot use the shell. If you use the
shell, it will fail with a `PleaseHoldException` because the master is not yet
up (it is waiting for the namepace table to come online before it declares
itself ‘up’). You have to use the `HBCK2` _assigns_ command. To assign, you
will need the namespace encoded name. It shows in the log quoted above: i.e.
_725a0fe6c2c869d3d0a9ed82bfa80fa3_ in this case. You will also have to pass the
-skip command to ‘skip’ the master version check (without it, your `HBCK2`
invocation will also elicit the above `PleaseHoldException` because the master
is not yet up). Here is an example adding an assign of the namespace table:
-```$
HBASE_CLASSPATH_PREFIX=~/checkouts/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
./bin/hbase org.apache.hbase.HBCK2 -skip assigns
725a0fe6c2c869d3d0a9ed82bfa80fa3```
+```
+$
HBASE_CLASSPATH_PREFIX=~/checkouts/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar
./bin/hbase org.apache.hbase.HBCK2 -skip assigns
[GitHub] [hbase-operator-tools] saintstack opened a new pull request #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release
saintstack opened a new pull request #32: HBASE-23021 [hbase-operator-tools] README edits in prep for release URL: https://github.com/apache/hbase-operator-tools/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23021) [hbase-operator-tools] README edits in prep for release
stack created HBASE-23021: - Summary: [hbase-operator-tools] README edits in prep for release Key: HBASE-23021 URL: https://issues.apache.org/jira/browse/HBASE-23021 Project: HBase Issue Type: Sub-task Reporter: stack Did an edit of the READMEs to get us ready for 1.0.0 release. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] ndimiduk opened a new pull request #622: Downloads page archive link should be https
ndimiduk opened a new pull request #622: Downloads page archive link should be https URL: https://github.com/apache/hbase/pull/622 Noticed this while working on some automation. We're https everywhere else in this page, just not this link. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23020) Operations docs for HBase website
Sean Busbey created HBASE-23020: --- Summary: Operations docs for HBase website Key: HBASE-23020 URL: https://issues.apache.org/jira/browse/HBASE-23020 Project: HBase Issue Type: Umbrella Components: hbase-operator-tools, hbck2, Operability, website Reporter: Sean Busbey Assignee: Sean Busbey Basics so far: * Won't be in the ref guide * Source as markdown * Source in hbase-operator-tools repo * Published on website as an "operations" menu item under our top level documentation menu. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929455#comment-16929455 ] Peter Somogyi commented on HBASE-22804: --- [~caroliney14] can you attach a rebased patch? The --skip-errorprone issue should be solved now. > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, > HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, > HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, > HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch, > HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, > HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, > HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, > HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, > HBASE-22804.master.006.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929454#comment-16929454
]
HBase QA commented on HBASE-22804:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 10s{color}
| {color:red} HBASE-22804 does not apply to branch-1. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-22804 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12980294/HBASE-22804.branch-1.009.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/902/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.0 https://yetus.apache.org |
This message was automatically generated.
> Provide an API to get list of successful regions and total expected regions
> in Canary
> -
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
> Issue Type: Improvement
> Components: canary
>Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>Reporter: Caroline
>Assignee: Caroline
>Priority: Minor
> Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch,
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch,
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch,
> HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch,
> HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch,
> HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch,
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch,
> HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch,
> HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch,
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch,
> HBASE-22804.master.004.patch, HBASE-22804.master.005.patch,
> HBASE-22804.master.006.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs.
> Providing an API to get the list of successes, as well as total number of
> expected regions, will make it easier to get a more accurate availability
> estimate.
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-23019) Handle --skip-errorprone on branch-1
[ https://issues.apache.org/jira/browse/HBASE-23019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929453#comment-16929453 ] Hudson commented on HBASE-23019: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #640 (See [https://builds.apache.org/job/HBase-1.3-IT/640/]) HBASE-23019 Handle --skip-errorprone on branch-1 (#620) (psomogyi: rev 26d4e1b817ef2c1057e958439a95288762189c77) * (edit) dev-support/hbase-personality.sh > Handle --skip-errorprone on branch-1 > > > Key: HBASE-23019 > URL: https://issues.apache.org/jira/browse/HBASE-23019 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.5.0, 1.3.6, 1.4.11 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-23019.branch-1.001.patch, > HBASE-23019.branch-1.002.patch > > > Precommit builds fail on branch-1 with "Unprocessed flag(s): > --skip-errorprone". -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-22804: -- Attachment: HBASE-22804.branch-1.009.patch > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, > HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, > HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, > HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch, > HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, > HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, > HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, > HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, > HBASE-22804.master.006.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929445#comment-16929445 ] Peter Somogyi commented on HBASE-22804: --- Reattached patch. > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, > HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, > HBASE-22804.branch-1.008.patch, HBASE-22804.branch-1.009.patch, > HBASE-22804.branch-1.009.patch, HBASE-22804.branch-2.001.patch, > HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, > HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, > HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, > HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, > HBASE-22804.master.006.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-23019) Handle --skip-errorprone on branch-1
[ https://issues.apache.org/jira/browse/HBASE-23019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-23019: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed PR to branch-1 and branch-1.4. Committed a modified patch to branch-1.3 because errorProne profile does not exist there. > Handle --skip-errorprone on branch-1 > > > Key: HBASE-23019 > URL: https://issues.apache.org/jira/browse/HBASE-23019 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 1.5.0, 1.3.6, 1.4.11 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-23019.branch-1.001.patch, > HBASE-23019.branch-1.002.patch > > > Precommit builds fail on branch-1 with "Unprocessed flag(s): > --skip-errorprone". -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] petersomogyi merged pull request #620: HBASE-23019 Handle --skip-errorprone on branch-1
petersomogyi merged pull request #620: HBASE-23019 Handle --skip-errorprone on branch-1 URL: https://github.com/apache/hbase/pull/620 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] petersomogyi commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts
petersomogyi commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts URL: https://github.com/apache/hbase-operator-tools/pull/29#issuecomment-531340692 Looks like ASF license check fails on dev-support/create-release/vote.tmpl This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
Apache-HBase commented on issue #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly. URL: https://github.com/apache/hbase/pull/621#issuecomment-531340137 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 42s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :blue_heart: | shelldocs | 0m 0s | Shelldocs was not available. | | :blue_heart: | hadolint | 0m 0s | hadolint was not available. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-1 Compile Tests _ | | :blue_heart: | mvndep | 6m 6s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 17s | Maven dependency ordering for patch | | :broken_heart: | shellcheck | 0m 0s | The patch generated 6 new + 37 unchanged - 0 fixed = 43 total (was 37) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | :blue_heart: | asflicense | 0m 0s | ASF License check generated no output? | | | | 8m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-621/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/621 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint | | uname | Linux 1798e139e50f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-621/out/precommit/personality/provided.sh | | git revision | branch-1 / 72ea366 | | shellcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-621/2/artifact/out/diff-patch-shellcheck.txt | | Max. process+thread count | 42 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-621/2/console | | versions | git=1.9.1 maven=3.0.5 shellcheck=0.4.7 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
Apache-HBase commented on issue #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly. URL: https://github.com/apache/hbase/pull/621#issuecomment-531337776 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-621/2/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
busbey commented on issue #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly. URL: https://github.com/apache/hbase/pull/621#issuecomment-531337289 Okay I think I got all the places that have a multijdk list. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] xcangCRM commented on issue #620: HBASE-23019 Handle --skip-errorprone on branch-1
xcangCRM commented on issue #620: HBASE-23019 Handle --skip-errorprone on branch-1 URL: https://github.com/apache/hbase/pull/620#issuecomment-531332000 +1 and thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
busbey commented on a change in pull request #621: HBASE-22955 Properly set
jdk7 as JAVA_HOME for branches-1 precommit and nightly.
URL: https://github.com/apache/hbase/pull/621#discussion_r324299642
##
File path: dev-support/hbase_nightly_yetus.sh
##
@@ -40,6 +40,10 @@ if [[ -n "${MULTIJDK}" ]]; then
YETUS_ARGS=("--multijdkdirs=${MULTIJDK}" "${YETUS_ARGS[@]}")
fi
+# If we're doing docker, make sure we don't accidentally pollute the image
with a host java path
Review comment:
AFAICT only our general precommit job can run not in docker mode. We've only
needed that for debugging a few times.
It would be nice if the nightly bootstrap script didn't require docker
because running in docker on OSX is prohibitively slow.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
busbey commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly. URL: https://github.com/apache/hbase/pull/621#discussion_r324298774 ## File path: dev-support/hbase-personality.sh ## @@ -45,6 +45,23 @@ if ! declare -f "yetus_info" >/dev/null; then fi +# work around yetus overwriting JAVA_HOME from our docker image +function docker_do_env_adds Review comment: Also this is working around what I suspect is a bug in Yetus. Without this Yetus tells docker to unset any JAVA_HOME defined in the image if the host doesn't have JAVA_HOME set, which doesn't make sense to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
busbey commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly. URL: https://github.com/apache/hbase/pull/621#discussion_r324298074 ## File path: dev-support/hbase-personality.sh ## @@ -45,6 +45,23 @@ if ! declare -f "yetus_info" >/dev/null; then fi +# work around yetus overwriting JAVA_HOME from our docker image +function docker_do_env_adds Review comment: Can't do that because in the case of the general precommit job (the one that looks at patches on Jira) we don't know what branch we're targeting until Yetus is running. Without knowing what branch we're on we can't know which jdk to point to. Yetus will then take care of getting the Dockerfile specific to that branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
busbey commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly. URL: https://github.com/apache/hbase/pull/621#discussion_r324297954 ## File path: dev-support/docker/Dockerfile ## @@ -97,9 +94,7 @@ RUN apt-get -q install --no-install-recommends -y zulu-8 zulu-7 RUN update-alternatives --config java RUN update-alternatives --config javac RUN mv /usr/lib/jvm/java-7-openjdk-amd64 /usr/lib/jvm/moved.java-7-openjdk-amd64 -RUN mv /usr/lib/jvm/zulu-7-amd64 /usr/lib/jvm/java-7-openjdk-amd64 -RUN mv /usr/lib/jvm/zulu-8-amd64 /usr/lib/jvm/java-8-openjdk-amd64 - +ENV JAVA_HOME /usr/lib/jvm/zulu-7-amd64 Review comment: Can't do that because in the case of the general precommit job (the one that looks at patches on Jira) we don't know what branch we're targeting until Yetus is running. Without knowing what branch we're on we can't know which jdk to point to. Yetus will then take care of getting the Dockerfile specific to that branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
busbey commented on a change in pull request #621: HBASE-22955 Properly set
jdk7 as JAVA_HOME for branches-1 precommit and nightly.
URL: https://github.com/apache/hbase/pull/621#discussion_r324297068
##
File path: dev-support/Jenkinsfile
##
@@ -131,9 +131,8 @@ curl -L -o personality.sh "${env.PROJECT_PERSONALITY}"
// TODO does hadoopcheck need to be jdk specific?
// Should be things that work with multijdk
TESTS = 'all,-unit,-findbugs'
-// on branches that don't support jdk7, this will already be
JAVA_HOME, so we'll end up not
-// doing multijdk there.
-MULTIJDK = '/usr/lib/jvm/java-8-openjdk-amd64'
+// this is only elevant on branches-1. on branches with default
jdk8, the relevant jdk will be JAVA_HOME
+MULTIJDK = '/usr/lib/jvm/zulu-8-amd64'
Review comment:
That's an easy enough change. Will do.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] asf-ci commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts
asf-ci commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts URL: https://github.com/apache/hbase-operator-tools/pull/29#issuecomment-531305371 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/102/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts
saintstack commented on issue #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts URL: https://github.com/apache/hbase-operator-tools/pull/29#issuecomment-531303766 Addressed @petersomogyi 's feedback. Addressed some of the shellcheck complaint (not all!). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts
saintstack commented on a change in pull request #29: HBASE-23003
[HBCK2/hbase-operator-tools] Release-making scripts
URL:
https://github.com/apache/hbase-operator-tools/pull/29#discussion_r324266861
##
File path: dev-support/create-release/release-util.sh
##
@@ -0,0 +1,383 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+DRY_RUN=${DRY_RUN:-0}
+GPG="gpg --pinentry-mode loopback --no-tty --batch"
+YETUS_VERSION=0.9.0
+
+function error {
+ echo "$*"
+ exit 1
+}
+
+function read_config {
+ local PROMPT="$1"
+ local DEFAULT="$2"
+ local REPLY=
+
+ read -p "$PROMPT [$DEFAULT]: " REPLY
+ local RETVAL="${REPLY:-$DEFAULT}"
+ if [ -z "$RETVAL" ]; then
+error "$PROMPT is must be provided."
+ fi
+ echo "$RETVAL"
+}
+
+function parse_version {
+ grep -e '.*' | \
+head -n 2 | tail -n 1 | cut -d'>' -f2 | cut -d '<' -f1
+}
+
+function run_silent {
+ local BANNER="$1"
+ local LOG_FILE="$2"
+ shift 2
+
+ echo ""
+ echo "= $BANNER"
+ echo "Command: $@"
+ echo "Log file: $LOG_FILE"
+
+ "$@" 1>"$LOG_FILE" 2>&1
+
+ local EC=$?
+ if [ $EC != 0 ]; then
+echo "Command FAILED. Check full logs for details."
+tail "$LOG_FILE"
+exit $EC
+ fi
+}
+
+function fcreate_secure {
+ local FPATH="$1"
+ rm -f "$FPATH"
+ touch "$FPATH"
+ chmod 600 "$FPATH"
+}
+
+function check_for_tag {
+ curl -s --head --fail "$ASF_GITHUB_REPO/releases/tag/$1" > /dev/null
+}
+
+# API compare version.
+function get_api_diff_version {
+ local version=$1
+ local rev=$(echo "$version" | cut -d . -f 3)
+ local api_diff_tag
+ if [ $rev != 0 ]; then
+local short_version=$(echo "$version" | cut -d . -f 1-2)
+api_diff_tag="rel/${short_version}.$((rev - 1))"
+ else
+local major=$(echo "$version" | cut -d . -f 1)
+local minor=$(echo "$version" | cut -d . -f 2)
+if [ $minor != 0 ]; then
+ api_diff_tag="rel/${major}.$((minor - 1)).0)"
+else
+ api_diff_tag="rel/$((major - 1)).0.0)"
+fi
+ fi
+ api_diff_tag=$(read_config "api_diff_tag", "$api_diff_tag")
+ echo $api_diff_tag
+}
+
+# Get all branches that begin with 'branch-', the hbase convention for
+# release branches, sort them and then pop off the most recent.
+function get_release_info {
+ if [[ -z "${ASF_REPO}" ]]; then
+ASF_REPO="https://gitbox.apache.org/repos/asf/${PROJECT}.git;
+ fi
+ if [[ -z "${ASF_REPO_WEBUI}" ]]; then
+ASF_REPO_WEBUI="https://gitbox.apache.org/repos/asf?p=${PROJECT}.git;
+ fi
+ if [[ -z "${ASF_GITHUB_REPO}" ]]; then
+ASF_GITHUB_REPO="https://github.com/apache/${PROJECT};
+ fi
+ if [ -z "$GIT_BRANCH" ]; then
+# If no branch is specified, find out the latest branch from the repo.
+GIT_BRANCH=$(git ls-remote --heads "$ASF_REPO" |
+ grep refs/heads/branch- |
+ awk '{print $2}' |
+ sort -r |
+ head -n 1 |
+ cut -d/ -f3)
+ fi
+
+ export GIT_BRANCH=$(read_config "GIT_BRANCH" "$GIT_BRANCH")
+
+ # Find the current version for the branch.
+ local VERSION=$(curl -s
"$ASF_REPO_WEBUI;a=blob_plain;f=pom.xml;hb=refs/heads/$GIT_BRANCH" |
+parse_version)
+ echo "Current branch VERSION is $VERSION."
+
+ if [[ ! $VERSION =~ .*-SNAPSHOT ]]; then
+error "Not a SNAPSHOT version: $VERSION"
+ fi
+
+ NEXT_VERSION="$VERSION"
+ RELEASE_VERSION="${VERSION/-SNAPSHOT/}"
+ SHORT_VERSION=$(echo "$VERSION" | cut -d . -f 1-2)
+ local REV=$(echo "$VERSION" | cut -d . -f 3)
+
+ # Find out what RC is being prepared.
+ # - If the current version is "x.y.0", then this is RC0 of the "x.y.0"
release.
+ # - If not, need to check whether the previous version has been already
released or not.
+ # - If it has, then we're building RC0 of the current version.
+ # - If it has not, we're building the next RC of the previous version.
+ local RC_COUNT
+ if [ $REV != 0 ]; then
+local PREV_REL_REV=$((REV - 1))
+PREV_REL_TAG="rel/${SHORT_VERSION}.${PREV_REL_REV}"
+if check_for_tag "$PREV_REL_TAG"; then
+ RC_COUNT=0
+ REV=$((REV + 1))
+ NEXT_VERSION="${SHORT_VERSION}.${REV}-SNAPSHOT"
+else
+ RELEASE_VERSION="${SHORT_VERSION}.${PREV_REL_REV}"
+ RC_COUNT=$(git ls-remote --tags "$ASF_REPO" "${RELEASE_VERSION}RC*" | wc
-l)
+
[GitHub] [hbase] ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set
jdk7 as JAVA_HOME for branches-1 precommit and nightly.
URL: https://github.com/apache/hbase/pull/621#discussion_r324266066
##
File path: dev-support/hbase_nightly_yetus.sh
##
@@ -40,6 +40,10 @@ if [[ -n "${MULTIJDK}" ]]; then
YETUS_ARGS=("--multijdkdirs=${MULTIJDK}" "${YETUS_ARGS[@]}")
fi
+# If we're doing docker, make sure we don't accidentally pollute the image
with a host java path
+if [ -n "${JAVA_HOME}" ]; then
+ unset JAVA_HOME
+fi
if [[ -n "${SET_JAVA_HOME}" ]]; then
YETUS_ARGS=("--java-home=${SET_JAVA_HOME}" "${YETUS_ARGS[@]}")
Review comment:
Per earlier comments, I think we should always explicitly call `--java-home`
and never leave it up to sniffing around.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly. URL: https://github.com/apache/hbase/pull/621#discussion_r324264248 ## File path: dev-support/hbase-personality.sh ## @@ -45,6 +45,23 @@ if ! declare -f "yetus_info" >/dev/null; then fi +# work around yetus overwriting JAVA_HOME from our docker image +function docker_do_env_adds Review comment: I think this function can be skipped -- instead, pass `--java-home` as an invocation argument to `test-patch`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set
jdk7 as JAVA_HOME for branches-1 precommit and nightly.
URL: https://github.com/apache/hbase/pull/621#discussion_r324265255
##
File path: dev-support/Jenkinsfile
##
@@ -131,9 +131,8 @@ curl -L -o personality.sh "${env.PROJECT_PERSONALITY}"
// TODO does hadoopcheck need to be jdk specific?
// Should be things that work with multijdk
TESTS = 'all,-unit,-findbugs'
-// on branches that don't support jdk7, this will already be
JAVA_HOME, so we'll end up not
-// doing multijdk there.
-MULTIJDK = '/usr/lib/jvm/java-8-openjdk-amd64'
+// this is only elevant on branches-1. on branches with default
jdk8, the relevant jdk will be JAVA_HOME
+MULTIJDK = '/usr/lib/jvm/zulu-8-amd64'
Review comment:
This still trips me up. I'd rather see both (all) JDK's explicitly listed
out in the `--multijdkdirs` argument. It's explicitly clear, vs. "use this one
plus whatever I happens to resolve into `JAVA_HOME` later."
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly. URL: https://github.com/apache/hbase/pull/621#discussion_r324264609 ## File path: dev-support/docker/Dockerfile ## @@ -97,9 +94,7 @@ RUN apt-get -q install --no-install-recommends -y zulu-8 zulu-7 RUN update-alternatives --config java RUN update-alternatives --config javac RUN mv /usr/lib/jvm/java-7-openjdk-amd64 /usr/lib/jvm/moved.java-7-openjdk-amd64 -RUN mv /usr/lib/jvm/zulu-7-amd64 /usr/lib/jvm/java-7-openjdk-amd64 -RUN mv /usr/lib/jvm/zulu-8-amd64 /usr/lib/jvm/java-8-openjdk-amd64 - +ENV JAVA_HOME /usr/lib/jvm/zulu-7-amd64 Review comment: Rather than manage the variable in Docker, why not pass it in as `--java-home` ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set
jdk7 as JAVA_HOME for branches-1 precommit and nightly.
URL: https://github.com/apache/hbase/pull/621#discussion_r324265807
##
File path: dev-support/hbase_nightly_yetus.sh
##
@@ -40,6 +40,10 @@ if [[ -n "${MULTIJDK}" ]]; then
YETUS_ARGS=("--multijdkdirs=${MULTIJDK}" "${YETUS_ARGS[@]}")
fi
+# If we're doing docker, make sure we don't accidentally pollute the image
with a host java path
Review comment:
Does this ever not run in Docker mode? Can we settle on only running in
Docker mode? It keeps things simpler and tidy, IMHO. The possibility of host
environment values leaking in makes for bizarre bugs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set jdk7 as JAVA_HOME for branches-1 precommit and nightly.
ndimiduk commented on a change in pull request #621: HBASE-22955 Properly set
jdk7 as JAVA_HOME for branches-1 precommit and nightly.
URL: https://github.com/apache/hbase/pull/621#discussion_r324264734
##
File path: dev-support/Jenkinsfile_GitHub
##
@@ -110,6 +110,10 @@ pipeline {
if [[ "true" = "${DEBUG}" ]]; then
YETUS_ARGS+=("--debug")
fi
+# If we're doing docker, make sure we don't
accidentally pollute the image with a host java path
Review comment:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts
saintstack commented on a change in pull request #29: HBASE-23003
[HBCK2/hbase-operator-tools] Release-making scripts
URL:
https://github.com/apache/hbase-operator-tools/pull/29#discussion_r324266307
##
File path: dev-support/create-release/release-util.sh
##
@@ -0,0 +1,383 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+DRY_RUN=${DRY_RUN:-0}
+GPG="gpg --pinentry-mode loopback --no-tty --batch"
+YETUS_VERSION=0.9.0
+
+function error {
+ echo "$*"
+ exit 1
+}
+
+function read_config {
+ local PROMPT="$1"
+ local DEFAULT="$2"
+ local REPLY=
+
+ read -p "$PROMPT [$DEFAULT]: " REPLY
+ local RETVAL="${REPLY:-$DEFAULT}"
+ if [ -z "$RETVAL" ]; then
+error "$PROMPT is must be provided."
+ fi
+ echo "$RETVAL"
+}
+
+function parse_version {
+ grep -e '.*' | \
+head -n 2 | tail -n 1 | cut -d'>' -f2 | cut -d '<' -f1
+}
+
+function run_silent {
+ local BANNER="$1"
+ local LOG_FILE="$2"
+ shift 2
+
+ echo ""
+ echo "= $BANNER"
+ echo "Command: $@"
Review comment:
https://stackoverflow.com/questions/3008695/what-is-the-difference-between-and-in-bash
Did as suggested.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts
saintstack commented on a change in pull request #29: HBASE-23003 [HBCK2/hbase-operator-tools] Release-making scripts URL: https://github.com/apache/hbase-operator-tools/pull/29#discussion_r324265893 ## File path: dev-support/create-release/README.txt ## @@ -0,0 +1,61 @@ +Entrance script is _do-release-docker.sh_. We run the release Review comment: Added README.txt to the rat excludes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23002) [HBCK2/hbase-operator-tools] Create an assembly that builds an hbase-operator-tools tgz
[ https://issues.apache.org/jira/browse/HBASE-23002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-23002. --- Fix Version/s: hbase-operator-tools-1.0.0 Release Note: First cut at an assembly for hbase-operator-tools project. Assignee: stack Resolution: Fixed Merged PR. Thanks for review [~psomogyi] > [HBCK2/hbase-operator-tools] Create an assembly that builds an > hbase-operator-tools tgz > --- > > Key: HBASE-23002 > URL: https://issues.apache.org/jira/browse/HBASE-23002 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: hbase-operator-tools-1.0.0 > > > Was going to build a convenience binary tgz as part of the first release of > hbase-operator-tools. Not sure how just yet; best would be if it were a > fatjar with all dependencies but that'd be kinda insane at same time since > the tgz would be massive. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase-operator-tools] saintstack merged pull request #30: HBASE-23002 [HBCK2/hbase-operator-tools] Create an assembly that buil…
saintstack merged pull request #30: HBASE-23002 [HBCK2/hbase-operator-tools] Create an assembly that buil… URL: https://github.com/apache/hbase-operator-tools/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on issue #30: HBASE-23002 [HBCK2/hbase-operator-tools] Create an assembly that buil…
saintstack commented on issue #30: HBASE-23002 [HBCK2/hbase-operator-tools] Create an assembly that buil… URL: https://github.com/apache/hbase-operator-tools/pull/30#issuecomment-531294841 > I assume the content of changes and releasenotes will be updated on release creation time. Script fills in Release notes and Changes... yes sir. Thanks for review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #30: HBASE-23002 [HBCK2/hbase-operator-tools] Create an assembly that buil…
saintstack commented on a change in pull request #30: HBASE-23002
[HBCK2/hbase-operator-tools] Create an assembly that buil…
URL:
https://github.com/apache/hbase-operator-tools/pull/30#discussion_r324248706
##
File path: hbase-operator-tools-assembly/src/main/assembly/bin.xml
##
@@ -0,0 +1,97 @@
+
+http://maven.apache.org/ASSEMBLY/2.0.0;
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0
http://maven.apache.org/xsd/assembly-2.0.0.xsd;>
+
+ bin
+
+tar.gz
+
+ true
+
+
+
+
+ true
+
+
+org.apache.hbase.operator.tools:hbase-hbck2
+
+
+
+
+
+ src/**
+
+
+ README.md
+
+
+
+
+
+hbase-hbck2/
+false
+
+
+
+ org.slf4j:slf4j-api
+
+
+
+
+
+
+
+
+
+ ${project.parent.basedir}/LICENSE.txt
+ .
+ LICENSE.txt
+ unix
+
+
+ ${project.parent.basedir}/NOTICE.txt
+ .
+ NOTICE.txt
+ unix
+
+
+ ${project.parent.basedir}/RELEASENOTES.md
+ .
+ RELEASENOTES.md
+ unix
+
+
+ ${project.parent.basedir}/CHANGES.md
+ .
+ CHANGES.md
+ unix
+
+
+ ${project.parent.basedir}/README.md
+ .
+ README.md
Review comment:
One is the high-level README for the repo. The other is for hbase-hbck.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] saintstack commented on issue #30: HBASE-23002 [HBCK2/hbase-operator-tools] Create an assembly that buil…
saintstack commented on issue #30: HBASE-23002 [HBCK2/hbase-operator-tools] Create an assembly that buil… URL: https://github.com/apache/hbase-operator-tools/pull/30#issuecomment-531284286 Thanks for review Peter. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
