[GitHub] [hbase] langdamao commented on issue #554: HBASE-22887 Fix HFileOutputFormat2 writer roll
langdamao commented on issue #554: HBASE-22887 Fix HFileOutputFormat2 writer roll URL: https://github.com/apache/hbase/pull/554#issuecomment-532109859 > Patch LGTM. Can we have a unit test? Thanks. Sorry for miss the last message. Yes， I think [TestHFileOutputFormat2](https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java) fits this. Is this comprehensive enought for this patch? I don't know how to make it more strong for this patch. Could you give me some suggestions, please？ Thank you so much :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23036) Scan returns wrong data when version is used in CF
[
https://issues.apache.org/jira/browse/HBASE-23036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931163#comment-16931163
]
Wellington Chevreuil commented on HBASE-23036:
--
This looks like a duplicate of HBASE-21596.
> Scan returns wrong data when version is used in CF
> --
>
> Key: HBASE-23036
> URL: https://issues.apache.org/jira/browse/HBASE-23036
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.1, 2.1.1
>Reporter: Ashok shetty
>Priority: Major
>
> Created a table with 2 versions , after couple of delete operations Scan
> return stale data
> Steps followed
> 1. create 'Ashok', {NAME => 'cf', VERSIONS => 2}
> 2. put 'Ashok','r1','cf:cq','500'
> 3. flush 'Ashok'
> 4. put 'Ashok','r1','cf:cq','600'
> put 'Ashok','r1','cf:cq','700'
> put 'Ashok','r1','cf:cq','800'
> put 'Ashok','r1','cf:cq','900'
> 5. delete 'Ashok','r1','cf:cq',1568694586309
> At step5 we deleted value 700 by specifying Timestamp
> 6. flush 'Ashok'
> 7. delete 'Ashok','r1','cf:cq',156869459
> At step7 we deleted value 800 by specifying Timestamp
> 8. flush 'Ashok'
> 9. scan 'Ashok',{ VERSIONS => 10 }
> At step 9 scan retuned wrong data value 900 & 500
> Expected output 900 & 600
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] wchevreuil merged pull request #524: HBASE-22846 Internal Error 500 when Using HBASE REST API to Create Na…
wchevreuil merged pull request #524: HBASE-22846 Internal Error 500 when Using HBASE REST API to Create Na… URL: https://github.com/apache/hbase/pull/524 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23023) upgrade shellcheck used to test in nightly and precommit
[
https://issues.apache.org/jira/browse/HBASE-23023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931177#comment-16931177
]
Hudson commented on HBASE-23023:
Results for branch branch-2.2
[build #612 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/612/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/612//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/612//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/612//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> upgrade shellcheck used to test in nightly and precommit
>
>
> Key: HBASE-23023
> URL: https://issues.apache.org/jira/browse/HBASE-23023
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
>
> all our docker images are using an out of date version of shellcheck.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-23035) Retain region to the last RegionServer make the failover slower
[ https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931181#comment-16931181 ] Anoop Sam John commented on HBASE-23035: So the server which went down and immediate came back will have lesser regions comparably right? In effect some of its old regions got moved to other live RSs. So how/whether that will impact the cluster later? What will happen with the later balance happening? > Retain region to the last RegionServer make the failover slower > --- > > Key: HBASE-23035 > URL: https://issues.apache.org/jira/browse/HBASE-23035 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.3.0, 2.2.1, 2.1.6 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > > Now if one RS crashed, the regions will try to use the old location for the > region deploy. But one RS only have 3 threads to open region by default. If a > RS have hundreds of regions, the failover is very slower. Assign to same RS > may have good locality if the Datanode is deploied on same host. But slower > failover make the availability worse. And the locality is not big deal when > deploy HBase on cloud. > This was introduced by HBASE-18946. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-23035) Retain region to the last RegionServer make the failover slower
[ https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931188#comment-16931188 ] Guanghao Zhang commented on HBASE-23035: bq. So the server which went down and immediate came back will have lesser regions comparably right? Yes. bq. So how/whether that will impact the cluster later? The cluster will balance again by running balancer. > Retain region to the last RegionServer make the failover slower > --- > > Key: HBASE-23035 > URL: https://issues.apache.org/jira/browse/HBASE-23035 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.3.0, 2.2.1, 2.1.6 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > > Now if one RS crashed, the regions will try to use the old location for the > region deploy. But one RS only have 3 threads to open region by default. If a > RS have hundreds of regions, the failover is very slower. Assign to same RS > may have good locality if the Datanode is deploied on same host. But slower > failover make the availability worse. And the locality is not big deal when > deploy HBase on cloud. > This was introduced by HBASE-18946. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-23035) Retain region to the last RegionServer make the failover slower
[ https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931193#comment-16931193 ] ramkrishna.s.vasudevan commented on HBASE-23035: We were always doing a round robin method in case of SCP right? I mean for non region replica cases? > Retain region to the last RegionServer make the failover slower > --- > > Key: HBASE-23035 > URL: https://issues.apache.org/jira/browse/HBASE-23035 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.3.0, 2.2.1, 2.1.6 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > > Now if one RS crashed, the regions will try to use the old location for the > region deploy. But one RS only have 3 threads to open region by default. If a > RS have hundreds of regions, the failover is very slower. Assign to same RS > may have good locality if the Datanode is deploied on same host. But slower > failover make the availability worse. And the locality is not big deal when > deploy HBase on cloud. > This was introduced by HBASE-18946. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (HBASE-22986) Add documentation for hbtop
[ https://issues.apache.org/jira/browse/HBASE-22986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki reassigned HBASE-22986: Assignee: Toshihiro Suzuki > Add documentation for hbtop > --- > > Key: HBASE-22986 > URL: https://issues.apache.org/jira/browse/HBASE-22986 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbtop >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Minor > > We already have README for hbtop, so we can make the refguide refer to this: > [https://github.com/apache/hbase/blob/master/hbase-hbtop/README.md] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22986) Add documentation for hbtop
[ https://issues.apache.org/jira/browse/HBASE-22986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931195#comment-16931195 ] Toshihiro Suzuki commented on HBASE-22986: -- As discussed in https://lists.apache.org/thread.html/704fa49b5dd4210fea7474f129a660c35acb851d2fab56fd11144f7d@%3Cdev.hbase.apache.org%3E , I will move the images to the hbase-site repository (https://github.com/apache/hbase-site) and the README itself to the HBase Book. > Add documentation for hbtop > --- > > Key: HBASE-22986 > URL: https://issues.apache.org/jira/browse/HBASE-22986 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbtop >Reporter: Toshihiro Suzuki >Priority: Minor > > We already have README for hbtop, so we can make the refguide refer to this: > [https://github.com/apache/hbase/blob/master/hbase-hbtop/README.md] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin
Apache-HBase commented on issue #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin URL: https://github.com/apache/hbase/pull/613#issuecomment-532130239 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :blue_heart: | prototool | 0m 0s | prototool was not available. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. | ||| _ HBASE-22514 Compile Tests _ | | :blue_heart: | mvndep | 0m 37s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 16s | HBASE-22514 passed | | :green_heart: | compile | 3m 5s | HBASE-22514 passed | | :green_heart: | checkstyle | 2m 52s | HBASE-22514 passed | | :green_heart: | shadedjars | 4m 34s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 59s | HBASE-22514 passed | | :blue_heart: | spotbugs | 1m 34s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 11m 7s | HBASE-22514 passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 5m 0s | the patch passed | | :green_heart: | compile | 3m 5s | the patch passed | | :green_heart: | cc | 3m 5s | the patch passed | | :green_heart: | javac | 3m 5s | the patch passed | | :broken_heart: | checkstyle | 0m 35s | hbase-client: The patch generated 19 new + 162 unchanged - 0 fixed = 181 total (was 162) | | :broken_heart: | checkstyle | 1m 16s | hbase-server: The patch generated 45 new + 89 unchanged - 0 fixed = 134 total (was 89) | | :broken_heart: | whitespace | 0m 0s | The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | :green_heart: | shadedjars | 4m 37s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 15m 59s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | hbaseprotoc | 3m 1s | the patch passed | | :broken_heart: | javadoc | 0m 40s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | :green_heart: | findbugs | 12m 16s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 0m 42s | hbase-protocol-shaded in the patch passed. | | :green_heart: | unit | 0m 27s | hbase-protocol in the patch passed. | | :green_heart: | unit | 1m 50s | hbase-client in the patch passed. | | :broken_heart: | unit | 177m 54s | hbase-server in the patch failed. | | :green_heart: | unit | 3m 38s | hbase-thrift in the patch passed. | | :green_heart: | asflicense | 2m 14s | The patch does not generate ASF License warnings. | | | | 273m 56s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestMigrateRSGroupInfo | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/613 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux 576ec239b478 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-613/out/precommit/personality/provided.sh | | git revision | HBASE-22514 / 9300631fa8 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/2/artifact/out/diff-checkstyle-hbase-client.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/2/artifact/out/diff-checkstyle-hbase-server.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/2/artifact/out/whitespace-eol.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/2/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/2/artifac
[GitHub] [hbase-connectors] asf-ci commented on issue #41: HBASE-22338 LICENSE file only contains Apache 2.0.
asf-ci commented on issue #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#issuecomment-532133268 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build/69/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23023) upgrade shellcheck used to test in nightly and precommit
[
https://issues.apache.org/jira/browse/HBASE-23023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931219#comment-16931219
]
Hudson commented on HBASE-23023:
Results for branch branch-2.1
[build #1605 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1605/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1605//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1605//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1605//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> upgrade shellcheck used to test in nightly and precommit
>
>
> Key: HBASE-23023
> URL: https://issues.apache.org/jira/browse/HBASE-23023
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
>
> all our docker images are using an out of date version of shellcheck.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase-connectors] ravowlga123 commented on issue #41: HBASE-22338 LICENSE file only contains Apache 2.0.
ravowlga123 commented on issue #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#issuecomment-532137438 @busbey I have added the aggregated license and notice files in assembly module under src/main/resources and removed the plugins from assembly module which generated aggregated license and notice files for hbase-repo. Please do have a look at them in case if any changes are to be made. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22955) Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
[
https://issues.apache.org/jira/browse/HBASE-22955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931230#comment-16931230
]
Hudson commented on HBASE-22955:
Results for branch branch-1
[build #1070 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1070/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1070//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1070//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1070//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
>
>
> Key: HBASE-22955
> URL: https://issues.apache.org/jira/browse/HBASE-22955
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> branch-1 nightly job is failing while trying to do our yetus shaded jar test
> because the enforcer plugin complains about a jdk8 jdk-tools jar being
> present.
>
> looking at the yetus footer, it's because jdk8 is being used instead of jdk7:
> {code:java}
> [2019-08-30T13:30:34.353Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T13:30:34.353Z] | Default Java | 1.8.0_222 |
> {code}
> Same thing in the footer of the jdk7 build (which passes, even though it
> shouldn't)
> {code}
> [2019-08-30T15:43:29.103Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T15:43:29.103Z] | Default Java | 1.8.0_222 |
> {code}
> Both builds appear to be properly running in Docker mode.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-23035) Retain region to the last RegionServer make the failover slower
[ https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931235#comment-16931235 ] Guanghao Zhang commented on HBASE-23035: bq. We were always doing a round robin method in case of SCP right? I mean for non region replica cases? After HBASE-18946, it will retain the regions to the old RS even no region replica. > Retain region to the last RegionServer make the failover slower > --- > > Key: HBASE-23035 > URL: https://issues.apache.org/jira/browse/HBASE-23035 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.3.0, 2.2.1, 2.1.6 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > > Now if one RS crashed, the regions will try to use the old location for the > region deploy. But one RS only have 3 threads to open region by default. If a > RS have hundreds of regions, the failover is very slower. Assign to same RS > may have good locality if the Datanode is deploied on same host. But slower > failover make the availability worse. And the locality is not big deal when > deploy HBase on cloud. > This was introduced by HBASE-18946. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (HBASE-23036) Scan returns wrong data when version is used in CF
[
https://issues.apache.org/jira/browse/HBASE-23036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashok shetty resolved HBASE-23036.
--
Resolution: Duplicate
closing as a dulpicate of HBASE-21596
> Scan returns wrong data when version is used in CF
> --
>
> Key: HBASE-23036
> URL: https://issues.apache.org/jira/browse/HBASE-23036
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.1, 2.1.1
>Reporter: Ashok shetty
>Priority: Major
>
> Created a table with 2 versions , after couple of delete operations Scan
> return stale data
> Steps followed
> 1. create 'Ashok', {NAME => 'cf', VERSIONS => 2}
> 2. put 'Ashok','r1','cf:cq','500'
> 3. flush 'Ashok'
> 4. put 'Ashok','r1','cf:cq','600'
> put 'Ashok','r1','cf:cq','700'
> put 'Ashok','r1','cf:cq','800'
> put 'Ashok','r1','cf:cq','900'
> 5. delete 'Ashok','r1','cf:cq',1568694586309
> At step5 we deleted value 700 by specifying Timestamp
> 6. flush 'Ashok'
> 7. delete 'Ashok','r1','cf:cq',156869459
> At step7 we deleted value 800 by specifying Timestamp
> 8. flush 'Ashok'
> 9. scan 'Ashok',{ VERSIONS => 10 }
> At step 9 scan retuned wrong data value 900 & 500
> Expected output 900 & 600
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Created] (HBASE-23037) Make the split WAL related log more readable
Guanghao Zhang created HBASE-23037: -- Summary: Make the split WAL related log more readable Key: HBASE-23037 URL: https://issues.apache.org/jira/browse/HBASE-23037 Project: HBase Issue Type: Improvement Reporter: Guanghao Zhang Assignee: Guanghao Zhang -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] infraio opened a new pull request #632: HBASE-23037 Make the split WAL related log more readable
infraio opened a new pull request #632: HBASE-23037 Make the split WAL related log more readable URL: https://github.com/apache/hbase/pull/632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created
Apache-HBase commented on issue #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created URL: https://github.com/apache/hbase/pull/581#issuecomment-532144649 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 14 new or modified test files. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 6m 34s | master passed | | :green_heart: | compile | 1m 1s | master passed | | :green_heart: | checkstyle | 1m 23s | master passed | | :green_heart: | shadedjars | 4m 47s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 40s | master passed | | :blue_heart: | spotbugs | 4m 19s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 17s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 5m 6s | the patch passed | | :green_heart: | compile | 0m 59s | the patch passed | | :green_heart: | javac | 0m 59s | the patch passed | | :broken_heart: | checkstyle | 1m 24s | hbase-server: The patch generated 3 new + 261 unchanged - 13 fixed = 264 total (was 274) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 46s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 2s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :broken_heart: | javadoc | 0m 39s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | :green_heart: | findbugs | 4m 46s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 173m 20s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 235m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/581 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 90d80bdbf06b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-581/out/precommit/personality/provided.sh | | git revision | master / bcad0d9f98 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/6/artifact/out/diff-checkstyle-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/6/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/6/testReport/ | | Max. process+thread count | 5084 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21596) Delete for a specific cell version can bring back versions above VERSIONS limit
[
https://issues.apache.org/jira/browse/HBASE-21596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931241#comment-16931241
]
HBase QA commented on HBASE-21596:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HBASE-21596 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-21596 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12954788/HBASE-21596-master.003.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/905/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.0 https://yetus.apache.org |
This message was automatically generated.
> Delete for a specific cell version can bring back versions above VERSIONS
> limit
> ---
>
> Key: HBASE-21596
> URL: https://issues.apache.org/jira/browse/HBASE-21596
> Project: HBase
> Issue Type: Bug
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Minor
> Attachments: HBASE-21596-master.001.patch,
> HBASE-21596-master.002.patch, HBASE-21596-master.003.patch, initial-patch.txt
>
>
> Originally tested with HBase Shell delete command, but it's also reproducible
> with Client API Delete operation.
> The problem is that the memstore scan filter logic for versions only counts
> the amount of cells it has read so far, then once the VERSIONS limit has been
> reached, it just skips the remaining cells. If a delete marker is inserted on
> a given cell version, that cell will not be accounted, then oldest versions
> that should had disappeared will now pop up on the scan results.
> Example, for a cell from a CF with max versions of 3, that has 4 versions T1,
> T2, T3 and T4, scan correctly shows T4, T3 and T2. If a delete is triggered
> for any for these 3 versions, say T3, scan now will show: T4, T2 and T1, but
> T1 was supposed to be gone by the time T4 was added.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] liujiayi771 commented on a change in pull request #630: HBASE-23030 Update completebulkload hadoop jar usage in related doc
liujiayi771 commented on a change in pull request #630: HBASE-23030 Update completebulkload hadoop jar usage in related doc URL: https://github.com/apache/hbase/pull/630#discussion_r325075142 ## File path: src/main/asciidoc/_chapters/architecture.adoc ## @@ -2462,7 +2462,7 @@ This process is not optimally efficient, so users should take care to minimize t [[arch.bulk.load.complete.help]] [source,bash] -$ hadoop jar hbase-server-VERSION.jar completebulkload [-c /path/to/hbase/config/hbase-site.xml] /user/todd/myoutput mytable +$ hadoop jar hbase-mapreduce-VERSION.jar completebulkload [-c /path/to/hbase/config/hbase-site.xml] /user/todd/myoutput mytable Review comment: HBASE-18698 moves Driver to be the main-class in hbase-mapreduce jar rather than hbase-server jar. hbase-server jar has no Main-Class in MANIFEST.MF, so when I use hadoop jar hbase-server-VERSION.jar completebulkload, hadoop cannot find the main class in hbase-server jar, and throws exception like this: ``` Exception in thread "main" java.lang.ClassNotFoundException: completebulkload at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:348) at org.apache.hadoop.util.RunJar.run(RunJar.java:311) at org.apache.hadoop.util.RunJar.main(RunJar.java:232) ``` According to HBASE-18698, it adds `Main-Class: org/apache/hadoop/hbase/mapreduce/Driver` in hbase-mapreduce jar, so the correct way to use completebulkload is hadoop jar hbase-mapreduce-VERSION.jar completebulkload. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] liujiayi771 commented on a change in pull request #630: HBASE-23030 Update completebulkload hadoop jar usage in related doc
liujiayi771 commented on a change in pull request #630: HBASE-23030 Update completebulkload hadoop jar usage in related doc URL: https://github.com/apache/hbase/pull/630#discussion_r325075142 ## File path: src/main/asciidoc/_chapters/architecture.adoc ## @@ -2462,7 +2462,7 @@ This process is not optimally efficient, so users should take care to minimize t [[arch.bulk.load.complete.help]] [source,bash] -$ hadoop jar hbase-server-VERSION.jar completebulkload [-c /path/to/hbase/config/hbase-site.xml] /user/todd/myoutput mytable +$ hadoop jar hbase-mapreduce-VERSION.jar completebulkload [-c /path/to/hbase/config/hbase-site.xml] /user/todd/myoutput mytable Review comment: [HBASE-18698](https://issues.apache.org/jira/browse/HBASE-18698) moves Driver to be the main-class in hbase-mapreduce jar rather than hbase-server jar. hbase-server jar has no Main-Class in MANIFEST.MF, so when I use hadoop jar hbase-server-VERSION.jar completebulkload, hadoop cannot find the main class in hbase-server jar, and throws exception like this: ``` Exception in thread "main" java.lang.ClassNotFoundException: completebulkload at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:348) at org.apache.hadoop.util.RunJar.run(RunJar.java:311) at org.apache.hadoop.util.RunJar.main(RunJar.java:232) ``` According to [HBASE-18698](https://issues.apache.org/jira/browse/HBASE-18698), it adds `Main-Class: org/apache/hadoop/hbase/mapreduce/Driver` in hbase-mapreduce jar, so the correct way to use completebulkload is hadoop jar hbase-mapreduce-VERSION.jar completebulkload. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23023) upgrade shellcheck used to test in nightly and precommit
[
https://issues.apache.org/jira/browse/HBASE-23023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931245#comment-16931245
]
Hudson commented on HBASE-23023:
Results for branch branch-2
[build #2266 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2266/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2266//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2266//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2266//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> upgrade shellcheck used to test in nightly and precommit
>
>
> Key: HBASE-23023
> URL: https://issues.apache.org/jira/browse/HBASE-23023
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
>
> all our docker images are using an out of date version of shellcheck.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-23030) Update completebulkload hadoop jar usage in related doc
[
https://issues.apache.org/jira/browse/HBASE-23030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931250#comment-16931250
]
Jiayi Liu commented on HBASE-23030:
---
[HBASE-18698|https://issues.apache.org/jira/browse/HBASE-18698] moves Driver to
be the main-class in hbase-mapreduce jar rather than hbase-server jar.
hbase-server jar has no Main-Class in MANIFEST.MF, so when I use hadoop jar
hbase-server-VERSION.jar completebulkload, hadoop cannot find the main class in
hbase-server jar, and throws exception like this:
{code:java}
Exception in thread "main" java.lang.ClassNotFoundException: completebulkload
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:348)
at org.apache.hadoop.util.RunJar.run(RunJar.java:311)
at org.apache.hadoop.util.RunJar.main(RunJar.java:232)
{code}
According to [HBASE-18698|https://issues.apache.org/jira/browse/HBASE-18698],
it adds {code}Main-Class: org/apache/hadoop/hbase/mapreduce/Driver{code} in
hbase-mapreduce jar, so the correct way to use completebulkload is hadoop jar
hbase-mapreduce-VERSION.jar completebulkload.
> Update completebulkload hadoop jar usage in related doc
> ---
>
> Key: HBASE-23030
> URL: https://issues.apache.org/jira/browse/HBASE-23030
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Jiayi Liu
>Priority: Minor
>
> Update the usage of completebulkload from "hadoop jar
> hbase-server-VERSION.jar completebulkload" to "hadoop jar
> hbase-mapreduce-VERSION.jar completebulkload" according to
> [HBASE-18698|https://issues.apache.org/jira/browse/HBASE-18698]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache9 commented on issue #501: HBASE-22699 refactor isMetaClearingException
Apache9 commented on issue #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#issuecomment-532149564 This is for master and #578 is for branch-2, I think... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] johnhomsea opened a new pull request #501: HBASE-22699 refactor isMetaClearingException
johnhomsea opened a new pull request #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #501: HBASE-22699 refactor isMetaClearingException
Apache9 commented on issue #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#issuecomment-532150087 So @saintstack if you think #578 is fine then this one should also be fine... Will merge it if no objections later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22846) Internal Error 500 when Using HBASE REST API to Create Namespace.
[ https://issues.apache.org/jira/browse/HBASE-22846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-22846: - Fix Version/s: 2.1.7 2.2.1 2.3.0 3.0.0 Affects Version/s: 3.0.0 2.2.0 Pushed to branch-2.1, branch-2.2, branch-2 and branch-3. Thanks for reviewing it, [~stack]. > Internal Error 500 when Using HBASE REST API to Create Namespace. > - > > Key: HBASE-22846 > URL: https://issues.apache.org/jira/browse/HBASE-22846 > Project: HBase > Issue Type: Improvement > Components: hbase-connectors >Affects Versions: 3.0.0, 2.2.0, 2.1.1 >Reporter: Sailesh Patel >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7 > > > When trying to the following URL to create namespace: > Secured cluster: curl --negotiate -u : -i -k -vi -X POST > "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest"; > UnSecured cluster: curl -vi -X POST > "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest"; > The following is returned on the console: > HTTP/1.1 500 Request failed. > The Error in Hbase REST Server log is: > 2019-08-13 15:44:55,080 WARN org.eclipse.jetty.servlet.ServletHandler: > javax.servlet.ServletException: java.lang.NullPointerException > at > org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489) > at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427) > ... > Caused by: java.lang.NullPointerException > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.createOrUpdate(NamespacesInstanceResource.java:250) > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.processUpdate(NamespacesInstanceResource.java:243) > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.post(NamespacesInstanceResource.java:183) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81) > at > org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144) > at > org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161) > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (HBASE-22846) Internal Error 500 when Using HBASE REST API to Create Namespace.
[ https://issues.apache.org/jira/browse/HBASE-22846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-22846. -- Resolution: Fixed > Internal Error 500 when Using HBASE REST API to Create Namespace. > - > > Key: HBASE-22846 > URL: https://issues.apache.org/jira/browse/HBASE-22846 > Project: HBase > Issue Type: Improvement > Components: hbase-connectors >Affects Versions: 3.0.0, 2.2.0, 2.1.1 >Reporter: Sailesh Patel >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7 > > > When trying to the following URL to create namespace: > Secured cluster: curl --negotiate -u : -i -k -vi -X POST > "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest"; > UnSecured cluster: curl -vi -X POST > "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest"; > The following is returned on the console: > HTTP/1.1 500 Request failed. > The Error in Hbase REST Server log is: > 2019-08-13 15:44:55,080 WARN org.eclipse.jetty.servlet.ServletHandler: > javax.servlet.ServletException: java.lang.NullPointerException > at > org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489) > at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427) > ... > Caused by: java.lang.NullPointerException > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.createOrUpdate(NamespacesInstanceResource.java:250) > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.processUpdate(NamespacesInstanceResource.java:243) > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.post(NamespacesInstanceResource.java:183) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81) > at > org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144) > at > org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161) > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22955) Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
[
https://issues.apache.org/jira/browse/HBASE-22955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931257#comment-16931257
]
Hudson commented on HBASE-22955:
Results for branch branch-1.4
[build #1018 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1018/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1018//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1018//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1018//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
>
>
> Key: HBASE-22955
> URL: https://issues.apache.org/jira/browse/HBASE-22955
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> branch-1 nightly job is failing while trying to do our yetus shaded jar test
> because the enforcer plugin complains about a jdk8 jdk-tools jar being
> present.
>
> looking at the yetus footer, it's because jdk8 is being used instead of jdk7:
> {code:java}
> [2019-08-30T13:30:34.353Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T13:30:34.353Z] | Default Java | 1.8.0_222 |
> {code}
> Same thing in the footer of the jdk7 build (which passes, even though it
> shouldn't)
> {code}
> [2019-08-30T15:43:29.103Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T15:43:29.103Z] | Default Java | 1.8.0_222 |
> {code}
> Both builds appear to be properly running in Docker mode.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931311#comment-16931311
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #113 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/113/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/113//console].
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/113//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/113//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/113//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22955) Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
[
https://issues.apache.org/jira/browse/HBASE-22955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931317#comment-16931317
]
Hudson commented on HBASE-22955:
Results for branch branch-1.3
[build #975 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/975/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/975//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/975//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/975//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
>
>
> Key: HBASE-22955
> URL: https://issues.apache.org/jira/browse/HBASE-22955
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> branch-1 nightly job is failing while trying to do our yetus shaded jar test
> because the enforcer plugin complains about a jdk8 jdk-tools jar being
> present.
>
> looking at the yetus footer, it's because jdk8 is being used instead of jdk7:
> {code:java}
> [2019-08-30T13:30:34.353Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T13:30:34.353Z] | Default Java | 1.8.0_222 |
> {code}
> Same thing in the footer of the jdk7 build (which passes, even though it
> shouldn't)
> {code}
> [2019-08-30T15:43:29.103Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T15:43:29.103Z] | Default Java | 1.8.0_222 |
> {code}
> Both builds appear to be properly running in Docker mode.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931319#comment-16931319
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #114 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/114/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/114//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/114//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/114//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/114//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] ZhaoBQ opened a new pull request #633: HBASE-22890 Verify the file integrity in persistent IOEngine
ZhaoBQ opened a new pull request #633: HBASE-22890 Verify the file integrity in persistent IOEngine URL: https://github.com/apache/hbase/pull/633 [HBASE-22890](https://issues.apache.org/jira/browse/HBASE-22890) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ZhaoBQ commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
ZhaoBQ commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode URL: https://github.com/apache/hbase/pull/528#issuecomment-532181376 Hello, @Reidd @anoopsjohn , I have created a new pull request. [HBASE-22890](https://github.com/apache/hbase/pull/633) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22955) Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
[
https://issues.apache.org/jira/browse/HBASE-22955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931342#comment-16931342
]
Hudson commented on HBASE-22955:
Results for branch branch-2.2
[build #613 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/613/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/613//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/613//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/613//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
>
>
> Key: HBASE-22955
> URL: https://issues.apache.org/jira/browse/HBASE-22955
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> branch-1 nightly job is failing while trying to do our yetus shaded jar test
> because the enforcer plugin complains about a jdk8 jdk-tools jar being
> present.
>
> looking at the yetus footer, it's because jdk8 is being used instead of jdk7:
> {code:java}
> [2019-08-30T13:30:34.353Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T13:30:34.353Z] | Default Java | 1.8.0_222 |
> {code}
> Same thing in the footer of the jdk7 build (which passes, even though it
> shouldn't)
> {code}
> [2019-08-30T15:43:29.103Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T15:43:29.103Z] | Default Java | 1.8.0_222 |
> {code}
> Both builds appear to be properly running in Docker mode.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (HBASE-22846) Internal Error 500 when Using HBASE REST API to Create Namespace.
[ https://issues.apache.org/jira/browse/HBASE-22846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931255#comment-16931255 ] Wellington Chevreuil edited comment on HBASE-22846 at 9/17/19 11:35 AM: Pushed to branch-2.1, branch-2.2, branch-2 and master. Thanks for reviewing it, [~stack]. was (Author: wchevreuil): Pushed to branch-2.1, branch-2.2, branch-2 and branch-3. Thanks for reviewing it, [~stack]. > Internal Error 500 when Using HBASE REST API to Create Namespace. > - > > Key: HBASE-22846 > URL: https://issues.apache.org/jira/browse/HBASE-22846 > Project: HBase > Issue Type: Improvement > Components: hbase-connectors >Affects Versions: 3.0.0, 2.2.0, 2.1.1 >Reporter: Sailesh Patel >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7 > > > When trying to the following URL to create namespace: > Secured cluster: curl --negotiate -u : -i -k -vi -X POST > "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest"; > UnSecured cluster: curl -vi -X POST > "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest"; > The following is returned on the console: > HTTP/1.1 500 Request failed. > The Error in Hbase REST Server log is: > 2019-08-13 15:44:55,080 WARN org.eclipse.jetty.servlet.ServletHandler: > javax.servlet.ServletException: java.lang.NullPointerException > at > org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489) > at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427) > ... > Caused by: java.lang.NullPointerException > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.createOrUpdate(NamespacesInstanceResource.java:250) > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.processUpdate(NamespacesInstanceResource.java:243) > at > org.apache.hadoop.hbase.rest.NamespacesInstanceResource.post(NamespacesInstanceResource.java:183) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81) > at > org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144) > at > org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161) > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] petersomogyi merged pull request #627: HBASE-23024 : Replace initcause with Constructor arg
petersomogyi merged pull request #627: HBASE-23024 : Replace initcause with Constructor arg URL: https://github.com/apache/hbase/pull/627 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23024) Replace Exception.initCause() with Constructor args
[ https://issues.apache.org/jira/browse/HBASE-23024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-23024: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed PR #627 to master and branch-2. Pushed a slightly modified version to branch-1. Thanks for the patch [~vjasani]! > Replace Exception.initCause() with Constructor args > --- > > Key: HBASE-23024 > URL: https://issues.apache.org/jira/browse/HBASE-23024 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > We can use parameterized constructor for providing root cause of some > Exceptions based on the availability of such constructors to avoid calling > .initCause() for Exceptions. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] johnhomsea commented on a change in pull request #501: HBASE-22699 refactor isMetaClearingException
johnhomsea commented on a change in pull request #501: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#discussion_r325136978
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocatorHelper.java
##
@@ -67,7 +68,8 @@ static void updateCachedLocationOnError(HRegionLocation loc,
Throwable exception
LOG.debug("The actual exception when updating {} is {}", loc,
cause != null ? cause.toString() : "none");
}
-if (cause == null || !isMetaClearingException(cause)) {
+if (cause == null || !isMetaClearingException(cause)
Review comment:
Yes, it subsumes this one, but branch-2 is different from master in some
cases.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22699) refactor isMetaClearingException
[ https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931405#comment-16931405 ] Junhong Xu commented on HBASE-22699: the pr 501 is for master. > refactor isMetaClearingException > > > Key: HBASE-22699 > URL: https://issues.apache.org/jira/browse/HBASE-22699 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Minor > Fix For: 2.3.0, 2.2.2 > > > It is not so readable -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22699) refactor isMetaClearingException
[ https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931403#comment-16931403 ] Junhong Xu commented on HBASE-22699: ok, it's fine to me, thx to Stack. > refactor isMetaClearingException > > > Key: HBASE-22699 > URL: https://issues.apache.org/jira/browse/HBASE-22699 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Minor > Fix For: 2.3.0, 2.2.2 > > > It is not so readable -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] johnhomsea commented on issue #501: HBASE-22699 refactor isMetaClearingException
johnhomsea commented on issue #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#issuecomment-532206367 > This is for master and #578 is for branch-2, I think... Yes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-connectors] meszibalu opened a new pull request #42: HBASE-22817 Use hbase-shaded dependencies in hbase-spark
meszibalu opened a new pull request #42: HBASE-22817 Use hbase-shaded dependencies in hbase-spark URL: https://github.com/apache/hbase-connectors/pull/42 * hbase-spark-protocol: a new project for the protobuf files. * hbase-spark-protocol-shaded: the shaded version of hbase-spark-protocol, which is compatible with hbase thirdparty protobuf. hbase-spark codebase now depends on only hbase-shaded-* stuff and hbase-spark-protocol-shaded. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #633: HBASE-22890 Verify the file integrity in persistent IOEngine
Reidd commented on a change in pull request #633: HBASE-22890 Verify the
file integrity in persistent IOEngine
URL: https://github.com/apache/hbase/pull/633#discussion_r325162163
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -1021,41 +1033,52 @@ void doDrain(final List entries) throws
InterruptedException {
private void persistToFile() throws IOException {
assert !cacheEnabled;
-FileOutputStream fos = null;
-ObjectOutputStream oos = null;
-try {
+try (ObjectOutputStream oos = new ObjectOutputStream(
+ new FileOutputStream(persistencePath, false))){
if (!ioEngine.isPersistent()) {
throw new IOException("Attempt to persist non-persistent cache
mappings!");
}
- fos = new FileOutputStream(persistencePath, false);
- oos = new ObjectOutputStream(fos);
+ oos.write(ProtobufUtil.PB_MAGIC);
+ byte[] checksum = ((PersistentIOEngine) ioEngine).calculateChecksum();
+ oos.writeInt(checksum.length);
+ oos.write(checksum);
oos.writeLong(cacheCapacity);
oos.writeUTF(ioEngine.getClass().getName());
oos.writeUTF(backingMap.getClass().getName());
oos.writeObject(deserialiserMap);
oos.writeObject(backingMap);
-} finally {
- if (oos != null) oos.close();
- if (fos != null) fos.close();
+} catch (NoSuchAlgorithmException e) {
+ LOG.error("No such algorithm : " + algorithm + "! Failed to persist data
on exit",e);
}
}
@SuppressWarnings("unchecked")
- private void retrieveFromFile(int[] bucketSizes) throws IOException,
BucketAllocatorException,
+ private void retrieveFromFile(int[] bucketSizes) throws IOException,
ClassNotFoundException {
File persistenceFile = new File(persistencePath);
if (!persistenceFile.exists()) {
return;
}
assert !cacheEnabled;
-FileInputStream fis = null;
ObjectInputStream ois = null;
try {
if (!ioEngine.isPersistent())
throw new IOException(
"Attempt to restore non-persistent cache mappings!");
- fis = new FileInputStream(persistencePath);
- ois = new ObjectInputStream(fis);
+ ois = new ObjectInputStream(new FileInputStream(persistencePath));
+ // there are two situations that can cause verification to fail
+ if (!((FileIOEngine) ioEngine).verifyFileIntegrity(persistencePath,
ois)) {
Review comment:
ioEngine can directly cast to FileIOEngine? It's already guarded by
``!ioEngine.isPersistent().``
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-connectors] asf-ci commented on issue #42: HBASE-22817 Use hbase-shaded dependencies in hbase-spark
asf-ci commented on issue #42: HBASE-22817 Use hbase-shaded dependencies in hbase-spark URL: https://github.com/apache/hbase-connectors/pull/42#issuecomment-532220904 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-CONNECTORS-Build/70/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on a change in pull request #633: HBASE-22890 Verify the file integrity in persistent IOEngine
Reidd commented on a change in pull request #633: HBASE-22890 Verify the
file integrity in persistent IOEngine
URL: https://github.com/apache/hbase/pull/633#discussion_r325185014
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -1021,41 +1033,52 @@ void doDrain(final List entries) throws
InterruptedException {
private void persistToFile() throws IOException {
assert !cacheEnabled;
-FileOutputStream fos = null;
-ObjectOutputStream oos = null;
-try {
+try (ObjectOutputStream oos = new ObjectOutputStream(
+ new FileOutputStream(persistencePath, false))){
if (!ioEngine.isPersistent()) {
throw new IOException("Attempt to persist non-persistent cache
mappings!");
}
- fos = new FileOutputStream(persistencePath, false);
- oos = new ObjectOutputStream(fos);
+ oos.write(ProtobufUtil.PB_MAGIC);
+ byte[] checksum = ((PersistentIOEngine) ioEngine).calculateChecksum();
+ oos.writeInt(checksum.length);
+ oos.write(checksum);
oos.writeLong(cacheCapacity);
oos.writeUTF(ioEngine.getClass().getName());
oos.writeUTF(backingMap.getClass().getName());
oos.writeObject(deserialiserMap);
oos.writeObject(backingMap);
-} finally {
- if (oos != null) oos.close();
- if (fos != null) fos.close();
+} catch (NoSuchAlgorithmException e) {
+ LOG.error("No such algorithm : " + algorithm + "! Failed to persist data
on exit",e);
}
}
@SuppressWarnings("unchecked")
- private void retrieveFromFile(int[] bucketSizes) throws IOException,
BucketAllocatorException,
+ private void retrieveFromFile(int[] bucketSizes) throws IOException,
ClassNotFoundException {
File persistenceFile = new File(persistencePath);
if (!persistenceFile.exists()) {
return;
}
assert !cacheEnabled;
-FileInputStream fis = null;
ObjectInputStream ois = null;
try {
if (!ioEngine.isPersistent())
throw new IOException(
"Attempt to restore non-persistent cache mappings!");
- fis = new FileInputStream(persistencePath);
- ois = new ObjectInputStream(fis);
+ ois = new ObjectInputStream(new FileInputStream(persistencePath));
+ // there are two situations that can cause verification to fail
+ if (!((FileIOEngine) ioEngine).verifyFileIntegrity(persistencePath,
ois)) {
+// 1. persistent file is old version, it's not support verification,
+// so reopen ObjectInputStream and read the persistent file from head
+if (((FileIOEngine) ioEngine).isOldVersion()) {
+ ois.close();
+ ois = new ObjectInputStream(new FileInputStream(persistencePath));
+} else {
+ // 2. there are some IOException like file not exist, and the
FileIOEngine
+ // has been reinitialized
+ return;
Review comment:
here we return, what about backingMap?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22955) Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
[
https://issues.apache.org/jira/browse/HBASE-22955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931487#comment-16931487
]
Hudson commented on HBASE-22955:
Results for branch branch-2
[build #2267 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2267/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2267//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2267//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2267//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
>
>
> Key: HBASE-22955
> URL: https://issues.apache.org/jira/browse/HBASE-22955
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> branch-1 nightly job is failing while trying to do our yetus shaded jar test
> because the enforcer plugin complains about a jdk8 jdk-tools jar being
> present.
>
> looking at the yetus footer, it's because jdk8 is being used instead of jdk7:
> {code:java}
> [2019-08-30T13:30:34.353Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T13:30:34.353Z] | Default Java | 1.8.0_222 |
> {code}
> Same thing in the footer of the jdk7 build (which passes, even though it
> shouldn't)
> {code}
> [2019-08-30T15:43:29.103Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T15:43:29.103Z] | Default Java | 1.8.0_222 |
> {code}
> Both builds appear to be properly running in Docker mode.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22955) Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
[
https://issues.apache.org/jira/browse/HBASE-22955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931489#comment-16931489
]
Hudson commented on HBASE-22955:
Results for branch master
[build #1445 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1445/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1445//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1445//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1445//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
>
>
> Key: HBASE-22955
> URL: https://issues.apache.org/jira/browse/HBASE-22955
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> branch-1 nightly job is failing while trying to do our yetus shaded jar test
> because the enforcer plugin complains about a jdk8 jdk-tools jar being
> present.
>
> looking at the yetus footer, it's because jdk8 is being used instead of jdk7:
> {code:java}
> [2019-08-30T13:30:34.353Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T13:30:34.353Z] | Default Java | 1.8.0_222 |
> {code}
> Same thing in the footer of the jdk7 build (which passes, even though it
> shouldn't)
> {code}
> [2019-08-30T15:43:29.103Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T15:43:29.103Z] | Default Java | 1.8.0_222 |
> {code}
> Both builds appear to be properly running in Docker mode.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Reidddddd commented on a change in pull request #615: HBASE-22975 Add read and write QPS metrics at server level and table level
Reidd commented on a change in pull request #615: HBASE-22975 Add read and
write QPS metrics at server level and table level
URL: https://github.com/apache/hbase/pull/615#discussion_r325187185
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##
@@ -4075,6 +4075,10 @@ public void completeMiniBatchOperations(
if (!initialized) {
this.writeRequestsCount.add(batchOp.size());
+ if (rsServices != null && rsServices.getMetrics() != null) {
+
rsServices.getMetrics().updateServerWriteQueryPerSecond(this.htableDescriptor.
Review comment:
OK, i see.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22955) Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
[
https://issues.apache.org/jira/browse/HBASE-22955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931501#comment-16931501
]
Hudson commented on HBASE-22955:
Results for branch branch-2.1
[build #1606 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1606/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1606//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1606//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1606//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1606//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Branches-1 precommit and nightly yetus jobs are using jdk8 for jdk7 jobs
>
>
> Key: HBASE-22955
> URL: https://issues.apache.org/jira/browse/HBASE-22955
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.5.0, 1.3.6, 1.4.11
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> branch-1 nightly job is failing while trying to do our yetus shaded jar test
> because the enforcer plugin complains about a jdk8 jdk-tools jar being
> present.
>
> looking at the yetus footer, it's because jdk8 is being used instead of jdk7:
> {code:java}
> [2019-08-30T13:30:34.353Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T13:30:34.353Z] | Default Java | 1.8.0_222 |
> {code}
> Same thing in the footer of the jdk7 build (which passes, even though it
> shouldn't)
> {code}
> [2019-08-30T15:43:29.103Z] | maven | version: Apache Maven 3.0.5 |
> [2019-08-30T15:43:29.103Z] | Default Java | 1.8.0_222 |
> {code}
> Both builds appear to be properly running in Docker mode.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] ZhaoBQ commented on a change in pull request #633: HBASE-22890 Verify the file integrity in persistent IOEngine
ZhaoBQ commented on a change in pull request #633: HBASE-22890 Verify the file
integrity in persistent IOEngine
URL: https://github.com/apache/hbase/pull/633#discussion_r325190250
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -1021,41 +1033,52 @@ void doDrain(final List entries) throws
InterruptedException {
private void persistToFile() throws IOException {
assert !cacheEnabled;
-FileOutputStream fos = null;
-ObjectOutputStream oos = null;
-try {
+try (ObjectOutputStream oos = new ObjectOutputStream(
+ new FileOutputStream(persistencePath, false))){
if (!ioEngine.isPersistent()) {
throw new IOException("Attempt to persist non-persistent cache
mappings!");
}
- fos = new FileOutputStream(persistencePath, false);
- oos = new ObjectOutputStream(fos);
+ oos.write(ProtobufUtil.PB_MAGIC);
+ byte[] checksum = ((PersistentIOEngine) ioEngine).calculateChecksum();
+ oos.writeInt(checksum.length);
+ oos.write(checksum);
oos.writeLong(cacheCapacity);
oos.writeUTF(ioEngine.getClass().getName());
oos.writeUTF(backingMap.getClass().getName());
oos.writeObject(deserialiserMap);
oos.writeObject(backingMap);
-} finally {
- if (oos != null) oos.close();
- if (fos != null) fos.close();
+} catch (NoSuchAlgorithmException e) {
+ LOG.error("No such algorithm : " + algorithm + "! Failed to persist data
on exit",e);
}
}
@SuppressWarnings("unchecked")
- private void retrieveFromFile(int[] bucketSizes) throws IOException,
BucketAllocatorException,
+ private void retrieveFromFile(int[] bucketSizes) throws IOException,
ClassNotFoundException {
File persistenceFile = new File(persistencePath);
if (!persistenceFile.exists()) {
return;
}
assert !cacheEnabled;
-FileInputStream fis = null;
ObjectInputStream ois = null;
try {
if (!ioEngine.isPersistent())
throw new IOException(
"Attempt to restore non-persistent cache mappings!");
- fis = new FileInputStream(persistencePath);
- ois = new ObjectInputStream(fis);
+ ois = new ObjectInputStream(new FileInputStream(persistencePath));
+ // there are two situations that can cause verification to fail
+ if (!((FileIOEngine) ioEngine).verifyFileIntegrity(persistencePath,
ois)) {
Review comment:
My fault, it's should be PersistentIOEngine.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ZhaoBQ commented on a change in pull request #633: HBASE-22890 Verify the file integrity in persistent IOEngine
ZhaoBQ commented on a change in pull request #633: HBASE-22890 Verify the file
integrity in persistent IOEngine
URL: https://github.com/apache/hbase/pull/633#discussion_r325190886
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -1021,41 +1033,52 @@ void doDrain(final List entries) throws
InterruptedException {
private void persistToFile() throws IOException {
assert !cacheEnabled;
-FileOutputStream fos = null;
-ObjectOutputStream oos = null;
-try {
+try (ObjectOutputStream oos = new ObjectOutputStream(
+ new FileOutputStream(persistencePath, false))){
if (!ioEngine.isPersistent()) {
throw new IOException("Attempt to persist non-persistent cache
mappings!");
}
- fos = new FileOutputStream(persistencePath, false);
- oos = new ObjectOutputStream(fos);
+ oos.write(ProtobufUtil.PB_MAGIC);
+ byte[] checksum = ((PersistentIOEngine) ioEngine).calculateChecksum();
+ oos.writeInt(checksum.length);
+ oos.write(checksum);
oos.writeLong(cacheCapacity);
oos.writeUTF(ioEngine.getClass().getName());
oos.writeUTF(backingMap.getClass().getName());
oos.writeObject(deserialiserMap);
oos.writeObject(backingMap);
-} finally {
- if (oos != null) oos.close();
- if (fos != null) fos.close();
+} catch (NoSuchAlgorithmException e) {
+ LOG.error("No such algorithm : " + algorithm + "! Failed to persist data
on exit",e);
}
}
@SuppressWarnings("unchecked")
- private void retrieveFromFile(int[] bucketSizes) throws IOException,
BucketAllocatorException,
+ private void retrieveFromFile(int[] bucketSizes) throws IOException,
ClassNotFoundException {
File persistenceFile = new File(persistencePath);
if (!persistenceFile.exists()) {
return;
}
assert !cacheEnabled;
-FileInputStream fis = null;
ObjectInputStream ois = null;
try {
if (!ioEngine.isPersistent())
throw new IOException(
"Attempt to restore non-persistent cache mappings!");
- fis = new FileInputStream(persistencePath);
- ois = new ObjectInputStream(fis);
+ ois = new ObjectInputStream(new FileInputStream(persistencePath));
+ // there are two situations that can cause verification to fail
+ if (!((FileIOEngine) ioEngine).verifyFileIntegrity(persistencePath,
ois)) {
+// 1. persistent file is old version, it's not support verification,
+// so reopen ObjectInputStream and read the persistent file from head
+if (((FileIOEngine) ioEngine).isOldVersion()) {
+ ois.close();
+ ois = new ObjectInputStream(new FileInputStream(persistencePath));
+} else {
+ // 2. there are some IOException like file not exist, and the
FileIOEngine
+ // has been reinitialized
+ return;
Review comment:
In "finally", the persistentFile(or backingMap) will be deleted.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-21874) Bucket cache on Persistent memory
[ https://issues.apache.org/jira/browse/HBASE-21874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-21874: - Resolution: Fixed Status: Resolved (was: Patch Available) > Bucket cache on Persistent memory > - > > Key: HBASE-21874 > URL: https://issues.apache.org/jira/browse/HBASE-21874 > Project: HBase > Issue Type: New Feature > Components: BucketCache >Affects Versions: 3.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21874.branch-2.2.001.patch, HBASE-21874.patch, > HBASE-21874.patch, HBASE-21874_V2.patch, HBASE-21874_V4.patch, > HBASE-21874_V5.patch, HBASE-21874_V6.patch, Pmem_BC.png > > > Non volatile persistent memory devices are byte addressable like DRAM (for > eg. Intel DCPMM). Bucket cache implementation can take advantage of this new > memory type and can make use of the existing offheap data structures to serve > data directly from this memory area without having to bring the data to > onheap. > The patch is a new IOEngine implementation that works with the persistent > memory. > Note : Here we don't make use of the persistence nature of the device and > just make use of the big memory it provides. > Performance numbers to follow. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-21874) Bucket cache on Persistent memory
[ https://issues.apache.org/jira/browse/HBASE-21874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931505#comment-16931505 ] Wellington Chevreuil commented on HBASE-21874: -- Thanks for your comments, [~elserj]. After further internal discussions, I think it's ok to leave it just in the new release branches. Am closing this for now. > Bucket cache on Persistent memory > - > > Key: HBASE-21874 > URL: https://issues.apache.org/jira/browse/HBASE-21874 > Project: HBase > Issue Type: New Feature > Components: BucketCache >Affects Versions: 3.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-21874.branch-2.2.001.patch, HBASE-21874.patch, > HBASE-21874.patch, HBASE-21874_V2.patch, HBASE-21874_V4.patch, > HBASE-21874_V5.patch, HBASE-21874_V6.patch, Pmem_BC.png > > > Non volatile persistent memory devices are byte addressable like DRAM (for > eg. Intel DCPMM). Bucket cache implementation can take advantage of this new > memory type and can make use of the existing offheap data structures to serve > data directly from this memory area without having to bring the data to > onheap. > The patch is a new IOEngine implementation that works with the persistent > memory. > Note : Here we don't make use of the persistence nature of the device and > just make use of the big memory it provides. > Performance numbers to follow. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] wchevreuil commented on a change in pull request #494: HBASE-22380 break circle replication when doing bulkload
wchevreuil commented on a change in pull request #494: HBASE-22380 break circle
replication when doing bulkload
URL: https://github.com/apache/hbase/pull/494#discussion_r325216175
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
##
@@ -243,14 +250,26 @@ public void replicateEntries(List entries,
final CellScanner cells,
LOG.debug("Finished replicating mutations.");
}
- if (bulkLoadHFileMap != null && !bulkLoadHFileMap.isEmpty()) {
-LOG.debug("Started replicating bulk loaded data.");
-HFileReplicator hFileReplicator =
-new HFileReplicator(this.provider.getConf(this.conf,
replicationClusterId),
+ if(bulkLoadsPerClusters != null) {
+for (List clusterIds : bulkLoadsPerClusters.keySet()) {
Review comment:
That came up as well on the separate PR I created for master branch. Pasting
my explanation made there:
> HRegionServer already keeps a String clusterId (not UUID), which I'm using
to check against the incoming bulk load request. Converting the request List to
List when clusterId is already represented as String didn't seem to give much
gain here. Maybe we should raise a separate jira to convert all existing String
representations of cluster id into UUID, and including this one as part of this
work?
We agreed with that suggestion to open a separate jira to address replacing
existing String clusterId to UUID.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #631: HBASE-23035 Retain region to the last RegionServer make the failover …
Apache-HBase commented on issue #631: HBASE-23035 Retain region to the last RegionServer make the failover … URL: https://github.com/apache/hbase/pull/631#issuecomment-532268492 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 20s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 7m 53s | master passed | | :green_heart: | compile | 1m 18s | master passed | | :green_heart: | checkstyle | 1m 47s | master passed | | :green_heart: | shadedjars | 6m 5s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 43s | master passed | | :blue_heart: | spotbugs | 5m 12s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 5m 11s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 7m 5s | the patch passed | | :green_heart: | compile | 1m 15s | the patch passed | | :green_heart: | javac | 1m 15s | the patch passed | | :green_heart: | checkstyle | 1m 43s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 57s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 21m 36s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 47s | the patch passed | | :green_heart: | findbugs | 5m 31s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 275m 35s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. | | | | 353m 2s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.regionserver.TestDrainReplicationQueuesForStandBy | | | hadoop.hbase.replication.TestSyncReplicationRemoveRemoteWAL | | | hadoop.hbase.regionserver.TestRegionReplicasAreDistributed | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-631/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/631 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d0e16ebbdec4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-631/out/precommit/personality/provided.sh | | git revision | master / bcad0d9f98 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-631/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-631/1/testReport/ | | Max. process+thread count | 4891 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-631/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #633: HBASE-22890 Verify the file integrity in persistent IOEngine
Apache-HBase commented on issue #633: HBASE-22890 Verify the file integrity in persistent IOEngine URL: https://github.com/apache/hbase/pull/633#issuecomment-532270602 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 29s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :green_heart: | mvninstall | 8m 7s | branch-1 passed | | :green_heart: | compile | 1m 59s | branch-1 passed with JDK v1.8.0_222 | | :broken_heart: | compile | 0m 21s | hbase-server in branch-1 failed with JDK v1.7.0_232. | | :green_heart: | checkstyle | 1m 33s | branch-1 passed | | :green_heart: | shadedjars | 2m 46s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 36s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 0m 39s | branch-1 passed with JDK v1.7.0_232 | | :blue_heart: | spotbugs | 2m 47s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 2m 43s | branch-1 passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 2m 1s | the patch passed | | :green_heart: | compile | 1m 49s | the patch passed with JDK v1.8.0_222 | | :green_heart: | javac | 1m 49s | the patch passed | | :broken_heart: | compile | 0m 22s | hbase-server in the patch failed with JDK v1.7.0_232. | | :broken_heart: | javac | 0m 22s | hbase-server in the patch failed with JDK v1.7.0_232. | | :broken_heart: | checkstyle | 1m 32s | hbase-server: The patch generated 4 new + 46 unchanged - 6 fixed = 50 total (was 52) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 2m 58s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 5m 15s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 32s | the patch passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 0m 43s | the patch passed with JDK v1.7.0_232 | | :broken_heart: | findbugs | 3m 3s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | :broken_heart: | unit | 34m 41s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 77m 26s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.io.hfile.bucket.FileIOEngine.verifyFileIntegrity(String, ObjectInputStream) ignores result of java.io.ObjectInputStream.read(byte[]) At FileIOEngine.java:java.io.ObjectInputStream.read(byte[]) At FileIOEngine.java:[line 95] | | Failed junit tests | hadoop.hbase.io.hfile.bucket.TestBucketCache | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-633/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/633 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2a13dce83b51 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-633/out/precommit/personality/provided.sh | | git revision | branch-1 / 5c4d8e0 | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_222 /usr/lib/jvm/zulu-7-amd64:1.7.0_232 | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-633/1/artifact/out/branch-compile-hbase-server-jdk1.7.0_232.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-633/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_232.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-633/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_232.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-633/1/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/
[GitHub] [hbase] Apache-HBase commented on issue #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin
Apache-HBase commented on issue #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin URL: https://github.com/apache/hbase/pull/613#issuecomment-532275916 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 49s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :blue_heart: | prototool | 0m 0s | prototool was not available. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. | ||| _ HBASE-22514 Compile Tests _ | | :blue_heart: | mvndep | 0m 36s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 6m 14s | HBASE-22514 passed | | :green_heart: | compile | 3m 32s | HBASE-22514 passed | | :green_heart: | checkstyle | 3m 20s | HBASE-22514 passed | | :green_heart: | shadedjars | 5m 56s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 2m 11s | HBASE-22514 passed | | :blue_heart: | spotbugs | 1m 50s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 12m 47s | HBASE-22514 passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 16s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 6m 8s | the patch passed | | :green_heart: | compile | 3m 31s | the patch passed | | :green_heart: | cc | 3m 31s | the patch passed | | :green_heart: | javac | 3m 31s | the patch passed | | :broken_heart: | checkstyle | 0m 39s | hbase-client: The patch generated 6 new + 162 unchanged - 0 fixed = 168 total (was 162) | | :broken_heart: | checkstyle | 1m 34s | hbase-server: The patch generated 22 new + 87 unchanged - 2 fixed = 109 total (was 89) | | :broken_heart: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | :green_heart: | shadedjars | 5m 48s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 16s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | hbaseprotoc | 3m 4s | the patch passed | | :broken_heart: | javadoc | 0m 36s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | :green_heart: | findbugs | 12m 42s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 0m 43s | hbase-protocol-shaded in the patch passed. | | :green_heart: | unit | 0m 29s | hbase-protocol in the patch passed. | | :green_heart: | unit | 1m 51s | hbase-client in the patch passed. | | :green_heart: | unit | 181m 16s | hbase-server in the patch passed. | | :green_heart: | unit | 4m 14s | hbase-thrift in the patch passed. | | :green_heart: | asflicense | 2m 17s | The patch does not generate ASF License warnings. | | | | 287m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/613 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux 447bb95e6a8c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-613/out/precommit/personality/provided.sh | | git revision | HBASE-22514 / 9300631fa8 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/3/artifact/out/diff-checkstyle-hbase-client.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/3/artifact/out/diff-checkstyle-hbase-server.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/3/artifact/out/whitespace-eol.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/3/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/3/testReport/ | | Max. process+thread count | 4982 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-p
[GitHub] [hbase] Apache-HBase commented on issue #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created
Apache-HBase commented on issue #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created URL: https://github.com/apache/hbase/pull/581#issuecomment-532281162 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 14 new or modified test files. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 6m 13s | master passed | | :green_heart: | compile | 1m 1s | master passed | | :green_heart: | checkstyle | 1m 34s | master passed | | :green_heart: | shadedjars | 5m 16s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 41s | master passed | | :blue_heart: | spotbugs | 4m 30s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 28s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 5m 40s | the patch passed | | :green_heart: | compile | 1m 7s | the patch passed | | :green_heart: | javac | 1m 7s | the patch passed | | :green_heart: | checkstyle | 1m 35s | hbase-server: The patch generated 0 new + 261 unchanged - 13 fixed = 261 total (was 274) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 16s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 18m 7s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 38s | the patch passed | | :green_heart: | findbugs | 4m 48s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 162m 42s | hbase-server in the patch passed. | | :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. | | | | 227m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/581 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e437db91d805 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-581/out/precommit/personality/provided.sh | | git revision | master / 0dbae8f0e1 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/7/testReport/ | | Max. process+thread count | 4463 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/7/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22846) Internal Error 500 when Using HBASE REST API to Create Namespace.
[
https://issues.apache.org/jira/browse/HBASE-22846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931608#comment-16931608
]
Hudson commented on HBASE-22846:
Results for branch branch-2.1
[build #1607 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1607/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1607//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1607//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1607//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Internal Error 500 when Using HBASE REST API to Create Namespace.
> -
>
> Key: HBASE-22846
> URL: https://issues.apache.org/jira/browse/HBASE-22846
> Project: HBase
> Issue Type: Improvement
> Components: hbase-connectors
>Affects Versions: 3.0.0, 2.2.0, 2.1.1
>Reporter: Sailesh Patel
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
>
> When trying to the following URL to create namespace:
> Secured cluster: curl --negotiate -u : -i -k -vi -X POST
> "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest";
> UnSecured cluster: curl -vi -X POST
> "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest";
> The following is returned on the console:
> HTTP/1.1 500 Request failed.
> The Error in Hbase REST Server log is:
> 2019-08-13 15:44:55,080 WARN org.eclipse.jetty.servlet.ServletHandler:
> javax.servlet.ServletException: java.lang.NullPointerException
> at
> org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489)
> at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427)
> ...
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.createOrUpdate(NamespacesInstanceResource.java:250)
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.processUpdate(NamespacesInstanceResource.java:243)
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.post(NamespacesInstanceResource.java:183)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81)
> at
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144)
> at
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161)
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22846) Internal Error 500 when Using HBASE REST API to Create Namespace.
[
https://issues.apache.org/jira/browse/HBASE-22846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931640#comment-16931640
]
Hudson commented on HBASE-22846:
Results for branch branch-2
[build #2268 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2268/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2268//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2268//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2268//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Internal Error 500 when Using HBASE REST API to Create Namespace.
> -
>
> Key: HBASE-22846
> URL: https://issues.apache.org/jira/browse/HBASE-22846
> Project: HBase
> Issue Type: Improvement
> Components: hbase-connectors
>Affects Versions: 3.0.0, 2.2.0, 2.1.1
>Reporter: Sailesh Patel
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
>
> When trying to the following URL to create namespace:
> Secured cluster: curl --negotiate -u : -i -k -vi -X POST
> "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest";
> UnSecured cluster: curl -vi -X POST
> "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest";
> The following is returned on the console:
> HTTP/1.1 500 Request failed.
> The Error in Hbase REST Server log is:
> 2019-08-13 15:44:55,080 WARN org.eclipse.jetty.servlet.ServletHandler:
> javax.servlet.ServletException: java.lang.NullPointerException
> at
> org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489)
> at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427)
> ...
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.createOrUpdate(NamespacesInstanceResource.java:250)
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.processUpdate(NamespacesInstanceResource.java:243)
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.post(NamespacesInstanceResource.java:183)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81)
> at
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144)
> at
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161)
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] saintstack merged pull request #630: HBASE-23030 Update completebulkload hadoop jar usage in related doc
saintstack merged pull request #630: HBASE-23030 Update completebulkload hadoop jar usage in related doc URL: https://github.com/apache/hbase/pull/630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23030) Update completebulkload hadoop jar usage in related doc
[ https://issues.apache.org/jira/browse/HBASE-23030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-23030. --- Fix Version/s: 3.0.0 Assignee: stack Resolution: Fixed Merged the PR. Thanks for the patch and justification [~liujiayi771] > Update completebulkload hadoop jar usage in related doc > --- > > Key: HBASE-23030 > URL: https://issues.apache.org/jira/browse/HBASE-23030 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Jiayi Liu >Assignee: stack >Priority: Minor > Fix For: 3.0.0 > > > Update the usage of completebulkload from "hadoop jar > hbase-server-VERSION.jar completebulkload" to "hadoop jar > hbase-mapreduce-VERSION.jar completebulkload" according to > [HBASE-18698|https://issues.apache.org/jira/browse/HBASE-18698] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] wchevreuil commented on issue #494: HBASE-22380 break circle replication when doing bulkload
wchevreuil commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-532307413 > In this case though, I believe the complaint from findbugs is that we should be using entrySet instead of both keySet and then getValue with the key. Thanks for the tip, @busbey! Had gone with that on the last commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501#issuecomment-532307719 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 33s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 33s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 56s | master passed | | :green_heart: | compile | 1m 23s | master passed | | :green_heart: | checkstyle | 2m 2s | master passed | | :green_heart: | shadedjars | 5m 20s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 11s | master passed | | :blue_heart: | spotbugs | 5m 1s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 6m 21s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 16s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 5m 46s | the patch passed | | :green_heart: | compile | 1m 37s | the patch passed | | :green_heart: | javac | 1m 37s | the patch passed | | :green_heart: | checkstyle | 2m 11s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 28s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 18m 47s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 1m 4s | the patch passed | | :green_heart: | findbugs | 6m 47s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 1m 58s | hbase-client in the patch passed. | | :broken_heart: | unit | 244m 24s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 43s | The patch does not generate ASF License warnings. | | | | 320m 45s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/501 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4682d2976929 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-501/out/precommit/personality/provided.sh | | git revision | master / 9198525501 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/1/testReport/ | | Max. process+thread count | 4837 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] wchevreuil edited a comment on issue #494: HBASE-22380 break circle replication when doing bulkload
wchevreuil edited a comment on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-532307413 > In this case though, I believe the complaint from findbugs is that we should be using entrySet instead of both keySet and then getValue with the key. Thanks for the tip, @busbey! Had gone with that on the last commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack merged pull request #501: HBASE-22699 refactor isMetaClearingException
saintstack merged pull request #501: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #632: HBASE-23037 Make the split WAL related log more readable
Apache-HBase commented on issue #632: HBASE-23037 Make the split WAL related log more readable URL: https://github.com/apache/hbase/pull/632#issuecomment-532310668 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 32s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 8m 22s | master passed | | :green_heart: | compile | 1m 25s | master passed | | :green_heart: | checkstyle | 2m 6s | master passed | | :green_heart: | shadedjars | 6m 27s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 53s | master passed | | :blue_heart: | spotbugs | 5m 41s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 5m 38s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 7m 27s | the patch passed | | :green_heart: | compile | 1m 21s | the patch passed | | :green_heart: | javac | 1m 21s | the patch passed | | :broken_heart: | checkstyle | 1m 42s | hbase-server: The patch generated 1 new + 17 unchanged - 0 fixed = 18 total (was 17) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 51s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 22m 34s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 49s | the patch passed | | :green_heart: | findbugs | 5m 17s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 272m 53s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 354m 0s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-632/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/632 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7d8421b12e4a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-632/out/precommit/personality/provided.sh | | git revision | master / 9198525501 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-632/1/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-632/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-632/1/testReport/ | | Max. process+thread count | 4904 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-632/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Reopened] (HBASE-22699) refactor isMetaClearingException
[ https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack reopened HBASE-22699: --- Reopening to note merge of master PR. > refactor isMetaClearingException > > > Key: HBASE-22699 > URL: https://issues.apache.org/jira/browse/HBASE-22699 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Minor > Fix For: 2.3.0, 2.2.2 > > > It is not so readable -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22699) refactor isMetaClearingException
[ https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22699: -- Fix Version/s: 3.0.0 > refactor isMetaClearingException > > > Key: HBASE-22699 > URL: https://issues.apache.org/jira/browse/HBASE-22699 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.2 > > > It is not so readable -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (HBASE-22699) refactor isMetaClearingException
[ https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-22699. --- Resolution: Fixed Merged PR #501. Thanks for the patch [~Joseph295] > refactor isMetaClearingException > > > Key: HBASE-22699 > URL: https://issues.apache.org/jira/browse/HBASE-22699 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Minor > Fix For: 2.3.0, 2.2.2 > > > It is not so readable -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (HBASE-23038) Provide consistent and clear logging about disabling chores
Sean Busbey created HBASE-23038:
---
Summary: Provide consistent and clear logging about disabling
chores
Key: HBASE-23038
URL: https://issues.apache.org/jira/browse/HBASE-23038
Project: HBase
Issue Type: Improvement
Components: master, regionserver
Reporter: Sean Busbey
Right now if you want to disable any of our chores you can set the period to be
<= 0. Sometimes, if you do this you get a nice message:
{code}
2019-09-16 22:10:16,756 INFO [master-1:16000.activeMasterManager]
master.HMaster: The period is 0 seconds, MobCompactionChore is disabled
{code}
And sometimes you get an opaque message:
{code}
2019-09-16 22:09:45,333 INFO [master-1:16000.activeMasterManager]
hbase.ChoreService: Could not successfully schedule chore: LogsCleaner
2019-09-16 22:09:45,340 INFO [master-1:16000.activeMasterManager]
hbase.ChoreService: Could not successfully schedule chore: HFileCleaner
{code}
This is because sometimes we just blindly submit to ChoreService which submits
to a java ScheduledExecutorService and then catches the
IllegalArgumentException.
We should remove the one-offs and make it so ChoreService checks the period
before accepting a submittal and produces a consistent "Foo is disabled"
message.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22846) Internal Error 500 when Using HBASE REST API to Create Namespace.
[
https://issues.apache.org/jira/browse/HBASE-22846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931707#comment-16931707
]
Hudson commented on HBASE-22846:
Results for branch branch-2.2
[build #614 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/614/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/614//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/614//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/614//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Internal Error 500 when Using HBASE REST API to Create Namespace.
> -
>
> Key: HBASE-22846
> URL: https://issues.apache.org/jira/browse/HBASE-22846
> Project: HBase
> Issue Type: Improvement
> Components: hbase-connectors
>Affects Versions: 3.0.0, 2.2.0, 2.1.1
>Reporter: Sailesh Patel
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
>
> When trying to the following URL to create namespace:
> Secured cluster: curl --negotiate -u : -i -k -vi -X POST
> "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest";
> UnSecured cluster: curl -vi -X POST
> "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest";
> The following is returned on the console:
> HTTP/1.1 500 Request failed.
> The Error in Hbase REST Server log is:
> 2019-08-13 15:44:55,080 WARN org.eclipse.jetty.servlet.ServletHandler:
> javax.servlet.ServletException: java.lang.NullPointerException
> at
> org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489)
> at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427)
> ...
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.createOrUpdate(NamespacesInstanceResource.java:250)
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.processUpdate(NamespacesInstanceResource.java:243)
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.post(NamespacesInstanceResource.java:183)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81)
> at
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144)
> at
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161)
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22460) Reopen a region if store reader references may have leaked
[ https://issues.apache.org/jira/browse/HBASE-22460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931719#comment-16931719 ] Viraj Jasani commented on HBASE-22460: -- Since the review is happening on github PR, removing the attached patch > Reopen a region if store reader references may have leaked > -- > > Key: HBASE-22460 > URL: https://issues.apache.org/jira/browse/HBASE-22460 > Project: HBase > Issue Type: Sub-task >Affects Versions: 3.0.0, 1.5.0, 2.3.0 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.3.0 > > Attachments: HBASE-22460.master.000.patch > > > We can leak store reader references if a coprocessor or core function somehow > opens a scanner, or wraps one, and then does not take care to call close on > the scanner or the wrapped instance. A reasonable mitigation for a reader > reference leak would be a fast reopen of the region on the same server > (initiated by the RS) This will release all resources, like the refcount, > leases, etc. The clients should gracefully ride over this like any other > region transition. This reopen would be like what is done during schema > change application and ideally would reuse the relevant code. If the refcount > is over some ridiculous threshold this mitigation could be triggered along > with a fat WARN in the logs. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22460) Reopen a region if store reader references may have leaked
[ https://issues.apache.org/jira/browse/HBASE-22460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22460: - Attachment: (was: HBASE-22460.master.000.patch) > Reopen a region if store reader references may have leaked > -- > > Key: HBASE-22460 > URL: https://issues.apache.org/jira/browse/HBASE-22460 > Project: HBase > Issue Type: Sub-task >Affects Versions: 3.0.0, 1.5.0, 2.3.0 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.3.0 > > > We can leak store reader references if a coprocessor or core function somehow > opens a scanner, or wraps one, and then does not take care to call close on > the scanner or the wrapped instance. A reasonable mitigation for a reader > reference leak would be a fast reopen of the region on the same server > (initiated by the RS) This will release all resources, like the refcount, > leases, etc. The clients should gracefully ride over this like any other > region transition. This reopen would be like what is done during schema > change application and ideally would reuse the relevant code. If the refcount > is over some ridiculous threshold this mitigation could be triggered along > with a fat WARN in the logs. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #566: HBASE-22380 break circle replication when doing bulkload
Apache-HBase commented on issue #566: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/566#issuecomment-532345226 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 0s | Docker mode activated. | | :broken_heart: | patch | 0m 5s | https://github.com/apache/hbase/pull/566 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/566 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-566/9/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22846) Internal Error 500 when Using HBASE REST API to Create Namespace.
[
https://issues.apache.org/jira/browse/HBASE-22846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931737#comment-16931737
]
Hudson commented on HBASE-22846:
Results for branch master
[build #1447 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1447/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1447//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1447//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1447//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Internal Error 500 when Using HBASE REST API to Create Namespace.
> -
>
> Key: HBASE-22846
> URL: https://issues.apache.org/jira/browse/HBASE-22846
> Project: HBase
> Issue Type: Improvement
> Components: hbase-connectors
>Affects Versions: 3.0.0, 2.2.0, 2.1.1
>Reporter: Sailesh Patel
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
>
> When trying to the following URL to create namespace:
> Secured cluster: curl --negotiate -u : -i -k -vi -X POST
> "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest";
> UnSecured cluster: curl -vi -X POST
> "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest";
> The following is returned on the console:
> HTTP/1.1 500 Request failed.
> The Error in Hbase REST Server log is:
> 2019-08-13 15:44:55,080 WARN org.eclipse.jetty.servlet.ServletHandler:
> javax.servlet.ServletException: java.lang.NullPointerException
> at
> org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489)
> at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427)
> ...
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.createOrUpdate(NamespacesInstanceResource.java:250)
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.processUpdate(NamespacesInstanceResource.java:243)
> at
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.post(NamespacesInstanceResource.java:183)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81)
> at
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144)
> at
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161)
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created
Apache-HBase commented on issue #581: HBASE-22888 Share some stuffs with the initial reader when new stream reader created URL: https://github.com/apache/hbase/pull/581#issuecomment-532349318 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 14 new or modified test files. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 5m 40s | master passed | | :green_heart: | compile | 0m 58s | master passed | | :green_heart: | checkstyle | 1m 26s | master passed | | :green_heart: | shadedjars | 4m 38s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 36s | master passed | | :blue_heart: | spotbugs | 4m 16s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 14s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 4m 58s | the patch passed | | :green_heart: | compile | 0m 59s | the patch passed | | :green_heart: | javac | 0m 59s | the patch passed | | :green_heart: | checkstyle | 1m 23s | hbase-server: The patch generated 0 new + 258 unchanged - 16 fixed = 258 total (was 274) | | :broken_heart: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | :green_heart: | shadedjars | 4m 31s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 15m 45s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 36s | the patch passed | | :green_heart: | findbugs | 4m 10s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 31m 45s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 89m 10s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestStoreFileInfo | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/581 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 20dbc9d4582c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-581/out/precommit/personality/provided.sh | | git revision | master / cb62f73406 | | Default Java | 1.8.0_181 | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/8/artifact/out/whitespace-eol.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/8/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/8/testReport/ | | Max. process+thread count | 692 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/8/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] srdo commented on a change in pull request #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
srdo commented on a change in pull request #361: HBase-22027: Split non-MR
related parts of TokenUtil off into a Clien…
URL: https://github.com/apache/hbase/pull/361#discussion_r325331505
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/ClientTokenUtil.java
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.security.token;
+
+import com.google.protobuf.ByteString;
+import com.google.protobuf.ServiceException;
+import java.io.IOException;
+import java.lang.reflect.UndeclaredThrowableException;
+import java.security.PrivilegedExceptionAction;
+import java.util.concurrent.CompletableFuture;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.AsyncConnection;
+import org.apache.hadoop.hbase.client.AsyncTable;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.ipc.CoprocessorRpcChannel;
+import org.apache.hadoop.hbase.protobuf.generated.AuthenticationProtos;
+import org.apache.hadoop.hbase.security.User;
+import org.apache.hadoop.io.Text;
+import org.apache.hadoop.security.token.Token;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+
+/**
+ * Utility methods for obtaining authentication tokens, that do not require
hbase-server.
+ */
+@InterfaceAudience.Public
+public final class ClientTokenUtil {
+ private static final Logger LOG =
LoggerFactory.getLogger(ClientTokenUtil.class);
+
+ // Set in TestClientTokenUtil via reflection
+ private static ServiceException injectedException;
+
+ private ClientTokenUtil() {}
+
+ private static void injectFault() throws ServiceException {
+if (injectedException != null) {
+ throw injectedException;
+}
+ }
+
+ /**
+ * Obtain and return an authentication token for the current user.
+ * @param conn The async HBase cluster connection
+ * @return the authentication token instance, wrapped by a {@link
CompletableFuture}.
+ */
+ @InterfaceAudience.Private
+ public static CompletableFuture>
obtainToken(
Review comment:
Only obtainToken(AsyncConnection) seems to need to be public, as it is used
by SecureBulkLoadManager. Everything else can be package private. Updated the
PR to make the methods package private, as well as to get rid of uses of the
deprecated TokenUtil methods.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #600: HBASE-22460 : Reopen regions with very high Store Ref Counts
virajjasani commented on issue #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#issuecomment-532364091 Updated the PR with suggested changes. Please review @anoopsjohn This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #595: HBASE-22971 Deprecated RSGroupAdminEndpoint and make RSGroup feature …
Apache-HBase commented on issue #595: HBASE-22971 Deprecated RSGroupAdminEndpoint and make RSGroup feature … URL: https://github.com/apache/hbase/pull/595#issuecomment-532377669 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 2m 41s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 9 new or modified test files. | ||| _ HBASE-22514 Compile Tests _ | | :green_heart: | mvninstall | 6m 45s | HBASE-22514 passed | | :green_heart: | compile | 0m 58s | HBASE-22514 passed | | :green_heart: | checkstyle | 1m 37s | HBASE-22514 passed | | :green_heart: | shadedjars | 5m 19s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 41s | HBASE-22514 passed | | :blue_heart: | spotbugs | 4m 44s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 42s | HBASE-22514 passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 5m 27s | the patch passed | | :green_heart: | compile | 0m 58s | the patch passed | | :green_heart: | javac | 0m 58s | the patch passed | | :broken_heart: | checkstyle | 1m 28s | hbase-server: The patch generated 13 new + 200 unchanged - 4 fixed = 213 total (was 204) | | :broken_heart: | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | :green_heart: | shadedjars | 4m 51s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 16m 23s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 36s | the patch passed | | :green_heart: | findbugs | 4m 31s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 322m 17s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. | | | | 386m 40s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.access.TestTablePermissions | | | hadoop.hbase.regionserver.TestRegionOpen | | | hadoop.hbase.master.TestDLSFSHLog | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.master.procedure.TestReopenTableRegionsProcedureInfiniteLoop | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | | hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicasWithoutZKCoordinated | | | hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicas | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.master.TestMasterRestartAfterDisablingTable | | | hadoop.hbase.replication.TestReplicationSmallTestsSync | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-595/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/595 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4e7fd25a709a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-595/out/precommit/personality/provided.sh | | git revision | HBASE-22514 / 9300631fa8 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-595/5/artifact/out/diff-checkstyle-hbase-server.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-595/5/artifact/out/whitespace-eol.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-595/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-595/5/testReport/ | | Max. process+thread count | 4735 (vs. ulimit of 1) | | modules | C: hbase-server
[jira] [Commented] (HBASE-23024) Replace Exception.initCause() with Constructor args
[
https://issues.apache.org/jira/browse/HBASE-23024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931793#comment-16931793
]
Hudson commented on HBASE-23024:
Results for branch branch-1
[build #1072 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1072/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1072//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1072//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1072//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Replace Exception.initCause() with Constructor args
> ---
>
> Key: HBASE-23024
> URL: https://issues.apache.org/jira/browse/HBASE-23024
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
>
> We can use parameterized constructor for providing root cause of some
> Exceptions based on the availability of such constructors to avoid calling
> .initCause() for Exceptions.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #615: HBASE-22975 Add read and write QPS metrics at server level and table level
Apache-HBase commented on issue #615: HBASE-22975 Add read and write QPS metrics at server level and table level URL: https://github.com/apache/hbase/pull/615#issuecomment-532409074 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 37s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 6m 14s | master passed | | :green_heart: | compile | 1m 35s | master passed | | :green_heart: | checkstyle | 1m 53s | master passed | | :green_heart: | shadedjars | 4m 31s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 13s | master passed | | :blue_heart: | spotbugs | 4m 31s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 5m 32s | master passed | | :yellow_heart: | patch | 4m 53s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 5m 16s | the patch passed | | :green_heart: | compile | 1m 44s | the patch passed | | :green_heart: | javac | 1m 44s | the patch passed | | :green_heart: | checkstyle | 2m 4s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 35s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 16m 24s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 1m 7s | the patch passed | | :green_heart: | findbugs | 5m 29s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 0m 33s | hbase-hadoop-compat in the patch passed. | | :green_heart: | unit | 0m 37s | hbase-hadoop2-compat in the patch passed. | | :broken_heart: | unit | 160m 12s | hbase-server in the patch failed. | | :green_heart: | asflicense | 1m 25s | The patch does not generate ASF License warnings. | | | | 228m 53s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSizeFailures | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-615/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/615 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e369a048a5ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-615/out/precommit/personality/provided.sh | | git revision | master / cb62f73406 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-615/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-615/3/testReport/ | | Max. process+thread count | 4909 (vs. ulimit of 1) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-615/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shahrs87 commented on a change in pull request #580: [HBASE-22874] Canary should not be IA.Public
shahrs87 commented on a change in pull request #580: [HBASE-22874] Canary
should not be IA.Public
URL: https://github.com/apache/hbase/pull/580#discussion_r325407321
##
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
##
@@ -119,8 +119,35 @@
*
*
*/
-@InterfaceAudience.Private
-public final class Canary implements Tool {
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.TOOLS)
+public class Canary implements Tool, CanaryInterface {
Review comment:
@saintstack @busbey Addressed your comments in latest commit. Could you
please review. Thank you !
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23024) Replace Exception.initCause() with Constructor args
[
https://issues.apache.org/jira/browse/HBASE-23024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931881#comment-16931881
]
Hudson commented on HBASE-23024:
Results for branch branch-2
[build #2269 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2269/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2269//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2269//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2269//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Replace Exception.initCause() with Constructor args
> ---
>
> Key: HBASE-23024
> URL: https://issues.apache.org/jira/browse/HBASE-23024
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
>
> We can use parameterized constructor for providing root cause of some
> Exceptions based on the availability of such constructors to avoid calling
> .initCause() for Exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22700) Incorrect timeout in recommended ZooKeeper configuration
[
https://issues.apache.org/jira/browse/HBASE-22700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931891#comment-16931891
]
Hudson commented on HBASE-22700:
Results for branch master
[build #1450 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1450/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1450//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1450//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1450//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Incorrect timeout in recommended ZooKeeper configuration
>
>
> Key: HBASE-22700
> URL: https://issues.apache.org/jira/browse/HBASE-22700
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Peter Somogyi
>Assignee: maoling
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
>
> The [Recommended
> configuration|https://hbase.apache.org/book.html#recommended_configurations.zk]
> section for ZooKeeper states that the default zookeeper.session.timeout is 3
> minutes, however, the [default
> configuration|https://github.com/apache/hbase/blob/master/hbase-common/src/main/resources/hbase-default.xml#L372-L373]
> is 90 seconds(
>
> {code:java}
> /** Default value for ZooKeeper session timeout */
> public static final int DEFAULT_ZK_SESSION_TIMEOUT = 90 * 1000;
> ).
> {code}
>
> This section in the documentation should be modified to reflect the default
> configuration.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23024) Replace Exception.initCause() with Constructor args
[
https://issues.apache.org/jira/browse/HBASE-23024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931910#comment-16931910
]
Hudson commented on HBASE-23024:
Results for branch master
[build #1448 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1448/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1448//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1448//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1448//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Replace Exception.initCause() with Constructor args
> ---
>
> Key: HBASE-23024
> URL: https://issues.apache.org/jira/browse/HBASE-23024
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
>
> We can use parameterized constructor for providing root cause of some
> Exceptions based on the availability of such constructors to avoid calling
> .initCause() for Exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-532442498 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 36s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 18s | master passed | | :green_heart: | compile | 1m 21s | master passed | | :green_heart: | checkstyle | 1m 50s | master passed | | :green_heart: | shadedjars | 4m 28s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 2s | master passed | | :blue_heart: | spotbugs | 4m 4s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 5m 9s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 4m 58s | the patch passed | | :green_heart: | compile | 1m 20s | the patch passed | | :green_heart: | javac | 1m 20s | the patch passed | | :green_heart: | checkstyle | 1m 48s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 36s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 15m 28s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 58s | the patch passed | | :green_heart: | findbugs | 5m 23s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 1m 39s | hbase-client in the patch failed. | | :green_heart: | unit | 160m 49s | hbase-server in the patch passed. | | :green_heart: | asflicense | 1m 5s | The patch does not generate ASF License warnings. | | | | 225m 24s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.token.TestClientTokenUtil | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/153/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 10a411869ed2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / cb62f73406 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/153/artifact/out/patch-unit-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/153/testReport/ | | Max. process+thread count | 4610 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/153/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin
Apache-HBase commented on issue #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin URL: https://github.com/apache/hbase/pull/613#issuecomment-532447027 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 19s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :blue_heart: | prototool | 0m 0s | prototool was not available. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. | ||| _ HBASE-22514 Compile Tests _ | | :blue_heart: | mvndep | 1m 3s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 6m 5s | HBASE-22514 passed | | :green_heart: | compile | 3m 25s | HBASE-22514 passed | | :green_heart: | checkstyle | 3m 15s | HBASE-22514 passed | | :green_heart: | shadedjars | 5m 23s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 2m 8s | HBASE-22514 passed | | :blue_heart: | spotbugs | 1m 49s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 13m 1s | HBASE-22514 passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 5m 52s | the patch passed | | :green_heart: | compile | 3m 30s | the patch passed | | :green_heart: | cc | 3m 30s | the patch passed | | :green_heart: | javac | 3m 30s | the patch passed | | :broken_heart: | checkstyle | 0m 41s | hbase-client: The patch generated 6 new + 162 unchanged - 0 fixed = 168 total (was 162) | | :broken_heart: | checkstyle | 1m 36s | hbase-server: The patch generated 22 new + 87 unchanged - 2 fixed = 109 total (was 89) | | :broken_heart: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | :green_heart: | shadedjars | 5m 12s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 55s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | hbaseprotoc | 3m 3s | the patch passed | | :broken_heart: | javadoc | 0m 39s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | :green_heart: | findbugs | 14m 29s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 0m 54s | hbase-protocol-shaded in the patch passed. | | :green_heart: | unit | 0m 31s | hbase-protocol in the patch passed. | | :green_heart: | unit | 2m 13s | hbase-client in the patch passed. | | :broken_heart: | unit | 306m 17s | hbase-server in the patch failed. | | :green_heart: | unit | 4m 57s | hbase-thrift in the patch passed. | | :green_heart: | asflicense | 2m 14s | The patch does not generate ASF License warnings. | | | | 416m 23s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/613 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux 1ff385050790 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-613/out/precommit/personality/provided.sh | | git revision | HBASE-22514 / 9300631fa8 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/4/artifact/out/diff-checkstyle-hbase-client.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/4/artifact/out/diff-checkstyle-hbase-server.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/4/artifact/out/whitespace-eol.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-613/4/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | uni
[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload URL: https://github.com/apache/hbase/pull/494#issuecomment-532466460 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 2m 35s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :blue_heart: | prototool | 0m 0s | prototool was not available. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-2 Compile Tests _ | | :blue_heart: | mvndep | 0m 18s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 8m 9s | branch-2 passed | | :green_heart: | compile | 2m 37s | branch-2 passed | | :green_heart: | checkstyle | 2m 54s | branch-2 passed | | :green_heart: | shadedjars | 5m 45s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 35s | branch-2 passed | | :blue_heart: | spotbugs | 4m 6s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 8m 51s | branch-2 passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 16s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 7m 6s | the patch passed | | :green_heart: | compile | 2m 42s | the patch passed | | :green_heart: | cc | 2m 42s | the patch passed | | :green_heart: | javac | 2m 42s | the patch passed | | :broken_heart: | checkstyle | 1m 49s | hbase-server: The patch generated 1 new + 300 unchanged - 0 fixed = 301 total (was 300) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 43s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 23m 7s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | hbaseprotoc | 2m 32s | the patch passed | | :green_heart: | javadoc | 1m 40s | the patch passed | | :green_heart: | findbugs | 9m 29s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 0m 47s | hbase-protocol-shaded in the patch passed. | | :green_heart: | unit | 2m 41s | hbase-client in the patch passed. | | :broken_heart: | unit | 279m 32s | hbase-server in the patch failed. | | :green_heart: | asflicense | 1m 15s | The patch does not generate ASF License warnings. | | | | 381m 49s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/47/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/494 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux bcb90a6f9458 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh | | git revision | branch-2 / faed3e457d | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/47/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/47/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/47/testReport/ | | Max. process+thread count | 3944 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/47/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infras
[jira] [Commented] (HBASE-23030) Update completebulkload hadoop jar usage in related doc
[
https://issues.apache.org/jira/browse/HBASE-23030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931943#comment-16931943
]
Hudson commented on HBASE-23030:
Results for branch master
[build #1449 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1449/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1449//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1449//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1449//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update completebulkload hadoop jar usage in related doc
> ---
>
> Key: HBASE-23030
> URL: https://issues.apache.org/jira/browse/HBASE-23030
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Jiayi Liu
>Assignee: stack
>Priority: Minor
> Fix For: 3.0.0
>
>
> Update the usage of completebulkload from "hadoop jar
> hbase-server-VERSION.jar completebulkload" to "hadoop jar
> hbase-mapreduce-VERSION.jar completebulkload" according to
> [HBASE-18698|https://issues.apache.org/jira/browse/HBASE-18698]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] sunhelly commented on issue #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin
sunhelly commented on issue #613: HBASE-22932 Add rs group management methods in Admin and AsyncAdmin URL: https://github.com/apache/hbase/pull/613#issuecomment-532475318 All relevant UTs have passed, ping @Apache9 @infraio for reviewing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #600: HBASE-22460 : Reopen regions with very high Store Ref Counts
Apache-HBase commented on issue #600: HBASE-22460 : Reopen regions with very high Store Ref Counts URL: https://github.com/apache/hbase/pull/600#issuecomment-532480549 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :blue_heart: | prototool | 0m 0s | prototool was not available. | | :green_heart: | hbaseanti | 0m 1s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 1m 3s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 27s | master passed | | :green_heart: | compile | 3m 4s | master passed | | :green_heart: | checkstyle | 2m 40s | master passed | | :blue_heart: | refguide | 5m 38s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | :green_heart: | shadedjars | 4m 54s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 5m 15s | master passed | | :blue_heart: | spotbugs | 4m 14s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 28m 6s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 6m 24s | the patch passed | | :green_heart: | compile | 3m 48s | the patch passed | | :green_heart: | cc | 3m 48s | the patch passed | | :green_heart: | javac | 3m 48s | the patch passed | | :green_heart: | checkstyle | 3m 14s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | :blue_heart: | refguide | 7m 14s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | :green_heart: | shadedjars | 6m 4s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 20m 8s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | hbaseprotoc | 10m 39s | the patch passed | | :green_heart: | javadoc | 6m 9s | the patch passed | | :green_heart: | findbugs | 30m 41s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 250m 39s | root in the patch passed. | | :green_heart: | asflicense | 5m 19s | The patch does not generate ASF License warnings. | | | | 417m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-600/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/600 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool | | uname | Linux ac7bbf7c4a4f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-600/out/precommit/personality/provided.sh | | git revision | master / cb62f73406 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-600/2/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-600/2/artifact/out/patch-site/book.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-600/2/testReport/ | | Max. process+thread count | 5458 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-common hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-600/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL
[jira] [Created] (HBASE-23039) HBCK2 bypass -r command does not work
Yi Mei created HBASE-23039:
--
Summary: HBCK2 bypass -r command does not work
Key: HBASE-23039
URL: https://issues.apache.org/jira/browse/HBASE-23039
Project: HBase
Issue Type: Bug
Reporter: Yi Mei
The recursiveFlag is wrong:
{code:java}
boolean overrideFlag = commandLine.hasOption(override.getOpt());
boolean recursiveFlag = commandLine.hasOption(override.getOpt());
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-23039) HBCK2 bypass -r command does not work
[
https://issues.apache.org/jira/browse/HBASE-23039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Mei reassigned HBASE-23039:
--
Assignee: Yi Mei
> HBCK2 bypass -r command does not work
> -
>
> Key: HBASE-23039
> URL: https://issues.apache.org/jira/browse/HBASE-23039
> Project: HBase
> Issue Type: Bug
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
>
>
> The recursiveFlag is wrong:
> {code:java}
> boolean overrideFlag = commandLine.hasOption(override.getOpt());
> boolean recursiveFlag = commandLine.hasOption(override.getOpt());
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23039) HBCK2 bypass -r command does not work
[
https://issues.apache.org/jira/browse/HBASE-23039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Mei updated HBASE-23039:
---
Attachment: HBASE-23039.001.patch
> HBCK2 bypass -r command does not work
> -
>
> Key: HBASE-23039
> URL: https://issues.apache.org/jira/browse/HBASE-23039
> Project: HBase
> Issue Type: Bug
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Attachments: HBASE-23039.001.patch
>
>
>
> The recursiveFlag is wrong:
> {code:java}
> boolean overrideFlag = commandLine.hasOption(override.getOpt());
> boolean recursiveFlag = commandLine.hasOption(override.getOpt());
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23039) HBCK2 bypass -r command does not work
[
https://issues.apache.org/jira/browse/HBASE-23039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Mei updated HBASE-23039:
---
Status: Patch Available (was: Open)
> HBCK2 bypass -r command does not work
> -
>
> Key: HBASE-23039
> URL: https://issues.apache.org/jira/browse/HBASE-23039
> Project: HBase
> Issue Type: Bug
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Attachments: HBASE-23039.001.patch
>
>
>
> The recursiveFlag is wrong:
> {code:java}
> boolean overrideFlag = commandLine.hasOption(override.getOpt());
> boolean recursiveFlag = commandLine.hasOption(override.getOpt());
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23039) HBCK2 bypass -r command does not work
[
https://issues.apache.org/jira/browse/HBASE-23039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931966#comment-16931966
]
Duo Zhang commented on HBASE-23039:
---
+1.
> HBCK2 bypass -r command does not work
> -
>
> Key: HBASE-23039
> URL: https://issues.apache.org/jira/browse/HBASE-23039
> Project: HBase
> Issue Type: Bug
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Attachments: HBASE-23039.001.patch
>
>
>
> The recursiveFlag is wrong:
> {code:java}
> boolean overrideFlag = commandLine.hasOption(override.getOpt());
> boolean recursiveFlag = commandLine.hasOption(override.getOpt());
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23039) HBCK2 bypass -r command does not work
[
https://issues.apache.org/jira/browse/HBASE-23039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931968#comment-16931968
]
HBase QA commented on HBASE-23039:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-23039 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-23039 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12980562/HBASE-23039.001.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/906/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.0 https://yetus.apache.org |
This message was automatically generated.
> HBCK2 bypass -r command does not work
> -
>
> Key: HBASE-23039
> URL: https://issues.apache.org/jira/browse/HBASE-23039
> Project: HBase
> Issue Type: Bug
>Reporter: Yi Mei
>Assignee: Yi Mei
>Priority: Major
> Attachments: HBASE-23039.001.patch
>
>
>
> The recursiveFlag is wrong:
> {code:java}
> boolean overrideFlag = commandLine.hasOption(override.getOpt());
> boolean recursiveFlag = commandLine.hasOption(override.getOpt());
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
