[GitHub] [hbase] Apache-HBase commented on issue #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic
Apache-HBase commented on issue #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic URL: https://github.com/apache/hbase/pull/671#issuecomment-536255631 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :blue_heart: | shelldocs | 0m 0s | Shelldocs was not available. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 37s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 11s | Maven dependency ordering for patch | | :broken_heart: | shellcheck | 0m 4s | The patch generated 101 new + 120 unchanged - 50 fixed = 221 total (was 170) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | :blue_heart: | asflicense | 0m 0s | ASF License check generated no output? | | | | 2m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-671/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/671 | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux f1590910ce7b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-671/out/precommit/personality/provided.sh | | git revision | master / c1a476c492 | | shellcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-671/1/artifact/out/diff-patch-shellcheck.txt | | Max. process+thread count | 52 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-671/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23054) Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm
[
https://issues.apache.org/jira/browse/HBASE-23054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940256#comment-16940256
]
Hudson commented on HBASE-23054:
Results for branch branch-2.1
[build #1649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1649/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1649//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1649//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1649//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove synchronization block from MetaTableMetrics and fix LossyCounting
> algorithm
> --
>
> Key: HBASE-23054
> URL: https://issues.apache.org/jira/browse/HBASE-23054
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.5
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-23054.master.001.patch,
> HBASE-23054.master.002.patch
>
>
> While trying to use LossyCounting for HBASE-15519 , found following bugs in
> current implementation
> – Remove synchronization block from MetaTableMetrics to avoid congestion at
> the code
> – Fix license format
> – Fix LossyCounting algorithm as per
> [http://www.vldb.org/conf/2002/S10P03.pdf
> |http://www.vldb.org/conf/2002/S10P03.pdf]
> -- Avoid doing sweep on every insert in LossyCounting
> – Remove extra redundant data structures from MetaTableMetrics.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack opened a new pull request #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic
saintstack opened a new pull request #671: HBASE-23092 Make the RM tooling in dev-tools/create-release generic URL: https://github.com/apache/hbase/pull/671 Make the scripts generic. Set PROJECT environment variable and away you go; e.g. set it to hbase-operator-tools or to hbase-thirdparty. This commit includes a bunch of bugfixes and miscellaneous that came of trying to use the scripts making RCs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23092) Make the RM tooling in dev-tools/create-release generic
Michael Stack created HBASE-23092: - Summary: Make the RM tooling in dev-tools/create-release generic Key: HBASE-23092 URL: https://issues.apache.org/jira/browse/HBASE-23092 Project: HBase Issue Type: Task Environment: The dev-tools/create-release scripts were originally about creating hbase core RCs (Original idea and script versions were copied over from apache spark). Subsequently, they were checked into hbase-operator-tools repo and genericized so they worked in that context. Today, after a few mods, the create-release scripts from hbase-operator-tools w/ some edits generated an RC of hbase-thirdparty. This issue is edits on the dev-tools/create-tools on master branch so the scripts can create RCs across these three repos at least (with more to follow). Reporter: Michael Stack -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #663: HBASE-23078 BaseLoadBalancer should consider region replicas when ran…
Apache-HBase commented on issue #663: HBASE-23078 BaseLoadBalancer should consider region replicas when ran… URL: https://github.com/apache/hbase/pull/663#issuecomment-536252197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 5m 59s | master passed | | :green_heart: | compile | 0m 57s | master passed | | :green_heart: | checkstyle | 1m 32s | master passed | | :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 40s | master passed | | :blue_heart: | spotbugs | 4m 25s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 23s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 5m 30s | the patch passed | | :green_heart: | compile | 0m 56s | the patch passed | | :green_heart: | javac | 0m 56s | the patch passed | | :green_heart: | checkstyle | 1m 28s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 3s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 9s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 35s | the patch passed | | :green_heart: | findbugs | 4m 32s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 254m 8s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 316m 28s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestRegionBypass | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | | | hadoop.hbase.master.TestSplitWALManager | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-663/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/663 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 672d38183af9 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-663/out/precommit/personality/provided.sh | | git revision | master / 836368189a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-663/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-663/5/testReport/ | | Max. process+thread count | 5006 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-663/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #667: HBASE-23055 Alter hbase:meta
Apache-HBase commented on issue #667: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/667#issuecomment-536243524 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 35s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 34s | master passed | | :green_heart: | compile | 1m 59s | master passed | | :green_heart: | checkstyle | 2m 48s | master passed | | :green_heart: | shadedjars | 4m 57s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 31s | master passed | | :blue_heart: | spotbugs | 4m 29s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 6m 52s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 14s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 5m 23s | the patch passed | | :green_heart: | compile | 2m 2s | the patch passed | | :green_heart: | javac | 2m 2s | the patch passed | | :green_heart: | checkstyle | 0m 27s | The patch passed checkstyle in hbase-common | | :green_heart: | checkstyle | 0m 33s | hbase-client: The patch generated 0 new + 97 unchanged - 4 fixed = 97 total (was 101) | | :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-zookeeper | | :green_heart: | checkstyle | 1m 35s | hbase-server: The patch generated 0 new + 444 unchanged - 21 fixed = 444 total (was 465) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 58s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 1s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 1m 30s | the patch passed | | :green_heart: | findbugs | 7m 22s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 2m 54s | hbase-common in the patch passed. | | :green_heart: | unit | 1m 47s | hbase-client in the patch passed. | | :green_heart: | unit | 0m 47s | hbase-zookeeper in the patch passed. | | :green_heart: | unit | 156m 53s | hbase-server in the patch passed. | | :green_heart: | asflicense | 1m 34s | The patch does not generate ASF License warnings. | | | | 237m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-667/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/667 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 32969c8dc284 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-667/out/precommit/personality/provided.sh | | git revision | master / 836368189a | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-667/4/testReport/ | | Max. process+thread count | 4365 (vs. ulimit of 1) | | modules | C: hbase-common hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-667/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work started] (HBASE-23091) Upgrade to hbase-thirdparty 3.1.0
[ https://issues.apache.org/jira/browse/HBASE-23091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23091 started by Duo Zhang. - > Upgrade to hbase-thirdparty 3.1.0 > - > > Key: HBASE-23091 > URL: https://issues.apache.org/jira/browse/HBASE-23091 > Project: HBase > Issue Type: Task > Components: build, dependencies >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23091) Upgrade to hbase-thirdparty 3.1.0
[ https://issues.apache.org/jira/browse/HBASE-23091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23091: - Assignee: Duo Zhang > Upgrade to hbase-thirdparty 3.1.0 > - > > Key: HBASE-23091 > URL: https://issues.apache.org/jira/browse/HBASE-23091 > Project: HBase > Issue Type: Task > Components: build, dependencies >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23078) BaseLoadBalancer should consider region replicas when randomAssignment and roundRobinAssignment
[
https://issues.apache.org/jira/browse/HBASE-23078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-23078:
---
Issue Type: Bug (was: Task)
> BaseLoadBalancer should consider region replicas when randomAssignment and
> roundRobinAssignment
> ---
>
> Key: HBASE-23078
> URL: https://issues.apache.org/jira/browse/HBASE-23078
> Project: HBase
> Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
>
> Copied the comment in HBASE-23035.
>
> There are two problems about the LoadBalancer.
>
> 1. The cluster means the cluster state of the whole cluster. But
> hasRegionReplica is false, so it only create clusterstate by the regions
> which need to assign, not the whole cluster...
> {code:java}
> Cluster cluster = createCluster(servers, regions, false);
> List unassignedRegions = new ArrayList<>();
> roundRobinAssignment(cluster, regions, unassignedRegions,
> servers, assignments);
> protected Cluster createCluster(List servers,
> Collection regions,
> boolean hasRegionReplica) {
> // Get the snapshot of the current assignments for the regions in
> question, and then create
> // a cluster out of it. Note that we might have replicas already assigned
> to some servers
> // earlier. So we want to get the snapshot to see those assignments, but
> this will only contain
> // replicas of the regions that are passed (for performance).
> Map> clusterState = null;
> if (!hasRegionReplica) {
> clusterState = getRegionAssignmentsByServer(regions);
> } else {
> // for the case where we have region replica it is better we get the
> entire cluster's snapshot
> clusterState = getRegionAssignmentsByServer(null);
> }for (ServerName server : servers) {
> if (!clusterState.containsKey(server)) {
> clusterState.put(server, EMPTY_REGION_LIST);
> }
> }
> return new Cluster(regions, clusterState, null, this.regionFinder,
> rackManager);
> }
> {code}
> 2. wouldLowerAvailability method only consider the primary regions. The
> replica region can't assign to same server with primary region. But can be
> assigned to same server with other replica regions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23078) BaseLoadBalancer should consider region replicas when randomAssignment and roundRobinAssignment
[
https://issues.apache.org/jira/browse/HBASE-23078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940222#comment-16940222
]
Guanghao Zhang commented on HBASE-23078:
{quote}Or is is your supposition that this change is a bug fix and that now the
balancer will behave more properly?
{quote}
Sir, I thought this should be a bug fix, as hasRegionReplica always be false
even there have region replica..
> BaseLoadBalancer should consider region replicas when randomAssignment and
> roundRobinAssignment
> ---
>
> Key: HBASE-23078
> URL: https://issues.apache.org/jira/browse/HBASE-23078
> Project: HBase
> Issue Type: Task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
>
> Copied the comment in HBASE-23035.
>
> There are two problems about the LoadBalancer.
>
> 1. The cluster means the cluster state of the whole cluster. But
> hasRegionReplica is false, so it only create clusterstate by the regions
> which need to assign, not the whole cluster...
> {code:java}
> Cluster cluster = createCluster(servers, regions, false);
> List unassignedRegions = new ArrayList<>();
> roundRobinAssignment(cluster, regions, unassignedRegions,
> servers, assignments);
> protected Cluster createCluster(List servers,
> Collection regions,
> boolean hasRegionReplica) {
> // Get the snapshot of the current assignments for the regions in
> question, and then create
> // a cluster out of it. Note that we might have replicas already assigned
> to some servers
> // earlier. So we want to get the snapshot to see those assignments, but
> this will only contain
> // replicas of the regions that are passed (for performance).
> Map> clusterState = null;
> if (!hasRegionReplica) {
> clusterState = getRegionAssignmentsByServer(regions);
> } else {
> // for the case where we have region replica it is better we get the
> entire cluster's snapshot
> clusterState = getRegionAssignmentsByServer(null);
> }for (ServerName server : servers) {
> if (!clusterState.containsKey(server)) {
> clusterState.put(server, EMPTY_REGION_LIST);
> }
> }
> return new Cluster(regions, clusterState, null, this.regionFinder,
> rackManager);
> }
> {code}
> 2. wouldLowerAvailability method only consider the primary regions. The
> replica region can't assign to same server with primary region. But can be
> assigned to same server with other replica regions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23091) Upgrade to hbase-thirdparty 3.1.0
Duo Zhang created HBASE-23091: - Summary: Upgrade to hbase-thirdparty 3.1.0 Key: HBASE-23091 URL: https://issues.apache.org/jira/browse/HBASE-23091 Project: HBase Issue Type: Task Components: build, dependencies Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22380) break circle replication when doing bulkload
[ https://issues.apache.org/jira/browse/HBASE-22380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940197#comment-16940197 ] Duo Zhang commented on HBASE-22380: --- I think the addendum works? The flaky dashboard is fine now. > break circle replication when doing bulkload > > > Key: HBASE-22380 > URL: https://issues.apache.org/jira/browse/HBASE-22380 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.5, 2.3.0, 2.1.5, 1.3.5 >Reporter: chenxu >Assignee: Wellington Chevreuil >Priority: Critical > Labels: bulkload > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.1.7, 2.2.2, 1.4.12 > > Attachments: HBASE-22380.branch-2.1.0001.patch, > HBASE-22380.branch-2.1.0003.patch, HBASE-22380.branch-2.1.0004.patch > > > when enabled master-master bulkload replication, HFiles will be replicated > circularly between two clusters -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23087) Remove the deprecated bulkload method in AsyncClusterConnection
[ https://issues.apache.org/jira/browse/HBASE-23087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23087. --- Fix Version/s: 3.0.0 Hadoop Flags: Reviewed Assignee: Duo Zhang Resolution: Fixed Merged to master. Thanks [~wchevreuil] for reviewing. > Remove the deprecated bulkload method in AsyncClusterConnection > --- > > Key: HBASE-23087 > URL: https://issues.apache.org/jira/browse/HBASE-23087 > Project: HBase > Issue Type: Task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > > The class is IA.Private and it has not been released yet so let's just remove > this method to keep the class clean. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23035) Retain region to the last RegionServer make the failover slower
[
https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940194#comment-16940194
]
Hudson commented on HBASE-23035:
Results for branch branch-2.2
[build #644 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/644/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/644//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/644//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/644//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Retain region to the last RegionServer make the failover slower
> ---
>
> Key: HBASE-23035
> URL: https://issues.apache.org/jira/browse/HBASE-23035
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Now if one RS crashed, the regions will try to use the old location for the
> region deploy. But one RS only have 3 threads to open region by default. If a
> RS have hundreds of regions, the failover is very slower. Assign to same RS
> may have good locality if the Datanode is deploied on same host. But slower
> failover make the availability worse. And the locality is not big deal when
> deploy HBase on cloud.
> This was introduced by HBASE-18946.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23054) Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm
[
https://issues.apache.org/jira/browse/HBASE-23054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940195#comment-16940195
]
Hudson commented on HBASE-23054:
Results for branch branch-2.2
[build #644 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/644/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/644//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/644//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/644//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove synchronization block from MetaTableMetrics and fix LossyCounting
> algorithm
> --
>
> Key: HBASE-23054
> URL: https://issues.apache.org/jira/browse/HBASE-23054
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.5
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-23054.master.001.patch,
> HBASE-23054.master.002.patch
>
>
> While trying to use LossyCounting for HBASE-15519 , found following bugs in
> current implementation
> – Remove synchronization block from MetaTableMetrics to avoid congestion at
> the code
> – Fix license format
> – Fix LossyCounting algorithm as per
> [http://www.vldb.org/conf/2002/S10P03.pdf
> |http://www.vldb.org/conf/2002/S10P03.pdf]
> -- Avoid doing sweep on every insert in LossyCounting
> – Remove extra redundant data structures from MetaTableMetrics.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #670: HBASE-23087 Remove the deprecated bulkload method in AsyncClusterConn…
Apache9 merged pull request #670: HBASE-23087 Remove the deprecated bulkload method in AsyncClusterConn… URL: https://github.com/apache/hbase/pull/670 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23035) Retain region to the last RegionServer make the failover slower
[
https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940178#comment-16940178
]
Hudson commented on HBASE-23035:
Results for branch branch-2
[build #2305 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Retain region to the last RegionServer make the failover slower
> ---
>
> Key: HBASE-23035
> URL: https://issues.apache.org/jira/browse/HBASE-23035
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Now if one RS crashed, the regions will try to use the old location for the
> region deploy. But one RS only have 3 threads to open region by default. If a
> RS have hundreds of regions, the failover is very slower. Assign to same RS
> may have good locality if the Datanode is deploied on same host. But slower
> failover make the availability worse. And the locality is not big deal when
> deploy HBase on cloud.
> This was introduced by HBASE-18946.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23038) Provide consistent and clear logging about disabling chores
[
https://issues.apache.org/jira/browse/HBASE-23038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940177#comment-16940177
]
Hudson commented on HBASE-23038:
Results for branch branch-2
[build #2305 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide consistent and clear logging about disabling chores
> ---
>
> Key: HBASE-23038
> URL: https://issues.apache.org/jira/browse/HBASE-23038
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
>Reporter: Sean Busbey
>Assignee: Sanjeet Nishad
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
> Attachments: HBASE-23038.001.patch, HBASE-23038.002.patch,
> HBASE-23038.master.003.patch
>
>
> Right now if you want to disable any of our chores you can set the period to
> be <= 0. Sometimes, if you do this you get a nice message:
> {code}
> 2019-09-16 22:10:16,756 INFO [master-1:16000.activeMasterManager]
> master.HMaster: The period is 0 seconds, MobCompactionChore is disabled
> {code}
> And sometimes you get an opaque message:
> {code}
> 2019-09-16 22:09:45,333 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: LogsCleaner
> 2019-09-16 22:09:45,340 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: HFileCleaner
> {code}
> This is because sometimes we just blindly submit to ChoreService which
> submits to a java ScheduledExecutorService and then catches the
> IllegalArgumentException.
> We should remove the one-offs and make it so ChoreService checks the period
> before accepting a submittal and produces a consistent "Foo is disabled"
> message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23054) Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm
[
https://issues.apache.org/jira/browse/HBASE-23054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940179#comment-16940179
]
Hudson commented on HBASE-23054:
Results for branch branch-2
[build #2305 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2305//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove synchronization block from MetaTableMetrics and fix LossyCounting
> algorithm
> --
>
> Key: HBASE-23054
> URL: https://issues.apache.org/jira/browse/HBASE-23054
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.5
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-23054.master.001.patch,
> HBASE-23054.master.002.patch
>
>
> While trying to use LossyCounting for HBASE-15519 , found following bugs in
> current implementation
> – Remove synchronization block from MetaTableMetrics to avoid congestion at
> the code
> – Fix license format
> – Fix LossyCounting algorithm as per
> [http://www.vldb.org/conf/2002/S10P03.pdf
> |http://www.vldb.org/conf/2002/S10P03.pdf]
> -- Avoid doing sweep on every insert in LossyCounting
> – Remove extra redundant data structures from MetaTableMetrics.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-23035) Retain region to the last RegionServer make the failover slower
[ https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-23035. Fix Version/s: 2.1.7 Resolution: Fixed Pushed to branch-2.1+. Thanks all for reviewing. > Retain region to the last RegionServer make the failover slower > --- > > Key: HBASE-23035 > URL: https://issues.apache.org/jira/browse/HBASE-23035 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.3.0, 2.2.1, 2.1.6 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > Now if one RS crashed, the regions will try to use the old location for the > region deploy. But one RS only have 3 threads to open region by default. If a > RS have hundreds of regions, the failover is very slower. Assign to same RS > may have good locality if the Datanode is deploied on same host. But slower > failover make the availability worse. And the locality is not big deal when > deploy HBase on cloud. > This was introduced by HBASE-18946. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23084) Assertion "Added a key not lexically larger than previous" or "prevKey followed by a smaller key" caused abortion of RS
[
https://issues.apache.org/jira/browse/HBASE-23084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940175#comment-16940175
]
ranpanfeng commented on HBASE-23084:
[~zhangduo]
I use this property: hbase.hregion.compacting.memstore.type=EAGER,
out-of-order adjacent keys can ocurr in the same memstore segment? I guess the
prevKey in the end of former segment, the next key in the begin of the latter
counterpart. right?
> Assertion "Added a key not lexically larger than previous" or "prevKey
> followed by a smaller key" caused abortion of RS
> --
>
> Key: HBASE-23084
> URL: https://issues.apache.org/jira/browse/HBASE-23084
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Environment: We store many phoenix tables in hbase, only one table
> trigger this issues.
> When two jacent keys in wrong order, the observation as follows.
> 1. the prevKey is written into hbase via Put rpc
> 2. the current key via phoenix upsert statment( Multi rpc in underlying hbase)
> 3. the current Cell extends 1MB.
> 4. the error is easy to re-ocurr.
>Reporter: ranpanfeng
>Priority: Critical
>
> when auto flush and manual flush is invoked, cell in immutable memstore
> segment is scanned one by one to build data block and bloom filter block,
> during this time, two adjacent keys are compared to assert that they are in
> lexicographical order, but regretfully, the assertion fails in some
> scenarios, when RS encounter these assertion failure, always call abort
> function to terminate abnormally.
>
> the version is 0ba7cc01a13dbb7fec8e6c5d599fc8b4936bae61 tag: rel/2.1.5
>
> At least three cases are found.
> *error case#1: getQualifierArray throws
> java.lang.ArrayIndexOutOfBoundsException*
>
> {code:java}
> 17:57:50.328 [MemStoreFlusher.0] ERROR
> org.apache.hadoop.hbase.regionserver.HRegionServer - * ABORTING region
> server ${regionserver}: Replay of WAL required. Forcing server shutdown *
> org.apache.hadoop.hbase.DroppedSnapshotException: region: ${region}.
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2788)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2467)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2439)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2329)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:612)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:581)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:361)
> [hbase-server-2.1.5.jar:2.1.5]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]
> Caused by: java.lang.ArrayIndexOutOfBoundsException
> at
> org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray(ByteBufferUtils.java:1155)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.CellUtil.copyQualifierTo(CellUtil.java:309)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at org.apache.hadoop.hbase.CellUtil.cloneQualifier(CellUtil.java:121)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.ByteBufferKeyValue.getQualifierArray(ByteBufferKeyValue.java:112)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(CellUtil.java:1306)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at org.apache.hadoop.hbase.CellUtil.toString(CellUtil.java:1483)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.ByteBufferKeyValue.toString(ByteBufferKeyValue.java:296)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at java.lang.String.valueOf(String.java:2994) ~[?:1.8.0_144]
> at java.lang.StringBuilder.append(StringBuilder.java:131)
> ~[?:1.8.0_144]
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:1007)
> ~[hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:582)
> ~[hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:127)
> ~[hbase-server-2.1.5.jar:2.1.5]
> at
[jira] [Commented] (HBASE-22986) Add documentation for hbtop
[ https://issues.apache.org/jira/browse/HBASE-22986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940174#comment-16940174 ] Toshihiro Suzuki commented on HBASE-22986: -- [~busbey] [~psomogyi] How can I add images to the hbase-site repository? Do I need to create a pull request for the repo? or I can push to the repo directly? > Add documentation for hbtop > --- > > Key: HBASE-22986 > URL: https://issues.apache.org/jira/browse/HBASE-22986 > Project: HBase > Issue Type: Sub-task > Components: documentation, hbtop >Reporter: Toshihiro Suzuki >Assignee: Toshihiro Suzuki >Priority: Minor > > We already have README for hbtop, so we can make the refguide refer to this: > [https://github.com/apache/hbase/blob/master/hbase-hbtop/README.md] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22653) Do not run errorProne on JDK7
[
https://issues.apache.org/jira/browse/HBASE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940162#comment-16940162
]
Hudson commented on HBASE-22653:
Results for branch branch-1.4
[build #1038 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1038/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1038//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1038//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1038//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Do not run errorProne on JDK7
> -
>
> Key: HBASE-22653
> URL: https://issues.apache.org/jira/browse/HBASE-22653
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 1.5.0, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 1.5.0, 1.4.11
>
>
> Nightly JDK7 build fails for branch-1 and branch-1.4 when errorProne profile
> is used.
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project hbase-common: Execution default-compile of goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile failed: An API
> incompatibility was encountered while executing
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile:
> java.lang.UnsupportedClassVersionError: javax/tools/DiagnosticListener :
> Unsupported major.minor version 52.0{noformat}
> https://builds.apache.org/job/HBase%20Nightly/job/branch-1/929/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23090) Cannot start and stop HBase from start-hbase.sh and stop-hbase.sh files
[ https://issues.apache.org/jira/browse/HBASE-23090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940158#comment-16940158 ] Sean Busbey commented on HBASE-23090: - What's your bash version? > Cannot start and stop HBase from start-hbase.sh and stop-hbase.sh files > --- > > Key: HBASE-23090 > URL: https://issues.apache.org/jira/browse/HBASE-23090 > Project: HBase > Issue Type: Bug >Affects Versions: 2.2.1 > Environment: Ubuntu 16.04 >Reporter: Tikiri Diasena >Priority: Blocker > > Server fails to start with "55: [: false: unexpected operator" error when > running the start-hbase.sh script on Linux. Similarly when trying to run > stop-hbase.sh script it gives errors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #667: HBASE-23055 Alter hbase:meta
Apache-HBase commented on issue #667: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/667#issuecomment-536224182 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 34s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 48s | master passed | | :green_heart: | compile | 2m 2s | master passed | | :green_heart: | checkstyle | 2m 49s | master passed | | :green_heart: | shadedjars | 5m 0s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 31s | master passed | | :blue_heart: | spotbugs | 4m 22s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 6m 51s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 14s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 5m 21s | the patch passed | | :green_heart: | compile | 1m 59s | the patch passed | | :green_heart: | javac | 1m 59s | the patch passed | | :green_heart: | checkstyle | 0m 27s | The patch passed checkstyle in hbase-common | | :green_heart: | checkstyle | 0m 35s | hbase-client: The patch generated 0 new + 97 unchanged - 4 fixed = 97 total (was 101) | | :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-zookeeper | | :green_heart: | checkstyle | 1m 32s | hbase-server: The patch generated 0 new + 444 unchanged - 21 fixed = 444 total (was 465) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 58s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 13s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 1m 30s | the patch passed | | :green_heart: | findbugs | 7m 23s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 2m 54s | hbase-common in the patch passed. | | :green_heart: | unit | 1m 55s | hbase-client in the patch passed. | | :green_heart: | unit | 0m 50s | hbase-zookeeper in the patch passed. | | :broken_heart: | unit | 160m 43s | hbase-server in the patch failed. | | :green_heart: | asflicense | 1m 35s | The patch does not generate ASF License warnings. | | | | 242m 2s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestMasterShutdown | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-667/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/667 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 27b5fe79d602 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-667/out/precommit/personality/provided.sh | | git revision | master / 836368189a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-667/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-667/3/testReport/ | | Max. process+thread count | 4393 (vs. ulimit of 1) | | modules | C: hbase-common hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-667/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@i
[jira] [Updated] (HBASE-23090) Cannot start and stop HBase from start-hbase.sh and stop-hbase.sh files
[ https://issues.apache.org/jira/browse/HBASE-23090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tikiri Diasena updated HBASE-23090: --- Description: Server fails to start with "55: [: false: unexpected operator" error when running the start-hbase.sh script on Linux. Similarly when trying to run stop-hbase.sh script it gives errors. (was: Server fails to start with "55: [: false: unexpected operator" error when running the start-hbase.sh script on Linux.) > Cannot start and stop HBase from start-hbase.sh and stop-hbase.sh files > --- > > Key: HBASE-23090 > URL: https://issues.apache.org/jira/browse/HBASE-23090 > Project: HBase > Issue Type: Bug >Affects Versions: 2.2.1 > Environment: Ubuntu 16.04 >Reporter: Tikiri Diasena >Priority: Blocker > > Server fails to start with "55: [: false: unexpected operator" error when > running the start-hbase.sh script on Linux. Similarly when trying to run > stop-hbase.sh script it gives errors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23090) Cannot start and stop HBase from start-hbase.sh and stop-hbase.sh files
[ https://issues.apache.org/jira/browse/HBASE-23090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tikiri Diasena updated HBASE-23090: --- Summary: Cannot start and stop HBase from start-hbase.sh and stop-hbase.sh files (was: Cannot start HBase from start-hbase.sh) > Cannot start and stop HBase from start-hbase.sh and stop-hbase.sh files > --- > > Key: HBASE-23090 > URL: https://issues.apache.org/jira/browse/HBASE-23090 > Project: HBase > Issue Type: Bug >Affects Versions: 2.2.1 > Environment: Ubuntu 16.04 >Reporter: Tikiri Diasena >Priority: Blocker > > Server fails to start with "55: [: false: unexpected operator" error when > running the start-hbase.sh script on Linux. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23090) Cannot start HBase from start-hbase.sh
Tikiri Diasena created HBASE-23090: -- Summary: Cannot start HBase from start-hbase.sh Key: HBASE-23090 URL: https://issues.apache.org/jira/browse/HBASE-23090 Project: HBase Issue Type: Bug Affects Versions: 2.2.1 Environment: Ubuntu 16.04 Reporter: Tikiri Diasena Server fails to start with "55: [: false: unexpected operator" error when running the start-hbase.sh script on Linux. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #663: HBASE-23078 BaseLoadBalancer should consider region replicas when ran…
Apache-HBase commented on issue #663: HBASE-23078 BaseLoadBalancer should consider region replicas when ran… URL: https://github.com/apache/hbase/pull/663#issuecomment-536217893 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 2m 10s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 7m 43s | master passed | | :green_heart: | compile | 1m 2s | master passed | | :green_heart: | checkstyle | 1m 35s | master passed | | :green_heart: | shadedjars | 5m 21s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 41s | master passed | | :blue_heart: | spotbugs | 4m 40s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 37s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 5m 39s | the patch passed | | :green_heart: | compile | 1m 4s | the patch passed | | :green_heart: | javac | 1m 4s | the patch passed | | :broken_heart: | checkstyle | 1m 34s | hbase-server: The patch generated 1 new + 71 unchanged - 0 fixed = 72 total (was 71) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 17s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 18m 20s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 34s | the patch passed | | :green_heart: | findbugs | 4m 32s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 244m 16s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. | | | | 312m 1s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.client.TestAsyncRegionAdminApi2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-663/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/663 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ce172c12f057 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-663/out/precommit/personality/provided.sh | | git revision | master / ef79b40e6e | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-663/4/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-663/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-663/4/testReport/ | | Max. process+thread count | 5062 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-663/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23084) Assertion "Added a key not lexically larger than previous" or "prevKey followed by a smaller key" caused abortion of RS
[
https://issues.apache.org/jira/browse/HBASE-23084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940131#comment-16940131
]
ranpanfeng commented on HBASE-23084:
[~zhangduo]
git commit: 0ba7cc01a13dbb7fec8e6c5d599fc8b4936bae61
git tag: rel/2.1.5
> Assertion "Added a key not lexically larger than previous" or "prevKey
> followed by a smaller key" caused abortion of RS
> --
>
> Key: HBASE-23084
> URL: https://issues.apache.org/jira/browse/HBASE-23084
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Environment: We store many phoenix tables in hbase, only one table
> trigger this issues.
> When two jacent keys in wrong order, the observation as follows.
> 1. the prevKey is written into hbase via Put rpc
> 2. the current key via phoenix upsert statment( Multi rpc in underlying hbase)
> 3. the current Cell extends 1MB.
> 4. the error is easy to re-ocurr.
>Reporter: ranpanfeng
>Priority: Critical
>
> when auto flush and manual flush is invoked, cell in immutable memstore
> segment is scanned one by one to build data block and bloom filter block,
> during this time, two adjacent keys are compared to assert that they are in
> lexicographical order, but regretfully, the assertion fails in some
> scenarios, when RS encounter these assertion failure, always call abort
> function to terminate abnormally.
>
> the version is 0ba7cc01a13dbb7fec8e6c5d599fc8b4936bae61 tag: rel/2.1.5
>
> At least three cases are found.
> *error case#1: getQualifierArray throws
> java.lang.ArrayIndexOutOfBoundsException*
>
> {code:java}
> 17:57:50.328 [MemStoreFlusher.0] ERROR
> org.apache.hadoop.hbase.regionserver.HRegionServer - * ABORTING region
> server ${regionserver}: Replay of WAL required. Forcing server shutdown *
> org.apache.hadoop.hbase.DroppedSnapshotException: region: ${region}.
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2788)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2467)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2439)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2329)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:612)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:581)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68)
> [hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:361)
> [hbase-server-2.1.5.jar:2.1.5]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]
> Caused by: java.lang.ArrayIndexOutOfBoundsException
> at
> org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray(ByteBufferUtils.java:1155)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.CellUtil.copyQualifierTo(CellUtil.java:309)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at org.apache.hadoop.hbase.CellUtil.cloneQualifier(CellUtil.java:121)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.ByteBufferKeyValue.getQualifierArray(ByteBufferKeyValue.java:112)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(CellUtil.java:1306)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at org.apache.hadoop.hbase.CellUtil.toString(CellUtil.java:1483)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.ByteBufferKeyValue.toString(ByteBufferKeyValue.java:296)
> ~[hbase-common-2.1.5.jar:2.1.5]
> at java.lang.String.valueOf(String.java:2994) ~[?:1.8.0_144]
> at java.lang.StringBuilder.append(StringBuilder.java:131)
> ~[?:1.8.0_144]
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:1007)
> ~[hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:582)
> ~[hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:127)
> ~[hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:69)
> ~[hbase-server-2.1.5.jar:2.1.5]
> at
> org.apache.hadoop.hb
[GitHub] [hbase] Apache-HBase commented on issue #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff
Apache-HBase commented on issue #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff URL: https://github.com/apache/hbase/pull/603#issuecomment-536213702 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 34s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 47s | master passed | | :green_heart: | compile | 1m 19s | master passed | | :green_heart: | checkstyle | 2m 0s | master passed | | :green_heart: | shadedjars | 5m 1s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 56s | master passed | | :blue_heart: | spotbugs | 4m 26s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 5m 12s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 14s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 5m 24s | the patch passed | | :green_heart: | compile | 1m 20s | the patch passed | | :green_heart: | javac | 1m 20s | the patch passed | | :green_heart: | checkstyle | 1m 54s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 2s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 8s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 54s | the patch passed | | :green_heart: | findbugs | 5m 27s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 2m 55s | hbase-common in the patch passed. | | :broken_heart: | unit | 157m 43s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 48s | The patch does not generate ASF License warnings. | | | | 227m 11s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestReportOnlineRegionsRace | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-603/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/603 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e86fc3b51c19 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-603/out/precommit/personality/provided.sh | | git revision | master / ef79b40e6e | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-603/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-603/6/testReport/ | | Max. process+thread count | 4538 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-603/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #664: HBASE-23083 Collect Executor status info periodically and report to metric system
Apache-HBase commented on issue #664: HBASE-23083 Collect Executor status info periodically and report to metric system URL: https://github.com/apache/hbase/pull/664#issuecomment-536212724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 1m 6s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 17s | master passed | | :green_heart: | compile | 1m 20s | master passed | | :green_heart: | checkstyle | 1m 49s | master passed | | :green_heart: | shadedjars | 4m 36s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 0s | master passed | | :blue_heart: | spotbugs | 4m 5s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 52s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 4m 58s | the patch passed | | :green_heart: | compile | 1m 22s | the patch passed | | :green_heart: | javac | 1m 22s | the patch passed | | :green_heart: | checkstyle | 0m 28s | The patch passed checkstyle in hbase-common | | :green_heart: | checkstyle | 1m 19s | hbase-server: The patch generated 0 new + 64 unchanged - 9 fixed = 64 total (was 73) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 33s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 15m 31s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 59s | the patch passed | | :green_heart: | findbugs | 5m 6s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 3m 6s | hbase-common in the patch passed. | | :green_heart: | unit | 159m 56s | hbase-server in the patch passed. | | :green_heart: | asflicense | 1m 7s | The patch does not generate ASF License warnings. | | | | 225m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-664/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/664 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux bc83ed2af8a2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-664/out/precommit/personality/provided.sh | | git revision | master / ef79b40e6e | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-664/4/testReport/ | | Max. process+thread count | 4998 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-664/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23035) Retain region to the last RegionServer make the failover slower
[
https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940117#comment-16940117
]
Hudson commented on HBASE-23035:
Results for branch branch-2.1
[build #1648 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1648/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1648//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1648//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1648//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Retain region to the last RegionServer make the failover slower
> ---
>
> Key: HBASE-23035
> URL: https://issues.apache.org/jira/browse/HBASE-23035
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.2
>
>
> Now if one RS crashed, the regions will try to use the old location for the
> region deploy. But one RS only have 3 threads to open region by default. If a
> RS have hundreds of regions, the failover is very slower. Assign to same RS
> may have good locality if the Datanode is deploied on same host. But slower
> failover make the availability worse. And the locality is not big deal when
> deploy HBase on cloud.
> This was introduced by HBASE-18946.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-23088) [hbase-thirdparty] Upgrade the dependencies for hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23088. --- Hadoop Flags: Reviewed Release Note: netty-all: 4.1.34.Final => 4.1.42.Final guava: 27.1-jre => 28.1-jre commons-collections4: 4.3 => 4.4 protobuf: 3.7.1 => 3.9.2 Resolution: Fixed Merged. An addendum moved netty from 4.1.41 to 4.1.42. > [hbase-thirdparty] Upgrade the dependencies for hbase-thirdparty > > > Key: HBASE-23088 > URL: https://issues.apache.org/jira/browse/HBASE-23088 > Project: HBase > Issue Type: Sub-task > Components: hbase-thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: hbase-thirdparty-3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #670: HBASE-23087 Remove the deprecated bulkload method in AsyncClusterConn…
Apache-HBase commented on issue #670: HBASE-23087 Remove the deprecated bulkload method in AsyncClusterConn… URL: https://github.com/apache/hbase/pull/670#issuecomment-536207466 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 18s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 7m 15s | master passed | | :green_heart: | compile | 1m 8s | master passed | | :green_heart: | checkstyle | 1m 36s | master passed | | :green_heart: | shadedjars | 5m 20s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 41s | master passed | | :blue_heart: | spotbugs | 4m 59s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 56s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 6m 56s | the patch passed | | :green_heart: | compile | 1m 15s | the patch passed | | :green_heart: | javac | 1m 15s | the patch passed | | :green_heart: | checkstyle | 1m 35s | hbase-server: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 39s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 18m 34s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 35s | hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | :green_heart: | findbugs | 4m 37s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 235m 17s | hbase-server in the patch passed. | | :green_heart: | asflicense | 0m 33s | The patch does not generate ASF License warnings. | | | | 304m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-670/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/670 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6fd8c86eee8e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-670/out/precommit/personality/provided.sh | | git revision | master / b45c0d0efa | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-670/1/testReport/ | | Max. process+thread count | 4686 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-670/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23088) [hbase-thirdparty] Upgrade the dependencies for hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23088: -- Fix Version/s: hbase-thirdparty-3.1.0 > [hbase-thirdparty] Upgrade the dependencies for hbase-thirdparty > > > Key: HBASE-23088 > URL: https://issues.apache.org/jira/browse/HBASE-23088 > Project: HBase > Issue Type: Sub-task > Components: hbase-thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: hbase-thirdparty-3.1.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] chenxu14 commented on a change in pull request #664: HBASE-23083 Collect Executor status info periodically and report to metric system
chenxu14 commented on a change in pull request #664: HBASE-23083 Collect
Executor status info periodically and report to metric system
URL: https://github.com/apache/hbase/pull/664#discussion_r329317673
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##
@@ -1922,6 +1926,14 @@ private void startServices() throws IOException {
HConstants.DEFAULT_THREAD_WAKE_FREQUENCY);
healthCheckChore = new HealthCheckChore(sleepTime, this,
getConfiguration());
}
+// Executor status collect thread.
+if (this.conf.getBoolean(HConstants.EXECUTOR_STATUS_COLLECTE_ENABLED,
+HConstants.DEFAULT_EXECUTOR_STATUS_COLLECTE_ENABLED)) {
+ int sleepTime = this.conf.getInt(ExecutorStatusChore.WAKE_FREQ,
+ ExecutorStatusChore.DEFAULT_WAKE_FREQ);
+ executorStatusChore = new ExecutorStatusChore(sleepTime, this,
this.getExecutorService(),
Review comment:
Hi Stack, maybe I misunderstood it. I mead there is only one
ExecutorService, but it will start many Executors.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-23054) Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm
[ https://issues.apache.org/jira/browse/HBASE-23054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-23054: -- Fix Version/s: 2.2.2 2.1.7 2.3.0 3.0.0 Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Merged (after fixing the checkstyle and checking the test locally -- passed). Thanks for the patch [~an...@apache.org]. Nice one. > Remove synchronization block from MetaTableMetrics and fix LossyCounting > algorithm > -- > > Key: HBASE-23054 > URL: https://issues.apache.org/jira/browse/HBASE-23054 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.5 >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > Attachments: HBASE-23054.master.001.patch, > HBASE-23054.master.002.patch > > > While trying to use LossyCounting for HBASE-15519 , found following bugs in > current implementation > – Remove synchronization block from MetaTableMetrics to avoid congestion at > the code > – Fix license format > – Fix LossyCounting algorithm as per > [http://www.vldb.org/conf/2002/S10P03.pdf > |http://www.vldb.org/conf/2002/S10P03.pdf] > -- Avoid doing sweep on every insert in LossyCounting > – Remove extra redundant data structures from MetaTableMetrics. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22699) refactor isMetaClearingException
[ https://issues.apache.org/jira/browse/HBASE-22699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940068#comment-16940068 ] Michael Stack commented on HBASE-22699: --- [~Joseph295] It is clearning the meta cache for this one region or all meta cache? If the former, would be nice to conditionally clear the cache dependent on the error type (would be hard though so probably safer to just clear the location for this region from cache). If we are clearing all of the meta cache, that is wrong. Thank you [~Joseph295] > refactor isMetaClearingException > > > Key: HBASE-22699 > URL: https://issues.apache.org/jira/browse/HBASE-22699 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Junhong Xu >Assignee: Junhong Xu >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.2 > > > It is not so readable -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] busbey commented on a change in pull request #662: HBASE-22942 move Snapshot verification to procedure
busbey commented on a change in pull request #662: HBASE-22942 move Snapshot
verification to procedure
URL: https://github.com/apache/hbase/pull/662#discussion_r329312522
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java
##
@@ -351,6 +352,12 @@ private void prepareRestore(final MasterProcedureEnv env)
throws IOException {
mfs.getFileSystem(),
SnapshotDescriptionUtils.getCompletedSnapshotDir(snapshot,
mfs.getRootDir()),
snapshot);
+
+ // Verify snapshot validity
+ SnapshotReferenceUtil
Review comment:
This is currently in a block for only checking non-system tables. Needs to
happen for all tables.
Also should probably be the first thing we do in prepareRestore, since it
used to proceed the step.
Please update the status monitor about doing the verification as well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] chenxu14 commented on a change in pull request #664: HBASE-23083 Collect Executor status info periodically and report to metric system
chenxu14 commented on a change in pull request #664: HBASE-23083 Collect
Executor status info periodically and report to metric system
URL: https://github.com/apache/hbase/pull/664#discussion_r329312300
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##
@@ -1922,6 +1926,14 @@ private void startServices() throws IOException {
HConstants.DEFAULT_THREAD_WAKE_FREQUENCY);
healthCheckChore = new HealthCheckChore(sleepTime, this,
getConfiguration());
}
+// Executor status collect thread.
+if (this.conf.getBoolean(HConstants.EXECUTOR_STATUS_COLLECTE_ENABLED,
+HConstants.DEFAULT_EXECUTOR_STATUS_COLLECTE_ENABLED)) {
+ int sleepTime = this.conf.getInt(ExecutorStatusChore.WAKE_FREQ,
+ ExecutorStatusChore.DEFAULT_WAKE_FREQ);
+ executorStatusChore = new ExecutorStatusChore(sleepTime, this,
this.getExecutorService(),
Review comment:
Not the only one inHRegionServer#startServices()
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #662: HBASE-22942 move Snapshot verification to procedure
busbey commented on issue #662: HBASE-22942 move Snapshot verification to procedure URL: https://github.com/apache/hbase/pull/662#issuecomment-536194454 Please check on the unit test failures since they're supposed to cover the code that changed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] sanjeetnishad95 commented on issue #662: HBASE-22942 move Snapshot verification to procedure
sanjeetnishad95 commented on issue #662: HBASE-22942 move Snapshot verification to procedure URL: https://github.com/apache/hbase/pull/662#issuecomment-536192952 Hi @saintstack ,If the procedure fails as a result of verifySnapshot, it will throw corruptedSnapshotException or IOException which will be taken care as a part of the procedure framework. The procedure will close out cleanly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23038) Provide consistent and clear logging about disabling chores
[
https://issues.apache.org/jira/browse/HBASE-23038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940030#comment-16940030
]
Hudson commented on HBASE-23038:
Results for branch master
[build #1486 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1486/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1486//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1486//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1486//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide consistent and clear logging about disabling chores
> ---
>
> Key: HBASE-23038
> URL: https://issues.apache.org/jira/browse/HBASE-23038
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
>Reporter: Sean Busbey
>Assignee: Sanjeet Nishad
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
> Attachments: HBASE-23038.001.patch, HBASE-23038.002.patch,
> HBASE-23038.master.003.patch
>
>
> Right now if you want to disable any of our chores you can set the period to
> be <= 0. Sometimes, if you do this you get a nice message:
> {code}
> 2019-09-16 22:10:16,756 INFO [master-1:16000.activeMasterManager]
> master.HMaster: The period is 0 seconds, MobCompactionChore is disabled
> {code}
> And sometimes you get an opaque message:
> {code}
> 2019-09-16 22:09:45,333 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: LogsCleaner
> 2019-09-16 22:09:45,340 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: HFileCleaner
> {code}
> This is because sometimes we just blindly submit to ChoreService which
> submits to a java ScheduledExecutorService and then catches the
> IllegalArgumentException.
> We should remove the one-offs and make it so ChoreService checks the period
> before accepting a submittal and produces a consistent "Foo is disabled"
> message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] infraio commented on issue #663: HBASE-23078 BaseLoadBalancer should consider region replicas when ran…
infraio commented on issue #663: HBASE-23078 BaseLoadBalancer should consider region replicas when ran… URL: https://github.com/apache/hbase/pull/663#issuecomment-536191870 Add the region replica UT back. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #663: HBASE-23078 BaseLoadBalancer should consider region replicas when ran…
infraio commented on a change in pull request #663: HBASE-23078
BaseLoadBalancer should consider region replicas when ran…
URL: https://github.com/apache/hbase/pull/663#discussion_r329311071
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
##
@@ -1319,8 +1318,22 @@ protected boolean
areSomeRegionReplicasColocated(Cluster c) {
return assignments;
}
- protected Cluster createCluster(List servers,
Collection regions,
- boolean hasRegionReplica) {
+ protected Cluster createCluster(List servers,
Collection regions)
+ throws HBaseIOException {
+boolean hasRegionReplica = false;
+try {
+ for (RegionInfo regionInfo : regions) {
+TableName tableName = regionInfo.getTable();
+if (services != null &&
+
services.getTableDescriptors().get(tableName).getRegionReplication() > 1) {
Review comment:
Updated in new patch. Will only getTableDescriptors once now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
[
https://issues.apache.org/jira/browse/HBASE-23089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940008#comment-16940008
]
HBase QA commented on HBASE-23089:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 0m
0s{color} | {color:red} Docker failed to build yetus/hbase:1cb4f687c1. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-23089 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12981678/0001-fix-undefined-constants.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/930/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.0 https://yetus.apache.org |
This message was automatically generated.
> fix undefined constants in HBaseHTraceConfiguration
> ---
>
> Key: HBASE-23089
> URL: https://issues.apache.org/jira/browse/HBASE-23089
> Project: HBase
> Issue Type: Improvement
>Reporter: cong.han
>Assignee: cong.han
>Priority: Trivial
> Attachments: 0001-fix-undefined-constants.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-23088) Upgrade the dependencies for hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23088 started by Duo Zhang. - > Upgrade the dependencies for hbase-thirdparty > - > > Key: HBASE-23088 > URL: https://issues.apache.org/jira/browse/HBASE-23088 > Project: HBase > Issue Type: Sub-task > Components: hbase-thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23088) Upgrade the dependencies for hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23088: - Assignee: Duo Zhang > Upgrade the dependencies for hbase-thirdparty > - > > Key: HBASE-23088 > URL: https://issues.apache.org/jira/browse/HBASE-23088 > Project: HBase > Issue Type: Sub-task > Components: hbase-thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23088) [hbase-thirdparty] Upgrade the dependencies for hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-23088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23088: -- Summary: [hbase-thirdparty] Upgrade the dependencies for hbase-thirdparty (was: Upgrade the dependencies for hbase-thirdparty) > [hbase-thirdparty] Upgrade the dependencies for hbase-thirdparty > > > Key: HBASE-23088 > URL: https://issues.apache.org/jira/browse/HBASE-23088 > Project: HBase > Issue Type: Sub-task > Components: hbase-thirdparty >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
[ https://issues.apache.org/jira/browse/HBASE-23089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-23089: - Attachment: (was: 0001-fix-undefined-constants.patch) > fix undefined constants in HBaseHTraceConfiguration > --- > > Key: HBASE-23089 > URL: https://issues.apache.org/jira/browse/HBASE-23089 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Trivial > Attachments: 0001-fix-undefined-constants.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
[ https://issues.apache.org/jira/browse/HBASE-23089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-23089: - Attachment: 0001-fix-undefined-constants.patch Status: Patch Available (was: Open) > fix undefined constants in HBaseHTraceConfiguration > --- > > Key: HBASE-23089 > URL: https://issues.apache.org/jira/browse/HBASE-23089 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Trivial > Attachments: 0001-fix-undefined-constants.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
[ https://issues.apache.org/jira/browse/HBASE-23089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han reassigned HBASE-23089: Assignee: cong.han > fix undefined constants in HBaseHTraceConfiguration > --- > > Key: HBASE-23089 > URL: https://issues.apache.org/jira/browse/HBASE-23089 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Assignee: cong.han >Priority: Trivial > Attachments: 0001-fix-undefined-constants.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
[ https://issues.apache.org/jira/browse/HBASE-23089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] cong.han updated HBASE-23089: - Attachment: 0001-fix-undefined-constants.patch > fix undefined constants in HBaseHTraceConfiguration > --- > > Key: HBASE-23089 > URL: https://issues.apache.org/jira/browse/HBASE-23089 > Project: HBase > Issue Type: Improvement >Reporter: cong.han >Priority: Trivial > Attachments: 0001-fix-undefined-constants.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] infraio merged pull request #652: HBASE-23035 Retain region to the last RegionServer make the failover …
infraio merged pull request #652: HBASE-23035 Retain region to the last RegionServer make the failover … URL: https://github.com/apache/hbase/pull/652 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio merged pull request #650: HBASE-23035 Retain region to the last RegionServer make the failover …
infraio merged pull request #650: HBASE-23035 Retain region to the last RegionServer make the failover … URL: https://github.com/apache/hbase/pull/650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23089) fix undefined constants in HBaseHTraceConfiguration
cong.han created HBASE-23089: Summary: fix undefined constants in HBaseHTraceConfiguration Key: HBASE-23089 URL: https://issues.apache.org/jira/browse/HBASE-23089 Project: HBase Issue Type: Improvement Reporter: cong.han -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23088) Upgrade the dependencies for hbase-thirdparty
Duo Zhang created HBASE-23088: - Summary: Upgrade the dependencies for hbase-thirdparty Key: HBASE-23088 URL: https://issues.apache.org/jira/browse/HBASE-23088 Project: HBase Issue Type: Sub-task Components: hbase-thirdparty Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #645: HBASE-22930 Set unique name to longCompactions/shortCompactions threads
Apache-HBase commented on issue #645: HBASE-22930 Set unique name to longCompactions/shortCompactions threads URL: https://github.com/apache/hbase/pull/645#issuecomment-536181229 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 2m 11s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | :green_heart: | mvninstall | 10m 47s | branch-1 passed | | :green_heart: | compile | 0m 53s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | compile | 0m 56s | branch-1 passed with JDK v1.7.0_232 | | :green_heart: | checkstyle | 1m 54s | branch-1 passed | | :green_heart: | shadedjars | 3m 29s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 38s | branch-1 passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 0m 40s | branch-1 passed with JDK v1.7.0_232 | | :blue_heart: | spotbugs | 3m 3s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 2m 59s | branch-1 passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 2m 5s | the patch passed | | :green_heart: | compile | 0m 42s | the patch passed with JDK v1.8.0_222 | | :green_heart: | javac | 0m 42s | the patch passed | | :green_heart: | compile | 0m 46s | the patch passed with JDK v1.7.0_232 | | :green_heart: | javac | 0m 46s | the patch passed | | :green_heart: | checkstyle | 1m 43s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 3m 7s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 5m 12s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 30s | the patch passed with JDK v1.8.0_222 | | :green_heart: | javadoc | 0m 42s | the patch passed with JDK v1.7.0_232 | | :green_heart: | findbugs | 3m 4s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 141m 17s | hbase-server in the patch passed. | | :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. | | | | 187m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-645/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/645 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a68aa31fda1f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-645/out/precommit/personality/provided.sh | | git revision | branch-1 / daf1faa | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_222 /usr/lib/jvm/zulu-7-amd64:1.7.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-645/5/testReport/ | | Max. process+thread count | 4654 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-645/5/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23077) move entirely to spotbugs
[ https://issues.apache.org/jira/browse/HBASE-23077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939985#comment-16939985 ] Duo Zhang commented on HBASE-23077: --- +1. > move entirely to spotbugs > - > > Key: HBASE-23077 > URL: https://issues.apache.org/jira/browse/HBASE-23077 > Project: HBase > Issue Type: Improvement > Components: build, test >Reporter: Sean Busbey >Priority: Major > > we've been relying on spotbugs definitions with findbugs tooling for awhile > now. I think spotbugs now provides its own versions of everything we need > (and Yetus supports spotbugs directly). > Do a pass removing findbugs tooling from all branches in favor of spotbugs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 opened a new pull request #670: HBASE-23087 Remove the deprecated bulkload method in AsyncClusterConn…
Apache9 opened a new pull request #670: HBASE-23087 Remove the deprecated bulkload method in AsyncClusterConn… URL: https://github.com/apache/hbase/pull/670 …ection This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23087) Remove the deprecated bulkload method in AsyncClusterConnection
Duo Zhang created HBASE-23087: - Summary: Remove the deprecated bulkload method in AsyncClusterConnection Key: HBASE-23087 URL: https://issues.apache.org/jira/browse/HBASE-23087 Project: HBase Issue Type: Task Reporter: Duo Zhang The class is IA.Private and it has not been released yet so let's just remove this method to keep the class clean. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23079) SCP fails when PE executes rollback of ORP
[
https://issues.apache.org/jira/browse/HBASE-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939969#comment-16939969
]
Duo Zhang commented on HBASE-23079:
---
{quote}
hbase.4500.log:2019-08-29,01:40:45,188 ERROR [PEWorker-7]
org.apache.hadoop.hbase.procedure2.ProcedureExecutor: CODE-BUG: Uncaught
runtime exception for pid=56653,
state=FAILED:SPLIT_TABLE_REGION_PRE_OPERATION_BEFORE_META, locked=true,
exception=org.apache.hadoop.hbase.exceptions.TimeoutIOException via
ProcedureExecutor:org.apache.hadoop.hbase.exceptions.TimeoutIOException:
Operation timed out after 20.1700sec; SplitTableRegionProcedure
table=c3prck8smonitorc3:tsdb-service, parent=67aead237772eeb491845afdd02037eb,
daughterA=fc85d08d8630ed25715730ba3d6901cb,
daughterB=413a5199ff68f3505f490c8341efe459
hbase.4500.log:java.lang.UnsupportedOperationException: pid=56653,
state=FAILED:SPLIT_TABLE_REGION_UPDATE_META, locked=true,
exception=org.apache.hadoop.hbase.exceptions.TimeoutIOException via
ProcedureExecutor:org.apache.hadoop.hbase.exceptions.TimeoutIOException:
Operation timed out after 20.1700sec; SplitTableRegionProcedure
table=c3prck8smonitorc3:tsdb-service, parent=67aead237772eeb491845afdd02037eb,
daughterA=fc85d08d8630ed25715730ba3d6901cb,
daughterB=413a5199ff68f3505f490c8341efe459 unhandled
state=SPLIT_TABLE_REGION_UPDATE_META
{quote}
I think the problem is here. A SplitTableRegionProcedure failed when updating
meta. By design it should retry for ever. Let me check the code.
> SCP fails when PE executes rollback of ORP
> ---
>
> Key: HBASE-23079
> URL: https://issues.apache.org/jira/browse/HBASE-23079
> Project: HBase
> Issue Type: Bug
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> In our test environment, we found that, when OpenRegionProcedure failed by
> timeout, though it doesn't support rollback, ProcedureExcutor will delete the
> OPR node in the store in its own rollback steps and make the RIT stay there
> looping rollback exception. ServerCrashProcedure will detect this RIT but
> cannot deal with it, because no node in the store and it will encounters NPE,
> as a result, SCP aborts.
>
> Logs are as follows,
> {quote}2019-08-29,07:27:35,710 INFO [PEWorker-15]
> org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure: pid=70206,
> state=RUNNABLE:SERVER_CRASH_ASSIGN, locked=true; ServerCrashProcedure
> server=c3-hadoop-srv-st297.bj,21600,1567012736142, splitWal=true, meta=true
> found RIT pid=56043, ppid=55625, state=ROLLEDBACK;
> TransitRegionStateProcedure table=c3srv_galaxy:tsdb,
> region=c1ccd94593bf1b87269cec98d6ffaaae, ASSIGN; rit=OPEN,
> location=c3-hadoop-srv-st297.bj,21600,1567012736142, table=c3srv_galaxy:tsdb,
> region=c1ccd94593bf1b87269cec98d6ffaaae
> 2019-08-29,07:27:35,711 ERROR [PEWorker-15]
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: CODE-BUG: Uncaught
> runtime exception: pid=70206, state=RUNNABLE:SERVER_CRASH_ASSIGN,
> locked=true; ServerCrashProcedure
> server=c3-hadoop-srv-st297.bj,21600,1567012736142, splitWal=true, meta=true
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.procedure2.store.ProcedureStoreTracker.update(ProcedureStoreTracker.java:140)
> at
> org.apache.hadoop.hbase.procedure2.store.ProcedureStoreTracker.update(ProcedureStoreTracker.java:133)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.updateStoreTracker(WALProcedureStore.java:782)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.pushData(WALProcedureStore.java:737)
> at
> org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.update(WALProcedureStore.java:604)
> at
> org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.persistAndWake(RegionRemoteProcedureBase.java:182)
> at
> org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.serverCrashed(RegionRemoteProcedureBase.java:239)
> at
> org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.serverCrashed(TransitRegionStateProcedure.java:398)
> at
> org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.assignRegions(ServerCrashProcedure.java:461)
> at
> org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.executeFromState(ServerCrashProcedure.java:221)
> at
> org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.executeFromState(ServerCrashProcedure.java:64)
> at
> org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:189)
> at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:962)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1645)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1392)
[jira] [Commented] (HBASE-23054) Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm
[
https://issues.apache.org/jira/browse/HBASE-23054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939956#comment-16939956
]
HBase QA commented on HBASE-23054:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
20s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
31s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
32s{color} | {color:red} hbase-server: The patch generated 1 new + 0 unchanged
- 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
11s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 27s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}235m 28s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}298m 59s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestMobSnapshotCloneIndependence |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.2 Server=19.03.2 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/929/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-23054 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12981620/HBASE-23054.master.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 343b7ba7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b45c0d0efa |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HB
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939954#comment-16939954
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #130 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/130/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/130//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/130//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/130//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/130//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23038) Provide consistent and clear logging about disabling chores
[
https://issues.apache.org/jira/browse/HBASE-23038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939953#comment-16939953
]
Hudson commented on HBASE-23038:
Results for branch branch-1
[build #1088 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1088/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1088//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1088//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1088//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Provide consistent and clear logging about disabling chores
> ---
>
> Key: HBASE-23038
> URL: https://issues.apache.org/jira/browse/HBASE-23038
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
>Reporter: Sean Busbey
>Assignee: Sanjeet Nishad
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
> Attachments: HBASE-23038.001.patch, HBASE-23038.002.patch,
> HBASE-23038.master.003.patch
>
>
> Right now if you want to disable any of our chores you can set the period to
> be <= 0. Sometimes, if you do this you get a nice message:
> {code}
> 2019-09-16 22:10:16,756 INFO [master-1:16000.activeMasterManager]
> master.HMaster: The period is 0 seconds, MobCompactionChore is disabled
> {code}
> And sometimes you get an opaque message:
> {code}
> 2019-09-16 22:09:45,333 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: LogsCleaner
> 2019-09-16 22:09:45,340 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: HFileCleaner
> {code}
> This is because sometimes we just blindly submit to ChoreService which
> submits to a java ScheduledExecutorService and then catches the
> IllegalArgumentException.
> We should remove the one-offs and make it so ChoreService checks the period
> before accepting a submittal and produces a consistent "Foo is disabled"
> message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-22653) Do not run errorProne on JDK7
[
https://issues.apache.org/jira/browse/HBASE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi resolved HBASE-22653.
---
Resolution: Fixed
Thanks for the review [~vjasani]!
> Do not run errorProne on JDK7
> -
>
> Key: HBASE-22653
> URL: https://issues.apache.org/jira/browse/HBASE-22653
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 1.5.0, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 1.5.0, 1.4.11
>
>
> Nightly JDK7 build fails for branch-1 and branch-1.4 when errorProne profile
> is used.
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project hbase-common: Execution default-compile of goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile failed: An API
> incompatibility was encountered while executing
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile:
> java.lang.UnsupportedClassVersionError: javax/tools/DiagnosticListener :
> Unsupported major.minor version 52.0{noformat}
> https://builds.apache.org/job/HBase%20Nightly/job/branch-1/929/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] petersomogyi merged pull request #669: HBASE-22653 Do not run errorProne on branch-1 PRs
petersomogyi merged pull request #669: HBASE-22653 Do not run errorProne on branch-1 PRs URL: https://github.com/apache/hbase/pull/669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #669: HBASE-22653 Do not run errorProne on branch-1 PRs
Apache-HBase commented on issue #669: HBASE-22653 Do not run errorProne on branch-1 PRs URL: https://github.com/apache/hbase/pull/669#issuecomment-536165920 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 11m 3s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :blue_heart: | shelldocs | 0m 0s | Shelldocs was not available. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-1 Compile Tests _ | | :blue_heart: | mvndep | 6m 8s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 17s | Maven dependency ordering for patch | | :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | :blue_heart: | asflicense | 0m 0s | ASF License check generated no output? | | | | 18m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-669/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/669 | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux e45e81cf4df8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-669/out/precommit/personality/provided.sh | | git revision | branch-1 / b96aefd | | Max. process+thread count | 42 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-669/1/console | | versions | git=1.9.1 maven=3.0.5 shellcheck=0.7.0 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] petersomogyi opened a new pull request #669: HBASE-22653 Do not run errorProne on branch-1 PRs
petersomogyi opened a new pull request #669: HBASE-22653 Do not run errorProne on branch-1 PRs URL: https://github.com/apache/hbase/pull/669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Reopened] (HBASE-22653) Do not run errorProne on JDK7
[
https://issues.apache.org/jira/browse/HBASE-22653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi reopened HBASE-22653:
---
Reopening to remove error-prone from PR verifications
> Do not run errorProne on JDK7
> -
>
> Key: HBASE-22653
> URL: https://issues.apache.org/jira/browse/HBASE-22653
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 1.5.0, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 1.5.0, 1.4.11
>
>
> Nightly JDK7 build fails for branch-1 and branch-1.4 when errorProne profile
> is used.
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project hbase-common: Execution default-compile of goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile failed: An API
> incompatibility was encountered while executing
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile:
> java.lang.UnsupportedClassVersionError: javax/tools/DiagnosticListener :
> Unsupported major.minor version 52.0{noformat}
> https://builds.apache.org/job/HBase%20Nightly/job/branch-1/929/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
