[jira] [Created] (HBASE-23298) Refactor LogRecoveredEditsOutputSink and BoundedLogWriterCreationOutputSink
Guanghao Zhang created HBASE-23298: -- Summary: Refactor LogRecoveredEditsOutputSink and BoundedLogWriterCreationOutputSink Key: HBASE-23298 URL: https://issues.apache.org/jira/browse/HBASE-23298 Project: HBase Issue Type: Improvement Reporter: Guanghao Zhang I do some refactor work in HBASE-23286. Move them to a new issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23298) Refactor LogRecoveredEditsOutputSink and BoundedLogWriterCreationOutputSink
[ https://issues.apache.org/jira/browse/HBASE-23298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-23298: -- Assignee: Guanghao Zhang > Refactor LogRecoveredEditsOutputSink and BoundedLogWriterCreationOutputSink > --- > > Key: HBASE-23298 > URL: https://issues.apache.org/jira/browse/HBASE-23298 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > > I do some refactor work in HBASE-23286. Move them to a new issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] infraio opened a new pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…
infraio opened a new pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832 …CreationOutputSink This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23293) [REPLICATION] make ship edits timeout configurable
[ https://issues.apache.org/jira/browse/HBASE-23293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974938#comment-16974938 ] Pankaj Kumar commented on HBASE-23293: -- Welcome [~wchevreuil]. > [REPLICATION] make ship edits timeout configurable > -- > > Key: HBASE-23293 > URL: https://issues.apache.org/jira/browse/HBASE-23293 > Project: HBase > Issue Type: Improvement > Components: Replication >Reporter: chenxu >Assignee: chenxu >Priority: Minor > > ReplicationSourceShipper#shipEdits may take a while if bulkload replication > enabled, since we should copy HFile from the source cluster, so i think there > is a need to make the timeout value configurable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] meszibalu commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position
meszibalu commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position URL: https://github.com/apache/hbase/pull/829#issuecomment-554271455 (Triggered jenkins manually.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 merged pull request #813: HBASE-23253 Rewrite rsgroup related UTs with the new methods introduc…
Apache9 merged pull request #813: HBASE-23253 Rewrite rsgroup related UTs with the new methods introduc… URL: https://github.com/apache/hbase/pull/813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23253) Rewrite rsgroup related UTs with the new methods introduced in HBASE-22932
[ https://issues.apache.org/jira/browse/HBASE-23253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23253. --- Fix Version/s: HBASE-22514 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch HBASE-22514. Thanks [~zghao] for reviewing. > Rewrite rsgroup related UTs with the new methods introduced in HBASE-22932 > -- > > Key: HBASE-23253 > URL: https://issues.apache.org/jira/browse/HBASE-23253 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: HBASE-22514 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23253) Rewrite rsgroup related UTs with the new methods introduced in HBASE-22932
[ https://issues.apache.org/jira/browse/HBASE-23253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23253: -- Component/s: test > Rewrite rsgroup related UTs with the new methods introduced in HBASE-22932 > -- > > Key: HBASE-23253 > URL: https://issues.apache.org/jira/browse/HBASE-23253 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: HBASE-22514 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #827: HBASE-23294 ReplicationBarrierCleaner should delete all the barriers …
Apache9 merged pull request #827: HBASE-23294 ReplicationBarrierCleaner should delete all the barriers … URL: https://github.com/apache/hbase/pull/827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975013#comment-16975013
]
Hudson commented on HBASE-23283:
Results for branch branch-1
[build #1138 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1138/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1138//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1138//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1138//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table
Apache-HBase commented on issue #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table URL: https://github.com/apache/hbase/pull/831#issuecomment-554332398 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 27s | master passed | | +1 :green_heart: | compile | 1m 24s | master passed | | +1 :green_heart: | checkstyle | 1m 35s | master passed | | +1 :green_heart: | shadedjars | 4m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | master passed | | +0 :ok: | spotbugs | 4m 9s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 53s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 1s | the patch passed | | +1 :green_heart: | compile | 1m 28s | the patch passed | | +1 :green_heart: | javac | 1m 28s | the patch passed | | -1 :x: | checkstyle | 0m 14s | hbase-rsgroup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 16m 49s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 58s | the patch passed | | +1 :green_heart: | findbugs | 5m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 165m 21s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 6m 51s | hbase-rsgroup in the patch passed. | | +1 :green_heart: | asflicense | 0m 55s | The patch does not generate ASF License warnings. | | | | 236m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-831/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/831 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8dbc87a149b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-831/out/precommit/personality/provided.sh | | git revision | master / 67f9afc722 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-831/2/artifact/out/diff-checkstyle-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-831/2/testReport/ | | Max. process+thread count | 4883 (vs. ulimit of 1) | | modules | C: hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-831/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters
Apache-HBase commented on issue #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#issuecomment-554339869 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 45s | master passed | | +1 :green_heart: | compile | 1m 40s | master passed | | +1 :green_heart: | checkstyle | 2m 17s | master passed | | +1 :green_heart: | shadedjars | 4m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 14s | master passed | | +0 :ok: | spotbugs | 4m 27s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 6m 5s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 27s | the patch passed | | +1 :green_heart: | compile | 1m 41s | the patch passed | | +1 :green_heart: | javac | 1m 41s | the patch passed | | +1 :green_heart: | checkstyle | 2m 18s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 17s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 1m 11s | the patch passed | | +1 :green_heart: | findbugs | 6m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 50s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 49s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 273m 0s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 16s | The patch does not generate ASF License warnings. | | | | 347m 40s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestMasterReplication | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/830 | | JIRA Issue | HBASE-23281 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c6003fb20773 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-830/out/precommit/personality/provided.sh | | git revision | master / 67f9afc722 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/3/testReport/ | | Max. process+thread count | 5424 (vs. ulimit of 1) | | modules | C: hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23281) Track meta region changes on masters
[
https://issues.apache.org/jira/browse/HBASE-23281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975051#comment-16975051
]
HBase QA commented on HBASE-23281:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
59s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
14s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
27s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
1s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 17s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
50s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
49s{color} | {color:green} hbase-zookeeper in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}273m 0s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}347m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.replication.TestMasterReplication |
| | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-830/3/artifact/out/Dockerfile
|
[jira] [Created] (HBASE-23299) Release 2.1.8
Duo Zhang created HBASE-23299: - Summary: Release 2.1.8 Key: HBASE-23299 URL: https://issues.apache.org/jira/browse/HBASE-23299 Project: HBase Issue Type: Umbrella Reporter: Duo Zhang Assignee: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23300) Set version as 2.1.8 in branch-2.1 in prep for first RC of 2.1.8
Duo Zhang created HBASE-23300: - Summary: Set version as 2.1.8 in branch-2.1 in prep for first RC of 2.1.8 Key: HBASE-23300 URL: https://issues.apache.org/jira/browse/HBASE-23300 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23301) Generate CHANGES.md and RELEASENOTES.md for 2.1.8
Duo Zhang created HBASE-23301: - Summary: Generate CHANGES.md and RELEASENOTES.md for 2.1.8 Key: HBASE-23301 URL: https://issues.apache.org/jira/browse/HBASE-23301 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23302) Put up 2.1.8RC0
Duo Zhang created HBASE-23302: - Summary: Put up 2.1.8RC0 Key: HBASE-23302 URL: https://issues.apache.org/jira/browse/HBASE-23302 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-23294) ReplicationBarrierCleaner should delete all the barriers for a removed region which does not belong to any serial replication peer
[ https://issues.apache.org/jira/browse/HBASE-23294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23294. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.1+. Thanks [~stack] for reviewing. > ReplicationBarrierCleaner should delete all the barriers for a removed region > which does not belong to any serial replication peer > -- > > Key: HBASE-23294 > URL: https://issues.apache.org/jira/browse/HBASE-23294 > Project: HBase > Issue Type: Bug > Components: master, Replication >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22146) SpaceQuotaViolationPolicy Disable is not working in Namespace level
[ https://issues.apache.org/jira/browse/HBASE-22146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22146: -- Fix Version/s: (was: 2.1.8) 2.1.9 > SpaceQuotaViolationPolicy Disable is not working in Namespace level > --- > > Key: HBASE-22146 > URL: https://issues.apache.org/jira/browse/HBASE-22146 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.0.0 >Reporter: Uma Maheswari >Assignee: Shardul Singh >Priority: Major > Labels: Quota, space > Fix For: 3.0.0, 2.0.7, 2.2.3, 2.1.9 > > > SpaceQuotaViolationPolicy Disable is not working in Namespace level > PFB the steps: > * Create Namespace and set Quota violation policy as Disable > * Create tables under namespace and violate Quota > Expected result: Tables to get disabled > Actual Result: Tables are not getting disabled > Note: mutation operation is not allowed on the table -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23297) [RSGROUP] build RegionPlan per group not per table
[ https://issues.apache.org/jira/browse/HBASE-23297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975059#comment-16975059 ] Duo Zhang commented on HBASE-23297: --- [~anoop.hbase] I do not think this is the same thing. In the original LB, per cluster and per table will lead to different result, but here, I think it is just an optimization to make the balancer faster, so it is an improvement, not a new feature. Am I correct [~javaman_chen]? Thanks. > [RSGROUP] build RegionPlan per group not per table > -- > > Key: HBASE-23297 > URL: https://issues.apache.org/jira/browse/HBASE-23297 > Project: HBase > Issue Type: Improvement > Components: Balancer, rsgroup >Reporter: chenxu >Assignee: chenxu >Priority: Major > > RSGroupAdminServer#balanceRSGroup will take too long time, if the target > group has thousands of tables, because we will build RegionPlan for each > table, I think it’s better to balance per group instead of per table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23120) Fix ref guide - Release process
[
https://issues.apache.org/jira/browse/HBASE-23120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-23120:
--
Fix Version/s: (was: 2.1.8)
2.1.9
> Fix ref guide - Release process
> ---
>
> Key: HBASE-23120
> URL: https://issues.apache.org/jira/browse/HBASE-23120
> Project: HBase
> Issue Type: Sub-task
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.3, 1.6.1, 2.1.9
>
>
> The example is of a sample ~/.m2/settings.xml file.
> {code:java}
>
> {code}
> is not a proper comment.
> Also I think here,
> {code:java}
>
> {code}
> the double hyphened --list-keys shouldn't be used. It leads to FATAL error
> like the one below:
> {code:java}
> [FATAL] Non-parseable settings
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-22075) Potential data loss when MOB compaction fails
[ https://issues.apache.org/jira/browse/HBASE-22075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22075: -- Fix Version/s: (was: 2.1.8) 2.1.9 > Potential data loss when MOB compaction fails > - > > Key: HBASE-22075 > URL: https://issues.apache.org/jira/browse/HBASE-22075 > Project: HBase > Issue Type: Bug > Components: mob >Affects Versions: 2.1.0, 2.0.0, 2.0.1, 2.1.1, 2.0.2, 2.0.3, 2.1.2, 2.0.4, > 2.1.3 >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > Labels: compaction, mob > Fix For: 2.0.7, 2.2.3, 2.1.9 > > Attachments: HBASE-22075-v1.patch, HBASE-22075-v2.patch, > HBASE-22075.test-only.0.patch, HBASE-22075.test-only.1.patch, > HBASE-22075.test-only.2.patch, ReproMOBDataLoss.java > > > When MOB compaction fails during last step (bulk load of a newly created > reference file) there is a high chance of a data loss due to partially loaded > reference file, cells of which refer to (now) non-existent MOB file. The > newly created MOB file is deleted automatically in case of a MOB compaction > failure, but some cells with the references to this file might be loaded to > HBase. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22640) Random init hstore lastFlushTime
[ https://issues.apache.org/jira/browse/HBASE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22640: -- Fix Version/s: (was: 2.1.8) 2.1.9 > Random init hstore lastFlushTime > - > > Key: HBASE-22640 > URL: https://issues.apache.org/jira/browse/HBASE-22640 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Bing Xiao >Assignee: Bing Xiao >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9 > > Attachments: HBASE-22640-master-v1.patch > > > During with open region use current time as hstore last flush time, and no > mush data put cause memstore flush, after flushCheckInterval all memstore > will flush together bring concentrated IO and compaction make high request > latency；So random init lastFlushTime -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-21981) MMaped bucket cache IOEngine does not work with persistence
[ https://issues.apache.org/jira/browse/HBASE-21981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21981: -- Fix Version/s: (was: 2.1.8) 2.1.9 > MMaped bucket cache IOEngine does not work with persistence > --- > > Key: HBASE-21981 > URL: https://issues.apache.org/jira/browse/HBASE-21981 > Project: HBase > Issue Type: Bug > Components: BucketCache >Affects Versions: 2.1.3 >Reporter: ramkrishna.s.vasudevan >Assignee: Anoop Sam John >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9 > > Attachments: HBASE-21981.patch, HBASE-21981.patch > > > The MMap based IOEngines does not retrieve the data back if > 'hbase.bucketcache.persistent.path' is enabled. FileIOEngine works fine but > only the FileMMapEngine has this problem. > The reason is that we don't get the byte buffers in the proper order while > reading back from the file in case of persistence. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22640) Random init hstore lastFlushTime
[ https://issues.apache.org/jira/browse/HBASE-22640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22640: -- Status: Open (was: Patch Available) > Random init hstore lastFlushTime > - > > Key: HBASE-22640 > URL: https://issues.apache.org/jira/browse/HBASE-22640 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Bing Xiao >Assignee: Bing Xiao >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9 > > Attachments: HBASE-22640-master-v1.patch > > > During with open region use current time as hstore last flush time, and no > mush data put cause memstore flush, after flushCheckInterval all memstore > will flush together bring concentrated IO and compaction make high request > latency；So random init lastFlushTime -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-23300) Set version as 2.1.8 in branch-2.1 in prep for first RC of 2.1.8
[ https://issues.apache.org/jira/browse/HBASE-23300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23300 started by Duo Zhang. - > Set version as 2.1.8 in branch-2.1 in prep for first RC of 2.1.8 > > > Key: HBASE-23300 > URL: https://issues.apache.org/jira/browse/HBASE-23300 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23300) Set version as 2.1.8 in branch-2.1 in prep for first RC of 2.1.8
[ https://issues.apache.org/jira/browse/HBASE-23300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23300: - Assignee: Duo Zhang > Set version as 2.1.8 in branch-2.1 in prep for first RC of 2.1.8 > > > Key: HBASE-23300 > URL: https://issues.apache.org/jira/browse/HBASE-23300 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-21981) MMaped bucket cache IOEngine does not work with persistence
[
https://issues.apache.org/jira/browse/HBASE-21981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975065#comment-16975065
]
HBase QA commented on HBASE-21981:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HBASE-21981 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-21981 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960889/HBASE-21981.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/1022/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> MMaped bucket cache IOEngine does not work with persistence
> ---
>
> Key: HBASE-21981
> URL: https://issues.apache.org/jira/browse/HBASE-21981
> Project: HBase
> Issue Type: Bug
> Components: BucketCache
>Affects Versions: 2.1.3
>Reporter: ramkrishna.s.vasudevan
>Assignee: Anoop Sam John
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-21981.patch, HBASE-21981.patch
>
>
> The MMap based IOEngines does not retrieve the data back if
> 'hbase.bucketcache.persistent.path' is enabled. FileIOEngine works fine but
> only the FileMMapEngine has this problem.
> The reason is that we don't get the byte buffers in the proper order while
> reading back from the file in case of persistence.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-21981) MMaped bucket cache IOEngine does not work with persistence
[ https://issues.apache.org/jira/browse/HBASE-21981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21981: -- Status: Open (was: Patch Available) > MMaped bucket cache IOEngine does not work with persistence > --- > > Key: HBASE-21981 > URL: https://issues.apache.org/jira/browse/HBASE-21981 > Project: HBase > Issue Type: Bug > Components: BucketCache >Affects Versions: 2.1.3 >Reporter: ramkrishna.s.vasudevan >Assignee: Anoop Sam John >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9 > > Attachments: HBASE-21981.patch, HBASE-21981.patch > > > The MMap based IOEngines does not retrieve the data back if > 'hbase.bucketcache.persistent.path' is enabled. FileIOEngine works fine but > only the FileMMapEngine has this problem. > The reason is that we don't get the byte buffers in the proper order while > reading back from the file in case of persistence. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 opened a new pull request #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o…
Apache9 opened a new pull request #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o… URL: https://github.com/apache/hbase/pull/833 …f 2.1.8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23247) [hbck2] Schedule SCPs for 'Unknown Servers'
[
https://issues.apache.org/jira/browse/HBASE-23247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-23247:
--
Fix Version/s: 2.1.8
2.3.0
3.0.0
> [hbck2] Schedule SCPs for 'Unknown Servers'
> ---
>
> Key: HBASE-23247
> URL: https://issues.apache.org/jira/browse/HBASE-23247
> Project: HBase
> Issue Type: Bug
> Components: hbck2
>Affects Versions: 2.2.2
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
>
> I've run into an 'Unknown Server' phenomenon.Meta has regions assigned to
> servers that the cluster no longer knows about. You can see the list in the
> 'HBCK Report' page down the end (run 'catalogjanitor_run' in the shell to
> generate a fresh report). Fix is tough if you try to do
> unassign/assign/close/etc. because new assign/unassign is insistent on
> checking the close succeeded by trying to contact the 'unknown server' and
> being insistent on not moving on until it succeeds; TODO. There are a few
> ways of obtaining this state of affairs. I'll list a few below in a minute.
> Meantime, an hbck2 'fix' seems just the ticket; Run a SCP for the 'Unknown
> Server' and it should clear the meta of all the bad server references So
> just schedule an SCP using scheduleRecoveries commandonly in this case it
> fails before scheduling SCP with the below; i.e. a FNFE because no dir for
> the 'Unknown Server'.
> {code}
> 22:41:13.909 [main] INFO
> org.apache.hadoop.hbase.client.ConnectionImplementation - Closing master
> protocol: MasterService
> Exception in thread "main" java.io.IOException:
> org.apache.hbase.thirdparty.com.google.protobuf.ServiceException:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(java.io.FileNotFoundException):
> java.io.FileNotFoundException: File
> hdfs://nameservice1/hbase/genie/WALs/s1.d.com,16020,1571170081872 does not
> exist.
>at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:986)
>at
> org.apache.hadoop.hdfs.DistributedFileSystem.access$1000(DistributedFileSystem.java:122)
>at
> org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1046)
>at
> org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1043)
>at
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
>at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:1053)
>at
> org.apache.hadoop.fs.FilterFileSystem.listStatus(FilterFileSystem.java:258)
>at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1802)
>at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1844)
>at
> org.apache.hadoop.hbase.master.MasterRpcServices.containMetaWals(MasterRpcServices.java:2709)
>at
> org.apache.hadoop.hbase.master.MasterRpcServices.scheduleServerCrashProcedure(MasterRpcServices.java:2488)
>at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$HbckService$2.callBlockingMethod(MasterProtos.java)
>at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
>at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
>at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
>at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)
>at
> org.apache.hadoop.hbase.client.HBaseHbck.scheduleServerCrashProcedures(HBaseHbck.java:175)
>at
> org.apache.hadoop.hbase.client.Hbck.scheduleServerCrashProcedure(Hbck.java:118)
>at org.apache.hbase.HBCK2.scheduleRecoveries(HBCK2.java:345)
>at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:746)
>at org.apache.hbase.HBCK2.run(HBCK2.java:631)
>at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
>at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
>at org.apache.hbase.HBCK2.main(HBCK2.java:865)
> {code}
> A simple fix makes it so I can schedule an SCP which indeed clears out the
> 'Unknown Server' to restore saneness on the cluster.
> As to how to get 'Unknown Server':
> 1. The current scenario came about because of this exception while processing
> a server crash procedure made it so the SCP exited just after splitting logs
> but before it cleared old assigns. A new server instance that came up after
> this one went down purged the server from dead servers list though there were
> still Procedures in flight (The cluster was under a crippling overloading)
> {code}
> 2019-11-02 21:02:34,775 DEBUG
> org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure: Done splitting
> WALs pid=112532, state=RUNNABLE:SERVER_CRASH_SPLIT_LOGS, locked=true;
> ServerCrashProc
[jira] [Commented] (HBASE-21424) Change flakies and nightlies so scheduled less often
[
https://issues.apache.org/jira/browse/HBASE-21424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975080#comment-16975080
]
Duo Zhang commented on HBASE-21424:
---
We append an addendum after one year...
> Change flakies and nightlies so scheduled less often
>
>
> Key: HBASE-21424
> URL: https://issues.apache.org/jira/browse/HBASE-21424
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 1.4.9, 2.1.2, 1.2.9
>
> Attachments: HBASE-21424.branch-2.1.001.patch
>
>
> Infra wrote us:
> {code}
> Chris Thistlethwaite
> 9:09 AM (25 minutes ago)
> to dev, team
> Greetings!
> During the Jenkins outage yesterday I noticed a ton of builds from
> HBase-Flaky-Tests
> https://builds.apache.org/view/H-L/view/HBase/job/HBase-Flaky-Tests/ in
> the queue. Turns out this runs a bunch of pipeline builds every hour
> which clogs up Jenkins, both for you and other projects. For example,
> branch-2.0 is currently queuing 3 builds, waiting on the 4th to finish,
> and it's also behind the HBase Nightly.
> That brings me to HBase Nightly
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/ it
> runs every 6 hours, which is a bit excessive for a nightly build which
> by definition should be once a day. Especially as it gets dangerously
> close to running into itself as builds currently around 4-5 hours of
> build time.
> I suggest something more like Flaky-Tests every 6 hours and the Nightly
> once a day. If you agree to these changes, feel free to update Jenkins.
> Otherwise, I'll update the jobs in the next few days if there is no
> response.
> Please add t...@infra.apache.org and/or my address to any replies as
> we're not subbed to your dev list.
> Thank you,
> Chris T.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani edited a comment on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition
virajjasani edited a comment on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#issuecomment-553338857 > Any chance for a unit test? @apurtell I tried writing at least one test but for this specific edge case I am not able to reproduce in unit test. Open for any suggestions. In fact, while reproducing this error in code, I had to manually change version of ZNode just to test our retry mechanism, but unit test repro seems tough. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition
virajjasani commented on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#issuecomment-554363978 > > Any chance for a unit test? > > @apurtell I tried writing at least one test but for this specific edge case I am not able to reproduce in unit test. Open for any suggestions. > > In fact, while reproducing this error in code, I had to manually change version of ZNode just to test our retry mechanism, but unit test repro seems tough. Is this fine with you? Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position
Apache-HBase commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position URL: https://github.com/apache/hbase/pull/829#issuecomment-554373636 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 44s | master passed | | +1 :green_heart: | compile | 3m 15s | master passed | | +1 :green_heart: | checkstyle | 2m 54s | master passed | | +0 :ok: | refguide | 6m 24s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 7s | master passed | | +0 :ok: | spotbugs | 3m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 24m 4s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 29s | the patch passed | | +1 :green_heart: | compile | 3m 16s | the patch passed | | +1 :green_heart: | cc | 3m 16s | the patch passed | | +1 :green_heart: | javac | 3m 16s | the patch passed | | +1 :green_heart: | checkstyle | 2m 56s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 6m 42s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 5m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 22s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | hbaseprotoc | 7m 58s | the patch passed | | +1 :green_heart: | javadoc | 4m 8s | the patch passed | | +1 :green_heart: | findbugs | 25m 3s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 176m 5s | root in the patch failed. | | +1 :green_heart: | asflicense | 2m 3s | The patch does not generate ASF License warnings. | | | | 317m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-829/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/829 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool refguide | | uname | Linux e964fe7ca721 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-829/out/precommit/personality/provided.sh | | git revision | master / 67f9afc722 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-829/2/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-829/2/artifact/out/patch-site/book.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-829/2/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-829/2/testReport/ | | Max. process+thread count | 4523 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-829/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service.
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975140#comment-16975140
]
Hudson commented on HBASE-23283:
Results for branch master
[build #1537 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1537/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[
https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975141#comment-16975141
]
Hudson commented on HBASE-19450:
Results for branch master
[build #1537 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1537/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add log about average execution time for ScheduledChore
> ---
>
> Key: HBASE-19450
> URL: https://issues.apache.org/jira/browse/HBASE-19450
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-19450.master.001.patch,
> HBASE-19450.master.002.patch, HBASE-19450.master.003.patch,
> HBASE-19450.master.004.patch
>
>
> So far, there is no information about the exact execution time for a chore,
> we can provide log information about it. It also brings other benefits, like
> discovering inefficient chores which show rooms for improvement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23290) shell processlist command is broken
[
https://issues.apache.org/jira/browse/HBASE-23290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975139#comment-16975139
]
Hudson commented on HBASE-23290:
Results for branch master
[build #1537 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1537/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> shell processlist command is broken
> ---
>
> Key: HBASE-23290
> URL: https://issues.apache.org/jira/browse/HBASE-23290
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.2.2
>Reporter: Michael Stack
>Assignee: Mingliang Liu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23290.000.patch, Screen Shot 2019-11-14 at 1.56.00
> AM.png
>
>
> {code}
> hbase(main):008:0> help 'processlist'
> Show regionserver task list.
> hbase> processlist
> hbase> processlist 'all'
> hbase> processlist 'general'
> hbase> processlist 'handler'
> hbase> processlist 'rpc'
> hbase> processlist 'operation'
> hbase> processlist 'all','host187.example.com'
> hbase> processlist 'all','host187.example.com,16020'
> hbase> processlist 'all','host187.example.com,16020,1289493121758'
> hbase(main):009:0> processlist 'all'
> 3377 tasks as of: 2019-11-13 22:58:57
> ERROR: too few arguments
> For usage try 'help "processlist"'
> Took 2.2107 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] guangxuCheng commented on a change in pull request #831: HBASE-23297 [RSGROUP] build RegionPlan per group not per table
guangxuCheng commented on a change in pull request #831: HBASE-23297 [RSGROUP]
build RegionPlan per group not per table
URL: https://github.com/apache/hbase/pull/831#discussion_r346850295
##
File path:
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##
@@ -607,6 +613,22 @@ public void removeServers(Set servers) throws
IOException {
return result;
}
+ private Map> getAssignmentsByGroup(String
groupName)
Review comment:
mis-placed regions will not be moved to the group.
We should get the grouping information through the tables in the group
instead of the servers
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (HBASE-23303) Add security headers to REST server/info page
Andor Molnar created HBASE-23303:
Summary: Add security headers to REST server/info page
Key: HBASE-23303
URL: https://issues.apache.org/jira/browse/HBASE-23303
Project: HBase
Issue Type: Improvement
Components: REST
Affects Versions: 2.2.2, 2.1.7, 2.0.6, 3.0.0
Reporter: Andor Molnar
Assignee: Andor Molnar
Vulnerability scanners suggest that the following extra headers should be added
to both Info/Rest server endpoints which are exposed by {{hbase-rest}} project.
* X-Content-Type-Options: nosniff
* X-XSS-Protection: 1; mode=block
* X-Frame-Options: SAMEORIGIN
Info server already has "X-Frame-Options: DENY" which is more restrictive than
"SAMEORIGIN", so it's probably fine. All of three headers are missing from REST
responses.
I'll put together a patch to resolve this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] joshelser commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…
joshelser commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas… URL: https://github.com/apache/hbase/pull/746#discussion_r346857842 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java ## @@ -92,7 +91,7 @@ private Boolean instanceOfCanUnbuffer = null; // Using reflection to get org.apache.hadoop.fs.CanUnbuffer#unbuffer method to avoid compilation // errors against Hadoop pre 2.6.4 and 2.7.1 versions. Review comment: Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas…
joshelser commented on a change in pull request #746: HBASE-23195
FSDataInputStreamWrapper unbuffer can NOT invoke the clas…
URL: https://github.com/apache/hbase/pull/746#discussion_r346864273
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
##
@@ -270,39 +269,23 @@ public void unbuffer() {
if (this.instanceOfCanUnbuffer == null) {
// To ensure we compute whether the stream is instance of CanUnbuffer
only once.
this.instanceOfCanUnbuffer = false;
-Class[] streamInterfaces = streamClass.getInterfaces();
-for (Class c : streamInterfaces) {
- if
(c.getCanonicalName().toString().equals("org.apache.hadoop.fs.CanUnbuffer")) {
-try {
- this.unbuffer = streamClass.getDeclaredMethod("unbuffer");
-} catch (NoSuchMethodException | SecurityException e) {
- if (isLogTraceEnabled) {
-LOG.trace("Failed to find 'unbuffer' method in class " +
streamClass
-+ " . So there may be a TCP socket connection "
-+ "left open in CLOSE_WAIT state.", e);
- }
- return;
-}
-this.instanceOfCanUnbuffer = true;
-break;
- }
+if (CanUnbuffer.class.isAssignableFrom(streamClass)) {
+ this.unbuffer = (CanUnbuffer) wrappedStream;
+ this.instanceOfCanUnbuffer = true;
}
}
if (this.instanceOfCanUnbuffer) {
try {
- this.unbuffer.invoke(wrappedStream);
-} catch (IllegalAccessException | IllegalArgumentException |
InvocationTargetException e) {
+ this.unbuffer.unbuffer();
+} catch (UnsupportedOperationException e){
Review comment:
Thanks, I'll take a look at those classes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…
Apache-HBase commented on issue #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#issuecomment-554395100 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 58s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | checkstyle | 1m 30s | master passed | | +1 :green_heart: | shadedjars | 5m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | | +0 :ok: | spotbugs | 4m 28s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 33s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | -1 :x: | checkstyle | 1m 29s | hbase-server: The patch generated 4 new + 2 unchanged - 0 fixed = 6 total (was 2) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 56s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 24s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | | +1 :green_heart: | findbugs | 4m 34s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 335m 10s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 397m 45s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.master.procedure.TestSCPWithMeta | | | hadoop.hbase.master.TestDLSAsyncFSWAL | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash | | | hadoop.hbase.quotas.TestQuotaAdmin | | | hadoop.hbase.wal.TestFSHLogCorruptionDueToDanglingByteBuffer | | | hadoop.hbase.regionserver.TestCleanupMetaWAL | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService | | | hadoop.hbase.master.TestServerCrashProcedureCarryingMetaStuck | | | hadoop.hbase.client.TestMultiParallel | | | hadoop.hbase.regionserver.TestPerColumnFamilyFlush | | | hadoop.hbase.master.procedure.TestSCPWithoutMetaWithReplicas | | | hadoop.hbase.regionserver.TestSplitWalDataLoss | | | hadoop.hbase.replication.TestSerialReplicationFailover | | | hadoop.hbase.wal.TestWALSplitCompressed | | | hadoop.hbase.master.procedure.TestSCPWithoutMeta | | | hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalGiveUpSplitting | | | hadoop.hbase.coprocessor.TestRegionObserverInterface | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.master.procedure.TestProcedurePriority | | | hadoop.hbase.master.assignment.TestReportRegionStateTransitionFromDeadServer | | | hadoop.hbase.master.TestMetaShutdownHandler | | | hadoop.hbase.TestIOFencing | | | hadoop.hbase.regionserver.TestShutdownWhileWALBroken | | | hadoop.hbase.regionserver.TestMutateRowsRecovery | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.master.TestSplitRegionWhileRSCrash | | | hadoop.hbase.client.TestHbck | | | hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash | | | hadoop.hbase.master.procedure.TestSCPWithoutMetaWithReplicasWithoutZKCoordinated | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.master.procedure.TestSplitWALProcedure | | | hadoop.hbase.wal.TestWALFactory | | | hadoop.hbase.client.TestMetaWithReplicas | | | hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicas | | | hadoop.hbase.client.TestScannerTimeout | | | hadoop.hbase.master.TestClusterRestartFailover | | | hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | hadoop
[GitHub] [hbase] udaikashyap commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position
udaikashyap commented on issue #829: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position URL: https://github.com/apache/hbase/pull/829#issuecomment-554425313 The unit test failure seems due to bad xml file /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-829/src/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover.xml I have no idea about how this file gets generated or used? @meszibalu can you give me some idea? What can be done to fix this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22969) A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position
[
https://issues.apache.org/jira/browse/HBASE-22969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975211#comment-16975211
]
Udai Bhan Kashyap commented on HBASE-22969:
---
The unit test failure seems due to bad xml file
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-829/src/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover.xml
I have no idea about how this file gets generated or used? Can someone help?
> A new binary component comparator(BinaryComponentComparator) to perform
> comparison of arbitrary length and position
> ---
>
> Key: HBASE-22969
> URL: https://issues.apache.org/jira/browse/HBASE-22969
> Project: HBase
> Issue Type: New Feature
> Components: Filters
>Reporter: Udai Bhan Kashyap
>Assignee: Udai Bhan Kashyap
>Priority: Minor
> Attachments: HBASE-22969.0003.patch, HBASE-22969.0004.patch,
> HBASE-22969.0005.patch, HBASE-22969.0006.patch, HBASE-22969.0007.patch,
> HBASE-22969.0008.patch, HBASE-22969.0009.patch, HBASE-22969.0010.patch,
> HBASE-22969.0011.patch, HBASE-22969.0012.patch, HBASE-22969.0013.patch,
> HBASE-22969.0014.patch, HBASE-22969.HBASE-22969.0001.patch,
> HBASE-22969.master.0001.patch
>
>
> Lets say you have composite key: a+b+c+d. And for simplicity assume that
> a,b,c, and d all are 4 byte integers.
> Now, if you want to execute a query which is semantically same to following
> sql:
> {{"SELECT * from table where a=1 and b > 10 and b < 20 and c > 90 and c < 100
> and d=1"}}
> The only choice you have is to do client side filtering. That could be lots
> of unwanted data going through various software components and network.
> Solution:
> We can create a "component" comparator which takes the value of the
> "component" and its relative position in the key to pass the 'Filter'
> subsystem of the server:
> {code}
> FilterList filterList = new FilterList(FilterList.Operator.MUST_PASS_ALL);
> int bOffset = 4;
> byte[] b10 = Bytes.toBytes(10);
> Filter b10Filter = new RowFilter(CompareFilter.CompareOp.GREATER,
> new BinaryComponentComparator(b10,bOffset));
> filterList.addFilter(b10Filter);
> byte[] b20 = Bytes.toBytes(20);
> Filter b20Filter = new RowFilter(CompareFilter.CompareOp.LESS,
> new BinaryComponentComparator(b20,bOffset));
> filterList.addFilter(b20Filter);
> int cOffset = 8;
> byte[] c90 = Bytes.toBytes(90);
> Filter c90Filter = new RowFilter(CompareFilter.CompareOp.GREATER,
> new BinaryComponentComparator(c90,cOffset));
> filterList.addFilter(c90Filter);
> byte[] c100 = Bytes.toBytes(100);
> Filter c100Filter = new RowFilter(CompareFilter.CompareOp.LESS,
> new BinaryComponentComparator(c100,cOffset));
> filterList.addFilter(c100Filter);
> in dOffset = 12;
> byte[] d1 = Bytes.toBytes(1);
> Filter dFilter = new RowFilter(CompareFilter.CompareOp.EQUAL,
> new BinaryComponentComparator(d1,dOffset));
> filterList.addFilter(dFilter);
> //build start and end key for scan
> int aOffset = 0;
> byte[] startKey = new byte[16]; //key size with four ints
> Bytes.putInt(startKey,aOffset,1); //a=1
> Bytes.putInt(startKey,bOffset,11); //b=11, takes care of b > 10
> Bytes.putInt(startKey,cOffset,91); //c=91,
> Bytes.putInt(startKey,dOffset,1); //d=1,
> byte[] endKey = new byte[16];
> Bytes.putInt(endKey,aOffset,1); //a=1
> Bytes.putInt(endKey,bOffset,20); //b=20, takes care of b < 20
> Bytes.putInt(endKey,cOffset,100); //c=100,
> Bytes.putInt(endKey,dOffset,1); //d=1,
> //setup scan
> Scan scan = new Scan(startKey,endKey);
> scan.setFilter(filterList);
> //The scanner below now should give only desired rows.
> //No client side filtering is required.
> ResultScanner scanner = table.getScanner(scan);
> {code}
> The comparator can be used with any filter which makes use of
> ByteArrayComparable. Most notably it can be used with ValueFilter to filter
> out KV based on partial comparison of 'values' :
> {code}
> byte[] partialValue = Bytes.toBytes("partial_value");
> int partialValueOffset =
> Filter partialValueFilter = new
> ValueFilter(CompareFilter.CompareOp.GREATER,
> new BinaryComponentComparator(partialValue,partialValueOffset));
> {code}
> Which in turn can be combined with RowFilter to create a poweful predicate:
> {code}
> RowFilter rowFilter = new RowFilter(GREATER, new
> BinaryComponentComparator(Bytes.toBytes("a"),1);
> FilterLiost fl = new FilterList
> (MUST_PASS_ALL,rowFilter,partialValueFilter);
> {code}
--
This message was sent
[jira] [Created] (HBASE-23304) Implement RPCs needed for master based registry
Bharath Vissapragada created HBASE-23304: Summary: Implement RPCs needed for master based registry Key: HBASE-23304 URL: https://issues.apache.org/jira/browse/HBASE-23304 Project: HBase Issue Type: Sub-task Affects Versions: 3.0.0 Reporter: Bharath Vissapragada Assignee: Bharath Vissapragada We need to implement RPCs on masters needed by client to fetch information like clusterID, active master server name, meta locations etc. These RPCs are used by clients during connection init. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23305) Implement master baseed AsyncRegistry
Bharath Vissapragada created HBASE-23305: Summary: Implement master baseed AsyncRegistry Key: HBASE-23305 URL: https://issues.apache.org/jira/browse/HBASE-23305 Project: HBase Issue Type: Sub-task Components: master Reporter: Bharath Vissapragada Assignee: Bharath Vissapragada Once we have all the RPCs in place (via HBASE-23304), implement a pluggable master based AsyncRegistry (like ZKAsyncRegistry) which clients can use to directly connect to master and fetch all the meta information needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23305) Implement master based AsyncRegistry
[ https://issues.apache.org/jira/browse/HBASE-23305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-23305: - Summary: Implement master based AsyncRegistry (was: Implement master baseed AsyncRegistry) > Implement master based AsyncRegistry > > > Key: HBASE-23305 > URL: https://issues.apache.org/jira/browse/HBASE-23305 > Project: HBase > Issue Type: Sub-task > Components: master >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Major > > Once we have all the RPCs in place (via HBASE-23304), implement a pluggable > master based AsyncRegistry (like ZKAsyncRegistry) which clients can use to > directly connect to master and fetch all the meta information needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23247) [hbck2] Schedule SCPs for 'Unknown Servers'
[
https://issues.apache.org/jira/browse/HBASE-23247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975291#comment-16975291
]
Michael Stack commented on HBASE-23247:
---
Adding link to subsequent issue which makes the hbck2 queuing of SCP more
thorough cleaning up 'Unknown Servers'.
> [hbck2] Schedule SCPs for 'Unknown Servers'
> ---
>
> Key: HBASE-23247
> URL: https://issues.apache.org/jira/browse/HBASE-23247
> Project: HBase
> Issue Type: Bug
> Components: hbck2
>Affects Versions: 2.2.2
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
>
> I've run into an 'Unknown Server' phenomenon.Meta has regions assigned to
> servers that the cluster no longer knows about. You can see the list in the
> 'HBCK Report' page down the end (run 'catalogjanitor_run' in the shell to
> generate a fresh report). Fix is tough if you try to do
> unassign/assign/close/etc. because new assign/unassign is insistent on
> checking the close succeeded by trying to contact the 'unknown server' and
> being insistent on not moving on until it succeeds; TODO. There are a few
> ways of obtaining this state of affairs. I'll list a few below in a minute.
> Meantime, an hbck2 'fix' seems just the ticket; Run a SCP for the 'Unknown
> Server' and it should clear the meta of all the bad server references So
> just schedule an SCP using scheduleRecoveries commandonly in this case it
> fails before scheduling SCP with the below; i.e. a FNFE because no dir for
> the 'Unknown Server'.
> {code}
> 22:41:13.909 [main] INFO
> org.apache.hadoop.hbase.client.ConnectionImplementation - Closing master
> protocol: MasterService
> Exception in thread "main" java.io.IOException:
> org.apache.hbase.thirdparty.com.google.protobuf.ServiceException:
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(java.io.FileNotFoundException):
> java.io.FileNotFoundException: File
> hdfs://nameservice1/hbase/genie/WALs/s1.d.com,16020,1571170081872 does not
> exist.
>at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:986)
>at
> org.apache.hadoop.hdfs.DistributedFileSystem.access$1000(DistributedFileSystem.java:122)
>at
> org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1046)
>at
> org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1043)
>at
> org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)
>at
> org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:1053)
>at
> org.apache.hadoop.fs.FilterFileSystem.listStatus(FilterFileSystem.java:258)
>at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1802)
>at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1844)
>at
> org.apache.hadoop.hbase.master.MasterRpcServices.containMetaWals(MasterRpcServices.java:2709)
>at
> org.apache.hadoop.hbase.master.MasterRpcServices.scheduleServerCrashProcedure(MasterRpcServices.java:2488)
>at
> org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$HbckService$2.callBlockingMethod(MasterProtos.java)
>at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
>at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
>at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
>at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)
>at
> org.apache.hadoop.hbase.client.HBaseHbck.scheduleServerCrashProcedures(HBaseHbck.java:175)
>at
> org.apache.hadoop.hbase.client.Hbck.scheduleServerCrashProcedure(Hbck.java:118)
>at org.apache.hbase.HBCK2.scheduleRecoveries(HBCK2.java:345)
>at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:746)
>at org.apache.hbase.HBCK2.run(HBCK2.java:631)
>at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
>at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
>at org.apache.hbase.HBCK2.main(HBCK2.java:865)
> {code}
> A simple fix makes it so I can schedule an SCP which indeed clears out the
> 'Unknown Server' to restore saneness on the cluster.
> As to how to get 'Unknown Server':
> 1. The current scenario came about because of this exception while processing
> a server crash procedure made it so the SCP exited just after splitting logs
> but before it cleared old assigns. A new server instance that came up after
> this one went down purged the server from dead servers list though there were
> still Procedures in flight (The cluster was under a crippling overloading)
> {code}
> 2019-11-02 21:02:34,775 DEBUG
> org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure:
[GitHub] [hbase] Apache-HBase commented on issue #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o…
Apache-HBase commented on issue #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o… URL: https://github.com/apache/hbase/pull/833#issuecomment-554493379 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 26s | branch-2.1 passed | | +1 :green_heart: | compile | 3m 3s | branch-2.1 passed | | +1 :green_heart: | checkstyle | 2m 49s | branch-2.1 passed | | +1 :green_heart: | shadedjars | 4m 22s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 11m 45s | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 8s | branch-2.1 passed | | +0 :ok: | mvndep | 5m 29s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 6s | the patch passed | | +1 :green_heart: | compile | 3m 5s | the patch passed | | +1 :green_heart: | javac | 3m 5s | the patch passed | | +1 :green_heart: | checkstyle | 2m 47s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 51s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedjars | 4m 18s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 22m 0s | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 :green_heart: | javadoc | 12m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 270m 49s | root in the patch passed. | | +1 :green_heart: | asflicense | 18m 9s | The patch does not generate ASF License warnings. | | | | 385m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-833/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/833 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile checkstyle | | uname | Linux 4906931ba30e 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-833/out/precommit/personality/provided.sh | | git revision | branch-2.1 / eb0fc936be | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-833/1/testReport/ | | Max. process+thread count | 5190 (vs. ulimit of 1) | | modules | C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-zookeeper hbase-replication hbase-resource-bundle hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-833/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us
[GitHub] [hbase] bharathv commented on issue #830: HBASE-23281: Track meta region locations in masters
bharathv commented on issue #830: HBASE-23281: Track meta region locations in masters URL: https://github.com/apache/hbase/pull/830#issuecomment-554499618 I'm fairly certain that the test failures are not related to the patch. There is a long discussion between @busbey and me in the Slack channel regarding failures like "Failed to read test report file /home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2.1/output-jdk8-hadoop3/archiver/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.replication.TestMasterReplication.xml org.dom4j.DocumentException: Error on line 86 of document : XML document structures must start and end within the same entity. Nested exception: XML document structures must start and end within the same entity." These look like a manifestation of tests timing out (and eventually getting killed) and resulting in corrupt sure fire reports that Jenkins is not able to interpret. It is being tracked in https://issues.apache.org/jira/browse/HBASE-22470 I re-ran the failed tests and they pass for me locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22701) Better handle invalid local directory for DynamicClassLoader
[
https://issues.apache.org/jira/browse/HBASE-22701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-22701:
Fix Version/s: 1.4.12
1.6.0
> Better handle invalid local directory for DynamicClassLoader
>
>
> Key: HBASE-22701
> URL: https://issues.apache.org/jira/browse/HBASE-22701
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 2.3.0, 1.6.0, 2.1.7, 2.2.2, 1.4.12
>
> Attachments: HBASE-22701.001.patch, HBASE-22701.002.patch,
> HBASE-22701.003.patch
>
>
> If you give HBase an {{hbase.local.dir}} (usually, "{{hbase.tmp.dir}}/local")
> which is not writable to it, you will get some weird errors on the scan path.
> I just saw this (again?) with Phoenix.
> Specifically, the first attempt to reference DynamicClassLoader (via
> ProtobufUtil), will result in an ExceptionInInitializationError because the
> unchecked exception coming out of DynamicClassLoader's constructor interrupts
> the loading of {{DynamicClassLoader.class}}.
> {noformat}
> 2019-07-14 06:25:34,284 ERROR
> [RpcServer.Metadata.Fifo.handler=12,queue=0,port=16020]
> coprocessor.MetaDataEndpointImpl: dropTable failed
> org.apache.hadoop.hbase.DoNotRetryIOException:
> java.lang.ExceptionInInitializerError
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.translateException(RpcRetryingCallerImpl.java:221)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:194)
> at
> org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:387)
> at
> org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:361)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:107)
> at
> org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture.run(ResultBoundedCompletionService.java:80)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.ExceptionInInitializerError
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toFilter(ProtobufUtil.java:1598)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toScan(ProtobufUtil.java:1152)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.newRegionScanner(RSRpcServices.java:2967)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3301)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.openScanner(ScannerCallable.java:332)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:242)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:58)
> at
> org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:127)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:192)
> ... 7 more
> Caused by: java.lang.RuntimeException: Failed to create local dir
> /hadoopfs/fs1/hbase/local/jars, DynamicClassLoader failed to init
> at
> org.apache.hadoop.hbase.util.DynamicClassLoader.initTempDir(DynamicClassLoader.java:110)
> at
> org.apache.hadoop.hbase.util.DynamicClassLoader.(DynamicClassLoader.java:98)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil$ClassLoaderHolder.lambda$static$0(ProtobufUtil.java:261)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil$ClassLoaderHolder.(ProtobufUtil.java:260)
> ... 16 more
> {noformat}
> Every subsequent call will result in a NoClassDefFoundError, because we
> already tried to load DynamicClassLoader.class once and failed.
> {noformat}
> 2019-07-14 06:25:34,380 ERROR
> [RpcServer.Metadata.Fifo.handler=2,queue=2,port=16020]
> coprocessor.MetaDataEndpointImpl: dropTable failed
> org.apache.hadoop.hbase.DoNotRetryIOException:
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil$ClassLoaderHolder
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.translateException(RpcRetryingCallerImpl.java:221)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:194)
> at
> org.apache.hadoop
[GitHub] [hbase] Apache-HBase commented on issue #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter…
Apache-HBase commented on issue #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#issuecomment-554519806 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 30s | master passed | | +1 :green_heart: | compile | 0m 59s | master passed | | +1 :green_heart: | checkstyle | 1m 17s | master passed | | +1 :green_heart: | shadedjars | 4m 41s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | | +0 :ok: | spotbugs | 4m 31s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 29s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 12s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | -1 :x: | checkstyle | 1m 15s | hbase-server: The patch generated 6 new + 2 unchanged - 0 fixed = 8 total (was 2) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 16m 49s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | | +1 :green_heart: | findbugs | 4m 17s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 271m 33s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 46s | The patch does not generate ASF License warnings. | | | | 330m 28s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | hadoop.hbase.regionserver.TestRegionServerAbortTimeout | | | hadoop.hbase.master.procedure.TestSCPWithMetaWithoutZKCoordinated | | | hadoop.hbase.replication.TestSerialReplicationFailover | | | hadoop.hbase.wal.TestWALSplitBoundedLogWriterCreation | | | hadoop.hbase.client.TestScannerTimeout | | | hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalCopyToRemote | | | hadoop.hbase.master.assignment.TestSCPGetRegionsRace | | | hadoop.hbase.master.TestMetaShutdownHandler | | | hadoop.hbase.client.TestHbck | | | hadoop.hbase.wal.TestFSHLogCorruptionDueToDanglingByteBuffer | | | hadoop.hbase.regionserver.TestCompactionInDeadRegionServer | | | hadoop.hbase.TestIOFencing | | | hadoop.hbase.master.TestServerCrashProcedureStuck | | | hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicas | | | hadoop.hbase.master.assignment.TestAssignmentOnRSCrash | | | hadoop.hbase.master.TestDLSAsyncFSWAL | | | hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash | | | hadoop.hbase.coprocessor.TestRegionObserverInterface | | | hadoop.hbase.master.procedure.TestSCPWithoutMeta | | | hadoop.hbase.master.TestClusterRestartFailoverSplitWithoutZk | | | hadoop.hbase.regionserver.TestSplitWalDataLoss | | | hadoop.hbase.master.procedure.TestSCPWithoutMetaWithReplicas | | | hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash | | | hadoop.hbase.regionserver.TestOpenSeqNumUnexpectedIncrease | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.TestZooKeeper | | | hadoop.hbase.master.procedure.TestSCPWithMeta | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.wal.TestWALSplit | | | hadoop.hbase.client.TestMetaWithReplicas | | | hadoop.hbase.wal.TestWALFactory | | | hadoop.hbase.quotas.TestQuotaAdmin | | | hadoop.hbase.master.procedure.TestSCPWithoutMetaWithoutZKCoordinated | | | hadoop.hbase.regionserver.TestPerColumnFamilyFlush | | | hadoop.hbase.regionserver.TestCleanupMetaWAL | | | hadoop.hbase.coprocessor.TestWALObserver | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.master.assignment.TestReportRegionStateTransitionFromDeadServer | | | hadoop.hbase.regionserver.TestRegionReplicaFailover | | |
[jira] [Updated] (HBASE-23287) LogCleaner is not added to choreService
[
https://issues.apache.org/jira/browse/HBASE-23287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated HBASE-23287:
Fix Version/s: 1.4.12
1.6.0
Release Note:
Prior to this change HBase 1.4.11 and 1.5.0 based clusters would fail to clean
up WALs from the oldWALs area automatically. With this change in place clusters
should return to the expected behavior of cleaning up WALs that are no longer
needed.
Resolution: Fixed
Status: Resolved (was: Patch Available)
> LogCleaner is not added to choreService
> ---
>
> Key: HBASE-23287
> URL: https://issues.apache.org/jira/browse/HBASE-23287
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.6.0, 1.4.11
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Blocker
> Fix For: 1.6.0, 1.4.12
>
> Attachments: HBASE-23287.branch-1.0001.patch
>
>
> We found /hbase/oldWALs keeps growing, and we never use replication feature.
> Then we found OldWALsCleaner thread is always in WAITTING state :
> {code:java}
> Thread 176 (OldWALsCleaner-1): State: WAITING Blocked count: 0 Waited count:
> 1 Waiting on
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@2ef05d36
> Stack: sun.misc.Unsafe.park(Native Method)
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
> org.apache.hadoop.hbase.master.cleaner.LogCleaner.deleteFile(LogCleaner.java:185)
>
> org.apache.hadoop.hbase.master.cleaner.LogCleaner.access$000(LogCleaner.java:48)
> org.apache.hadoop.hbase.master.cleaner.LogCleaner$1.run(LogCleaner.java:161)
> java.lang.Thread.run(Thread.java:745)
> {code}
> Finally, we found that LogCleaner is not added to choreService, so LogCleaner
> doesn't run periodically.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reopened HBASE-19450: --- Reopening. This seems to be spewing the logs. I don't think this is what you want [~busbey] (Start up an hbase and tail). > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.master.001.patch, > HBASE-19450.master.002.patch, HBASE-19450.master.003.patch, > HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'
Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers' URL: https://github.com/apache/hbase/pull/826#issuecomment-554544769 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 16s | branch-2 passed | | +1 :green_heart: | compile | 1m 23s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 57s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | branch-2 passed | | +0 :ok: | spotbugs | 3m 19s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 27s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 47s | the patch passed | | +1 :green_heart: | compile | 1m 22s | the patch passed | | +1 :green_heart: | javac | 1m 22s | the patch passed | | -1 :x: | checkstyle | 1m 21s | hbase-server: The patch generated 2 new + 48 unchanged - 0 fixed = 50 total (was 48) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 13s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 10s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 1m 1s | the patch passed | | +1 :green_heart: | findbugs | 4m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 25s | hbase-client in the patch passed. | | -1 :x: | unit | 168m 48s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 5s | The patch does not generate ASF License warnings. | | | | 232m 30s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/826 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7a5ee58f1507 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-826/out/precommit/personality/provided.sh | | git revision | branch-2 / e69431ae8c | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/3/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/3/testReport/ | | Max. process+thread count | 4553 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975445#comment-16975445 ] Sean Busbey commented on HBASE-19450: - I went through minicluster logs and it seemed fine. You running at INFO or DEBUG? > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.master.001.patch, > HBASE-19450.master.002.patch, HBASE-19450.master.003.patch, > HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[
https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975447#comment-16975447
]
Michael Stack commented on HBASE-19450:
---
Built branch-2 and ran in standalone mode Logs are filled with this sort of
stuff
{code}
2019-11-15 14:49:59,118 INFO [regionserver/localhost:16020.Chore.1]
hbase.ScheduledChore: CompactionChecker average execution time: 7532.00 ns.
2019-11-15 14:49:59,118 INFO [regionserver/localhost:16020.Chore.1]
hbase.ScheduledChore: MemstoreFlusherChore average execution time: 12188.60 ns.
2019-11-15 14:49:59,141 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3955.20 ns.
2019-11-15 14:50:00,141 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3811.60 ns.
2019-11-15 14:50:01,141 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3904.20 ns.
2019-11-15 14:50:02,140 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3878.60 ns.
2019-11-15 14:50:03,141 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3907.80 ns.
2019-11-15 14:50:04,144 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3873.00 ns.
2019-11-15 14:50:05,141 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 4064.80 ns.
2019-11-15 14:50:06,141 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3993.20 ns.
2019-11-15 14:50:07,139 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 4072.60 ns.
2019-11-15 14:50:08,144 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 4049.60 ns.
2019-11-15 14:50:09,142 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 4134.60 ns.
2019-11-15 14:50:09,363 INFO [regionserver/localhost:16020.Chore.1]
hbase.ScheduledChore: MemstoreFlusherChore average execution time: 11454.40 ns.
2019-11-15 14:50:09,363 INFO [regionserver/localhost:16020.Chore.1]
hbase.ScheduledChore: CompactionChecker average execution time: 7346.60 ns.
2019-11-15 14:50:10,143 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 4124.60 ns.
2019-11-15 14:50:11,141 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 4222.20 ns.
2019-11-15 14:50:12,144 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 4233.20 ns.
2019-11-15 14:50:13,142 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 4067.40 ns.
2019-11-15 14:50:14,143 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3896.80 ns.
2019-11-15 14:50:15,140 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3941.80 ns.
2019-11-15 14:50:16,143 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3902.60 ns.
2019-11-15 14:50:17,144 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3929.40 ns.
2019-11-15 14:50:18,143 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 3901.80 ns.
2019-11-15 14:50:19,139 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogManager Timeout Monitor average execution time: 4147.40 ns.
2019-11-15 14:50:19,602 INFO [regionserver/localhost:16020.Chore.1]
hbase.ScheduledChore: MemstoreFlusherChore average execution time: 13649.20 ns.
2019-11-15 14:50:19,602 INFO [regionserver/localhost:16020.Chore.1]
hbase.ScheduledChore: CompactionChecker average execution time: 7153.40 ns.
2019-11-15 14:50:20,144 INFO
[master/localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore:
SplitLogMan
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975448#comment-16975448 ] Michael Stack commented on HBASE-19450: --- Similar for a deploy on cluster for a tip of branch-2.2 build. > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.master.001.patch, > HBASE-19450.master.002.patch, HBASE-19450.master.003.patch, > HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975462#comment-16975462 ] Sean Busbey commented on HBASE-19450: - Huh. Those are very short chore periods. What do you think, set a minimum logging period instead of each time? Maybe at most once per 5 minutes? > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.master.001.patch, > HBASE-19450.master.002.patch, HBASE-19450.master.003.patch, > HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] apurtell commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports
apurtell commented on a change in pull request #807: HBASE-23259: Ability to
start minicluster with pre-determined master ports
URL: https://github.com/apache/hbase/pull/807#discussion_r347061636
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
##
@@ -173,6 +173,14 @@ public LocalHBaseCluster(final Configuration conf, final
int noMasters,
for (int i = 0; i < noMasters; i++) {
addMaster(new Configuration(conf), i);
}
+
+// Populate the master address host ports in the config. This is needed if
a master based
+// registry is configured for client metadata services (HBASE-18095)
+List masterHostPorts = new ArrayList<>();
+getMasters().forEach(masterThread ->
Review comment:
Java 8 idioms are just going to get in the way if you want to backport to
branch-1, where Java 7 source level compliance is required. FWIW
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] apurtell commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports
apurtell commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports URL: https://github.com/apache/hbase/pull/807#discussion_r347061440 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -171,6 +171,11 @@ /** Configuration key for master web API port */ public static final String MASTER_INFO_PORT = "hbase.master.info.port"; + /** Configuration key for the list of master host:ports **/ + public static final String MASTER_ADDRS_KEY = "hbase.master.addrs"; Review comment: Make sure parsing can handle both and : comma separated values. The other configuration setting like this is the zk quorum, which accepts a comma-separated list of : or . Let's keep things consistent. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
apurtell commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#discussion_r347062457 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java ## @@ -40,6 +40,9 @@ private CoordinatedStateManager coordinationManager; private final ZooKeeperWatcher watcher; + // max wait for split transaction - 100 times in a loop with 100 ms of thread sleep each time + private static final int SPLIT_WAIT_TIMEOUT = 100; Review comment: I'm going to put this response into the code here as a comment because I was about to request changes on this point. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell commented on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition
apurtell commented on issue #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#issuecomment-554583769 Doing some local tests... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'
saintstack commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers' URL: https://github.com/apache/hbase/pull/826#issuecomment-554585413 Second-to-last push had a bug. This last push is good. Tested on live cluster and did nice cleanup of 'Unknown Server'. Will push tomorrow unless objection. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'
Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers' URL: https://github.com/apache/hbase/pull/826#issuecomment-554591739 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 1s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 22s | branch-2 passed | | +1 :green_heart: | compile | 1m 22s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 55s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 2s | branch-2 passed | | +0 :ok: | spotbugs | 3m 24s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 37s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 51s | the patch passed | | +1 :green_heart: | compile | 1m 23s | the patch passed | | +1 :green_heart: | javac | 1m 23s | the patch passed | | -1 :x: | checkstyle | 1m 20s | hbase-server: The patch generated 2 new + 48 unchanged - 0 fixed = 50 total (was 48) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 12s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 9s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 1m 0s | the patch passed | | +1 :green_heart: | findbugs | 4m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 30s | hbase-client in the patch passed. | | -1 :x: | unit | 164m 28s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 4s | The patch does not generate ASF License warnings. | | | | 229m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/826 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 6978a7426ee5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-826/out/precommit/personality/provided.sh | | git revision | branch-2 / e69431ae8c | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/4/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/4/testReport/ | | Max. process+thread count | 4460 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell closed pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition
apurtell closed pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23261) Region stuck in transition while splitting
[
https://issues.apache.org/jira/browse/HBASE-23261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-23261:
Hadoop Flags: Reviewed
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Region stuck in transition while splitting
> --
>
> Key: HBASE-23261
> URL: https://issues.apache.org/jira/browse/HBASE-23261
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.6.0, 1.4.12, 1.3.7
>
> Attachments: HBASE-23261.branch-1.3.000.patch,
> HBASE-23261.branch-1.3.000.patch, HBASE-23261.branch-1.3.001.patch,
> HBASE-23261.branch-1.3.002.patch, HBASE-23261.branch-1.3.003.patch
>
>
> While splitting, some region gets stuck in transition. After RegionServer
> initiates split, ZK has the region marked in RIT ZNode. However, RegionServer
> encounters KeeperException.BadVersion for
> /hbase/region-in-transition/\{region-name} while transitioning node to
> RS_ZK_REQUEST_REGION_SPLIT and hence, it runs rollback/cleanup of failed
> split of the region. Even after successful rollback, region stays in
> transition sometimes.
>
> {code:java}
> 2019-11-05 04:07:17,711 INFO [splits-1572926837064] regionserver.SplitRequest
> - Successful rollback of failed split of
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
> {code}
> {code:java}
> 2019-11-05 04:07:17,688 INFO [splits-1572926837064] regionserver.SplitRequest
> - Running rollback/cleanup of failed split of
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.; Failed getting
> SPLITTING znode on TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
> java.io.IOException: Failed getting SPLITTING znode on
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:203)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.stepsBeforePONR(SplitTransactionImpl.java:383)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.createDaughters(SplitTransactionImpl.java:278)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.execute(SplitTransactionImpl.java:561)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.doSplitting(SplitRequest.java:82)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.run(SplitRequest.java:153)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException:
> Failed transition of splitting node
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:132)
> at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:161)
> ... 8 more Caused by:
> org.apache.zookeeper.KeeperException$BadVersionException: KeeperErrorCode =
> BadVersion for /hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:115) at
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51) at
> org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1336) at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.setData(RecoverableZooKeeper.java:442)
> at org.apache.hadoop.hbase.zookeeper.ZKUtil.setData(ZKUtil.java:818) at
> org.apache.hadoop.hbase.zookeeper.ZKAssign.transitionNode(ZKAssign.java:871)
> at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:128)
> ... 9 more
> {code}
> {code:java}
> 2019-11-05 04:07:17,688 INFO [.Worker-pool3-t26826] master.RegionStates -
> Transition {257ff8985e7a169af0514208b3b0b430 state=OPEN, ts=1572923178845,
> server=rsserver.net,60020,1572890688075} to {257ff8985e7a169af0514208b3b0b430
> state=SPLITTING, ts=1572926837688, server=rsserver.net,60020,1572890688075}
> {code}
> {code:java}
> 2019-11-05 04:07:17,680 INFO [myid:5] [ead(sid:5 cport:-1):]
> server.PrepRequestProcessor - Got user-level KeeperException when processing
> sessionid:0x36dd5dc94536a3e type:setData cxid:0x8f8a zxid:0x304fd98ef
> txntype:-1 reqpath:n/a Error
> Path:/hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> Error:KeeperErrorCode = BadVersion for
> /hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> {code}
> {code:java}
> 2019-11-05 04:07:17,668 DEBUG [.Worker-pool3-t26826] master.AssignmentManager
>
[GitHub] [hbase] bharathv commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports
bharathv commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports URL: https://github.com/apache/hbase/pull/807#discussion_r347070236 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -171,6 +171,11 @@ /** Configuration key for master web API port */ public static final String MASTER_INFO_PORT = "hbase.master.info.port"; + /** Configuration key for the list of master host:ports **/ + public static final String MASTER_ADDRS_KEY = "hbase.master.addrs"; Review comment: Just to confirm my understanding is correct, you mean the port number is optional right ? Something like "foo.com,bar.com:1234,baz.com:5678,temp.com" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #807: HBASE-23259: Ability to start minicluster with pre-determined master ports
bharathv commented on a change in pull request #807: HBASE-23259: Ability to
start minicluster with pre-determined master ports
URL: https://github.com/apache/hbase/pull/807#discussion_r347070047
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
##
@@ -173,6 +173,14 @@ public LocalHBaseCluster(final Configuration conf, final
int noMasters,
for (int i = 0; i < noMasters; i++) {
addMaster(new Configuration(conf), i);
}
+
+// Populate the master address host ports in the config. This is needed if
a master based
+// registry is configured for client metadata services (HBASE-18095)
+List masterHostPorts = new ArrayList<>();
+getMasters().forEach(masterThread ->
Review comment:
Thanks for the heads up.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-23290) shell processlist command is broken
[
https://issues.apache.org/jira/browse/HBASE-23290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975526#comment-16975526
]
Hudson commented on HBASE-23290:
Results for branch branch-2.2
[build #694 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> shell processlist command is broken
> ---
>
> Key: HBASE-23290
> URL: https://issues.apache.org/jira/browse/HBASE-23290
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.2.2
>Reporter: Michael Stack
>Assignee: Mingliang Liu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23290.000.patch, Screen Shot 2019-11-14 at 1.56.00
> AM.png
>
>
> {code}
> hbase(main):008:0> help 'processlist'
> Show regionserver task list.
> hbase> processlist
> hbase> processlist 'all'
> hbase> processlist 'general'
> hbase> processlist 'handler'
> hbase> processlist 'rpc'
> hbase> processlist 'operation'
> hbase> processlist 'all','host187.example.com'
> hbase> processlist 'all','host187.example.com,16020'
> hbase> processlist 'all','host187.example.com,16020,1289493121758'
> hbase(main):009:0> processlist 'all'
> 3377 tasks as of: 2019-11-13 22:58:57
> ERROR: too few arguments
> For usage try 'help "processlist"'
> Took 2.2107 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[
https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975529#comment-16975529
]
Hudson commented on HBASE-19450:
Results for branch branch-2.2
[build #694 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add log about average execution time for ScheduledChore
> ---
>
> Key: HBASE-19450
> URL: https://issues.apache.org/jira/browse/HBASE-19450
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-19450.master.001.patch,
> HBASE-19450.master.002.patch, HBASE-19450.master.003.patch,
> HBASE-19450.master.004.patch
>
>
> So far, there is no information about the exact execution time for a chore,
> we can provide log information about it. It also brings other benefits, like
> discovering inefficient chores which show rooms for improvement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23038) Provide consistent and clear logging about disabling chores
[
https://issues.apache.org/jira/browse/HBASE-23038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975527#comment-16975527
]
Hudson commented on HBASE-23038:
Results for branch branch-2.2
[build #694 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide consistent and clear logging about disabling chores
> ---
>
> Key: HBASE-23038
> URL: https://issues.apache.org/jira/browse/HBASE-23038
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
>Reporter: Sean Busbey
>Assignee: Sanjeet Nishad
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23038.001.patch, HBASE-23038.002.patch,
> HBASE-23038.master.003.patch
>
>
> Right now if you want to disable any of our chores you can set the period to
> be <= 0. Sometimes, if you do this you get a nice message:
> {code}
> 2019-09-16 22:10:16,756 INFO [master-1:16000.activeMasterManager]
> master.HMaster: The period is 0 seconds, MobCompactionChore is disabled
> {code}
> And sometimes you get an opaque message:
> {code}
> 2019-09-16 22:09:45,333 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: LogsCleaner
> 2019-09-16 22:09:45,340 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: HFileCleaner
> {code}
> This is because sometimes we just blindly submit to ChoreService which
> submits to a java ScheduledExecutorService and then catches the
> IllegalArgumentException.
> We should remove the one-offs and make it so ChoreService checks the period
> before accepting a submittal and produces a consistent "Foo is disabled"
> message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23294) ReplicationBarrierCleaner should delete all the barriers for a removed region which does not belong to any serial replication peer
[
https://issues.apache.org/jira/browse/HBASE-23294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975530#comment-16975530
]
Hudson commented on HBASE-23294:
Results for branch branch-2.2
[build #694 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ReplicationBarrierCleaner should delete all the barriers for a removed region
> which does not belong to any serial replication peer
> --
>
> Key: HBASE-23294
> URL: https://issues.apache.org/jira/browse/HBASE-23294
> Project: HBase
> Issue Type: Bug
> Components: master, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975528#comment-16975528
]
Hudson commented on HBASE-23283:
Results for branch branch-2.2
[build #694 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975531#comment-16975531 ] Sean Busbey commented on HBASE-19450: - I think I got this going. let me get an addendum up > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.master.001.patch, > HBASE-19450.master.002.patch, HBASE-19450.master.003.patch, > HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23287) LogCleaner is not added to choreService
[
https://issues.apache.org/jira/browse/HBASE-23287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975533#comment-16975533
]
Baiqiang Zhao commented on HBASE-23287:
---
Thanks [~busbey]! And I apologize for what I did.
> LogCleaner is not added to choreService
> ---
>
> Key: HBASE-23287
> URL: https://issues.apache.org/jira/browse/HBASE-23287
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.6.0, 1.4.11
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Blocker
> Fix For: 1.6.0, 1.4.12
>
> Attachments: HBASE-23287.branch-1.0001.patch
>
>
> We found /hbase/oldWALs keeps growing, and we never use replication feature.
> Then we found OldWALsCleaner thread is always in WAITTING state :
> {code:java}
> Thread 176 (OldWALsCleaner-1): State: WAITING Blocked count: 0 Waited count:
> 1 Waiting on
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@2ef05d36
> Stack: sun.misc.Unsafe.park(Native Method)
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
> org.apache.hadoop.hbase.master.cleaner.LogCleaner.deleteFile(LogCleaner.java:185)
>
> org.apache.hadoop.hbase.master.cleaner.LogCleaner.access$000(LogCleaner.java:48)
> org.apache.hadoop.hbase.master.cleaner.LogCleaner$1.run(LogCleaner.java:161)
> java.lang.Thread.run(Thread.java:745)
> {code}
> Finally, we found that LogCleaner is not added to choreService, so LogCleaner
> doesn't run periodically.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23261) Region stuck in transition while splitting
[
https://issues.apache.org/jira/browse/HBASE-23261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975535#comment-16975535
]
Hudson commented on HBASE-23261:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #672 (See
[https://builds.apache.org/job/HBase-1.3-IT/672/])
HBASE-23261 Region stuck in transition while splitting (apurtell: rev
7ac0eb9f033be4e0f9ff56cd4679a5b07b3a2594)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
> Region stuck in transition while splitting
> --
>
> Key: HBASE-23261
> URL: https://issues.apache.org/jira/browse/HBASE-23261
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 1.6.0, 1.4.12, 1.3.7
>
> Attachments: HBASE-23261.branch-1.3.000.patch,
> HBASE-23261.branch-1.3.000.patch, HBASE-23261.branch-1.3.001.patch,
> HBASE-23261.branch-1.3.002.patch, HBASE-23261.branch-1.3.003.patch
>
>
> While splitting, some region gets stuck in transition. After RegionServer
> initiates split, ZK has the region marked in RIT ZNode. However, RegionServer
> encounters KeeperException.BadVersion for
> /hbase/region-in-transition/\{region-name} while transitioning node to
> RS_ZK_REQUEST_REGION_SPLIT and hence, it runs rollback/cleanup of failed
> split of the region. Even after successful rollback, region stays in
> transition sometimes.
>
> {code:java}
> 2019-11-05 04:07:17,711 INFO [splits-1572926837064] regionserver.SplitRequest
> - Successful rollback of failed split of
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
> {code}
> {code:java}
> 2019-11-05 04:07:17,688 INFO [splits-1572926837064] regionserver.SplitRequest
> - Running rollback/cleanup of failed split of
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.; Failed getting
> SPLITTING znode on TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430.
> java.io.IOException: Failed getting SPLITTING znode on
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:203)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.stepsBeforePONR(SplitTransactionImpl.java:383)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.createDaughters(SplitTransactionImpl.java:278)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.execute(SplitTransactionImpl.java:561)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.doSplitting(SplitRequest.java:82)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.run(SplitRequest.java:153)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException:
> Failed transition of splitting node
> TABLE1,1572894157455.257ff8985e7a169af0514208b3b0b430. at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:132)
> at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.waitForSplitTransaction(ZKSplitTransactionCoordination.java:161)
> ... 8 more Caused by:
> org.apache.zookeeper.KeeperException$BadVersionException: KeeperErrorCode =
> BadVersion for /hbase/region-in-transition/257ff8985e7a169af0514208b3b0b430
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:115) at
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51) at
> org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1336) at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.setData(RecoverableZooKeeper.java:442)
> at org.apache.hadoop.hbase.zookeeper.ZKUtil.setData(ZKUtil.java:818) at
> org.apache.hadoop.hbase.zookeeper.ZKAssign.transitionNode(ZKAssign.java:871)
> at
> org.apache.hadoop.hbase.coordination.ZKSplitTransactionCoordination.transitionSplittingNode(ZKSplitTransactionCoordination.java:128)
> ... 9 more
> {code}
> {code:java}
> 2019-11-05 04:07:17,688 INFO [.Worker-pool3-t26826] master.RegionStates -
> Transition {257ff8985e7a169af0514208b3b0b430 state=OPEN, ts=1572923178845,
> server=rsserver.net,60020,1572890688075} to {257ff8985e7a169af0514208b3b0b430
> state=SPLITTING, ts=1572926837688, server=rsserver.net,60020,1572890688075}
> {code}
> {code:java}
> 2019-11-05 04:07:17,680 INFO [myid:5] [ead(sid:5 cport:-1):]
> server.PrepRequestProcessor - Got user-level KeeperException when processing
> sessionid:0x36dd5dc94536a3e typ
[jira] [Updated] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-19450: Attachment: HBASE-19450.addendum1.0.patch > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.addendum1.0.patch, > HBASE-19450.master.001.patch, HBASE-19450.master.002.patch, > HBASE-19450.master.003.patch, HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-19450: Status: Patch Available (was: Reopened) addendum v0 - Ensure we don't output the execution time at INFO more often then once per 5 minutes - when not logging at INFO, log at TRACE Tested by running a stand alone instance and going through logs out of the box, and then runtime changing the log level via the web ui on ScheduledChore to TRACE, to WARN, and back to INFO. > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.addendum1.0.patch, > HBASE-19450.master.001.patch, HBASE-19450.master.002.patch, > HBASE-19450.master.003.patch, HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[
https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975552#comment-16975552
]
Hudson commented on HBASE-19450:
Results for branch branch-2
[build #2355 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add log about average execution time for ScheduledChore
> ---
>
> Key: HBASE-19450
> URL: https://issues.apache.org/jira/browse/HBASE-19450
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-19450.addendum1.0.patch,
> HBASE-19450.master.001.patch, HBASE-19450.master.002.patch,
> HBASE-19450.master.003.patch, HBASE-19450.master.004.patch
>
>
> So far, there is no information about the exact execution time for a chore,
> we can provide log information about it. It also brings other benefits, like
> discovering inefficient chores which show rooms for improvement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975551#comment-16975551
]
Hudson commented on HBASE-23283:
Results for branch branch-2
[build #2355 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23294) ReplicationBarrierCleaner should delete all the barriers for a removed region which does not belong to any serial replication peer
[
https://issues.apache.org/jira/browse/HBASE-23294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975553#comment-16975553
]
Hudson commented on HBASE-23294:
Results for branch branch-2
[build #2355 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ReplicationBarrierCleaner should delete all the barriers for a removed region
> which does not belong to any serial replication peer
> --
>
> Key: HBASE-23294
> URL: https://issues.apache.org/jira/browse/HBASE-23294
> Project: HBase
> Issue Type: Bug
> Components: master, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23290) shell processlist command is broken
[
https://issues.apache.org/jira/browse/HBASE-23290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975550#comment-16975550
]
Hudson commented on HBASE-23290:
Results for branch branch-2
[build #2355 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> shell processlist command is broken
> ---
>
> Key: HBASE-23290
> URL: https://issues.apache.org/jira/browse/HBASE-23290
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.2.2
>Reporter: Michael Stack
>Assignee: Mingliang Liu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23290.000.patch, Screen Shot 2019-11-14 at 1.56.00
> AM.png
>
>
> {code}
> hbase(main):008:0> help 'processlist'
> Show regionserver task list.
> hbase> processlist
> hbase> processlist 'all'
> hbase> processlist 'general'
> hbase> processlist 'handler'
> hbase> processlist 'rpc'
> hbase> processlist 'operation'
> hbase> processlist 'all','host187.example.com'
> hbase> processlist 'all','host187.example.com,16020'
> hbase> processlist 'all','host187.example.com,16020,1289493121758'
> hbase(main):009:0> processlist 'all'
> 3377 tasks as of: 2019-11-13 22:58:57
> ERROR: too few arguments
> For usage try 'help "processlist"'
> Took 2.2107 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[
https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1697#comment-1697
]
HBase QA commented on HBASE-19450:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
6s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
47s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
58s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 18s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
54s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 25s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/1023/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-19450 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12986000/HBASE-19450.addendum1.0.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f04b339a2a1a 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1
05:24:09 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e60764f5a1 |
| Default Java | 1.8.0_181 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build
[jira] [Commented] (HBASE-23038) Provide consistent and clear logging about disabling chores
[
https://issues.apache.org/jira/browse/HBASE-23038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975560#comment-16975560
]
Hudson commented on HBASE-23038:
Results for branch branch-2.1
[build #1711 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide consistent and clear logging about disabling chores
> ---
>
> Key: HBASE-23038
> URL: https://issues.apache.org/jira/browse/HBASE-23038
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
>Reporter: Sean Busbey
>Assignee: Sanjeet Nishad
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23038.001.patch, HBASE-23038.002.patch,
> HBASE-23038.master.003.patch
>
>
> Right now if you want to disable any of our chores you can set the period to
> be <= 0. Sometimes, if you do this you get a nice message:
> {code}
> 2019-09-16 22:10:16,756 INFO [master-1:16000.activeMasterManager]
> master.HMaster: The period is 0 seconds, MobCompactionChore is disabled
> {code}
> And sometimes you get an opaque message:
> {code}
> 2019-09-16 22:09:45,333 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: LogsCleaner
> 2019-09-16 22:09:45,340 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: HFileCleaner
> {code}
> This is because sometimes we just blindly submit to ChoreService which
> submits to a java ScheduledExecutorService and then catches the
> IllegalArgumentException.
> We should remove the one-offs and make it so ChoreService checks the period
> before accepting a submittal and produces a consistent "Foo is disabled"
> message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[
https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975562#comment-16975562
]
Hudson commented on HBASE-19450:
Results for branch branch-2.1
[build #1711 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add log about average execution time for ScheduledChore
> ---
>
> Key: HBASE-19450
> URL: https://issues.apache.org/jira/browse/HBASE-19450
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-19450.addendum1.0.patch,
> HBASE-19450.master.001.patch, HBASE-19450.master.002.patch,
> HBASE-19450.master.003.patch, HBASE-19450.master.004.patch
>
>
> So far, there is no information about the exact execution time for a chore,
> we can provide log information about it. It also brings other benefits, like
> discovering inefficient chores which show rooms for improvement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23294) ReplicationBarrierCleaner should delete all the barriers for a removed region which does not belong to any serial replication peer
[
https://issues.apache.org/jira/browse/HBASE-23294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975563#comment-16975563
]
Hudson commented on HBASE-23294:
Results for branch branch-2.1
[build #1711 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ReplicationBarrierCleaner should delete all the barriers for a removed region
> which does not belong to any serial replication peer
> --
>
> Key: HBASE-23294
> URL: https://issues.apache.org/jira/browse/HBASE-23294
> Project: HBase
> Issue Type: Bug
> Components: master, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23290) shell processlist command is broken
[
https://issues.apache.org/jira/browse/HBASE-23290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975559#comment-16975559
]
Hudson commented on HBASE-23290:
Results for branch branch-2.1
[build #1711 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> shell processlist command is broken
> ---
>
> Key: HBASE-23290
> URL: https://issues.apache.org/jira/browse/HBASE-23290
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.2.2
>Reporter: Michael Stack
>Assignee: Mingliang Liu
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23290.000.patch, Screen Shot 2019-11-14 at 1.56.00
> AM.png
>
>
> {code}
> hbase(main):008:0> help 'processlist'
> Show regionserver task list.
> hbase> processlist
> hbase> processlist 'all'
> hbase> processlist 'general'
> hbase> processlist 'handler'
> hbase> processlist 'rpc'
> hbase> processlist 'operation'
> hbase> processlist 'all','host187.example.com'
> hbase> processlist 'all','host187.example.com,16020'
> hbase> processlist 'all','host187.example.com,16020,1289493121758'
> hbase(main):009:0> processlist 'all'
> 3377 tasks as of: 2019-11-13 22:58:57
> ERROR: too few arguments
> For usage try 'help "processlist"'
> Took 2.2107 seconds
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975561#comment-16975561
]
Hudson commented on HBASE-23283:
Results for branch branch-2.1
[build #1711 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975565#comment-16975565 ] Sean Busbey commented on HBASE-19450: - I think the addendum works well enough. precommit gives it a pass. anyone got a +1 for it? > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.addendum1.0.patch, > HBASE-19450.master.001.patch, HBASE-19450.master.002.patch, > HBASE-19450.master.003.patch, HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23302) Put up 2.1.8RC0
[ https://issues.apache.org/jira/browse/HBASE-23302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975575#comment-16975575 ] Sean Busbey commented on HBASE-23302: - you should wait for the addendum on HBASE-19450 to land before making the RC. it's waiting for a review > Put up 2.1.8RC0 > --- > > Key: HBASE-23302 > URL: https://issues.apache.org/jira/browse/HBASE-23302 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers'
Apache-HBase commented on issue #826: HBASE-23282 HBCKServerCrashProcedure for 'Unknown Servers' URL: https://github.com/apache/hbase/pull/826#issuecomment-554606932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 15s | branch-2 passed | | +1 :green_heart: | compile | 1m 22s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 56s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | branch-2 passed | | +0 :ok: | spotbugs | 3m 31s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 39s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 42s | the patch passed | | +1 :green_heart: | compile | 1m 22s | the patch passed | | +1 :green_heart: | javac | 1m 23s | the patch passed | | -1 :x: | checkstyle | 1m 17s | hbase-server: The patch generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 3s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 1m 0s | the patch passed | | -1 :x: | findbugs | 3m 32s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 31s | hbase-client in the patch passed. | | -1 :x: | unit | 164m 43s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 4s | The patch does not generate ASF License warnings. | | | | 228m 28s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Possible null pointer dereference of ps in org.apache.hadoop.hbase.master.procedure.HBCKServerCrashProcedure.getRegionsOnCrashedServer(MasterProcedureEnv) on exception path Dereferenced at HBCKServerCrashProcedure.java:ps in org.apache.hadoop.hbase.master.procedure.HBCKServerCrashProcedure.getRegionsOnCrashedServer(MasterProcedureEnv) on exception path Dereferenced at HBCKServerCrashProcedure.java:[line 81] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/826 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 315797532cc4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-826/out/precommit/personality/provided.sh | | git revision | branch-2 / e69431ae8c | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/5/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/5/artifact/out/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/5/testReport/ | | Max. process+thread count | 4784 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-826/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated.
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975586#comment-16975586 ] Duo Zhang commented on HBASE-19450: --- Please file a new issue for this? This one has been resolved for two years! > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.addendum1.0.patch, > HBASE-19450.master.001.patch, HBASE-19450.master.002.patch, > HBASE-19450.master.003.patch, HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23302) Put up 2.1.8RC0
[ https://issues.apache.org/jira/browse/HBASE-23302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975587#comment-16975587 ] Duo Zhang commented on HBASE-23302: --- Let's use a new issue please [~busbey]. > Put up 2.1.8RC0 > --- > > Key: HBASE-23302 > URL: https://issues.apache.org/jira/browse/HBASE-23302 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975589#comment-16975589 ] Duo Zhang commented on HBASE-19450: --- On the patch, we wrap LOG.trace with LOG.isInfoEnabled? Seems not good... > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.addendum1.0.patch, > HBASE-19450.master.001.patch, HBASE-19450.master.002.patch, > HBASE-19450.master.003.patch, HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975590#comment-16975590 ] Sean Busbey commented on HBASE-19450: - It has not been resolved for two years. It got resolved earlier today. We should not release with the original commit without the addendum. As stack mentioned we log at least once a second > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.addendum1.0.patch, > HBASE-19450.master.001.patch, HBASE-19450.master.002.patch, > HBASE-19450.master.003.patch, HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23300) Set version as 2.1.8 in branch-2.1 in prep for first RC of 2.1.8
[ https://issues.apache.org/jira/browse/HBASE-23300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23300: -- Fix Version/s: 2.1.8 > Set version as 2.1.8 in branch-2.1 in prep for first RC of 2.1.8 > > > Key: HBASE-23300 > URL: https://issues.apache.org/jira/browse/HBASE-23300 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.8 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o…
Apache9 merged pull request #833: HBASE-23300 Set version as 2.1.8 in branch-2.1 in prep for first RC o… URL: https://github.com/apache/hbase/pull/833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-19450) Add log about average execution time for ScheduledChore
[ https://issues.apache.org/jira/browse/HBASE-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975591#comment-16975591 ] Sean Busbey commented on HBASE-19450: - > On the patch, we wrap LOG.trace with LOG.isInfoEnabled? Seems not good. Please read the full context. We have to do some work to decide to log at info or at trace. If we aren't at least at info level we skip doing all the work. > Add log about average execution time for ScheduledChore > --- > > Key: HBASE-19450 > URL: https://issues.apache.org/jira/browse/HBASE-19450 > Project: HBase > Issue Type: Improvement > Components: Operability >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.8, 2.2.3 > > Attachments: HBASE-19450.addendum1.0.patch, > HBASE-19450.master.001.patch, HBASE-19450.master.002.patch, > HBASE-19450.master.003.patch, HBASE-19450.master.004.patch > > > So far, there is no information about the exact execution time for a chore, > we can provide log information about it. It also brings other benefits, like > discovering inefficient chores which show rooms for improvement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
