[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2020-02-01 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028295#comment-17028295
 ] 

Hudson commented on HBASE-22514:


Results for branch HBASE-22514
[build #260 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/260/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/260//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/260//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/260//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
>  Issue Type: Umbrella
>  Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch, 
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public 
> we need to use java api  RSGroupAdminClient  to manager RSG 
> so  RSGroupAdminClient should be public
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-21110) Issues with Unsafe and JDK 11

2020-02-01 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-21110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028282#comment-17028282
 ] 

Duo Zhang commented on HBASE-21110:
---

For suppress warnings I think we could use the patch in HBASE-22172, and for 
Bits.unaligned, let's use this issue to port the spark fix.

FYI. [~zghao]

> Issues with Unsafe and JDK 11
> -
>
> Key: HBASE-21110
> URL: https://issues.apache.org/jira/browse/HBASE-21110
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Mike Drob
>Priority: Major
>  Labels: jdk11
> Fix For: 3.0.0
>
>
> Using Java 11 RC 1, I get the following warning, probably need to add the 
> suggested flag to our scripts?
> {noformat}
> mdrob@mdrob-MBP:~/IdeaProjects/hbase$ java -version
> java version "11" 2018-09-25
> Java(TM) SE Runtime Environment 18.9 (build 11+28)
> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11+28, mixed mode)
> mdrob@mdrob-MBP:~/IdeaProjects/hbase$ bin/start-hbase.sh
> mdrob@mdrob-MBP:~/IdeaProjects/hbase$ cat 
> /Users/mdrob/IdeaProjects/hbase/bin/../logs/hbase-mdrob-master-mdrob-MBP.local.out
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by 
> org.apache.hadoop.hbase.util.UnsafeAvailChecker 
> (file:/Users/mdrob/IdeaProjects/hbase/hbase-common/target/hbase-common-3.0.0-SNAPSHOT.jar)
>  to method java.nio.Bits.unaligned()
> WARNING: Please consider reporting this to the maintainers of 
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-22172) Suppress Java 11 reflective access warnings

2020-02-01 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028281#comment-17028281
 ] 

Duo Zhang commented on HBASE-22172:
---

[~ndimiduk] Ideally we should change to use new APIs but actually we can not, 
as we have lots of dependency which rely on the old internal APIs, for example, 
netty. So I think we'd better add these flags for now, and start to replace the 
old APIs with new APIs.

But I do not think it is easy. Java11 and Java8 are two different worlds. Maybe 
we have to change the whole architecture of HBase if we want to fully support 
Java11's modular system, which may take another decade...

> Suppress Java 11 reflective access warnings
> ---
>
> Key: HBASE-22172
> URL: https://issues.apache.org/jira/browse/HBASE-22172
> Project: HBase
>  Issue Type: Sub-task
>  Components: java, scripts
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
>  Labels: jdk11
> Attachments: hbase-22172.master.001.patch
>
>
> While running a Java 8 compiled hbase on Java 11 system, I found the 
> following warnings being thrown. I think we can add the "--add-opens" flag to 
> HBASE_OPTS (if the jdk version is 11) to suppress this warning.
> {code:java}
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by 
> org.apache.hadoop.hbase.util.UnsafeAvailChecker 
> (file:/Users/jatsakthi/test/HBASE_TEST_AREA/hbase-3.0.0-SNAPSHOT/lib/hbase-common-3.0.0-SNAPSHOT.jar)
>  to method java.nio.Bits.unaligned()
> WARNING: Please consider reporting this to the maintainers of 
> org.apache.hadoop.hbase.util.UnsafeAvailChecker
> WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-22972) [JDK11] Support JDK11 LTS in HBase

2020-02-01 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028280#comment-17028280
 ] 

Duo Zhang commented on HBASE-22972:
---

https://github.com/netty/netty/issues/7838

See this...

We need lots of flags to make netty work without performance downgrading...

> [JDK11] Support JDK11 LTS in HBase
> --
>
> Key: HBASE-22972
> URL: https://issues.apache.org/jira/browse/HBASE-22972
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Blocker
>  Labels: jdk11
> Fix For: 3.0.0, 2.3.0
>
>
> This is an umbrella issue for tracking all the problems for JDK11 in HBase. 
> And we also rely on hadoop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on issue #1101: HBASE-23305: Master based registry implementation (#954)

2020-02-01 Thread GitBox
Apache-HBase commented on issue #1101: HBASE-23305: Master based registry 
implementation (#954)
URL: https://github.com/apache/hbase/pull/1101#issuecomment-581101060
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 17s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
32 new or modified test files.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 52s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 47s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   2m 18s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 40s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 19s |  branch-2 passed  |
   | +0 :ok: |  spotbugs  |   3m 45s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 46s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 23s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 48s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 48s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 23s |  hbase-common: The patch 
generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13)  |
   | +1 :green_heart: |  checkstyle  |   0m 34s |  hbase-client: The patch 
generated 0 new + 64 unchanged - 23 fixed = 64 total (was 87)  |
   | +1 :green_heart: |  checkstyle  |   1m 21s |  hbase-server: The patch 
generated 0 new + 266 unchanged - 49 fixed = 266 total (was 315)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedjars  |   4m 40s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  17m 14s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   1m 18s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m 57s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 57s |  hbase-common in the patch passed.  
|
   | +1 :green_heart: |  unit  |   3m 35s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  | 164m 56s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   1m 14s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 242m 27s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestScannersFromClientSide |
   |   | hadoop.hbase.client.TestFromClientSide |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.5 Server=19.03.5 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1101/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1101 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 44cf905f56c1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1101/out/precommit/personality/provided.sh
 |
   | git revision | branch-2 / 4de06915b8 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1101/2/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1101/2/testReport/
 |
   | Max. process+thread count | 4999 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1101/2/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra

[jira] [Commented] (HBASE-20623) Introduce the helper method "getCellBuilder()" to Mutation

2020-02-01 Thread HBase QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-20623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028275#comment-17028275
 ] 

HBase QA commented on HBASE-20623:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  9s{color} 
| {color:red} HBASE-20623 does not apply to master. Rebase required? Wrong 
Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20623 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12945234/HBASE-20623.master.009.patch
 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/1118/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |


This message was automatically generated.



> Introduce the helper method "getCellBuilder()" to Mutation
> --
>
> Key: HBASE-20623
> URL: https://issues.apache.org/jira/browse/HBASE-20623
> Project: HBase
>  Issue Type: Task
>  Components: API
>Reporter: Chia-Ping Tsai
>Assignee: maoling
>Priority: Minor
> Attachments: HBASE-20623.master.001.patch, 
> HBASE-20623.master.002.patch, HBASE-20623.master.003.patch, 
> HBASE-20623.master.004.patch, HBASE-20623.master.005.patch, 
> HBASE-20623.master.006.patch, HBASE-20623.master.007.patch, 
> HBASE-20623.master.008.patch, HBASE-20623.master.009.patch
>
>
> see 
> [https://lists.apache.org/thread.html/d05bfaa0134502a47f6e1aca56cb0b096d4dd32ddefbbdf28db4952a@%3Cdev.hbase.apache.org%3E]
>  for more details.
> {code:java}
> How about a "getCellBuilder" or "getCellBuilderFactory" method for
> Mutation implementations that gives you a CellBuilder instance that
> already has relevant parts set? Like for a Put instance it should be
> able to already have the Type and Row set.{code}
> mentioned a day or so ago by [~busbey]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-20623) Introduce the helper method "getCellBuilder()" to Mutation

2020-02-01 Thread maoling (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-20623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028273#comment-17028273
 ] 

maoling commented on HBASE-20623:
-

[~stack] 

Thank for your ping and sorry for my late. I will refresh this patch and push a 
github PR asap at this weekend

> Introduce the helper method "getCellBuilder()" to Mutation
> --
>
> Key: HBASE-20623
> URL: https://issues.apache.org/jira/browse/HBASE-20623
> Project: HBase
>  Issue Type: Task
>  Components: API
>Reporter: Chia-Ping Tsai
>Assignee: maoling
>Priority: Minor
> Attachments: HBASE-20623.master.001.patch, 
> HBASE-20623.master.002.patch, HBASE-20623.master.003.patch, 
> HBASE-20623.master.004.patch, HBASE-20623.master.005.patch, 
> HBASE-20623.master.006.patch, HBASE-20623.master.007.patch, 
> HBASE-20623.master.008.patch, HBASE-20623.master.009.patch
>
>
> see 
> [https://lists.apache.org/thread.html/d05bfaa0134502a47f6e1aca56cb0b096d4dd32ddefbbdf28db4952a@%3Cdev.hbase.apache.org%3E]
>  for more details.
> {code:java}
> How about a "getCellBuilder" or "getCellBuilderFactory" method for
> Mutation implementations that gives you a CellBuilder instance that
> already has relevant parts set? Like for a Put instance it should be
> able to already have the Type and Row set.{code}
> mentioned a day or so ago by [~busbey]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23774) Announce user-zh list

2020-02-01 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028271#comment-17028271
 ] 

Hudson commented on HBASE-23774:


Results for branch branch-2.1
[build #1791 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1791/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1791//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1791//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1791//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Announce user-zh list
> -
>
> Key: HBASE-23774
> URL: https://issues.apache.org/jira/browse/HBASE-23774
> Project: HBase
>  Issue Type: Task
>  Components: website
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-23774.001.patch
>
>
> Let folks know about the new user-zh list that is dedicated for user 
> questions in chinese (as opposed to the norm of english on user)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HBASE-22972) [JDK11] Support JDK11 LTS in HBase

2020-02-01 Thread Guanghao Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028262#comment-17028262
 ] 

Guanghao Zhang edited comment on HBASE-22972 at 2/2/20 3:29 AM:


The "ungligned" is a method in jdk8 but it is a filed since jdk9. And it seems 
have different name for jdk9/10 and jdk11/12.


was (Author: zghaobac):
The ungligned is a method in jdk8 but it is a filed since jdk9. And it seems 
have different name for jdk9/10 and jdk11/12.

> [JDK11] Support JDK11 LTS in HBase
> --
>
> Key: HBASE-22972
> URL: https://issues.apache.org/jira/browse/HBASE-22972
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Blocker
>  Labels: jdk11
> Fix For: 3.0.0, 2.3.0
>
>
> This is an umbrella issue for tracking all the problems for JDK11 in HBase. 
> And we also rely on hadoop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-22972) [JDK11] Support JDK11 LTS in HBase

2020-02-01 Thread Guanghao Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028262#comment-17028262
 ] 

Guanghao Zhang commented on HBASE-22972:


The ungligned is a method in jdk8 but it is a filed since jdk9. And it seems 
have different name for jdk9/10 and jdk11/12.

> [JDK11] Support JDK11 LTS in HBase
> --
>
> Key: HBASE-22972
> URL: https://issues.apache.org/jira/browse/HBASE-22972
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Blocker
>  Labels: jdk11
> Fix For: 3.0.0, 2.3.0
>
>
> This is an umbrella issue for tracking all the problems for JDK11 in HBase. 
> And we also rely on hadoop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-22972) [JDK11] Support JDK11 LTS in HBase

2020-02-01 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028258#comment-17028258
 ] 

Duo Zhang commented on HBASE-22972:
---

I think we need to add some flags in the start scripts, to export some internal 
classes, Netty also has the same problem...

> [JDK11] Support JDK11 LTS in HBase
> --
>
> Key: HBASE-22972
> URL: https://issues.apache.org/jira/browse/HBASE-22972
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Blocker
>  Labels: jdk11
> Fix For: 3.0.0, 2.3.0
>
>
> This is an umbrella issue for tracking all the problems for JDK11 in HBase. 
> And we also rely on hadoop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-22972) [JDK11] Support JDK11 LTS in HBase

2020-02-01 Thread Guanghao Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028255#comment-17028255
 ] 

Guanghao Zhang commented on HBASE-22972:


The waring message is "WARNING: Illegal reflective access by 
org.apache.hadoop.hbase.util.UnsafeAvailChecker 
(file:/home/zhangguanghao1/code/hbase/hbase-common/target/hbase-common-2.3.0-SNAPSHOT.jar)
 to method java.nio.Bits.unaligned()". And spark had smae problem and resolved 
by https://issues.apache.org/jira/browse/SPARK-27981

> [JDK11] Support JDK11 LTS in HBase
> --
>
> Key: HBASE-22972
> URL: https://issues.apache.org/jira/browse/HBASE-22972
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Blocker
>  Labels: jdk11
> Fix For: 3.0.0, 2.3.0
>
>
> This is an umbrella issue for tracking all the problems for JDK11 in HBase. 
> And we also rely on hadoop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (HBASE-22972) [JDK11] Support JDK11 LTS in HBase

2020-02-01 Thread Guanghao Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028254#comment-17028254
 ] 

Guanghao Zhang edited comment on HBASE-22972 at 2/2/20 3:02 AM:


The runtime means what? I build a package of branch-2 and run with jdk11. There 
are some warnings but it worked now. I used PE to write/read 1M rows and it 
worked. The hadoop version is 2.8.5.


was (Author: zghaobac):
The runtime means what? I build a package of branch-2 and run with jdk11. There 
are some warnings but it worked now. I used PE to write/read 1M rows and it 
worked.

> [JDK11] Support JDK11 LTS in HBase
> --
>
> Key: HBASE-22972
> URL: https://issues.apache.org/jira/browse/HBASE-22972
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Blocker
>  Labels: jdk11
> Fix For: 3.0.0, 2.3.0
>
>
> This is an umbrella issue for tracking all the problems for JDK11 in HBase. 
> And we also rely on hadoop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-22972) [JDK11] Support JDK11 LTS in HBase

2020-02-01 Thread Guanghao Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028254#comment-17028254
 ] 

Guanghao Zhang commented on HBASE-22972:


The runtime means what? I build a package of branch-2 and run with jdk11. There 
are some warnings but it worked now. I used PE to write/read 1M rows and it 
worked.

> [JDK11] Support JDK11 LTS in HBase
> --
>
> Key: HBASE-22972
> URL: https://issues.apache.org/jira/browse/HBASE-22972
> Project: HBase
>  Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Blocker
>  Labels: jdk11
> Fix For: 3.0.0, 2.3.0
>
>
> This is an umbrella issue for tracking all the problems for JDK11 in HBase. 
> And we also rely on hadoop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23633) Find a way to handle the corrupt recovered hfiles

2020-02-01 Thread Guanghao Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028252#comment-17028252
 ] 

Guanghao Zhang commented on HBASE-23633:


[~pankajkumar] Are you working for this now?

> Find a way to handle the corrupt recovered hfiles
> -
>
> Key: HBASE-23633
> URL: https://issues.apache.org/jira/browse/HBASE-23633
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Priority: Major
>
> Copy the comment from PR review.
>  
> If the file is a corrupt HFile, an exception will be thrown here, which will 
> cause the region to fail to open.
> Maybe we can add a new parameter to control whether to skip the exception, 
> similar to recover edits which has a parameter 
> "hbase.hregion.edits.replay.skip.errors";
>  
> Regions that can't be opened because of detached References or corrupt hfiles 
> are a fact-of-life. We need work on this issue. This will be a new variant on 
> the problem -- i.e. bad recovered hfiles.
> On adding a config to ignore bad files and just open, thats a bit dangerous 
> as per @infraio  as it could mean silent data loss.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] Apache-HBase commented on issue #1109: HBASE-23780 Edit of test classifications

2020-02-01 Thread GitBox
Apache-HBase commented on issue #1109: HBASE-23780 Edit of test classifications
URL: https://github.com/apache/hbase/pull/1109#issuecomment-581090445
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 59s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  4s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
183 new or modified test files.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 17s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   3m 17s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   3m 35s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 17s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m 33s |  branch-2 passed  |
   | +0 :ok: |  spotbugs  |   0m 34s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   7m 44s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 19s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 19s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 24s |  The patch passed checkstyle 
in hbase-common  |
   | +1 :green_heart: |  checkstyle  |   0m 33s |  The patch passed checkstyle 
in hbase-client  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  The patch passed checkstyle 
in hbase-zookeeper  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  The patch passed checkstyle 
in hbase-http  |
   | +1 :green_heart: |  checkstyle  |   0m 16s |  The patch passed checkstyle 
in hbase-procedure  |
   | +1 :green_heart: |  checkstyle  |   1m 27s |  hbase-server: The patch 
generated 0 new + 658 unchanged - 170 fixed = 658 total (was 828)  |
   | +1 :green_heart: |  checkstyle  |   0m 21s |  The patch passed checkstyle 
in hbase-mapreduce  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedjars  |   4m 17s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  15m 26s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   2m 30s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   9m  3s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 54s |  hbase-common in the patch passed.  
|
   | +1 :green_heart: |  unit  |   3m 55s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  |   0m 52s |  hbase-zookeeper in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   1m 15s |  hbase-http in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 10s |  hbase-procedure in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 148m 38s |  hbase-server in the patch passed.  
|
   | -1 :x: |  unit  |  17m 41s |  hbase-mapreduce in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   4m 32s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 263m 31s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotNoCluster |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.5 Server=19.03.5 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1109/6/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1109 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux dec8824dd984 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1109/out/precommit/personality/provided.sh
 |
   | git revision | branch-2 / 7b4b90aef5 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1109/6/artifact/out/patch-unit-hbase-mapreduce.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1109/6/testReport/
 |
   | Max. process+thread count | 5579 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-client hbase-zookeeper hbase-http 
hba

[jira] [Commented] (HBASE-18095) Provide an option for clients to find the server hosting META that does not involve the ZooKeeper client

2020-02-01 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-18095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028250#comment-17028250
 ] 

Hudson commented on HBASE-18095:


Results for branch HBASE-18095/client-locate-meta-no-zookeeper
[build #58 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/58/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/58//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/58//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/58//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for 
details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/58//artifact/output-integration/hadoop-2.log].
 (note that this means we didn't run on Hadoop 3)


> Provide an option for clients to find the server hosting META that does not 
> involve the ZooKeeper client
> 
>
> Key: HBASE-18095
> URL: https://issues.apache.org/jira/browse/HBASE-18095
> Project: HBase
>  Issue Type: New Feature
>  Components: Client
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
> Attachments: HBASE-18095.master-v1.patch, HBASE-18095.master-v2.patch
>
>
> Clients are required to connect to ZooKeeper to find the location of the 
> regionserver hosting the meta table region. Site configuration provides the 
> client a list of ZK quorum peers and the client uses an embedded ZK client to 
> query meta location. Timeouts and retry behavior of this embedded ZK client 
> are managed orthogonally to HBase layer settings and in some cases the ZK 
> cannot manage what in theory the HBase client can, i.e. fail fast upon outage 
> or network partition.
> We should consider new configuration settings that provide a list of 
> well-known master and backup master locations, and with this information the 
> client can contact any of the master processes directly. Any master in either 
> active or passive state will track meta location and respond to requests for 
> it with its cached last known location. If this location is stale, the client 
> can ask again with a flag set that requests the master refresh its location 
> cache and return the up-to-date location. Every client interaction with the 
> cluster thus uses only HBase RPC as transport, with appropriate settings 
> applied to the connection. The configuration toggle that enables this 
> alternative meta location lookup should be false by default.
> This removes the requirement that HBase clients embed the ZK client and 
> contact the ZK service directly at the beginning of the connection lifecycle. 
> This has several benefits. ZK service need not be exposed to clients, and 
> their potential abuse, yet no benefit ZK provides the HBase server cluster is 
> compromised. Normalizing HBase client and ZK client timeout settings and 
> retry behavior - in some cases, impossible, i.e. for fail-fast - is no longer 
> necessary. 
> And, from [~ghelmling]: There is an additional complication here for 
> token-based authentication. When a delegation token is used for SASL 
> authentication, the client uses the cluster ID obtained from Zookeeper to 
> select the token identifier to use. So there would also need to be some 
> Zookeeper-less, unauthenticated way to obtain the cluster ID as well. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] bharathv closed pull request #1100: HBASE-23648: Re-use underlying connection registry in RawAsyncHBaseAd… …min (#994)

2020-02-01 Thread GitBox
bharathv closed pull request #1100: HBASE-23648: Re-use underlying connection 
registry in RawAsyncHBaseAd…  …min (#994)
URL: https://github.com/apache/hbase/pull/1100
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] bharathv commented on issue #1100: HBASE-23648: Re-use underlying connection registry in RawAsyncHBaseAd… …min (#994)

2020-02-01 Thread GitBox
bharathv commented on issue #1100: HBASE-23648: Re-use underlying connection 
registry in RawAsyncHBaseAd…  …min (#994)
URL: https://github.com/apache/hbase/pull/1100#issuecomment-581086419
 
 
   Will be included in #1101
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] bharathv closed pull request #1099: HBASE-23604: Clarify AsyncRegistry usage in the code. (#957)

2020-02-01 Thread GitBox
bharathv closed pull request #1099: HBASE-23604: Clarify AsyncRegistry usage in 
the code. (#957)
URL: https://github.com/apache/hbase/pull/1099
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] bharathv commented on issue #1099: HBASE-23604: Clarify AsyncRegistry usage in the code. (#957)

2020-02-01 Thread GitBox
bharathv commented on issue #1099: HBASE-23604: Clarify AsyncRegistry usage in 
the code. (#957)
URL: https://github.com/apache/hbase/pull/1099#issuecomment-581086410
 
 
   Will be included in #1101 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] bharathv closed pull request #1106: HBASE-23764: Switch to IP address for ZK ensemble

2020-02-01 Thread GitBox
bharathv closed pull request #1106: HBASE-23764: Switch to IP address for ZK 
ensemble
URL: https://github.com/apache/hbase/pull/1106
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-23764) Flaky tests due to ZK client name resolution delays

2020-02-01 Thread HBase QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028242#comment-17028242
 ] 

HBase QA commented on HBASE-23764:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 4 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
49s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m  
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue}  4m 
55s{color} | {color:blue} branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. {color} 
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
42s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  4m  
2s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  3m 
50s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 19m  
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
23s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue}  4m 
41s{color} | {color:blue} patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. {color} 
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
39s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
15m 49s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  4m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 19m 
25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}172m 51s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  2m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}286m  7s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tes

[GitHub] [hbase] Apache-HBase commented on issue #1106: HBASE-23764: Switch to IP address for ZK ensemble

2020-02-01 Thread GitBox
Apache-HBase commented on issue #1106: HBASE-23764: Switch to IP address for ZK 
ensemble
URL: https://github.com/apache/hbase/pull/1106#issuecomment-581085073
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 31s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
4 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 49s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 15s |  master passed  |
   | +1 :green_heart: |  compile  |   3m  1s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   2m 11s |  master passed  |
   | +0 :ok: |  refguide  |   4m 55s |  branch has no errors when building the 
reference guide. See footer for rendered docs, which you should manually 
inspect.  |
   | +1 :green_heart: |  shadedjars  |   4m 42s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   4m  2s |  master passed  |
   | +0 :ok: |  spotbugs  |   3m 50s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |  19m  6s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 59s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  4s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m  4s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   2m  8s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  3s |  The patch has no ill-formed XML 
file.  |
   | +0 :ok: |  refguide  |   4m 41s |  patch has no errors when building the 
reference guide. See footer for rendered docs, which you should manually 
inspect.  |
   | +1 :green_heart: |  shadedjars  |   4m 39s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  15m 49s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   4m  6s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |  19m 25s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 172m 51s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   2m 22s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 286m  7s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.snapshot.TestFlushSnapshotFromClient |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.5 Server=19.03.5 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1106/7/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1106 |
   | JIRA Issue | HBASE-23764 |
   | Optional Tests | dupname asflicense javac javadoc unit refguide xml 
spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 4691c23c6472 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1106/out/precommit/personality/provided.sh
 |
   | git revision | master / 70699365ad |
   | Default Java | 1.8.0_181 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1106/7/artifact/out/branch-site/book.html
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1106/7/artifact/out/patch-site/book.html
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1106/7/artifact/out/patch-unit-root.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1106/7/testReport/
 |
   | Max. process+thread count | 5227 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-zookeeper hbase-server . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1106/7/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above

[jira] [Resolved] (HBASE-23764) Flaky tests due to ZK client name resolution delays

2020-02-01 Thread Bharath Vissapragada (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bharath Vissapragada resolved HBASE-23764.
--
Fix Version/s: 2.3.0
   3.0.0
   Resolution: Fixed

Thanks for the review [~stack]

> Flaky tests due to ZK client name resolution delays
> ---
>
> Key: HBASE-23764
> URL: https://issues.apache.org/jira/browse/HBASE-23764
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 3.0.0
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: sample-jstacks.zip
>
>
> [~ndimiduk] and I ran into this issue (separately) and we noticed that there 
> are some performance issues with name resolution in the Zookeeper client. 
> Since we use ZK heavily in the unit tests, this often manifests as the 
> following issues 
> 1. Test time outs starting the mini cluster (Master failed to start)
> 2. InterruptedException (because the tests timeout)
> 3. Flaky tests because a subset of the cluster fails to start for whatever 
> reason (replication tests especially because they spawn multiple clusters).
> 4. ConnectionLoss to znode /hbase/xyzz.. JVM pause?
> I have strong feeling that this is a possible cause for many of our flaky 
> tests in Jenkins. Luckily, it looks like the following workaround to switch 
> to an IP address instead of hostname makes it much quicker. There are some 
> related discussions in the ZK community (ZOOKEEPER-1666 and related jiras).
> {code:java}
> --- a/hbase-common/src/main/resources/hbase-default.xml
> +++ b/hbase-common/src/main/resources/hbase-default.xml
> @@ -72,7 +72,7 @@ possible configurations would overwhelm and obscure the 
> important.
>
>
>  hbase.zookeeper.quorum
> -localhost
> +127.0.0.1
>  Comma separated list of servers in the ZooKeeper ensemble
>  (This config. should have been named hbase.zookeeper.ensemble).
>  For example, "host1.mydomain.com,host2.mydomain.com,host3.mydomain.com".
> {code}
> Until we figure out the actual root cause and a dependency upgrade (if 
> needed), we should consider making this hostname to IP switch for more stable 
> builds.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (HBASE-23776) Remove deprecated createLocalHTU from HBaseTestingUtility

2020-02-01 Thread Jan Hentschel (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated HBASE-23776:
--
Fix Version/s: 3.0.0
 Hadoop Flags: Incompatible change,Reviewed  (was: Incompatible change)
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Remove deprecated createLocalHTU from HBaseTestingUtility
> -
>
> Key: HBASE-23776
> URL: https://issues.apache.org/jira/browse/HBASE-23776
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0
>
>
> {{createLocalHTU()}} in {{HBaseTestingUtility}} was deprecated back in 2.0.0 
> and should be removed for 3.0.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] HorizonNet merged pull request #1112: HBASE-23776 Removed deprecated method createLocalHTU() from HBaseTestingUtility

2020-02-01 Thread GitBox
HorizonNet merged pull request #1112: HBASE-23776 Removed deprecated method 
createLocalHTU() from HBaseTestingUtility
URL: https://github.com/apache/hbase/pull/1112
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-23774) Announce user-zh list

2020-02-01 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028226#comment-17028226
 ] 

Hudson commented on HBASE-23774:


Results for branch branch-2.2
[build #772 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/772/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/772//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/772//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/772//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Announce user-zh list
> -
>
> Key: HBASE-23774
> URL: https://issues.apache.org/jira/browse/HBASE-23774
> Project: HBase
>  Issue Type: Task
>  Components: website
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-23774.001.patch
>
>
> Let folks know about the new user-zh list that is dedicated for user 
> questions in chinese (as opposed to the norm of english on user)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] saintstack commented on issue #1106: HBASE-23764: Switch to IP address for ZK ensemble

2020-02-01 Thread GitBox
saintstack commented on issue #1106: HBASE-23764: Switch to IP address for ZK 
ensemble
URL: https://github.com/apache/hbase/pull/1106#issuecomment-581077970
 
 
   Let me merge by hand so I can remove the pom addition made just to run full 
suite.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1112: HBASE-23776 Removed deprecated method createLocalHTU() from HBaseTestingUtility

2020-02-01 Thread GitBox
Apache-HBase commented on issue #1112: HBASE-23776 Removed deprecated method 
createLocalHTU() from HBaseTestingUtility
URL: https://github.com/apache/hbase/pull/1112#issuecomment-581073630
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 51s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
33 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   6m 34s |  master passed  |
   | +1 :green_heart: |  compile  |   1m  2s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 26s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 47s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 41s |  master passed  |
   | +0 :ok: |  spotbugs  |   4m 55s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   4m 52s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   6m  0s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  8s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  8s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 20s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedjars  |   5m 15s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  19m 32s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   0m 40s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m  0s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 153m 33s |  hbase-server in the patch passed.  
|
   | +1 :green_heart: |  asflicense  |   0m 37s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 221m 48s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.5 Server=19.03.5 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1112/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1112 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 385d5246a964 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1112/out/precommit/personality/provided.sh
 |
   | git revision | master / 70699365ad |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1112/1/testReport/
 |
   | Max. process+thread count | 5533 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1112/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] saintstack commented on issue #1109: HBASE-23780 Edit of test classifications

2020-02-01 Thread GitBox
saintstack commented on issue #1109: HBASE-23780 Edit of test classifications
URL: https://github.com/apache/hbase/pull/1109#issuecomment-581073594
 
 
   A different two failed. Retry.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #1109: HBASE-23780 Edit of test classifications

2020-02-01 Thread GitBox
Apache-HBase commented on issue #1109: HBASE-23780 Edit of test classifications
URL: https://github.com/apache/hbase/pull/1109#issuecomment-581071238
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 38s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  4s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
183 new or modified test files.  |
   ||| _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 16s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   3m 15s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   3m 34s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 17s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m 32s |  branch-2 passed  |
   | +0 :ok: |  spotbugs  |   0m 35s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   7m 36s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 49s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 16s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 16s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 25s |  The patch passed checkstyle 
in hbase-common  |
   | +1 :green_heart: |  checkstyle  |   0m 33s |  The patch passed checkstyle 
in hbase-client  |
   | +1 :green_heart: |  checkstyle  |   0m 15s |  The patch passed checkstyle 
in hbase-zookeeper  |
   | +1 :green_heart: |  checkstyle  |   0m 15s |  The patch passed checkstyle 
in hbase-http  |
   | +1 :green_heart: |  checkstyle  |   0m 15s |  The patch passed checkstyle 
in hbase-procedure  |
   | +1 :green_heart: |  checkstyle  |   1m 26s |  hbase-server: The patch 
generated 0 new + 658 unchanged - 170 fixed = 658 total (was 828)  |
   | +1 :green_heart: |  checkstyle  |   0m 20s |  The patch passed checkstyle 
in hbase-mapreduce  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedjars  |   4m 19s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  15m 26s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   2m 32s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   8m 37s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 52s |  hbase-common in the patch passed.  
|
   | +1 :green_heart: |  unit  |   3m 53s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  |   0m 52s |  hbase-zookeeper in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   1m 14s |  hbase-http in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 11s |  hbase-procedure in the patch 
passed.  |
   | -1 :x: |  unit  | 150m 46s |  hbase-server in the patch failed.  |
   | -1 :x: |  unit  |  17m 27s |  hbase-mapreduce in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   4m 33s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 263m 16s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.quotas.TestClusterScopeQuotaThrottle |
   |   | hadoop.hbase.snapshot.TestExportSnapshotNoCluster |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.5 Server=19.03.5 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1109/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/1109 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux cea03dd2e225 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1109/out/precommit/personality/provided.sh
 |
   | git revision | branch-2 / 7b4b90aef5 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1109/5/artifact/out/patch-unit-hbase-server.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1109/5/artifact/out/patch-unit-hbase-mapreduce.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit

[jira] [Updated] (HBASE-23776) Remove deprecated createLocalHTU from HBaseTestingUtility

2020-02-01 Thread Jan Hentschel (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-23776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Hentschel updated HBASE-23776:
--
Status: Patch Available  (was: In Progress)

> Remove deprecated createLocalHTU from HBaseTestingUtility
> -
>
> Key: HBASE-23776
> URL: https://issues.apache.org/jira/browse/HBASE-23776
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> {{createLocalHTU()}} in {{HBaseTestingUtility}} was deprecated back in 2.0.0 
> and should be removed for 3.0.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [hbase] HorizonNet opened a new pull request #1112: HBASE-23776 Removed deprecated method createLocalHTU() from HBaseTestingUtility

2020-02-01 Thread GitBox
HorizonNet opened a new pull request #1112: HBASE-23776 Removed deprecated 
method createLocalHTU() from HBaseTestingUtility
URL: https://github.com/apache/hbase/pull/1112
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] saintstack commented on issue #1109: HBASE-23780 Edit of test classifications

2020-02-01 Thread GitBox
saintstack commented on issue #1109: HBASE-23780 Edit of test classifications
URL: https://github.com/apache/hbase/pull/1109#issuecomment-581049149
 
 
   Rerun build. Tests pass locally.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] virajjasani commented on a change in pull request #754: HBASE-22978 : Online slow response log

2020-02-01 Thread GitBox
virajjasani commented on a change in pull request #754: HBASE-22978 : Online 
slow response log
URL: https://github.com/apache/hbase/pull/754#discussion_r371620037
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
 ##
 @@ -215,6 +224,17 @@
*/
   private RSRpcServices rsRpcServices;
 
+
+  /**
+   * Use to add online slowlog responses
+   */
+  private OnlineSlowLogProvider onlineSlowLogProvider;
 
 Review comment:
   If we make it final, we add up more constructor arg which is again some 
pain, so IMHO better have setter method and let it be non-final please? :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] virajjasani edited a comment on issue #754: HBASE-22978 : Online slow response log

2020-02-01 Thread GitBox
virajjasani edited a comment on issue #754: HBASE-22978 : Online slow response 
log
URL: https://github.com/apache/hbase/pull/754#issuecomment-579605235
 
 
   > I think you misunderstood me here...
   > 
   > "With the patch we would run at RS entrance only and for any slow running 
query it will go to this ring buffer running at RS. Just that this patch 
doesn't include storing slow logs in HDFS, which is also a good idea and 
probably up for a subtask given the priority is storing slow logs in ring 
buffer first. Storing them in HDFS would be just an option as part of another 
Jira(sub-task)."
   > 
   > What I was saying is that your ringbuffer only keeps dfsclient ops. I was 
wondering if we could put actual requests into a system like this. If they are 
taking a long time, we could inspect the ringbuffer to see which type of 
queries are taking a while. It would be coarser grained than the dfs accesses 
only. Was just wondering if you think we could do this in a follow-on based on 
work h ere.
   
   One question: Does actual request not come to `RpcServer.logResponse()` 
already? If not, then definitely +1 for follow-up task. 
   I thought all requests already do land in RpcServer. No?
   
   Edit: @saintstack you are suggesting to run ringbuffer at RS entrance and 
consume request soon as it arrives at RS and before triggering DFSClient ops? 
If so, we need to determine which one is slow for RS to send response to 
HBaseClient/HMaster and accordingly log entry in ring buffer right? 
   +1 for the idea.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22978) Online slow response log

2020-02-01 Thread Viraj Jasani (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028114#comment-17028114
 ] 

Viraj Jasani commented on HBASE-22978:
--

[~stack] [~ndimiduk] Addressed latest review comments. Please review when you 
get some time.

> Online slow response log
> 
>
> Key: HBASE-22978
> URL: https://issues.apache.org/jira/browse/HBASE-22978
> Project: HBase
>  Issue Type: New Feature
>  Components: Admin, Operability, regionserver, shell
>Affects Versions: 3.0.0, 2.3.0, 1.5.1
>Reporter: Andrew Kyle Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
> Attachments: Screen Shot 2019-10-19 at 2.31.59 AM.png, Screen Shot 
> 2019-10-19 at 2.32.54 AM.png, Screen Shot 2019-10-19 at 2.34.11 AM.png, 
> Screen Shot 2019-10-19 at 2.36.14 AM.png
>
>
> Today when an individual RPC exceeds a configurable time bound we log a 
> complaint by way of the logging subsystem. These log lines look like:
> {noformat}
> 2019-08-30 22:10:36,195 WARN [,queue=15,port=60020] ipc.RpcServer - 
> (responseTooSlow):
> {"call":"Scan(org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ScanRequest)",
> "starttimems":1567203007549,
> "responsesize":6819737,
> "method":"Scan",
> "param":"region { type: REGION_NAME value: 
> \"tsdb,\\000\\000\\215\\f)o\\024\\302\\220\\000\\000\\000\\000\\000\\001\\000\\000\\000\\000\\000\\006\\000\\000\\000\\000\\000\\005\\000\\000",
> "processingtimems":28646,
> "client":"10.253.196.215:41116",
> "queuetimems":22453,
> "class":"HRegionServer"}
> {noformat}
> Unfortunately we often truncate the request parameters, like in the above 
> example. We do this because the human readable representation is verbose, the 
> rate of too slow warnings may be high, and the combination of these things 
> can overwhelm the log capture system. The truncation is unfortunate because 
> it eliminates much of the utility of the warnings. For example, the region 
> name, the start and end keys, and the filter hierarchy are all important 
> clues for debugging performance problems caused by moderate to low 
> selectivity queries or queries made at a high rate.
> We can maintain an in-memory ring buffer of requests that were judged to be 
> too slow in addition to the responseTooSlow logging. The in-memory 
> representation can be complete and compressed. A new admin API and shell 
> command can provide access to the ring buffer for online performance 
> debugging. A modest sizing of the ring buffer will prevent excessive memory 
> utilization for a minor performance debugging feature by limiting the total 
> number of retained records. There is some chance a high rate of requests will 
> cause information on other interesting requests to be overwritten before it 
> can be read. This is the nature of a ring buffer and an acceptable trade off.
> The write request types do not require us to retain all information submitted 
> in the request. We don't need to retain all key-values in the mutation, which 
> may be too large to comfortably retain. We only need a unique set of row 
> keys, or even a min/max range, and total counts.
> The consumers of this information will be debugging tools. We can afford to 
> apply fast compression to ring buffer entries (if codec support is 
> available), something like snappy or zstandard, and decompress on the fly 
> when servicing the retrieval API request. This will minimize the impact of 
> retaining more information about slow requests than we do today.
> This proposal is for retention of request information only, the same 
> information provided by responseTooSlow warnings. Total size of response 
> serialization, possibly also total cell or row counts, should be sufficient 
> to characterize the response.
> Optionally persist new entries added to the ring buffer into one or more 
> files in HDFS in a write-behind manner. If the HDFS writer blocks or falls 
> behind and we are unable to persist an entry before it is overwritten, that 
> is fine. Response too slow logging is best effort. If we can detect this make 
> a note of it in the log file. Provide a tool for parsing, dumping, filtering, 
> and pretty printing the slow logs written to HDFS. The tool and the shell can 
> share and reuse some utility classes and methods for accomplishing that. 
> —
> New shell commands:
> {{get_slow_responses [  ... ,  ] [ , \{  
> } ]}}
> Retrieve, decode, and pretty print the contents of the too slow response ring 
> buffer maintained by the given list of servers; or all servers in the cluster 
> if no list is provided. Optionally provide a map of parameters for filtering 
> as additional argument. The TABLE filter, which expects a string containing a 
> table name, will include only entries pertaining to that tabl

[jira] [Commented] (HBASE-23774) Announce user-zh list

2020-02-01 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028111#comment-17028111
 ] 

Hudson commented on HBASE-23774:


Results for branch master
[build #1616 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1616/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1616//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1616//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1616//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Announce user-zh list
> -
>
> Key: HBASE-23774
> URL: https://issues.apache.org/jira/browse/HBASE-23774
> Project: HBase
>  Issue Type: Task
>  Components: website
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-23774.001.patch
>
>
> Let folks know about the new user-zh list that is dedicated for user 
> questions in chinese (as opposed to the norm of english on user)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23770) [Flakey Tests] TestRegionReplicasWithRestartScenarios#testWhenRestart

2020-02-01 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028110#comment-17028110
 ] 

Hudson commented on HBASE-23770:


Results for branch master
[build #1616 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1616/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1616//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1616//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1616//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> [Flakey Tests] TestRegionReplicasWithRestartScenarios#testWhenRestart
> -
>
> Key: HBASE-23770
> URL: https://issues.apache.org/jira/browse/HBASE-23770
> Project: HBase
>  Issue Type: Bug
>  Components: flakies
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 
> 0001-HBASE-23770-Flakey-Tests-TestRegionReplicasWithResta.patch, Screen Shot 
> 2020-01-29 at 9.45.58 PM.png, Screen Shot 2020-01-31 at 8.37.13 AM.png, 
> Screen Shot 2020-01-31 at 8.49.22 AM.png
>
>
> Fails about 35% of the time in the GCE build. Let me attach a picture from 
> current flakies dashboard for branch-2.
> The test starts a cluster of three RS w/ 3 region replicas. It then stops a 
> server, starts a new one, and then expects that the remaining three nodes do 
> not have instances where two region replicas have landed on a single server.
> It fails sporadically (reproducible locally) because when the SCP runs its 
> assign, sometimes timing has it so Master knows of two servers only.  Making 
> the new start before the old one is stopped (instead of other way around) 
> seems to fix the test -- there'll be three servers up when SCP runs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23771) [Flakey Tests] Test TestSplitTransactionOnCluster Again

2020-02-01 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028109#comment-17028109
 ] 

Hudson commented on HBASE-23771:


Results for branch master
[build #1616 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1616/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1616//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1616//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1616//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> [Flakey Tests] Test TestSplitTransactionOnCluster Again
> ---
>
> Key: HBASE-23771
> URL: https://issues.apache.org/jira/browse/HBASE-23771
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 
> 0001-HBASE-23771-Flakey-Tests-Test-TestSplitTransactionOn.patch, Screen Shot 
> 2020-01-31 at 8.37.13 AM.png
>
>
> Parent fix had the test failures in GCE go from 35% to 4%. Let me see if can 
> clear the remaining fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23774) Announce user-zh list

2020-02-01 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028050#comment-17028050
 ] 

Hudson commented on HBASE-23774:


Results for branch branch-1
[build #1218 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1218/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1218//General_Nightly_Build_Report/]


(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1218//JDK7_Nightly_Build_Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1218//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Announce user-zh list
> -
>
> Key: HBASE-23774
> URL: https://issues.apache.org/jira/browse/HBASE-23774
> Project: HBase
>  Issue Type: Task
>  Components: website
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-23774.001.patch
>
>
> Let folks know about the new user-zh list that is dedicated for user 
> questions in chinese (as opposed to the norm of english on user)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23774) Announce user-zh list

2020-02-01 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028029#comment-17028029
 ] 

Hudson commented on HBASE-23774:


Results for branch branch-2
[build #2444 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2444/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2444//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2444//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2444//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Announce user-zh list
> -
>
> Key: HBASE-23774
> URL: https://issues.apache.org/jira/browse/HBASE-23774
> Project: HBase
>  Issue Type: Task
>  Components: website
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-23774.001.patch
>
>
> Let folks know about the new user-zh list that is dedicated for user 
> questions in chinese (as opposed to the norm of english on user)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)