[GitHub] [hbase] Apache-HBase commented on issue #1453: HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7
Apache-HBase commented on issue #1453: HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 URL: https://github.com/apache/hbase/pull/1453#issuecomment-610763024 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 49s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 38s | master passed | | +1 :green_heart: | compile | 5m 29s | master passed | | +1 :green_heart: | shadedjars | 7m 17s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 21s | hbase-zookeeper in master failed. | | -0 :warning: | javadoc | 0m 21s | root in master failed. | | -0 :warning: | javadoc | 0m 48s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 8m 38s | the patch passed | | +1 :green_heart: | compile | 4m 0s | the patch passed | | +1 :green_heart: | javac | 4m 0s | the patch passed | | +1 :green_heart: | shadedjars | 5m 30s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-zookeeper in the patch failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 19s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 125m 50s | root in the patch failed. | | | | 172m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1453 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1f2ba9752ea6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-zookeeper.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-zookeeper.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/testReport/ | | Max. process+thread count | 4480 (vs. ulimit of 1) | | modules | C: hbase-zookeeper hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an…
Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an… URL: https://github.com/apache/hbase/pull/1451#issuecomment-610754672 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 33s | branch-2 passed | | +1 :green_heart: | compile | 3m 3s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 20s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 1s | the patch passed | | +1 :green_heart: | compile | 2m 57s | the patch passed | | +1 :green_heart: | javac | 2m 57s | the patch passed | | +1 :green_heart: | shadedjars | 4m 14s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 163m 33s | root in the patch passed. | | | | 199m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1451 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 15a8b31f41b8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 953c326498 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/2/testReport/ | | Max. process+thread count | 5290 (vs. ulimit of 12500) | | modules | C: hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1454: HBASE-24062 Add 2.1.10 to download page
Apache-HBase commented on issue #1454: HBASE-24062 Add 2.1.10 to download page URL: https://github.com/apache/hbase/pull/1454#issuecomment-610752824 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 47s | master passed | | +1 :green_heart: | mvnsite | 18m 32s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 51s | the patch passed | | +1 :green_heart: | mvnsite | 18m 53s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 53m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1454/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1454 | | Optional Tests | dupname asflicense mvnsite xml | | uname | Linux f6a541e2ffac 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6451a8e2b | | Max. process+thread count | 82 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1454/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1435: HBASE-24112 [RSGroup] Support renaming rsgroup
Apache-HBase commented on issue #1435: HBASE-24112 [RSGroup] Support renaming rsgroup URL: https://github.com/apache/hbase/pull/1435#issuecomment-610749104 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 20s | master passed | | +1 :green_heart: | checkstyle | 2m 49s | master passed | | +1 :green_heart: | spotbugs | 8m 37s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 16s | the patch passed | | -0 :warning: | checkstyle | 0m 32s | hbase-client: The patch generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37) | | -0 :warning: | checkstyle | 1m 5s | hbase-server: The patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 48s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | hbaseprotoc | 2m 50s | the patch passed | | +1 :green_heart: | spotbugs | 8m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 2s | The patch does not generate ASF License warnings. | | | | 57m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1435/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1435 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux 3e4638d18942 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6451a8e2b | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1435/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1435/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1435/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] mwkang edited a comment on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
mwkang edited a comment on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time. URL: https://github.com/apache/hbase/pull/1274#issuecomment-610743488 @saintstack All test is green. Could you check this PR? and I want to apply this patch in branch-2.2, branch-1.x. because I am preparing to make an HBase cluster using HBase-2.2.X and I operate HBase cluster Using HBase-1.x. Does it make sense? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] mwkang edited a comment on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
mwkang edited a comment on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time. URL: https://github.com/apache/hbase/pull/1274#issuecomment-610743488 @saintstack All test is green. Could you check this PR? and I want to apply this patch in branch-2.2. because I am preparing to make an HBase cluster using HBase-2.2.X. Does it make sense? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] mwkang commented on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
mwkang commented on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time. URL: https://github.com/apache/hbase/pull/1274#issuecomment-610743488 @saintstack All test is green. Could you check this PR? and I want to apply this patch in branch-2.2. because I am preparing to make an HBase cluster using HBase-2.2.4. Does it make sense? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1453: HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7
Apache-HBase commented on issue #1453: HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 URL: https://github.com/apache/hbase/pull/1453#issuecomment-610743179 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 7s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 56s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 39s | master passed | | +1 :green_heart: | checkstyle | 3m 13s | master passed | | +1 :green_heart: | spotbugs | 18m 52s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 8m 5s | the patch passed | | +1 :green_heart: | checkstyle | 3m 14s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 16m 20s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 17m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 39s | The patch does not generate ASF License warnings. | | | | 90m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1453 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml | | uname | Linux ba035cef77a7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Max. process+thread count | 84 (vs. ulimit of 1) | | modules | C: hbase-zookeeper hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
Apache-HBase commented on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time. URL: https://github.com/apache/hbase/pull/1274#issuecomment-610742359 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 55s | master passed | | +1 :green_heart: | compile | 0m 55s | master passed | | +1 :green_heart: | shadedjars | 4m 57s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 36s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 4m 55s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 169m 51s | hbase-server in the patch passed. | | | | 197m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1274/7/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1274 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c2be8903e7d8 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1274/7/testReport/ | | Max. process+thread count | 3617 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1274/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1454: HBASE-24062 Add 2.1.10 to download page
Apache-HBase commented on issue #1454: HBASE-24062 Add 2.1.10 to download page URL: https://github.com/apache/hbase/pull/1454#issuecomment-610741201 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1454/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1454 | | Optional Tests | | | uname | Linux 547a02f5aedb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6451a8e2b | | Max. process+thread count | 46 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1454/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1454: HBASE-24062 Add 2.1.10 to download page
Apache-HBase commented on issue #1454: HBASE-24062 Add 2.1.10 to download page URL: https://github.com/apache/hbase/pull/1454#issuecomment-610741117 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1454/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1454 | | Optional Tests | | | uname | Linux 7fc06711cf7d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d6451a8e2b | | Max. process+thread count | 54 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1454/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
Apache-HBase commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout URL: https://github.com/apache/hbase/pull/1441#issuecomment-610740470 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 0s | master passed | | +1 :green_heart: | checkstyle | 1m 16s | master passed | | +1 :green_heart: | spotbugs | 2m 9s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 27s | the patch passed | | +1 :green_heart: | checkstyle | 1m 13s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 21s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 18s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 38m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1441 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 360207d22c71 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 opened a new pull request #1454: HBASE-24062 Add 2.1.10 to download page
Apache9 opened a new pull request #1454: HBASE-24062 Add 2.1.10 to download page URL: https://github.com/apache/hbase/pull/1454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24067) [RSGroup] Error logs appear when the table is created
[
https://issues.apache.org/jira/browse/HBASE-24067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kangkang.guo updated HBASE-24067:
-
Description:
Will create table assigned to the corresponding rsgroup, appear
TableStateNotFoundException:
{code:java}
2020-03-27 15:49:21,959 INFO
[RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000]
rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default
2020-03-27 15:49:21,971 ERROR
[RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000]
master.TableStateManager: Unable to get table Test:t3 state
org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException:
Test:t3
at
org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215)
at
org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147)
at
org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388)
at
org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252)
at
org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366)
at
org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447)
at
org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470)
at
org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350)
at
org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347)
at
org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551)
at
org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625)
at
org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347)
at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2043)
at
org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134)
at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2026)
at
org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:659)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)
2020-03-27 15:49:21,971 INFO
[RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000]
rsgroup.RSGroupAdminServer: Moving region(s) for table Test:t3 to RSGroup
default
{code}
This doesn't seem to cause any problems, but I think it's best to avoid error
logs like this
was:
Will create table assigned to the corresponding rsgroup, appear
TableStateNotFoundException:
2020-03-27 15:49:21,959 INFO
[RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000]
rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default
2020-03-27 15:49:21,971 ERROR
[RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000]
master.TableStateManager: Unable to get table Test:t3 state
org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException:
Test:t3
at
org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215)
at
org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147)
at
org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388)
at
org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252)
at
org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366)
at
org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447)
at
org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470)
at
org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350)
at
org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347)
at
org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551)
at
org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625)
at
[GitHub] [hbase] Reidddddd commented on a change in pull request #1435: HBASE-24112 [RSGroup] Support renaming rsgroup
Reidd commented on a change in pull request #1435: HBASE-24112 [RSGroup]
Support renaming rsgroup
URL: https://github.com/apache/hbase/pull/1435#discussion_r405241049
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin1.java
##
@@ -468,4 +468,31 @@ public boolean evaluate() throws Exception {
// Cleanup
TEST_UTIL.deleteTable(tn1);
}
+
+ @Test
+ public void testRenameRSGroup() throws Exception {
+// Add rsgroup, and assign 2 servers and a table to it.
+RSGroupInfo oldgroup = addGroup("oldgroup", 2);
+TableName tb = TableName.valueOf("testRename");
+TEST_UTIL.createTable(tb, "tr");
+ADMIN.setRSGroup(Sets.newHashSet(tb), oldgroup.getName());
+Thread.sleep(500);
+oldgroup = ADMIN.getRSGroup(oldgroup.getName());
+assertEquals(2, oldgroup.getServers().size());
+assertEquals(oldgroup.getName(), ADMIN.getRSGroup(tb).getName());
+
+// Rename rsgroup
+ADMIN.renameRSGroup(oldgroup.getName(), "newgroup");
+Set servers = oldgroup.getServers();
+RSGroupInfo newgroup = ADMIN.getRSGroup("newgroup");
+assertEquals(servers.size(), newgroup.getServers().size());
+int match = 0;
+for (Address addr : newgroup.getServers()) {
+ if (servers.contains(addr)) {
+match++;
+ }
+}
+assertEquals(servers.size(), match);
Review comment:
Get your idea. Fixed in new commit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] huaxiangsun commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
huaxiangsun commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout URL: https://github.com/apache/hbase/pull/1441#issuecomment-610734485 Test failures are mostly due to "Unable to create native thread", will address the comments and kick off a new run later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24115) Relocate test-only REST "client" from src/ to test/ and mark Private
[
https://issues.apache.org/jira/browse/HBASE-24115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077808#comment-17077808
]
Hudson commented on HBASE-24115:
Results for branch branch-2.1
[build #1850 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1850/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1850//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1850//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1850//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Relocate test-only REST "client" from src/ to test/ and mark Private
>
>
> Key: HBASE-24115
> URL: https://issues.apache.org/jira/browse/HBASE-24115
> Project: HBase
> Issue Type: Test
> Components: REST, security
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0, 2.3.1, 1.3.7, 1.7.0, 2.4.0, 2.1.10, 1.4.14, 2.2.5
>
>
> Relocate test-only REST "client" from src/ to test/ and annotate as Private.
> The classes o.a.h.h.rest.Remote* were developed to facilitate REST unit tests
> and incorrectly committed to src/ .
> Although this "breaks" compatibility by moving public classes to test jar and
> marking them private, no attention has been paid to these classes with
> respect to performance, convenience, or security. Consensus from various
> discussions over the years is to move them to test/ as was intent of the
> original committer, but misplaced by the same individual.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1453: HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7
Apache-HBase commented on issue #1453: HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 URL: https://github.com/apache/hbase/pull/1453#issuecomment-610734239 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 47s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 22s | master passed | | +1 :green_heart: | compile | 3m 0s | master passed | | +1 :green_heart: | shadedjars | 4m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 23s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 10s | the patch passed | | +1 :green_heart: | compile | 3m 4s | the patch passed | | +1 :green_heart: | javac | 3m 4s | the patch passed | | +1 :green_heart: | shadedjars | 4m 53s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 30s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 12m 13s | root in the patch failed. | | | | 48m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1453 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bb29c5aa681b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/testReport/ | | Max. process+thread count | 564 (vs. ulimit of 1) | | modules | C: hbase-zookeeper hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1453/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-24091) Put up 2.1.10RC1
[ https://issues.apache.org/jira/browse/HBASE-24091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24091. --- Resolution: Fixed Release 2.1.10RC1 as 2.1.10. > Put up 2.1.10RC1 > > > Key: HBASE-24091 > URL: https://issues.apache.org/jira/browse/HBASE-24091 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] huaxiangsun merged pull request #1433: HBASE-24114 [Flakey Tests] TestSnapshotScannerHDFSAclController
huaxiangsun merged pull request #1433: HBASE-24114 [Flakey Tests] TestSnapshotScannerHDFSAclController URL: https://github.com/apache/hbase/pull/1433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
Apache-HBase commented on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time. URL: https://github.com/apache/hbase/pull/1274#issuecomment-610732020 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 1s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 21s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 5m 14s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 55s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 5m 25s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 116m 1s | hbase-server in the patch passed. | | | | 148m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1274/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1274 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 620feb254aa1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1274/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1274/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1274/7/testReport/ | | Max. process+thread count | 4165 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1274/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24067) [RSGroup] Error logs appear when the table is created
[ https://issues.apache.org/jira/browse/HBASE-24067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-24067: - Issue Type: Bug (was: Improvement) > [RSGroup] Error logs appear when the table is created > - > > Key: HBASE-24067 > URL: https://issues.apache.org/jira/browse/HBASE-24067 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.1.7, 2.1.8, 2.2.3, 2.2.4 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Minor > > Will create table assigned to the corresponding rsgroup, appear > TableStateNotFoundException: > 2020-03-27 15:49:21,959 INFO > [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] > rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default > 2020-03-27 15:49:21,971 ERROR > [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] > master.TableStateManager: Unable to get table Test:t3 state > org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: > Test:t3 > at > org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215) > at > org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147) > at > org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470) > at > org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350) > at > org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625) > at > org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347) > at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2043) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134) > at > org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2026) > at > org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:659) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) > 2020-03-27 15:49:21,971 INFO > [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] > rsgroup.RSGroupAdminServer: Moving region(s) for table Test:t3 to RSGroup > default > > This doesn't seem to cause any problems, but I think it's best to avoid error > logs like this -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
Apache-HBase commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout URL: https://github.com/apache/hbase/pull/1441#issuecomment-610731549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 1s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 5m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 51s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 5m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 134m 27s | hbase-server in the patch failed. | | | | 166m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1441 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux aa3a0eb3c5e6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/testReport/ | | Max. process+thread count | 3949 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
Apache-HBase commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout URL: https://github.com/apache/hbase/pull/1441#issuecomment-610726617 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 49s | master passed | | +1 :green_heart: | compile | 1m 22s | master passed | | +1 :green_heart: | shadedjars | 5m 20s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 53s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | shadedjars | 5m 9s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 116m 34s | hbase-server in the patch passed. | | | | 147m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1441 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 544f308cbe6a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/testReport/ | | Max. process+thread count | 3894 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24086) Disable output stream capability enforcement when running in standalone mode
[
https://issues.apache.org/jira/browse/HBASE-24086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077767#comment-17077767
]
Guanghao Zhang commented on HBASE-24086:
[~ndimiduk] Sorry for reply late. +1 for branch-2.2. Thanks.
> Disable output stream capability enforcement when running in standalone mode
>
>
> Key: HBASE-24086
> URL: https://issues.apache.org/jira/browse/HBASE-24086
> Project: HBase
> Issue Type: Task
> Components: master
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> {noformat}
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> mvn clean install -DskipTests
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> ./bin/hbase master start
> {noformat}
> gives
> {noformat}
> 2020-03-30 17:12:43,857 ERROR
> [master/192.168.111.13:16000:becomeActiveMaster] master.HMaster: Failed to
> become active master
>
> java.io.IOException: cannot get log writer
>
>
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:118)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createAsyncWriter(AsyncFSWAL.java:704)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:710)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:128)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:839)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:549)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:490)
>
>
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:156)
>
>
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:61)
>
>
> at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:297)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.createWAL(RegionProcedureStore.java:256)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.bootstrap(RegionProcedureStore.java:273)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.recoverLease(RegionProcedureStore.java:482)
>
>
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:587)
>
>
> at
> org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1575)
>
>
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:961)
>
>
>
[GitHub] [hbase] Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an…
Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an… URL: https://github.com/apache/hbase/pull/1451#issuecomment-610725520 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 15s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 41s | branch-2 passed | | +1 :green_heart: | spotbugs | 15m 44s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 42s | the patch passed | | +1 :green_heart: | checkstyle | 2m 57s | the patch passed | | +1 :green_heart: | hadolint | 0m 3s | There were no new hadolint issues. | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 37s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 15m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 71m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1451 | | Optional Tests | dupname asflicense hadolint shellcheck shelldocs spotbugs hadoopcheck hbaseanti checkstyle xml | | uname | Linux 633b2d6100f3 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 953c326498 | | Max. process+thread count | 83 (vs. ulimit of 12500) | | modules | C: hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 spotbugs=3.1.12 hadolint=1.17.5-0-g443423c | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24132) Upgrade to Apache ZooKeeper 3.5.7
[ https://issues.apache.org/jira/browse/HBASE-24132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077763#comment-17077763 ] Jianfei Jiang commented on HBASE-24132: --- Thank you [~zhangduo], I have created a pr [https://github.com/apache/hbase/pull/1453], please review. > Upgrade to Apache ZooKeeper 3.5.7 > - > > Key: HBASE-24132 > URL: https://issues.apache.org/jira/browse/HBASE-24132 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.3 >Reporter: Jianfei Jiang >Assignee: Jianfei Jiang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-24132_001.patch > > > Apache ZooKeeper 3.5.7 has been released, HDFS and other projects have > updated the dependent zookeeper verison. Perhaps Hbase may update as well. > Some of the interfaces are changed in this zookeeper version . -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] francisjjf opened a new pull request #1453: HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7
francisjjf opened a new pull request #1453: HBASE-24132 Upgrade to Apache ZooKeeper 3.5.7 URL: https://github.com/apache/hbase/pull/1453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24115) Relocate test-only REST "client" from src/ to test/ and mark Private
[
https://issues.apache.org/jira/browse/HBASE-24115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077761#comment-17077761
]
Hudson commented on HBASE-24115:
Results for branch branch-1.3
[build #1171 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1171/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1171//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1171//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1171//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Relocate test-only REST "client" from src/ to test/ and mark Private
>
>
> Key: HBASE-24115
> URL: https://issues.apache.org/jira/browse/HBASE-24115
> Project: HBase
> Issue Type: Test
> Components: REST, security
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0, 2.3.1, 1.3.7, 1.7.0, 2.4.0, 2.1.10, 1.4.14, 2.2.5
>
>
> Relocate test-only REST "client" from src/ to test/ and annotate as Private.
> The classes o.a.h.h.rest.Remote* were developed to facilitate REST unit tests
> and incorrectly committed to src/ .
> Although this "breaks" compatibility by moving public classes to test jar and
> marking them private, no attention has been paid to these classes with
> respect to performance, convenience, or security. Consensus from various
> discussions over the years is to move them to test/ as was intent of the
> original committer, but misplaced by the same individual.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock
Apache-HBase commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock URL: https://github.com/apache/hbase/pull/1407#issuecomment-610718532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 32s | master passed | | +1 :green_heart: | compile | 1m 8s | master passed | | +1 :green_heart: | shadedjars | 5m 33s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 16s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | shadedjars | 5m 40s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 125m 4s | hbase-server in the patch passed. | | | | 155m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1407/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1407 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a1439d1cecc3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1407/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1407/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1407/5/testReport/ | | Max. process+thread count | 3793 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1407/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock
Apache-HBase commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock URL: https://github.com/apache/hbase/pull/1407#issuecomment-610715313 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 25s | master passed | | +1 :green_heart: | compile | 0m 54s | master passed | | +1 :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 7s | the patch passed | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | +1 :green_heart: | shadedjars | 5m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 117m 15s | hbase-server in the patch passed. | | | | 143m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1407/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1407 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1b644ee76f2d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1407/5/testReport/ | | Max. process+thread count | 4385 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1407/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24114) [Flakey Tests] TestSnapshotScannerHDFSAclController
[
https://issues.apache.org/jira/browse/HBASE-24114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077750#comment-17077750
]
Yi Mei commented on HBASE-24114:
Thank you for taking a look [~huaxiangsun]. We have a fix in our Xiaomi branch,
set acl to tmp snapshot directory before RS execute snapshot regions, in this
way, acls can be inherited and don't need to set it, once snapshot is done, all
acls are ready. Let me upload this patch later.
> [Flakey Tests] TestSnapshotScannerHDFSAclController
> ---
>
> Key: HBASE-24114
> URL: https://issues.apache.org/jira/browse/HBASE-24114
> Project: HBase
> Issue Type: Test
> Components: acl
>Affects Versions: 2.3.0, master, 2.4.0
>Reporter: Huaxiang Sun
>Priority: Major
>
> Still see the following error from the test.
> {code:java}
> ---
> Test set:
> org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
> ---
> Tests run: 23, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 342.32 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
> org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.testGrantTable
> Time elapsed: 6.82 s <<< FAILURE!
> java.lang.AssertionError: expected:<6> but was:<-1>
> at
> org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.testGrantTable(TestSnapshotScannerHDFSAclController.java:349)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an…
Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an… URL: https://github.com/apache/hbase/pull/1451#issuecomment-610707068 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/2/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an…
Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an… URL: https://github.com/apache/hbase/pull/1451#issuecomment-610707079 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/2/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an…
Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an… URL: https://github.com/apache/hbase/pull/1451#issuecomment-610707075 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/2/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an…
Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an… URL: https://github.com/apache/hbase/pull/1451#issuecomment-610705828 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 59s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 14s | branch-2 passed | | +1 :green_heart: | compile | 4m 20s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 57s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | root in branch-2 failed. | | -0 :warning: | javadoc | 0m 45s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 10s | the patch passed | | +1 :green_heart: | compile | 4m 18s | the patch passed | | +1 :green_heart: | javac | 4m 18s | the patch passed | | +1 :green_heart: | shadedjars | 5m 52s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 46s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 20s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 265m 33s | root in the patch passed. | | | | 307m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1451 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a9804dcbdc79 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 953c326498 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/1/testReport/ | | Max. process+thread count | 3494 (vs. ulimit of 12500) | | modules | C: hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
Apache-HBase commented on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time. URL: https://github.com/apache/hbase/pull/1274#issuecomment-610703875 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 43s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 44s | master passed | | +1 :green_heart: | checkstyle | 1m 21s | master passed | | +1 :green_heart: | spotbugs | 2m 18s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 36s | the patch passed | | +1 :green_heart: | checkstyle | 1m 18s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 23s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 40m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1274/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1274 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux c9c4783083fb 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1274/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-16393) Improve computeHDFSBlocksDistribution
[ https://issues.apache.org/jira/browse/HBASE-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li resolved HBASE-16393. --- Resolution: Implemented Closing since all sub-tasks resolved. > Improve computeHDFSBlocksDistribution > - > > Key: HBASE-16393 > URL: https://issues.apache.org/jira/browse/HBASE-16393 > Project: HBase > Issue Type: Improvement >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > Attachments: HBASE-16393.patch > > > With our cluster is big, i can see the balancer is slow from time to time. > And the balancer will be called on master startup, so we can see the startup > is slow also. > The first thing i think whether if we can parallel compute different region's > HDFSBlocksDistribution. > The second i think we can improve compute single region's > HDFSBlocksDistribution. > When to compute a storefile's HDFSBlocksDistribution first we call > FileSystem#getFileStatus(path) and then > FileSystem#getFileBlockLocations(status, start, length), so two namenode rpc > call for every storefile. Instead we can use FileSystem#listLocatedStatus to > get a LocatedFileStatus for the information we need, so reduce the namenode > rpc call to one. This can speed the computeHDFSBlocksDistribution, but also > send out less rpc call to namenode. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-16397) optimize FSRegionScanner
[ https://issues.apache.org/jira/browse/HBASE-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li resolved HBASE-16397. --- Resolution: Incomplete Since there's no much information in the description, it's hard to judge whether the optimization planned is still valid. Thus I'm closing this long stalling one, please feel free to revive it if necessary [~binlijin] > optimize FSRegionScanner > > > Key: HBASE-16397 > URL: https://issues.apache.org/jira/browse/HBASE-16397 > Project: HBase > Issue Type: Sub-task >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-15161) Umbrella: Miscellaneous improvements from production usage
[ https://issues.apache.org/jira/browse/HBASE-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077731#comment-17077731 ] Yu Li commented on HBASE-15161: --- +1, thanks for watching on this [~ndimiduk] > Umbrella: Miscellaneous improvements from production usage > -- > > Key: HBASE-15161 > URL: https://issues.apache.org/jira/browse/HBASE-15161 > Project: HBase > Issue Type: Improvement >Reporter: Yu Li >Assignee: Yu Li >Priority: Major > > We use HBase to (mainly) build index for our search engine in Alibaba. > Recently we are upgrading our online cluster from 0.98.12 to 1.x and I'd like > to take the opportunity to contribute a bunch of our private patches to > community (better late than never, I hope :-)). This is an umbrella to track > this effort. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey
Test: TestReplicationAdminWithClusters timeout
URL: https://github.com/apache/hbase/pull/1441#discussion_r405203198
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java
##
@@ -122,6 +122,10 @@ public final void run() {
} catch (InterruptedException e) {
LOG.trace("Interrupted while waiting for next replication entry
batch", e);
Thread.currentThread().interrupt();
+ } catch (ReplicationRuntimeException rre) {
Review comment:
Will do, and updated the patch to fix the NullPointerException as well,
thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
Apache-HBase commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout URL: https://github.com/apache/hbase/pull/1441#issuecomment-61069 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 37s | master passed | | +1 :green_heart: | checkstyle | 1m 6s | master passed | | +1 :green_heart: | spotbugs | 2m 0s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 59s | the patch passed | | +1 :green_heart: | checkstyle | 1m 5s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 13s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 34m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1441 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 994d023b4959 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey
Test: TestReplicationAdminWithClusters timeout
URL: https://github.com/apache/hbase/pull/1441#discussion_r405195387
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##
@@ -579,8 +579,8 @@ private void
interruptOrAbortWhenFail(ReplicationQueueOperation op) {
if (e.getCause() != null && e.getCause() instanceof
KeeperException.SystemErrorException
Review comment:
missed this comment, will get back.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
Apache9 commented on a change in pull request #1441: HBASE-24120 Flakey Test:
TestReplicationAdminWithClusters timeout
URL: https://github.com/apache/hbase/pull/1441#discussion_r405202676
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
##
@@ -445,7 +445,7 @@ private IOException extractHiddenEof(Exception ex) {
&& ex.getCause() != null && ex.getCause() instanceof IOException) {
ioEx = (IOException)ex.getCause();
}
-if (ioEx != null) {
+if ((ioEx != null) && (ioEx.getMessage() != null)) {
Review comment:
Good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
Apache9 commented on a change in pull request #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout URL: https://github.com/apache/hbase/pull/1441#discussion_r405202506 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationRuntimeException.java ## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.replication.regionserver; + +import org.apache.yetus.audience.InterfaceAudience; + +/** + * This exception is thrown when replication source is terminated and source threads got + * interrupted. + * Review comment: Add a so it will not be reformated by IDE. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
Apache9 commented on a change in pull request #1441: HBASE-24120 Flakey Test:
TestReplicationAdminWithClusters timeout
URL: https://github.com/apache/hbase/pull/1441#discussion_r405202353
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java
##
@@ -122,6 +122,10 @@ public final void run() {
} catch (InterruptedException e) {
LOG.trace("Interrupted while waiting for next replication entry
batch", e);
Thread.currentThread().interrupt();
+ } catch (ReplicationRuntimeException rre) {
Review comment:
I think we could do this
```
catch (InterruptedException | ReplicationRuntimeException e) {
blabla
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1452: HBASE-24131 [Flakey Tests] TestExportSnapshot takes too long; up agai…
Apache-HBase commented on issue #1452: HBASE-24131 [Flakey Tests] TestExportSnapshot takes too long; up agai… URL: https://github.com/apache/hbase/pull/1452#issuecomment-610697323 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 5s | branch-2 passed | | +1 :green_heart: | compile | 0m 35s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 43s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-mapreduce in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 17s | the patch passed | | +1 :green_heart: | compile | 0m 33s | the patch passed | | +1 :green_heart: | javac | 0m 33s | the patch passed | | +1 :green_heart: | shadedjars | 7m 9s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 24s | hbase-mapreduce in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 14m 14s | hbase-mapreduce in the patch passed. | | | | 49m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1452/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1452 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cde91ae1bdda 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 953c326498 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1452/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1452/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1452/1/testReport/ | | Max. process+thread count | 5668 (vs. ulimit of 12500) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1452/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey
Test: TestReplicationAdminWithClusters timeout
URL: https://github.com/apache/hbase/pull/1441#discussion_r405202118
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
##
@@ -445,7 +445,7 @@ private IOException extractHiddenEof(Exception ex) {
&& ex.getCause() != null && ex.getCause() instanceof IOException) {
ioEx = (IOException)ex.getCause();
}
-if (ioEx != null) {
+if ((ioEx != null) && (ioEx.getMessage() != null)) {
Review comment:
Added this check because the flakey test run into the following Nullpointer
exception.
`2020-04-07 03:30:03,677 WARN
[RS_REFRESH_PEER-regionserver/asf905:0-0.replicationSource,2.replicationSource.wal-reader.asf905.gq1.ygridcore.net%2C41391%2C1586230117579,2]
impl.BlockReaderFactory(768): I/O error constructing remote block reader.
java.nio.channels.ClosedByInterruptException
at
java.nio.channels.spi.AbstractInterruptibleChannel.end(AbstractInterruptibleChannel.java:202)
at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:659)
at
org.apache.hadoop.net.SocketIOWithTimeout.connect(SocketIOWithTimeout.java:192)
at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:531)
at
org.apache.hadoop.hdfs.DFSClient.newConnectedPeer(DFSClient.java:2881)
at
org.apache.hadoop.hdfs.client.impl.BlockReaderFactory.nextTcpPeer(BlockReaderFactory.java:825)
at
org.apache.hadoop.hdfs.client.impl.BlockReaderFactory.getRemoteBlockReaderFromTcp(BlockReaderFactory.java:750)
at
org.apache.hadoop.hdfs.client.impl.BlockReaderFactory.build(BlockReaderFactory.java:387)
at
org.apache.hadoop.hdfs.DFSInputStream.getBlockReader(DFSInputStream.java:717)
at
org.apache.hadoop.hdfs.DFSInputStream.blockSeekTo(DFSInputStream.java:665)
at
org.apache.hadoop.hdfs.DFSInputStream.seekToBlockSource(DFSInputStream.java:1697)
at
org.apache.hadoop.hdfs.DFSInputStream.readBuffer(DFSInputStream.java:915)
at
org.apache.hadoop.hdfs.DFSInputStream.readWithStrategy(DFSInputStream.java:950)
at
org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:996)
at java.io.DataInputStream.read(DataInputStream.java:149)
at java.io.FilterInputStream.read(FilterInputStream.java:133)
at java.io.PushbackInputStream.read(PushbackInputStream.java:186)
at org.apache.hadoop.io.IOUtils.readFully(IOUtils.java:209)
at
org.apache.hadoop.hbase.KeyValueUtil.createKeyValueFromInputStream(KeyValueUtil.java:716)
at
org.apache.hadoop.hbase.codec.KeyValueCodecWithTags$KeyValueDecoder.parseCell(KeyValueCodecWithTags.java:81)
at
org.apache.hadoop.hbase.codec.BaseDecoder.advance(BaseDecoder.java:68)
at
org.apache.hadoop.hbase.wal.WALEdit.readFromCells(WALEdit.java:276)
at
org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:382)
at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:98)
at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:86)
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:263)
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:176)
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:101)
at
org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:221)
at
org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:138)
2020-04-07 03:30:03,678 ERROR
[RS_REFRESH_PEER-regionserver/asf905:0-0.replicationSource,2.replicationSource.wal-reader.asf905.gq1.ygridcore.net%2C41391%2C1586230117579,2]
regionserver.ReplicationSource(397): Unexpected exception in
RS_REFRESH_PEER-regionserver/asf905:0-0.replicationSource,2.replicationSource.wal-reader.asf905.gq1.ygridcore.net%2C41391%2C1586230117579,2
currentPath=hdfs://localhost:37359/user/jenkins/test-data/260e1f0f-a3fd-6192-b1d7-6568614aef58/WALs/asf905.gq1.ygridcore.net,41391,1586230117579/asf905.gq1.ygridcore.net%2C41391%2C1586230117579.1586230122806
java.lang.NullPointerException
at
org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.extractHiddenEof(ProtobufLogReader.java:449)
at
org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:396)
at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:98)
at
[GitHub] [hbase] huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey
Test: TestReplicationAdminWithClusters timeout
URL: https://github.com/apache/hbase/pull/1441#discussion_r405202118
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
##
@@ -445,7 +445,7 @@ private IOException extractHiddenEof(Exception ex) {
&& ex.getCause() != null && ex.getCause() instanceof IOException) {
ioEx = (IOException)ex.getCause();
}
-if (ioEx != null) {
+if ((ioEx != null) && (ioEx.getMessage() != null)) {
Review comment:
Added this check because the flakey test run into the following Nullpointer
exception.
2020-04-07 03:30:03,677 WARN
[RS_REFRESH_PEER-regionserver/asf905:0-0.replicationSource,2.replicationSource.wal-reader.asf905.gq1.ygridcore.net%2C41391%2C1586230117579,2]
impl.BlockReaderFactory(768): I/O error constructing remote block reader.
java.nio.channels.ClosedByInterruptException
at
java.nio.channels.spi.AbstractInterruptibleChannel.end(AbstractInterruptibleChannel.java:202)
at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:659)
at
org.apache.hadoop.net.SocketIOWithTimeout.connect(SocketIOWithTimeout.java:192)
at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:531)
at
org.apache.hadoop.hdfs.DFSClient.newConnectedPeer(DFSClient.java:2881)
at
org.apache.hadoop.hdfs.client.impl.BlockReaderFactory.nextTcpPeer(BlockReaderFactory.java:825)
at
org.apache.hadoop.hdfs.client.impl.BlockReaderFactory.getRemoteBlockReaderFromTcp(BlockReaderFactory.java:750)
at
org.apache.hadoop.hdfs.client.impl.BlockReaderFactory.build(BlockReaderFactory.java:387)
at
org.apache.hadoop.hdfs.DFSInputStream.getBlockReader(DFSInputStream.java:717)
at
org.apache.hadoop.hdfs.DFSInputStream.blockSeekTo(DFSInputStream.java:665)
at
org.apache.hadoop.hdfs.DFSInputStream.seekToBlockSource(DFSInputStream.java:1697)
at
org.apache.hadoop.hdfs.DFSInputStream.readBuffer(DFSInputStream.java:915)
at
org.apache.hadoop.hdfs.DFSInputStream.readWithStrategy(DFSInputStream.java:950)
at
org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:996)
at java.io.DataInputStream.read(DataInputStream.java:149)
at java.io.FilterInputStream.read(FilterInputStream.java:133)
at java.io.PushbackInputStream.read(PushbackInputStream.java:186)
at org.apache.hadoop.io.IOUtils.readFully(IOUtils.java:209)
at
org.apache.hadoop.hbase.KeyValueUtil.createKeyValueFromInputStream(KeyValueUtil.java:716)
at
org.apache.hadoop.hbase.codec.KeyValueCodecWithTags$KeyValueDecoder.parseCell(KeyValueCodecWithTags.java:81)
at
org.apache.hadoop.hbase.codec.BaseDecoder.advance(BaseDecoder.java:68)
at
org.apache.hadoop.hbase.wal.WALEdit.readFromCells(WALEdit.java:276)
at
org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:382)
at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:98)
at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:86)
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:263)
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:176)
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:101)
at
org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:221)
at
org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:138)
2020-04-07 03:30:03,678 ERROR
[RS_REFRESH_PEER-regionserver/asf905:0-0.replicationSource,2.replicationSource.wal-reader.asf905.gq1.ygridcore.net%2C41391%2C1586230117579,2]
regionserver.ReplicationSource(397): Unexpected exception in
RS_REFRESH_PEER-regionserver/asf905:0-0.replicationSource,2.replicationSource.wal-reader.asf905.gq1.ygridcore.net%2C41391%2C1586230117579,2
currentPath=hdfs://localhost:37359/user/jenkins/test-data/260e1f0f-a3fd-6192-b1d7-6568614aef58/WALs/asf905.gq1.ygridcore.net,41391,1586230117579/asf905.gq1.ygridcore.net%2C41391%2C1586230117579.1586230122806
java.lang.NullPointerException
at
org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.extractHiddenEof(ProtobufLogReader.java:449)
at
org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:396)
at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:98)
at
[jira] [Commented] (HBASE-24135) HBase RS Group
[ https://issues.apache.org/jira/browse/HBASE-24135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077724#comment-17077724 ] Duo Zhang commented on HBASE-24135: --- [~zghao] Did we meet the same problem when testing rs group feature? > HBase RS Group > -- > > Key: HBASE-24135 > URL: https://issues.apache.org/jira/browse/HBASE-24135 > Project: HBase > Issue Type: Bug >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Priority: Minor > > IF RS group is enabled then Unable to get table state error is thrown while > creating a new table > > Stpes: > 1: Make sure RS group feature is enabled > 2: Create a table say usertable2000 > 3: Check master log and observe below exception is thrown > org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: > usertable2000 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1452: HBASE-24131 [Flakey Tests] TestExportSnapshot takes too long; up agai…
Apache-HBase commented on issue #1452: HBASE-24131 [Flakey Tests] TestExportSnapshot takes too long; up agai… URL: https://github.com/apache/hbase/pull/1452#issuecomment-610694858 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 14s | branch-2 passed | | +1 :green_heart: | compile | 0m 25s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 49s | the patch passed | | +1 :green_heart: | compile | 0m 24s | the patch passed | | +1 :green_heart: | javac | 0m 24s | the patch passed | | +1 :green_heart: | shadedjars | 5m 12s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 18m 6s | hbase-mapreduce in the patch passed. | | | | 44m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1452/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1452 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5ae8356465ae 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 953c326498 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1452/1/testReport/ | | Max. process+thread count | 3598 (vs. ulimit of 12500) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1452/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an…
Apache-HBase commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an… URL: https://github.com/apache/hbase/pull/1451#issuecomment-610693714 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 0s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 15s | branch-2 passed | | +1 :green_heart: | compile | 3m 24s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 47s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 46s | the patch passed | | +1 :green_heart: | compile | 3m 17s | the patch passed | | +1 :green_heart: | javac | 3m 17s | the patch passed | | +1 :green_heart: | shadedjars | 4m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 37s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 219m 30s | root in the patch failed. | | | | 260m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1451 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3974750fed7d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 953c326498 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/1/testReport/ | | Max. process+thread count | 2516 (vs. ulimit of 12500) | | modules | C: hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1451/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-24132) Upgrade to Apache ZooKeeper 3.5.7
[ https://issues.apache.org/jira/browse/HBASE-24132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24132: - Assignee: Jianfei Jiang > Upgrade to Apache ZooKeeper 3.5.7 > - > > Key: HBASE-24132 > URL: https://issues.apache.org/jira/browse/HBASE-24132 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.3 >Reporter: Jianfei Jiang >Assignee: Jianfei Jiang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-24132_001.patch > > > Apache ZooKeeper 3.5.7 has been released, HDFS and other projects have > updated the dependent zookeeper verison. Perhaps Hbase may update as well. > Some of the interfaces are changed in this zookeeper version . -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24132) Upgrade to Apache ZooKeeper 3.5.7
[ https://issues.apache.org/jira/browse/HBASE-24132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077718#comment-17077718 ] Duo Zhang commented on HBASE-24132: --- Seems the zookeeper commuity has decided to EOL 3.4.x, so I'm +1 on moving to 3.5.x by default for the new release lines. [~jiangjianfei] Mind creating a PR for this? HBase uses github PR to review patch now. Make sure the title of the PR is started with the issue number, i.e., HBASE-24132. Thanks. > Upgrade to Apache ZooKeeper 3.5.7 > - > > Key: HBASE-24132 > URL: https://issues.apache.org/jira/browse/HBASE-24132 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.3 >Reporter: Jianfei Jiang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-24132_001.patch > > > Apache ZooKeeper 3.5.7 has been released, HDFS and other projects have > updated the dependent zookeeper verison. Perhaps Hbase may update as well. > Some of the interfaces are changed in this zookeeper version . -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24132) Upgrade to Apache ZooKeeper 3.5.7
[ https://issues.apache.org/jira/browse/HBASE-24132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24132: -- Fix Version/s: 2.3.0 3.0.0 > Upgrade to Apache ZooKeeper 3.5.7 > - > > Key: HBASE-24132 > URL: https://issues.apache.org/jira/browse/HBASE-24132 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.3 >Reporter: Jianfei Jiang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-24132_001.patch > > > Apache ZooKeeper 3.5.7 has been released, HDFS and other projects have > updated the dependent zookeeper verison. Perhaps Hbase may update as well. > Some of the interfaces are changed in this zookeeper version . -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1452: HBASE-24131 [Flakey Tests] TestExportSnapshot takes too long; up agai…
Apache-HBase commented on issue #1452: HBASE-24131 [Flakey Tests] TestExportSnapshot takes too long; up agai… URL: https://github.com/apache/hbase/pull/1452#issuecomment-610692214 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 8s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 19s | branch-2 passed | | +1 :green_heart: | spotbugs | 0m 44s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 33s | the patch passed | | +1 :green_heart: | checkstyle | 0m 18s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 36s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 0m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 34m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1452/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1452 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 28b153a445bb 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 953c326498 | | Max. process+thread count | 83 (vs. ulimit of 12500) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1452/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
huaxiangsun commented on a change in pull request #1441: HBASE-24120 Flakey
Test: TestReplicationAdminWithClusters timeout
URL: https://github.com/apache/hbase/pull/1441#discussion_r405195387
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##
@@ -579,8 +579,8 @@ private void
interruptOrAbortWhenFail(ReplicationQueueOperation op) {
if (e.getCause() != null && e.getCause() instanceof
KeeperException.SystemErrorException
Review comment:
missed this comment, will me get back.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] huaxiangsun commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout
huaxiangsun commented on issue #1441: HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout URL: https://github.com/apache/hbase/pull/1441#issuecomment-610689469 @Apache9 @ndimiduk @saintstack I updated the patch based on Duo's comments. Manually throws out ReplicationException with cause as IntteruptedException in ZKReplicationQueueStorage#setWALPosition to make sure the path exercised as expected. Please review. Going to address the other issue separately. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24115) Relocate test-only REST "client" from src/ to test/ and mark Private
[
https://issues.apache.org/jira/browse/HBASE-24115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077711#comment-17077711
]
Hudson commented on HBASE-24115:
Results for branch branch-2.2
[build #833 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/833/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/833//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/833//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/833//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Relocate test-only REST "client" from src/ to test/ and mark Private
>
>
> Key: HBASE-24115
> URL: https://issues.apache.org/jira/browse/HBASE-24115
> Project: HBase
> Issue Type: Test
> Components: REST, security
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0, 2.3.1, 1.3.7, 1.7.0, 2.4.0, 2.1.10, 1.4.14, 2.2.5
>
>
> Relocate test-only REST "client" from src/ to test/ and annotate as Private.
> The classes o.a.h.h.rest.Remote* were developed to facilitate REST unit tests
> and incorrectly committed to src/ .
> Although this "breaks" compatibility by moving public classes to test jar and
> marking them private, no attention has been paid to these classes with
> respect to performance, convenience, or security. Consensus from various
> discussions over the years is to move them to test/ as was intent of the
> original committer, but misplaced by the same individual.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24077) When encounter RowTooBigException, log the row info.
[
https://issues.apache.org/jira/browse/HBASE-24077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077712#comment-17077712
]
Hudson commented on HBASE-24077:
Results for branch branch-2.2
[build #833 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/833/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/833//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/833//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/833//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> When encounter RowTooBigException, log the row info.
>
>
> Key: HBASE-24077
> URL: https://issues.apache.org/jira/browse/HBASE-24077
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.2.4
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> Current when we encounter a big row and throw RowTooBigException, there is no
> information about the row, it hard to debug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock
Apache-HBase commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock URL: https://github.com/apache/hbase/pull/1407#issuecomment-610688626 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 19s | master passed | | +1 :green_heart: | checkstyle | 1m 19s | master passed | | +1 :green_heart: | spotbugs | 2m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 40s | the patch passed | | +1 :green_heart: | checkstyle | 1m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 41s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 39m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1407/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1407 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 29fb98bfd755 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1407/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24055) Make AsyncFSWAL can run on EC cluster
[
https://issues.apache.org/jira/browse/HBASE-24055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077701#comment-17077701
]
Hudson commented on HBASE-24055:
Results for branch branch-2
[build #2589 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make AsyncFSWAL can run on EC cluster
> -
>
> Key: HBASE-24055
> URL: https://issues.apache.org/jira/browse/HBASE-24055
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> We need to enable replicate when creating the file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24126) Up the container nproc uplimit from 10000 to 12500
[
https://issues.apache.org/jira/browse/HBASE-24126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077704#comment-17077704
]
Hudson commented on HBASE-24126:
Results for branch branch-2
[build #2589 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Up the container nproc uplimit from 1 to 12500
> --
>
> Key: HBASE-24126
> URL: https://issues.apache.org/jira/browse/HBASE-24126
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Michael Stack
>Priority: Major
> Attachments:
> 0001-HBASE-24126-Up-the-container-nproc-uplimit-from-1000.patch
>
>
> Let me up the container nproc count from 1. If many tests running in
> parallel, container could breach the 1 limit: i.e. if a bunch of
> heavy-duty long tests run at same time (0.5C on a 16CPU machine means 8
> possible concurrents) and we spin up 1-2000 threads in each test, then could
> hit the 1 limit. Move up the limit some expecially after INFRA just upped
> our limit to 3.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24130) rat plugin complains about having an unlicensed file.
[
https://issues.apache.org/jira/browse/HBASE-24130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077702#comment-17077702
]
Hudson commented on HBASE-24130:
Results for branch branch-2
[build #2589 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> rat plugin complains about having an unlicensed file.
> -
>
> Key: HBASE-24130
> URL: https://issues.apache.org/jira/browse/HBASE-24130
> Project: HBase
> Issue Type: Bug
>Reporter: Minwoo Kang
>Assignee: Minwoo Kang
>Priority: Minor
> Fix For: 3.0.0, 1.7.0, 2.4.0
>
>
> Files with unapproved licenses:
> dev-support/HOW_TO_YETUS_LOCAL.md
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24128) [Flakey Tests] Add retry on thrift cmdline if client fails plus misc debug
[
https://issues.apache.org/jira/browse/HBASE-24128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077703#comment-17077703
]
Hudson commented on HBASE-24128:
Results for branch branch-2
[build #2589 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] Add retry on thrift cmdline if client fails plus misc debug
> --
>
> Key: HBASE-24128
> URL: https://issues.apache.org/jira/browse/HBASE-24128
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> {code}
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java
> Saw case where Master failed startup because of BindException but it
> came out wrapped
> in an IOE so we did not trip the BindException retry logic. Make the
> catch more general.
> hbase-server/src/test/java/org/apache/hadoop/hbase/TestInfoServers.java
> Add some debug and up timeouts. This test fails frequently for me
> locally.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/locking/TestEntityLocks.java
> Up the wait from 2x 200ms to 10x in case a pause on hardware or GC.
> This test fails locally and up on jenkins.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestClearRegionBlockCache.java
> Debug. Have assert say what bad count was.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingToCellFlatMapMemStore.java
> Fails on occasion. Found count is off by a few. Tricky to debug. Adding
> sub-issue to reenable.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java
> Debug. Add wait and check before moving to assert.
>
> hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java
> Check for null before shutting; can be null if failed start.
>
> hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
> Add retry if client messes up connection. Fails for me locally.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24072) Nightlies reporting OutOfMemoryError: unable to create new native thread
[
https://issues.apache.org/jira/browse/HBASE-24072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077700#comment-17077700
]
Hudson commented on HBASE-24072:
Results for branch branch-2
[build #2589 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2589/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Nightlies reporting OutOfMemoryError: unable to create new native thread
>
>
> Key: HBASE-24072
> URL: https://issues.apache.org/jira/browse/HBASE-24072
> Project: HBase
> Issue Type: Task
> Components: test
>Reporter: Michael Stack
>Priority: Major
> Attachments:
> 0001-HBASE-24072-Nightlies-reporting-OutOfMemoryError-una.patch,
> print_ulimit.patch
>
>
> Seeing this kind of thing in nightly...
> {code}
> java.lang.RuntimeException: java.lang.OutOfMemoryError: unable to create new
> native thread
> at
> org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.beforeClass(TestMultithreadedTableMapper.java:83)
> Caused by: java.lang.OutOfMemoryError: unable to create new native thread
> at
> org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.beforeClass(TestMultithreadedTableMapper.java:83)
> {code}
> Chatting w/ Nick and Huaxiang, doing the math, we are likely oversubscribing
> our docker container. It is set to 20G (The hosts are 48G). Fork count is
> 0.5C on a 16 CPU machine which is 8 *2.8G our current forked jvm size. Add
> the maven 4G and we could be over the top.
> Play w/ downing the fork size (in earlier study we didn't seem to need this
> much RAM when running a fat long test). Let me also take th ms off the mvn
> allocation to see if that helps.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1446: HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone
Apache-HBase commented on issue #1446: HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone URL: https://github.com/apache/hbase/pull/1446#issuecomment-610683968 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 19s | master passed | | +1 :green_heart: | compile | 1m 15s | master passed | | +1 :green_heart: | shadedjars | 4m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 0s | the patch passed | | +1 :green_heart: | compile | 1m 15s | the patch passed | | +1 :green_heart: | javac | 1m 15s | the patch passed | | +1 :green_heart: | shadedjars | 4m 31s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 35s | hbase-server generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 14s | hbase-common in the patch passed. | | -1 :x: | unit | 146m 33s | hbase-server in the patch failed. | | | | 175m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1446 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a602cd26325c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Default Java | 1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/testReport/ | | Max. process+thread count | 3688 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack opened a new pull request #1452: HBASE-24131 [Flakey Tests] TestExportSnapshot takes too long; up agai…
saintstack opened a new pull request #1452: HBASE-24131 [Flakey Tests] TestExportSnapshot takes too long; up agai… URL: https://github.com/apache/hbase/pull/1452 …nst 13min max Split TestExportSnapshot and TestVerifyReplication to two smaller tests rather than one big one that can take 13minutes+ when contention. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1446: HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone
Apache-HBase commented on issue #1446: HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone URL: https://github.com/apache/hbase/pull/1446#issuecomment-610680394 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 33s | master passed | | +1 :green_heart: | compile | 1m 44s | master passed | | +1 :green_heart: | shadedjars | 6m 34s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-common in master failed. | | -0 :warning: | javadoc | 0m 47s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 14s | the patch passed | | +1 :green_heart: | compile | 1m 47s | the patch passed | | +1 :green_heart: | javac | 1m 47s | the patch passed | | +1 :green_heart: | shadedjars | 6m 30s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 45s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 42s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 123m 18s | hbase-server in the patch passed. | | | | 162m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1446 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5aa46d1548da 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/testReport/ | | Max. process+thread count | 3727 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1446/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] liuml07 commented on a change in pull request #1435: HBASE-24112 [RSGroup] Support renaming rsgroup
liuml07 commented on a change in pull request #1435: HBASE-24112 [RSGroup]
Support renaming rsgroup
URL: https://github.com/apache/hbase/pull/1435#discussion_r405182537
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin1.java
##
@@ -468,4 +468,31 @@ public boolean evaluate() throws Exception {
// Cleanup
TEST_UTIL.deleteTable(tn1);
}
+
+ @Test
+ public void testRenameRSGroup() throws Exception {
+// Add rsgroup, and assign 2 servers and a table to it.
+RSGroupInfo oldgroup = addGroup("oldgroup", 2);
+TableName tb = TableName.valueOf("testRename");
+TEST_UTIL.createTable(tb, "tr");
+ADMIN.setRSGroup(Sets.newHashSet(tb), oldgroup.getName());
+Thread.sleep(500);
+oldgroup = ADMIN.getRSGroup(oldgroup.getName());
+assertEquals(2, oldgroup.getServers().size());
+assertEquals(oldgroup.getName(), ADMIN.getRSGroup(tb).getName());
+
+// Rename rsgroup
+ADMIN.renameRSGroup(oldgroup.getName(), "newgroup");
+Set servers = oldgroup.getServers();
+RSGroupInfo newgroup = ADMIN.getRSGroup("newgroup");
+assertEquals(servers.size(), newgroup.getServers().size());
+int match = 0;
+for (Address addr : newgroup.getServers()) {
+ if (servers.contains(addr)) {
+match++;
+ }
+}
+assertEquals(servers.size(), match);
Review comment:
Yes I agree this is useful assertion.
Actually I was wondering if we can add more context to this test as well as
assertions. For example, we create and assign another table to another rsgroup.
So the "if" clause checking rsgroup name in `RSGroupInfoManagerImpl.java` will
get tested. Otherwise this test may still pass even when we remove the "if". By
the "if" I mean:
```
if (rsgroup.get().equals(oldName)) {
updateTables.add(table.getValue().getTableName());
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (HBASE-24136) Add release branch report to git-jira-release-audit tool
Nick Dimiduk created HBASE-24136:
Summary: Add release branch report to git-jira-release-audit tool
Key: HBASE-24136
URL: https://issues.apache.org/jira/browse/HBASE-24136
Project: HBase
Issue Type: Improvement
Reporter: Nick Dimiduk
Assignee: Nick Dimiduk
Update {{git-jira-release-audit}} to build a "what's new" report for a release
branch (i.e., {{branch-2.3}}). Currently it only supports building such a
report from a release line branch (i.e., {{branch-2}}).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] liuml07 commented on a change in pull request #1435: HBASE-24112 [RSGroup] Support renaming rsgroup
liuml07 commented on a change in pull request #1435: HBASE-24112 [RSGroup]
Support renaming rsgroup
URL: https://github.com/apache/hbase/pull/1435#discussion_r405178082
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##
@@ -1221,4 +1221,32 @@ public String determineRSGroupInfoForTable(TableName
tableName) {
return script.getRSGroup(tableName.getNamespaceAsString(),
tableName.getQualifierAsString());
}
+ @Override
+ public synchronized void renameRSGroup(String oldName, String newName)
throws IOException {
+if (oldName.equals(RSGroupInfo.DEFAULT_GROUP)) {
+ throw new ConstraintException(RSGroupInfo.DEFAULT_GROUP + " can't be
rename");
+}
+checkGroupName(newName);
+
+RSGroupInfo oldRSG = getRSGroupInfo(oldName);
+Map rsGroupMap = holder.groupName2Group;
+Map newGroupMap = Maps.newHashMap(rsGroupMap);
+newGroupMap.remove(oldRSG.getName());
+RSGroupInfo newRSG = new RSGroupInfo(newName, oldRSG.getServers());
+newGroupMap.put(newName, newRSG);
+flushConfig(newGroupMap);
+Set updateTables = new HashSet<>();
Review comment:
```
Set updateTables = new HashSet<>();
TableDescriptors tableDescriptors = masterServices.getTableDescriptors();
for (Map.Entry table :
tableDescriptors.getAll().entrySet()) {
Optional rsgroup = table.getValue().getRegionServerGroup();
if (!rsgroup.isPresent()) {
continue;
}
if (rsgroup.get().equals(oldName)) {
updateTables.add(table.getValue().getTableName());
}
}
```
can be replaced with, if stream is preferred, following code (not tested):
```
Set updateTables =
masterServices.getTableDescriptors().getAll().values()
.stream()
.filter(t -> oldName.equals(t.getRegionServerGroup().orElse(null)))
.map(TableDescriptor::getTableName)
.collect(Collectors.toSet());
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] apurtell edited a comment on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock
apurtell edited a comment on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock URL: https://github.com/apache/hbase/pull/1407#issuecomment-610671724 I also think variance makes it challenging to discern signal here. I was hoping for a slam dunk "no regression, see it's all in the noise" result and didn't quite get that but believe sufficient diligence and corresponding results allow us to move forward. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell edited a comment on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock
apurtell edited a comment on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock URL: https://github.com/apache/hbase/pull/1407#issuecomment-610671550 > I don't see how a scan workload differs from a mix of get/put w.r.t to contention on this lock I think the difference is a scan will run longer than point lookup so probability of threads concurrently acquiring the lock is higher. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock
apurtell commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock URL: https://github.com/apache/hbase/pull/1407#issuecomment-610672071 Over on the JIRA @Reidd requested we leave a config toggle in place, so let me do that but set the default to 'true'. Will push up a final version shortly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock
apurtell commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock URL: https://github.com/apache/hbase/pull/1407#issuecomment-610671724 I also think variance makes it challenging to discern signal here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24131) [Flakey Tests] TestExportSnapshot takes too long; up against 13min max
[ https://issues.apache.org/jira/browse/HBASE-24131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077665#comment-17077665 ] Michael Stack commented on HBASE-24131: --- Hmmm. Running standalone I see that the full TestExportSnapshot can take a short as 3minutes and a few seconds. Guessing then that its access to system resources that slows us down. Let me see if split helps. > [Flakey Tests] TestExportSnapshot takes too long; up against 13min max > -- > > Key: HBASE-24131 > URL: https://issues.apache.org/jira/browse/HBASE-24131 > Project: HBase > Issue Type: Bug >Reporter: Michael Stack >Priority: Major > > TestExportSnapshot fails fairly regularly locally. Looking, its test timeout. > Looking at how long it ran, its 13minutes plus. Looking at recent successful > branch-2 run, it passed but it took about 7-8minutes. Let me break up the > test into to pieces. > org.junit.runners.model.TestTimedOutException: test timed out after 780 > seconds >at > org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:227) >at > org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportRetry(TestExportSnapshot.java:267) > ... I see this in the log: > > TEST TIMED OUT. PRINTING THREAD DUMP. < > Test started at: > 2020-04-06 17:19:21,739 INFO > ... and the timestamp just above the TIMED OUT was > 2020-04-06 17:31:01,758 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] apurtell commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock
apurtell commented on issue #1407: HBASE-24099 Use a fair ReentrantReadWriteLock for region close lock URL: https://github.com/apache/hbase/pull/1407#issuecomment-610671550 bq. I don't see how a scan workload differs from a mix of get/put w.r.t to contention on this lock I think the difference is a scan will run longer than point lookup so probability of threads concurrently acquiring the lock is higher. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-13428) [DOC] Migration to hbase-2.0.0
[ https://issues.apache.org/jira/browse/HBASE-13428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-13428: - Fix Version/s: (was: 2.3.0) (was: 3.0.0) Dropping fixVersions as no commit bears this jira id. > [DOC] Migration to hbase-2.0.0 > -- > > Key: HBASE-13428 > URL: https://issues.apache.org/jira/browse/HBASE-13428 > Project: HBase > Issue Type: Umbrella > Components: migration >Reporter: Michael Stack >Priority: Blocker > > Opening a 2.0 umbrella migration issue. Lets hang off this one any tools and > expectations migrating from 1.0 (or earlier) to 2.0. So far there are none > that I know of though there is an expectation in HBASE-13373 that hfiles are > at least major version 2 and minor version 3. Lets list all such > expectations, etc., here. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-20188) Evaluate and address performance delta between branch-1 and branch-2
[ https://issues.apache.org/jira/browse/HBASE-20188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-20188: - Fix Version/s: (was: 2.3.0) (was: 3.0.0) Dropping fixVersions as no commit bears this issue id. > Evaluate and address performance delta between branch-1 and branch-2 > > > Key: HBASE-20188 > URL: https://issues.apache.org/jira/browse/HBASE-20188 > Project: HBase > Issue Type: Umbrella > Components: Performance >Reporter: Michael Stack >Priority: Blocker > Attachments: CAM-CONFIG-V01.patch, HBASE-20188-xac.sh, > HBASE-20188.sh, HBase 2.0 performance evaluation - 8GB(1).pdf, HBase 2.0 > performance evaluation - 8GB.pdf, HBase 2.0 performance evaluation - Basic vs > None_ system settings.pdf, HBase 2.0 performance evaluation - throughput > SSD_HDD.pdf, ITBLL2.5B_1.2.7vs2.0.0_cpu.png, > ITBLL2.5B_1.2.7vs2.0.0_gctime.png, ITBLL2.5B_1.2.7vs2.0.0_iops.png, > ITBLL2.5B_1.2.7vs2.0.0_load.png, ITBLL2.5B_1.2.7vs2.0.0_memheap.png, > ITBLL2.5B_1.2.7vs2.0.0_memstore.png, ITBLL2.5B_1.2.7vs2.0.0_ops.png, > ITBLL2.5B_1.2.7vs2.0.0_ops_NOT_summing_regions.png, YCSB_CPU.png, > YCSB_GC_TIME.png, YCSB_IN_MEMORY_COMPACTION=NONE.ops.png, YCSB_MEMSTORE.png, > YCSB_OPs.png, YCSB_in-memory-compaction=NONE.ops.png, YCSB_load.png, > flamegraph-1072.1.svg, flamegraph-1072.2.svg, hbase-env.sh, hbase-site.xml, > hbase-site.xml, hits.png, hits_with_fp_scheduler.png, > lock.127.workloadc.20180402T200918Z.svg, > lock.2.memsize2.c.20180403T160257Z.svg, perregion.png, run_ycsb.sh, > total.png, tree.txt, workloadx, workloadx > > > How does 2.0.0 compare to old versions? Is it faster, slower? There is rumor > that it is much slower, that the problem is the asyncwal writing. Does > in-memory compaction slow us down or speed us up? What happens when you > enable offheaping? > Keep notes here in this umbrella issue. Need to be able to say something > about perf when 2.0.0 ships. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-20188) Evaluate and address performance delta between branch-1 and branch-2
[ https://issues.apache.org/jira/browse/HBASE-20188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-20188: - Summary: Evaluate and address performance delta between branch-1 and branch-2 (was: [TESTING] Performance) > Evaluate and address performance delta between branch-1 and branch-2 > > > Key: HBASE-20188 > URL: https://issues.apache.org/jira/browse/HBASE-20188 > Project: HBase > Issue Type: Umbrella > Components: Performance >Reporter: Michael Stack >Priority: Blocker > Fix For: 3.0.0, 2.3.0 > > Attachments: CAM-CONFIG-V01.patch, HBASE-20188-xac.sh, > HBASE-20188.sh, HBase 2.0 performance evaluation - 8GB(1).pdf, HBase 2.0 > performance evaluation - 8GB.pdf, HBase 2.0 performance evaluation - Basic vs > None_ system settings.pdf, HBase 2.0 performance evaluation - throughput > SSD_HDD.pdf, ITBLL2.5B_1.2.7vs2.0.0_cpu.png, > ITBLL2.5B_1.2.7vs2.0.0_gctime.png, ITBLL2.5B_1.2.7vs2.0.0_iops.png, > ITBLL2.5B_1.2.7vs2.0.0_load.png, ITBLL2.5B_1.2.7vs2.0.0_memheap.png, > ITBLL2.5B_1.2.7vs2.0.0_memstore.png, ITBLL2.5B_1.2.7vs2.0.0_ops.png, > ITBLL2.5B_1.2.7vs2.0.0_ops_NOT_summing_regions.png, YCSB_CPU.png, > YCSB_GC_TIME.png, YCSB_IN_MEMORY_COMPACTION=NONE.ops.png, YCSB_MEMSTORE.png, > YCSB_OPs.png, YCSB_in-memory-compaction=NONE.ops.png, YCSB_load.png, > flamegraph-1072.1.svg, flamegraph-1072.2.svg, hbase-env.sh, hbase-site.xml, > hbase-site.xml, hits.png, hits_with_fp_scheduler.png, > lock.127.workloadc.20180402T200918Z.svg, > lock.2.memsize2.c.20180403T160257Z.svg, perregion.png, run_ycsb.sh, > total.png, tree.txt, workloadx, workloadx > > > How does 2.0.0 compare to old versions? Is it faster, slower? There is rumor > that it is much slower, that the problem is the asyncwal writing. Does > in-memory compaction slow us down or speed us up? What happens when you > enable offheaping? > Keep notes here in this umbrella issue. Need to be able to say something > about perf when 2.0.0 ships. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-22677) Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and org.apache.hadoop.hbase.util.Classes
[ https://issues.apache.org/jira/browse/HBASE-22677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-22677: Assignee: Eric Hettiaratchi > Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and > org.apache.hadoop.hbase.util.Classes > --- > > Key: HBASE-22677 > URL: https://issues.apache.org/jira/browse/HBASE-22677 > Project: HBase > Issue Type: Improvement > Components: java, test > Environment: Junit >Reporter: Eric Hettiaratchi >Assignee: Eric Hettiaratchi >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > > I've analysed your codebase and noticed that > org.apache.hadoop.hbase.util.ByteRangeUtils and Classes is not fully tested. > I've written some tests for the methods in this class with the help of > Diffblue Cover. > Hopefully, these tests will help you detect any regressions caused by future > code changes. If you would find it useful to have additional tests written > for this repository, I would be more than happy to look at other classes that > you consider important in a subsequent PR. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22936) Close memStoreScanners in StoreScanner#updateReaders else memory leak
[
https://issues.apache.org/jira/browse/HBASE-22936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-22936:
-
Fix Version/s: (was: 2.2.2)
(was: 2.1.7)
(was: 2.3.0)
Looks like this one was resolved by HBASE-22929, so dropping fixVersions.
> Close memStoreScanners in StoreScanner#updateReaders else memory leak
> -
>
> Key: HBASE-22936
> URL: https://issues.apache.org/jira/browse/HBASE-22936
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
>
> Via [~aoxiang] from over on HBASE-22723
> {code}
> + if (!closeLock.tryLock()) {
> +// no lock acquired.
> +LOG.debug("StoreScanner already has the close lokc. There is no need
> to updateReaders");
> +return;
> + }
> + // lock acquired
> + updateReaders = true;
> + if (this.closing) {
> +LOG.debug("StoreScanner already closing. There is no need to
> updateReaders");
> +return;
> + }
> {code}
> We need to close memStoreScanners in StoreScanner#updateReaders before this
> two return, someone else can take over the task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-24041) [regression] Increase RESTServer buffer size back to 64k
[
https://issues.apache.org/jira/browse/HBASE-24041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk reassigned HBASE-24041:
Assignee: Esteban Gutierrez
> [regression] Increase RESTServer buffer size back to 64k
> -
>
> Key: HBASE-24041
> URL: https://issues.apache.org/jira/browse/HBASE-24041
> Project: HBase
> Issue Type: Bug
> Components: REST
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.4.0
>Reporter: Esteban Gutierrez
>Assignee: Esteban Gutierrez
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.4.0, 2.2.5
>
>
> HBASE-14492 is not longer present in our current releases after HBASE-12894.
> Unfortunately our RESTServer is not extending HttpServer which means that
> {{DEFAULT_MAX_HEADER_SIZE}} is not being set and HTTP requests with a very
> large header can still cause connection issues for clients. A quick fix is
> just to add the settings to the {{HttpConfiguration}} configuration object. A
> long term solution should be to re-factor services that create an HTTP server
> and normalize all configuration settings across all of them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-24001) The "HBase Nightly" job may exhaust all executors - and create a deadlock
[ https://issues.apache.org/jira/browse/HBASE-24001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-24001: Assignee: Michael Stack > The "HBase Nightly" job may exhaust all executors - and create a deadlock > - > > Key: HBASE-24001 > URL: https://issues.apache.org/jira/browse/HBASE-24001 > Project: HBase > Issue Type: Bug >Reporter: Zoltan Haindrich >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > What seems to happen is: > * the job needs more and more executors to run > * in case there are several of them launched in parallel (different branches) > say 5 > * they take up all available executors labeled "Hadoop" and then they wait > for more indefinetly > I've killed a few builds...see my notes here: > https://the-asf.slack.com/archives/C7M1AFYLS/p1584442366000900 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24099) Use a fair ReentrantReadWriteLock for the region close lock
[
https://issues.apache.org/jira/browse/HBASE-24099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077656#comment-17077656
]
Andrew Kyle Purtell commented on HBASE-24099:
-
I don't think there is a real scan penalty. What is happening is there is some
normal variance in the tests and the fair mode is _paradoxically *faster* _for
some cases.
Anyway sure [~reidchan] your request is very reasonable. I will leave the
config in the code, but set the default to 'true'. Let's also include a release
note.
Our [~bharathv] did some microbenchmarking of the difference between a RWL in
fair and-non fair mode and in his very simple case fair mode was observed to
outperform nonfair, which is... counter conventional wisdom. The nonfair case
contends on CAS and acquisition is not ordered; the fair case implements an
efficient FIFO queue and processes acquisitions in order. Benchmark results
establish that in some cases the queue is faster than the CAS.
> Use a fair ReentrantReadWriteLock for the region close lock
> ---
>
> Key: HBASE-24099
> URL: https://issues.apache.org/jira/browse/HBASE-24099
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0, 2.3.1, 1.3.7, 1.7.0, 2.4.0, 2.1.10, 1.4.14, 2.2.5
>
> Attachments: ltt_results.pdf, pe_results.pdf, ycsb_results.pdf
>
>
> Consider creating the region's ReentrantReadWriteLock with the fair locking
> policy. We have had a couple of production incidents where a regionserver
> stalled in shutdown for a very very long time, leading to RIT (FAILED_CLOSE).
> The latest example is a 43 minute shutdown, ~40 minutes (2465280 ms) of that
> time was spent waiting to acquire the write lock on the region in order to
> finish closing it.
> {quote}
> ...
> Finished memstore flush of ~66.92 MB/70167112, currentsize=0 B/0 for region
> . in 927ms, sequenceid=6091133815, compaction requested=false at
> 1585175635349 (+60 ms)
> Disabling writes for close at 1585178100629 (+2465280 ms)
> {quote}
> This time was spent in between the memstore flush and the task status change
> "Disabling writes for close at...". This is at HRegion.java:1481 in 1.3.6:
> {code}
> 1480: // block waiting for the lock for closing
> 1481: lock.writeLock().lock(); // FindBugs: Complains
> UL_UNRELEASED_LOCK_EXCEPTION_PATH but seems fine
> {code}
>
> The close lock is operating in unfair mode. The table in question is under
> constant high query load. When the close request was received, there were
> active readers. After the close request there were more active readers,
> near-continuous contention. Although the clients would receive
> RegionServerStoppingException and other error notifications, because the
> region could not be reassigned, they kept coming, region (re-)location would
> find the region still hosted on the stuck server. Finally the closing thread
> waiting for the write lock became no longer starved (by chance) after 40
> minutes.
> The ReentrantReadWriteLock javadoc is clear about the possibility of
> starvation when continuously contended: "_When constructed as non-fair (the
> default), the order of entry to the read and write lock is unspecified,
> subject to reentrancy constraints. A nonfair lock that is continuously
> contended may indefinitely postpone one or more reader or writer threads, but
> will normally have higher throughput than a fair lock._"
> We could try changing the acquisition semantics of this lock to fair. This is
> a one line change, where we call the RW lock constructor. Then:
> "_When constructed as fair, threads contend for entry using an approximately
> arrival-order policy. When the currently held lock is released, either the
> longest-waiting single writer thread will be assigned the write lock, or if
> there is a group of reader threads waiting longer than all waiting writer
> threads, that group will be assigned the read lock._"
> This could be better. The close process will have to wait until all readers
> and writers already waiting for acquisition either acquire and release or go
> away but won't be starved by future/incoming requests.
> There could be a throughput loss in request handling, though, because this is
> the global reentrant RW lock for the region.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24099) Use a fair ReentrantReadWriteLock for the region close lock
[
https://issues.apache.org/jira/browse/HBASE-24099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077656#comment-17077656
]
Andrew Kyle Purtell edited comment on HBASE-24099 at 4/7/20, 11:25 PM:
---
I don't think there is a real scan penalty.
Anyway sure [~reidchan] your request is very reasonable. I will leave the
config in the code, but set the default to 'true'. Let's also include a release
note.
Our [~bharathv] did some microbenchmarking of the difference between a RWL in
fair and-non fair mode and in his very simple case fair mode was observed to
outperform nonfair, which is... counter conventional wisdom. The nonfair case
contends on CAS and acquisition is not ordered; the fair case implements an
efficient FIFO queue and processes acquisitions in order. Benchmark results
establish that in some cases the queue is faster than the CAS.
was (Author: apurtell):
I don't think there is a real scan penalty. What is happening is there is some
normal variance in the tests and the fair mode is _paradoxically *faster* _for
some cases.
Anyway sure [~reidchan] your request is very reasonable. I will leave the
config in the code, but set the default to 'true'. Let's also include a release
note.
Our [~bharathv] did some microbenchmarking of the difference between a RWL in
fair and-non fair mode and in his very simple case fair mode was observed to
outperform nonfair, which is... counter conventional wisdom. The nonfair case
contends on CAS and acquisition is not ordered; the fair case implements an
efficient FIFO queue and processes acquisitions in order. Benchmark results
establish that in some cases the queue is faster than the CAS.
> Use a fair ReentrantReadWriteLock for the region close lock
> ---
>
> Key: HBASE-24099
> URL: https://issues.apache.org/jira/browse/HBASE-24099
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0, 2.3.1, 1.3.7, 1.7.0, 2.4.0, 2.1.10, 1.4.14, 2.2.5
>
> Attachments: ltt_results.pdf, pe_results.pdf, ycsb_results.pdf
>
>
> Consider creating the region's ReentrantReadWriteLock with the fair locking
> policy. We have had a couple of production incidents where a regionserver
> stalled in shutdown for a very very long time, leading to RIT (FAILED_CLOSE).
> The latest example is a 43 minute shutdown, ~40 minutes (2465280 ms) of that
> time was spent waiting to acquire the write lock on the region in order to
> finish closing it.
> {quote}
> ...
> Finished memstore flush of ~66.92 MB/70167112, currentsize=0 B/0 for region
> . in 927ms, sequenceid=6091133815, compaction requested=false at
> 1585175635349 (+60 ms)
> Disabling writes for close at 1585178100629 (+2465280 ms)
> {quote}
> This time was spent in between the memstore flush and the task status change
> "Disabling writes for close at...". This is at HRegion.java:1481 in 1.3.6:
> {code}
> 1480: // block waiting for the lock for closing
> 1481: lock.writeLock().lock(); // FindBugs: Complains
> UL_UNRELEASED_LOCK_EXCEPTION_PATH but seems fine
> {code}
>
> The close lock is operating in unfair mode. The table in question is under
> constant high query load. When the close request was received, there were
> active readers. After the close request there were more active readers,
> near-continuous contention. Although the clients would receive
> RegionServerStoppingException and other error notifications, because the
> region could not be reassigned, they kept coming, region (re-)location would
> find the region still hosted on the stuck server. Finally the closing thread
> waiting for the write lock became no longer starved (by chance) after 40
> minutes.
> The ReentrantReadWriteLock javadoc is clear about the possibility of
> starvation when continuously contended: "_When constructed as non-fair (the
> default), the order of entry to the read and write lock is unspecified,
> subject to reentrancy constraints. A nonfair lock that is continuously
> contended may indefinitely postpone one or more reader or writer threads, but
> will normally have higher throughput than a fair lock._"
> We could try changing the acquisition semantics of this lock to fair. This is
> a one line change, where we call the RW lock constructor. Then:
> "_When constructed as fair, threads contend for entry using an approximately
> arrival-order policy. When the currently held lock is released, either the
> longest-waiting single writer thread will be assigned the write lock, or if
> there is a group of reader threads waiting longer than all waiting writer
> threads, that group will be assigned the read lock._"
> This could be better. The close process
[jira] [Resolved] (HBASE-24068) [Flakey Tests] TestServerSideScanMetricsFromClientSide and NullPointerException
[
https://issues.apache.org/jira/browse/HBASE-24068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk resolved HBASE-24068.
--
Resolution: Fixed
> [Flakey Tests] TestServerSideScanMetricsFromClientSide and
> NullPointerException
> ---
>
> Key: HBASE-24068
> URL: https://issues.apache.org/jira/browse/HBASE-24068
> Project: HBase
> Issue Type: Test
> Components: flakies
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> This fails for me locally sporadically.
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> ---
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.893 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetricWithAsync
> Time elapsed: 0.325 s <<< ERROR!
> java.lang.NullPointerException
> {code}
> Log pinpoints the problem a little better
> {code}
> Exception in thread "testTable.asyncPrefetcher"
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:183)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> 2020-03-26 22:18:15,160 ERROR [Listener at localhost/53268]
> hbase.TestServerSideScanMetricsFromClientSide(202): FAIL
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> {code}
> It didn't make sense to me since complaint was about a 'lock' that is created
> as a final data member. But then this issue happened for my compañero,
> [~ndimiduk]... and he saw that the call is from a Thread inner class in this
> class's grandparent that is set running on construction; i.e. the lock
> *could* be null at the time of reference.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24068) [Flakey Tests] TestServerSideScanMetricsFromClientSide and NullPointerException
[
https://issues.apache.org/jira/browse/HBASE-24068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-24068:
-
Fix Version/s: (was: 2.3.0)
(was: 3.0.0)
> [Flakey Tests] TestServerSideScanMetricsFromClientSide and
> NullPointerException
> ---
>
> Key: HBASE-24068
> URL: https://issues.apache.org/jira/browse/HBASE-24068
> Project: HBase
> Issue Type: Test
> Components: flakies
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
>
> This fails for me locally sporadically.
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> ---
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.893 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetricWithAsync
> Time elapsed: 0.325 s <<< ERROR!
> java.lang.NullPointerException
> {code}
> Log pinpoints the problem a little better
> {code}
> Exception in thread "testTable.asyncPrefetcher"
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:183)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> 2020-03-26 22:18:15,160 ERROR [Listener at localhost/53268]
> hbase.TestServerSideScanMetricsFromClientSide(202): FAIL
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> {code}
> It didn't make sense to me since complaint was about a 'lock' that is created
> as a final data member. But then this issue happened for my compañero,
> [~ndimiduk]... and he saw that the call is from a Thread inner class in this
> class's grandparent that is set running on construction; i.e. the lock
> *could* be null at the time of reference.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24068) [Flakey Tests] TestServerSideScanMetricsFromClientSide and NullPointerException
[
https://issues.apache.org/jira/browse/HBASE-24068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077655#comment-17077655
]
Nick Dimiduk commented on HBASE-24068:
--
Oh sorry. I see it was resolved by way of HBASE-24079. It's PR is still open.
Mind closing that one if you've got what you need from it?
> [Flakey Tests] TestServerSideScanMetricsFromClientSide and
> NullPointerException
> ---
>
> Key: HBASE-24068
> URL: https://issues.apache.org/jira/browse/HBASE-24068
> Project: HBase
> Issue Type: Test
> Components: flakies
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> This fails for me locally sporadically.
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> ---
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.893 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetricWithAsync
> Time elapsed: 0.325 s <<< ERROR!
> java.lang.NullPointerException
> {code}
> Log pinpoints the problem a little better
> {code}
> Exception in thread "testTable.asyncPrefetcher"
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:183)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> 2020-03-26 22:18:15,160 ERROR [Listener at localhost/53268]
> hbase.TestServerSideScanMetricsFromClientSide(202): FAIL
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> {code}
> It didn't make sense to me since complaint was about a 'lock' that is created
> as a final data member. But then this issue happened for my compañero,
> [~ndimiduk]... and he saw that the call is from a Thread inner class in this
> class's grandparent that is set running on construction; i.e. the lock
> *could* be null at the time of reference.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (HBASE-24068) [Flakey Tests] TestServerSideScanMetricsFromClientSide and NullPointerException
[
https://issues.apache.org/jira/browse/HBASE-24068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk reopened HBASE-24068:
--
Looks like this one was never committed boss.
> [Flakey Tests] TestServerSideScanMetricsFromClientSide and
> NullPointerException
> ---
>
> Key: HBASE-24068
> URL: https://issues.apache.org/jira/browse/HBASE-24068
> Project: HBase
> Issue Type: Test
> Components: flakies
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> This fails for me locally sporadically.
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> ---
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.893 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetricWithAsync
> Time elapsed: 0.325 s <<< ERROR!
> java.lang.NullPointerException
> {code}
> Log pinpoints the problem a little better
> {code}
> Exception in thread "testTable.asyncPrefetcher"
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:183)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> 2020-03-26 22:18:15,160 ERROR [Listener at localhost/53268]
> hbase.TestServerSideScanMetricsFromClientSide(202): FAIL
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> {code}
> It didn't make sense to me since complaint was about a 'lock' that is created
> as a final data member. But then this issue happened for my compañero,
> [~ndimiduk]... and he saw that the call is from a Thread inner class in this
> class's grandparent that is set running on construction; i.e. the lock
> *could* be null at the time of reference.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-24079) [Flakey Tests] Misc fixes and debug; fix BindException in Thrift tests; add waits on quota table to come online; etc.
[
https://issues.apache.org/jira/browse/HBASE-24079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk reassigned HBASE-24079:
Assignee: Michael Stack
> [Flakey Tests] Misc fixes and debug; fix BindException in Thrift tests; add
> waits on quota table to come online; etc.
> -
>
> Key: HBASE-24079
> URL: https://issues.apache.org/jira/browse/HBASE-24079
> Project: HBase
> Issue Type: Test
> Components: flakies
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Some fixes that have accumulated over last few days.
> Fixes for weird NPE on construction of ClientAsyncPrefetchScanner, catches
> for unexpected, test-killing exceptions in RSProcedureDispatcher and in
> CompactSplit; add waits on quota table to come on line and regionservers to
> go down before proceeding; add retry if BindException in thrift tests;
> disabled a few flakies; etc. Add some debug too.
> {code}
>
> hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java
> Refactor to avoid NPE timing issue referencing lock during Construction.
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
> Comment
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java
> Refactor. Catch NPE during startup and return it instead as failed
> initialization.
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
> Catch IndexOutOfBounds exception and convert to non-split request.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/TestCachedClusterId.java
> Make less furious. Make it less flakie.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java
> Debug. Catch exception to log, then rethrow.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java
> Guess that waiting longer on compaction to succeed may help make this
> less flakey.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java
> Be explicit about timestamping to avoid concurrent edit landing
> server-side and messing up test expectation.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMasterRegistry.java
> Add wait on meta before proceeding w/ test.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannersFromClientSide.java
> Be explicit that edits are distinct.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCacheRefCnt.java
> Add @Ignore on RAM test... Fails sporadically.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionMoveAndAbandon.java
> Add wait for all RegionServers going down before proceeding; was
> messing up RS accounting.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
> Make balancer test sloppier; less restrictive; would fail on occasion
> by being just outside test limits.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaObserverChoreRegionReports.java
> Add wait on quota table coming up; helps make this less flakie.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
> Be explicity about timestamps; see if helps w/ flakie failure.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java
> Catch and ignore if issue in shutdown; don't care if after test.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java
> Comment.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
> Add retry to see if helps w/ odd failure; grant hasn't propagated?
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java
> Explicit w/ timestamps so no accidental overlap of puts.
>
> hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java
>
> hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
> Hack to deal w/ BindException on startup.
>
> hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThrift2ServerCmdLine.java
> Use loopback.
>
> hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
> Disable flakie test.
> {code}
--
This message was sent by Atlassian Jira
[jira] [Assigned] (HBASE-24068) [Flakey Tests] TestServerSideScanMetricsFromClientSide and NullPointerException
[
https://issues.apache.org/jira/browse/HBASE-24068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk reassigned HBASE-24068:
Assignee: Michael Stack
> [Flakey Tests] TestServerSideScanMetricsFromClientSide and
> NullPointerException
> ---
>
> Key: HBASE-24068
> URL: https://issues.apache.org/jira/browse/HBASE-24068
> Project: HBase
> Issue Type: Bug
> Components: flakies
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> This fails for me locally sporadically.
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> ---
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.893 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetricWithAsync
> Time elapsed: 0.325 s <<< ERROR!
> java.lang.NullPointerException
> {code}
> Log pinpoints the problem a little better
> {code}
> Exception in thread "testTable.asyncPrefetcher"
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:183)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> 2020-03-26 22:18:15,160 ERROR [Listener at localhost/53268]
> hbase.TestServerSideScanMetricsFromClientSide(202): FAIL
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> {code}
> It didn't make sense to me since complaint was about a 'lock' that is created
> as a final data member. But then this issue happened for my compañero,
> [~ndimiduk]... and he saw that the call is from a Thread inner class in this
> class's grandparent that is set running on construction; i.e. the lock
> *could* be null at the time of reference.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24068) [Flakey Tests] TestServerSideScanMetricsFromClientSide and NullPointerException
[
https://issues.apache.org/jira/browse/HBASE-24068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-24068:
-
Issue Type: Test (was: Bug)
> [Flakey Tests] TestServerSideScanMetricsFromClientSide and
> NullPointerException
> ---
>
> Key: HBASE-24068
> URL: https://issues.apache.org/jira/browse/HBASE-24068
> Project: HBase
> Issue Type: Test
> Components: flakies
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> This fails for me locally sporadically.
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> ---
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.893 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetricWithAsync
> Time elapsed: 0.325 s <<< ERROR!
> java.lang.NullPointerException
> {code}
> Log pinpoints the problem a little better
> {code}
> Exception in thread "testTable.asyncPrefetcher"
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:183)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> 2020-03-26 22:18:15,160 ERROR [Listener at localhost/53268]
> hbase.TestServerSideScanMetricsFromClientSide(202): FAIL
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> {code}
> It didn't make sense to me since complaint was about a 'lock' that is created
> as a final data member. But then this issue happened for my compañero,
> [~ndimiduk]... and he saw that the call is from a Thread inner class in this
> class's grandparent that is set running on construction; i.e. the lock
> *could* be null at the time of reference.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 10000 to 12500
saintstack commented on issue #1450: HBASE-24126 Up the container nproc uplimit from 1 to 12500 URL: https://github.com/apache/hbase/pull/1450#issuecomment-610666383 Will merge this to master in morning unless objection. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an…
saintstack commented on issue #1451: HBASE-24134 Down forked JVM heap size from 2800m to 2200m for jdk8 an… URL: https://github.com/apache/hbase/pull/1451#issuecomment-610665476 Make a nothing change in pom.xml so we run all tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-15161) Umbrella: Miscellaneous improvements from production usage
[ https://issues.apache.org/jira/browse/HBASE-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-15161: - Issue Type: Improvement (was: Umbrella) > Umbrella: Miscellaneous improvements from production usage > -- > > Key: HBASE-15161 > URL: https://issues.apache.org/jira/browse/HBASE-15161 > Project: HBase > Issue Type: Improvement >Reporter: Yu Li >Assignee: Yu Li >Priority: Major > > We use HBase to (mainly) build index for our search engine in Alibaba. > Recently we are upgrading our online cluster from 0.98.12 to 1.x and I'd like > to take the opportunity to contribute a bunch of our private patches to > community (better late than never, I hope :-)). This is an umbrella to track > this effort. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-15161) Umbrella: Miscellaneous improvements from production usage
[ https://issues.apache.org/jira/browse/HBASE-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077626#comment-17077626 ] Nick Dimiduk commented on HBASE-15161: -- There's so much goodness hidden beneath this umbrella ticket. How about we get the doc update task in and put a bow on this one? > Umbrella: Miscellaneous improvements from production usage > -- > > Key: HBASE-15161 > URL: https://issues.apache.org/jira/browse/HBASE-15161 > Project: HBase > Issue Type: Umbrella >Reporter: Yu Li >Assignee: Yu Li >Priority: Major > > We use HBase to (mainly) build index for our search engine in Alibaba. > Recently we are upgrading our online cluster from 0.98.12 to 1.x and I'd like > to take the opportunity to contribute a bunch of our private patches to > community (better late than never, I hope :-)). This is an umbrella to track > this effort. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22707) [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore
[ https://issues.apache.org/jira/browse/HBASE-22707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-22707: - Issue Type: Improvement (was: Task) > [HBCK2] MasterRpcServices assigns method should try to reload regions from > meta if the passed regions isn't found under AssignmentManager > RegionsStateStore > --- > > Key: HBASE-22707 > URL: https://issues.apache.org/jira/browse/HBASE-22707 > Project: HBase > Issue Type: Improvement > Components: hbck2, master >Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5 >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: HBASE-22707.branch-2.001.patch, > HBASE-22707.branch-2.002.patch, HBASE-22707.master.001.patch > > > Although HBCK2 related, this is a master side improvement. On situations > where regions are missing in META, any online fix tool such as the one being > implemented in HBASE-22567 would require a further master restart to get > RegionsStateStore reloaded from META, so that master can be aware of the > newly re-added regions. > After regions are re-added to meta in CLOSED state, it should be possible to > bring those by simply invoking hbck2 _assigns_ command. But before > _MasterRpcServices.assigns_ submits an _Assign_ procedure, it validates first > if the given region is available on _AssignmentManager.RegionsStateStore_. > The current patch reloads meta on _MasterRpcServices.assigns_ if the given > region is not found on the first lookup, then try a new lookup again before > giving-up on region assignment. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1433: HBASE-24114 [Flakey Tests] TestSnapshotScannerHDFSAclController
Apache-HBase commented on issue #1433: HBASE-24114 [Flakey Tests] TestSnapshotScannerHDFSAclController URL: https://github.com/apache/hbase/pull/1433#issuecomment-610650522 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 0s | master passed | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | shadedjars | 5m 24s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 51s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 4m 53s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 176m 42s | hbase-server in the patch passed. | | | | 205m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1433/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1433 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 93fcfc41cd92 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 80d4a09ddc | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1433/2/testReport/ | | Max. process+thread count | 3216 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1433/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
