[GitHub] [hbase] Apache-HBase commented on issue #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile
Apache-HBase commented on issue #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile URL: https://github.com/apache/hbase/pull/1380#issuecomment-613854281 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 32s | master passed | | +1 :green_heart: | compile | 0m 55s | master passed | | +1 :green_heart: | shadedjars | 4m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 15s | the patch passed | | +1 :green_heart: | compile | 0m 53s | the patch passed | | +1 :green_heart: | javac | 0m 53s | the patch passed | | +1 :green_heart: | shadedjars | 4m 44s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 6m 12s | hbase-server in the patch failed. | | | | 27m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1380 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 20dea3484a62 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/testReport/ | | Max. process+thread count | 572 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer
Apache-HBase commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer URL: https://github.com/apache/hbase/pull/1514#issuecomment-613852637 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 14s | the patch passed | | +1 :green_heart: | compile | 0m 54s | the patch passed | | +1 :green_heart: | javac | 0m 54s | the patch passed | | +1 :green_heart: | shadedjars | 4m 40s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 117m 34s | hbase-server in the patch passed. | | | | 139m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1514 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f23df99253c4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/2/testReport/ | | Max. process+thread count | 4538 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] anoopsjohn commented on a change in pull request #1511: HBASE-24139 : Balancer should avoid leaving idle region servers
anoopsjohn commented on a change in pull request #1511: HBASE-24139 : Balancer
should avoid leaving idle region servers
URL: https://github.com/apache/hbase/pull/1511#discussion_r408617013
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##
@@ -310,6 +310,19 @@ protected synchronized boolean
areSomeRegionReplicasColocated(Cluster c) {
return false;
}
+ private synchronized boolean areThereIdleRegions(Cluster c){
+boolean isServerExistsWithMoreRegions=false;
+boolean isServerExistsWithZeroRegions=false;
+for (ServerName server:c.servers){
Review comment:
This is iterating over many data structures and complex. Why cant we just
iterate over the regionsPerServer data structure alone and populate the
booleans as needed?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] anoopsjohn commented on a change in pull request #1511: HBASE-24139 : Balancer should avoid leaving idle region servers
anoopsjohn commented on a change in pull request #1511: HBASE-24139 : Balancer
should avoid leaving idle region servers
URL: https://github.com/apache/hbase/pull/1511#discussion_r408615221
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##
@@ -310,6 +310,19 @@ protected synchronized boolean
areSomeRegionReplicasColocated(Cluster c) {
return false;
}
+ private synchronized boolean areThereIdleRegions(Cluster c){
Review comment:
Here it checks the status of RS. The name areThereIdleRegions not making
good meaning
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1520: [Back-port branch-2]: HBASE-24112 [RSGroup] Support renaming rsgroup
Apache-HBase commented on issue #1520: [Back-port branch-2]: HBASE-24112 [RSGroup] Support renaming rsgroup URL: https://github.com/apache/hbase/pull/1520#issuecomment-613841890 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 29s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 22s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 37s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 8s | the patch passed | | +1 :green_heart: | checkstyle | 1m 18s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 58s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | hbaseprotoc | 0m 59s | the patch passed | | +1 :green_heart: | spotbugs | 2m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 35m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1520/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1520 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux 1eb1d2f36b7f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 62a488b946 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1520/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HuiHang-Yu edited a comment on issue #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile
HuiHang-Yu edited a comment on issue #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile URL: https://github.com/apache/hbase/pull/1380#issuecomment-613837433 @Apache9 TestStoreFileInfo.java need to change a little after i put localstatus to construct . I will modify TestStoreFileInfo soon . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HuiHang-Yu commented on issue #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile
HuiHang-Yu commented on issue #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile URL: https://github.com/apache/hbase/pull/1380#issuecomment-613837433 @Apache9 TestStoreFileInfo.java need to change a little after i put localstatus to construct . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Gkkkk302 commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException
G302 commented on issue #1465: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1465#issuecomment-613834115 yes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Apache-HBase commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-613833502 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m 16s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 40s | branch-1 passed | | +1 :green_heart: | compile | 0m 46s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | compile | 0m 45s | branch-1 passed with JDK v1.7.0_252 | | +1 :green_heart: | checkstyle | 1m 39s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 40s | branch-1 passed with JDK v1.7.0_252 | | +0 :ok: | spotbugs | 3m 0s | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 :x: | findbugs | 2m 57s | hbase-server in branch-1 has 1 extant findbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 57s | the patch passed | | +1 :green_heart: | compile | 0m 44s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javac | 0m 44s | the patch passed | | +1 :green_heart: | compile | 0m 45s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | javac | 0m 45s | the patch passed | | +1 :green_heart: | checkstyle | 1m 34s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 53s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 4m 57s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 31s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 42s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | findbugs | 2m 58s | hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 129m 49s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 178m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1494 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b976b8aefc52 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1494/out/precommit/personality/provided.sh | | git revision | branch-1 / 03d73f1 | | Default Java | 1.7.0_252 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/5/artifact/out/branch-findbugs-hbase-server-warnings.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/5/testReport/ | | Max. process+thread count | 4769 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/5/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Ser
[GitHub] [hbase] Gkkkk302 commented on issue #1507: HBASE-24151 The master server aborted for IllegalThreadStateException
G302 commented on issue #1507: HBASE-24151 The master server aborted for IllegalThreadStateException URL: https://github.com/apache/hbase/pull/1507#issuecomment-613833460 @virajjasani Thanks for your reply. I think this problem has been conveniently fixed in the master branch. (HBASE-22971) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1478: HBASE-24137:The max merge count of metafixer may be remind in hbase-site.xml
Apache-HBase commented on issue #1478: HBASE-24137:The max merge count of metafixer may be remind in hbase-site.xml URL: https://github.com/apache/hbase/pull/1478#issuecomment-613832542 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 29s | master passed | | +1 :green_heart: | compile | 1m 17s | master passed | | +1 :green_heart: | shadedjars | 4m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 59s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | compile | 1m 18s | the patch passed | | +1 :green_heart: | javac | 1m 18s | the patch passed | | +1 :green_heart: | shadedjars | 4m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 16s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 119m 21s | hbase-server in the patch passed. | | | | 145m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1478 | | JIRA Issue | HBASE-24137 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b78ce50ebd5c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/testReport/ | | Max. process+thread count | 4452 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1519: HBASE-24148: Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
Apache-HBase commented on issue #1519: HBASE-24148: Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1519#issuecomment-613827818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 50s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 44s | branch-2 passed | | +1 :green_heart: | spotbugs | 13m 14s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 27s | the patch passed | | +1 :green_heart: | checkstyle | 2m 56s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 14m 1s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 13m 48s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 68m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1519 | | JIRA Issue | HBASE-24148 | | Optional Tests | dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle | | uname | Linux 68bf76375f27 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 62a488b946 | | Max. process+thread count | 122 (vs. ulimit of 12500) | | modules | C: hbase-thrift . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1519/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1518: HBASE-24191 HRegion#processRowsWithLocks count memstore size wrong wh…
Apache-HBase commented on issue #1518: HBASE-24191 HRegion#processRowsWithLocks count memstore size wrong wh… URL: https://github.com/apache/hbase/pull/1518#issuecomment-613827128 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 43s | branch-1 passed | | +1 :green_heart: | compile | 0m 43s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | compile | 0m 48s | branch-1 passed with JDK v1.7.0_252 | | +1 :green_heart: | checkstyle | 1m 49s | branch-1 passed | | +1 :green_heart: | shadedjars | 3m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | branch-1 passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 45s | branch-1 passed with JDK v1.7.0_252 | | +0 :ok: | spotbugs | 3m 7s | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 :x: | findbugs | 3m 3s | hbase-server in branch-1 has 1 extant findbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 8s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | compile | 0m 46s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | javac | 0m 46s | the patch passed | | +1 :green_heart: | checkstyle | 1m 43s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 3m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 24s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 33s | the patch passed with JDK v1.8.0_242 | | +1 :green_heart: | javadoc | 0m 46s | the patch passed with JDK v1.7.0_252 | | +1 :green_heart: | findbugs | 3m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 133m 26s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. | | | | 176m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1518/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1518 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 06d60017157c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1518/out/precommit/personality/provided.sh | | git revision | branch-1 / 03d73f1 | | Default Java | 1.7.0_252 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1518/1/artifact/out/branch-findbugs-hbase-server-warnings.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1518/1/testReport/ | | Max. process+thread count | 4338 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1518/1/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer
Apache-HBase commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer URL: https://github.com/apache/hbase/pull/1514#issuecomment-613821249 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 33s | master passed | | +1 :green_heart: | checkstyle | 1m 32s | master passed | | +1 :green_heart: | spotbugs | 2m 54s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 24s | the patch passed | | +1 :green_heart: | checkstyle | 1m 29s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 19s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 41m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1514 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 688a9101935e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24183) [flakey test] replication.TestAddToSerialReplicationPeer
[
https://issues.apache.org/jira/browse/HBASE-24183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083799#comment-17083799
]
Huaxiang Sun commented on HBASE-24183:
--
Forward the root cause analysis from the github PR.
There are two flakies.
testAddToSerialPeer failure is that it just needs to make sure the source RS's
inmemory map contains only the new wal file. (not the RS which region moves to)
After that, there is still one failure which is common to testAddToSerialPeer
and testChangeToSerial.
If the old wal file before rollover is still in the inmemory map of
replicateSourceManager, during peer disable/enable/config update, it could be
still be replicated over from the begin to peer cluster. If that happens, the
old wal entries and the new wal entries will be written to the same wal file
(which results in out of order seq numbers).
waitUntilReplicatedToTheCurrentWALFile() does not really guarantee that the
inmemory map is forwarded to the new wal file, there is a small window that
there is only one wal file in map which is the old wal file. Added a new check
to make sure that inmemory map only has the new wal file.
This could happen in the production cluster as well, however I do not think
this is the purpose of these two test cases.
> [flakey test] replication.TestAddToSerialReplicationPeer
>
>
> Key: HBASE-24183
> URL: https://issues.apache.org/jira/browse/HBASE-24183
> Project: HBase
> Issue Type: Test
> Components: Client
>Affects Versions: 3.0.0, 2.3.0, 2.4.0
>Reporter: Huaxiang Sun
>Assignee: Hua Xiang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> From both 2.3 and branch-2 flaky test board, it constantly runs into the
> following flaky:
>
> {code:java}
> org.apache.hadoop.hbase.replication.TestAddToSerialReplicationPeer.testAddToSerialPeerFailing
> for the past 1 build (Since #6069 )Took 15 sec.Error MessageSequence id go
> backwards from 122 to 24Stacktracejava.lang.AssertionError: Sequence id go
> backwards from 122 to 24
> at
> org.apache.hadoop.hbase.replication.TestAddToSerialReplicationPeer.testAddToSerialPeer(TestAddToSerialReplicationPeer.java:176)
> Standard Output{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] huaxiangsun commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer
huaxiangsun commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer URL: https://github.com/apache/hbase/pull/1514#issuecomment-613818552 Forwarded the comments to the jira. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] huaxiangsun commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer
huaxiangsun commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer URL: https://github.com/apache/hbase/pull/1514#issuecomment-613817883 Thanks @Apache9 and @saintstack. The failed tests are not related cause the patch is in the specific test case. I checked the failed three cases, they are all due to malformat xml error so could related to the known native thread issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack edited a comment on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer
saintstack edited a comment on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer URL: https://github.com/apache/hbase/pull/1514#issuecomment-613810526 Test failures related @huaxiangsun ? Let me rerun the tests to see Otherwise, +1 on patch. Lets try it. I like the root cause analysis. Stick that up on the issue tooo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd opened a new pull request #1520: [Back-port branch-2]: HBASE-24112 [RSGroup] Support renaming rsgroup
Reidd opened a new pull request #1520: [Back-port branch-2]: HBASE-24112 [RSGroup] Support renaming rsgroup URL: https://github.com/apache/hbase/pull/1520 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer
saintstack commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer URL: https://github.com/apache/hbase/pull/1514#issuecomment-613810526 Test failures related @huaxiangsun ? Let me rerun the tests to see This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24072) Nightlies reporting OutOfMemoryError: unable to create new native thread
[
https://issues.apache.org/jira/browse/HBASE-24072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083792#comment-17083792
]
Michael Stack commented on HBASE-24072:
---
Found that HBASE-23956 Use less resources running tests (#1266) was missing off
branch-2.3. Added it (and the correction HBASE-23987 NettyRpcClientConfigHelper
will not share event loop by default which is incorrect (#1288)). Lets see if
that helps.
> Nightlies reporting OutOfMemoryError: unable to create new native thread
>
>
> Key: HBASE-24072
> URL: https://issues.apache.org/jira/browse/HBASE-24072
> Project: HBase
> Issue Type: Task
> Components: test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments:
> 0001-HBASE-24072-Nightlies-reporting-OutOfMemoryError-una.patch,
> print_ulimit.patch
>
>
> Seeing this kind of thing in nightly...
> {code}
> java.lang.RuntimeException: java.lang.OutOfMemoryError: unable to create new
> native thread
> at
> org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.beforeClass(TestMultithreadedTableMapper.java:83)
> Caused by: java.lang.OutOfMemoryError: unable to create new native thread
> at
> org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.beforeClass(TestMultithreadedTableMapper.java:83)
> {code}
> Chatting w/ Nick and Huaxiang, doing the math, we are likely oversubscribing
> our docker container. It is set to 20G (The hosts are 48G). Fork count is
> 0.5C on a 16 CPU machine which is 8 *2.8G our current forked jvm size. Add
> the maven 4G and we could be over the top.
> Play w/ downing the fork size (in earlier study we didn't seem to need this
> much RAM when running a fat long test). Let me also take th ms off the mvn
> allocation to see if that helps.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack commented on issue #1462: HBASE-24148: Upgrade Thrift to 0.13.0
saintstack commented on issue #1462: HBASE-24148: Upgrade Thrift to 0.13.0 URL: https://github.com/apache/hbase/pull/1462#issuecomment-613808900 Closing. Wrapped @tamaashu 's patch into a fatter one in a new PR that includes regeneration of java files from thrift IDLs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack closed pull request #1462: HBASE-24148: Upgrade Thrift to 0.13.0
saintstack closed pull request #1462: HBASE-24148: Upgrade Thrift to 0.13.0 URL: https://github.com/apache/hbase/pull/1462 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack edited a comment on issue #1462: HBASE-24148: Upgrade Thrift to 0.13.0
saintstack edited a comment on issue #1462: HBASE-24148: Upgrade Thrift to 0.13.0 URL: https://github.com/apache/hbase/pull/1462#issuecomment-613808900 Closing. Wrapped @tamaashu 's patch into a fatter one in a new PR that includes regeneration of java files from thrift IDLs. See #1519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack opened a new pull request #1519: HBASE-24148: Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
saintstack opened a new pull request #1519: HBASE-24148: Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. URL: https://github.com/apache/hbase/pull/1519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24184) listSnapshots returns empty when just use simple acl but not use authentication
[
https://issues.apache.org/jira/browse/HBASE-24184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
tianhang tang updated HBASE-24184:
--
Description:
For the owner of snapshots(not global admin user), currently list_snapshots
returns empty if i just use simple acls for authorization but not use
authentication.
The code in AccessController.preListSnapshot:
{code:java}
if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}{code}
And SnapshotManager.takeSnapshotInternal:
{code:java}
if (User.isHBaseSecurityEnabled(master.getConfiguration()) && user != null) {
builder.setOwner(user.getShortName());
}
{code}
User.isHBaseSecurityEnabled：
{code:java}
public static boolean isHBaseSecurityEnabled(Configuration conf) {
return "kerberos".equalsIgnoreCase(conf.get(HBASE_SECURITY_CONF_KEY));
}
{code}
So i think the logic of setOwner is used for authorization, not authentication,
SnapshotManager should not only setOwner when hbase.security.authentication =
kerberos, which cause listSnapshots returns empty when i just use simple acls.
was:
For the owner of snapshots(not global admin user), currently list_snapshots
returns empty if i just use simple acls for authorization but not use
authentication.
The code in AccessController.preListSnapshot:
{code:java}
if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}{code}
And SnapshotManager.takeSnapshotInternal:
{code:java}
if (User.isHBaseSecurityEnabled(master.getConfiguration()) && user != null) {
builder.setOwner(user.getShortName());
}
{code}
User.isHBaseSecurityEnabled：
{code:java}
public static boolean isHBaseSecurityEnabled(Configuration conf) {
return "kerberos".equalsIgnoreCase(conf.get(HBASE_SECURITY_CONF_KEY));
}
{code}
So i think the logic of setOwner is used for authorization, not authentication,
SnapshotManager should not only setOwner when hbase.security.authentication =
kerberos, which cause listSnapshots returns empty when i just use simple acls.
> listSnapshots returns empty when just use simple acl but not use
> authentication
> ---
>
> Key: HBASE-24184
> URL: https://issues.apache.org/jira/browse/HBASE-24184
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: tianhang tang
>Assignee: tianhang tang
>Priority: Minor
>
> For the owner of snapshots(not global admin user), currently list_snapshots
> returns empty if i just use simple acls for authorization but not use
> authentication.
> The code in AccessController.preListSnapshot:
> {code:java}
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
> // list it, if user is the owner of snapshot
> AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
> "Snapshot owner check allowed", user, null, null, null);
> accessChecker.logResult(result);
> }{code}
> And SnapshotManager.takeSnapshotInternal:
> {code:java}
> if (User.isHBaseSecurityEnabled(master.getConfiguration()) && user != null) {
> builder.setOwner(user.getShortName());
> }
> {code}
> User.isHBaseSecurityEnabled：
> {code:java}
> public static boolean isHBaseSecurityEnabled(Configuration conf) {
> return "kerberos".equalsIgnoreCase(conf.get(HBASE_SECURITY_CONF_KEY));
> }
> {code}
> So i think the logic of setOwner is used for authorization, not
> authentication, SnapshotManager should not only setOwner when
> hbase.security.authentication = kerberos, which cause listSnapshots returns
> empty when i just use simple acls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1478: HBASE-24137:The max merge count of metafixer may be remind in hbase-site.xml
Apache-HBase commented on issue #1478: HBASE-24137:The max merge count of metafixer may be remind in hbase-site.xml URL: https://github.com/apache/hbase/pull/1478#issuecomment-613807496 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 22s | master passed | | +1 :green_heart: | checkstyle | 1m 29s | master passed | | +0 :ok: | refguide | 4m 40s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotbugs | 2m 50s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 14s | the patch passed | | +1 :green_heart: | checkstyle | 1m 25s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 4m 56s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 14m 6s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 3m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. | | | | 50m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1478 | | JIRA Issue | HBASE-24137 | | Optional Tests | dupname asflicense refguide xml spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 8e801181b1ca 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-general-check/output/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1478/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24184) listSnapshots returns empty when just use simple acl but not use authentication
[
https://issues.apache.org/jira/browse/HBASE-24184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
tianhang tang updated HBASE-24184:
--
Description:
For the owner of snapshots(not global admin user), currently list_snapshots
returns empty if i just use simple acls for authorization but not use
authentication.
The code in AccessController.preListSnapshot:
{code:java}
if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}{code}
And SnapshotManager.takeSnapshotInternal:
{code:java}
if (User.isHBaseSecurityEnabled(master.getConfiguration()) && user != null) {
builder.setOwner(user.getShortName());
}
{code}
User.isHBaseSecurityEnabled：
{code:java}
public static boolean isHBaseSecurityEnabled(Configuration conf) {
return "kerberos".equalsIgnoreCase(conf.get(HBASE_SECURITY_CONF_KEY));
}
{code}
So i think the logic of setOwner is used for authorization, not authentication,
SnapshotManager should not only setOwner when hbase.security.authentication =
kerberos, which cause listSnapshots returns empty when i just use simple acls.
was:
For the owner of snapshots(not global admin user), currently list_snapshots
returns empty if i just use simple acls for authorization but not use
authentication.
The code in AccessController.preListSnapshot:
{code:java}
if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}
{code}
So i think the logic of setOwner is used for authorization, not authentication,
SnapshotManager should not only setOwner when hbase.security.authentication =
kerberos, which cause listSnapshots returns empty when i just use simple acls.
> listSnapshots returns empty when just use simple acl but not use
> authentication
> ---
>
> Key: HBASE-24184
> URL: https://issues.apache.org/jira/browse/HBASE-24184
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: tianhang tang
>Assignee: tianhang tang
>Priority: Minor
>
> For the owner of snapshots(not global admin user), currently list_snapshots
> returns empty if i just use simple acls for authorization but not use
> authentication.
> The code in AccessController.preListSnapshot:
> {code:java}
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
> // list it, if user is the owner of snapshot
> AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
> "Snapshot owner check allowed", user, null, null, null);
> accessChecker.logResult(result);
> }{code}
>
> And SnapshotManager.takeSnapshotInternal:
> {code:java}
> if (User.isHBaseSecurityEnabled(master.getConfiguration()) && user != null) {
> builder.setOwner(user.getShortName());
> }
> {code}
> User.isHBaseSecurityEnabled：
> {code:java}
> public static boolean isHBaseSecurityEnabled(Configuration conf) {
> return "kerberos".equalsIgnoreCase(conf.get(HBASE_SECURITY_CONF_KEY));
> }
> {code}
> So i think the logic of setOwner is used for authorization, not
> authentication, SnapshotManager should not only setOwner when
> hbase.security.authentication = kerberos, which cause listSnapshots returns
> empty when i just use simple acls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24148) Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
[
https://issues.apache.org/jira/browse/HBASE-24148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083784#comment-17083784
]
Michael Stack commented on HBASE-24148:
---
Rereading HBASE-21791 , there is profile to generate/compile thrift. I applied
[~tamaas]'s patch which takes care of upping the thrift version in poms. I then
ran the special profile as follows (AFTER installing thrift 0.13 -- I used brew
as in 'brew install thrift' and then checked the install with 'thrift
--version' to make sure I was on version 0.13.0).
{code}
$ mvn -Pcompile-thrift clean install -DskipTests
{code}
I put together [~tamaas] 's patch and the generated files to make a new PR.
> Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
> --
>
> Key: HBASE-24148
> URL: https://issues.apache.org/jira/browse/HBASE-24148
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
>Affects Versions: 3.0.0
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> In Apache Thrift all versions up to and including 0.12.0, a server or client
> may run into an endless loop when feed with specific input data. Because the
> issue had already been partially fixed in version 0.11.0, depending on the
> installed version it affects only certain language bindings.
> To be on the safe side, we could update to 0.13.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23994) Add WebUI to Canary
[
https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083767#comment-17083767
]
Hudson commented on HBASE-23994:
Results for branch branch-2
[build #2608 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2608/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2608/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2608/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2608/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2608/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add WebUI to Canary
>
>
> Key: HBASE-23994
> URL: https://issues.apache.org/jira/browse/HBASE-23994
> Project: HBase
> Issue Type: Improvement
> Components: canary, UI, Usability
>Affects Versions: 3.0.0
>Reporter: Zhuoyue Huang
>Assignee: Zhuoyue Huang
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
> Attachments: image-2020-03-16-09-12-00-595.png
>
>
> During the running of Canary, the table sniff failure information will be
> printed through the Log.
> {code:java}
> LOG.error("Read from {} on {}", table, server);
> {code}
>
> I think we can use WebUI to display these failures to make it easier for us
> to view this information
>
> !image-2020-03-16-09-12-00-595.png!
> As shown in the figure above, we can directly see the Table and Regionserver
> where the error occurred
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24148) Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
[ https://issues.apache.org/jira/browse/HBASE-24148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083764#comment-17083764 ] Michael Stack commented on HBASE-24148: --- HBASE-21791 has prescription for how to generate the new thrift files from the thrift idls. > Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. > -- > > Key: HBASE-24148 > URL: https://issues.apache.org/jira/browse/HBASE-24148 > Project: HBase > Issue Type: Improvement > Components: Thrift >Affects Versions: 3.0.0 >Reporter: Tamas Penzes >Assignee: Tamas Penzes >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > In Apache Thrift all versions up to and including 0.12.0, a server or client > may run into an endless loop when feed with specific input data. Because the > issue had already been partially fixed in version 0.11.0, depending on the > installed version it affects only certain language bindings. > To be on the safe side, we could update to 0.13.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] gentlewangyu commented on issue #1478: HBASE-24137:The max merge count of metafixer may be remind in hbase-site.xml
gentlewangyu commented on issue #1478: HBASE-24137:The max merge count of metafixer may be remind in hbase-site.xml URL: https://github.com/apache/hbase/pull/1478#issuecomment-613794669 @ndimiduk @saintstack @virajjasani thanks for your suggestion, I see . I just add the description of hbase.master.metafixer.max.merge.count in hbase-site.xml This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] thangTang removed a comment on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang removed a comment on issue #1510: HBASE-24184 listSnapshots returns
empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613776774
The code in AccessController.preListSnapshot:
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " +
snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}
So i think the logic of setOwner is used for **authorization**, not
**authentication**, SnapshotManager should not only setOwner when
`hbase.security.authentication = kerberos`, which cause listSnapshots returns
empty when i just use simple acls.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore
Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore URL: https://github.com/apache/hbase/pull/1513#issuecomment-613793186 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 43s | branch-2.3 passed | | +1 :green_heart: | compile | 1m 42s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 55s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-common in branch-2.3 failed. | | -0 :warning: | javadoc | 0m 44s | hbase-server in branch-2.3 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 24s | the patch passed | | +1 :green_heart: | compile | 1m 36s | the patch passed | | +1 :green_heart: | javac | 1m 36s | the patch passed | | +1 :green_heart: | shadedjars | 6m 20s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 21s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 54s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 16s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 197m 33s | hbase-server in the patch passed. | | | | 229m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1513 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3b55969ac09a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / dc7fd7c32c | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/testReport/ | | Max. process+thread count | 2409 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24123) [Flakey Tests] TestThrift?ServerCmdLine
[
https://issues.apache.org/jira/browse/HBASE-24123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083762#comment-17083762
]
Michael Stack commented on HBASE-24123:
---
Maybe upgrade of thrift HBASE-24148 would help w/ these failures.
> [Flakey Tests] TestThrift?ServerCmdLine
> ---
>
> Key: HBASE-24123
> URL: https://issues.apache.org/jira/browse/HBASE-24123
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
>
> TestThrift2ServerCmdLine and TestThriftServerCmdLine are flakey. They fail
> frequently in local runs for myriad reasons: protocol failures, wrong answers
> on query, connection resets, etc. Each test runs 40 different combinations of
> config.
> This is after work done to try and stabilize by fixing port clash issues.
> Let me list in here the ways in which it fails. I will disable after I get a
> good list. Will also try and do some more stabilization too in sub-issues.
> Lets see which prevails; stabilization or disabling.
> For starters, this morning I got this:
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine
>
> ---
> Tests run: 32, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 126.301 s
> <<< FAILURE! - in org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine
>
> org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.testRunThriftServer[29]
> Time elapsed: 0.964 s <<< ERROR!
> java.lang.Exception: org.apache.thrift.transport.TTransportException:
> java.net.SocketException: Connection reset
>at
> org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.talkToThriftServer(TestThrift2ServerCmdLine.java:92)
> Caused by: java.net.SocketException: Connection reset
>at
> org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.talkToThriftServer(TestThrift2ServerCmdLine.java:92)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24123) [Flakey Tests] TestThrift?ServerCmdLine
[
https://issues.apache.org/jira/browse/HBASE-24123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083761#comment-17083761
]
Michael Stack commented on HBASE-24123:
---
Locally, this failed
{code}
[ERROR] Tests run: 32, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 78.382
s <<< FAILURE! - in org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine
[ERROR]
org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.testRunThriftServer[24]
Time elapsed: 0.473 s <<< ERROR!
java.lang.Exception: org.apache.thrift.protocol.TProtocolException: Bad version
in readMessageBegin
at
org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.talkToThriftServer(TestThrift2ServerCmdLine.java:92)
{code}
> [Flakey Tests] TestThrift?ServerCmdLine
> ---
>
> Key: HBASE-24123
> URL: https://issues.apache.org/jira/browse/HBASE-24123
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
>
> TestThrift2ServerCmdLine and TestThriftServerCmdLine are flakey. They fail
> frequently in local runs for myriad reasons: protocol failures, wrong answers
> on query, connection resets, etc. Each test runs 40 different combinations of
> config.
> This is after work done to try and stabilize by fixing port clash issues.
> Let me list in here the ways in which it fails. I will disable after I get a
> good list. Will also try and do some more stabilization too in sub-issues.
> Lets see which prevails; stabilization or disabling.
> For starters, this morning I got this:
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine
>
> ---
> Tests run: 32, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 126.301 s
> <<< FAILURE! - in org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine
>
> org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.testRunThriftServer[29]
> Time elapsed: 0.964 s <<< ERROR!
> java.lang.Exception: org.apache.thrift.transport.TTransportException:
> java.net.SocketException: Connection reset
>at
> org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.talkToThriftServer(TestThrift2ServerCmdLine.java:92)
> Caused by: java.net.SocketException: Connection reset
>at
> org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.talkToThriftServer(TestThrift2ServerCmdLine.java:92)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes
Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes URL: https://github.com/apache/hbase/pull/1487#issuecomment-613792435 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 36s | master passed | | +0 :ok: | refguide | 4m 46s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 11s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 4m 43s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 18m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1487 | | Optional Tests | dupname asflicense refguide | | uname | Linux e69764541e4e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/4/artifact/yetus-general-check/output/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/4/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 78 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24137) The max merge count of metafixer may be remind in hbase-site.xml
[ https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24137: Summary: The max merge count of metafixer may be remind in hbase-site.xml (was: The max merge count of metafixer should be configurable in MetaFixer) > The max merge count of metafixer may be remind in hbase-site.xml > > > Key: HBASE-24137 > URL: https://issues.apache.org/jira/browse/HBASE-24137 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Yu Wang >Priority: Minor > Fix For: 3.0.0 > > Attachments: 24137_master_1.patch > > > The max merge count of metafixer should be configurable in MetaFixer -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24184) listSnapshots returns empty when just use simple acl but not use authentication
[
https://issues.apache.org/jira/browse/HBASE-24184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
tianhang tang updated HBASE-24184:
--
Description:
For the owner of snapshots(not global admin user), currently list_snapshots
returns empty if i just use simple acls for authorization but not use
authentication.
The code in AccessController.preListSnapshot:
{code:java}
if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}
{code}
So i think the logic of setOwner is used for authorization, not authentication,
SnapshotManager should not only setOwner when hbase.security.authentication =
kerberos, which cause listSnapshots returns empty when i just use simple acls.
was:For the owner of snapshots(not global admin user), currently
list_snapshots returns empty if i just use simple acls for authorization but
not use authentication.
> listSnapshots returns empty when just use simple acl but not use
> authentication
> ---
>
> Key: HBASE-24184
> URL: https://issues.apache.org/jira/browse/HBASE-24184
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Reporter: tianhang tang
>Assignee: tianhang tang
>Priority: Minor
>
> For the owner of snapshots(not global admin user), currently list_snapshots
> returns empty if i just use simple acls for authorization but not use
> authentication.
> The code in AccessController.preListSnapshot:
> {code:java}
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
> // list it, if user is the owner of snapshot
> AuthResult result = AuthResult.allow("listSnapshot " + snapshot.getName(),
> "Snapshot owner check allowed", user, null, null, null);
> accessChecker.logResult(result);
> }
> {code}
> So i think the logic of setOwner is used for authorization, not
> authentication, SnapshotManager should not only setOwner when
> hbase.security.authentication = kerberos, which cause listSnapshots returns
> empty when i just use simple acls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore
Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore URL: https://github.com/apache/hbase/pull/1513#issuecomment-613791577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 58s | branch-2.3 passed | | +1 :green_heart: | compile | 1m 24s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 4m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 59s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 41s | the patch passed | | +1 :green_heart: | compile | 1m 20s | the patch passed | | +1 :green_heart: | javac | 1m 20s | the patch passed | | +1 :green_heart: | shadedjars | 4m 59s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 57s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 25s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 197m 4s | hbase-server in the patch passed. | | | | 223m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1513 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fc09b1c7b870 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / dc7fd7c32c | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/testReport/ | | Max. process+thread count | 2373 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1495: HBASE-24170 Remove hadoop-2.0 profile
Apache-HBase commented on issue #1495: HBASE-24170 Remove hadoop-2.0 profile URL: https://github.com/apache/hbase/pull/1495#issuecomment-613788878 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 48s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 26s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 6m 36s | Patch does not cause any errors with Hadoop 3.1.2. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 3m 52s | The patch does not generate ASF License warnings. | | | | 24m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1495/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1495 | | Optional Tests | dupname asflicense shellcheck shelldocs hadoopcheck xml | | uname | Linux 7cfe828b1a17 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | Max. process+thread count | 63 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1495/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes
Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes URL: https://github.com/apache/hbase/pull/1487#issuecomment-613788124 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1487 | | Optional Tests | | | uname | Linux 8e7631a3179f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | Max. process+thread count | 42 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes
Apache-HBase commented on issue #1487: HBASE-23800 Add documentation about the CECPs changes URL: https://github.com/apache/hbase/pull/1487#issuecomment-613787947 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1487 | | Optional Tests | | | uname | Linux 2767ded5bdae 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | Max. process+thread count | 52 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1487/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23994) Add WebUI to Canary
[
https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083745#comment-17083745
]
Hudson commented on HBASE-23994:
Results for branch branch-2.3
[build #34 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/34/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/34/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/34/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/34/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/34/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add WebUI to Canary
>
>
> Key: HBASE-23994
> URL: https://issues.apache.org/jira/browse/HBASE-23994
> Project: HBase
> Issue Type: Improvement
> Components: canary, UI, Usability
>Affects Versions: 3.0.0
>Reporter: Zhuoyue Huang
>Assignee: Zhuoyue Huang
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
> Attachments: image-2020-03-16-09-12-00-595.png
>
>
> During the running of Canary, the table sniff failure information will be
> printed through the Log.
> {code:java}
> LOG.error("Read from {} on {}", table, server);
> {code}
>
> I think we can use WebUI to display these failures to make it easier for us
> to view this information
>
> !image-2020-03-16-09-12-00-595.png!
> As shown in the figure above, we can directly see the Table and Regionserver
> where the error occurred
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on a change in pull request #1487: HBASE-23800 Add documentation about the CECPs changes
Apache9 commented on a change in pull request #1487: HBASE-23800 Add documentation about the CECPs changes URL: https://github.com/apache/hbase/pull/1487#discussion_r408550036 ## File path: src/main/asciidoc/_chapters/cp.adoc ## @@ -193,6 +209,12 @@ link:https://issues.apache.org/jira/browse/HBASE-5448[HBASE-5448]). To upgrade y HBase cluster from 0.94 or earlier to 0.96 or later, you need to reimplement your coprocessor. +In HBase 2.0.0, we make use of a shaded version of protobuf 3.x, but still keep the +protobuf for coprocessor on 2.5.0. In 3.0.0, we removed all dependencies on non-shaded +protobuf so you need to reimplement your coprocessor to make use of the shaded protobuf +version provided in hbase-thirdparty. Please see the <> section for Review comment: Yes, I think it is LimitedPrivate for CPEPs. What I said above is that, we had this consensus in the past, otherwise we did not need to provide a hbase-protocol module which duplicates a lot of proto files... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1495: HBASE-24170 Remove hadoop-2.0 profile
Apache-HBase commented on issue #1495: HBASE-24170 Remove hadoop-2.0 profile URL: https://github.com/apache/hbase/pull/1495#issuecomment-613782403 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1495/5/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1495: HBASE-24170 Remove hadoop-2.0 profile
Apache-HBase commented on issue #1495: HBASE-24170 Remove hadoop-2.0 profile URL: https://github.com/apache/hbase/pull/1495#issuecomment-613782401 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1495/5/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1495: HBASE-24170 Remove hadoop-2.0 profile
Apache-HBase commented on issue #1495: HBASE-24170 Remove hadoop-2.0 profile URL: https://github.com/apache/hbase/pull/1495#issuecomment-613782436 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1495/5/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] thangTang edited a comment on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang edited a comment on issue #1510: HBASE-24184 listSnapshots returns
empty when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613776774
The code in AccessController.preListSnapshot:
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " +
snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}
So i think the logic of setOwner is used for **authorization**, not
**authentication**, SnapshotManager should not only setOwner when
`hbase.security.authentication = kerberos`, which cause listSnapshots returns
empty when i just use simple acls.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin commented on issue #1518: HBASE-24191 HRegion#processRowsWithLocks count memstore size wrong wh…
binlijin commented on issue #1518: HBASE-24191 HRegion#processRowsWithLocks count memstore size wrong wh… URL: https://github.com/apache/hbase/pull/1518#issuecomment-613779534 Only branch-1 verions have this problem, not apply to master/branch-2. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] thangTang removed a comment on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang removed a comment on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1510#issuecomment-613768194 @enis Hi, could you help me to review this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] binlijin opened a new pull request #1518: HBASE-24191 HRegion#processRowsWithLocks count memstore size wrong wh…
binlijin opened a new pull request #1518: HBASE-24191 HRegion#processRowsWithLocks count memstore size wrong wh… URL: https://github.com/apache/hbase/pull/1518 …en sync failed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24191) HRegion#processRowsWithLocks count memstore size wrong when sync failed
[ https://issues.apache.org/jira/browse/HBASE-24191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin updated HBASE-24191: -- Summary: HRegion#processRowsWithLocks count memstore size wrong when sync failed (was: HRegion#processRowsWithLocks count memstore size wrong sync failed) > HRegion#processRowsWithLocks count memstore size wrong when sync failed > --- > > Key: HBASE-24191 > URL: https://issues.apache.org/jira/browse/HBASE-24191 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.7.0 >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > > HRegion#processRowsWithLocks when wal sync failed, it will roll back the > memstore in Store and reduce the size in DefaultMemStore, but still add > memStoreSize to HRegion#memstoreSize. > And this only affect branch-1 verions, not apply to master/branch-2. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24191) HRegion#processRowsWithLocks count memstore size wrong sync failed
[ https://issues.apache.org/jira/browse/HBASE-24191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin updated HBASE-24191: -- Summary: HRegion#processRowsWithLocks count memstore size wrong sync failed (was: HRegion#processRowsWithLocks count memstore size wrong sync failed.) > HRegion#processRowsWithLocks count memstore size wrong sync failed > -- > > Key: HBASE-24191 > URL: https://issues.apache.org/jira/browse/HBASE-24191 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.7.0 >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > > HRegion#processRowsWithLocks when wal sync failed, it will roll back the > memstore in Store and reduce the size in DefaultMemStore, but still add > memStoreSize to HRegion#memstoreSize. > And this only affect branch-1 verions, not apply to master/branch-2. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24191) HRegion#processRowsWithLocks count memstore size wrong sync failed.
Lijin Bin created HBASE-24191: - Summary: HRegion#processRowsWithLocks count memstore size wrong sync failed. Key: HBASE-24191 URL: https://issues.apache.org/jira/browse/HBASE-24191 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 1.7.0 Reporter: Lijin Bin Assignee: Lijin Bin HRegion#processRowsWithLocks when wal sync failed, it will roll back the memstore in Store and reduce the size in DefaultMemStore, but still add memStoreSize to HRegion#memstoreSize. And this only affect branch-1 verions, not apply to master/branch-2. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty
when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613776774
The code in AccessController.preListSnapshot:
`if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " +
snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}`
So i think the logic of setOwner is used for **authorization**, not
**authentication**, SnapshotManager should not only setOwner when
`hbase.security.authentication = kerberos`, which cause listSnapshots returns
empty when i just use simple acls.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-24086) Disable output stream capability enforcement when running in standalone mode
[
https://issues.apache.org/jira/browse/HBASE-24086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-24086:
Fix Version/s: 2.4.0
1.7.0
> Disable output stream capability enforcement when running in standalone mode
>
>
> Key: HBASE-24086
> URL: https://issues.apache.org/jira/browse/HBASE-24086
> Project: HBase
> Issue Type: Task
> Components: master
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.4.0, 2.2.5
>
>
> {noformat}
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> mvn clean install -DskipTests
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> ./bin/hbase master start
> {noformat}
> gives
> {noformat}
> 2020-03-30 17:12:43,857 ERROR
> [master/192.168.111.13:16000:becomeActiveMaster] master.HMaster: Failed to
> become active master
>
> java.io.IOException: cannot get log writer
>
>
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:118)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createAsyncWriter(AsyncFSWAL.java:704)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:710)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:128)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:839)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:549)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:490)
>
>
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:156)
>
>
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:61)
>
>
> at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:297)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.createWAL(RegionProcedureStore.java:256)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.bootstrap(RegionProcedureStore.java:273)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.recoverLease(RegionProcedureStore.java:482)
>
>
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:587)
>
>
> at
> org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1575)
>
>
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:961)
>
>
> at
> org.apach
[jira] [Updated] (HBASE-8868) add metric to report client shortcircuit reads
[ https://issues.apache.org/jira/browse/HBASE-8868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-8868: --- Fix Version/s: 1.7.0 > add metric to report client shortcircuit reads > -- > > Key: HBASE-8868 > URL: https://issues.apache.org/jira/browse/HBASE-8868 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Affects Versions: 0.94.8, 0.95.1 >Reporter: Viral Bajaria >Assignee: Wei-Chiu Chuang >Priority: Minor > Fix For: 3.0.0, 2.3.0, 1.7.0 > > Attachments: HBASE-8868.master.001.patch > > > With the availability of shortcircuit reads, when the feature is enabled > there is no metric which exposes how many times the regionserver was able to > shortcircuit the read and not make a IPC to the datanode. > It will be great to add the metric and expose it via Ganglia. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-8868) add metric to report client shortcircuit reads
[ https://issues.apache.org/jira/browse/HBASE-8868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-8868: --- Fix Version/s: 2.4.0 > add metric to report client shortcircuit reads > -- > > Key: HBASE-8868 > URL: https://issues.apache.org/jira/browse/HBASE-8868 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Affects Versions: 0.94.8, 0.95.1 >Reporter: Viral Bajaria >Assignee: Wei-Chiu Chuang >Priority: Minor > Fix For: 3.0.0, 2.3.0, 1.7.0, 2.4.0 > > Attachments: HBASE-8868.master.001.patch > > > With the availability of shortcircuit reads, when the feature is enabled > there is no metric which exposes how many times the regionserver was able to > shortcircuit the read and not make a IPC to the datanode. > It will be great to add the metric and expose it via Ganglia. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer
Apache-HBase commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer URL: https://github.com/apache/hbase/pull/1514#issuecomment-613773408 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 23s | master passed | | +1 :green_heart: | compile | 1m 23s | master passed | | +1 :green_heart: | shadedjars | 6m 50s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 56s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 11s | the patch passed | | +1 :green_heart: | compile | 1m 22s | the patch passed | | +1 :green_heart: | javac | 1m 22s | the patch passed | | +1 :green_heart: | shadedjars | 7m 18s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 1m 0s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 242m 39s | hbase-server in the patch failed. | | | | 275m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1514 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c6538c99b2b6 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4fc3527e46 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/1/testReport/ | | Max. process+thread count | 2745 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer
Apache-HBase commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer URL: https://github.com/apache/hbase/pull/1514#issuecomment-613768996 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 45s | master passed | | +1 :green_heart: | compile | 1m 12s | master passed | | +1 :green_heart: | shadedjars | 5m 56s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 13s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed | | +1 :green_heart: | javac | 1m 9s | the patch passed | | +1 :green_heart: | shadedjars | 6m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 231m 57s | hbase-server in the patch passed. | | | | 260m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1514 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9778e249c96c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4fc3527e46 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/1/testReport/ | | Max. process+thread count | 2572 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1514/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1510#issuecomment-613768352 The findbugs warning seems unrelated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1510#issuecomment-613768194 @enis Hi, could you help me to review this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24077) When encounter RowTooBigException, log the row info.
[ https://issues.apache.org/jira/browse/HBASE-24077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24077: Fix Version/s: 1.7.0 > When encounter RowTooBigException, log the row info. > > > Key: HBASE-24077 > URL: https://issues.apache.org/jira/browse/HBASE-24077 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.2.4 >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Minor > Fix For: 3.0.0, 2.3.0, 1.7.0, 2.2.5 > > > Current when we encounter a big row and throw RowTooBigException, there is no > information about the row, it hard to debug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1440: HBASE-23113: Improve and add additional Netty configuration for RPC.
Apache-HBase commented on issue #1440: HBASE-23113: Improve and add additional Netty configuration for RPC. URL: https://github.com/apache/hbase/pull/1440#issuecomment-613765236 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 47s | branch-2 passed | | +1 :green_heart: | compile | 1m 22s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 30s | the patch passed | | +1 :green_heart: | compile | 1m 21s | the patch passed | | +1 :green_heart: | javac | 1m 21s | the patch passed | | +1 :green_heart: | shadedjars | 4m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 59s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 13s | hbase-client in the patch passed. | | -1 :x: | unit | 182m 9s | hbase-server in the patch failed. | | | | 209m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1440 | | JIRA Issue | HBASE-23113 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 88f89903ac97 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / df3768cf2a | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/testReport/ | | Max. process+thread count | 2819 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Description:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
{code:java}
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf =
HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
}
{code}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
{code:java}
public MasterFileSystem(Configuration conf) throws IOException{
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
{code}
The doc in GitHub repo is also misleading (Giving upper-case value).
{quote}As a distributed database, HBase must be able to authenticate users and
HBase services across an untrusted network. Clients and HBase services are
treated equivalently in terms of authentication (and this is the only time we
will draw such a distinction).
There are currently three modes of authentication which are supported by HBase
today via the configuration property {{hbase.security.authentication}}
{{1.SIMPLE}}
{{2.KERBROS}}
{{3.TOKEN}}
{quote}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc.
was:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
{code:java}
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf =
HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
}
{code}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
{code:java}
public MasterFileSystem(Configuration conf) throws IOException{
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
{code}
The doc in GitHub repo is also misleading.
{quote}As a distributed database, HBase must be able to authenticate users and
HBase services across an untrusted network. Clients and HBase services are
treated equivalently in terms of authentication (and this is the only time we
will draw such a distinction).
There are currently three modes of authentication which are supported by HBase
today via the configuration property {{hbase.security.authentication}}
{{1.SIMPLE}}
{{2.KERBROS}}
{{3.TOKEN}}
{quote}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc.
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
>
> {code:java}
> private void initCredentialsForHBase(String zookeeper, Job job) throws
> IOException {
> Configuration peerConf =
> HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);
> if(peerConf.get("hbase.security.authentication").equals("kerberos")){
>
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Description:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
{code:java}
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf =
HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
}
{code}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
{code:java}
public MasterFileSystem(Configuration conf) throws IOException{
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
{code}
The doc in GitHub repo is also misleading.
{quote}As a distributed database, HBase must be able to authenticate users and
HBase services across an untrusted network. Clients and HBase services are
treated equivalently in terms of authentication (and this is the only time we
will draw such a distinction).
There are currently three modes of authentication which are supported by HBase
today via the configuration property {{hbase.security.authentication}}
{{1.SIMPLE}}
{{2.KERBROS}}
{{3.TOKEN}}
{quote}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc.
was:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
{code:java}
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf =
HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
}
{code}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
{code:java}
public MasterFileSystem(Configuration conf) throws IOException{
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
{code}
The doc in GitHub repo is also misleading.
{quote}As a distributed database, HBase must be able to authenticate users and
HBase services across an untrusted network. Clients and HBase services are
treated equivalently in terms of authentication (and this is the only time we
will draw such a distinction).
There are currently three modes of authentication which are supported by HBase
today via the configuration property {{hbase.security.authentication}}
{{1.SIMPLE}}
{{2.KERBROS}}
{{3.TOKEN}}
{quote}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
>
> {code:java}
> private void initCredentialsForHBase(String zookeeper, Job job) throws
> IOException {
> Configuration peerConf =
> HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);
> if(peerConf.get("hbase.security.authentication").equals("kerb
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Description:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
{code:java}
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf =
HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
}
{code}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
{code:java}
public MasterFileSystem(Configuration conf) throws IOException{
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
{code}
The doc in GitHub repo is also misleading.
{quote}As a distributed database, HBase must be able to authenticate users and
HBase services across an untrusted network. Clients and HBase services are
treated equivalently in terms of authentication (and this is the only time we
will draw such a distinction).
There are currently three modes of authentication which are supported by HBase
today via the configuration property {{hbase.security.authentication}}
{{1.SIMPLE}}
{{2.KERBROS}}
{{3.TOKEN}}
{quote}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
was:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf =
HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException{
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
>
> {code:java}
> private void initCredentialsForHBase(String zookeeper, Job job) throws
> IOException {
> Configuration peerConf =
> HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);
> if(peerConf.get("hbase.security.authentication").equals("kerberos")){
> TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
> }
> {code}
>
> However, in current code base, other uses of *hbase.security.authentication*
> are all case-insensitive. For example in *MasterFileSystem.java.*
>
> {code:java}
> public MasterFileSystem(Configuration conf) throws IOException{
> ...
> this.isSecurityEnabled =
> "kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
> ...
> }
> {code}
>
> The doc in GitHub repo is also mi
[GitHub] [hbase] huaxiangsun commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer
huaxiangsun commented on issue #1514: HBASE-24183 [flakey test] replication.TestAddToSerialReplicationPeer URL: https://github.com/apache/hbase/pull/1514#issuecomment-613757958 There are two flakies. testAddToSerialPeer failure is that it just needs to make sure the source RS's inmemory map contains only the new wal file. (not the RS which region moves to) After that, there is still one failure which is common to testAddToSerialPeer and testChangeToSerial. If the old wal file before rollover is still in the inmemory map of replicateSourceManager, during peer disable/enable/config update, it could be still be replicated over from the begin to peer cluster. If that happens, the old wal entries and the new wal entries will be written to the same wal file (which results in out of order seq numbers). waitUntilReplicatedToTheCurrentWALFile() does not really guarantee that the inmemory map is forwarded to the new wal file, there is a small window that there is only one wal file in map which is the old wal file. Added a new check to make sure that inmemory map only has the new wal file. This could happen in the production cluster as well, however I do not think this is the purpose of these two test cases. @Apache9, please provide your input, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Description:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf =
HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException{
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
was:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf = HBaseConfiguration.createClusterConf(job
.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf);
}
}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException {
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
>
> private void initCredentialsForHBase(String zookeeper, Job job) throws
> IOException {
> Configuration peerConf =
> HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);
> if(peerConf.get("hbase.security.authentication").equals("kerberos")){
> TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
> }
> However, in current code base, other uses of *hbase.security.authentication*
> are all case-insensitive. For example in *MasterFileSystem.java.*
> public MasterFileSystem(Configuration conf) throws IOException{
> ...
> this.isSecurityEnabled =
> "kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
> ...
> }
> Users may misconfigured the parameter because of the case-senstive problem.
> *How To Fix*
> Using *eqaulsIgnoreCase* API consistently in every place when using
> *hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
> mention it clearly)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Description:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf = HBaseConfiguration.createClusterConf(job
.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf);
}
}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException {
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
was:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf = HBaseConfiguration.createClusterConf(job
.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos"))\{
TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException
{ ... this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication")); ... }
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
>
> private void initCredentialsForHBase(String zookeeper, Job job) throws
> IOException {
> Configuration peerConf = HBaseConfiguration.createClusterConf(job
> .getConfiguration(), zookeeper);
> if(peerConf.get("hbase.security.authentication").equals("kerberos")){
> TableMapReduceUtil.initCredentialsForCluster(job, peerConf);
> }
> }
> However, in current code base, other uses of *hbase.security.authentication*
> are all case-insensitive. For example in *MasterFileSystem.java.*
> public MasterFileSystem(Configuration conf) throws IOException {
> ...
> this.isSecurityEnabled =
> "kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
> ...
> }
> Users may misconfigured the parameter because of the case-senstive problem.
> *How To Fix*
> Using *eqaulsIgnoreCase* API consistently in every place when using
> *hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
> mention it clearly)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Description:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf = HBaseConfiguration.createClusterConf(job
.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos"))\{
TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException
{ ... this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication")); ... }
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
was:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf = HBaseConfiguration.createClusterConf(job
.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf);
}
}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException {
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
>
> private void initCredentialsForHBase(String zookeeper, Job job) throws
> IOException {
> Configuration peerConf = HBaseConfiguration.createClusterConf(job
> .getConfiguration(), zookeeper);
> if(peerConf.get("hbase.security.authentication").equals("kerberos"))\{
> TableMapReduceUtil.initCredentialsForCluster(job, peerConf); }
> }
> However, in current code base, other uses of *hbase.security.authentication*
> are all case-insensitive. For example in *MasterFileSystem.java.*
> public MasterFileSystem(Configuration conf) throws IOException
> { ... this.isSecurityEnabled =
> "kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication")); ... }
> Users may misconfigured the parameter because of the case-senstive problem.
> *How To Fix*
> Using *eqaulsIgnoreCase* API consistently in every place when using
> *hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
> mention it clearly)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Description:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf = HBaseConfiguration.createClusterConf(job
.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf);
}
}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException {
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
was:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
!截屏2020-04-14下午7.57.45.png|width=531,height=176!
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException
{ ... this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication")); ... }
The doc in GitHub repo is also misleading
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
>
> private void initCredentialsForHBase(String zookeeper, Job job) throws
> IOException {
> Configuration peerConf = HBaseConfiguration.createClusterConf(job
> .getConfiguration(), zookeeper);
> if(peerConf.get("hbase.security.authentication").equals("kerberos")){
> TableMapReduceUtil.initCredentialsForCluster(job, peerConf);
> }
> }
> However, in current code base, other uses of *hbase.security.authentication*
> are all case-insensitive. For example in *MasterFileSystem.java.*
> public MasterFileSystem(Configuration conf) throws IOException {
> ...
> this.isSecurityEnabled =
> "kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
> ...
> }
> Users may misconfigured the parameter because of the case-senstive problem.
> *How To Fix*
> Using *eqaulsIgnoreCase* API consistently in every place when using
> *hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
> mention it clearly)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Description:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
!截屏2020-04-14下午7.57.45.png|width=531,height=176!
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException
{ ... this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication")); ... }
The doc in GitHub repo is also misleading
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
was:
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf = HBaseConfiguration.createClusterConf(job
.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf);
}
}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException {
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
> !截屏2020-04-14下午7.57.45.png|width=531,height=176!
>
> However, in current code base, other uses of *hbase.security.authentication*
> are all case-insensitive. For example in *MasterFileSystem.java.*
> public MasterFileSystem(Configuration conf) throws IOException
> { ... this.isSecurityEnabled =
> "kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication")); ... }
> The doc in GitHub repo is also misleading
>
> Users may misconfigured the parameter because of the case-senstive problem.
> *How To Fix*
> Using *eqaulsIgnoreCase* API consistently in every place when using
> *hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
> mention it clearly)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Attachment: (was: 截屏2020-04-14下午7.57.45.png)
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
> !截屏2020-04-14下午7.57.45.png|width=531,height=176!
>
> However, in current code base, other uses of *hbase.security.authentication*
> are all case-insensitive. For example in *MasterFileSystem.java.*
> public MasterFileSystem(Configuration conf) throws IOException
> { ... this.isSecurityEnabled =
> "kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication")); ... }
> The doc in GitHub repo is also misleading
>
> Users may misconfigured the parameter because of the case-senstive problem.
> *How To Fix*
> Using *eqaulsIgnoreCase* API consistently in every place when using
> *hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
> mention it clearly)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Attachment: 截屏2020-04-14下午7.57.45.png
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
> Attachments: 截屏2020-04-14下午7.57.45.png
>
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
>
> private void initCredentialsForHBase(String zookeeper, Job job) throws
> IOException {
> Configuration peerConf = HBaseConfiguration.createClusterConf(job
> .getConfiguration(), zookeeper);
> if(peerConf.get("hbase.security.authentication").equals("kerberos")){
> TableMapReduceUtil.initCredentialsForCluster(job, peerConf);
> }
> }
> However, in current code base, other uses of *hbase.security.authentication*
> are all case-insensitive. For example in *MasterFileSystem.java.*
>
> public MasterFileSystem(Configuration conf) throws IOException {
> ...
> this.isSecurityEnabled =
> "kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
> ...
> }
> Users may misconfigured the parameter because of the case-senstive problem.
> *How To Fix*
> Using *eqaulsIgnoreCase* API consistently in every place when using
> *hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
> mention it clearly)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Attachment: (was: 截屏2020-04-14下午7.57.15.png)
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
>
> private void initCredentialsForHBase(String zookeeper, Job job) throws
> IOException {
> Configuration peerConf = HBaseConfiguration.createClusterConf(job
> .getConfiguration(), zookeeper);
> if(peerConf.get("hbase.security.authentication").equals("kerberos")){
> TableMapReduceUtil.initCredentialsForCluster(job, peerConf);
> }
> }
> However, in current code base, other uses of *hbase.security.authentication*
> are all case-insensitive. For example in *MasterFileSystem.java.*
>
> public MasterFileSystem(Configuration conf) throws IOException {
> ...
> this.isSecurityEnabled =
> "kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
> ...
> }
> Users may misconfigured the parameter because of the case-senstive problem.
> *How To Fix*
> Using *eqaulsIgnoreCase* API consistently in every place when using
> *hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
> mention it clearly)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
[
https://issues.apache.org/jira/browse/HBASE-24190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbuzhang updated HBASE-24190:
-
Attachment: 截屏2020-04-14下午7.57.15.png
> Case-sensitive use of configuration parameter hbase.security.authentication
> ---
>
> Key: HBASE-24190
> URL: https://issues.apache.org/jira/browse/HBASE-24190
> Project: HBase
> Issue Type: Bug
> Components: conf
>Reporter: zhangbuzhang
>Priority: Major
>
> In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
> （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
> The code added
> ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
> for the use of *hbase.security.authentication* is case-sensitive. So users
> setting it to “KERBEROS” won’t take effect.
>
> private void initCredentialsForHBase(String zookeeper, Job job) throws
> IOException {
> Configuration peerConf = HBaseConfiguration.createClusterConf(job
> .getConfiguration(), zookeeper);
> if(peerConf.get("hbase.security.authentication").equals("kerberos")){
> TableMapReduceUtil.initCredentialsForCluster(job, peerConf);
> }
> }
> However, in current code base, other uses of *hbase.security.authentication*
> are all case-insensitive. For example in *MasterFileSystem.java.*
>
> public MasterFileSystem(Configuration conf) throws IOException {
> ...
> this.isSecurityEnabled =
> "kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
> ...
> }
> Users may misconfigured the parameter because of the case-senstive problem.
> *How To Fix*
> Using *eqaulsIgnoreCase* API consistently in every place when using
> *hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
> mention it clearly)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-24190) Case-sensitive use of configuration parameter hbase.security.authentication
zhangbuzhang created HBASE-24190:
Summary: Case-sensitive use of configuration parameter
hbase.security.authentication
Key: HBASE-24190
URL: https://issues.apache.org/jira/browse/HBASE-24190
Project: HBase
Issue Type: Bug
Components: conf
Reporter: zhangbuzhang
In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586)
（commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ）
The code added
([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3])
for the use of *hbase.security.authentication* is case-sensitive. So users
setting it to “KERBEROS” won’t take effect.
private void initCredentialsForHBase(String zookeeper, Job job) throws
IOException {
Configuration peerConf = HBaseConfiguration.createClusterConf(job
.getConfiguration(), zookeeper);
if(peerConf.get("hbase.security.authentication").equals("kerberos")){
TableMapReduceUtil.initCredentialsForCluster(job, peerConf);
}
}
However, in current code base, other uses of *hbase.security.authentication*
are all case-insensitive. For example in *MasterFileSystem.java.*
public MasterFileSystem(Configuration conf) throws IOException {
...
this.isSecurityEnabled =
"kerberos".equalsIgnoreCase(conf.get("hbase.security.authentication"));
...
}
Users may misconfigured the parameter because of the case-senstive problem.
*How To Fix*
Using *eqaulsIgnoreCase* API consistently in every place when using
*hbase.security.authentication* or make it clear in Doc. (Current doc doesn't
mention it clearly)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack commented on issue #1440: HBASE-23113: Improve and add additional Netty configuration for RPC.
saintstack commented on issue #1440: HBASE-23113: Improve and add additional Netty configuration for RPC. URL: https://github.com/apache/hbase/pull/1440#issuecomment-613752836 Failures look related. Complaint about netty on construction of RegionServer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1440: HBASE-23113: Improve and add additional Netty configuration for RPC.
Apache-HBase commented on issue #1440: HBASE-23113: Improve and add additional Netty configuration for RPC. URL: https://github.com/apache/hbase/pull/1440#issuecomment-613750516 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 57s | branch-2 passed | | +1 :green_heart: | compile | 1m 34s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 11s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 30s | hbase-client in branch-2 failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 45s | the patch passed | | +1 :green_heart: | compile | 1m 33s | the patch passed | | +1 :green_heart: | javac | 1m 33s | the patch passed | | +1 :green_heart: | shadedjars | 5m 14s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 28s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 17s | hbase-client in the patch passed. | | -1 :x: | unit | 124m 9s | hbase-server in the patch failed. | | | | 153m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1440 | | JIRA Issue | HBASE-23113 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7bee9d0d4600 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / df3768cf2a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/testReport/ | | Max. process+thread count | 4005 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1440/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23987) NettyRpcClientConfigHelper will not share event loop by default which is incorrect
[ https://issues.apache.org/jira/browse/HBASE-23987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083714#comment-17083714 ] Michael Stack commented on HBASE-23987: --- Just pushed on branch-2.3 too. > NettyRpcClientConfigHelper will not share event loop by default which is > incorrect > -- > > Key: HBASE-23987 > URL: https://issues.apache.org/jira/browse/HBASE-23987 > Project: HBase > Issue Type: Bug > Components: Client, rpc >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23956) Use less resources running tests
[
https://issues.apache.org/jira/browse/HBASE-23956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083713#comment-17083713
]
Michael Stack commented on HBASE-23956:
---
Just pushed this patch and its addendum on branch-2.3 Wasn't there.
> Use less resources running tests
>
>
> Key: HBASE-23956
> URL: https://issues.apache.org/jira/browse/HBASE-23956
> Project: HBase
> Issue Type: Test
> Components: test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: Screen Shot 2020-03-09 at 10.11.26 PM.png, Screen Shot
> 2020-03-09 at 10.11.35 PM.png, Screen Shot 2020-03-09 at 10.20.08 PM.png,
> Screen Shot 2020-03-10 at 7.10.15 AM.png, Screen Shot 2020-03-10 at 7.10.28
> AM.png
>
>
> Our tests can create thousands of threads all up in the one JVM. Using less
> means less memory, less contention, likelier passes, and later, more possible
> parallelism.
> I've been studying the likes of TestNamespaceReplicationWithBulkLoadedData to
> see what it does as it runs (this test puts up 4 clusters with replication
> between). It peaks at 2k threads. After some configuration and using less
> HDFS, its possible to get it down to ~800 threads and about 1/2 the
> memory-used. HDFS is a main offender. DataXceivers (Server and Client), jetty
> threads, Volume threads (async disk 'worker' then another for cleanup...),
> image savers, ipc clients -- new thread per incoming connection w/o bound (or
> reuse), block responder threads, anonymous threads, and so on. Many are not
> configurable or boundable or are hard-coded; e.g. each volume gets 4 workers
> regardless. Biggest impact was just downing the count of data nodes. TODO: a
> follow-on that turns down DN counts in all tests.
> I've been using Java Flight Recorder during this study. Here is how you get a
> flight recorder for the a single test run: \{code:java} MAVEN_OPTS="
> -XX:StartFlightRecording=disk=true,dumponexit=true,filename=recording.jfr,settings=profile,path-to-gc-roots=true,maxsize=1024m"
> mvn test -Dtest=TestNamespaceReplicationWithBulkLoadedData
> -Dsurefire.firstPartForkCount=0 -Dsurefire.secondPartForkCount=0 \{code} i.e.
> start recording on mvn launch, bound the size of the recording, and have the
> test run in the mvn context (DON'T fork). Useful is connecting to the running
> test at the same time from JDK Mission Control. We do the latter because the
> thread reporting screen is overwhelmed by the count of running threads and if
> you connect live, you can at least get a 'live threads' graph w/ count as the
> test progresses. Useful. When the test finishes, it dumps a .jfr file which
> can be opened in JDK MC.
> I've been compiling w/ JDK8 and then running w/ JDK11 so I can use JDK MC
> Version 7, the non-commercial latest. Works pretty well. Let me put up a
> patch for tests that cuts down thread counts where we can.
> Let me put up a patch that does first pass on curtailing resource usage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore
Apache-HBase commented on issue #1513: HBASE-24188 PR Hanger. Ignore URL: https://github.com/apache/hbase/pull/1513#issuecomment-613742674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 46s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 1m 37s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 2m 48s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | checkstyle | 1m 36s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 3s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 3m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 38m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1513 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml | | uname | Linux f70b0a9e8cee 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / dc7fd7c32c | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1513/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24148) Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.
[ https://issues.apache.org/jira/browse/HBASE-24148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24148: -- Summary: Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. (was: Upgrade Thrift to 0.13.0) > Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs. > -- > > Key: HBASE-24148 > URL: https://issues.apache.org/jira/browse/HBASE-24148 > Project: HBase > Issue Type: Improvement > Components: Thrift >Affects Versions: 3.0.0 >Reporter: Tamas Penzes >Assignee: Tamas Penzes >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > In Apache Thrift all versions up to and including 0.12.0, a server or client > may run into an endless loop when feed with specific input data. Because the > issue had already been partially fixed in version 0.11.0, depending on the > installed version it affects only certain language bindings. > To be on the safe side, we could update to 0.13.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24148) Upgrade Thrift to 0.13.0
[ https://issues.apache.org/jira/browse/HBASE-24148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083704#comment-17083704 ] Michael Stack commented on HBASE-24148: --- Linking to HBASE-21791 which had us upgrade to thrift 0.12 because of CVEs. > Upgrade Thrift to 0.13.0 > > > Key: HBASE-24148 > URL: https://issues.apache.org/jira/browse/HBASE-24148 > Project: HBase > Issue Type: Improvement > Components: Thrift >Affects Versions: 3.0.0 >Reporter: Tamas Penzes >Assignee: Tamas Penzes >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > In Apache Thrift all versions up to and including 0.12.0, a server or client > may run into an endless loop when feed with specific input data. Because the > issue had already been partially fixed in version 0.11.0, depending on the > installed version it affects only certain language bindings. > To be on the safe side, we could update to 0.13.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24148) Upgrade Thrift to 0.13.0
[ https://issues.apache.org/jira/browse/HBASE-24148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24148: -- Fix Version/s: 2.3.0 3.0.0 > Upgrade Thrift to 0.13.0 > > > Key: HBASE-24148 > URL: https://issues.apache.org/jira/browse/HBASE-24148 > Project: HBase > Issue Type: Improvement > Components: Thrift >Affects Versions: 3.0.0 >Reporter: Tamas Penzes >Assignee: Tamas Penzes >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > In Apache Thrift all versions up to and including 0.12.0, a server or client > may run into an endless loop when feed with specific input data. Because the > issue had already been partially fixed in version 0.11.0, depending on the > installed version it affects only certain language bindings. > To be on the safe side, we could update to 0.13.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24148) Upgrade Thrift to 0.13.0
[ https://issues.apache.org/jira/browse/HBASE-24148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083703#comment-17083703 ] Michael Stack commented on HBASE-24148: --- Thrift 0.12.0, which has two known CVE: CVE-2019-0205 and CVE-2019-0210. Bringing into 2.3.0 for consideration. > Upgrade Thrift to 0.13.0 > > > Key: HBASE-24148 > URL: https://issues.apache.org/jira/browse/HBASE-24148 > Project: HBase > Issue Type: Improvement > Components: Thrift >Affects Versions: 3.0.0 >Reporter: Tamas Penzes >Assignee: Tamas Penzes >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > In Apache Thrift all versions up to and including 0.12.0, a server or client > may run into an endless loop when feed with specific input data. Because the > issue had already been partially fixed in version 0.11.0, depending on the > installed version it affects only certain language bindings. > To be on the safe side, we could update to 0.13.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1517: HBASE-23697 Document new RegionProcedureStore operation and migration
Apache-HBase commented on issue #1517: HBASE-23697 Document new RegionProcedureStore operation and migration URL: https://github.com/apache/hbase/pull/1517#issuecomment-613739363 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 34s | master passed | | +0 :ok: | refguide | 4m 50s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 12s | the patch passed | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +0 :ok: | refguide | 4m 46s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 19m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1517/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1517 | | Optional Tests | dupname asflicense refguide | | uname | Linux 09c27a4bd4f4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1517/1/artifact/yetus-general-check/output/branch-site/book.html | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1517/1/artifact/yetus-general-check/output/whitespace-eol.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1517/1/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 79 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1517/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24137) The max merge count of metafixer should be configurable in MetaFixer
[
https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083699#comment-17083699
]
Nick Dimiduk commented on HBASE-24137:
--
It is already configurable. Try it out for yourself by editing hbase-site.xml
By default:
{noformat}
$ cat conf/hbase-site.xml
$ bin/hbase org.apache.hadoop.hbase.util.HBaseConfTool
hbase.master.metafixer.max.merge.count
null
{noformat}
Here, "null" means the default will be read from code, as you can see, a value
of 10.
Now edit the config file, override the value.
{noformat}
$ cat conf/hbase-site.xml
hbase.master.metafixer.max.merge.count100
$ bin/hbase org.apache.hadoop.hbase.util.HBaseConfTool
hbase.master.metafixer.max.merge.count
100
{noformat}
To [~stack]'s point in the PR, we could do a better job advertising this
configuration point in the book or hbase-default.xml or the like.
> The max merge count of metafixer should be configurable in MetaFixer
>
>
> Key: HBASE-24137
> URL: https://issues.apache.org/jira/browse/HBASE-24137
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Yu Wang
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 24137_master_1.patch
>
>
> The max merge count of metafixer should be configurable in MetaFixer
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1517: HBASE-23697 Document new RegionProcedureStore operation and migration
Apache-HBase commented on issue #1517: HBASE-23697 Document new RegionProcedureStore operation and migration URL: https://github.com/apache/hbase/pull/1517#issuecomment-613734380 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1517/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1517 | | Optional Tests | | | uname | Linux eed8a4914a9f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | Max. process+thread count | 54 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1517/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1517: HBASE-23697 Document new RegionProcedureStore operation and migration
Apache-HBase commented on issue #1517: HBASE-23697 Document new RegionProcedureStore operation and migration URL: https://github.com/apache/hbase/pull/1517#issuecomment-613734394 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1517/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1517 | | Optional Tests | | | uname | Linux 8f2c90851b06 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 38954edb25 | | Max. process+thread count | 47 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1517/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack opened a new pull request #1517: HBASE-23697 Document new RegionProcedureStore operation and migration
saintstack opened a new pull request #1517: HBASE-23697 Document new RegionProcedureStore operation and migration URL: https://github.com/apache/hbase/pull/1517 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23994) Add WebUI to Canary
[
https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-23994:
-
Release Note:
The Canary tool now offers a WebUI when run in `region` mode (the default
mode). It is enabled by default, and by default, it binds to `0.0.0.0:16050`.
This can be overridden by setting `hbase.canary.info.bindAddress` and
`hbase.canary.info.port`. To disable entirely, set the port to `-1`.
> Add WebUI to Canary
>
>
> Key: HBASE-23994
> URL: https://issues.apache.org/jira/browse/HBASE-23994
> Project: HBase
> Issue Type: Improvement
> Components: canary, UI, Usability
>Affects Versions: 3.0.0
>Reporter: Zhuoyue Huang
>Assignee: Zhuoyue Huang
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
> Attachments: image-2020-03-16-09-12-00-595.png
>
>
> During the running of Canary, the table sniff failure information will be
> printed through the Log.
> {code:java}
> LOG.error("Read from {} on {}", table, server);
> {code}
>
> I think we can use WebUI to display these failures to make it easier for us
> to view this information
>
> !image-2020-03-16-09-12-00-595.png!
> As shown in the figure above, we can directly see the Table and Regionserver
> where the error occurred
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23994) Add WebUI to Canary
[
https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-23994:
-
Component/s: (was: website)
Usability
UI
> Add WebUI to Canary
>
>
> Key: HBASE-23994
> URL: https://issues.apache.org/jira/browse/HBASE-23994
> Project: HBase
> Issue Type: Improvement
> Components: canary, UI, Usability
>Affects Versions: 3.0.0
>Reporter: Zhuoyue Huang
>Assignee: Zhuoyue Huang
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
> Attachments: image-2020-03-16-09-12-00-595.png
>
>
> During the running of Canary, the table sniff failure information will be
> printed through the Log.
> {code:java}
> LOG.error("Read from {} on {}", table, server);
> {code}
>
> I think we can use WebUI to display these failures to make it easier for us
> to view this information
>
> !image-2020-03-16-09-12-00-595.png!
> As shown in the figure above, we can directly see the Table and Regionserver
> where the error occurred
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-23994) Add WebUI to Canary
[
https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk resolved HBASE-23994.
--
Fix Version/s: 2.3.0
3.0.0
Resolution: Fixed
Applied to branch-2.3+. [~GeorryHuang] if you'd like to prepare a patch for
branch-1, we can back port it there as well. Thanks for the nice contribution!
> Add WebUI to Canary
>
>
> Key: HBASE-23994
> URL: https://issues.apache.org/jira/browse/HBASE-23994
> Project: HBase
> Issue Type: Improvement
> Components: canary, website
>Affects Versions: 3.0.0
>Reporter: Zhuoyue Huang
>Assignee: Zhuoyue Huang
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
> Attachments: image-2020-03-16-09-12-00-595.png
>
>
> During the running of Canary, the table sniff failure information will be
> printed through the Log.
> {code:java}
> LOG.error("Read from {} on {}", table, server);
> {code}
>
> I think we can use WebUI to display these failures to make it easier for us
> to view this information
>
> !image-2020-03-16-09-12-00-595.png!
> As shown in the figure above, we can directly see the Table and Regionserver
> where the error occurred
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ndimiduk merged pull request #1516: Backport "HBASE-23994: Add WebUI to Canary (#1292)" to branch-2.3
ndimiduk merged pull request #1516: Backport "HBASE-23994: Add WebUI to Canary (#1292)" to branch-2.3 URL: https://github.com/apache/hbase/pull/1516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk opened a new pull request #1516: Backport "HBASE-23994: Add WebUI to Canary (#1292)" to branch-2.3
ndimiduk opened a new pull request #1516: Backport "HBASE-23994: Add WebUI to Canary (#1292)" to branch-2.3 URL: https://github.com/apache/hbase/pull/1516 Signed-off-by: Duo Zhang Signed-off-by: Nick Dimiduk This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1515: Backport "HBASE-23994: Add WebUI to Canary (#1292)" to branch-2
Apache-HBase commented on issue #1515: Backport "HBASE-23994: Add WebUI to Canary (#1292)" to branch-2 URL: https://github.com/apache/hbase/pull/1515#issuecomment-613725395 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | patch | 0m 7s | https://github.com/apache/hbase/pull/1515 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/1515 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1515/1/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1515: Backport "HBASE-23994: Add WebUI to Canary (#1292)" to branch-2
Apache-HBase commented on issue #1515: Backport "HBASE-23994: Add WebUI to Canary (#1292)" to branch-2 URL: https://github.com/apache/hbase/pull/1515#issuecomment-613725378 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | patch | 0m 6s | https://github.com/apache/hbase/pull/1515 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/1515 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1515/1/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
