[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra
ddupg commented on a change in pull request #1782:
URL: https://github.com/apache/hbase/pull/1782#discussion_r443107712
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java
##
@@ -114,4 +115,12 @@ static RSGroupInfoManager create(MasterServices master)
throws IOException {
*/
void renameRSGroup(String oldName, String newName) throws IOException;
+ /**
+ * Update RSGroup configuration
+ * @param groupName the group name
+ * @param configuration new configuration of the group name to be set
+ * @throws IOException if a remote or network exception occurs
+ */
+ void updateRSGroupConfig(String groupName, Map
configuration) throws IOException;
+
Review comment:
I've changed the methods accessing the map in RSGroupInfo.
```
public Map getConfiguration() {
return Collections.unmodifiableMap(configuration);
}
public void setConfiguration(String key, String value) {
if (value == null) {
removeConfiguration(key);
} else {
configuration.put(key, value);
}
}
public void removeConfiguration(final String key) {
configuration.remove(key);
}
```
and rewrote the impl of RSGroupInfoManagerImpl.updateRSGroupConfig.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra
ddupg commented on a change in pull request #1782:
URL: https://github.com/apache/hbase/pull/1782#discussion_r443107302
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##
@@ -1244,4 +1244,11 @@ public synchronized void renameRSGroup(String oldName,
String newName) throws IO
setRSGroup(updateTables, newName);
}
+ @Override
+ public synchronized void updateRSGroupConfig(String groupName, Map configuration)
+ throws IOException {
+RSGroupInfo rsGroupInfo = getRSGroupInfo(groupName);
Review comment:
Already loged in MaterRpcServices.updateRSGroupConfig like this
```
LOG.info("{} update rsgroup {} configuration {}",
master.getClientIdAuditPrefix(), groupName,
configuration);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] ZhaoBQ commented on a change in pull request #1901: HBASE-24560 Add a new option of designatedfile in RegionMover
ZhaoBQ commented on a change in pull request #1901:
URL: https://github.com/apache/hbase/pull/1901#discussion_r443106788
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java
##
@@ -435,6 +451,10 @@ public boolean unload() throws InterruptedException,
ExecutionException, Timeout
LOG.debug("List of region servers: {}", regionServers);
return false;
}
+// Remove RS present not in the designated file
+if (designatedFile != null) {
+ filterDesignatedServers(regionServers);
Review comment:
I haven't thought of how to elegantly combine excludeFile and
designedFile in one method. Could you please give some advice?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…
Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-646940157 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 20s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 6m 7s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 1s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | shadedjars | 6m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 235m 23s | hbase-server in the patch failed. | | | | 262m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1935 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux afcdceb63442 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3c31981179 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/testReport/ | | Max. process+thread count | 3480 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…
Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-646939442 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 9s | master passed | | +1 :green_heart: | compile | 1m 18s | master passed | | +1 :green_heart: | shadedjars | 6m 37s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 47s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 46s | the patch passed | | +1 :green_heart: | compile | 1m 14s | the patch passed | | +1 :green_heart: | javac | 1m 14s | the patch passed | | +1 :green_heart: | shadedjars | 6m 46s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 50s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 221m 57s | hbase-server in the patch failed. | | | | 253m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1935 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6033a2470a26 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3c31981179 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/testReport/ | | Max. process+thread count | 3121 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1936: HBASE-23126: Removing the un-used integration test class - IntegrationTestRSGroup
Apache-HBase commented on pull request #1936: URL: https://github.com/apache/hbase/pull/1936#issuecomment-646937896 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 57s | master passed | | +1 :green_heart: | checkstyle | 0m 18s | master passed | | +1 :green_heart: | spotbugs | 0m 0s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | checkstyle | 0m 16s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 49s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 0m 0s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 27m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1936 | | JIRA Issue | HBASE-23126 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 6b63360405e5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3c31981179 | | Max. process+thread count | 78 (vs. ulimit of 12500) | | modules | C: hbase-it U: hbase-it | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1936: HBASE-23126: Removing the un-used integration test class - IntegrationTestRSGroup
Apache-HBase commented on pull request #1936: URL: https://github.com/apache/hbase/pull/1936#issuecomment-646937718 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 4s | master passed | | +1 :green_heart: | compile | 0m 32s | master passed | | +1 :green_heart: | shadedjars | 6m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 17s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 37s | the patch passed | | +1 :green_heart: | compile | 0m 32s | the patch passed | | +1 :green_heart: | javac | 0m 32s | the patch passed | | +1 :green_heart: | shadedjars | 6m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 51s | hbase-it in the patch passed. | | | | 26m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1936 | | JIRA Issue | HBASE-23126 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux dc8e030d64ea 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3c31981179 | | Default Java | 2020-01-14 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/testReport/ | | Max. process+thread count | 661 (vs. ulimit of 12500) | | modules | C: hbase-it U: hbase-it | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1936: HBASE-23126: Removing the un-used integration test class - IntegrationTestRSGroup
Apache-HBase commented on pull request #1936: URL: https://github.com/apache/hbase/pull/1936#issuecomment-646937316 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 13s | master passed | | +1 :green_heart: | compile | 0m 24s | master passed | | +1 :green_heart: | shadedjars | 6m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 53s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 6m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 53s | hbase-it in the patch passed. | | | | 24m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1936 | | JIRA Issue | HBASE-23126 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 01c6f3894954 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3c31981179 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/testReport/ | | Max. process+thread count | 657 (vs. ulimit of 12500) | | modules | C: hbase-it U: hbase-it | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1936/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sandeepvinayak commented on pull request #1936: HBASE-23126: Removing the un-used integration test class - IntegrationTestRSGroup
sandeepvinayak commented on pull request #1936: URL: https://github.com/apache/hbase/pull/1936#issuecomment-646932565 @Apache9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sandeepvinayak opened a new pull request #1936: HBASE-23126: Removing the un-used integration test class - IntegrationTestRSGroup
sandeepvinayak opened a new pull request #1936: URL: https://github.com/apache/hbase/pull/1936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24550) Passing '-h' or '--help' to bin/hbase doesn't do as expected
[
https://issues.apache.org/jira/browse/HBASE-24550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140926#comment-17140926
]
Hudson commented on HBASE-24550:
Results for branch branch-2
[build #2711 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2711/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2711/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2711/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2711/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2711/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Passing '-h' or '--help' to bin/hbase doesn't do as expected
>
>
> Key: HBASE-24550
> URL: https://issues.apache.org/jira/browse/HBASE-24550
> Project: HBase
> Issue Type: Bug
> Components: Operability, shell
>Reporter: Michael Stack
>Assignee: wenfeiyi666
>Priority: Trivial
> Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0, 2.1.10, 2.2.6
>
>
> If I do 'bin/hbase -h' or './bin/hbase --help', it doesn't dump usage as I'd
> expect. Instead, the param gets passed direct to the jvm for it to spew
> complaint that the param is unrecognized.
> Should do the right thing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24516) Parameter copyFiles should be passed in SecureBulkLoadClient
[
https://issues.apache.org/jira/browse/HBASE-24516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140925#comment-17140925
]
Hudson commented on HBASE-24516:
Results for branch branch-2
[build #2711 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2711/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2711/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2711/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2711/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2711/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Parameter copyFiles should be passed in SecureBulkLoadClient
>
>
> Key: HBASE-24516
> URL: https://issues.apache.org/jira/browse/HBASE-24516
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Affects Versions: 2.2.2, 2.2.5
>Reporter: Qilin Cao
>Assignee: Qilin Cao
>Priority: Minor
> Fix For: 2.3.1, 2.2.6
>
> Attachments: HBASE-24516.branch-2.2.patch
>
>
> When refactor SecureBulkLoadClient started in HBASE-22380. The public
> secureBulkLoadHFiles method parameter copyFiles was not passed to the
> refactoring method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-24373) Implement JvmMetrics in HBase instead of using the one in hadoop
[ https://issues.apache.org/jira/browse/HBASE-24373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24373. --- Resolution: Later > Implement JvmMetrics in HBase instead of using the one in hadoop > > > Key: HBASE-24373 > URL: https://issues.apache.org/jira/browse/HBASE-24373 > Project: HBase > Issue Type: Sub-task > Components: logging, metrics >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > The JvmMetrics from hadoop is hard coded to use log4j. > Although we do not make use of the ability, it still prevents us to ban the > log4j dependencies completely. > So let's implement the JvmMetrics by our own, based on log4j2. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 closed pull request #1714: HBASE-24373 Implement JvmMetrics in HBase instead of using the one in hadoop
Apache9 closed pull request #1714: URL: https://github.com/apache/hbase/pull/1714 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24550) Passing '-h' or '--help' to bin/hbase doesn't do as expected
[
https://issues.apache.org/jira/browse/HBASE-24550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140911#comment-17140911
]
Hudson commented on HBASE-24550:
Results for branch branch-2.2
[build #897 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/897/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/897//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/897//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/897//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Passing '-h' or '--help' to bin/hbase doesn't do as expected
>
>
> Key: HBASE-24550
> URL: https://issues.apache.org/jira/browse/HBASE-24550
> Project: HBase
> Issue Type: Bug
> Components: Operability, shell
>Reporter: Michael Stack
>Assignee: wenfeiyi666
>Priority: Trivial
> Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0, 2.1.10, 2.2.6
>
>
> If I do 'bin/hbase -h' or './bin/hbase --help', it doesn't dump usage as I'd
> expect. Instead, the param gets passed direct to the jvm for it to spew
> complaint that the param is unrecognized.
> Should do the right thing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24516) Parameter copyFiles should be passed in SecureBulkLoadClient
[
https://issues.apache.org/jira/browse/HBASE-24516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140910#comment-17140910
]
Hudson commented on HBASE-24516:
Results for branch branch-2.2
[build #897 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/897/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/897//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/897//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/897//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Parameter copyFiles should be passed in SecureBulkLoadClient
>
>
> Key: HBASE-24516
> URL: https://issues.apache.org/jira/browse/HBASE-24516
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Affects Versions: 2.2.2, 2.2.5
>Reporter: Qilin Cao
>Assignee: Qilin Cao
>Priority: Minor
> Fix For: 2.3.1, 2.2.6
>
> Attachments: HBASE-24516.branch-2.2.patch
>
>
> When refactor SecureBulkLoadClient started in HBASE-22380. The public
> secureBulkLoadHFiles method parameter copyFiles was not passed to the
> refactoring method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…
Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-646909968 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 7s | master passed | | +1 :green_heart: | checkstyle | 1m 14s | master passed | | +1 :green_heart: | spotbugs | 2m 8s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 45s | the patch passed | | -0 :warning: | checkstyle | 1m 11s | hbase-server: The patch generated 2 new + 6 unchanged - 0 fixed = 8 total (was 6) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 18s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 37m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1935 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 04b748f7652d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 3c31981179 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1935/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-24543) ScheduledChore logging is too chatty, replace with metrics
[
https://issues.apache.org/jira/browse/HBASE-24543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandeep Pal reassigned HBASE-24543:
---
Assignee: Sandeep Pal
> ScheduledChore logging is too chatty, replace with metrics
> --
>
> Key: HBASE-24543
> URL: https://issues.apache.org/jira/browse/HBASE-24543
> Project: HBase
> Issue Type: Improvement
> Components: metrics, Operability
>Reporter: Andrew Kyle Purtell
>Assignee: Sandeep Pal
>Priority: Minor
>
> ScheduledChore logs at DEBUG level the execution time of each chore.
> We used to log an average execution time across all chores every five
> minutes, which by consensus was judged to not be useful. Derived metrics like
> averages or histograms should be calculated per chore. So we modified the
> logging to dump the chore execution time each time it runs, to facilitate
> such calculations with the log aggregation and searching tool of choice. Per
> chore execution logging is more useful, in that sense, but may be too chatty.
> This is not unexpected but let me provide my observations so we can revisit
> this.
> On the master, for example, this is logged every second:
> {noformat}
> 2020-06-11 16:35:28,263 DEBUG
> [master/apurtell-ltm:8100.splitLogManager..Chore.1] hbase.ScheduledChore:
> SplitLogManager Timeout Monitor execution time: 0 ms.
> {noformat}
> Does the value of these lines outweigh the cost of 86,400 log lines per day
> per master instance? (At least.)
> On the regionserver it is somewhat better, these are logged every 10 seconds:
> {noformat}
> 2020-06-11 16:37:57,203 DEBUG [regionserver/apurtell-ltm:8120.Chore.1]
> hbase.ScheduledChore: CompactionChecker execution time: 0 ms.
> 2020-06-11 16:37:57,203 DEBUG [regionserver/apurtell-ltm:8120.Chore.1]
> hbase.ScheduledChore: MemstoreFlusherChore execution time: 0 ms.
> {noformat}
> So that will be 17,280 log lines per day per regionserver. (At least.)
> These could be moved to TRACE level, perhaps.
> I propose we replace this logging with histogram metrics. There should be a
> separate metric for each distinct chore classname, allocated as needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] skochhar opened a new pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…
skochhar opened a new pull request #1935: URL: https://github.com/apache/hbase/pull/1935 HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Namespace level When a namespace space quota is deleted, the namespace quota (q:s) row from hbase:quota table is removed, however the related u:p rows from tables in the namespace still stay. Removing the u:p rows for tables in the namespace to fix this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-23739) BoundedRecoveredHFilesOutputSink should read the table descriptor directly
[
https://issues.apache.org/jira/browse/HBASE-23739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140895#comment-17140895
]
Guanghao Zhang commented on HBASE-23739:
{quote}The Master hosts the hbase:meta table schema locally.
{quote}
Sir, can you explain more about this?
> BoundedRecoveredHFilesOutputSink should read the table descriptor directly
> --
>
> Key: HBASE-23739
> URL: https://issues.apache.org/jira/browse/HBASE-23739
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Read from meta or filesystem?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23739) BoundedRecoveredHFilesOutputSink should read the table descriptor directly
[
https://issues.apache.org/jira/browse/HBASE-23739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140894#comment-17140894
]
Guanghao Zhang commented on HBASE-23739:
{quote}But if there were pending compactions (eligible older files) this new
file's compaction will be delayed right?
{quote}
Yes. Just request a compaction after reopen. The compaction algorithm decide
which files will be compact.
> BoundedRecoveredHFilesOutputSink should read the table descriptor directly
> --
>
> Key: HBASE-23739
> URL: https://issues.apache.org/jira/browse/HBASE-23739
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Read from meta or filesystem?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24597) Port HBASE-24380 (Improve WAL splitting log lines to enable sessionization) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-24597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24597: Component/s: Operability > Port HBASE-24380 (Improve WAL splitting log lines to enable sessionization) > to branch-1 > --- > > Key: HBASE-24597 > URL: https://issues.apache.org/jira/browse/HBASE-24597 > Project: HBase > Issue Type: Sub-task > Components: logging, Operability, wal >Reporter: Andrew Kyle Purtell >Priority: Major > Fix For: 1.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24598) Port HBASE-24380 (Improve WAL splitting log lines to enable sessionization) to branch-2.2
[ https://issues.apache.org/jira/browse/HBASE-24598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24598: Component/s: Operability > Port HBASE-24380 (Improve WAL splitting log lines to enable sessionization) > to branch-2.2 > - > > Key: HBASE-24598 > URL: https://issues.apache.org/jira/browse/HBASE-24598 > Project: HBase > Issue Type: Sub-task > Components: logging, Operability, wal >Reporter: Andrew Kyle Purtell >Priority: Major > Fix For: 2.2.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24380) Improve WAL splitting log lines to enable sessionization
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24380: Fix Version/s: 2.4.0 2.3.1 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Merged PR. Picked with minor fixups to branch-2. Picked cleanly from there to branch-2.3. Opened subtasks for backport to branch-2.2 and branch-1. > Improve WAL splitting log lines to enable sessionization > > > Key: HBASE-24380 > URL: https://issues.apache.org/jira/browse/HBASE-24380 > Project: HBase > Issue Type: Improvement > Components: logging, Operability, wal >Reporter: Andrew Kyle Purtell >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0 > > > Looking to reconstruct a timeline from write of recovered.edits file back to > start of WAL file split, with a bunch of unrelated activity in the meantime, > there isn't a consistent token that links split file write messages (which > include store path including region hash) to beginning of WAL splitting > activity. Sessonizing by host doesn't work because work can bounce around > through retries. Thread context names in the logs vary and can be like > [nds1-225-fra:60020-7] or [fb472085572ba72e96f1] (trailing digits of region > hash) or [splits-1589016325868] . > We could have WALSplitter get the current time when starting the split of a > WAL file and have it log this timestamp in every line as a splitting session > identifier. > Related, we should track the time of split task execution end to end and > export a metric that captures it. > It might also be worthwhile to wire up more of WAL splitting to TaskMonitor > status logging. If we do this we can also enable status journal logging, so > when a WAL split has completed, a line will appear in the log that has the > list of all status messages recorded during splitting and the time delta in > milliseconds between them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24598) Port HBASE-24380 (Improve WAL splitting log lines to enable sessionization) to branch-2.2
Andrew Kyle Purtell created HBASE-24598: --- Summary: Port HBASE-24380 (Improve WAL splitting log lines to enable sessionization) to branch-2.2 Key: HBASE-24598 URL: https://issues.apache.org/jira/browse/HBASE-24598 Project: HBase Issue Type: Sub-task Components: logging, wal Reporter: Andrew Kyle Purtell Fix For: 2.2.6 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24597) Port HBASE-24380 (Improve WAL splitting log lines to enable sessionization) to branch-1
Andrew Kyle Purtell created HBASE-24597: --- Summary: Port HBASE-24380 (Improve WAL splitting log lines to enable sessionization) to branch-1 Key: HBASE-24597 URL: https://issues.apache.org/jira/browse/HBASE-24597 Project: HBase Issue Type: Sub-task Components: logging, wal Reporter: Andrew Kyle Purtell Fix For: 1.7.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] apurtell commented on pull request #1860: HBASE-24380 : Provide WAL splitting journal logging
apurtell commented on pull request #1860: URL: https://github.com/apache/hbase/pull/1860#issuecomment-646896275 Picking back... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell merged pull request #1860: HBASE-24380 : Provide WAL splitting journal logging
apurtell merged pull request #1860: URL: https://github.com/apache/hbase/pull/1860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1934: HBASE-24594 : Separate resource allocation for TestReplicationStatusSink
Apache-HBase commented on pull request #1934: URL: https://github.com/apache/hbase/pull/1934#issuecomment-646887023 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 49s | master passed | | +1 :green_heart: | compile | 1m 12s | master passed | | +1 :green_heart: | shadedjars | 6m 33s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 43s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 39s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | shadedjars | 6m 26s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 193m 50s | hbase-server in the patch passed. | | | | 223m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1934/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1934 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cc0b1b4a4dc0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b62c0b6d2 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1934/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1934/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1934/1/testReport/ | | Max. process+thread count | 3659 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1934/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1934: HBASE-24594 : Separate resource allocation for TestReplicationStatusSink
Apache-HBase commented on pull request #1934: URL: https://github.com/apache/hbase/pull/1934#issuecomment-646874190 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 43s | master passed | | +1 :green_heart: | compile | 0m 55s | master passed | | +1 :green_heart: | shadedjars | 5m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 5m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 147m 22s | hbase-server in the patch passed. | | | | 171m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1934/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1934 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 020981788c02 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b62c0b6d2 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1934/1/testReport/ | | Max. process+thread count | 3981 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1934/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24559) Fix logging in tests
[ https://issues.apache.org/jira/browse/HBASE-24559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24559: - Fix Version/s: master Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the review, Marc. > Fix logging in tests > > > Key: HBASE-24559 > URL: https://issues.apache.org/jira/browse/HBASE-24559 > Project: HBase > Issue Type: Sub-task > Components: Client, native-client >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Major > Fix For: master > > > In the current tests, glog/gflags etc are not initialized before running the > tests. This results in logging to stderr by default. Fix the initialization > so that we can redirect the logging to the appropriate log files/directories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-native-client] bharathv merged pull request #8: HBASE-24559: Fix test logging initialization
bharathv merged pull request #8: URL: https://github.com/apache/hbase-native-client/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] bharathv commented on a change in pull request #8: HBASE-24559: Fix test logging initialization
bharathv commented on a change in pull request #8:
URL: https://github.com/apache/hbase-native-client/pull/8#discussion_r443025886
##
File path: src/hbase/test-util/test-util.cc
##
@@ -18,81 +18,17 @@
*/
#include "hbase/test-util/test-util.h"
-#include
-#include
+#include
+#include
+#include
-#include "hbase/client/zk-util.h"
+using std::string;
-using hbase::TestUtil;
-using folly::Random;
-
-std::string TestUtil::RandString(int len) {
- // Create the whole string.
- // Filling everything with z's
- auto s = std::string(len, 'z');
-
- // Now pick a bunch of random numbers
- for (int i = 0; i < len; i++) {
-// use Folly's random to get the numbers
-// as I don't want to have to learn
-// all the cpp rand invocation magic.
-auto r = Random::rand32('a', 'z');
-// Cast that to ascii.
-s[i] = static_cast(r);
+namespace hbase {
+ string TestUtil::get_exec_path() {
+char result[ PATH_MAX ];
+ssize_t count = readlink( "/proc/self/exe", result, PATH_MAX );
Review comment:
Good point, I missed it, thanks. Switched to
boost::dll::program_location for now and enforced min version to 1.6.1. That
should be ok I guess
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1934: HBASE-24594 : Separate resource allocation for TestReplicationStatusSink
Apache-HBase commented on pull request #1934: URL: https://github.com/apache/hbase/pull/1934#issuecomment-646831640 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 41s | master passed | | +1 :green_heart: | checkstyle | 1m 6s | master passed | | +1 :green_heart: | spotbugs | 1m 57s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | -0 :warning: | checkstyle | 1m 3s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 9s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 32m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1934/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1934 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 1565b6bbbce5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b62c0b6d2 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1934/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1934/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani opened a new pull request #1934: HBASE-24594 : Separate resource allocation for TestReplicationStatusSink
virajjasani opened a new pull request #1934: URL: https://github.com/apache/hbase/pull/1934 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24589) In HBase UI, srcChecksum has bad content
[ https://issues.apache.org/jira/browse/HBASE-24589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew Foley updated HBASE-24589: -- Description: The value of srcChecksum displayed in the HBase UI is generated at build time by https://github.com/apache/hbase/blob/master/hbase-common/src/saveVersion.sh#L53-L61 On a Linux build host, if `openssl`(v 1.1.1) is available, the resulting value of srcChecksum is `(stdin)=` else if `gpg` (v 2.2.19) is available, the value is only the first 8-character substring of the sha512 hash. On a Mac build host, if `openssl`(LibreSSL 2.8.3) is available, the resulting value of srcChecksum is correct else if `gpg` (v 2.2.19) is available, the value is again the first 8-character substring of the sha512 hash. Furthermore, while "sha512" is well defined and gives the same value from all four programs, the associated leader text for file names has a different format, and gpg generates uppercase hex divided into 8-character blocks while openssl generates lowercase hex in a single string. Either of these differences will cause the sum-of-sums generated by openssl and gpg to be different! Which is unacceptable if srcChecksum is to be used for validation. was: The value of srcChecksum displayed in the HBase UI is generated at build time by https://github.com/apache/hbase/blob/master/hbase-common/src/saveVersion.sh#L53-L61 On a Linux build host, if `openssl`(v 1.1.1) is available, the resulting value of srcChecksum is `(stdin)=` else if `gpg` (v 2.2.19) is available, the value is only the first 8-character substring of the sha512 hash. On a Mac build host, if `openssl`(LibreSSL 2.8.3) is available, the resulting value of srcChecksum is correct else if `gpg` (v 2.2.19) is available, the value is again the first 8-character substring of the sha512 hash. Furthermore, while "sha512" is well defined and gives the same value from all four programs, the associated leader text for file names has a different format, therefore the sum-of-sums generated by openssl and gpg will be different! Which is unacceptable if srcChecksum is to be used for validation. > In HBase UI, srcChecksum has bad content > > > Key: HBASE-24589 > URL: https://issues.apache.org/jira/browse/HBASE-24589 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0-alpha-1, 2.3.0 >Reporter: Matthew Foley >Assignee: Matthew Foley >Priority: Minor > > The value of srcChecksum displayed in the HBase UI is generated at build time > by > https://github.com/apache/hbase/blob/master/hbase-common/src/saveVersion.sh#L53-L61 > On a Linux build host, > if `openssl`(v 1.1.1) is available, the resulting value of srcChecksum is > `(stdin)=` > else if `gpg` (v 2.2.19) is available, the value is only the first > 8-character substring of the sha512 hash. > On a Mac build host, > if `openssl`(LibreSSL 2.8.3) is available, the resulting value of srcChecksum > is correct > else if `gpg` (v 2.2.19) is available, the value is again the first > 8-character substring of the sha512 hash. > Furthermore, while "sha512" is well defined and gives the same value from all > four programs, the associated leader text for file names has a different > format, and gpg generates uppercase hex divided into 8-character blocks while > openssl generates lowercase hex in a single string. Either of these > differences will cause the sum-of-sums generated by openssl and gpg to be > different! Which is unacceptable if srcChecksum is to be used for validation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24550) Passing '-h' or '--help' to bin/hbase doesn't do as expected
[ https://issues.apache.org/jira/browse/HBASE-24550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24550. -- Fix Version/s: 1.7.0 Resolution: Fixed > Passing '-h' or '--help' to bin/hbase doesn't do as expected > > > Key: HBASE-24550 > URL: https://issues.apache.org/jira/browse/HBASE-24550 > Project: HBase > Issue Type: Bug > Components: Operability, shell >Reporter: Michael Stack >Assignee: wenfeiyi666 >Priority: Trivial > Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0, 2.1.10, 2.2.6 > > > If I do 'bin/hbase -h' or './bin/hbase --help', it doesn't dump usage as I'd > expect. Instead, the param gets passed direct to the jvm for it to spew > complaint that the param is unrecognized. > Should do the right thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani closed pull request #1930: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
virajjasani closed pull request #1930: URL: https://github.com/apache/hbase/pull/1930 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani closed pull request #1931: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
virajjasani closed pull request #1931: URL: https://github.com/apache/hbase/pull/1931 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #1931: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
virajjasani commented on pull request #1931: URL: https://github.com/apache/hbase/pull/1931#issuecomment-646773572 Closing this PR as branch-1.0 is not active. branch-1 PR is sufficient. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani closed pull request #1932: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
virajjasani closed pull request #1932: URL: https://github.com/apache/hbase/pull/1932 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-23739) BoundedRecoveredHFilesOutputSink should read the table descriptor directly
[ https://issues.apache.org/jira/browse/HBASE-23739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140712#comment-17140712 ] Michael Stack commented on HBASE-23739: --- I tried removing fetch of TD and just using defaults. Basically works. Need to verify no dataloss still. We could go this route. Another thought which is to make it so the getTableDescriptor worked even though the Master is 'not' initialized WHEN the request is for details on the hbase:meta table. The Master hosts the hbase:meta table schema locally so queries could just succeed. Let me try it > BoundedRecoveredHFilesOutputSink should read the table descriptor directly > -- > > Key: HBASE-23739 > URL: https://issues.apache.org/jira/browse/HBASE-23739 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > Read from meta or filesystem? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24596) Document general framework to execute remote procedure on RegionServer
Michael Stack created HBASE-24596: - Summary: Document general framework to execute remote procedure on RegionServer Key: HBASE-24596 URL: https://issues.apache.org/jira/browse/HBASE-24596 Project: HBase Issue Type: Sub-task Components: documentation Reporter: Michael Stack Document -- probably best in javadoc -- the system added by HBASE-19216 'Implement a general framework to execute remote procedure on RS ' for having procedures run tasks on remote regionservers. The system evolved a good while ago in HBASE-19216 to manage replication peers. It was then adopted by the new procedure-based distributed WAL splitting feature with some worry that the latter didn't use the framework properly (so far, all looks good). This issue is about vetting the distributed WAL splitters usage and doc'ing the framework as I go. This framework is useful. Others will want to exploit it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24585) Failed start recovering crash in standalone mode if procedure-based distributed WAL split & hbase.wal.split.to.hfile=true
[
https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-24585:
--
Description:
(This description got redone after I figured out what was going on. Previously
it was just a litany of me banging around trying to learn procedure-based WAL
splitting and hbase.wal.split.to.hfile; no one needs to read that; hence the
refactor).
HBASE-24574 procedure-based distributed WAL splitting is enabled and
split-to-hflie too. A force crash requires recovery with ServerCrashProcedure
splitting old WALs on restart. The recovery fails because we get stuck. The
Master can't assign meta because it is being recovered. The recovery can't make
progress because it is asking for a table descriptor for meta -- needed by the
hbase.wal.split.to.hfile feature -- and the master is not yet initialized.
After the default timeout, Master shuts down because it can't initialize.
{code}
2020-06-18 19:53:54,175 ERROR [main] master.HMasterCommandLine: Master exiting
java.lang.RuntimeException: Master not initialized after 20ms
at
org.apache.hadoop.hbase.util.JVMClusterUtil.waitForEvent(JVMClusterUtil.java:232)
at
org.apache.hadoop.hbase.util.JVMClusterUtil.startup(JVMClusterUtil.java:200)
at
org.apache.hadoop.hbase.LocalHBaseCluster.startup(LocalHBaseCluster.java:430)
at
org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:232)
at
org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
at
org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)
at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3059)
{code}
The abort of Master interrupts other ongoing actions so later in the log we'll
see the WAL split show as interrupted
{code}
2020-06-17 21:20:37,472 ERROR
[RS_LOG_REPLAY_OPS-regionserver/localhost:16020-0] handler.RSProcedureHandler:
Error when call RSProcedureCallable:
java.io.IOException: Failed WAL split, status=RESIGNED,
wal=file:/Users/stack/checkouts/hbase.apache.git/tmp/hbase/WALs/localhost,16020,1592440848604-splitting/localhost%2C16020%2C1592440848604.meta.1592440852959.meta
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.splitWal(SplitWALCallable.java:106)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:86)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:49)
at
org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49)
at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}
This issue becomes how to make hbase.wal.split.to.hfile work in standalone mode.
was:
(This description got redone after I figured out what was going on. Previously
it was just a litany of me banging around trying to learn procedure-based WAL
splitting and hbase.wal.split.to.hfile; no one needs to read that; hence the
refactor).
HBASE-24574 procedure-based distributed WAL splitting is enabled and
split-to-hflie too. A force crash requires recovery with ServerCrashProcedure
splitting old WALs on restart. The recovery fails because we get stuck. The
Master can't assign meta because it is being recovered. The recovery can't make
progress because it is asking for a table descriptor for meta -- needed by the
hbase.wal.split.to.hfile feature -- and the master is not yet initialized.
After the default timeout, Master shuts down because it can't initialize.
The abort of Master interrupts other ongoing actions so later in the log we'll
see the WAL split show as interrupted
{code}
2020-06-17 21:20:37,472 ERROR
[RS_LOG_REPLAY_OPS-regionserver/localhost:16020-0] handler.RSProcedureHandler:
Error when call RSProcedureCallable:
java.io.IOException: Failed WAL split, status=RESIGNED,
wal=file:/Users/stack/checkouts/hbase.apache.git/tmp/hbase/WALs/localhost,16020,1592440848604-splitting/localhost%2C16020%2C1592440848604.meta.1592440852959.meta
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.splitWal(SplitWALCallable.java:106)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:86)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:49)
at
org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49)
at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Work
[jira] [Updated] (HBASE-24585) Failed start recovering crash in standalone mode if procedure-based distributed WAL split & hbase.wal.split.to.hfile=true
[
https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-24585:
--
Description:
(This description got redone after I figured out what was going on. Previously
it was just a litany of me banging around trying to learn procedure-based WAL
splitting and hbase.wal.split.to.hfile; no one needs to read that; hence the
refactor).
HBASE-24574 procedure-based distributed WAL splitting is enabled and
split-to-hflie too. A force crash requires recovery with ServerCrashProcedure
splitting old WALs on restart. The recovery fails because we get stuck. The
Master can't assign meta because it is being recovered. The recovery can't make
progress because it is asking for a table descriptor for meta -- needed by the
hbase.wal.split.to.hfile feature -- and the master is not yet initialized.
After the default timeout, Master shuts down because it can't initialize.
The abort of Master interrupts other ongoing actions so later in the log we'll
see the WAL split show as interrupted
{code}
2020-06-17 21:20:37,472 ERROR
[RS_LOG_REPLAY_OPS-regionserver/localhost:16020-0] handler.RSProcedureHandler:
Error when call RSProcedureCallable:
java.io.IOException: Failed WAL split, status=RESIGNED,
wal=file:/Users/stack/checkouts/hbase.apache.git/tmp/hbase/WALs/localhost,16020,1592440848604-splitting/localhost%2C16020%2C1592440848604.meta.1592440852959.meta
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.splitWal(SplitWALCallable.java:106)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:86)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:49)
at
org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49)
at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}
This issue becomes how to make hbase.wal.split.to.hfile work in standalone mode.
was:
(This description got redone after I figured out what was going on. Previously
it was just a litany of me banging around trying to learn procedure-based WAL
splitting and hbase.wal.split.to.hfile; no one needs to read that; hence the
refactor).
HBASE-24574 procedure-based distributed WAL splitting is enabled and
split-to-hflie too. A force crash requires recovery with ServerCrashProcedure
splitting old WALs on restart. The recovery fails because we get stuck. The
Master can't assign meta because it is being recovered. The recovery can't make
progress because it is asking for a table descriptor for meta -- needed by the
hbase.wal.split.to.hfile feature -- and the master is not yet initialized.
After the default timeout, Master shuts down because it can't initialize.
The abort of Master interrupts other ongoing actions so later in the log we'll
see the WAL split show as interrupted
{code}
2020-06-17 21:20:37,472 ERROR
[RS_LOG_REPLAY_OPS-regionserver/localhost:16020-0] handler.RSProcedureHandler:
Error when call RSProcedureCallable:
java.io.IOException: Failed WAL split, status=RESIGNED,
wal=file:/Users/stack/checkouts/hbase.apache.git/tmp/hbase/WALs/localhost,16020,1592440848604-splitting/localhost%2C16020%2C1592440848604.meta.1592440852959.meta
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.splitWal(SplitWALCallable.java:106)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:86)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:49)
at
org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49)
at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}
This issue becomes how to make hbase.wal.split.to.hfile work in standalone mode.
While here, need to document
> Failed start recovering crash in standalone mode if procedure-based
> distributed WAL split & hbase.wal.split.to.hfile=true
> -
>
> Key: HBASE-24585
> URL: https://issues.apache.org/jira/browse/HBASE-24585
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
>
> (This description got redone after I figured out what was going on.
> Previously it was just a litany of me banging around trying to learn
[jira] [Updated] (HBASE-24585) Failed start recovering crash in standalone mode if procedure-based distributed WAL split & hbase.wal.split.to.hfile=true
[
https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-24585:
--
Description:
(This description got redone after I figured out what was going on. Previously
it was just a litany of me banging around trying to learn procedure-based WAL
splitting and hbase.wal.split.to.hfile; no one needs to read that; hence the
refactor).
HBASE-24574 procedure-based distributed WAL splitting is enabled and
split-to-hflie too. A force crash requires recovery with ServerCrashProcedure
splitting old WALs on restart. The recovery fails because we get stuck. The
Master can't assign meta because it is being recovered. The recovery can't make
progress because it is asking for a table descriptor for meta -- needed by the
hbase.wal.split.to.hfile feature -- and the master is not yet initialized.
After the default timeout, Master shuts down because it can't initialize.
The abort of Master interrupts other ongoing actions so later in the log we'll
see the WAL split show as interrupted
{code}
2020-06-17 21:20:37,472 ERROR
[RS_LOG_REPLAY_OPS-regionserver/localhost:16020-0] handler.RSProcedureHandler:
Error when call RSProcedureCallable:
java.io.IOException: Failed WAL split, status=RESIGNED,
wal=file:/Users/stack/checkouts/hbase.apache.git/tmp/hbase/WALs/localhost,16020,1592440848604-splitting/localhost%2C16020%2C1592440848604.meta.1592440852959.meta
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.splitWal(SplitWALCallable.java:106)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:86)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:49)
at
org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49)
at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}
This issue becomes how to make hbase.wal.split.to.hfile work in standalone mode.
While here, need to document
was:
HBASE-24574 proc v2 distributed log splitting is enabled. A remote split fails
because it was interrupted. The InterruptedException became an IOE and then
bubbled up and out of the RSPH below causing a RS abort.
{code}
2020-06-17 21:20:37,472 ERROR
[RS_LOG_REPLAY_OPS-regionserver/localhost:16020-0] handler.RSProcedureHandler:
Error when call RSProcedureCallable:
java.io.IOException: Failed WAL split, status=RESIGNED,
wal=file:/Users/stack/checkouts/hbase.apache.git/tmp/hbase/WALs/localhost,16020,1592440848604-splitting/localhost%2C16020%2C1592440848604.meta.1592440852959.meta
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.splitWal(SplitWALCallable.java:106)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:86)
at
org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:49)
at
org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49)
at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}
The remote-procedure framework needs to be more resilient? Log the exception
unless an ERROR and keep going? Otherwise, makes features like procedurev2
distributed log splitting brittle.
> Failed start recovering crash in standalone mode if procedure-based
> distributed WAL split & hbase.wal.split.to.hfile=true
> -
>
> Key: HBASE-24585
> URL: https://issues.apache.org/jira/browse/HBASE-24585
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
>
> (This description got redone after I figured out what was going on.
> Previously it was just a litany of me banging around trying to learn
> procedure-based WAL splitting and hbase.wal.split.to.hfile; no one needs to
> read that; hence the refactor).
> HBASE-24574 procedure-based distributed WAL splitting is enabled and
> split-to-hflie too. A force crash requires recovery with ServerCrashProcedure
> splitting old WALs on restart. The recovery fails because we get stuck. The
> Master can't assign meta because it is being recovered. The recovery can't
> make progress because it is asking for a table descriptor for meta -- needed
> by the hbase.wal.split.to.hfile feature -- and the master is not yet
> initi
[jira] [Updated] (HBASE-24585) Failed start recovering crash in standalone mode if procedure-based distributed WAL split & hbase.wal.split.to.hfile=true
[
https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-24585:
--
Summary: Failed start recovering crash in standalone mode if
procedure-based distributed WAL split & hbase.wal.split.to.hfile=true (was: If
RSProcedureHandler throws exception, it aborts the hosting RS)
> Failed start recovering crash in standalone mode if procedure-based
> distributed WAL split & hbase.wal.split.to.hfile=true
> -
>
> Key: HBASE-24585
> URL: https://issues.apache.org/jira/browse/HBASE-24585
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
>
> HBASE-24574 proc v2 distributed log splitting is enabled. A remote split
> fails because it was interrupted. The InterruptedException became an IOE and
> then bubbled up and out of the RSPH below causing a RS abort.
> {code}
> 2020-06-17 21:20:37,472 ERROR
> [RS_LOG_REPLAY_OPS-regionserver/localhost:16020-0]
> handler.RSProcedureHandler: Error when call RSProcedureCallable:
> java.io.IOException: Failed WAL split, status=RESIGNED,
> wal=file:/Users/stack/checkouts/hbase.apache.git/tmp/hbase/WALs/localhost,16020,1592440848604-splitting/localhost%2C16020%2C1592440848604.meta.1592440852959.meta
>at
> org.apache.hadoop.hbase.regionserver.SplitWALCallable.splitWal(SplitWALCallable.java:106)
>at
> org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:86)
>at
> org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:49)
>at
> org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49)
>at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
>at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>at java.lang.Thread.run(Thread.java:748)
> {code}
> The remote-procedure framework needs to be more resilient? Log the exception
> unless an ERROR and keep going? Otherwise, makes features like procedurev2
> distributed log splitting brittle.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan
Apache-HBase commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-646747091 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 36s | master passed | | +1 :green_heart: | compile | 1m 21s | master passed | | +1 :green_heart: | shadedjars | 5m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 0s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | compile | 1m 20s | the patch passed | | +1 :green_heart: | javac | 1m 20s | the patch passed | | +1 :green_heart: | shadedjars | 5m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | -1 :x: | unit | 140m 59s | hbase-server in the patch failed. | | | | 168m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1933 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e53be58f9a08 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/testReport/ | | Max. process+thread count | 4363 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan
Apache-HBase commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-646741743 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 10s | master passed | | +1 :green_heart: | compile | 1m 32s | master passed | | +1 :green_heart: | shadedjars | 5m 49s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 38s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 2s | the patch passed | | +1 :green_heart: | compile | 1m 33s | the patch passed | | +1 :green_heart: | javac | 1m 33s | the patch passed | | +1 :green_heart: | shadedjars | 5m 42s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 7s | hbase-client in the patch passed. | | -1 :x: | unit | 133m 44s | hbase-server in the patch failed. | | | | 163m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1933 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cc3f55dd5477 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/testReport/ | | Max. process+thread count | 4168 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1929: HBASE-24205 Create metric to know the number of reads that happens from memstore
Apache-HBase commented on pull request #1929: URL: https://github.com/apache/hbase/pull/1929#issuecomment-646734466 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ branch-2.2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 13s | branch-2.2 passed | | +1 :green_heart: | compile | 1m 32s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 1m 55s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 4m 56s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 7s | branch-2.2 passed | | +0 :ok: | spotbugs | 4m 12s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 22s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 17s | the patch passed | | +1 :green_heart: | compile | 1m 29s | the patch passed | | +1 :green_heart: | javac | 1m 29s | the patch passed | | -1 :x: | checkstyle | 1m 26s | hbase-server: The patch generated 2 new + 91 unchanged - 1 fixed = 93 total (was 92) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 27m 35s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | javadoc | 1m 2s | the patch passed | | +1 :green_heart: | findbugs | 4m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 32s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 0m 36s | hbase-hadoop2-compat in the patch passed. | | -1 :x: | unit | 165m 28s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 13s | The patch does not generate ASF License warnings. | | | | 243m 25s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.quotas.TestSpaceQuotaBasicFunctioning | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1929 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8a5a27fdd94b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1929/out/precommit/personality/provided.sh | | git revision | branch-2.2 / e7f17fe68d | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/2/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/2/testReport/ | | Max. process+thread count | 5111 (vs. ulimit of 1) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Attachment: hmaster.log > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > Attachments: create_namespace_1.png, create_namespace_2.png, > hmaster.log, hmaster.png, hmaster_4569.jstack, hregionserver.log, > hregionserver_25649.jstack, procedure.png > > > environment: > jdk:1.8.0_181 > hadoop: 3.1.1 > hbase: 2.1.6 > hbase shell create namespace blocked when all datanodes has restarted > in kerberos environment, > but create it successfully without kerberos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Attachment: hregionserver.log > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > Attachments: create_namespace_1.png, create_namespace_2.png, > hmaster.log, hmaster.png, hmaster_4569.jstack, hregionserver.log, > hregionserver_25649.jstack, procedure.png > > > environment: > jdk:1.8.0_181 > hadoop: 3.1.1 > hbase: 2.1.6 > hbase shell create namespace blocked when all datanodes has restarted > in kerberos environment, > but create it successfully without kerberos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Attachment: hmaster_4569.jstack > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > Attachments: create_namespace_1.png, create_namespace_2.png, > hmaster.png, hmaster_4569.jstack, hregionserver_25649.jstack, procedure.png > > > environment: > jdk:1.8.0_181 > hadoop: 3.1.1 > hbase: 2.1.6 > hbase shell create namespace blocked when all datanodes has restarted > in kerberos environment, > but create it successfully without kerberos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Attachment: hregionserver_25649.jstack > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > Attachments: create_namespace_1.png, create_namespace_2.png, > hmaster.png, hmaster_4569.jstack, hregionserver_25649.jstack, procedure.png > > > environment: > jdk:1.8.0_181 > hadoop: 3.1.1 > hbase: 2.1.6 > hbase shell create namespace blocked when all datanodes has restarted > in kerberos environment, > but create it successfully without kerberos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Attachment: create_namespace_2.png create_namespace_1.png > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > Attachments: create_namespace_1.png, create_namespace_2.png, > hmaster.png, procedure.png > > > environment: > jdk:1.8.0_181 > hadoop: 3.1.1 > hbase: 2.1.6 > hbase shell create namespace blocked when all datanodes has restarted > in kerberos environment, > but create it successfully without kerberos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Attachment: procedure.png > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > Attachments: hmaster.png, procedure.png > > > environment: > jdk:1.8.0_181 > hadoop: 3.1.1 > hbase: 2.1.6 > hbase shell create namespace blocked when all datanodes has restarted > in kerberos environment, > but create it successfully without kerberos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Attachment: hmaster.png > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > Attachments: hmaster.png, procedure.png > > > environment: > jdk:1.8.0_181 > hadoop: 3.1.1 > hbase: 2.1.6 > hbase shell create namespace blocked when all datanodes has restarted > in kerberos environment, > but create it successfully without kerberos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Description: environment: jdk:1.8.0_181 hadoop: 3.1.1 hbase: 2.1.6 hbase shell create namespace blocked when all datanodes has restarted in kerberos environment, but create it successfully without kerberos was: environment: jdk:1.8.0_181 hadoop: 3.1.1 hbase: 2.1.6 hbase shell create namespace blocked when all datanodes has restarted in kerberos environment but create it successfully without kerberos > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > > environment: > jdk:1.8.0_181 > hadoop: 3.1.1 > hbase: 2.1.6 > hbase shell create namespace blocked when all datanodes has restarted > in kerberos environment, > but create it successfully without kerberos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Description: environment: jdk:1.8.0_181 hadoop: 3.1.1 hbase: 2.1.6 hbase shell create namespace blocked when all datanodes has restarted in kerberos environment but create it successfully without kerberos was: environment: jdk:1.8.0_181 hadoop: 3.1.1 hbase: 2.1.6 > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > > environment: > jdk:1.8.0_181 > hadoop: 3.1.1 > hbase: 2.1.6 > hbase shell create namespace blocked when all datanodes has restarted > in kerberos environment but create it successfully without kerberos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Description: environment: jdk:1.8.0_181 hadoop: 3.1.1 hbase: 2.1.6 > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > > environment: > jdk:1.8.0_181 > hadoop: 3.1.1 > hbase: 2.1.6 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Component/s: (was: hbase-thirdparty) > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
[ https://issues.apache.org/jira/browse/HBASE-24595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated HBASE-24595: Component/s: hbase-thirdparty > hbase create namespace blocked when all datanodes has restarted > --- > > Key: HBASE-24595 > URL: https://issues.apache.org/jira/browse/HBASE-24595 > Project: HBase > Issue Type: Bug > Components: hbase-thirdparty >Affects Versions: 2.1.6 >Reporter: Yu Wang >Priority: Critical > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24595) hbase create namespace blocked when all datanodes has restarted
Yu Wang created HBASE-24595: --- Summary: hbase create namespace blocked when all datanodes has restarted Key: HBASE-24595 URL: https://issues.apache.org/jira/browse/HBASE-24595 Project: HBase Issue Type: Bug Affects Versions: 2.1.6 Reporter: Yu Wang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24579) Failed SASL authentication does not result in an exception on client side
[
https://issues.apache.org/jira/browse/HBASE-24579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140636#comment-17140636
]
Hudson commented on HBASE-24579:
Results for branch master
[build #1761 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Failed SASL authentication does not result in an exception on client side
> -
>
> Key: HBASE-24579
> URL: https://issues.apache.org/jira/browse/HBASE-24579
> Project: HBase
> Issue Type: Bug
> Components: rpc
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0, 2.2.5
>Reporter: Szabolcs Bukros
>Assignee: Szabolcs Bukros
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0
>
>
> When HBaseSaslRpcClient.saslConnect tries to authenticate it only reads the
> input stream if the process is not complete yet. However if the
> authentication failed and the process is completed the exception sent back in
> the stream never gets read.
> We should always try to read the input stream even if the process is complete
> to make sure it was empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24574) Procedure V2 - Distributed WAL Splitting => LOGGING
[
https://issues.apache.org/jira/browse/HBASE-24574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140637#comment-17140637
]
Hudson commented on HBASE-24574:
Results for branch master
[build #1761 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Procedure V2 - Distributed WAL Splitting => LOGGING
> ---
>
> Key: HBASE-24574
> URL: https://issues.apache.org/jira/browse/HBASE-24574
> Project: HBase
> Issue Type: Sub-task
> Components: wal
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.1
>
>
> The procedure-based distributed WAL splitter uses the old SplitLogManager
> class. It registers it as a chore even though the chore #run immediately
> skips out. Meantime we log SLM ran in #0ms frequently. For example...
> {code}
> ...
> 2020-06-17 17:48:30,567 DEBUG [localhost:16000.splitLogManager..Chore.1]
> hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms.
> 2020-06-17 17:48:31,567 DEBUG [localhost:16000.splitLogManager..Chore.1]
> hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms.
> 2020-06-17 17:48:32,570 DEBUG [localhost:16000.splitLogManager..Chore.1]
> hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms.
> 2020-06-17 17:48:33,567 DEBUG [localhost:16000.splitLogManager..Chore.1]
> hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms.
> 2020-06-17 17:48:34,569 DEBUG [localhost:16000.splitLogManager..Chore.1]
> hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms.
> 2020-06-17 17:48:35,569 DEBUG [localhost:16000.splitLogManager..Chore.1]
> hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms.
> 2020-06-17 17:48:36,568 DEBUG [localhost:16000.splitLogManager..Chore.1]
> hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms.
> ...
> {code}
> The new pv2 WAL splitter introduces new procedures that log their class name
> only w/o detail on log that is being split or the server that is running the
> split.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24550) Passing '-h' or '--help' to bin/hbase doesn't do as expected
[
https://issues.apache.org/jira/browse/HBASE-24550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140635#comment-17140635
]
Hudson commented on HBASE-24550:
Results for branch master
[build #1761 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1761/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Passing '-h' or '--help' to bin/hbase doesn't do as expected
>
>
> Key: HBASE-24550
> URL: https://issues.apache.org/jira/browse/HBASE-24550
> Project: HBase
> Issue Type: Bug
> Components: Operability, shell
>Reporter: Michael Stack
>Assignee: wenfeiyi666
>Priority: Trivial
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0, 2.1.10, 2.2.6
>
>
> If I do 'bin/hbase -h' or './bin/hbase --help', it doesn't dump usage as I'd
> expect. Instead, the param gets passed direct to the jvm for it to spew
> complaint that the param is unrecognized.
> Should do the right thing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp
Apache-HBase commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-646699392 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 40s | master passed | | +1 :green_heart: | compile | 2m 27s | master passed | | +1 :green_heart: | shadedjars | 5m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 29s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | compile | 2m 23s | the patch passed | | +1 :green_heart: | javac | 2m 23s | the patch passed | | +1 :green_heart: | shadedjars | 5m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 46s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 7s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 138m 34s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 0m 44s | hbase-hbtop in the patch passed. | | | | 171m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1926 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d885e740b9be 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/testReport/ | | Max. process+thread count | 4340 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-hbtop U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp
Apache-HBase commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-646695282 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 56s | master passed | | +1 :green_heart: | compile | 2m 46s | master passed | | +1 :green_heart: | shadedjars | 5m 39s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 17s | hbase-hbtop in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 57s | the patch passed | | +1 :green_heart: | compile | 2m 47s | the patch passed | | +1 :green_heart: | javac | 2m 47s | the patch passed | | +1 :green_heart: | shadedjars | 5m 48s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 17s | hbase-hbtop in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 58s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 5s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 127m 55s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 0m 47s | hbase-hbtop in the patch passed. | | | | 162m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1926 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux df7e66b2c622 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hbtop.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hbtop.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/testReport/ | | Max. process+thread count | 4453 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-hbtop U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Reidddddd commented on pull request #1923: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count
Reidd commented on pull request #1923: URL: https://github.com/apache/hbase/pull/1923#issuecomment-646693495 Sorry, i think your request messes things up, and makes this simple improvement complicated, far away from my intention. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-24588) Normalizer plan execution is not consistent between plan types
[
https://issues.apache.org/jira/browse/HBASE-24588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140320#comment-17140320
]
Viraj Jasani edited comment on HBASE-24588 at 6/19/20, 2:46 PM:
{quote}the calling context should handle the resolution of those futures in a
single place.
{quote}
HMaster should call future.get() for all tables after plans are submitted for
all tables. That might be better right? And if polling throws any Exception, we
log it only at one place: HMaster(caller) and we maintain a count say
normalizationPlanFailureCount and if it is helpful, maybe expose it in metric?
Thought?
was (Author: vjasani):
{quote}the calling context should handle the resolution of those futures in a
single place.
{quote}
HMaster should call future.get() for all tables after plans are submitted for
all tables? That might be better right? And if polling throws any Exception, we
log it only at one place: HMaster and we maintain a count say
splitPlanFailedCount, mergePlanFailedCount and if it is helpful, maybe expose
them as metrics? Thought?
> Normalizer plan execution is not consistent between plan types
> --
>
> Key: HBASE-24588
> URL: https://issues.apache.org/jira/browse/HBASE-24588
> Project: HBase
> Issue Type: Bug
> Components: master, Normalizer
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0
>
>
> I left a comment on a merged
> [commit|https://github.com/apache/hbase/commit/5d0e0fc5fd09bddb2d766d1e24e28e472961f454#r39987289]
> where a little discussion has blossomed. Right now the normalizer produces
> two types of plans: "split" or "merge". The master receives the list of plans
> and executes them in a simple loop. The way it does the actual execution is
> delegated off to the plan implementation.
> The bug I noticed is that the two implementations are subtly different. Both
> use async APIs to submit procedures, but "split" blocks on completion while
> "merge" does not. Furthermore, because "split" blocks, it's able to capture
> any exception that's thrown, while "merge" cannot.
> These implementations should be made consistent. My thinking at the moment is
> this {{execute}} method should instead be named {{submit}}, creating and
> returning the {{Future}} that represents whatever work it submitted, and the
> calling context should handle the resolution of those futures in a single
> place.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24516) Parameter copyFiles should be passed in SecureBulkLoadClient
[
https://issues.apache.org/jira/browse/HBASE-24516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140603#comment-17140603
]
Hudson commented on HBASE-24516:
Results for branch branch-2.3
[build #146 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/146/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/146/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/146/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/146/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/146/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Parameter copyFiles should be passed in SecureBulkLoadClient
>
>
> Key: HBASE-24516
> URL: https://issues.apache.org/jira/browse/HBASE-24516
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Affects Versions: 2.2.2, 2.2.5
>Reporter: Qilin Cao
>Assignee: Qilin Cao
>Priority: Minor
> Fix For: 2.3.1, 2.2.6
>
> Attachments: HBASE-24516.branch-2.2.patch
>
>
> When refactor SecureBulkLoadClient started in HBASE-22380. The public
> secureBulkLoadHFiles method parameter copyFiles was not passed to the
> refactoring method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan
Apache-HBase commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-646670431 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 36s | master passed | | +1 :green_heart: | checkstyle | 1m 33s | master passed | | +1 :green_heart: | spotbugs | 2m 55s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | -0 :warning: | checkstyle | 1m 4s | hbase-server: The patch generated 2 new + 103 unchanged - 0 fixed = 105 total (was 103) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 4s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. | | | | 36m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1933 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux b0e0ce2c675c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1933/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-23927) hbck2 assigns command should accept one or more files containing a list of region names
[ https://issues.apache.org/jira/browse/HBASE-23927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23927: - Description: Currently, *assigns* command accepts a list of region names as parameter. When dealing with a very large number of regions, though, passing all regions encoded name as the command parameters becomes too much overhead for the CLI. We should accept a path to one or more file that contains these encoded regions, one per line. That way, this command tails nicely into an operator's incantation using grep/sed over log files. (was: Currently, *assigns* command accepts a list of region names on the command line. When dealing with a very large number of regions, though, passing all regions encoded name as the command parameters becomes too much overhead for the CLI. We should accept a path to one or more file that contains these encoded regions, one per line. That way, this command tails nicely into an operator's incantation using grep/sed over log files.) > hbck2 assigns command should accept one or more files containing a list of > region names > --- > > Key: HBASE-23927 > URL: https://issues.apache.org/jira/browse/HBASE-23927 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools, hbck2, Operability, Usability >Affects Versions: hbase-operator-tools-1.0.0 >Reporter: Nick Dimiduk >Assignee: Clara Xiong >Priority: Major > Fix For: hbase-operator-tools-1.1.0 > > > Currently, *assigns* command accepts a list of region names as parameter. > When dealing with a very large number of regions, though, passing all regions > encoded name as the command parameters becomes too much overhead for the CLI. > We should accept a path to one or more file that contains these encoded > regions, one per line. That way, this command tails nicely into an operator's > incantation using grep/sed over log files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23927) hbck2 assigns command should accept one or more files containing a list of region names
[ https://issues.apache.org/jira/browse/HBASE-23927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23927: - Description: Currently, *assigns* command accepts a list of region names on the command line. When dealing with a very large number of regions, though, passing all regions encoded name as the command parameters becomes too much overhead for the CLI. We should accept a path to one or more file that contains these encoded regions, one per line. That way, this command tails nicely into an operator's incantation using grep/sed over log files. (was: The interface is not very ergonomic. Currently the command accepts a list of region names on the command line. When dealing with a very large number of regions, though, passing all regions encoded name as the command parameters becomes too much overhead for the CLI. We should accept a path to one or more file that contains these encoded regions, one per line. That way, this command tails nicely into an operator's incantation using grep/sed over log files.) > hbck2 assigns command should accept one or more files containing a list of > region names > --- > > Key: HBASE-23927 > URL: https://issues.apache.org/jira/browse/HBASE-23927 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools, hbck2, Operability, Usability >Affects Versions: hbase-operator-tools-1.0.0 >Reporter: Nick Dimiduk >Assignee: Clara Xiong >Priority: Major > Fix For: hbase-operator-tools-1.1.0 > > > Currently, *assigns* command accepts a list of region names on the command > line. When dealing with a very large number of regions, though, passing all > regions encoded name as the command parameters becomes too much overhead for > the CLI. We should accept a path to one or more file that contains these > encoded regions, one per line. That way, this command tails nicely into an > operator's incantation using grep/sed over log files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23927) hbck2 assigns command should accept one or more files containing a list of region names
[ https://issues.apache.org/jira/browse/HBASE-23927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-23927: - Description: The interface is not very ergonomic. Currently the command accepts a list of region names on the command line. When dealing with a very large number of regions, though, passing all regions encoded name as the command parameters becomes too much overhead for the CLI. We should accept a path to one or more file that contains these encoded regions, one per line. That way, this command tails nicely into an operator's incantation using grep/sed over log files. (was: The interface is not very ergonomic. Currently the command accepts a list of region names on the command line. If you have 100's of regions to assign, this sucks. We should accept a path to one or more file that contains these encoded regions, one per line. That way, this command tails nicely into an operator's incantation using grep/sed over log files.) > hbck2 assigns command should accept one or more files containing a list of > region names > --- > > Key: HBASE-23927 > URL: https://issues.apache.org/jira/browse/HBASE-23927 > Project: HBase > Issue Type: Improvement > Components: hbase-operator-tools, hbck2, Operability, Usability >Affects Versions: hbase-operator-tools-1.0.0 >Reporter: Nick Dimiduk >Assignee: Clara Xiong >Priority: Major > Fix For: hbase-operator-tools-1.1.0 > > > The interface is not very ergonomic. Currently the command accepts a list of > region names on the command line. When dealing with a very large number of > regions, though, passing all regions encoded name as the command parameters > becomes too much overhead for the CLI. We should accept a path to one or more > file that contains these encoded regions, one per line. That way, this > command tails nicely into an operator's incantation using grep/sed over log > files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #69: HBASE-24587 hbck2 command should accept one or more files containing …
wchevreuil commented on a change in pull request #69:
URL:
https://github.com/apache/hbase-operator-tools/pull/69#discussion_r442869982
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##
@@ -203,8 +204,8 @@ int setRegionState(ClusterConnection connection, String
region,
Map> report;
try (final FsRegionsMetaRecoverer fsRegionsMetaRecoverer =
new FsRegionsMetaRecoverer(this.conf)) {
- report = fsRegionsMetaRecoverer.reportTablesMissingRegions(
-formatNameSpaceTableParam(nameSpaceOrTable));
+ report =
fsRegionsMetaRecoverer.reportTablesMissingRegions(getFromArgsOrFiles(
Review comment:
Missing UT and updates to `reportMissingRegionsInMeta` command
description (as it now accepts list of files)
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##
@@ -297,21 +292,8 @@ int setRegionState(ClusterConnection connection, String
region,
return null;
}
boolean overrideFlag = commandLine.hasOption(override.getOpt());
-
List argList = commandLine.getArgList();
-if (!commandLine.hasOption(inputFile.getOpt())) {
- return hbck.assigns(argList, overrideFlag);
-}
-List assignmentList = new ArrayList<>();
-for (String filePath : argList) {
- try (InputStream fileStream = new FileInputStream(filePath)){
-LineIterator it = IOUtils.lineIterator(fileStream, "UTF-8");
-while (it.hasNext()) {
- assignmentList.add(it.nextLine().trim());
-}
- }
-}
-return hbck.assigns(assignmentList, overrideFlag);
+return hbck.assigns(this.getFromArgsOrFiles(argList), overrideFlag);
Review comment:
Missing UT and updates to `setRegionState` command description (as it
now accepts list of files)
##
File path: hbase-hbck2/README.md
##
@@ -280,6 +281,9 @@ Command:
of what a userspace encoded region name looks like. For example:
$ HBCK2 unassign 1588230740 de00010733901a05f5a2a3a382e27dd4
Returns the pid(s) of the created UnassignProcedure(s) or -1 if none.
+ If -i or --inputFiles is specified, pass one or more input file names.
Review comment:
We should modify the command params description on line #274 to:
`unassigns `
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##
@@ -265,16 +266,12 @@ int setRegionState(ClusterConnection connection, String
region,
return result;
}
- private List formatNameSpaceTableParam(String... nameSpaceOrTable) {
-return nameSpaceOrTable != null ? Arrays.asList(nameSpaceOrTable) : null;
- }
-
List>> addMissingRegionsInMetaForTables(String...
nameSpaceOrTable) throws IOException {
try (final FsRegionsMetaRecoverer fsRegionsMetaRecoverer =
new FsRegionsMetaRecoverer(this.conf)) {
- return fsRegionsMetaRecoverer.addMissingRegionsInMetaForTables(
-formatNameSpaceTableParam(nameSpaceOrTable));
+ return
fsRegionsMetaRecoverer.addMissingRegionsInMetaForTables(getFromArgsOrFiles(
Review comment:
Missing UT and updates to `addFsRegionsMissingInMeta` command
description (as it now accepts list of files)
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##
@@ -228,7 +229,7 @@ int setRegionState(ClusterConnection connection, String
region,
Map> result = new HashMap<>();
try (final FsRegionsMetaRecoverer fsRegionsMetaRecoverer =
new FsRegionsMetaRecoverer(this.conf)) {
- List namespacesTables =
formatNameSpaceTableParam(commandLine.getArgs());
+ List namespacesTables =
getFromArgsOrFiles(formatNameSpaceTableParam(commandLine.getArgs()));
Review comment:
Missing UT and updates to `extraRegionsInMeta` command description (as
it now accepts list of files)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work started] (HBASE-24588) Normalizer plan execution is not consistent between plan types
[
https://issues.apache.org/jira/browse/HBASE-24588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-24588 started by Viraj Jasani.
> Normalizer plan execution is not consistent between plan types
> --
>
> Key: HBASE-24588
> URL: https://issues.apache.org/jira/browse/HBASE-24588
> Project: HBase
> Issue Type: Bug
> Components: master, Normalizer
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Viraj Jasani
>Priority: Major
>
> I left a comment on a merged
> [commit|https://github.com/apache/hbase/commit/5d0e0fc5fd09bddb2d766d1e24e28e472961f454#r39987289]
> where a little discussion has blossomed. Right now the normalizer produces
> two types of plans: "split" or "merge". The master receives the list of plans
> and executes them in a simple loop. The way it does the actual execution is
> delegated off to the plan implementation.
> The bug I noticed is that the two implementations are subtly different. Both
> use async APIs to submit procedures, but "split" blocks on completion while
> "merge" does not. Furthermore, because "split" blocks, it's able to capture
> any exception that's thrown, while "merge" cannot.
> These implementations should be made consistent. My thinking at the moment is
> this {{execute}} method should instead be named {{submit}}, creating and
> returning the {{Future}} that represents whatever work it submitted, and the
> calling context should handle the resolution of those futures in a single
> place.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24588) Normalizer plan execution is not consistent between plan types
[
https://issues.apache.org/jira/browse/HBASE-24588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-24588:
-
Fix Version/s: 2.4.0
2.3.1
3.0.0-alpha-1
Status: Patch Available (was: In Progress)
> Normalizer plan execution is not consistent between plan types
> --
>
> Key: HBASE-24588
> URL: https://issues.apache.org/jira/browse/HBASE-24588
> Project: HBase
> Issue Type: Bug
> Components: master, Normalizer
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0
>
>
> I left a comment on a merged
> [commit|https://github.com/apache/hbase/commit/5d0e0fc5fd09bddb2d766d1e24e28e472961f454#r39987289]
> where a little discussion has blossomed. Right now the normalizer produces
> two types of plans: "split" or "merge". The master receives the list of plans
> and executes them in a simple loop. The way it does the actual execution is
> delegated off to the plan implementation.
> The bug I noticed is that the two implementations are subtly different. Both
> use async APIs to submit procedures, but "split" blocks on completion while
> "merge" does not. Furthermore, because "split" blocks, it's able to capture
> any exception that's thrown, while "merge" cannot.
> These implementations should be made consistent. My thinking at the moment is
> this {{execute}} method should instead be named {{submit}}, creating and
> returning the {{Future}} that represents whatever work it submitted, and the
> calling context should handle the resolution of those futures in a single
> place.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani opened a new pull request #1933: HBASE-24588 : Submit task for NormalizationPlan
virajjasani opened a new pull request #1933: URL: https://github.com/apache/hbase/pull/1933 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1916: HBASE-24546 CloneSnapshotProcedure unlimited retry
Apache-HBase commented on pull request #1916: URL: https://github.com/apache/hbase/pull/1916#issuecomment-646641201 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 12s | branch-2.2 passed | | +1 :green_heart: | compile | 0m 56s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 1m 20s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 4m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | branch-2.2 passed | | +0 :ok: | spotbugs | 3m 23s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 22s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 40s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | checkstyle | 1m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 3s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 25m 15s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | | +1 :green_heart: | findbugs | 3m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 166m 30s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. | | | | 229m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1916/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1916 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 019766351e58 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1916/out/precommit/personality/provided.sh | | git revision | branch-2.2 / e7f17fe68d | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1916/2/testReport/ | | Max. process+thread count | 4484 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1916/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp
Apache-HBase commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-646638233 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 40s | master passed | | +1 :green_heart: | checkstyle | 1m 56s | master passed | | +1 :green_heart: | spotbugs | 6m 39s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | checkstyle | 1m 55s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 30s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 2m 42s | the patch passed | | +1 :green_heart: | spotbugs | 9m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 46s | The patch does not generate ASF License warnings. | | | | 52m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1926 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux 56931f68b939 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Max. process+thread count | 95 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-hbtop U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1926/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1923: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count
Apache-HBase commented on pull request #1923: URL: https://github.com/apache/hbase/pull/1923#issuecomment-646631993 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 55s | master passed | | +1 :green_heart: | compile | 1m 20s | master passed | | +1 :green_heart: | shadedjars | 6m 40s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 44s | hbase-server in master failed. | | -0 :warning: | patch | 7m 34s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 37s | the patch passed | | +1 :green_heart: | compile | 1m 11s | the patch passed | | +1 :green_heart: | javac | 1m 11s | the patch passed | | +1 :green_heart: | shadedjars | 6m 41s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 46s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 198m 55s | hbase-server in the patch passed. | | | | 229m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1923/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1923 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1fc0c44becb1 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1923/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1923/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1923/2/testReport/ | | Max. process+thread count | 3091 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1923/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24580) Persist map of regions-to-last-flush-sequenceid across restarts
[ https://issues.apache.org/jira/browse/HBASE-24580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140535#comment-17140535 ] Anoop Sam John commented on HBASE-24580: Ya there was a jira which tried to persist this (to HDFS) at intervals. > Persist map of regions-to-last-flush-sequenceid across restarts > --- > > Key: HBASE-24580 > URL: https://issues.apache.org/jira/browse/HBASE-24580 > Project: HBase > Issue Type: Improvement >Reporter: Michael Stack >Priority: Minor > > A nice suggestion by our [~ndimiduk] was that we persist the > last-successful-flush-sequenceid per region kept up by an in-memory map in > Master. We could add it to our nice new general local master store. On > restart, could rehydrate the map. Would be helpful on cold start in > particular, especially if a big backlog of WALs to replay. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1927: HBASE-24592 [brnach-2.2] Upgrade junit to 4.13
Apache-HBase commented on pull request #1927: URL: https://github.com/apache/hbase/pull/1927#issuecomment-646621490 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 37s | branch-2.2 passed | | +1 :green_heart: | compile | 3m 9s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 4m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 46s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 11s | the patch passed | | +1 :green_heart: | compile | 3m 7s | the patch passed | | +1 :green_heart: | javac | 3m 7s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedjars | 4m 21s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 28m 21s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | javadoc | 3m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 258m 49s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 43s | The patch does not generate ASF License warnings. | | | | 327m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1927/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1927 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 49d0d72d1fd7 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1927/out/precommit/personality/provided.sh | | git revision | branch-2.2 / e7f17fe68d | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1927/1/testReport/ | | Max. process+thread count | 4843 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1927/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (HBASE-24550) Passing '-h' or '--help' to bin/hbase doesn't do as expected
[ https://issues.apache.org/jira/browse/HBASE-24550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reopened HBASE-24550: -- Reopening the Jira as we have one addendum and branch-1 PR in progress. > Passing '-h' or '--help' to bin/hbase doesn't do as expected > > > Key: HBASE-24550 > URL: https://issues.apache.org/jira/browse/HBASE-24550 > Project: HBase > Issue Type: Bug > Components: Operability, shell >Reporter: Michael Stack >Assignee: wenfeiyi666 >Priority: Trivial > Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0, 2.1.10, 2.2.6 > > > If I do 'bin/hbase -h' or './bin/hbase --help', it doesn't dump usage as I'd > expect. Instead, the param gets passed direct to the jvm for it to spew > complaint that the param is unrecognized. > Should do the right thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24590) Clone snapshot with optional table level property overrides
[
https://issues.apache.org/jira/browse/HBASE-24590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140513#comment-17140513
]
Viraj Jasani edited comment on HBASE-24590 at 6/19/20, 12:49 PM:
-
+1 to this idea, it would be real nice to have override attributes with
clone_snaoshot.
However, from impl point of view, we already have tableDescriptor for step
CLONE_SNAPSHOT_WRITE_FS_LAYOUT to create regions in file system using
tableDescriptor. So why not let SnapshotManager take care of updating
tableDescriptor with overriding all desired attribute values that we are
planning to introduce as part of this Jira, and pass it on to
CloneSnapshotProcedure? That way not only we require any additional step in
CloneSnapshotProcedure, but also the responsibility of overriding attribute
remains with SnapshotManager.
Thought?
was (Author: vjasani):
+1 to this idea, it would real nice to have override attributes with
clone_snaoshot.
However, from impl point of view, we already have tableDescriptor for step
CLONE_SNAPSHOT_WRITE_FS_LAYOUT to create regions in file system using
tableDescriptor. So why not let SnapshotManager take care of updating
tableDescriptor with overriding all desired attribute values that we are
planning to introduce as part of this Jira, and pass it on to
CloneSnapshotProcedure? That way not only we require any additional step in
CloneSnapshotProcedure, but also the responsibility of overriding attribute
remains with SnapshotManager.
Thought?
> Clone snapshot with optional table level property overrides
> ---
>
> Key: HBASE-24590
> URL: https://issues.apache.org/jira/browse/HBASE-24590
> Project: HBase
> Issue Type: Improvement
> Components: API, master, shell
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.6.0
>Reporter: Bharath Vissapragada
>Priority: Minor
>
> We have this use case where we try to clone from snapshots of a table with
> replication enabled. Cloning process just reads the TableDescriptor from the
> manifest and uses it for the new target table.
> In our case, the moment we clone it, replication kicks in and attempts to
> replicate table to peers but since the target table doesn't exist, it keeps
> throwing TNFE in a loop. I propose to add additional *optional* parameters to
> clone_snapshot that takes the target table property overrides (table leve/cf
> level).
> For example:
> {noformat}
> clone_snapshot 'snapshotName', 'tableName'# default
> clone_snapshot 'snapshotName', 'tableName', {NAME => 'f1', REPLICATION_SCOPE
> => 0 }
> clone_snapshot 'snapshotName, 'tableName', {MERGE_ENABLED => false}
> .
> {noformat}
>
> Implementation wise, this just adds a {{ModifyTableProcedure}} as a child
> procedure (if args are provided) for {{CloneSnapshotProcedure}} after
> {{CLONE_SNAPSHOT_ADD_TO_META}}, so we reuse most of the "modifyTable" code.
> Also, since clone puts the table in a disabled state, using
> "ModifyTableProcedure" shouldn't cause any issues.
> Thoughts? Is there any easier way to do it?
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24590) Clone snapshot with optional table level property overrides
[
https://issues.apache.org/jira/browse/HBASE-24590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140513#comment-17140513
]
Viraj Jasani commented on HBASE-24590:
--
+1 to this idea, it would real nice to have override attributes with
clone_snaoshot.
However, from impl point of view, we already have tableDescriptor for step
CLONE_SNAPSHOT_WRITE_FS_LAYOUT to create regions in file system using
tableDescriptor. So why not let SnapshotManager take care of updating
tableDescriptor with overriding all desired attribute values that we are
planning to introduce as part of this Jira, and pass it on to
CloneSnapshotProcedure? That way not only we require any additional step in
CloneSnapshotProcedure, but also the responsibility of overriding attribute
remains with SnapshotManager.
Thought?
> Clone snapshot with optional table level property overrides
> ---
>
> Key: HBASE-24590
> URL: https://issues.apache.org/jira/browse/HBASE-24590
> Project: HBase
> Issue Type: Improvement
> Components: API, master, shell
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.6.0
>Reporter: Bharath Vissapragada
>Priority: Minor
>
> We have this use case where we try to clone from snapshots of a table with
> replication enabled. Cloning process just reads the TableDescriptor from the
> manifest and uses it for the new target table.
> In our case, the moment we clone it, replication kicks in and attempts to
> replicate table to peers but since the target table doesn't exist, it keeps
> throwing TNFE in a loop. I propose to add additional *optional* parameters to
> clone_snapshot that takes the target table property overrides (table leve/cf
> level).
> For example:
> {noformat}
> clone_snapshot 'snapshotName', 'tableName'# default
> clone_snapshot 'snapshotName', 'tableName', {NAME => 'f1', REPLICATION_SCOPE
> => 0 }
> clone_snapshot 'snapshotName, 'tableName', {MERGE_ENABLED => false}
> .
> {noformat}
>
> Implementation wise, this just adds a {{ModifyTableProcedure}} as a child
> procedure (if args are provided) for {{CloneSnapshotProcedure}} after
> {{CLONE_SNAPSHOT_ADD_TO_META}}, so we reuse most of the "modifyTable" code.
> Also, since clone puts the table in a disabled state, using
> "ModifyTableProcedure" shouldn't cause any issues.
> Thoughts? Is there any easier way to do it?
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1929: HBASE-24205 Create metric to know the number of reads that happens from memstore
Apache-HBase commented on pull request #1929: URL: https://github.com/apache/hbase/pull/1929#issuecomment-646610053 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ branch-2.2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 41s | branch-2.2 passed | | +1 :green_heart: | compile | 1m 35s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 1m 52s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 4m 29s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 6s | branch-2.2 passed | | +0 :ok: | spotbugs | 3m 49s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 44s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 14s | the patch passed | | +1 :green_heart: | compile | 1m 31s | the patch passed | | +1 :green_heart: | javac | 1m 31s | the patch passed | | -1 :x: | checkstyle | 1m 29s | hbase-server: The patch generated 1 new + 91 unchanged - 1 fixed = 92 total (was 92) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 24s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 28m 28s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | javadoc | 1m 7s | the patch passed | | +1 :green_heart: | findbugs | 5m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 33s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 0m 38s | hbase-hadoop2-compat in the patch passed. | | -1 :x: | unit | 193m 16s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 20s | The patch does not generate ASF License warnings. | | | | 270m 57s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestClusterRestartFailoverSplitWithoutZk | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1929 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d7be7f2da25b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1929/out/precommit/personality/provided.sh | | git revision | branch-2.2 / e7f17fe68d | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/1/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/1/testReport/ | | Max. process+thread count | 4551 (vs. ulimit of 1) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1929/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-23739) BoundedRecoveredHFilesOutputSink should read the table descriptor directly
[ https://issues.apache.org/jira/browse/HBASE-23739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140487#comment-17140487 ] Anoop Sam John commented on HBASE-23739: Once the region is opened after the WAL split (to HFiles) there will be a compaction on these new HFiles right? But if there were pending compactions (eligible older files) this new file's compaction will be delayed right? [~zghao] > BoundedRecoveredHFilesOutputSink should read the table descriptor directly > -- > > Key: HBASE-23739 > URL: https://issues.apache.org/jira/browse/HBASE-23739 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > Read from meta or filesystem? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1923: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count
Apache-HBase commented on pull request #1923: URL: https://github.com/apache/hbase/pull/1923#issuecomment-646602368 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 43s | master passed | | +1 :green_heart: | compile | 0m 55s | master passed | | +1 :green_heart: | shadedjars | 5m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | | -0 :warning: | patch | 6m 25s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 5m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 138m 25s | hbase-server in the patch passed. | | | | 162m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1923/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1923 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 668f8c33aa6f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1923/2/testReport/ | | Max. process+thread count | 4632 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1923/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1932: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
virajjasani commented on a change in pull request #1932: URL: https://github.com/apache/hbase/pull/1932#discussion_r442800622 ## File path: bin/hbase-config.cmd ## @@ -37,7 +37,7 @@ if "%1" == "--help" ( echo Error usage! You should use it like 'hbase --help' or 'hbase -h'; exit /B 2 ) -if "%1" == "--help" ( +if "%1" == "-h" ( Review comment: I am not aware of exact syntax, but with `or` condition for `--help` and `-h`, we should be good with this PR. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled
Apache-HBase commented on pull request #1903: URL: https://github.com/apache/hbase/pull/1903#issuecomment-646598104 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 15s | master passed | | +1 :green_heart: | compile | 1m 2s | master passed | | +1 :green_heart: | shadedjars | 6m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 55s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | shadedjars | 6m 9s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 37s | hbase-server generated 2 new + 26 unchanged - 0 fixed = 28 total (was 26) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 234m 46s | hbase-server in the patch passed. | | | | 262m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1903 | | JIRA Issue | HBASE-24562 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ff9e1443d53a 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Default Java | 1.8.0_232 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/testReport/ | | Max. process+thread count | 2917 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1932: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
virajjasani commented on a change in pull request #1932: URL: https://github.com/apache/hbase/pull/1932#discussion_r442799700 ## File path: bin/hbase-config.cmd ## @@ -37,7 +37,7 @@ if "%1" == "--help" ( echo Error usage! You should use it like 'hbase --help' or 'hbase -h'; exit /B 2 ) -if "%1" == "--help" ( +if "%1" == "-h" ( Review comment: Oh wait, let's combine both of these if conditions. Something like: ``` if ["%1" == "-h"] || ["%1" == "--help"] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled
Apache-HBase commented on pull request #1903: URL: https://github.com/apache/hbase/pull/1903#issuecomment-646593911 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 6s | master passed | | +1 :green_heart: | compile | 1m 15s | master passed | | +1 :green_heart: | shadedjars | 6m 40s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 45s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 46s | the patch passed | | +1 :green_heart: | compile | 1m 14s | the patch passed | | +1 :green_heart: | javac | 1m 14s | the patch passed | | +1 :green_heart: | shadedjars | 6m 49s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 49s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 220m 19s | hbase-server in the patch passed. | | | | 251m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1903 | | JIRA Issue | HBASE-24562 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux abb15ee4aba6 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/testReport/ | | Max. process+thread count | 3118 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1903/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-native-client] phrocker commented on a change in pull request #8: HBASE-24559: Fix test logging initialization
phrocker commented on a change in pull request #8:
URL: https://github.com/apache/hbase-native-client/pull/8#discussion_r442794598
##
File path: src/hbase/test-util/test-util.cc
##
@@ -18,81 +18,17 @@
*/
#include "hbase/test-util/test-util.h"
-#include
-#include
+#include
+#include
+#include
-#include "hbase/client/zk-util.h"
+using std::string;
-using hbase::TestUtil;
-using folly::Random;
-
-std::string TestUtil::RandString(int len) {
- // Create the whole string.
- // Filling everything with z's
- auto s = std::string(len, 'z');
-
- // Now pick a bunch of random numbers
- for (int i = 0; i < len; i++) {
-// use Folly's random to get the numbers
-// as I don't want to have to learn
-// all the cpp rand invocation magic.
-auto r = Random::rand32('a', 'z');
-// Cast that to ascii.
-s[i] = static_cast(r);
+namespace hbase {
+ string TestUtil::get_exec_path() {
+char result[ PATH_MAX ];
+ssize_t count = readlink( "/proc/self/exe", result, PATH_MAX );
Review comment:
Not sure if we can use boost::dll::program_location ( that's 1.61 + I
think ) but that may be more cross platform compatible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…
bsglz commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-646579266 @wchevreuil For now the default split policy is SteppingSplitPolicy, FYI. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…
bsglz commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-646577229 Ok, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1932: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
Apache-HBase commented on pull request #1932: URL: https://github.com/apache/hbase/pull/1932#issuecomment-646575183 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1932/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1932 | | Optional Tests | | | uname | Linux d795560eda8a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Max. process+thread count | 46 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1932/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1932: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
Apache-HBase commented on pull request #1932: URL: https://github.com/apache/hbase/pull/1932#issuecomment-646575315 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 3m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1932/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1932 | | Optional Tests | dupname asflicense | | uname | Linux f02e34ddb480 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Max. process+thread count | 43 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1932/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1932: HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected
Apache-HBase commented on pull request #1932: URL: https://github.com/apache/hbase/pull/1932#issuecomment-646574773 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1932/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1932 | | Optional Tests | | | uname | Linux f8c12119d843 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 537a3caccd | | Max. process+thread count | 55 (vs. ulimit of 12500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1932/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
