[jira] [Created] (HBASE-25022) Remove 'hbase.testing.nocluster' config
Duo Zhang created HBASE-25022: - Summary: Remove 'hbase.testing.nocluster' config Key: HBASE-25022 URL: https://issues.apache.org/jira/browse/HBASE-25022 Project: HBase Issue Type: Improvement Components: test Reporter: Duo Zhang Assignee: Duo Zhang It is only used at two places in tests and easy to be removed, so let's just remove it to make our code cleaner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2392: HBASE-25013 Avoid reset the backup master root cache every time when …
Apache-HBase commented on pull request #2392: URL: https://github.com/apache/hbase/pull/2392#issuecomment-691804947 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 49s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-24950 Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 25s | HBASE-24950 passed | | +1 :green_heart: | checkstyle | 2m 0s | HBASE-24950 passed | | +1 :green_heart: | spotbugs | 6m 50s | HBASE-24950 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-protocol-shaded | | +1 :green_heart: | checkstyle | 0m 27s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-balancer | | +1 :green_heart: | checkstyle | 1m 11s | hbase-server: The patch generated 0 new + 323 unchanged - 1 fixed = 323 total (was 324) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 12s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 2m 19s | the patch passed | | +1 :green_heart: | spotbugs | 7m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 48s | The patch does not generate ASF License warnings. | | | | 55m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2392 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux b64de13619d1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24950 / 160eee511f | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-balancer hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2384: HBASE-25012 HBASE-24359 causes replication missed log of some RemoteE…
Apache-HBase commented on pull request #2384: URL: https://github.com/apache/hbase/pull/2384#issuecomment-691804830 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 7s | master passed | | +1 :green_heart: | checkstyle | 1m 12s | master passed | | +1 :green_heart: | spotbugs | 2m 8s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | the patch passed | | +1 :green_heart: | checkstyle | 1m 9s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 25s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 36m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2384/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2384 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux d1781c27a9de 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0f00e1c7c7 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2384/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2385: HBASE-24950 Another solution for Splittable Meta
Apache-HBase commented on pull request #2385: URL: https://github.com/apache/hbase/pull/2385#issuecomment-691802119 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 1s | master passed | | +1 :green_heart: | checkstyle | 3m 4s | master passed | | +1 :green_heart: | spotbugs | 8m 14s | master passed | | -0 :warning: | patch | 1m 16s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 43s | the patch passed | | +1 :green_heart: | checkstyle | 0m 9s | The patch passed checkstyle in hbase-protocol-shaded | | +1 :green_heart: | checkstyle | 0m 23s | The patch passed checkstyle in hbase-common | | +1 :green_heart: | checkstyle | 0m 31s | hbase-client: The patch generated 0 new + 185 unchanged - 1 fixed = 185 total (was 186) | | +1 :green_heart: | checkstyle | 0m 11s | The patch passed checkstyle in hbase-zookeeper | | +1 :green_heart: | checkstyle | 0m 12s | The patch passed checkstyle in hbase-balancer | | +1 :green_heart: | checkstyle | 1m 21s | hbase-server: The patch generated 0 new + 683 unchanged - 7 fixed = 683 total (was 690) | | +1 :green_heart: | checkstyle | 0m 15s | The patch passed checkstyle in hbase-it | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 43s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 3m 26s | the patch passed | | +1 :green_heart: | spotbugs | 10m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 10s | The patch does not generate ASF License warnings. | | | | 60m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2385/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2385 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux 49dd1b37d839 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0f00e1c7c7 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-balancer hbase-server hbase-it U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2385/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2378: HBASE-24929 Introduce a special CellComparator for master local region
Apache-HBase commented on pull request #2378: URL: https://github.com/apache/hbase/pull/2378#issuecomment-691801662 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-24950 Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 54s | HBASE-24950 passed | | +1 :green_heart: | checkstyle | 1m 58s | HBASE-24950 passed | | +1 :green_heart: | spotbugs | 3m 47s | HBASE-24950 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 47s | the patch passed | | +1 :green_heart: | checkstyle | 2m 0s | the patch passed | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 7s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 4m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. | | | | 49m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2378/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2378 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 5c66f9831d00 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24950 / 160eee511f | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2378/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2393: HBASE-25016 addendum: should also close the Table which is returned by calling getMetaHTable
Apache-HBase commented on pull request #2393: URL: https://github.com/apache/hbase/pull/2393#issuecomment-691797733 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 26s | master passed | | +1 :green_heart: | checkstyle | 0m 13s | master passed | | +1 :green_heart: | spotbugs | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | the patch passed | | +1 :green_heart: | checkstyle | 0m 12s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 0s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 0m 43s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 31m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2393/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2393 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 4d011070a4a9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0f00e1c7c7 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-balancer U: hbase-balancer | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2393/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2393: HBASE-25016 addendum: should also close the Table which is returned by calling getMetaHTable
Apache-HBase commented on pull request #2393: URL: https://github.com/apache/hbase/pull/2393#issuecomment-691797599 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +1 :green_heart: | compile | 0m 16s | master passed | | +1 :green_heart: | shadedjars | 7m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 49s | the patch passed | | +1 :green_heart: | compile | 0m 16s | the patch passed | | +1 :green_heart: | javac | 0m 16s | the patch passed | | +1 :green_heart: | shadedjars | 7m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 20s | hbase-balancer in the patch passed. | | | | 31m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2393/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2393 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 73e92d2858ca 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0f00e1c7c7 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2393/1/testReport/ | | Max. process+thread count | 131 (vs. ulimit of 12500) | | modules | C: hbase-balancer U: hbase-balancer | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2393/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2393: HBASE-25016 addendum: should also close the Table which is returned by calling getMetaHTable
Apache-HBase commented on pull request #2393: URL: https://github.com/apache/hbase/pull/2393#issuecomment-691796921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 48s | master passed | | +1 :green_heart: | compile | 0m 18s | master passed | | +1 :green_heart: | shadedjars | 7m 25s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-balancer in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 30s | the patch passed | | +1 :green_heart: | compile | 0m 17s | the patch passed | | +1 :green_heart: | javac | 0m 17s | the patch passed | | +1 :green_heart: | shadedjars | 7m 23s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-balancer in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 26s | hbase-balancer in the patch passed. | | | | 27m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2393/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2393 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9e6c2ef00469 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0f00e1c7c7 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2393/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-balancer.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2393/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2393/1/testReport/ | | Max. process+thread count | 80 (vs. ulimit of 12500) | | modules | C: hbase-balancer U: hbase-balancer | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2393/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] nyl3532016 opened a new pull request #2393: HBASE-25016 addendum: should also close the Table which is returned by calling getMetaHTable
nyl3532016 opened a new pull request #2393: URL: https://github.com/apache/hbase/pull/2393 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25021) Nightly job should skip hadoop-2 integration test for master
[ https://issues.apache.org/jira/browse/HBASE-25021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195169#comment-17195169 ] Duo Zhang commented on HBASE-25021: --- [~busbey] FYI. It is a huge stage called 'packaging and integration', where we test both hadoop-2 and hadoop-3. Not sure what is the best way to fix it... > Nightly job should skip hadoop-2 integration test for master > > > Key: HBASE-25021 > URL: https://issues.apache.org/jira/browse/HBASE-25021 > Project: HBase > Issue Type: Bug > Components: build, scripts >Reporter: Duo Zhang >Priority: Major > > Since master does not support hadoop 2.x any more. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-25021) Nightly job should skip hadoop-2 integration test for master
Duo Zhang created HBASE-25021: - Summary: Nightly job should skip hadoop-2 integration test for master Key: HBASE-25021 URL: https://issues.apache.org/jira/browse/HBASE-25021 Project: HBase Issue Type: Bug Components: build, scripts Reporter: Duo Zhang Since master does not support hadoop 2.x any more. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24796) Migrate all jenkins jobs to the new ci-hadoop.a.o
[ https://issues.apache.org/jira/browse/HBASE-24796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24796. --- Resolution: Fixed > Migrate all jenkins jobs to the new ci-hadoop.a.o > - > > Key: HBASE-24796 > URL: https://issues.apache.org/jira/browse/HBASE-24796 > Project: HBase > Issue Type: Umbrella > Components: build, test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > Need to open an issue as we need to change the code. > We will exclude flaky tests when running pre commit job, so if we move the > flaky jobs, we also need to change the url. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25016) Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
[ https://issues.apache.org/jira/browse/HBASE-25016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195164#comment-17195164 ] niuyulin commented on HBASE-25016: -- tanks [~zhangduo] and [~vjasani] , I will submit an addendum PR. > Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName > --- > > Key: HBASE-25016 > URL: https://issues.apache.org/jira/browse/HBASE-25016 > Project: HBase > Issue Type: Bug > Components: master, meta >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 > > > It will cause resource leak. > Th good news is that this method is only used for cluster maintainance, such > as assign or unassign region manually, so it is less hurt. Anyway, we should > fix it ASAP. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-25016) Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
[ https://issues.apache.org/jira/browse/HBASE-25016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195164#comment-17195164 ] niuyulin edited comment on HBASE-25016 at 9/14/20, 2:56 AM: Thanks [~zhangduo] and [~vjasani] , I will submit an addendum PR. was (Author: niuyulin): tanks [~zhangduo] and [~vjasani] , I will submit an addendum PR. > Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName > --- > > Key: HBASE-25016 > URL: https://issues.apache.org/jira/browse/HBASE-25016 > Project: HBase > Issue Type: Bug > Components: master, meta >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 > > > It will cause resource leak. > Th good news is that this method is only used for cluster maintainance, such > as assign or unassign region manually, so it is less hurt. Anyway, we should > fix it ASAP. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-691765918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 37s | master passed | | +1 :green_heart: | compile | 0m 17s | master passed | | +1 :green_heart: | checkstyle | 0m 46s | master passed | | +1 :green_heart: | javadoc | 0m 7s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 0m 47s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | checkstyle | 0m 52s | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 41s | hbase-noop-htrace in the patch passed. | | +1 :green_heart: | unit | 0m 51s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 6m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/24/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/36 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit xml compile spotbugs findbugs checkstyle | | uname | Linux cea85d8225d1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / b47d4cd | | Default Java | Oracle Corporation-1.8.0_265-b01 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/24/testReport/ | | Max. process+thread count | 421 (vs. ulimit of 1000) | | modules | C: hbase-noop-htrace . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/24/console | | versions | git=2.20.1 shellcheck=0.5.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-691763441 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 37s | master passed | | +1 :green_heart: | compile | 0m 17s | master passed | | +1 :green_heart: | checkstyle | 0m 49s | master passed | | +1 :green_heart: | javadoc | 0m 8s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 0m 48s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | checkstyle | 0m 55s | the patch passed | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 42s | hbase-noop-htrace in the patch passed. | | +1 :green_heart: | unit | 0m 51s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 6m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/23/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/36 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit xml compile spotbugs findbugs checkstyle | | uname | Linux ff6a76192355 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / b47d4cd | | Default Java | Oracle Corporation-1.8.0_265-b01 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/23/testReport/ | | Max. process+thread count | 421 (vs. ulimit of 1000) | | modules | C: hbase-noop-htrace . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/23/console | | versions | git=2.20.1 shellcheck=0.5.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25006) Make the cost functions optional for StochastoicBalancer
[
https://issues.apache.org/jira/browse/HBASE-25006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195139#comment-17195139
]
Hudson commented on HBASE-25006:
Results for branch master
[build #45 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/45/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/45/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/45/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/45/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/45//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Make the cost functions optional for StochastoicBalancer
>
>
> Key: HBASE-25006
> URL: https://issues.apache.org/jira/browse/HBASE-25006
> Project: HBase
> Issue Type: Improvement
>Reporter: Clara Xiong
>Assignee: Clara Xiong
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0, 2.3.2
>
>
> StochastoicBalancer takes a long time to generate a plan for larger clusters.
> We want to make the cost functions optional.
> hbase.master.balancer.stochastic.regionCountCost: 0
> hbase.master.balancer.stochastic.primaryRegionCountCost: 0
> hbase.master.balancer.stochastic.tableSkewCost: 0
> hbase.master.balancer.stochastic.rackLocalityCost:0
> hbase.master.balancer.stochastic.readRequestCost: 0
> hbase.master.balancer.stochastic.cpRequestCost: 0
> hbase.master.balancer.stochastic.writeRequestCost: 0
> hbase.master.balancer.stochastic.regionReplicaHostCostKey: 0
> hbase.master.balancer.stochastic.memstoreSizeCost: 0
> hbase.master.balancer.stochastic.storefileSizeCost: 0
> hbase.master.balancer.stochastic.regionReplicaRackCostKey: 0
> hbase.master.balancer.stochastic.serverLocalityCost:0
>
> This will turn off all cost functions
> To keep some of them, we just need to set some to positive value
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25016) Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
[
https://issues.apache.org/jira/browse/HBASE-25016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195140#comment-17195140
]
Hudson commented on HBASE-25016:
Results for branch master
[build #45 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/45/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/45/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/45/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/45/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/45//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
> ---
>
> Key: HBASE-25016
> URL: https://issues.apache.org/jira/browse/HBASE-25016
> Project: HBase
> Issue Type: Bug
> Components: master, meta
>Reporter: Duo Zhang
>Assignee: niuyulin
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2
>
>
> It will cause resource leak.
> Th good news is that this method is only used for cluster maintainance, such
> as assign or unassign region manually, so it is less hurt. Anyway, we should
> fix it ASAP.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-691749210 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 36s | master passed | | +1 :green_heart: | compile | 0m 17s | master passed | | +1 :green_heart: | checkstyle | 0m 45s | master passed | | +1 :green_heart: | javadoc | 0m 8s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 0m 46s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | checkstyle | 0m 57s | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 41s | hbase-noop-htrace in the patch passed. | | +1 :green_heart: | unit | 0m 51s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 6m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/22/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/36 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit xml compile spotbugs findbugs checkstyle | | uname | Linux bedc7d79ae79 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / b47d4cd | | Default Java | Oracle Corporation-1.8.0_265-b01 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/22/testReport/ | | Max. process+thread count | 421 (vs. ulimit of 1000) | | modules | C: hbase-noop-htrace . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/22/console | | versions | git=2.20.1 shellcheck=0.5.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-691745947 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | spotbugs | 0m 1s | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 37s | master passed | | +1 :green_heart: | compile | 0m 18s | master passed | | +1 :green_heart: | checkstyle | 0m 49s | master passed | | +1 :green_heart: | javadoc | 0m 8s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 0m 46s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | checkstyle | 0m 54s | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 43s | hbase-noop-htrace in the patch passed. | | +1 :green_heart: | unit | 0m 50s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 6m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/21/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/36 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit xml compile spotbugs findbugs checkstyle | | uname | Linux 67c2943b601f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / b47d4cd | | Default Java | Oracle Corporation-1.8.0_265-b01 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/21/testReport/ | | Max. process+thread count | 420 (vs. ulimit of 1000) | | modules | C: hbase-noop-htrace . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/21/console | | versions | git=2.20.1 shellcheck=0.5.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-691732610 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 36s | master passed | | +1 :green_heart: | compile | 0m 17s | master passed | | +1 :green_heart: | checkstyle | 0m 46s | master passed | | +1 :green_heart: | javadoc | 0m 7s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 0m 46s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | checkstyle | 0m 54s | the patch passed | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 42s | hbase-noop-htrace in the patch passed. | | +1 :green_heart: | unit | 0m 51s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 6m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/20/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/36 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit xml compile spotbugs findbugs checkstyle | | uname | Linux 392813fe2ca1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / b47d4cd | | Default Java | Oracle Corporation-1.8.0_265-b01 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/20/testReport/ | | Max. process+thread count | 409 (vs. ulimit of 1000) | | modules | C: hbase-noop-htrace . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/20/console | | versions | git=2.20.1 shellcheck=0.5.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25006) Make the cost functions optional for StochastoicBalancer
[
https://issues.apache.org/jira/browse/HBASE-25006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195123#comment-17195123
]
Hudson commented on HBASE-25006:
Results for branch branch-2.3
[build #41 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/41/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/41/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/41/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/41/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/41/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make the cost functions optional for StochastoicBalancer
>
>
> Key: HBASE-25006
> URL: https://issues.apache.org/jira/browse/HBASE-25006
> Project: HBase
> Issue Type: Improvement
>Reporter: Clara Xiong
>Assignee: Clara Xiong
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0, 2.3.2
>
>
> StochastoicBalancer takes a long time to generate a plan for larger clusters.
> We want to make the cost functions optional.
> hbase.master.balancer.stochastic.regionCountCost: 0
> hbase.master.balancer.stochastic.primaryRegionCountCost: 0
> hbase.master.balancer.stochastic.tableSkewCost: 0
> hbase.master.balancer.stochastic.rackLocalityCost:0
> hbase.master.balancer.stochastic.readRequestCost: 0
> hbase.master.balancer.stochastic.cpRequestCost: 0
> hbase.master.balancer.stochastic.writeRequestCost: 0
> hbase.master.balancer.stochastic.regionReplicaHostCostKey: 0
> hbase.master.balancer.stochastic.memstoreSizeCost: 0
> hbase.master.balancer.stochastic.storefileSizeCost: 0
> hbase.master.balancer.stochastic.regionReplicaRackCostKey: 0
> hbase.master.balancer.stochastic.serverLocalityCost:0
>
> This will turn off all cost functions
> To keep some of them, we just need to set some to positive value
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25016) Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
[
https://issues.apache.org/jira/browse/HBASE-25016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195124#comment-17195124
]
Hudson commented on HBASE-25016:
Results for branch branch-2.3
[build #41 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/41/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/41/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/41/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/41/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/41/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
> ---
>
> Key: HBASE-25016
> URL: https://issues.apache.org/jira/browse/HBASE-25016
> Project: HBase
> Issue Type: Bug
> Components: master, meta
>Reporter: Duo Zhang
>Assignee: niuyulin
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2
>
>
> It will cause resource leak.
> Th good news is that this method is only used for cluster maintainance, such
> as assign or unassign region manually, so it is less hurt. Anyway, we should
> fix it ASAP.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2392: HBASE-25013 Avoid reset the backup master root cache every time when …
Apache-HBase commented on pull request #2392: URL: https://github.com/apache/hbase/pull/2392#issuecomment-691699504 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24950 Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 44s | HBASE-24950 passed | | +1 :green_heart: | compile | 2m 30s | HBASE-24950 passed | | +1 :green_heart: | shadedjars | 7m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 32s | HBASE-24950 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 1s | the patch passed | | +1 :green_heart: | compile | 2m 48s | the patch passed | | +1 :green_heart: | javac | 2m 48s | the patch passed | | +1 :green_heart: | shadedjars | 7m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 49s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 4s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 20s | hbase-balancer in the patch passed. | | -1 :x: | unit | 145m 34s | hbase-server in the patch failed. | | | | 182m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2392 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f86e4d4941e6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24950 / 784daeb084 | | Default Java | 1.8.0_232 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/testReport/ | | Max. process+thread count | 4872 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-balancer hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2357: HBASE-24991 Replace MovedRegionsCleaner with guava cache
Apache-HBase commented on pull request #2357: URL: https://github.com/apache/hbase/pull/2357#issuecomment-691698842 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 52s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 42s | master passed | | +1 :green_heart: | compile | 1m 37s | master passed | | +1 :green_heart: | shadedjars | 8m 50s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 58s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 50s | the patch passed | | +1 :green_heart: | compile | 1m 46s | the patch passed | | +1 :green_heart: | javac | 1m 46s | the patch passed | | +1 :green_heart: | shadedjars | 8m 53s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 56s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 249m 41s | hbase-server in the patch passed. | | | | 289m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2357 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 610d42714dc0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a393fc594c | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/7/testReport/ | | Max. process+thread count | 3686 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2392: HBASE-25013 Avoid reset the backup master root cache every time when …
Apache-HBase commented on pull request #2392: URL: https://github.com/apache/hbase/pull/2392#issuecomment-691698805 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-24950 Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 10s | HBASE-24950 passed | | +1 :green_heart: | compile | 2m 52s | HBASE-24950 passed | | +1 :green_heart: | shadedjars | 7m 47s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-balancer in HBASE-24950 failed. | | -0 :warning: | javadoc | 0m 27s | hbase-client in HBASE-24950 failed. | | -0 :warning: | javadoc | 0m 45s | hbase-server in HBASE-24950 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 34s | the patch passed | | +1 :green_heart: | compile | 3m 15s | the patch passed | | -0 :warning: | javac | 1m 13s | hbase-server generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4) | | +1 :green_heart: | shadedjars | 7m 9s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-balancer in the patch failed. | | -0 :warning: | javadoc | 0m 42s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 59s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 7s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 23s | hbase-balancer in the patch passed. | | -1 :x: | unit | 136m 26s | hbase-server in the patch failed. | | | | 176m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2392 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 425d78feb3fa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24950 / 784daeb084 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-balancer.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/testReport/ | | Max. process+thread count | 4441 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-balancer hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated.
[jira] [Updated] (HBASE-25018) EOM cleanup
[ https://issues.apache.org/jira/browse/HBASE-25018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25018: Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed Status: Resolved (was: Patch Available) website now updated. that's all I noticed. > EOM cleanup > --- > > Key: HBASE-25018 > URL: https://issues.apache.org/jira/browse/HBASE-25018 > Project: HBase > Issue Type: Task > Components: community, website >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > Fix For: 3.0.0-alpha-1 > > > the [foundation downloads area for the > project|https://downloads.apache.org/hbase/] has some versions that shouldn't > be present anymore. Also it's missing an EOM marker for 1.3. > the ref guide also includes several EOM versions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-691694258 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 13s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +0 :ok: | spotbugs | 0m 1s | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | -1 :x: | mvninstall | 0m 17s | root in master failed. | | -1 :x: | compile | 0m 17s | root in master failed. | | -1 :x: | checkstyle | 0m 16s | The patch fails to run checkstyle in root | | -1 :x: | javadoc | 0m 17s | root in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 18s | root in the patch failed. | | -1 :x: | mvninstall | 0m 17s | hbase-noop-htrace in the patch failed. | | -1 :x: | compile | 0m 20s | root in the patch failed. | | -1 :x: | compile | 0m 3s | hbase-noop-htrace in the patch failed. | | -1 :x: | javac | 0m 20s | root in the patch failed. | | -1 :x: | javac | 0m 3s | hbase-noop-htrace in the patch failed. | | -1 :x: | checkstyle | 1m 13s | The patch fails to run checkstyle in root | | -1 :x: | checkstyle | 0m 16s | The patch fails to run checkstyle in hbase-noop-htrace | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. | | -1 :x: | javadoc | 0m 17s | root in the patch failed. | | -1 :x: | javadoc | 0m 18s | hbase-noop-htrace in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 17s | root in the patch failed. | | -1 :x: | unit | 0m 18s | hbase-noop-htrace in the patch failed. | | +0 :ok: | asflicense | 0m 36s | ASF License check generated no output? | | | | 8m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/18/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/36 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit xml compile spotbugs findbugs checkstyle | | uname | Linux fde4b9ba35b1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / b47d4cd | | Default Java | Oracle Corporation-1.8.0_265-b01 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/18/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/18/artifact/yetus-precommit-check/output/branch-compile-root.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/18/artifact/yetus-precommit-check/output/buildtool-branch-checkstyle-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/18/artifact/yetus-precommit-check/output/branch-javadoc-root.txt | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/18/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/18/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-noop-htrace.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/18/artifact/yetus-precommit-check/output/patch-compile-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/18/artifact/yetus-precommit-check/output/patch-compile-hbase-noop-htrace.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/18/artifact/yetus-precommit-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/18/artifact/yetus-precommit-check/output/patch-compile-hbase-noop-htrace.txt | | checkstyle |
[jira] [Commented] (HBASE-24974) Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter
[
https://issues.apache.org/jira/browse/HBASE-24974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195068#comment-17195068
]
Hudson commented on HBASE-24974:
Results for branch branch-1
[build #25 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Provide a flexibility to print only row key and filter for multiple tables in
> the WALPrettyPrinter
> --
>
> Key: HBASE-24974
> URL: https://issues.apache.org/jira/browse/HBASE-24974
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Reporter: Sandeep Pal
>Assignee: Sandeep Pal
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0, 2.3.2
>
>
> Currently,
> [WALPrettyPrinter|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java]
> provides an option to ignore the values in the output, but it prints the
> whole cell and has no option to ignore some information from the cell.
> Sometimes, the user may only need the row keys from WAL and it may reduce the
> size of output from WALPrettyPrinter significantly.
> We should provide flexibility to output only rowkey from the cell.
> In addition we should increase the flexibility for providing multiple tables
> in the table filter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25004) Log RegionTooBusyException details
[
https://issues.apache.org/jira/browse/HBASE-25004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195067#comment-17195067
]
Hudson commented on HBASE-25004:
Results for branch branch-1
[build #25 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Log RegionTooBusyException details
> --
>
> Key: HBASE-25004
> URL: https://issues.apache.org/jira/browse/HBASE-25004
> Project: HBase
> Issue Type: Task
>Affects Versions: 1.6.0, 1.3.6
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0, 2.2.7, 2.3.2
>
> Attachments: Screenshot 2020-09-09 at 2.32.02 PM.png
>
>
> When we throw RegionTooBusyException, it gets wrapped in
> RetriesExhaustedWithDetailsException at times and the original source doing
> batch mutation might not be able to log region name and root cause that comes
> with RegionTooBusyException as it is wrapped with outer
> RetriesExhaustedWithDetailsException and outer Exception has it's own way of
> logging only necessary info, which is quite acceptable. Attaching a sample
> screenshot.
> We should at least log details of RegionTooBusyException at server side
> before we throw it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25006) Make the cost functions optional for StochastoicBalancer
[
https://issues.apache.org/jira/browse/HBASE-25006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195069#comment-17195069
]
Hudson commented on HBASE-25006:
Results for branch branch-1
[build #25 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/25//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Make the cost functions optional for StochastoicBalancer
>
>
> Key: HBASE-25006
> URL: https://issues.apache.org/jira/browse/HBASE-25006
> Project: HBase
> Issue Type: Improvement
>Reporter: Clara Xiong
>Assignee: Clara Xiong
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0, 2.3.2
>
>
> StochastoicBalancer takes a long time to generate a plan for larger clusters.
> We want to make the cost functions optional.
> hbase.master.balancer.stochastic.regionCountCost: 0
> hbase.master.balancer.stochastic.primaryRegionCountCost: 0
> hbase.master.balancer.stochastic.tableSkewCost: 0
> hbase.master.balancer.stochastic.rackLocalityCost:0
> hbase.master.balancer.stochastic.readRequestCost: 0
> hbase.master.balancer.stochastic.cpRequestCost: 0
> hbase.master.balancer.stochastic.writeRequestCost: 0
> hbase.master.balancer.stochastic.regionReplicaHostCostKey: 0
> hbase.master.balancer.stochastic.memstoreSizeCost: 0
> hbase.master.balancer.stochastic.storefileSizeCost: 0
> hbase.master.balancer.stochastic.regionReplicaRackCostKey: 0
> hbase.master.balancer.stochastic.serverLocalityCost:0
>
> This will turn off all cost functions
> To keep some of them, we just need to set some to positive value
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25018) EOM cleanup
[ https://issues.apache.org/jira/browse/HBASE-25018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195066#comment-17195066 ] Sean Busbey commented on HBASE-25018: - ref guide changes have merged. waiting on a website build. > EOM cleanup > --- > > Key: HBASE-25018 > URL: https://issues.apache.org/jira/browse/HBASE-25018 > Project: HBase > Issue Type: Task > Components: community, website >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Major > > the [foundation downloads area for the > project|https://downloads.apache.org/hbase/] has some versions that shouldn't > be present anymore. Also it's missing an EOM marker for 1.3. > the ref guide also includes several EOM versions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] busbey closed pull request #2391: HBASE-25018 EOM cleanup
busbey closed pull request #2391: URL: https://github.com/apache/hbase/pull/2391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
virajjasani commented on a change in pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#discussion_r487407947
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
##
@@ -3503,14 +3508,26 @@ private static OnlineLogRecord getSlowLogRecord(
/**
* Convert AdminProtos#SlowLogResponses to list of {@link OnlineLogRecord}
*
- * @param slowLogResponses slowlog response protobuf instance
+ * @param logEntry slowlog response protobuf instance
* @return list of SlowLog payloads for client usecase
*/
- public static List toSlowLogPayloads(
- final AdminProtos.SlowLogResponses slowLogResponses) {
-List onlineLogRecords =
slowLogResponses.getSlowLogPayloadsList()
-
.stream().map(ProtobufUtil::getSlowLogRecord).collect(Collectors.toList());
-return onlineLogRecords;
+ public static List toSlowLogPayloads(
+ final HBaseProtos.LogEntry logEntry) {
+try {
+ final String logClassName = logEntry.getLogClassName();
+ Class logClass =
Class.forName(logClassName).asSubclass(Message.class);
+ Method method = logClass.getMethod("parseFrom", ByteString.class);
+ if (logClassName.contains("SlowLogResponses")) {
Review comment:
Oh, we don't leave it up to client, we do throw Exception. The last line
of this method after try/catch is:
```
throw new RuntimeException("Invalid response from server");
```
I realize it's bit difficult to catch while reading since it's last line of
the method.
Any specific Exception message recommendation? The reason why I kept
"Invalid response from server" is because ultimately we are parsing response
from RPC call.
Open to update error message for better recommendation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
virajjasani commented on a change in pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#discussion_r487407947
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
##
@@ -3503,14 +3508,26 @@ private static OnlineLogRecord getSlowLogRecord(
/**
* Convert AdminProtos#SlowLogResponses to list of {@link OnlineLogRecord}
*
- * @param slowLogResponses slowlog response protobuf instance
+ * @param logEntry slowlog response protobuf instance
* @return list of SlowLog payloads for client usecase
*/
- public static List toSlowLogPayloads(
- final AdminProtos.SlowLogResponses slowLogResponses) {
-List onlineLogRecords =
slowLogResponses.getSlowLogPayloadsList()
-
.stream().map(ProtobufUtil::getSlowLogRecord).collect(Collectors.toList());
-return onlineLogRecords;
+ public static List toSlowLogPayloads(
+ final HBaseProtos.LogEntry logEntry) {
+try {
+ final String logClassName = logEntry.getLogClassName();
+ Class logClass =
Class.forName(logClassName).asSubclass(Message.class);
+ Method method = logClass.getMethod("parseFrom", ByteString.class);
+ if (logClassName.contains("SlowLogResponses")) {
Review comment:
Oh, we don't leave it up to client, we do throw Exception. The last line
of this method after try/catch is:
```
throw new RuntimeException("Invalid response from server");
```
I realize since it's last line of the method, while reading, it's bit
difficult to catch.
Any specific Exception message recommendation? The reason why I kept
"Invalid response from server" is because ultimately we are parsing response
from RPC call.
Open to update error message for better recommendation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-691688176 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 49s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | -1 :x: | mvninstall | 0m 16s | root in master failed. | | -1 :x: | compile | 0m 42s | root in master failed. | | -1 :x: | checkstyle | 1m 30s | The patch fails to run checkstyle in root | | -1 :x: | javadoc | 0m 18s | root in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 17s | root in the patch failed. | | -1 :x: | mvninstall | 0m 18s | hbase-noop-htrace in the patch failed. | | -1 :x: | compile | 0m 17s | root in the patch failed. | | -1 :x: | compile | 0m 18s | hbase-noop-htrace in the patch failed. | | -1 :x: | javac | 0m 17s | root in the patch failed. | | -1 :x: | javac | 0m 18s | hbase-noop-htrace in the patch failed. | | -1 :x: | checkstyle | 0m 16s | The patch fails to run checkstyle in root | | -1 :x: | checkstyle | 0m 16s | The patch fails to run checkstyle in hbase-noop-htrace | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. | | -1 :x: | javadoc | 0m 18s | root in the patch failed. | | -1 :x: | javadoc | 0m 17s | hbase-noop-htrace in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 18s | root in the patch failed. | | -1 :x: | unit | 0m 17s | hbase-noop-htrace in the patch failed. | | +0 :ok: | asflicense | 0m 37s | ASF License check generated no output? | | | | 10m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/17/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/36 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit xml compile spotbugs findbugs checkstyle | | uname | Linux 26b351e21f34 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / b47d4cd | | Default Java | Oracle Corporation-1.8.0_265-b01 | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/17/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/17/artifact/yetus-precommit-check/output/branch-compile-root.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/17/artifact/yetus-precommit-check/output/buildtool-branch-checkstyle-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/17/artifact/yetus-precommit-check/output/branch-javadoc-root.txt | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/17/artifact/yetus-precommit-check/output/patch-mvninstall-root.txt | | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/17/artifact/yetus-precommit-check/output/patch-mvninstall-hbase-noop-htrace.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/17/artifact/yetus-precommit-check/output/patch-compile-root.txt | | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/17/artifact/yetus-precommit-check/output/patch-compile-hbase-noop-htrace.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/17/artifact/yetus-precommit-check/output/patch-compile-root.txt | | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/17/artifact/yetus-precommit-check/output/patch-compile-hbase-noop-htrace.txt | | checkstyle |
[jira] [Commented] (HBASE-24974) Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter
[
https://issues.apache.org/jira/browse/HBASE-24974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195059#comment-17195059
]
Hudson commented on HBASE-24974:
Results for branch branch-2
[build #39 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/39/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/39/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/39/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/39/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/39/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/39//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Provide a flexibility to print only row key and filter for multiple tables in
> the WALPrettyPrinter
> --
>
> Key: HBASE-24974
> URL: https://issues.apache.org/jira/browse/HBASE-24974
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Reporter: Sandeep Pal
>Assignee: Sandeep Pal
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0, 2.3.2
>
>
> Currently,
> [WALPrettyPrinter|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java]
> provides an option to ignore the values in the output, but it prints the
> whole cell and has no option to ignore some information from the cell.
> Sometimes, the user may only need the row keys from WAL and it may reduce the
> size of output from WALPrettyPrinter significantly.
> We should provide flexibility to output only rowkey from the cell.
> In addition we should increase the flexibility for providing multiple tables
> in the table filter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2357: HBASE-24991 Replace MovedRegionsCleaner with guava cache
Apache-HBase commented on pull request #2357: URL: https://github.com/apache/hbase/pull/2357#issuecomment-691684177 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 48s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 45s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 6m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 6m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 136m 51s | hbase-server in the patch passed. | | | | 166m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2357 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e753c244a1c9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a393fc594c | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/7/testReport/ | | Max. process+thread count | 3979 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2392: HBASE-25013 Avoid reset the backup master root cache every time when …
Apache-HBase commented on pull request #2392: URL: https://github.com/apache/hbase/pull/2392#issuecomment-691683864 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-24950 Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 41s | HBASE-24950 passed | | +1 :green_heart: | checkstyle | 2m 2s | HBASE-24950 passed | | +1 :green_heart: | spotbugs | 6m 58s | HBASE-24950 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | -0 :warning: | checkstyle | 1m 11s | hbase-server: The patch generated 7 new + 322 unchanged - 1 fixed = 329 total (was 323) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 14s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 2m 22s | the patch passed | | +1 :green_heart: | spotbugs | 7m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. | | | | 50m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2392 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux c2dec0cf626c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24950 / 784daeb084 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-balancer hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2392/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-691682560 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 27s | master passed | | +1 :green_heart: | compile | 2m 18s | master passed | | +1 :green_heart: | shadedjars | 6m 30s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 32s | master passed | | -0 :warning: | patch | 12m 13s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | compile | 2m 19s | the patch passed | | +1 :green_heart: | javac | 2m 19s | the patch passed | | +1 :green_heart: | shadedjars | 6m 30s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) | | -0 :warning: | javadoc | 2m 1s | root generated 1 new + 46 unchanged - 0 fixed = 47 total (was 46) | ||| _ Other Tests _ | | -1 :x: | unit | 325m 17s | root in the patch failed. | | | | 363m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2261 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0504a5f9f0d2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / fe776306d0 | | Default Java | 1.8.0_232 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/testReport/ | | Max. process+thread count | 5230 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-common hbase-hadoop-compat hbase-client hbase-server hbase-thrift hbase-shell . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #2392: HBASE-25013 Avoid reset the backup master root cache every time when …
Apache9 opened a new pull request #2392: URL: https://github.com/apache/hbase/pull/2392 …syncing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24974) Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter
[
https://issues.apache.org/jira/browse/HBASE-24974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195047#comment-17195047
]
Hudson commented on HBASE-24974:
Results for branch branch-2.3
[build #40 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/40/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/40/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/40/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/40/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/40/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide a flexibility to print only row key and filter for multiple tables in
> the WALPrettyPrinter
> --
>
> Key: HBASE-24974
> URL: https://issues.apache.org/jira/browse/HBASE-24974
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Reporter: Sandeep Pal
>Assignee: Sandeep Pal
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0, 2.3.2
>
>
> Currently,
> [WALPrettyPrinter|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java]
> provides an option to ignore the values in the output, but it prints the
> whole cell and has no option to ignore some information from the cell.
> Sometimes, the user may only need the row keys from WAL and it may reduce the
> size of output from WALPrettyPrinter significantly.
> We should provide flexibility to output only rowkey from the cell.
> In addition we should increase the flexibility for providing multiple tables
> in the table filter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-691674833 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 47s | master passed | | +1 :green_heart: | compile | 3m 20s | master passed | | +1 :green_heart: | shadedjars | 7m 44s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-common in master failed. | | -0 :warning: | javadoc | 0m 19s | hbase-hadoop-compat in master failed. | | -0 :warning: | javadoc | 0m 29s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 46s | hbase-server in master failed. | | -0 :warning: | javadoc | 1m 1s | hbase-thrift in master failed. | | -0 :warning: | javadoc | 0m 14s | root in master failed. | | -0 :warning: | patch | 12m 29s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 48s | the patch passed | | +1 :green_heart: | compile | 3m 20s | the patch passed | | +1 :green_heart: | javac | 3m 20s | the patch passed | | +1 :green_heart: | shadedjars | 7m 45s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javadoc | 0m 28s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 45s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 1m 2s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 15s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 255m 26s | root in the patch passed. | | | | 298m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2261 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d1256e8b6594 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / fe776306d0 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc |
[GitHub] [hbase] Apache-HBase commented on pull request #2357: HBASE-24991 Replace MovedRegionsCleaner with guava cache
Apache-HBase commented on pull request #2357: URL: https://github.com/apache/hbase/pull/2357#issuecomment-691668809 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 23s | master passed | | +1 :green_heart: | checkstyle | 1m 3s | master passed | | +1 :green_heart: | spotbugs | 1m 55s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | -0 :warning: | checkstyle | 1m 2s | hbase-server: The patch generated 1 new + 41 unchanged - 4 fixed = 42 total (was 45) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 5s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 9s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 31m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2357 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 812749011c19 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / a393fc594c | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2357/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25016) Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
[ https://issues.apache.org/jira/browse/HBASE-25016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195032#comment-17195032 ] Viraj Jasani commented on HBASE-25016: -- Oh, I missed this. Yes, Table also should be closed. try-with-resources should define two resources: Table and ResultScanner using that table reference. > Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName > --- > > Key: HBASE-25016 > URL: https://issues.apache.org/jira/browse/HBASE-25016 > Project: HBase > Issue Type: Bug > Components: master, meta >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 > > > It will cause resource leak. > Th good news is that this method is only used for cluster maintainance, such > as assign or unassign region manually, so it is less hurt. Anyway, we should > fix it ASAP. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25016) Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
[ https://issues.apache.org/jira/browse/HBASE-25016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195033#comment-17195033 ] Viraj Jasani commented on HBASE-25016: -- [~niuyulin] you can create an addendum PR. > Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName > --- > > Key: HBASE-25016 > URL: https://issues.apache.org/jira/browse/HBASE-25016 > Project: HBase > Issue Type: Bug > Components: master, meta >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 > > > It will cause resource leak. > Th good news is that this method is only used for cluster maintainance, such > as assign or unassign region manually, so it is less hurt. Anyway, we should > fix it ASAP. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (HBASE-25016) Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
[ https://issues.apache.org/jira/browse/HBASE-25016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-25016: --- The PR is not complete, we should also close the Table which is returned by calling getMetaHTable... > Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName > --- > > Key: HBASE-25016 > URL: https://issues.apache.org/jira/browse/HBASE-25016 > Project: HBase > Issue Type: Bug > Components: master, meta >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 > > > It will cause resource leak. > Th good news is that this method is only used for cluster maintainance, such > as assign or unassign region manually, so it is less hurt. Anyway, we should > fix it ASAP. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-25016) Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
[ https://issues.apache.org/jira/browse/HBASE-25016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25016. -- Fix Version/s: 2.3.2 2.4.0 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed > Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName > --- > > Key: HBASE-25016 > URL: https://issues.apache.org/jira/browse/HBASE-25016 > Project: HBase > Issue Type: Bug > Components: master, meta >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 > > > It will cause resource leak. > Th good news is that this method is only used for cluster maintainance, such > as assign or unassign region manually, so it is less hurt. Anyway, we should > fix it ASAP. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25016) Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
[ https://issues.apache.org/jira/browse/HBASE-25016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195024#comment-17195024 ] Viraj Jasani commented on HBASE-25016: -- Thanks for the contribution [~niuyulin]. > Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName > --- > > Key: HBASE-25016 > URL: https://issues.apache.org/jira/browse/HBASE-25016 > Project: HBase > Issue Type: Bug > Components: master, meta >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Critical > > It will cause resource leak. > Th good news is that this method is only used for cluster maintainance, such > as assign or unassign region manually, so it is less hurt. Anyway, we should > fix it ASAP. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24975) HBASE shell update_config doesn't work for master node
[ https://issues.apache.org/jira/browse/HBASE-24975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195006#comment-17195006 ] Viraj Jasani commented on HBASE-24975: -- I checked the relevant code and it seems to be working fine. Could you please provide sequence of steps that you used to repro this? e.g how you updated hbase-site on server X, Y, Z. And after executing update_config 'X', what behaviour was observed, any specific logs that implies above configs are not changing? Moreover, these configs are only applicable for active HMaster, hope that was the case with "update_config server_name" command. > HBASE shell update_config doesn't work for master node > -- > > Key: HBASE-24975 > URL: https://issues.apache.org/jira/browse/HBASE-24975 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.3.1 >Reporter: Clara Xiong >Priority: Critical > > The helper message says: > Reload a subset of configuration on server 'servername' where servername is > host, port plus startcode. For example: > host187.example.com,60020,1289493121758 > See http://hbase.apache.org/book.html#dyn_config for more details. Here is how > you would run the command in the hbase shell: > hbase> update_config 'servername' > > But the command doesn't update config on master. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25020) Fix major compaction interval check logic bug when value of `hbase.hregion.majorcompaction` is below 0
[
https://issues.apache.org/jira/browse/HBASE-25020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuqi updated HBASE-25020:
-
Description:
In `RatioBasedCompactionPolicy#shouldPerformMajorCompaction`
{code:java}
// mcTime can be less than 0
long mcTime = getNextMajorCompactTime(filesToCompact);
//this check logic can't handle the condtion that mcTime is less than 0
if (filesToCompact == null || filesToCompact.isEmpty() || mcTime == 0) {
return result;
}
// As long as lowTimestamp > 0, the following logic is true, and major
compaction will run continually
if (lowTimestamp > 0L && lowTimestamp < (now - mcTime))
{code}
Am i wrong?, By the way, do hbase allow to set negative values to properties
like this? is it necessary to make valid check?
was:
In `RatioBasedCompactionPolicy#shouldPerformMajorCompaction`
{code:java}
// mcTime can be less than 0
long mcTime = getNextMajorCompactTime(filesToCompact);
//this check logic can't handle the condtion that mcTime is less than 0
if (filesToCompact == null || filesToCompact.isEmpty() || mcTime == 0) {
return result;
}
// As long as lowTimestamp > 0, the following logic is true, and major
compaction will run continually
if (lowTimestamp > 0L && lowTimestamp < (now - mcTime))
{code}
> Fix major compaction interval check logic bug when value of
> `hbase.hregion.majorcompaction` is below 0
> --
>
> Key: HBASE-25020
> URL: https://issues.apache.org/jira/browse/HBASE-25020
> Project: HBase
> Issue Type: Bug
>Reporter: yuqi
>Assignee: yuqi
>Priority: Minor
>
> In `RatioBasedCompactionPolicy#shouldPerformMajorCompaction`
> {code:java}
> // mcTime can be less than 0
> long mcTime = getNextMajorCompactTime(filesToCompact);
> //this check logic can't handle the condtion that mcTime is less than 0
> if (filesToCompact == null || filesToCompact.isEmpty() || mcTime == 0) {
> return result;
> }
>
> // As long as lowTimestamp > 0, the following logic is true, and major
> compaction will run continually
> if (lowTimestamp > 0L && lowTimestamp < (now - mcTime))
> {code}
> Am i wrong?, By the way, do hbase allow to set negative values to properties
> like this? is it necessary to make valid check?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani closed pull request #2390: HBASE-25016 Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName
virajjasani closed pull request #2390: URL: https://github.com/apache/hbase/pull/2390 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25020) Fix major compaction interval check logic bug when value of `hbase.hregion.majorcompaction` is below 0
[
https://issues.apache.org/jira/browse/HBASE-25020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuqi updated HBASE-25020:
-
Description:
In `RatioBasedCompactionPolicy#shouldPerformMajorCompaction`
{code:java}
// mcTime can be less than 0
long mcTime = getNextMajorCompactTime(filesToCompact);
//this check logic can't handle the condtion that mcTime is less than 0
if (filesToCompact == null || filesToCompact.isEmpty() || mcTime == 0) {
return result;
}
// As long as lowTimestamp > 0, the following logic is true, and major
compaction will run continually
if (lowTimestamp > 0L && lowTimestamp < (now - mcTime))
{code}
was:
In `RatioBasedCompactionPolicy#shouldPerformMajorCompaction`
{code:java}
// mcTime can be less than 0
long mcTime = getNextMajorCompactTime(filesToCompact);
//this check logic can't handle the condtion that mcTime is less than 0
if (filesToCompact == null || filesToCompact.isEmpty() || mcTime == 0) {
return result;
}
// As long as lowTimestamp > 0, the following logic is true
if (lowTimestamp > 0L && lowTimestamp < (now - mcTime))
{code}
> Fix major compaction interval check logic bug when value of
> `hbase.hregion.majorcompaction` is below 0
> --
>
> Key: HBASE-25020
> URL: https://issues.apache.org/jira/browse/HBASE-25020
> Project: HBase
> Issue Type: Bug
>Reporter: yuqi
>Assignee: yuqi
>Priority: Minor
>
> In `RatioBasedCompactionPolicy#shouldPerformMajorCompaction`
> {code:java}
> // mcTime can be less than 0
> long mcTime = getNextMajorCompactTime(filesToCompact);
> //this check logic can't handle the condtion that mcTime is less than 0
> if (filesToCompact == null || filesToCompact.isEmpty() || mcTime == 0) {
> return result;
> }
>
> // As long as lowTimestamp > 0, the following logic is true, and major
> compaction will run continually
> if (lowTimestamp > 0L && lowTimestamp < (now - mcTime))
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-25020) Fix major compaction interval check logic bug when value of `hbase.hregion.majorcompaction` is below 0
yuqi created HBASE-25020:
Summary: Fix major compaction interval check logic bug when value
of `hbase.hregion.majorcompaction` is below 0
Key: HBASE-25020
URL: https://issues.apache.org/jira/browse/HBASE-25020
Project: HBase
Issue Type: Bug
Reporter: yuqi
Assignee: yuqi
In `RatioBasedCompactionPolicy#shouldPerformMajorCompaction`
{code:java}
// mcTime can be less than 0
long mcTime = getNextMajorCompactTime(filesToCompact);
//this check logic can't handle the condtion that mcTime is less than 0
if (filesToCompact == null || filesToCompact.isEmpty() || mcTime == 0) {
return result;
}
// As long as lowTimestamp > 0, the following logic is true
if (lowTimestamp > 0L && lowTimestamp < (now - mcTime))
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-691654076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 56s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 29s | master passed | | +1 :green_heart: | checkstyle | 2m 25s | master passed | | +0 :ok: | refguide | 5m 40s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotbugs | 18m 50s | master passed | | -0 :warning: | patch | 10m 35s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 48s | the patch passed | | -0 :warning: | checkstyle | 2m 23s | root: The patch generated 8 new + 511 unchanged - 0 fixed = 519 total (was 511) | | -0 :warning: | rubocop | 0m 24s | The patch generated 15 new + 587 unchanged - 9 fixed = 602 total (was 596) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 5m 37s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 12m 22s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 7m 35s | the patch passed | | +1 :green_heart: | spotbugs | 20m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 27s | The patch does not generate ASF License warnings. | | | | 97m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2261 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide xml cc hbaseprotoc prototool rubocop | | uname | Linux 2578ca0f47cf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / fe776306d0 | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-general-check/output/branch-site/book.html | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 122 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-common hbase-hadoop-compat hbase-client hbase-server hbase-thrift hbase-shell . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/18/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25006) Make the cost functions optional for StochastoicBalancer
[ https://issues.apache.org/jira/browse/HBASE-25006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194951#comment-17194951 ] Viraj Jasani commented on HBASE-25006: -- Thanks for the contribution [~clarax98007]. > Make the cost functions optional for StochastoicBalancer > > > Key: HBASE-25006 > URL: https://issues.apache.org/jira/browse/HBASE-25006 > Project: HBase > Issue Type: Improvement >Reporter: Clara Xiong >Assignee: Clara Xiong >Priority: Major > > StochastoicBalancer takes a long time to generate a plan for larger clusters. > We want to make the cost functions optional. > hbase.master.balancer.stochastic.regionCountCost: 0 > hbase.master.balancer.stochastic.primaryRegionCountCost: 0 > hbase.master.balancer.stochastic.tableSkewCost: 0 > hbase.master.balancer.stochastic.rackLocalityCost:0 > hbase.master.balancer.stochastic.readRequestCost: 0 > hbase.master.balancer.stochastic.cpRequestCost: 0 > hbase.master.balancer.stochastic.writeRequestCost: 0 > hbase.master.balancer.stochastic.regionReplicaHostCostKey: 0 > hbase.master.balancer.stochastic.memstoreSizeCost: 0 > hbase.master.balancer.stochastic.storefileSizeCost: 0 > hbase.master.balancer.stochastic.regionReplicaRackCostKey: 0 > hbase.master.balancer.stochastic.serverLocalityCost:0 > > This will turn off all cost functions > To keep some of them, we just need to set some to positive value -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-25006) Make the cost functions optional for StochastoicBalancer
[ https://issues.apache.org/jira/browse/HBASE-25006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25006. -- Fix Version/s: 2.3.2 2.4.0 1.7.0 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed > Make the cost functions optional for StochastoicBalancer > > > Key: HBASE-25006 > URL: https://issues.apache.org/jira/browse/HBASE-25006 > Project: HBase > Issue Type: Improvement >Reporter: Clara Xiong >Assignee: Clara Xiong >Priority: Major > Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0, 2.3.2 > > > StochastoicBalancer takes a long time to generate a plan for larger clusters. > We want to make the cost functions optional. > hbase.master.balancer.stochastic.regionCountCost: 0 > hbase.master.balancer.stochastic.primaryRegionCountCost: 0 > hbase.master.balancer.stochastic.tableSkewCost: 0 > hbase.master.balancer.stochastic.rackLocalityCost:0 > hbase.master.balancer.stochastic.readRequestCost: 0 > hbase.master.balancer.stochastic.cpRequestCost: 0 > hbase.master.balancer.stochastic.writeRequestCost: 0 > hbase.master.balancer.stochastic.regionReplicaHostCostKey: 0 > hbase.master.balancer.stochastic.memstoreSizeCost: 0 > hbase.master.balancer.stochastic.storefileSizeCost: 0 > hbase.master.balancer.stochastic.regionReplicaRackCostKey: 0 > hbase.master.balancer.stochastic.serverLocalityCost:0 > > This will turn off all cost functions > To keep some of them, we just need to set some to positive value -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani closed pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
virajjasani closed pull request #2376: URL: https://github.com/apache/hbase/pull/2376 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani closed pull request #2386: HBASE-25006 Make the cost functions optional for StochastoicBalancer
virajjasani closed pull request #2386: URL: https://github.com/apache/hbase/pull/2386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2391: HBASE-25018 EOM cleanup
virajjasani commented on pull request #2391: URL: https://github.com/apache/hbase/pull/2391#issuecomment-691636248 patch refguide looks good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
