[jira] [Updated] (HBASE-27240) Clean up error-prone findings in hbase-http
[ https://issues.apache.org/jira/browse/HBASE-27240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27240: -- Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to branch-2.5+. > Clean up error-prone findings in hbase-http > --- > > Key: HBASE-27240 > URL: https://issues.apache.org/jira/browse/HBASE-27240 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4657: HBASE-27246 RSGroupMappingScript#getRSGroup Should be Synchronized
Apache-HBase commented on PR #4657: URL: https://github.com/apache/hbase/pull/4657#issuecomment-1211599093 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 30s | master passed | | +1 :green_heart: | compile | 0m 41s | master passed | | +1 :green_heart: | shadedjars | 3m 45s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 12s | the patch passed | | +1 :green_heart: | compile | 0m 41s | the patch passed | | +1 :green_heart: | javac | 0m 41s | the patch passed | | +1 :green_heart: | shadedjars | 3m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 209m 42s | hbase-server in the patch passed. | | | | 226m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4657/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4657 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e98d69c6b99e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 00612106b5 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4657/2/testReport/ | | Max. process+thread count | 2834 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4657/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #4653: HBASE-27240 Clean up error-prone findings in hbase-http
Apache9 merged PR #4653: URL: https://github.com/apache/hbase/pull/4653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4657: HBASE-27246 RSGroupMappingScript#getRSGroup Should be Synchronized
Apache-HBase commented on PR #4657: URL: https://github.com/apache/hbase/pull/4657#issuecomment-1211590512 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 0s | master passed | | +1 :green_heart: | compile | 0m 42s | master passed | | +1 :green_heart: | shadedjars | 3m 52s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 26s | the patch passed | | +1 :green_heart: | compile | 0m 43s | the patch passed | | +1 :green_heart: | javac | 0m 43s | the patch passed | | +1 :green_heart: | shadedjars | 3m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 192m 11s | hbase-server in the patch passed. | | | | 213m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4657/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4657 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e5c21ad88b71 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 00612106b5 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4657/2/testReport/ | | Max. process+thread count | 2870 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4657/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-21587) Improve support for protobuf 3
[
https://issues.apache.org/jira/browse/HBASE-21587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578275#comment-17578275
]
Duo Zhang commented on HBASE-21587:
---
Good, my pleasure.
> Improve support for protobuf 3
> --
>
> Key: HBASE-21587
> URL: https://issues.apache.org/jira/browse/HBASE-21587
> Project: HBase
> Issue Type: Improvement
>Reporter: Mya Pitzeruse
>Priority: Major
>
> {{HBaseZeroCopyByteString}} extends {{LiteralByteString}} which was removed
> in protobuf 3. The class was marked as package private, so hbase needed to do
> a package trick to get to the underlying class.
> [https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-protocol/src/main/java/com/google/protobuf/HBaseZeroCopyByteString.java#L18]
> ejona86 references this problem in grpc-java:
> [https://github.com/grpc/grpc-java/issues/3035#issuecomment-360851817]
> The {{HBaseZeroCopyByteString}} class appears to only be used by
> {{ByteStringer}} class.
> [https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java#L42-L49]
> I think a simple change can be made to the {{ByteStringer}} class to support
> both proto2 and proto3.
> Proto3 offers an {{UnsafeByteOperations}} class that can be used in place of
> the {{HBaseZeroCopyByteString}} class.
> [https://github.com/protocolbuffers/protobuf/blob/master/java/core/src/main/java/com/google/protobuf/UnsafeByteOperations.java#L97]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-21587) Improve support for protobuf 3
[
https://issues.apache.org/jira/browse/HBASE-21587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578264#comment-17578264
]
Ayush Saxena commented on HBASE-21587:
--
Thanx [~zhangduo] for the help. It worked. :)
> Improve support for protobuf 3
> --
>
> Key: HBASE-21587
> URL: https://issues.apache.org/jira/browse/HBASE-21587
> Project: HBase
> Issue Type: Improvement
>Reporter: Mya Pitzeruse
>Priority: Major
>
> {{HBaseZeroCopyByteString}} extends {{LiteralByteString}} which was removed
> in protobuf 3. The class was marked as package private, so hbase needed to do
> a package trick to get to the underlying class.
> [https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-protocol/src/main/java/com/google/protobuf/HBaseZeroCopyByteString.java#L18]
> ejona86 references this problem in grpc-java:
> [https://github.com/grpc/grpc-java/issues/3035#issuecomment-360851817]
> The {{HBaseZeroCopyByteString}} class appears to only be used by
> {{ByteStringer}} class.
> [https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java#L42-L49]
> I think a simple change can be made to the {{ByteStringer}} class to support
> both proto2 and proto3.
> Proto3 offers an {{UnsafeByteOperations}} class that can be used in place of
> the {{HBaseZeroCopyByteString}} class.
> [https://github.com/protocolbuffers/protobuf/blob/master/java/core/src/main/java/com/google/protobuf/UnsafeByteOperations.java#L97]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27292) Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
[
https://issues.apache.org/jira/browse/HBASE-27292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578263#comment-17578263
]
Hudson commented on HBASE-27292:
Results for branch branch-2.5
[build #182 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/182/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/182/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/182/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/182/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/182/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
>
>
> Key: HBASE-27292
> URL: https://issues.apache.org/jira/browse/HBASE-27292
> Project: HBase
> Issue Type: Bug
> Components: build, hadoop3, pom
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> {noformat}
> $ mvn clean install -DskipTests -Phadoop-3.0 -Dhadoop-three.version=3.3.4
> ...
> [ERROR] Found artifact with unexpected contents:
> '/home/rocky/srcs/hbase/hbase-shaded/hbase-shaded-mapreduce/target/hbase-shaded-mapreduce-3.0.0-alpha-4-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> okhttp3/
> okhttp3/Request$Builder.class
> ...
> kotlin/
> kotlin/collections/
> kotlin/collections/ArraysUtilJVM.class
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27248) WALPrettyPrinter add print timestamp
[
https://issues.apache.org/jira/browse/HBASE-27248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578262#comment-17578262
]
Hudson commented on HBASE-27248:
Results for branch branch-2.5
[build #182 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/182/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/182/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/182/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/182/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/182/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> WALPrettyPrinter add print timestamp
>
>
> Key: HBASE-27248
> URL: https://issues.apache.org/jira/browse/HBASE-27248
> Project: HBase
> Issue Type: Task
> Components: tooling, wal
>Reporter: zhengsicheng
>Assignee: zhengsicheng
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> hbase wal -wal -p, print include timestamp
> At first:
> row=rowA, column=f:c1, type=Delete
> value:
> cell total size sum: 88
>
> New:
> row=rowA, column=f:c1, timestamp=1657851212679, type=Delete
> value:
> cell total size sum: 88
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27248) WALPrettyPrinter add print timestamp
[
https://issues.apache.org/jira/browse/HBASE-27248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578252#comment-17578252
]
Hudson commented on HBASE-27248:
Results for branch master
[build #653 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/653/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/653/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/653/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/653/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> WALPrettyPrinter add print timestamp
>
>
> Key: HBASE-27248
> URL: https://issues.apache.org/jira/browse/HBASE-27248
> Project: HBase
> Issue Type: Task
> Components: tooling, wal
>Reporter: zhengsicheng
>Assignee: zhengsicheng
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> hbase wal -wal -p, print include timestamp
> At first:
> row=rowA, column=f:c1, type=Delete
> value:
> cell total size sum: 88
>
> New:
> row=rowA, column=f:c1, timestamp=1657851212679, type=Delete
> value:
> cell total size sum: 88
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27292) Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
[
https://issues.apache.org/jira/browse/HBASE-27292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578253#comment-17578253
]
Hudson commented on HBASE-27292:
Results for branch master
[build #653 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/653/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/653/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/653/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/653/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
>
>
> Key: HBASE-27292
> URL: https://issues.apache.org/jira/browse/HBASE-27292
> Project: HBase
> Issue Type: Bug
> Components: build, hadoop3, pom
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> {noformat}
> $ mvn clean install -DskipTests -Phadoop-3.0 -Dhadoop-three.version=3.3.4
> ...
> [ERROR] Found artifact with unexpected contents:
> '/home/rocky/srcs/hbase/hbase-shaded/hbase-shaded-mapreduce/target/hbase-shaded-mapreduce-3.0.0-alpha-4-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> okhttp3/
> okhttp3/Request$Builder.class
> ...
> kotlin/
> kotlin/collections/
> kotlin/collections/ArraysUtilJVM.class
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (HBASE-23186) Close dfs output stream in fsck threads when master exit
[
https://issues.apache.org/jira/browse/HBASE-23186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578243#comment-17578243
]
chaijunjie edited comment on HBASE-23186 at 8/11/22 4:06 AM:
-
I find the same bug in HBase 2.2 in our env, if we have any idea to fix it?
was (Author: JIRAUSER286971):
I find the same bug in HBase 2.2, if we have any idea to fix it?
> Close dfs output stream in fsck threads when master exit
>
>
> Key: HBASE-23186
> URL: https://issues.apache.org/jira/browse/HBASE-23186
> Project: HBase
> Issue Type: Bug
> Components: master
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> HBASE-21072 imported to use HBaseFsck as default in hbase2.
> {code:java}
> if (this.conf.getBoolean("hbase.write.hbck1.lock.file", true)) {
> HBaseFsck.checkAndMarkRunningHbck(this.conf,
> HBaseFsck.createLockRetryCounterFactory(this.conf).create());
> }{code}
>
> We should close the dfs output stream when master abort/stop.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-23186) Close dfs output stream in fsck threads when master exit
[
https://issues.apache.org/jira/browse/HBASE-23186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578243#comment-17578243
]
chaijunjie commented on HBASE-23186:
I find the same bug in HBase 2.2, if we have any idea to fix it?
> Close dfs output stream in fsck threads when master exit
>
>
> Key: HBASE-23186
> URL: https://issues.apache.org/jira/browse/HBASE-23186
> Project: HBase
> Issue Type: Bug
> Components: master
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> HBASE-21072 imported to use HBaseFsck as default in hbase2.
> {code:java}
> if (this.conf.getBoolean("hbase.write.hbck1.lock.file", true)) {
> HBaseFsck.checkAndMarkRunningHbck(this.conf,
> HBaseFsck.createLockRetryCounterFactory(this.conf).create());
> }{code}
>
> We should close the dfs output stream when master abort/stop.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work started] (HBASE-27267) Delete causes timestamp to be negative
[
https://issues.apache.org/jira/browse/HBASE-27267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-27267 started by zhengsicheng.
> Delete causes timestamp to be negative
> --
>
> Key: HBASE-27267
> URL: https://issues.apache.org/jira/browse/HBASE-27267
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.3.4
>Reporter: zhengsicheng
>Assignee: zhengsicheng
>Priority: Major
>
> When client-1.1.6 and server-2.3.4 there is a case where the batch delete
> timestamp is negative
> # 1. RegionServer log message:
> {code:java}
> 2022-07-19 12:13:29,324 WARN
> [RS_OPEN_REGION-regionserver/HBASE-HOSTNAME1:16020-1.replicationSource.wal-reader.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.regiongroup-2,clusterB]
> hbase.KeyValueUtil: Timestamp cannot be negative, ts=-4323977095312258207,
> KeyValueBytesHex=\x00\x00\x00, offset=0, length=40
> 2022-07-19 12:13:29,324 WARN
> [RS_OPEN_REGION-regionserver/HBASE-HOSTNAME1:16020-1.replicationSource.wal-reader.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.regiongroup-2,clusterB]
> wal.ProtobufLogReader: Encountered a malformed edit, seeking back to last
> good position in file, from 1099261 to 1078224
> java.io.EOFException: EOF while reading 660 WAL KVs; started reading at
> 1078317 and read up to 1099261
> at
> org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:403)
> at
> org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:97)
> at
> org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:85)
> at
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:264)
> at
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:178)
> at
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:103)
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:230)
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:145)
> Caused by: java.lang.IllegalArgumentException: Timestamp cannot be negative,
> ts=-4323977095312258207, KeyValueBytesHex=\x00\x00\x00, offset=0, length=40
> at
> org.apache.hadoop.hbase.KeyValueUtil.checkKeyValueBytes(KeyValueUtil.java:612)
> at org.apache.hadoop.hbase.KeyValue.(KeyValue.java:346)
> at
> org.apache.hadoop.hbase.KeyValueUtil.createKeyValueFromInputStream(KeyValueUtil.java:717)
> at
> org.apache.hadoop.hbase.codec.KeyValueCodecWithTags$KeyValueDecoder.parseCell(KeyValueCodecWithTags.java:81)
> at org.apache.hadoop.hbase.codec.BaseDecoder.advance(BaseDecoder.java:68)
> at org.apache.hadoop.hbase.wal.WALEdit.readFromCells(WALEdit.java:276)
> at
> org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:387)
> ... 7 more
> {code}
> # 2. Debug WAL file ,found that the delete operation is caused
> {code:java}
> Sequence=365693989, table=tableA, region=148cedb7b8ca3145690800fd650e084d, at
> write timestamp=Sat Jul 16 00:50:01 CST 2022
> 2022-07-22 22:09:43,244 ERROR [main] wal.WALPrettyPrinter: Timestamp is
> negative row=rowkey1, column=d:act, timestamp=-4323977095312258207,
> type=Delete
> {code}
> # 3. User use spark read/write hbase
> batchsize is 1
> {code:scala}
> def dataDeleteFromHbase(rdd: RDD[(String, String)], hbase_table: String,
> hbase_instance: String, hbase_accesskey: String, accumulator:
> LongAccumulator, buffersize: String, batchsize: Int): Unit = {
> rdd.foreachPartition(iterator => {
> val partitionId = TaskContext.getPartitionId()
> val conf = HBaseConfiguration.create()
> val connection = SparkHbaseUtils.getconnection(conf)
> val table = connection.getTable(TableName.valueOf(hbase_table))
> var deleteList = new util.LinkedList[Delete]()
> var count = 0
> var batchCount = 0
> while (iterator.hasNext) {
> val element = iterator.next
> val crc32 = new CRC32()
> crc32.update(s"${element._1}_${element._2}".getBytes())
> val crcArr = convertLow4bit2SmallEndan(crc32.getValue)
> val key = concat(DigestUtils.md5(s"${element._1}_${element._2}"),
> crcArr)
> val delete = new Delete(key)
> deleteList.add(delete)
> count += 1
> if (count % batchsize.toInt == 0) {
> batchCount = batchCount + 1
> try {
> table.delete(deleteList)
> } catch {
> case _: RetriesExhaustedWithDetailsExc
[jira] [Assigned] (HBASE-27267) Delete causes timestamp to be negative
[
https://issues.apache.org/jira/browse/HBASE-27267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhengsicheng reassigned HBASE-27267:
Assignee: zhengsicheng
> Delete causes timestamp to be negative
> --
>
> Key: HBASE-27267
> URL: https://issues.apache.org/jira/browse/HBASE-27267
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.3.4
>Reporter: zhengsicheng
>Assignee: zhengsicheng
>Priority: Major
>
> When client-1.1.6 and server-2.3.4 there is a case where the batch delete
> timestamp is negative
> # 1. RegionServer log message:
> {code:java}
> 2022-07-19 12:13:29,324 WARN
> [RS_OPEN_REGION-regionserver/HBASE-HOSTNAME1:16020-1.replicationSource.wal-reader.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.regiongroup-2,clusterB]
> hbase.KeyValueUtil: Timestamp cannot be negative, ts=-4323977095312258207,
> KeyValueBytesHex=\x00\x00\x00, offset=0, length=40
> 2022-07-19 12:13:29,324 WARN
> [RS_OPEN_REGION-regionserver/HBASE-HOSTNAME1:16020-1.replicationSource.wal-reader.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.regiongroup-2,clusterB]
> wal.ProtobufLogReader: Encountered a malformed edit, seeking back to last
> good position in file, from 1099261 to 1078224
> java.io.EOFException: EOF while reading 660 WAL KVs; started reading at
> 1078317 and read up to 1099261
> at
> org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:403)
> at
> org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:97)
> at
> org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:85)
> at
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:264)
> at
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:178)
> at
> org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:103)
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:230)
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:145)
> Caused by: java.lang.IllegalArgumentException: Timestamp cannot be negative,
> ts=-4323977095312258207, KeyValueBytesHex=\x00\x00\x00, offset=0, length=40
> at
> org.apache.hadoop.hbase.KeyValueUtil.checkKeyValueBytes(KeyValueUtil.java:612)
> at org.apache.hadoop.hbase.KeyValue.(KeyValue.java:346)
> at
> org.apache.hadoop.hbase.KeyValueUtil.createKeyValueFromInputStream(KeyValueUtil.java:717)
> at
> org.apache.hadoop.hbase.codec.KeyValueCodecWithTags$KeyValueDecoder.parseCell(KeyValueCodecWithTags.java:81)
> at org.apache.hadoop.hbase.codec.BaseDecoder.advance(BaseDecoder.java:68)
> at org.apache.hadoop.hbase.wal.WALEdit.readFromCells(WALEdit.java:276)
> at
> org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:387)
> ... 7 more
> {code}
> # 2. Debug WAL file ,found that the delete operation is caused
> {code:java}
> Sequence=365693989, table=tableA, region=148cedb7b8ca3145690800fd650e084d, at
> write timestamp=Sat Jul 16 00:50:01 CST 2022
> 2022-07-22 22:09:43,244 ERROR [main] wal.WALPrettyPrinter: Timestamp is
> negative row=rowkey1, column=d:act, timestamp=-4323977095312258207,
> type=Delete
> {code}
> # 3. User use spark read/write hbase
> batchsize is 1
> {code:scala}
> def dataDeleteFromHbase(rdd: RDD[(String, String)], hbase_table: String,
> hbase_instance: String, hbase_accesskey: String, accumulator:
> LongAccumulator, buffersize: String, batchsize: Int): Unit = {
> rdd.foreachPartition(iterator => {
> val partitionId = TaskContext.getPartitionId()
> val conf = HBaseConfiguration.create()
> val connection = SparkHbaseUtils.getconnection(conf)
> val table = connection.getTable(TableName.valueOf(hbase_table))
> var deleteList = new util.LinkedList[Delete]()
> var count = 0
> var batchCount = 0
> while (iterator.hasNext) {
> val element = iterator.next
> val crc32 = new CRC32()
> crc32.update(s"${element._1}_${element._2}".getBytes())
> val crcArr = convertLow4bit2SmallEndan(crc32.getValue)
> val key = concat(DigestUtils.md5(s"${element._1}_${element._2}"),
> crcArr)
> val delete = new Delete(key)
> deleteList.add(delete)
> count += 1
> if (count % batchsize.toInt == 0) {
> batchCount = batchCount + 1
> try {
> table.delete(deleteList)
> } catch {
> case _: RetriesExhaustedW
[GitHub] [hbase] Apache-HBase commented on pull request #4657: HBASE-27246 RSGroupMappingScript#getRSGroup Should be Synchronized
Apache-HBase commented on PR #4657: URL: https://github.com/apache/hbase/pull/4657#issuecomment-1211511754 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 26s | master passed | | +1 :green_heart: | compile | 2m 16s | master passed | | +1 :green_heart: | checkstyle | 0m 32s | master passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 18s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 11s | the patch passed | | +1 :green_heart: | compile | 2m 14s | the patch passed | | +1 :green_heart: | javac | 2m 14s | the patch passed | | -0 :warning: | checkstyle | 0m 30s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 33s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | -1 :x: | spotless | 0m 36s | patch has 24 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 1m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 31m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4657/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4657 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 521e2693b92d 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 00612106b5 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4657/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4657/2/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 69 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4657/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean commented on pull request #4657: HBASE-27246 RSGroupMappingScript#getRSGroup Should be Synchronized
YutSean commented on PR #4657: URL: https://github.com/apache/hbase/pull/4657#issuecomment-1211495014 > Why not just create a ShellCommandExecutor everytime? Checked the ShellCommandExecutor constructor and find no time costly step. Has changed to local variable creation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4675: HBASE-27264 Add options to consider compressed size when delimiting blocks during hfile writes
Apache9 commented on PR #4675: URL: https://github.com/apache/hbase/pull/4675#issuecomment-1211484307 > > > At least I've proposed another way to predicate the compression rate right? But I do not think there is a always win algorithm here, so a pluggable algorithm will be more appropriate here? > > Sorry, I think I misunderstood it, previously. What if we leave this current PR as is, for an initial approach on using compressed sizes to determine blocks, then work on the pluggable solution on a separate ticket? If we expose the configs out then it will be a pain to switch to a pluggable solution because we can not simply remove these configs without a deprecation cycle... I still prefer we make a pluggable solution first, and then the first approach could be the algorithm in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27292) Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
[
https://issues.apache.org/jira/browse/HBASE-27292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578199#comment-17578199
]
Hudson commented on HBASE-27292:
Results for branch branch-2
[build #613 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/613/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/613/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/613/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/613/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/613/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
>
>
> Key: HBASE-27292
> URL: https://issues.apache.org/jira/browse/HBASE-27292
> Project: HBase
> Issue Type: Bug
> Components: build, hadoop3, pom
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> {noformat}
> $ mvn clean install -DskipTests -Phadoop-3.0 -Dhadoop-three.version=3.3.4
> ...
> [ERROR] Found artifact with unexpected contents:
> '/home/rocky/srcs/hbase/hbase-shaded/hbase-shaded-mapreduce/target/hbase-shaded-mapreduce-3.0.0-alpha-4-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> okhttp3/
> okhttp3/Request$Builder.class
> ...
> kotlin/
> kotlin/collections/
> kotlin/collections/ArraysUtilJVM.class
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27248) WALPrettyPrinter add print timestamp
[
https://issues.apache.org/jira/browse/HBASE-27248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578198#comment-17578198
]
Hudson commented on HBASE-27248:
Results for branch branch-2
[build #613 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/613/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/613/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/613/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/613/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/613/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> WALPrettyPrinter add print timestamp
>
>
> Key: HBASE-27248
> URL: https://issues.apache.org/jira/browse/HBASE-27248
> Project: HBase
> Issue Type: Task
> Components: tooling, wal
>Reporter: zhengsicheng
>Assignee: zhengsicheng
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> hbase wal -wal -p, print include timestamp
> At first:
> row=rowA, column=f:c1, type=Delete
> value:
> cell total size sum: 88
>
> New:
> row=rowA, column=f:c1, timestamp=1657851212679, type=Delete
> value:
> cell total size sum: 88
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27292) Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
[
https://issues.apache.org/jira/browse/HBASE-27292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578187#comment-17578187
]
Hudson commented on HBASE-27292:
Results for branch branch-2.4
[build #407 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/407/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/407/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/407/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/407/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/407/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
>
>
> Key: HBASE-27292
> URL: https://issues.apache.org/jira/browse/HBASE-27292
> Project: HBase
> Issue Type: Bug
> Components: build, hadoop3, pom
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> {noformat}
> $ mvn clean install -DskipTests -Phadoop-3.0 -Dhadoop-three.version=3.3.4
> ...
> [ERROR] Found artifact with unexpected contents:
> '/home/rocky/srcs/hbase/hbase-shaded/hbase-shaded-mapreduce/target/hbase-shaded-mapreduce-3.0.0-alpha-4-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> okhttp3/
> okhttp3/Request$Builder.class
> ...
> kotlin/
> kotlin/collections/
> kotlin/collections/ArraysUtilJVM.class
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27244) bin/hbase still use slf4j-log4j while reload4j in place
[
https://issues.apache.org/jira/browse/HBASE-27244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578186#comment-17578186
]
Hudson commented on HBASE-27244:
Results for branch branch-2.4
[build #407 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/407/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/407/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/407/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/407/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/407/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> bin/hbase still use slf4j-log4j while reload4j in place
> ---
>
> Key: HBASE-27244
> URL: https://issues.apache.org/jira/browse/HBASE-27244
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.4.13
>Reporter: Dong0829
>Assignee: Dong0829
>Priority: Major
> Fix For: 2.4.14
>
>
> For the bin/hbase file, there are some class path set which will handle the
> slf4j-log4j before, but now in hbase branch 2, we upgrade to reload4j, but
> the hbase file not upgrade, for example, if we run mapredcp:
> hbase mapredcp:
> /usr/lib/hbase/lib/shaded-clients/hbase-shaded-mapreduce-2.4.12.jar:/usr/lib/hbase/lib/client-facing-thirdparty/audience-annotations-0.5.0.jar:/usr/lib/hbase/lib/client-facing-thirdparty/commons-logging-1.2.jar:/usr/lib/hbase/lib/client-facing-thirdparty/htrace-core4-4.2.0-incubating.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jcl-over-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jul-to-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/reload4j-1.2.19.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-api-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar
> Among above,
> /usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar should
> be excluded but as slf4j-log4j before
> This will impact the downstream users
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27241) Add metrics for evaluating cost and effectiveness of bloom filters
[
https://issues.apache.org/jira/browse/HBASE-27241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578140#comment-17578140
]
Hudson commented on HBASE-27241:
Results for branch branch-2.5
[build #181 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/181/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/181/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/181/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/181/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/181/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add metrics for evaluating cost and effectiveness of bloom filters
> --
>
> Key: HBASE-27241
> URL: https://issues.apache.org/jira/browse/HBASE-27241
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Labels: patch-available
> Fix For: 2.5.1, 3.0.0-alpha-4
>
>
> Bloom filters can be costly for some tables, easily resulting in an aggregate
> memory footprint of many GBs. It's currently hard to monitor for that cost on
> a per-table basis. You can view {{staticBloomSize}} in JMX, but that is for
> the whole server. Otherwise you must manually sum the values using the
> regionserver UI. We can add this (as well as staticIndexSize) to the
> per-table metrics.
> Additionally, it can be hard to know how effective those bloom filters are. I
> think the easiest way to measure that is to count bloomFilterRequests and
> bloomFilterNegativeResults. With these metrics in hand, one can have an
> easier time deciding how much memory they want to give to their L1 cache
> and/or whether they want to disable blooms on a table.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27241) Add metrics for evaluating cost and effectiveness of bloom filters
[
https://issues.apache.org/jira/browse/HBASE-27241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578137#comment-17578137
]
Hudson commented on HBASE-27241:
Results for branch master
[build #652 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/652/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/652/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/652/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/652/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add metrics for evaluating cost and effectiveness of bloom filters
> --
>
> Key: HBASE-27241
> URL: https://issues.apache.org/jira/browse/HBASE-27241
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Labels: patch-available
> Fix For: 2.5.1, 3.0.0-alpha-4
>
>
> Bloom filters can be costly for some tables, easily resulting in an aggregate
> memory footprint of many GBs. It's currently hard to monitor for that cost on
> a per-table basis. You can view {{staticBloomSize}} in JMX, but that is for
> the whole server. Otherwise you must manually sum the values using the
> regionserver UI. We can add this (as well as staticIndexSize) to the
> per-table metrics.
> Additionally, it can be hard to know how effective those bloom filters are. I
> think the easiest way to measure that is to count bloomFilterRequests and
> bloomFilterNegativeResults. With these metrics in hand, one can have an
> easier time deciding how much memory they want to give to their L1 cache
> and/or whether they want to disable blooms on a table.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27288) Update compatibility matrix and release manager section in our ref guide about the EOL of 1.x
[
https://issues.apache.org/jira/browse/HBASE-27288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578138#comment-17578138
]
Hudson commented on HBASE-27288:
Results for branch master
[build #652 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/652/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/652/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/652/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/652/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update compatibility matrix and release manager section in our ref guide
> about the EOL of 1.x
> -
>
> Key: HBASE-27288
> URL: https://issues.apache.org/jira/browse/HBASE-27288
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (HBASE-27270) Add bulkloadExecutor.resizeQueues
[ https://issues.apache.org/jira/browse/HBASE-27270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-27270: --- > Add bulkloadExecutor.resizeQueues > - > > Key: HBASE-27270 > URL: https://issues.apache.org/jira/browse/HBASE-27270 > Project: HBase > Issue Type: Sub-task > Components: regionserver, rpc >Reporter: zhengsicheng >Assignee: zhengsicheng >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27270) Add bulkloadExecutor.resizeQueues
[ https://issues.apache.org/jira/browse/HBASE-27270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27270. --- Resolution: Fixed > Add bulkloadExecutor.resizeQueues > - > > Key: HBASE-27270 > URL: https://issues.apache.org/jira/browse/HBASE-27270 > Project: HBase > Issue Type: Sub-task > Components: regionserver, rpc >Reporter: zhengsicheng >Assignee: zhengsicheng >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27292) Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
[
https://issues.apache.org/jira/browse/HBASE-27292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-27292:
--
Fix Version/s: 2.5.0
3.0.0-alpha-4
2.4.14
Hadoop Flags: Reviewed
Resolution: Fixed
Status: Resolved (was: Patch Available)
Pushed to branch-2.4+.
Thanks [~iwasakims] for contributing!
> Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
>
>
> Key: HBASE-27292
> URL: https://issues.apache.org/jira/browse/HBASE-27292
> Project: HBase
> Issue Type: Bug
> Components: build, hadoop3, pom
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> {noformat}
> $ mvn clean install -DskipTests -Phadoop-3.0 -Dhadoop-three.version=3.3.4
> ...
> [ERROR] Found artifact with unexpected contents:
> '/home/rocky/srcs/hbase/hbase-shaded/hbase-shaded-mapreduce/target/hbase-shaded-mapreduce-3.0.0-alpha-4-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> okhttp3/
> okhttp3/Request$Builder.class
> ...
> kotlin/
> kotlin/collections/
> kotlin/collections/ArraysUtilJVM.class
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (HBASE-27214) Implement the new replication log cleaner
[ https://issues.apache.org/jira/browse/HBASE-27214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LiangJun He reassigned HBASE-27214: --- Assignee: LiangJun He > Implement the new replication log cleaner > - > > Key: HBASE-27214 > URL: https://issues.apache.org/jira/browse/HBASE-27214 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: LiangJun He >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27270) Add bulkloadExecutor.resizeQueues
[ https://issues.apache.org/jira/browse/HBASE-27270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhengsicheng updated HBASE-27270: - Fix Version/s: 2.6.0 3.0.0-alpha-4 > Add bulkloadExecutor.resizeQueues > - > > Key: HBASE-27270 > URL: https://issues.apache.org/jira/browse/HBASE-27270 > Project: HBase > Issue Type: Sub-task > Components: regionserver, rpc >Reporter: zhengsicheng >Assignee: zhengsicheng >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27270) Add bulkloadExecutor.resizeQueues
[ https://issues.apache.org/jira/browse/HBASE-27270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhengsicheng resolved HBASE-27270. -- Resolution: Resolved > Add bulkloadExecutor.resizeQueues > - > > Key: HBASE-27270 > URL: https://issues.apache.org/jira/browse/HBASE-27270 > Project: HBase > Issue Type: Sub-task > Components: regionserver, rpc >Reporter: zhengsicheng >Assignee: zhengsicheng >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27144) Add special rpc handlers for bulkload operations
[ https://issues.apache.org/jira/browse/HBASE-27144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhengsicheng updated HBASE-27144: - Release Note: Bulkload will consume a lot of resources in the cluster. We try to reduce the impact of bulkload on online services and do simple resource isolation for bulkload. The bulkload RpcExecutor is disabled by default. Enable by setting "hbase.regionserver.bulkload.handler.count" greater than 0. Online HBASE cluster "hbase.regionserver.bulkload.handler.count" is recommended to be set to 1. Offline HBASE clusters can be appropriately increased. "hbase.regionserver.bulkload.handler.count" works with "hbase.ipc.server.bulkload.max.callqueue.length". > Add special rpc handlers for bulkload operations > > > Key: HBASE-27144 > URL: https://issues.apache.org/jira/browse/HBASE-27144 > Project: HBase > Issue Type: Improvement > Components: regionserver, rpc >Reporter: zhengsicheng >Assignee: zhengsicheng >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4 > > Attachments: image-2022-06-22-11-47-26-963.png > > > Bulkload will consume a lot of resources in the cluster. We try to reduce the > impact of bulkload on online services and do simple resource isolation for > bulkload. > !image-2022-06-22-11-47-26-963.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27292) Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
[
https://issues.apache.org/jira/browse/HBASE-27292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-27292:
--
Component/s: hadoop3
> Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
>
>
> Key: HBASE-27292
> URL: https://issues.apache.org/jira/browse/HBASE-27292
> Project: HBase
> Issue Type: Bug
> Components: hadoop3
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Major
>
> {noformat}
> $ mvn clean install -DskipTests -Phadoop-3.0 -Dhadoop-three.version=3.3.4
> ...
> [ERROR] Found artifact with unexpected contents:
> '/home/rocky/srcs/hbase/hbase-shaded/hbase-shaded-mapreduce/target/hbase-shaded-mapreduce-3.0.0-alpha-4-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> okhttp3/
> okhttp3/Request$Builder.class
> ...
> kotlin/
> kotlin/collections/
> kotlin/collections/ArraysUtilJVM.class
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27292) Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
[
https://issues.apache.org/jira/browse/HBASE-27292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-27292:
--
Component/s: build
pom
> Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp
>
>
> Key: HBASE-27292
> URL: https://issues.apache.org/jira/browse/HBASE-27292
> Project: HBase
> Issue Type: Bug
> Components: build, hadoop3, pom
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Major
>
> {noformat}
> $ mvn clean install -DskipTests -Phadoop-3.0 -Dhadoop-three.version=3.3.4
> ...
> [ERROR] Found artifact with unexpected contents:
> '/home/rocky/srcs/hbase/hbase-shaded/hbase-shaded-mapreduce/target/hbase-shaded-mapreduce-3.0.0-alpha-4-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> okhttp3/
> okhttp3/Request$Builder.class
> ...
> kotlin/
> kotlin/collections/
> kotlin/collections/ArraysUtilJVM.class
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (HBASE-27248) WALPrettyPrinter add print timestamp
[ https://issues.apache.org/jira/browse/HBASE-27248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27248. --- Fix Version/s: 2.5.0 3.0.0-alpha-4 Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.5+. Thanks [~zhengsicheng] for contributing! > WALPrettyPrinter add print timestamp > > > Key: HBASE-27248 > URL: https://issues.apache.org/jira/browse/HBASE-27248 > Project: HBase > Issue Type: Task > Components: tooling, wal >Reporter: zhengsicheng >Assignee: zhengsicheng >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-4 > > > hbase wal -wal -p, print include timestamp > At first: > row=rowA, column=f:c1, type=Delete > value: > cell total size sum: 88 > > New: > row=rowA, column=f:c1, timestamp=1657851212679, type=Delete > value: > cell total size sum: 88 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 merged pull request #4687: HBASE-27292. Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp.
Apache9 merged PR #4687: URL: https://github.com/apache/hbase/pull/4687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27248) WALPrettyPrinter add print timestamp
[ https://issues.apache.org/jira/browse/HBASE-27248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27248: -- Component/s: tooling wal > WALPrettyPrinter add print timestamp > > > Key: HBASE-27248 > URL: https://issues.apache.org/jira/browse/HBASE-27248 > Project: HBase > Issue Type: Task > Components: tooling, wal >Reporter: zhengsicheng >Assignee: zhengsicheng >Priority: Minor > > hbase wal -wal -p, print include timestamp > At first: > row=rowA, column=f:c1, type=Delete > value: > cell total size sum: 88 > > New: > row=rowA, column=f:c1, timestamp=1657851212679, type=Delete > value: > cell total size sum: 88 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 merged pull request #4659: HBASE-27248 WALPrettyPrinter add print timestamp
Apache9 merged PR #4659: URL: https://github.com/apache/hbase/pull/4659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring
Apache9 commented on code in PR #4691:
URL: https://github.com/apache/hbase/pull/4691#discussion_r942426722
##
hbase-http/src/main/java/org/apache/hadoop/hbase/http/prometheus/PrometheusHadoop2Servlet.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.http.prometheus;
+
+import java.io.IOException;
+import java.io.Writer;
+import java.util.Collection;
+import java.util.regex.Pattern;
+import javax.servlet.http.HttpServlet;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import com.google.errorprone.annotations.RestrictedApi;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.metrics2.AbstractMetric;
+import org.apache.hadoop.metrics2.MetricType;
+import org.apache.hadoop.metrics2.MetricsRecord;
+import org.apache.hadoop.metrics2.MetricsTag;
+import org.apache.hadoop.metrics2.impl.MetricsExportHelper;
+import org.apache.yetus.audience.InterfaceAudience;
+
+@InterfaceAudience.Private
+public class PrometheusHadoop2Servlet extends HttpServlet {
+
+ private static final Pattern SPLIT_PATTERN =
+Pattern.compile("(?<=[a-z])(?=[A-Z])|(?<=[A-Z])(?=([A-Z][a-z]))|\\W|(_)+");
+
+ @Override
+ protected void doGet(HttpServletRequest req, HttpServletResponse resp)
+throws IOException {
+writeMetrics(resp.getWriter());
+ }
+
+ static String toPrometheusName(String metricRecordName, String metricName) {
+String baseName = metricRecordName + StringUtils.capitalize(metricName);
+String[] parts = SPLIT_PATTERN.split(baseName);
+return String
+ .join("_", parts)
+ .toLowerCase();
+ }
+
+ @RestrictedApi(explanation = "Should only be called in tests", link = "",
+allowedOnPath = ".*/src/test/.*")
+ void writeMetrics(Writer writer) throws IOException {
+Collection metricRecords = MetricsExportHelper.export();
+for (MetricsRecord metricsRecord : metricRecords) {
+ for (AbstractMetric metrics : metricsRecord.metrics()) {
+if (metrics.type() == MetricType.COUNTER || metrics.type() ==
MetricType.GAUGE) {
Review Comment:
We do not want to rely on prometheus simpleclient to do this?
##
hbase-http/src/main/java/org/apache/hadoop/hbase/http/prometheus/PrometheusHadoop2Servlet.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.http.prometheus;
+
+import java.io.IOException;
+import java.io.Writer;
+import java.util.Collection;
+import java.util.regex.Pattern;
+import javax.servlet.http.HttpServlet;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import com.google.errorprone.annotations.RestrictedApi;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.metrics2.AbstractMetric;
+import org.apache.hadoop.metrics2.MetricType;
+import org.apache.hadoop.metrics2.MetricsRecord;
+import org.apache.hadoop.metrics2.MetricsTag;
+import org.apache.hadoop.metrics2.impl.MetricsExportHelper;
+import org.apache.yetus.audience.InterfaceAudience;
+
+@InterfaceAudience.Private
+public class PrometheusHadoop2Servlet extends HttpServlet {
Review Comment:
Why name it hadoop2, not hadoop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[GitHub] [hbase] Apache-HBase commented on pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring
Apache-HBase commented on PR #4691: URL: https://github.com/apache/hbase/pull/4691#issuecomment-1210452230 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 57s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 25s | master passed | | +1 :green_heart: | compile | 8m 34s | master passed | | +1 :green_heart: | checkstyle | 1m 14s | master passed | | +0 :ok: | refguide | 2m 56s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotless | 1m 1s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 13m 2s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | -1 :x: | compile | 1m 33s | root in the patch failed. | | -0 :warning: | javac | 1m 33s | root in the patch failed. | | -0 :warning: | checkstyle | 1m 10s | root: The patch generated 18 new + 0 unchanged - 0 fixed = 18 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 2m 30s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 16m 6s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | -1 :x: | spotless | 0m 17s | patch has 56 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 11m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 39s | The patch does not generate ASF License warnings. | | | | 80m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4691 | | Optional Tests | dupname asflicense javac refguide spotless xml spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 07d031032f1b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8c0633688e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4691/1/yetus-general-check/output/branch-site/book.html | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/artifact/yetus-general-check/output/patch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/artifact/yetus-general-check/output/patch-compile-root.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-4691/1/yetus-general-check/output/patch-site/book.html | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 137 (vs. ulimit of 3) | | modules | C: hbase-common hbase-hadoop-compat hbase-http . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring
Apache-HBase commented on PR #4691: URL: https://github.com/apache/hbase/pull/4691#issuecomment-1210402559 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 25s | master passed | | +1 :green_heart: | compile | 1m 26s | master passed | | +1 :green_heart: | shadedjars | 4m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 3s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 31s | the patch passed | | +1 :green_heart: | compile | 1m 50s | the patch passed | | +1 :green_heart: | javac | 1m 50s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 0s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 14m 21s | root in the patch failed. | | | | 39m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4691 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 074038d6d1b7 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8c0633688e | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/testReport/ | | Max. process+thread count | 462 (vs. ulimit of 3) | | modules | C: hbase-common hbase-hadoop-compat hbase-http . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring
Apache-HBase commented on PR #4691: URL: https://github.com/apache/hbase/pull/4691#issuecomment-1210402330 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 47s | master passed | | +1 :green_heart: | compile | 1m 56s | master passed | | +1 :green_heart: | shadedjars | 3m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 37s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 30s | the patch passed | | +1 :green_heart: | compile | 1m 54s | the patch passed | | +1 :green_heart: | javac | 1m 54s | the patch passed | | +1 :green_heart: | shadedjars | 3m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 14m 23s | root in the patch failed. | | | | 39m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4691 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 98987fd1805e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8c0633688e | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/testReport/ | | Max. process+thread count | 642 (vs. ulimit of 3) | | modules | C: hbase-common hbase-hadoop-compat hbase-http . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4691/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] lucakovacs opened a new pull request, #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring
lucakovacs opened a new pull request, #4691: URL: https://github.com/apache/hbase/pull/4691 Co-authored-by: Luca Kovacs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210347544 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for branch | | +1 :green_heart: | spotless | 0m 37s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 3m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4690 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs | | uname | Linux ea863ff2fb50 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8c0633688e | | Max. process+thread count | 33 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/2/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210346958 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4690 | | Optional Tests | | | uname | Linux a8b83e6888c4 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8c0633688e | | Max. process+thread count | 37 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210345540 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4690 | | Optional Tests | | | uname | Linux 77c96a0c3ba9 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8c0633688e | | Max. process+thread count | 28 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210344519 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/2/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210344387 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/2/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210344260 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/2/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4657: HBASE-27246 RSGroupMappingScript#getRSGroup Should be Synchronized
Apache9 commented on PR #4657: URL: https://github.com/apache/hbase/pull/4657#issuecomment-1210328340 Why not just create a ShellCommandExecutor everytime? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-27244) bin/hbase still use slf4j-log4j while reload4j in place
[ https://issues.apache.org/jira/browse/HBASE-27244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27244. --- Fix Version/s: 2.4.14 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch-2.4+. Thanks [~Li0829] for contributing! > bin/hbase still use slf4j-log4j while reload4j in place > --- > > Key: HBASE-27244 > URL: https://issues.apache.org/jira/browse/HBASE-27244 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.4.13 >Reporter: Dong0829 >Assignee: Dong0829 >Priority: Major > Fix For: 2.4.14 > > > For the bin/hbase file, there are some class path set which will handle the > slf4j-log4j before, but now in hbase branch 2, we upgrade to reload4j, but > the hbase file not upgrade, for example, if we run mapredcp: > hbase mapredcp: > /usr/lib/hbase/lib/shaded-clients/hbase-shaded-mapreduce-2.4.12.jar:/usr/lib/hbase/lib/client-facing-thirdparty/audience-annotations-0.5.0.jar:/usr/lib/hbase/lib/client-facing-thirdparty/commons-logging-1.2.jar:/usr/lib/hbase/lib/client-facing-thirdparty/htrace-core4-4.2.0-incubating.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jcl-over-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jul-to-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/reload4j-1.2.19.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-api-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar > Among above, > /usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar should > be excluded but as slf4j-log4j before > This will impact the downstream users -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27244) bin/hbase still use slf4j-log4j while reload4j in place
[ https://issues.apache.org/jira/browse/HBASE-27244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27244: - Assignee: Dong0829 > bin/hbase still use slf4j-log4j while reload4j in place > --- > > Key: HBASE-27244 > URL: https://issues.apache.org/jira/browse/HBASE-27244 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.4.13 >Reporter: Dong0829 >Assignee: Dong0829 >Priority: Major > > For the bin/hbase file, there are some class path set which will handle the > slf4j-log4j before, but now in hbase branch 2, we upgrade to reload4j, but > the hbase file not upgrade, for example, if we run mapredcp: > hbase mapredcp: > /usr/lib/hbase/lib/shaded-clients/hbase-shaded-mapreduce-2.4.12.jar:/usr/lib/hbase/lib/client-facing-thirdparty/audience-annotations-0.5.0.jar:/usr/lib/hbase/lib/client-facing-thirdparty/commons-logging-1.2.jar:/usr/lib/hbase/lib/client-facing-thirdparty/htrace-core4-4.2.0-incubating.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jcl-over-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jul-to-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/reload4j-1.2.19.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-api-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar > Among above, > /usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar should > be excluded but as slf4j-log4j before > This will impact the downstream users -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 merged pull request #4652: [HBASE-27244]Fix the issue legacy log4j issue: https://issues.apache.org/jira/brow…
Apache9 merged PR #4652: URL: https://github.com/apache/hbase/pull/4652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4687: HBASE-27292. Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp.
Apache9 commented on PR #4687: URL: https://github.com/apache/hbase/pull/4687#issuecomment-1210279281 Verified locally, this PR can fix the build problem when building with 3.3.4. I think we should add newer hadoop versions to our hadoop check versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210268076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch | | -0 :warning: | shellcheck | 0m 1s | The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 3m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4690 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs | | uname | Linux b8a4347838bb 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8c0633688e | | shellcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/1/artifact/yetus-general-check/output/diff-patch-shellcheck.txt | | Max. process+thread count | 34 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/1/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210266538 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4690 | | Optional Tests | | | uname | Linux 04eb246d0e5c 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8c0633688e | | Max. process+thread count | 32 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210266086 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4690 | | Optional Tests | | | uname | Linux 0b7787dd09ec 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8c0633688e | | Max. process+thread count | 43 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210265694 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/1/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210265452 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/1/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4690: HBASE-27293 Remove jenkins and personality scripts support for 1.x
Apache-HBase commented on PR #4690: URL: https://github.com/apache/hbase/pull/4690#issuecomment-1210265331 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4690/1/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27293) Remove jenkins and personality scripts support for 1.x
[ https://issues.apache.org/jira/browse/HBASE-27293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27293: -- Summary: Remove jenkins and personality scripts support for 1.x (was: Remove pre commit script support for 1.x) > Remove jenkins and personality scripts support for 1.x > -- > > Key: HBASE-27293 > URL: https://issues.apache.org/jira/browse/HBASE-27293 > Project: HBase > Issue Type: Sub-task > Components: scripts >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
