[GitHub] [hbase] virajjasani commented on pull request #4829: HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept…
virajjasani commented on PR #4829: URL: https://github.com/apache/hbase/pull/4829#issuecomment-1277059976 @vli02 could you please add just one extra line on hbase-server/pom.xml just so that all hbase-server tests would be run. Once we are good to merge, this minor change can be reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a diff in pull request #4829: HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept…
virajjasani commented on code in PR #4829:
URL: https://github.com/apache/hbase/pull/4829#discussion_r994162853
##
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java:
##
@@ -735,13 +735,21 @@ public void
interruptedExceptionNoThrow(InterruptedException ie, boolean throwLa
*/
@Override
public void close() {
+LOG.info("ZKWatcher close started.");
+zkEventProcessor.shutdown();
try {
- recoverableZooKeeper.close();
+ zkEventProcessor.awaitTermination(60, TimeUnit.SECONDS);
} catch (InterruptedException e) {
+ LOG.warn("ZKWatcher event processor has not finished to terminate.");
Thread.currentThread().interrupt();
} finally {
- zkEventProcessor.shutdownNow();
+ try {
+recoverableZooKeeper.close();
+ } catch (InterruptedException e) {
+Thread.currentThread().interrupt();
+ }
}
+LOG.info("ZKWatcher close finished.");
Review Comment:
I think this is redundant, can be removed.
##
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java:
##
@@ -735,13 +735,21 @@ public void
interruptedExceptionNoThrow(InterruptedException ie, boolean throwLa
*/
@Override
public void close() {
+LOG.info("ZKWatcher close started.");
Review Comment:
This one also can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule
[
https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616779#comment-17616779
]
Hudson commented on HBASE-27421:
Results for branch branch-2
[build #662 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/662/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/662/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/662/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/662/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/662/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc
> stubs' rule
>
>
> Key: HBASE-27421
> URL: https://issues.apache.org/jira/browse/HBASE-27421
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, pom
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> spotless maven 2.27.2 is released and it contains
> https://github.com/diffplug/spotless/issues/1359, which allows the
> replacement to be null, so we can add back the 'Remove unhelpful javadoc
> stubs' rule now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4827: HBASE-27422: Support replication for hbase:acl
Apache-HBase commented on PR #4827: URL: https://github.com/apache/hbase/pull/4827#issuecomment-1276978243 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 30s | master passed | | +1 :green_heart: | compile | 2m 18s | master passed | | +1 :green_heart: | checkstyle | 0m 30s | master passed | | +1 :green_heart: | spotless | 0m 39s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 17s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 8s | the patch passed | | +1 :green_heart: | compile | 2m 11s | the patch passed | | +1 :green_heart: | javac | 2m 11s | the patch passed | | +1 :green_heart: | checkstyle | 0m 28s | the patch passed | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 10s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 28m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4827/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4827 | | JIRA Issue | HBASE-27422 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 326f0e3b4cc3 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d260f5b22 | | Default Java | Temurin-1.8.0_345-b01 | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4827/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] taklwu commented on pull request #4827: HBASE-27422: Support replication for hbase:acl
taklwu commented on PR #4827: URL: https://github.com/apache/hbase/pull/4827#issuecomment-1276962524 retest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4829: HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept…
Apache-HBase commented on PR #4829: URL: https://github.com/apache/hbase/pull/4829#issuecomment-1276851997 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 24s | master passed | | +1 :green_heart: | compile | 0m 19s | master passed | | +1 :green_heart: | checkstyle | 0m 8s | master passed | | +1 :green_heart: | spotless | 0m 39s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 20s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 11s | the patch passed | | +1 :green_heart: | compile | 0m 16s | the patch passed | | +1 :green_heart: | javac | 0m 16s | the patch passed | | +1 :green_heart: | checkstyle | 0m 6s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 8m 2s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 36s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 21m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4829 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 829b9171a2fb 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d260f5b22 | | Default Java | Temurin-1.8.0_345-b01 | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-zookeeper U: hbase-zookeeper | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4829: HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept…
Apache-HBase commented on PR #4829: URL: https://github.com/apache/hbase/pull/4829#issuecomment-1276850775 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | master passed | | +1 :green_heart: | compile | 0m 14s | master passed | | +1 :green_heart: | shadedjars | 4m 21s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 2s | the patch passed | | +1 :green_heart: | compile | 0m 14s | the patch passed | | +1 :green_heart: | javac | 0m 14s | the patch passed | | +1 :green_heart: | shadedjars | 4m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 42s | hbase-zookeeper in the patch passed. | | | | 19m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4829 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fcb5be87e929 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d260f5b22 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/testReport/ | | Max. process+thread count | 229 (vs. ulimit of 3) | | modules | C: hbase-zookeeper U: hbase-zookeeper | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4829: HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept…
Apache-HBase commented on PR #4829: URL: https://github.com/apache/hbase/pull/4829#issuecomment-1276850761 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 56s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 48s | master passed | | +1 :green_heart: | compile | 0m 13s | master passed | | +1 :green_heart: | shadedjars | 4m 29s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 27s | the patch passed | | +1 :green_heart: | compile | 0m 12s | the patch passed | | +1 :green_heart: | javac | 0m 12s | the patch passed | | +1 :green_heart: | shadedjars | 4m 36s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 40s | hbase-zookeeper in the patch passed. | | | | 18m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4829 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux de1e22c2e160 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d260f5b22 | | Default Java | Temurin-1.8.0_345-b01 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/testReport/ | | Max. process+thread count | 212 (vs. ulimit of 3) | | modules | C: hbase-zookeeper U: hbase-zookeeper | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] vli02 opened a new pull request, #4829: HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept…
vli02 opened a new pull request, #4829: URL: https://github.com/apache/hbase/pull/4829 …ion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27426) Region server abort with failing to list region servers.
Victor Li created HBASE-27426: - Summary: Region server abort with failing to list region servers. Key: HBASE-27426 URL: https://issues.apache.org/jira/browse/HBASE-27426 Project: HBase Issue Type: Bug Components: Zookeeper Reporter: Victor Li During unit tests, clusters were created and destroyed, the region server could abort during shutdown with failing to list region servers. Logs: 2022-10-11 18:44:43,393 INFO [main] utility.HBaseClusterSetup(160): Starting mini cluster: singleCluster [master/victorli-wsl:0:becomeActiveMaster] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - not a secure deployment, proceeding 2022-10-11 18:45:07,234 INFO [Listener at localhost/45185] utility.HBaseClusterSetup(177): Started mini cluster: singleCluster [Listener at localhost/45185] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close started. [Listener at localhost/45185] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close finished. [Listener at localhost/45185] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close started. [Listener at localhost/45185] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close finished. 2022-10-11 18:45:45,980 INFO [Listener at localhost/45185] utility.HBaseClusterSetup(132): Stopping mini cluster: singleCluster [RS:0;victorli-wsl:35113] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close started. [zk-event-processor-pool-0] ERROR org.apache.hadoop.hbase.regionserver.HRegionServer - * ABORTING region server victorli-wsl,35113,1665539090704: failed to list region servers * [RS:0;victorli-wsl:35113] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close finished. [M:0;victorli-wsl:42915] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close started. [M:0;victorli-wsl:42915] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close finished. 2022-10-11 18:45:57,208 INFO [Listener at localhost/45185] utility.HBaseClusterSetup(144): Stopped mini cluster: singleCluster Stack: [zk-event-processor-pool-0] WARN org.apache.hadoop.hbase.zookeeper.ZKUtil - regionserver:35113-0x101b6fed2a1, quorum=127.0.0.1:53028, baseZNode=/9 Unable to list children of znode /9/rs java.lang.InterruptedException at java.lang.Object.wait(Native Method) at java.lang.Object.wait(Object.java:502) at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1601) at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1573) at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:2420) at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.getChildren(RecoverableZooKeeper.java:341) at org.apache.hadoop.hbase.zookeeper.ZKUtil.listChildrenAndWatchForNewChildren(ZKUtil.java:190) at org.apache.hadoop.hbase.zookeeper.RegionServerAddressTracker.loadRegionServerList(RegionServerAddressTracker.java:54) at org.apache.hadoop.hbase.zookeeper.RegionServerAddressTracker.nodeChildrenChanged(RegionServerAddressTracker.java:71) at org.apache.hadoop.hbase.zookeeper.ZKWatcher.lambda$processEvent$0(ZKWatcher.java:586) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177) at org.apache.hadoop.hbase.zookeeper.ZKWatcher.processEvent(ZKWatcher.java:554) at org.apache.hadoop.hbase.zookeeper.ZKWatcher.lambda$process$1(ZKWatcher.java:607) at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule
[
https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616710#comment-17616710
]
Hudson commented on HBASE-27421:
Results for branch branch-2.4
[build #440 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/440/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/440/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/440/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/440/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/440/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc
> stubs' rule
>
>
> Key: HBASE-27421
> URL: https://issues.apache.org/jira/browse/HBASE-27421
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, pom
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> spotless maven 2.27.2 is released and it contains
> https://github.com/diffplug/spotless/issues/1359, which allows the
> replacement to be null, so we can add back the 'Remove unhelpful javadoc
> stubs' rule now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27339) Improve sasl connection failure log message to include server
[
https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616671#comment-17616671
]
Hudson commented on HBASE-27339:
Results for branch master
[build #700 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Improve sasl connection failure log message to include server
> -
>
> Key: HBASE-27339
> URL: https://issues.apache.org/jira/browse/HBASE-27339
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 1.7.2
>Reporter: Daniel Wong
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> We were seeing timeout issues in our deployment in the saslConnect path in
> the blockingRPC client. Knowing which server we failed to connect to would
> help isolate and understand the issue.
>
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server :
> java.io.IOException: Connection reset by peer {code}
>
>
> Change the log message to something like
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server myhost.realm.net:
> java.io.IOException: Connection reset by peer {code}
>
> See relevant code
> [here|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java#L398]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27420) Failure while connecting to zk if HBase is running in standalone mode in a container
[
https://issues.apache.org/jira/browse/HBASE-27420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616672#comment-17616672
]
Hudson commented on HBASE-27420:
Results for branch master
[build #700 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Failure while connecting to zk if HBase is running in standalone mode in a
> container
>
>
> Key: HBASE-27420
> URL: https://issues.apache.org/jira/browse/HBASE-27420
> Project: HBase
> Issue Type: Bug
> Components: Zookeeper
>Reporter: Sanjeet Malhotra
>Assignee: Sanjeet Malhotra
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> With [this change|https://issues.apache.org/jira/browse/HBASE-23993]
> zookeeper will only listen for client connections on 127.0.0.1 in standalone
> mode. If HBase is running in standalone mode inside a docker container and
> docker port forwarding is being used to connect to HBase inside container
> then, any client trying to connect to zk will have destination IP as
> container's private IP rather than loopback IP. This will cause zk to reject
> all client connections being initiated from outside the container.
> Thus, we need a way to make zk listen for client connections on IP other than
> loopback. zk already provides a property named `clientPortAddress` to specify
> the address to listen for client connections. And, we can specify zk
> properties using `hbase.zookeeper.property.` prefix. Thus, the proposal is to
> allow user to specify the IP address that zk will listen on using
> `hbase.zookeeper.property.clientPortAddress` and if its not specified then
> default to loopback as per current behaviour.
> This way, the tests will still remain unimpacted and HBase can also be used
> in standalone mode in a container.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27424) Upgrade Jettison for CVE-2022-40149/40150
[
https://issues.apache.org/jira/browse/HBASE-27424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616670#comment-17616670
]
Hudson commented on HBASE-27424:
Results for branch master
[build #700 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/700/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade Jettison for CVE-2022-40149/40150
> -
>
> Key: HBASE-27424
> URL: https://issues.apache.org/jira/browse/HBASE-27424
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> Jettison versions <= 1.5.0 are subject to CVE-2022-40149 and CVE-2022-40150.
> Move jettison.version to 1.5.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27339) Improve sasl connection failure log message to include server
[
https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616651#comment-17616651
]
Hudson commented on HBASE-27339:
Results for branch branch-2.5
[build #223 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Improve sasl connection failure log message to include server
> -
>
> Key: HBASE-27339
> URL: https://issues.apache.org/jira/browse/HBASE-27339
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 1.7.2
>Reporter: Daniel Wong
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> We were seeing timeout issues in our deployment in the saslConnect path in
> the blockingRPC client. Knowing which server we failed to connect to would
> help isolate and understand the issue.
>
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server :
> java.io.IOException: Connection reset by peer {code}
>
>
> Change the log message to something like
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server myhost.realm.net:
> java.io.IOException: Connection reset by peer {code}
>
> See relevant code
> [here|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java#L398]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27420) Failure while connecting to zk if HBase is running in standalone mode in a container
[
https://issues.apache.org/jira/browse/HBASE-27420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616652#comment-17616652
]
Hudson commented on HBASE-27420:
Results for branch branch-2.5
[build #223 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Failure while connecting to zk if HBase is running in standalone mode in a
> container
>
>
> Key: HBASE-27420
> URL: https://issues.apache.org/jira/browse/HBASE-27420
> Project: HBase
> Issue Type: Bug
> Components: Zookeeper
>Reporter: Sanjeet Malhotra
>Assignee: Sanjeet Malhotra
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> With [this change|https://issues.apache.org/jira/browse/HBASE-23993]
> zookeeper will only listen for client connections on 127.0.0.1 in standalone
> mode. If HBase is running in standalone mode inside a docker container and
> docker port forwarding is being used to connect to HBase inside container
> then, any client trying to connect to zk will have destination IP as
> container's private IP rather than loopback IP. This will cause zk to reject
> all client connections being initiated from outside the container.
> Thus, we need a way to make zk listen for client connections on IP other than
> loopback. zk already provides a property named `clientPortAddress` to specify
> the address to listen for client connections. And, we can specify zk
> properties using `hbase.zookeeper.property.` prefix. Thus, the proposal is to
> allow user to specify the IP address that zk will listen on using
> `hbase.zookeeper.property.clientPortAddress` and if its not specified then
> default to loopback as per current behaviour.
> This way, the tests will still remain unimpacted and HBase can also be used
> in standalone mode in a container.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27424) Upgrade Jettison for CVE-2022-40149/40150
[
https://issues.apache.org/jira/browse/HBASE-27424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616650#comment-17616650
]
Hudson commented on HBASE-27424:
Results for branch branch-2.5
[build #223 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/223/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade Jettison for CVE-2022-40149/40150
> -
>
> Key: HBASE-27424
> URL: https://issues.apache.org/jira/browse/HBASE-27424
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> Jettison versions <= 1.5.0 are subject to CVE-2022-40149 and CVE-2022-40150.
> Move jettison.version to 1.5.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Kota-SH commented on a diff in pull request #4827: HBASE-27422: Support replication for hbase:acl
Kota-SH commented on code in PR #4827:
URL: https://github.com/apache/hbase/pull/4827#discussion_r993797104
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/SystemTableWALEntryFilter.java:
##
@@ -17,16 +17,24 @@
*/
package org.apache.hadoop.hbase.replication;
+import org.apache.hadoop.hbase.security.access.PermissionStorage;
+import org.apache.hadoop.hbase.security.visibility.VisibilityConstants;
import org.apache.hadoop.hbase.wal.WAL.Entry;
import org.apache.yetus.audience.InterfaceAudience;
/**
- * Skips WAL edits for all System tables including hbase:meta.
+ * Skips WAL edits for all System tables including hbase:meta except hbase:acl.
*/
@InterfaceAudience.Private
public class SystemTableWALEntryFilter implements WALEntryFilter {
@Override
public Entry filter(Entry entry) {
+if (
+ entry.getKey().getTableName().equals(PermissionStorage.ACL_TABLE_NAME)
Review Comment:
Hi Duo, Thanks for the review.
> why only hbase:acl can be replicated but other system tables are not
As of now, only 2 tables can be allowed for replication - hbase:acl and
hbase:labels
1. hbase:meta - not to be replicated
2. hbase:canary - for current cluster
3. hbase:namespace - Deprecated and moved to meta
4. hbase:quota - related to namespace, quota for the current cluster
usage
5. hbase:rsgroup - contains hostnames
> how do you plan to use this feature
We are trying to set up an active-active deployment and we want this
hbase:acl table to be replicated so that any connected client to either one
cluster will have the same access control information.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4828: HBASE-27425 run flaky test job once an hour.
Apache-HBase commented on PR #4828: URL: https://github.com/apache/hbase/pull/4828#issuecomment-1276594860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 5s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | spotless | 0m 39s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 35s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 8m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4828/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4828 | | Optional Tests | dupname asflicense spotless | | uname | Linux 723a69c9b2c9 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d260f5b22 | | Max. process+thread count | 34 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4828/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4828: HBASE-27425 run flaky test job once an hour.
Apache-HBase commented on PR #4828: URL: https://github.com/apache/hbase/pull/4828#issuecomment-1276591949 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 1m 4s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 5m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4828/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4828 | | Optional Tests | | | uname | Linux 4e3e6d3abe89 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d260f5b22 | | Max. process+thread count | 42 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4828/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4828: HBASE-27425 run flaky test job once an hour.
Apache-HBase commented on PR #4828: URL: https://github.com/apache/hbase/pull/4828#issuecomment-1276588376 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4828/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4828 | | Optional Tests | | | uname | Linux 9b0a5de6dd63 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0d260f5b22 | | Max. process+thread count | 33 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4828/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] taklwu commented on pull request #4827: HBASE-27422: Support replication for hbase:acl
taklwu commented on PR #4827: URL: https://github.com/apache/hbase/pull/4827#issuecomment-1276585153 the JDK 11 tests `Archive JUnit-formatted test results` cannot read the test results, IMO it's unrelated to your change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27425) Run flaky test job more often
[ https://issues.apache.org/jira/browse/HBASE-27425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-27425: Status: Patch Available (was: In Progress) > Run flaky test job more often > - > > Key: HBASE-27425 > URL: https://issues.apache.org/jira/browse/HBASE-27425 > Project: HBase > Issue Type: Task > Components: test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > Attachments: ci-hbase-hbase-flaky-test-master-time-png.png, > ci-hbase-hbase-load-chart-long.png > > > We currently run the flaky tests once per 4 hours and keep a backlog of 50 > runs. That means it takes a perfect test a bit over 8 days to get back out of > being penalized. > we regularly are leaving a bunch of executors idle (see attached PNG) and I > think we should run the tests more often. > we use an executor per branch for a flaky test run. the duration depends on > the specific tests that are flagged, but it has a timeout of 2 hours. > as an example the master branch tests currently take < 30 minutes (see other > attached PNG). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27425) Run flaky test job more often
[ https://issues.apache.org/jira/browse/HBASE-27425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27425 started by Sean Busbey. --- > Run flaky test job more often > - > > Key: HBASE-27425 > URL: https://issues.apache.org/jira/browse/HBASE-27425 > Project: HBase > Issue Type: Task > Components: test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > Attachments: ci-hbase-hbase-flaky-test-master-time-png.png, > ci-hbase-hbase-load-chart-long.png > > > We currently run the flaky tests once per 4 hours and keep a backlog of 50 > runs. That means it takes a perfect test a bit over 8 days to get back out of > being penalized. > we regularly are leaving a bunch of executors idle (see attached PNG) and I > think we should run the tests more often. > we use an executor per branch for a flaky test run. the duration depends on > the specific tests that are flagged, but it has a timeout of 2 hours. > as an example the master branch tests currently take < 30 minutes (see other > attached PNG). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27425) Run flaky test job more often
[ https://issues.apache.org/jira/browse/HBASE-27425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616640#comment-17616640 ] Sean Busbey commented on HBASE-27425: - let's try once an hour and see how the executor load goes. that would give us a floor for test clearing of just over 2 days instead of 8. > Run flaky test job more often > - > > Key: HBASE-27425 > URL: https://issues.apache.org/jira/browse/HBASE-27425 > Project: HBase > Issue Type: Task > Components: test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > Attachments: ci-hbase-hbase-flaky-test-master-time-png.png, > ci-hbase-hbase-load-chart-long.png > > > We currently run the flaky tests once per 4 hours and keep a backlog of 50 > runs. That means it takes a perfect test a bit over 8 days to get back out of > being penalized. > we regularly are leaving a bunch of executors idle (see attached PNG) and I > think we should run the tests more often. > we use an executor per branch for a flaky test run. the duration depends on > the specific tests that are flagged, but it has a timeout of 2 hours. > as an example the master branch tests currently take < 30 minutes (see other > attached PNG). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27425) Run flaky test job more often
[ https://issues.apache.org/jira/browse/HBASE-27425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned HBASE-27425: --- Assignee: Sean Busbey > Run flaky test job more often > - > > Key: HBASE-27425 > URL: https://issues.apache.org/jira/browse/HBASE-27425 > Project: HBase > Issue Type: Task > Components: test >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > Attachments: ci-hbase-hbase-flaky-test-master-time-png.png, > ci-hbase-hbase-load-chart-long.png > > > We currently run the flaky tests once per 4 hours and keep a backlog of 50 > runs. That means it takes a perfect test a bit over 8 days to get back out of > being penalized. > we regularly are leaving a bunch of executors idle (see attached PNG) and I > think we should run the tests more often. > we use an executor per branch for a flaky test run. the duration depends on > the specific tests that are flagged, but it has a timeout of 2 hours. > as an example the master branch tests currently take < 30 minutes (see other > attached PNG). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27425) Run flaky test job more often
Sean Busbey created HBASE-27425: --- Summary: Run flaky test job more often Key: HBASE-27425 URL: https://issues.apache.org/jira/browse/HBASE-27425 Project: HBase Issue Type: Task Components: test Reporter: Sean Busbey Attachments: ci-hbase-hbase-flaky-test-master-time-png.png, ci-hbase-hbase-load-chart-long.png We currently run the flaky tests once per 4 hours and keep a backlog of 50 runs. That means it takes a perfect test a bit over 8 days to get back out of being penalized. we regularly are leaving a bunch of executors idle (see attached PNG) and I think we should run the tests more often. we use an executor per branch for a flaky test run. the duration depends on the specific tests that are flagged, but it has a timeout of 2 hours. as an example the master branch tests currently take < 30 minutes (see other attached PNG). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27411) Update and clean up bcprov-jdk15on dependency
[
https://issues.apache.org/jira/browse/HBASE-27411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616568#comment-17616568
]
Nick Dimiduk commented on HBASE-27411:
--
Thank you [~apurtell]!
> Update and clean up bcprov-jdk15on dependency
> --
>
> Key: HBASE-27411
> URL: https://issues.apache.org/jira/browse/HBASE-27411
> Project: HBase
> Issue Type: Task
> Components: build
>Affects Versions: 3.0.0-alpha-4
>Reporter: Nick Dimiduk
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> {noformat}
> $ env
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> mvn -T0.5C clean install -DskipTests
>
> [INFO] Scanning for projects...
>
>
> [WARNING]
>
>
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.hbase:hbase-server:jar:3.0.0-alpha-4-SNAPSHOT
>
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
> be unique: org.bouncycastle:bcprov-jdk15on:jar -> duplicate declaration of
> version (?) @ line 331, column 17
> [WARNING]
>
>
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
>
> [WARNING]
>
>
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.
>
> [WARNING]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27400) The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead of '\n'
[ https://issues.apache.org/jira/browse/HBASE-27400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616566#comment-17616566 ] Nick Dimiduk commented on HBASE-27400: -- Thank you [~zhangduo]! > The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead > of '\n' > --- > > Key: HBASE-27400 > URL: https://issues.apache.org/jira/browse/HBASE-27400 > Project: HBase > Issue Type: Umbrella > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > That's why there are lots of 'n' in our code base... > Let me find a way to fix this and clean up all the 'n's. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27400) The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead of '\n'
[ https://issues.apache.org/jira/browse/HBASE-27400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27400. --- Assignee: Duo Zhang Resolution: Fixed All sub tasks are done. Resolve. > The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead > of '\n' > --- > > Key: HBASE-27400 > URL: https://issues.apache.org/jira/browse/HBASE-27400 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > That's why there are lots of 'n' in our code base... > Let me find a way to fix this and clean up all the 'n's. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27400) The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead of '\n'
[ https://issues.apache.org/jira/browse/HBASE-27400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27400: -- Issue Type: Umbrella (was: Bug) > The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead > of '\n' > --- > > Key: HBASE-27400 > URL: https://issues.apache.org/jira/browse/HBASE-27400 > Project: HBase > Issue Type: Umbrella > Components: documentation >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > That's why there are lots of 'n' in our code base... > Let me find a way to fix this and clean up all the 'n's. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule
[ https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27421. --- Fix Version/s: 2.6.0 2.5.1 3.0.0-alpha-4 2.4.15 Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.4_. Thanks [~haxiaolin] for reviewing! > Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc > stubs' rule > > > Key: HBASE-27421 > URL: https://issues.apache.org/jira/browse/HBASE-27421 > Project: HBase > Issue Type: Sub-task > Components: documentation, pom >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15 > > > spotless maven 2.27.2 is released and it contains > https://github.com/diffplug/spotless/issues/1359, which allows the > replacement to be null, so we can add back the 'Remove unhelpful javadoc > stubs' rule now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 merged pull request #4824: HBASE-27421 Bump spotless plugin to 2.27.2 and reimplement the 'Remov…
Apache9 merged PR #4824: URL: https://github.com/apache/hbase/pull/4824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-27347) Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections
[ https://issues.apache.org/jira/browse/HBASE-27347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27347 started by Andor Molnar. > Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS > connections > - > > Key: HBASE-27347 > URL: https://issues.apache.org/jira/browse/HBASE-27347 > Project: HBase > Issue Type: New Feature > Components: IPC/RPC, security >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > Labels: security, ssl, tls > > As a follow-up feature I'd like to port the file watcher functionality from > ZooKeeper in order to avoid restarts when keystore/truststore is updated on a > running cluster. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1275883558 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 10s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 1m 53s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 3m 45s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 12s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 11s | the patch passed | | +1 :green_heart: | compile | 1m 52s | the patch passed | | +1 :green_heart: | javac | 1m 52s | the patch passed | | +1 :green_heart: | shadedjars | 3m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 31s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 5s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 27s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 1m 26s | hbase-procedure in the patch passed. | | +1 :green_heart: | unit | 222m 18s | hbase-server in the patch passed. | | | | 247m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2abf0f350678 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Temurin-1.8.0_345-b01 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/6/testReport/ | | Max. process+thread count | 3069 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1275871729 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 42s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 2s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 1m 58s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 4m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 9s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 42s | the patch passed | | +1 :green_heart: | compile | 2m 4s | the patch passed | | +1 :green_heart: | javac | 2m 4s | the patch passed | | +1 :green_heart: | shadedjars | 4m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 9s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 34s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 21s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 23s | hbase-replication in the patch passed. | | +1 :green_heart: | unit | 1m 25s | hbase-procedure in the patch passed. | | +1 :green_heart: | unit | 209m 27s | hbase-server in the patch passed. | | | | 238m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 446cab66390d 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/6/testReport/ | | Max. process+thread count | 2940 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4827: HBASE-27422: Support replication for hbase:acl
Apache-HBase commented on PR #4827: URL: https://github.com/apache/hbase/pull/4827#issuecomment-1275743009 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 13s | master passed | | +1 :green_heart: | compile | 0m 39s | master passed | | +1 :green_heart: | shadedjars | 3m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 0m 39s | the patch passed | | +1 :green_heart: | javac | 0m 39s | the patch passed | | +1 :green_heart: | shadedjars | 3m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 210m 44s | hbase-server in the patch passed. | | | | 227m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4827/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4827 | | JIRA Issue | HBASE-27422 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4663fdcd6b6e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b656456e20 | | Default Java | Temurin-1.8.0_345-b01 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4827/2/testReport/ | | Max. process+thread count | 2483 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4827/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4556: HBASE-26913 Replication Observability Framework
Apache-HBase commented on PR #4556: URL: https://github.com/apache/hbase/pull/4556#issuecomment-1275673135 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 22s | master passed | | +1 :green_heart: | compile | 1m 36s | master passed | | +1 :green_heart: | shadedjars | 3m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 39s | master passed | | -0 :warning: | patch | 7m 3s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 12s | the patch passed | | +1 :green_heart: | compile | 1m 35s | the patch passed | | +1 :green_heart: | javac | 1m 35s | the patch passed | | +1 :green_heart: | shadedjars | 3m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 42s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 404m 23s | root in the patch failed. | | | | 430m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/10/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4556 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux abd3438173c5 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / b656456e20 | | Default Java | Temurin-1.8.0_345-b01 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/10/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/10/testReport/ | | Max. process+thread count | 4231 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-hadoop-compat hbase-client hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4556/10/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-27405) Fix the replication hfile/log cleaner report that the replication table does not exist
[ https://issues.apache.org/jira/browse/HBASE-27405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27405. --- Fix Version/s: HBASE-27109 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch HBASE-27109. Thanks [~heliangjun] for contributing! > Fix the replication hfile/log cleaner report that the replication table does > not exist > -- > > Key: HBASE-27405 > URL: https://issues.apache.org/jira/browse/HBASE-27405 > Project: HBase > Issue Type: Sub-task > Components: master, Replication >Reporter: LiangJun He >Assignee: LiangJun He >Priority: Major > Fix For: HBASE-27109 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 merged pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache9 merged PR #4811: URL: https://github.com/apache/hbase/pull/4811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4811: HBASE-27405 Fix the replication hfile/log cleaner report that the replication table does not exist
Apache9 commented on PR #4811: URL: https://github.com/apache/hbase/pull/4811#issuecomment-1275666963 The failed UT should not be related. Let me merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4827: HBASE-27422: Support replication for hbase:acl
Apache9 commented on code in PR #4827:
URL: https://github.com/apache/hbase/pull/4827#discussion_r993050289
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/SystemTableWALEntryFilter.java:
##
@@ -17,16 +17,24 @@
*/
package org.apache.hadoop.hbase.replication;
+import org.apache.hadoop.hbase.security.access.PermissionStorage;
+import org.apache.hadoop.hbase.security.visibility.VisibilityConstants;
import org.apache.hadoop.hbase.wal.WAL.Entry;
import org.apache.yetus.audience.InterfaceAudience;
/**
- * Skips WAL edits for all System tables including hbase:meta.
+ * Skips WAL edits for all System tables including hbase:meta except hbase:acl.
*/
@InterfaceAudience.Private
public class SystemTableWALEntryFilter implements WALEntryFilter {
@Override
public Entry filter(Entry entry) {
+if (
+ entry.getKey().getTableName().equals(PermissionStorage.ACL_TABLE_NAME)
Review Comment:
It is a bit confusing to users that why only hbase:acl can be replicated but
other system tables are not? Please provide more information here, like how do
you plan to use this feature?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1275649661 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 42s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 15s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 4m 12s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | checkstyle | 0m 58s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | spotless | 0m 37s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 22s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 4m 9s | the patch passed | | +1 :green_heart: | cc | 4m 9s | the patch passed | | -0 :warning: | javac | 0m 14s | hbase-replication generated 2 new + 2 unchanged - 1 fixed = 4 total (was 3) | | -0 :warning: | javac | 0m 19s | hbase-procedure generated 1 new + 29 unchanged - 0 fixed = 30 total (was 29) | | -0 :warning: | checkstyle | 0m 28s | hbase-server: The patch generated 2 new + 8 unchanged - 0 fixed = 10 total (was 8) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 7m 55s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 1m 40s | the patch passed | | +1 :green_heart: | spotless | 0m 36s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 56s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. | | | | 44m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool xml | | uname | Linux 0a54b3bdaa6f 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 59dd1beaa3 | | Default Java | Temurin-1.8.0_345-b01 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-replication.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-procedure.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/6/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
