[jira] [Commented] (HBASE-27406) Make "/prometheus" endpoint accessible from HBase UI
[
https://issues.apache.org/jira/browse/HBASE-27406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621495#comment-17621495
]
Hudson commented on HBASE-27406:
Results for branch branch-2
[build #666 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/666/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/666/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/666/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/666/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/666/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make "/prometheus" endpoint accessible from HBase UI
>
>
> Key: HBASE-27406
> URL: https://issues.apache.org/jira/browse/HBASE-27406
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Affects Versions: 2.6.0, 3.0.0-alpha-3
>Reporter: Luca Kovacs
>Assignee: Luca Kovacs
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Prometheus metrics feature were added in HBASE-20904, but it's not in the UI
> yet, so the only option to use it is the URL.
> I would like to make a change in the web UI, so it can be accessed via a
> dropdown menu there and I would like to include the description option, so
> metrics can be viewed with or without description.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] comnetwork merged pull request #4839: HBASE-27433 DefaultMobStoreCompactor should delete MobStoreFile clean…
comnetwork merged PR #4839: URL: https://github.com/apache/hbase/pull/4839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] comnetwork opened a new pull request, #4839: HBASE-27433 DefaultMobStoreCompactor should delete MobStoreFile clean…
comnetwork opened a new pull request, #4839: URL: https://github.com/apache/hbase/pull/4839 …ly when compaction is failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-27439) metrics method removeHistogramMetrics trigger serious memory leak
[ https://issues.apache.org/jira/browse/HBASE-27439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tianliuhe resolved HBASE-27439. --- Resolution: Abandoned > metrics method removeHistogramMetrics trigger serious memory leak > - > > Key: HBASE-27439 > URL: https://issues.apache.org/jira/browse/HBASE-27439 > Project: HBase > Issue Type: Bug > Components: metrics, regionserver >Affects Versions: 2.4.14 > Environment: java linux >Reporter: tianliuhe >Priority: Major > > !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! > the method removeHistogramMetrics will cause the metricsMap leak! > because the put op in the map is the baseName but the remove is not , the > origin code add the histogramSuffixe follow the baseName when remove. > > !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (HBASE-27440) metrics method removeHistogramMetrics trigger serious memory leak
[ https://issues.apache.org/jira/browse/HBASE-27440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liuhe Tian reopened HBASE-27440: > metrics method removeHistogramMetrics trigger serious memory leak > - > > Key: HBASE-27440 > URL: https://issues.apache.org/jira/browse/HBASE-27440 > Project: HBase > Issue Type: Bug > Components: metrics, regionserver >Affects Versions: 2.4.15 >Reporter: Liuhe Tian >Priority: Major > > the method removeHistogramMetrics will cause the metricsMap leak! > because the put op in the map is the baseName but the remove is not , the > origin code add the histogramSuffixe follow the baseName when remove. > !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! > !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27440) metrics method removeHistogramMetrics trigger serious memory leak
[ https://issues.apache.org/jira/browse/HBASE-27440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liuhe Tian resolved HBASE-27440. Resolution: Abandoned > metrics method removeHistogramMetrics trigger serious memory leak > - > > Key: HBASE-27440 > URL: https://issues.apache.org/jira/browse/HBASE-27440 > Project: HBase > Issue Type: Bug > Components: metrics, regionserver >Affects Versions: 2.4.15 >Reporter: Liuhe Tian >Priority: Major > > the method removeHistogramMetrics will cause the metricsMap leak! > because the put op in the map is the baseName but the remove is not , the > origin code add the histogramSuffixe follow the baseName when remove. > !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! > !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27440) metrics method removeHistogramMetrics trigger serious memory leak
Liuhe Tian created HBASE-27440: -- Summary: metrics method removeHistogramMetrics trigger serious memory leak Key: HBASE-27440 URL: https://issues.apache.org/jira/browse/HBASE-27440 Project: HBase Issue Type: Bug Components: metrics, regionserver Affects Versions: 2.4.15 Reporter: Liuhe Tian the method removeHistogramMetrics will cause the metricsMap leak! because the put op in the map is the baseName but the remove is not , the origin code add the histogramSuffixe follow the baseName when remove. !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27439) metrics method removeHistogramMetrics trigger serious memory leak
[ https://issues.apache.org/jira/browse/HBASE-27439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tianliuhe updated HBASE-27439: -- Description: !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! the method removeHistogramMetrics will cause the metricsMap leak! because the put op in the map is the baseName but the remove is not , the origin code add the histogramSuffixe follow the baseName when remove. !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png! was: !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! the method removeHistogramMetrics will cause the metricsMap leak! because the put op in the map is the baseName but the remove is not , the origin code add the histogramSuffixe follow the baseName when remove. > metrics method removeHistogramMetrics trigger serious memory leak > - > > Key: HBASE-27439 > URL: https://issues.apache.org/jira/browse/HBASE-27439 > Project: HBase > Issue Type: Bug > Components: metrics, regionserver >Affects Versions: 2.4.14 > Environment: java linux >Reporter: tianliuhe >Priority: Major > > !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! > the method removeHistogramMetrics will cause the metricsMap leak! > because the put op in the map is the baseName but the remove is not , the > origin code add the histogramSuffixe follow the baseName when remove. > > !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27439) metrics method removeHistogramMetrics trigger serious memory leak
[ https://issues.apache.org/jira/browse/HBASE-27439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tianliuhe updated HBASE-27439: -- Priority: Major (was: Critical) > metrics method removeHistogramMetrics trigger serious memory leak > - > > Key: HBASE-27439 > URL: https://issues.apache.org/jira/browse/HBASE-27439 > Project: HBase > Issue Type: Bug > Components: metrics, regionserver >Affects Versions: 2.4.14 > Environment: java linux >Reporter: tianliuhe >Priority: Major > > !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! > the method removeHistogramMetrics will cause the metricsMap leak! > because the put op in the map is the baseName but the remove is not , the > origin code add the histogramSuffixe follow the baseName when remove. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27439) metrics method removeHistogramMetrics trigger serious memory leak
[ https://issues.apache.org/jira/browse/HBASE-27439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tianliuhe updated HBASE-27439: -- Affects Version/s: 2.4.14 > metrics method removeHistogramMetrics trigger serious memory leak > - > > Key: HBASE-27439 > URL: https://issues.apache.org/jira/browse/HBASE-27439 > Project: HBase > Issue Type: Bug > Components: metrics, regionserver >Affects Versions: 2.4.14 > Environment: java linux >Reporter: tianliuhe >Priority: Critical > > !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! > the method removeHistogramMetrics will cause the metricsMap leak! > because the put op in the map is the baseName but the remove is not , the > origin code add the histogramSuffixe follow the baseName when remove. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27439) metrics method removeHistogramMetrics trigger serious memory leak
tianliuhe created HBASE-27439: - Summary: metrics method removeHistogramMetrics trigger serious memory leak Key: HBASE-27439 URL: https://issues.apache.org/jira/browse/HBASE-27439 Project: HBase Issue Type: Bug Components: metrics, regionserver Environment: java linux Reporter: tianliuhe !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! the method removeHistogramMetrics will cause the metricsMap leak! because the put op in the map is the baseName but the remove is not , the origin code add the histogramSuffixe follow the baseName when remove. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27437) TestHeapSize is flaky
[ https://issues.apache.org/jira/browse/HBASE-27437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621405#comment-17621405 ] Michael Stack commented on HBASE-27437: --- Makes sense to me. > TestHeapSize is flaky > - > > Key: HBASE-27437 > URL: https://issues.apache.org/jira/browse/HBASE-27437 > Project: HBase > Issue Type: Bug > Components: test >Reporter: Duo Zhang >Priority: Major > > I believe it is just in memory computation, so it is weird that why it can be > flaky. > Need to dig more. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4836: HBASE-27434 Use as placeholder for maven version to make it easier t…
Apache-HBase commented on PR #4836: URL: https://github.com/apache/hbase/pull/4836#issuecomment-1286126121 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 25s | master passed | | +1 :green_heart: | compile | 1m 31s | master passed | | +1 :green_heart: | shadedjars | 4m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 8m 35s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 7s | the patch passed | | +1 :green_heart: | compile | 1m 29s | the patch passed | | +1 :green_heart: | javac | 1m 29s | the patch passed | | +1 :green_heart: | shadedjars | 4m 5s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 1m 22s | root generated 15 new + 69 unchanged - 15 fixed = 84 total (was 84) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 403m 50s | root in the patch passed. | | | | 445m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4836 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 871fdda3176c 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dffc8e0fbe | | Default Java | Temurin-1.8.0_345-b01 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/3/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/3/testReport/ | | Max. process+thread count | 4785 (vs. ulimit of 3) | | modules | C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase- shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4836: HBASE-27434 Use as placeholder for maven version to make it easier t…
Apache-HBase commented on PR #4836: URL: https://github.com/apache/hbase/pull/4836#issuecomment-1285975599 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 42s | master passed | | +1 :green_heart: | compile | 1m 53s | master passed | | +1 :green_heart: | shadedjars | 3m 51s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 11m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 31s | the patch passed | | +1 :green_heart: | compile | 1m 53s | the patch passed | | +1 :green_heart: | javac | 1m 53s | the patch passed | | +1 :green_heart: | shadedjars | 3m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 11m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 265m 38s | root in the patch passed. | | | | 314m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4836 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a7367171084e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dffc8e0fbe | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/3/testReport/ | | Max. process+thread count | 4695 (vs. ulimit of 3) | | modules | C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase- shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4837: HBASE-25983 javadoc generation fails on openjdk-11.0.11+9
Apache9 commented on code in PR #4837: URL: https://github.com/apache/hbase/pull/4837#discussion_r1000835689 ## pom.xml: ## @@ -780,7 +780,12 @@ comes in via hbase-thirdparty hbase-shaded-netty--> 3.10.5.Final -0.5.0 +0.13.0 + + 0.13.0 Review Comment: OK, will update the PR once yetus 0.14.1 is out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a diff in pull request #4837: HBASE-25983 javadoc generation fails on openjdk-11.0.11+9
ndimiduk commented on code in PR #4837: URL: https://github.com/apache/hbase/pull/4837#discussion_r1000824542 ## pom.xml: ## @@ -780,7 +780,12 @@ comes in via hbase-thirdparty hbase-shaded-netty--> 3.10.5.Final -0.5.0 +0.13.0 + + 0.13.0 Review Comment: Ah okay. Please add a comment to this effect, this is the last version of Yetus that we can use until we give up on JDK8. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27438) Make release scripts can generate CHANGES.md and RELEASENOTES.md for 3.x
Duo Zhang created HBASE-27438: - Summary: Make release scripts can generate CHANGES.md and RELEASENOTES.md for 3.x Key: HBASE-27438 URL: https://issues.apache.org/jira/browse/HBASE-27438 Project: HBase Issue Type: Improvement Components: community, scripts Reporter: Duo Zhang For 3.x, we do not have CHANGES.md and RELEASENOTES.md in source control, so we need to find a new way to generate it and commit it to dist.a.o. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (HBASE-27438) Make release scripts can generate CHANGES.md and RELEASENOTES.md for 3.x
[ https://issues.apache.org/jira/browse/HBASE-27438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27438 started by Duo Zhang. - > Make release scripts can generate CHANGES.md and RELEASENOTES.md for 3.x > > > Key: HBASE-27438 > URL: https://issues.apache.org/jira/browse/HBASE-27438 > Project: HBase > Issue Type: Improvement > Components: community, scripts >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > For 3.x, we do not have CHANGES.md and RELEASENOTES.md in source control, so > we need to find a new way to generate it and commit it to dist.a.o. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27438) Make release scripts can generate CHANGES.md and RELEASENOTES.md for 3.x
[ https://issues.apache.org/jira/browse/HBASE-27438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27438: - Assignee: Duo Zhang > Make release scripts can generate CHANGES.md and RELEASENOTES.md for 3.x > > > Key: HBASE-27438 > URL: https://issues.apache.org/jira/browse/HBASE-27438 > Project: HBase > Issue Type: Improvement > Components: community, scripts >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > For 3.x, we do not have CHANGES.md and RELEASENOTES.md in source control, so > we need to find a new way to generate it and commit it to dist.a.o. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4836: HBASE-27434 Use as placeholder for maven version to make it easier t…
Apache-HBase commented on PR #4836: URL: https://github.com/apache/hbase/pull/4836#issuecomment-1285600472 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 7s | master passed | | +1 :green_heart: | compile | 6m 8s | master passed | | +1 :green_heart: | checkstyle | 0m 57s | master passed | | +1 :green_heart: | spotless | 0m 35s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 6s | the patch passed | | +1 :green_heart: | compile | 6m 7s | the patch passed | | +1 :green_heart: | javac | 6m 7s | the patch passed | | +1 :green_heart: | checkstyle | 0m 58s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 32s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 7m 55s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 5m 37s | The patch does not generate ASF License warnings. | | | | 44m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4836 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile checkstyle | | uname | Linux 146a0cedf74d 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dffc8e0fbe | | Default Java | Temurin-1.8.0_345-b01 | | Max. process+thread count | 140 (vs. ulimit of 3) | | modules | C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase- shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27437) TestHeapSize is flaky
[
https://issues.apache.org/jira/browse/HBASE-27437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621116#comment-17621116
]
Duo Zhang commented on HBASE-27437:
---
OK, the code is for testing performance...
{noformat}
@Test
public void testAutoCalcFixedOverHead() {
Class[] classList = new Class[] { HFileContext.class, HRegion.class,
BlockCacheKey.class,
HFileBlock.class, HStore.class, LruBlockCache.class, StoreContext.class };
for (Class cl : classList) {
// do estimate in advance to ensure class is loaded
ClassSize.estimateBase(cl, false);
long startTime = EnvironmentEdgeManager.currentTime();
ClassSize.estimateBase(cl, false);
long endTime = EnvironmentEdgeManager.currentTime();
assertTrue(endTime - startTime < 5);
}
}
{noformat}
It is introduced in HBASE-24659, which is for making sure that the calculation
overhead is small. But if the machine itself is small, it is possible that we
fail since the assertion is a bit strict, especially if there is a gc...
[~niuyulin] [~stack] WDYT? Can we relax the threshold?
Thanks.
> TestHeapSize is flaky
> -
>
> Key: HBASE-27437
> URL: https://issues.apache.org/jira/browse/HBASE-27437
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Priority: Major
>
> I believe it is just in memory computation, so it is weird that why it can be
> flaky.
> Need to dig more.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (HBASE-27167) HBase CI: Add to existing s390x build nodes
[
https://issues.apache.org/jira/browse/HBASE-27167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620565#comment-17620565
]
Jonathan Albrecht edited comment on HBASE-27167 at 10/20/22 1:30 PM:
-
[~zhangduo], there is a reply on
https://issues.apache.org/jira/browse/INFRA-23791 that the s390x nodes should
be available on all controllers by just using the 's390x' label. I don't know
how to check that though.
For the nightly build script, I've been looking at the build logs for arm64
there are two things on s390x that I think will be different based on my local
testing:
OpenJDK 8 on s390x doesn't have a JIT compiler so the build (especially tests)
runs very slowly and there are time outs. Could the s390x nightly build use JDK
11 instead?
The recent brotli4j and aircompressor dependencies don't have s390x support
yet. Even though aircompressor is pure java, it only supports little-endian
right now. The tests run successfully if those modules are excluded, ie.:
{{mvn test -pl
'\!hbase-compression-aircompressor,\!:hbase-compression-brotli'}}
Could the nightly build exclude those modules on s390x?
was (Author: jonathan.albrecht):
[~zhangduo], there is a reply on
https://issues.apache.org/jira/browse/INFRA-23791 that the s390x nodes should
be available on all controllers by just using the 's390x' label. I don't know
how to check that though.
For the nightly build script, I've been looking at the build logs for arm64
there are two things on s390x that I think will be different based on my local
testing:
OpenJDK 8 on s390x doesn't have a JIT compiler so the build (especially tests)
runs very slowly and there are time outs. Could the s390x nightly build use JDK
11 instead?
The recent brotli4j and aircompressor dependencies don't have s390x support
yet. Even though aircompressor is pure java, it only supports little-endian
right now. The tests run successfully if those modules are excluded, ie.:
{{mvn test -pl '!hbase-compression-aircompressor,!:hbase-compression-brotli'}}
Could the nightly build exclude those modules on s390x?
> HBase CI: Add to existing s390x build nodes
> ---
>
> Key: HBASE-27167
> URL: https://issues.apache.org/jira/browse/HBASE-27167
> Project: HBase
> Issue Type: Improvement
> Components: build, jenkins
>Reporter: Jonathan Albrecht
>Priority: Major
>
> Since https://issues.apache.org/jira/browse/INFRA-21433, there are four s390x
> Jenkins build nodes available. Could the HBase CI be extended to build on
> s390x as well?
> There is an old issue open about adding s390x support to the HBase CI but it
> has not received any update in quite some time.
> https://issues.apache.org/jira/browse/HBASE-25192. There was some interest in
> starting by adding s390x to the nightly builds. Would that still be the best
> way to start?
> Let me know if there are any questions. I'm happy to help in any way I can.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27167) HBase CI: Add to existing s390x build nodes
[ https://issues.apache.org/jira/browse/HBASE-27167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1762#comment-1762 ] Duo Zhang commented on HBASE-27167: --- Oh, let me be more specific. I do not mean you should fix the compression algorithm, just use Assert.assume, or checking the arch to determine the compression algos list. Thanks. > HBase CI: Add to existing s390x build nodes > --- > > Key: HBASE-27167 > URL: https://issues.apache.org/jira/browse/HBASE-27167 > Project: HBase > Issue Type: Improvement > Components: build, jenkins >Reporter: Jonathan Albrecht >Priority: Major > > Since https://issues.apache.org/jira/browse/INFRA-21433, there are four s390x > Jenkins build nodes available. Could the HBase CI be extended to build on > s390x as well? > There is an old issue open about adding s390x support to the HBase CI but it > has not received any update in quite some time. > https://issues.apache.org/jira/browse/HBASE-25192. There was some interest in > starting by adding s390x to the nightly builds. Would that still be the best > way to start? > Let me know if there are any questions. I'm happy to help in any way I can. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27167) HBase CI: Add to existing s390x build nodes
[ https://issues.apache.org/jira/browse/HBASE-27167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621109#comment-17621109 ] Duo Zhang commented on HBASE-27167: --- And on the unsupported compression algos, I suggest you guys submit PRs to fix them in code, instead of doing some magics in the build scripts :) > HBase CI: Add to existing s390x build nodes > --- > > Key: HBASE-27167 > URL: https://issues.apache.org/jira/browse/HBASE-27167 > Project: HBase > Issue Type: Improvement > Components: build, jenkins >Reporter: Jonathan Albrecht >Priority: Major > > Since https://issues.apache.org/jira/browse/INFRA-21433, there are four s390x > Jenkins build nodes available. Could the HBase CI be extended to build on > s390x as well? > There is an old issue open about adding s390x support to the HBase CI but it > has not received any update in quite some time. > https://issues.apache.org/jira/browse/HBASE-25192. There was some interest in > starting by adding s390x to the nightly builds. Would that still be the best > way to start? > Let me know if there are any questions. I'm happy to help in any way I can. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27167) HBase CI: Add to existing s390x build nodes
[
https://issues.apache.org/jira/browse/HBASE-27167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621108#comment-17621108
]
Duo Zhang commented on HBASE-27167:
---
This is the script for running HBase-Nightly-ARM
{noformat}
#!/bin/bash
#Manually installed JAVA and MAVEN in ARM machine.
export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-arm64
export MAVEN_HOME=/home/jenkins/tools/maven/latest3/
export PATH=${MAVEN_HOME}/bin:${JAVA_HOME}/bin:${PATH}
export LD_LIBRARY_PATH=/home/jenkins/test-deps/protobuf/2.5.0/build-bin/lib/
export MAVEN_OPTS="-Dstyle.color=never"
${MAVEN_HOME}/bin/mvn -Paarch64 clean install -DskipTests
exclude_tests=$(wget
https://builds.apache.org/job/HBASE-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/excludes
-q -O -)
${MAVEN_HOME}/bin/mvn clean test -P runAllTests -Dmaven.javadoc.skip=true \
-Dcheckstyle.skip=true -Dfindbugs.skip=true -Dspotbugs.skip=true \
-Dtest.exclude.pattern=$exclude_tests -fn
{noformat}
So where is the jdk11 and maven install path on the s390x machine? Thanks.
> HBase CI: Add to existing s390x build nodes
> ---
>
> Key: HBASE-27167
> URL: https://issues.apache.org/jira/browse/HBASE-27167
> Project: HBase
> Issue Type: Improvement
> Components: build, jenkins
>Reporter: Jonathan Albrecht
>Priority: Major
>
> Since https://issues.apache.org/jira/browse/INFRA-21433, there are four s390x
> Jenkins build nodes available. Could the HBase CI be extended to build on
> s390x as well?
> There is an old issue open about adding s390x support to the HBase CI but it
> has not received any update in quite some time.
> https://issues.apache.org/jira/browse/HBASE-25192. There was some interest in
> starting by adding s390x to the nightly builds. Would that still be the best
> way to start?
> Let me know if there are any questions. I'm happy to help in any way I can.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (HBASE-27437) TestHeapSize is flaky
Duo Zhang created HBASE-27437: - Summary: TestHeapSize is flaky Key: HBASE-27437 URL: https://issues.apache.org/jira/browse/HBASE-27437 Project: HBase Issue Type: Bug Components: test Reporter: Duo Zhang I believe it is just in memory computation, so it is weird that why it can be flaky. Need to dig more. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27167) HBase CI: Add to existing s390x build nodes
[ https://issues.apache.org/jira/browse/HBASE-27167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621102#comment-17621102 ] Duo Zhang commented on HBASE-27167: --- Let me have a try. > HBase CI: Add to existing s390x build nodes > --- > > Key: HBASE-27167 > URL: https://issues.apache.org/jira/browse/HBASE-27167 > Project: HBase > Issue Type: Improvement > Components: build, jenkins >Reporter: Jonathan Albrecht >Priority: Major > > Since https://issues.apache.org/jira/browse/INFRA-21433, there are four s390x > Jenkins build nodes available. Could the HBase CI be extended to build on > s390x as well? > There is an old issue open about adding s390x support to the HBase CI but it > has not received any update in quite some time. > https://issues.apache.org/jira/browse/HBASE-25192. There was some interest in > starting by adding s390x to the nightly builds. Would that still be the best > way to start? > Let me know if there are any questions. I'm happy to help in any way I can. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4838: fix table HistogramMetrics leak in table metrics map
Apache-HBase commented on PR #4838: URL: https://github.com/apache/hbase/pull/4838#issuecomment-1285502397 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 1s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 20s | master passed | | +1 :green_heart: | compile | 2m 34s | master passed | | +1 :green_heart: | checkstyle | 0m 41s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 39s | root in the patch failed. | | -1 :x: | compile | 0m 7s | hbase-hadoop-compat in the patch failed. | | -1 :x: | compile | 1m 16s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 7s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javac | 1m 16s | hbase-server in the patch failed. | | -0 :warning: | checkstyle | 0m 7s | hbase-hadoop-compat: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | -0 :warning: | checkstyle | 0m 28s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 0m 42s | The patch causes 10 errors with Hadoop v3.2.4. | | -1 :x: | hadoopcheck | 1m 25s | The patch causes 10 errors with Hadoop v3.3.4. | | -1 :x: | spotless | 0m 12s | patch has 24 errors when running spotless:check, run spotless:apply to fix. | | -1 :x: | spotbugs | 0m 8s | hbase-hadoop-compat in the patch failed. | | -1 :x: | spotbugs | 0m 30s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 21m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4838 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 4e6287f2be66 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dffc8e0fbe | | Default Java | Temurin-1.8.0_345-b01 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-compile-hbase-hadoop-compat.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-compile-hbase-hadoop-compat.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-javac-3.2.4.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-javac-3.3.4.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-general-check/output/patch-spotless.txt | | spotbugs |
[GitHub] [hbase] Apache-HBase commented on pull request #4838: fix table HistogramMetrics leak in table metrics map
Apache-HBase commented on PR #4838: URL: https://github.com/apache/hbase/pull/4838#issuecomment-1285496258 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 48s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 4s | master passed | | +1 :green_heart: | compile | 0m 47s | master passed | | +1 :green_heart: | shadedjars | 4m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 31s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 37s | root in the patch failed. | | -1 :x: | compile | 0m 8s | hbase-hadoop-compat in the patch failed. | | -1 :x: | compile | 0m 34s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 8s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javac | 0m 34s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 1m 7s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 7s | hbase-hadoop-compat in the patch failed. | | -1 :x: | unit | 0m 35s | hbase-server in the patch failed. | | | | 16m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4838 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6346cbfbfc72 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dffc8e0fbe | | Default Java | Temurin-1.8.0_345-b01 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-hadoop-compat.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/testReport/ | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4838: fix table HistogramMetrics leak in table metrics map
Apache-HBase commented on PR #4838: URL: https://github.com/apache/hbase/pull/4838#issuecomment-1285494140 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 35s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 4m 6s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 45s | root in the patch failed. | | -1 :x: | compile | 0m 8s | hbase-hadoop-compat in the patch failed. | | -1 :x: | compile | 0m 41s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 8s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javac | 0m 41s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 1m 13s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 8s | hbase-hadoop-compat in the patch failed. | | -1 :x: | unit | 0m 42s | hbase-server in the patch failed. | | | | 14m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4838 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2e86cd05783f 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dffc8e0fbe | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-hadoop-compat.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/testReport/ | | Max. process+thread count | 77 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4836: HBASE-27434 Use as placeholder for maven version to make it easier t…
Apache-HBase commented on PR #4836: URL: https://github.com/apache/hbase/pull/4836#issuecomment-1285467770 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 19s | master passed | | -1 :x: | compile | 0m 55s | root in master failed. | | +1 :green_heart: | checkstyle | 0m 58s | master passed | | +1 :green_heart: | spotless | 0m 38s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 8s | the patch passed | | +1 :green_heart: | compile | 6m 4s | the patch passed | | -0 :warning: | javac | 6m 4s | root generated 703 new + 0 unchanged - 0 fixed = 703 total (was 0) | | +1 :green_heart: | checkstyle | 0m 56s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 31s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 7m 54s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 36s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 5m 30s | The patch does not generate ASF License warnings. | | | | 38m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4836 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile checkstyle | | uname | Linux f9607d1774ac 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / dffc8e0fbe | | Default Java | Temurin-1.8.0_345-b01 | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/2/artifact/yetus-general-check/output/branch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 139 (vs. ulimit of 3) | | modules | C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-compression hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase- shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4836/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-25192) s390x support for HBase CI
[ https://issues.apache.org/jira/browse/HBASE-25192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditi Jadhav resolved HBASE-25192. -- Resolution: Duplicate > s390x support for HBase CI > -- > > Key: HBASE-25192 > URL: https://issues.apache.org/jira/browse/HBASE-25192 > Project: HBase > Issue Type: Improvement >Reporter: Aditi Jadhav >Priority: Major > > Hi All, > As I understand that currently CI available for HBase ( to validate any code > updates ) is : https://ci-hadoop.apache.org/job/HBase/ and as can be seen > most of the deployment here is on amd64 and ppc64le. > Wanted to know your views/comments/suggestions for extending CI of HBase on > s390x . > 1) If the community will be willing to add - vm's/slaves ( s390x based ) to > their current above CI. > 2) Use an externally hosted jenkins CI - for running HBase build on s390x and > link the results of the build to the above CI. > Please let me know your thoughts. > Regards, > Aditi -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-25192) s390x support for HBase CI
[ https://issues.apache.org/jira/browse/HBASE-25192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621046#comment-17621046 ] Aditi Jadhav commented on HBASE-25192: -- Opened New issue for tracking the same https://issues.apache.org/jira/browse/HBASE-27167 Thus, closing this one. > s390x support for HBase CI > -- > > Key: HBASE-25192 > URL: https://issues.apache.org/jira/browse/HBASE-25192 > Project: HBase > Issue Type: Improvement >Reporter: Aditi Jadhav >Priority: Major > > Hi All, > As I understand that currently CI available for HBase ( to validate any code > updates ) is : https://ci-hadoop.apache.org/job/HBase/ and as can be seen > most of the deployment here is on amd64 and ppc64le. > Wanted to know your views/comments/suggestions for extending CI of HBase on > s390x . > 1) If the community will be willing to add - vm's/slaves ( s390x based ) to > their current above CI. > 2) Use an externally hosted jenkins CI - for running HBase build on s390x and > link the results of the build to the above CI. > Please let me know your thoughts. > Regards, > Aditi -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 commented on pull request #4716: HBASE-27312 Update create-release to work with maven-gpg-plugin-3.0.1 and gnupg >= 2.1.x
Apache9 commented on PR #4716: URL: https://github.com/apache/hbase/pull/4716#issuecomment-1285376347 > I've not attempted release candidates anytime recently, so the status here is not changed. There's a couple reviewer questions about the wisdom of exposing the socket with elevated privileges. The changes here that allowed me to proceed may not make sense for other environments. For example, if someone is building an RC on a 3PC, they may not want the full privileged socket exposed to the remote environment. However, I don't know if any of our release managers are building on "untrusted" hardware. I think we could introduce a flag to control the behavior? i.e, mounting agent-socket or agent-extra-socket, and we could still make the default to mount agent-extra-socket, which is the same with the current behavior. Anyway, if this is not to be landed in the new future, I will try to land other improvements first. Thanks @ndimiduk ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4837: HBASE-25983 javadoc generation fails on openjdk-11.0.11+9
Apache9 commented on code in PR #4837: URL: https://github.com/apache/hbase/pull/4837#discussion_r1000508822 ## pom.xml: ## @@ -780,7 +780,12 @@ comes in via hbase-thirdparty hbase-shaded-netty--> 3.10.5.Final -0.5.0 +0.13.0 + + 0.13.0 Review Comment: 0.14.0 is for JDK11 only, it can not be used together with JDK8. See here https://github.com/apache/yetus/releases the audience-annotations section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27359) Publish binaries and maven artifacts for both hadoop2 and hadoop3
[
https://issues.apache.org/jira/browse/HBASE-27359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621034#comment-17621034
]
Duo Zhang commented on HBASE-27359:
---
{quote}
Maybe instead we use versions:set-property to update the revision value.
{quote}
Yes.
{quote}
We also must upgrade our maven version to at least 3.5.0
{quote}
This is a good point. Let me check the enforcer rule. Maven 3.,5.0 is released
at 2017, which is five years ago, I think it is OK to move up to 3.5.0(if we
have not done this yet).
{quote}
It is worth introducing mvnw while we're at it?
{quote}
This could be a good add-on. Can be a follow on issue.
Thanks [~ndimiduk] for taking a look at this!
> Publish binaries and maven artifacts for both hadoop2 and hadoop3
> -
>
> Key: HBASE-27359
> URL: https://issues.apache.org/jira/browse/HBASE-27359
> Project: HBase
> Issue Type: Improvement
> Components: build, community, pom, scripts
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 2.5.2, 2.4.16
>
>
> As per the discussion in this thread
> https://lists.apache.org/thread/y05gspk4mnxsz6nk7hc5ots8wt50366b
> And this is possible after we land HBASE-27340.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (HBASE-27406) Make "/prometheus" endpoint accessible from HBase UI
[ https://issues.apache.org/jira/browse/HBASE-27406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros resolved HBASE-27406. - Resolution: Fixed > Make "/prometheus" endpoint accessible from HBase UI > > > Key: HBASE-27406 > URL: https://issues.apache.org/jira/browse/HBASE-27406 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 2.6.0, 3.0.0-alpha-3 >Reporter: Luca Kovacs >Assignee: Luca Kovacs >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4 > > > Prometheus metrics feature were added in HBASE-20904, but it's not in the UI > yet, so the only option to use it is the URL. > I would like to make a change in the web UI, so it can be accessed via a > dropdown menu there and I would like to include the description option, so > metrics can be viewed with or without description. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27406) Make "/prometheus" endpoint accessible from HBase UI
[ https://issues.apache.org/jira/browse/HBASE-27406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros updated HBASE-27406: Fix Version/s: 2.6.0 3.0.0-alpha-4 > Make "/prometheus" endpoint accessible from HBase UI > > > Key: HBASE-27406 > URL: https://issues.apache.org/jira/browse/HBASE-27406 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 2.6.0, 3.0.0-alpha-3 >Reporter: Luca Kovacs >Assignee: Luca Kovacs >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4 > > > Prometheus metrics feature were added in HBASE-20904, but it's not in the UI > yet, so the only option to use it is the URL. > I would like to make a change in the web UI, so it can be accessed via a > dropdown menu there and I would like to include the description option, so > metrics can be viewed with or without description. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] meszibalu merged pull request #4833: HBASE-27406 Make "/prometheus" endpoint accessible from HBase UI
meszibalu merged PR #4833: URL: https://github.com/apache/hbase/pull/4833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27359) Publish binaries and maven artifacts for both hadoop2 and hadoop3
[
https://issues.apache.org/jira/browse/HBASE-27359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620986#comment-17620986
]
Nick Dimiduk commented on HBASE-27359:
--
So if we make use of {{revision}}, we no longer use {{versions:set}} to update
the project version? Maybe instead we use {{versions:set-property}} to update
the {{revision}} value.
We also must upgrade our maven version to at least 3.5.0. It is worth
introducing mvnw while we're at it?
> Publish binaries and maven artifacts for both hadoop2 and hadoop3
> -
>
> Key: HBASE-27359
> URL: https://issues.apache.org/jira/browse/HBASE-27359
> Project: HBase
> Issue Type: Improvement
> Components: build, community, pom, scripts
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 2.5.2, 2.4.16
>
>
> As per the discussion in this thread
> https://lists.apache.org/thread/y05gspk4mnxsz6nk7hc5ots8wt50366b
> And this is possible after we land HBASE-27340.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4838: fix table HistogramMetrics leak in table metrics map
Apache-HBase commented on PR #4838: URL: https://github.com/apache/hbase/pull/4838#issuecomment-1285288221 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 48s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 4m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 46s | root in the patch failed. | | -1 :x: | compile | 0m 8s | hbase-hadoop-compat in the patch failed. | | -1 :x: | compile | 0m 42s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 8s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javac | 0m 42s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 1m 12s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 8s | hbase-hadoop-compat in the patch failed. | | -1 :x: | unit | 0m 43s | hbase-server in the patch failed. | | | | 18m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4838 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux eb433a063af7 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5cacece790 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-hadoop-compat.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/testReport/ | | Max. process+thread count | 77 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a diff in pull request #4837: HBASE-25983 javadoc generation fails on openjdk-11.0.11+9
ndimiduk commented on code in PR #4837: URL: https://github.com/apache/hbase/pull/4837#discussion_r1000435661 ## pom.xml: ## @@ -780,7 +780,12 @@ comes in via hbase-thirdparty hbase-shaded-netty--> 3.10.5.Final -0.5.0 +0.13.0 + + 0.13.0 Review Comment: Why keep an older version here? Is YETUS-1197 incompatible with JDK8? If so, why not 0.14.0, the last release before YETUS-1197? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a diff in pull request #4837: HBASE-25983 javadoc generation fails on openjdk-11.0.11+9
ndimiduk commented on code in PR #4837: URL: https://github.com/apache/hbase/pull/4837#discussion_r1000435661 ## pom.xml: ## @@ -780,7 +780,12 @@ comes in via hbase-thirdparty hbase-shaded-netty--> 3.10.5.Final -0.5.0 +0.13.0 + + 0.13.0 Review Comment: this should be 0.14.1, to use the RC repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a diff in pull request #4837: HBASE-25983 javadoc generation fails on openjdk-11.0.11+9
ndimiduk commented on code in PR #4837: URL: https://github.com/apache/hbase/pull/4837#discussion_r1000435661 ## pom.xml: ## @@ -780,7 +780,12 @@ comes in via hbase-thirdparty hbase-shaded-netty--> 3.10.5.Final -0.5.0 +0.13.0 + + 0.13.0 Review Comment: Why keep the old version here? Is YETUS-1197 incompatible with JDK8? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4838: fix table HistogramMetrics leak in table metrics map
Apache-HBase commented on PR #4838: URL: https://github.com/apache/hbase/pull/4838#issuecomment-1285285641 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 20s | master passed | | +1 :green_heart: | compile | 2m 33s | master passed | | +1 :green_heart: | checkstyle | 0m 35s | master passed | | +1 :green_heart: | spotless | 0m 39s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 36s | root in the patch failed. | | -1 :x: | compile | 0m 6s | hbase-hadoop-compat in the patch failed. | | -1 :x: | compile | 1m 14s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 6s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javac | 1m 14s | hbase-server in the patch failed. | | -0 :warning: | checkstyle | 0m 6s | hbase-hadoop-compat: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | -0 :warning: | checkstyle | 0m 25s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 0m 37s | The patch causes 10 errors with Hadoop v3.2.4. | | -1 :x: | hadoopcheck | 1m 15s | The patch causes 10 errors with Hadoop v3.3.4. | | -1 :x: | spotless | 0m 10s | patch has 24 errors when running spotless:check, run spotless:apply to fix. | | -1 :x: | spotbugs | 0m 6s | hbase-hadoop-compat in the patch failed. | | -1 :x: | spotbugs | 0m 27s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 15m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4838 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux f791aa66d8d4 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5cacece790 | | Default Java | Temurin-1.8.0_345-b01 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-compile-hbase-hadoop-compat.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-compile-hbase-hadoop-compat.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-javac-3.3.4.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-general-check/output/patch-spotless.txt | | spotbugs |
[GitHub] [hbase] Apache-HBase commented on pull request #4838: fix table HistogramMetrics leak in table metrics map
Apache-HBase commented on PR #4838: URL: https://github.com/apache/hbase/pull/4838#issuecomment-1285283588 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 21s | master passed | | +1 :green_heart: | compile | 0m 46s | master passed | | +1 :green_heart: | shadedjars | 4m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 36s | root in the patch failed. | | -1 :x: | compile | 0m 7s | hbase-hadoop-compat in the patch failed. | | -1 :x: | compile | 0m 36s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 7s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javac | 0m 36s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 1m 7s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 33s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 8s | hbase-hadoop-compat in the patch failed. | | -1 :x: | unit | 0m 35s | hbase-server in the patch failed. | | | | 13m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4838 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 07f09a701f02 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 5cacece790 | | Default Java | Temurin-1.8.0_345-b01 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-hadoop-compat.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-hadoop-compat.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/testReport/ | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] comnetwork merged pull request #4834: HBASE-27433 DefaultMobStoreCompactor should delete MobStoreFile clean…
comnetwork merged PR #4834: URL: https://github.com/apache/hbase/pull/4834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #4716: HBASE-27312 Update create-release to work with maven-gpg-plugin-3.0.1 and gnupg >= 2.1.x
ndimiduk commented on PR #4716: URL: https://github.com/apache/hbase/pull/4716#issuecomment-1285277185 I've not attempted release candidates anytime recently, so the status here is not changed. There's a couple reviewer questions about the wisdom of exposing the socket with elevated privileges. The changes here that allowed me to proceed may not make sense for other environments. For example, if someone is building an RC on a 3PC, they may not want the full privileged socket exposed to the remote environment. However, I don't know if any of our release managers are building on "untrusted" hardware. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] tianliuliu opened a new pull request, #4838: fix table HistogramMetrics leak in table metrics map
tianliuliu opened a new pull request, #4838: URL: https://github.com/apache/hbase/pull/4838  the method removeHistogramMetrics will cause the metricsMap leak! because the put op in the map is the baseName but the remove is not , the origin code add the histogramSuffixe follow the baseName when remove.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
