[GitHub] [hbase] Apache-HBase commented on pull request #4838: HBASE-27440 fix table HistogramMetrics leak in table metrics map
Apache-HBase commented on PR #4838: URL: https://github.com/apache/hbase/pull/4838#issuecomment-1288511668 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 8s | master passed | | +1 :green_heart: | compile | 2m 32s | master passed | | +1 :green_heart: | checkstyle | 0m 40s | master passed | | +1 :green_heart: | spotless | 0m 39s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 37s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 9s | the patch passed | | +1 :green_heart: | compile | 2m 34s | the patch passed | | +1 :green_heart: | javac | 2m 34s | the patch passed | | +1 :green_heart: | checkstyle | 0m 39s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 51s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 30m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4838 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 7c24cc426363 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2fc879e863 | | Default Java | Temurin-1.8.0_345-b01 | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4810: HBASE-27217 Revisit the DumpReplicationQueues tool
Apache9 commented on code in PR #4810:
URL: https://github.com/apache/hbase/pull/4810#discussion_r1003129402
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/DumpReplicationQueues.java:
##
@@ -294,80 +321,117 @@ public String
dumpPeersState(List peers) throws Exce
return sb.toString();
}
- public String dumpQueues(ZKWatcher zkw, Set peerIds, boolean hdfs)
throws Exception {
-ReplicationQueueStorage queueStorage;
+ public String dumpQueues(Connection connection, Set peerIds, boolean
hdfs)
+throws Exception {
StringBuilder sb = new StringBuilder();
+ReplicationQueueStorage queueStorage =
+ ReplicationStorageFactory.getReplicationQueueStorage(connection,
getConf());
+
+Set liveRegionServers =
+
connection.getAdmin().getClusterMetrics().getLiveServerMetrics().keySet();
+
+List regionServers = queueStorage.listAllReplicators();
+if (regionServers == null || regionServers.isEmpty()) {
+ return sb.toString();
+}
+for (ServerName regionServer : regionServers) {
+ List queueIds =
queueStorage.listAllQueueIds(regionServer);
-// queueStorage =
ReplicationStorageFactory.getReplicationQueueStorage(zkw, getConf());
-// Set liveRegionServers = ZKUtil.listChildrenNoWatch(zkw,
-// zkw.getZNodePaths().rsZNode)
-// .stream().map(ServerName::parseServerName).collect(Collectors.toSet());
-//
-// Loops each peer on each RS and dumps the queues
-// List regionservers = queueStorage.getListOfReplicators();
-// if (regionservers == null || regionservers.isEmpty()) {
-// return sb.toString();
-// }
-// for (ServerName regionserver : regionservers) {
-// List queueIds = queueStorage.getAllQueues(regionserver);
-// if (!liveRegionServers.contains(regionserver)) {
-// deadRegionServers.add(regionserver.getServerName());
-// }
-// for (String queueId : queueIds) {
-// ReplicationQueueInfo queueInfo = new ReplicationQueueInfo(queueId);
-// List wals = queueStorage.getWALsInQueue(regionserver, queueId);
-// Collections.sort(wals);
-// if (!peerIds.contains(queueInfo.getPeerId())) {
-// deletedQueues.add(regionserver + "/" + queueId);
-// sb.append(formatQueue(regionserver, queueStorage, queueInfo, queueId,
wals, true, hdfs));
-// } else {
-// sb.append(formatQueue(regionserver, queueStorage, queueInfo, queueId,
wals, false, hdfs));
-// }
-// }
-// }
+ if (!liveRegionServers.contains(regionServer)) {
+deadRegionServers.add(regionServer.getServerName());
+ }
+ for (ReplicationQueueId queueId : queueIds) {
+// wals
+List tmpWals = AbstractFSWALProvider
+ .getWALFiles(connection.getConfiguration(),
+URLEncoder.encode(queueId.getServerWALsBelongTo().toString(),
+ StandardCharsets.UTF_8.name()))
+ .stream().map(Path::toString).collect(Collectors.toList());
+
+// old wals
+tmpWals.addAll(AbstractFSWALProvider
+ .getArchivedWALFiles(connection.getConfiguration(),
queueId.getServerWALsBelongTo(),
+URLEncoder.encode(queueId.getServerWALsBelongTo().toString(),
+ StandardCharsets.UTF_8.name()))
+ .stream().map(Path::toString).collect(Collectors.toList()));
+
+Map offsets =
queueStorage.getOffsets(queueId);
+// filter out the wal files that should replicate
+List wals = new ArrayList<>();
+for (Map.Entry entry :
offsets.entrySet()) {
+ ReplicationGroupOffset offset = entry.getValue();
+ for (String wal : tmpWals) {
+if (ReplicationOffsetUtil.shouldReplicate(offset, wal)) {
+ wals.add(wal);
+}
+ }
+}
+
+Collections.sort(wals);
+if (!peerIds.contains(queueId.getPeerId())) {
+ deletedQueues.add(regionServer + "/" + queueId);
+ sb.append(formatQueue(regionServer, offsets, wals, queueId, true,
hdfs));
+} else {
+ sb.append(formatQueue(regionServer, offsets, wals, queueId, false,
hdfs));
+}
+ }
+}
return sb.toString();
}
- private String formatQueue(ServerName regionserver, ReplicationQueueStorage
queueStorage,
-ReplicationQueueInfo queueInfo, String queueId, List wals, boolean
isDeleted,
-boolean hdfs) throws Exception {
+ private String formatQueue(ServerName regionServer, Map offsets,
+List wals, ReplicationQueueId queueId, boolean isDeleted, boolean
hdfs)
+throws Exception {
StringBuilder sb = new StringBuilder();
-List deadServers;
-
-sb.append("Dumping replication queue info for RegionServer: [" +
regionserver + "]" + "\n");
-sb.append("Queue znode: " + queueId + "\n");
-sb.append("PeerID: " + queueInfo.getPeerId() + "\n");
-sb.append("Recovered: " + queueInfo.isQueueRecovered() + "\n");
-deadServers = queueInfo.getDeadRegionServer
[GitHub] [hbase] Apache-HBase commented on pull request #4838: HBASE-27440 fix table HistogramMetrics leak in table metrics map
Apache-HBase commented on PR #4838: URL: https://github.com/apache/hbase/pull/4838#issuecomment-1288791396 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 7s | master passed | | +1 :green_heart: | compile | 0m 47s | master passed | | +1 :green_heart: | shadedjars | 4m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 11s | the patch passed | | +1 :green_heart: | compile | 0m 46s | the patch passed | | +1 :green_heart: | javac | 0m 46s | the patch passed | | +1 :green_heart: | shadedjars | 4m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 30s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 210m 13s | hbase-server in the patch passed. | | | | 228m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4838 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 28b222c72a44 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2fc879e863 | | Default Java | Temurin-1.8.0_345-b01 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/testReport/ | | Max. process+thread count | 2703 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-27442) Change the way of bumping version in release scripts
[ https://issues.apache.org/jira/browse/HBASE-27442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-27442: Assignee: Nick Dimiduk > Change the way of bumping version in release scripts > > > Key: HBASE-27442 > URL: https://issues.apache.org/jira/browse/HBASE-27442 > Project: HBase > Issue Type: Task > Components: community, scripts >Reporter: Duo Zhang >Assignee: Nick Dimiduk >Priority: Major > > After HBASE-27434, we can not use 'mvn versions:set' to change the versions, > as all the versions are filled with the $revision placeholder. We need to use > 'mvn versions:set-property' instead. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 commented on a diff in pull request #4808: HBASE-27218 Support rolling upgrading
Apache9 commented on code in PR #4808: URL: https://github.com/apache/hbase/pull/4808#discussion_r1003148397 ## hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueueStorage.java: ## @@ -184,4 +185,12 @@ void removeLastSequenceIds(String peerId, List encodedRegionNames) * @return Whether the replication queue table exists */ boolean hasData() throws ReplicationException; + + // the below 3 methods are used for migrating + void batchUpdate(ServerName serverName, List datas) +throws ReplicationException; + + void batchUpdate(List lastPushedSeqIds) throws ReplicationException; + + void batchUpdate(String peerId, List hfileRefs) throws ReplicationException; Review Comment: OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4838: HBASE-27440 fix table HistogramMetrics leak in table metrics map
Apache-HBase commented on PR #4838: URL: https://github.com/apache/hbase/pull/4838#issuecomment-1288802860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 52s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 4m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 44s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 4m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 34s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 217m 17s | hbase-server in the patch passed. | | | | 237m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4838 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fd5d2c65a68c 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2fc879e863 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/testReport/ | | Max. process+thread count | 3111 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4838/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27442) Change the way of bumping version in release scripts
[ https://issues.apache.org/jira/browse/HBASE-27442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27442: - Status: Patch Available (was: Open) > Change the way of bumping version in release scripts > > > Key: HBASE-27442 > URL: https://issues.apache.org/jira/browse/HBASE-27442 > Project: HBase > Issue Type: Task > Components: community, scripts >Reporter: Duo Zhang >Assignee: Nick Dimiduk >Priority: Major > > After HBASE-27434, we can not use 'mvn versions:set' to change the versions, > as all the versions are filled with the $revision placeholder. We need to use > 'mvn versions:set-property' instead. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] ndimiduk commented on pull request #4844: HBASE-27442 Change the way of bumping version in release scripts
ndimiduk commented on PR #4844: URL: https://github.com/apache/hbase/pull/4844#issuecomment-1288803526 Untested... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27442) Change the way of bumping version in release scripts
[ https://issues.apache.org/jira/browse/HBASE-27442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27442: - Fix Version/s: 3.0.0-alpha-4 > Change the way of bumping version in release scripts > > > Key: HBASE-27442 > URL: https://issues.apache.org/jira/browse/HBASE-27442 > Project: HBase > Issue Type: Task > Components: community, scripts >Reporter: Duo Zhang >Assignee: Nick Dimiduk >Priority: Major > Fix For: 3.0.0-alpha-4 > > > After HBASE-27434, we can not use 'mvn versions:set' to change the versions, > as all the versions are filled with the $revision placeholder. We need to use > 'mvn versions:set-property' instead. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 commented on a diff in pull request #4808: HBASE-27218 Support rolling upgrading
Apache9 commented on code in PR #4808:
URL: https://github.com/apache/hbase/pull/4808#discussion_r1003149647
##
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/TableReplicationQueueStorage.java:
##
@@ -541,4 +538,58 @@ public boolean hasData() throws ReplicationException {
throw new ReplicationException("failed to get replication queue table",
e);
}
}
+
+ @Override
+ public void batchUpdate(ServerName serverName, List
datas)
+throws ReplicationException {
+List puts = new ArrayList<>();
+for (ReplicationQueueData data : datas) {
+ if (data.getOffsets().isEmpty()) {
+continue;
+ }
+ Put put = new Put(Bytes.toBytes(data.getId().toString()));
+ data.getOffsets().forEach((walGroup, offset) -> {
+put.addColumn(QUEUE_FAMILY, Bytes.toBytes(walGroup),
Bytes.toBytes(offset.toString()));
+ });
+ puts.add(put);
+}
+try (Table table = conn.getTable(tableName)) {
+ table.put(puts);
+} catch (IOException e) {
+ throw new ReplicationException("failed to batch update queues", e);
+}
+ }
+
+ @Override
+ public void batchUpdate(List lastPushedSeqIds) throws
ReplicationException {
+Map peerId2Put = new HashMap<>();
+for (ZkLastPushedSeqId lastPushedSeqId : lastPushedSeqIds) {
+ peerId2Put
+.computeIfAbsent(lastPushedSeqId.getPeerId(), peerId -> new
Put(Bytes.toBytes(peerId)))
+.addColumn(LAST_SEQUENCE_ID_FAMILY,
Bytes.toBytes(lastPushedSeqId.getEncodedRegionName()),
+ Bytes.toBytes(lastPushedSeqId.getLastPushedSeqId()));
+}
+try (Table table = conn.getTable(tableName)) {
+ table
+.put(peerId2Put.values().stream().filter(p ->
!p.isEmpty()).collect(Collectors.toList()));
+} catch (IOException e) {
+ throw new ReplicationException("failed to batch update last pushed
sequence ids", e);
+}
+ }
+
+ @Override
+ public void batchUpdate(String peerId, List hfileRefs) throws
ReplicationException {
+if (hfileRefs.isEmpty()) {
+ return;
+}
+Put put = new Put(Bytes.toBytes(peerId));
+for (String ref : hfileRefs) {
+ put.addColumn(HFILE_REF_FAMILY, Bytes.toBytes(ref),
HConstants.EMPTY_BYTE_ARRAY);
+}
+try (Table table = conn.getTable(tableName)) {
+ table.put(put);
Review Comment:
This is a single put, where it contains a lot column, but for the same row.
##
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/TableReplicationQueueStorage.java:
##
@@ -541,4 +538,58 @@ public boolean hasData() throws ReplicationException {
throw new ReplicationException("failed to get replication queue table",
e);
}
}
+
+ @Override
+ public void batchUpdate(ServerName serverName, List
datas)
+throws ReplicationException {
+List puts = new ArrayList<>();
+for (ReplicationQueueData data : datas) {
+ if (data.getOffsets().isEmpty()) {
+continue;
+ }
+ Put put = new Put(Bytes.toBytes(data.getId().toString()));
+ data.getOffsets().forEach((walGroup, offset) -> {
+put.addColumn(QUEUE_FAMILY, Bytes.toBytes(walGroup),
Bytes.toBytes(offset.toString()));
+ });
+ puts.add(put);
Review Comment:
This is a single put, where it contains a lot column, but for the same row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a diff in pull request #4844: HBASE-27442 Change the way of bumping version in release scripts
Apache9 commented on code in PR #4844:
URL: https://github.com/apache/hbase/pull/4844#discussion_r1003151468
##
dev-support/create-release/release-util.sh:
##
@@ -678,8 +678,8 @@ function kick_gpg_agent {
# Do maven command to set version into local pom
function maven_set_version { #input:
local this_version="$1"
- log "${MVN[@]}" versions:set -DnewVersion="$this_version"
- "${MVN[@]}" versions:set -DnewVersion="$this_version" | grep -v "no value" #
silence logs
+ log "${MVN[@]}" versions:set-property -Dproperty=revision
-DnewVersion="$this_version" -DgenerateBackupPoms=false
Review Comment:
The problem of using verisons plugin is that, it always requires updating
the version. But here we only want to change the revision property, leave the
version with ${revision} placeholder...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4844: HBASE-27442 Change the way of bumping version in release scripts
Apache-HBase commented on PR #4844: URL: https://github.com/apache/hbase/pull/4844#issuecomment-1288813628 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4844 | | Optional Tests | | | uname | Linux 065f45e4109a 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2fc879e863 | | Max. process+thread count | 41 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4844: HBASE-27442 Change the way of bumping version in release scripts
Apache-HBase commented on PR #4844: URL: https://github.com/apache/hbase/pull/4844#issuecomment-1288815122 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 1m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4844 | | Optional Tests | | | uname | Linux 6c8ca57c5520 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2fc879e863 | | Max. process+thread count | 31 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4844: HBASE-27442 Change the way of bumping version in release scripts
Apache-HBase commented on PR #4844: URL: https://github.com/apache/hbase/pull/4844#issuecomment-1288815848 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | spotless | 0m 38s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 36s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? | | | | 3m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4844 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs | | uname | Linux 8f7d681da468 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2fc879e863 | | Max. process+thread count | 34 (vs. ulimit of 3) | | modules | C: U: | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4844/1/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-27440) metrics method removeHistogramMetrics trigger serious memory leak
[ https://issues.apache.org/jira/browse/HBASE-27440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27440: - Assignee: Liuhe Tian > metrics method removeHistogramMetrics trigger serious memory leak > - > > Key: HBASE-27440 > URL: https://issues.apache.org/jira/browse/HBASE-27440 > Project: HBase > Issue Type: Bug > Components: metrics, regionserver >Affects Versions: 2.4.15 >Reporter: Liuhe Tian >Assignee: Liuhe Tian >Priority: Major > > the method removeHistogramMetrics will cause the metricsMap leak! > because the put op in the map is the baseName but the remove is not , the > origin code add the histogramSuffixe follow the baseName when remove. > !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! > !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] ndimiduk commented on a diff in pull request #4844: HBASE-27442 Change the way of bumping version in release scripts
ndimiduk commented on code in PR #4844:
URL: https://github.com/apache/hbase/pull/4844#discussion_r1003162999
##
dev-support/create-release/release-util.sh:
##
@@ -678,8 +678,8 @@ function kick_gpg_agent {
# Do maven command to set version into local pom
function maven_set_version { #input:
local this_version="$1"
- log "${MVN[@]}" versions:set -DnewVersion="$this_version"
- "${MVN[@]}" versions:set -DnewVersion="$this_version" | grep -v "no value" #
silence logs
+ log "${MVN[@]}" versions:set-property -Dproperty=revision
-DnewVersion="$this_version" -DgenerateBackupPoms=false
Review Comment:
In this patch, I'm using `versions:set-property`, not `versions:set`.
`set-property` does the appropriate thing, try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #4838: HBASE-27440 fix table HistogramMetrics leak in table metrics map
Apache9 merged PR #4838: URL: https://github.com/apache/hbase/pull/4838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-27440) metrics method removeHistogramMetrics trigger serious memory leak
[ https://issues.apache.org/jira/browse/HBASE-27440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27440. --- Fix Version/s: 2.6.0 3.0.0-alpha-4 2.5.2 2.4.16 Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.4+. Thanks [~tianliuliu] for contributing! > metrics method removeHistogramMetrics trigger serious memory leak > - > > Key: HBASE-27440 > URL: https://issues.apache.org/jira/browse/HBASE-27440 > Project: HBase > Issue Type: Bug > Components: metrics, regionserver >Affects Versions: 2.4.15 >Reporter: Liuhe Tian >Assignee: Liuhe Tian >Priority: Major > Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16 > > > the method removeHistogramMetrics will cause the metricsMap leak! > because the put op in the map is the baseName but the remove is not , the > origin code add the histogramSuffixe follow the baseName when remove. > !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! > !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 merged pull request #4842: HBASE-27438 Make release scripts can generate CHANGES.md and RELEASEN…
Apache9 merged PR #4842: URL: https://github.com/apache/hbase/pull/4842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-27438) Make release scripts can generate CHANGES.md and RELEASENOTES.md for 3.x
[ https://issues.apache.org/jira/browse/HBASE-27438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27438. --- Fix Version/s: 3.0.0-alpha-4 Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~zghao] for reviewing! > Make release scripts can generate CHANGES.md and RELEASENOTES.md for 3.x > > > Key: HBASE-27438 > URL: https://issues.apache.org/jira/browse/HBASE-27438 > Project: HBase > Issue Type: Improvement > Components: community, scripts >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-4 > > > For 3.x, we do not have CHANGES.md and RELEASENOTES.md in source control, so > we need to find a new way to generate it and commit it to dist.a.o. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1289364213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 40s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 45s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 7m 35s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | checkstyle | 1m 29s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | spotless | 0m 55s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 14m 7s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 35s | the patch passed | | +1 :green_heart: | compile | 7m 24s | the patch passed | | +1 :green_heart: | cc | 7m 24s | the patch passed | | -0 :warning: | javac | 7m 24s | root generated 3 new + 703 unchanged - 1 fixed = 706 total (was 704) | | -0 :warning: | checkstyle | 1m 4s | root: The patch generated 3 new + 25 unchanged - 0 fixed = 28 total (was 25) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 8m 49s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 5m 2s | the patch passed | | +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 15m 3s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 48s | The patch does not generate ASF License warnings. | | | | 77m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool xml | | uname | Linux 8f68ef4da25a 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 6d4e7fdfb7 | | Default Java | Temurin-1.8.0_345-b01 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/8/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/8/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | Max. process+thread count | 139 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/8/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27434) Use $revision as placeholder for maven version to make it easier to control the version from command line
[
https://issues.apache.org/jira/browse/HBASE-27434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623374#comment-17623374
]
Hudson commented on HBASE-27434:
Results for branch branch-2.5
[build #230 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/230/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/230/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/230/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/230/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/230/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Use $revision as placeholder for maven version to make it easier to control
> the version from command line
> -
>
> Key: HBASE-27434
> URL: https://issues.apache.org/jira/browse/HBASE-27434
> Project: HBase
> Issue Type: Improvement
> Components: build, pom
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2
>
>
> https://stackoverflow.com/questions/10582054/maven-project-version-inheritance-do-i-have-to-specify-the-parent-version
> https://maven.apache.org/maven-ci-friendly.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27434) Use $revision as placeholder for maven version to make it easier to control the version from command line
[
https://issues.apache.org/jira/browse/HBASE-27434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623379#comment-17623379
]
Hudson commented on HBASE-27434:
Results for branch master
[build #705 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/705/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/705/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/705/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/705/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Use $revision as placeholder for maven version to make it easier to control
> the version from command line
> -
>
> Key: HBASE-27434
> URL: https://issues.apache.org/jira/browse/HBASE-27434
> Project: HBase
> Issue Type: Improvement
> Components: build, pom
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2
>
>
> https://stackoverflow.com/questions/10582054/maven-project-version-inheritance-do-i-have-to-specify-the-parent-version
> https://maven.apache.org/maven-ci-friendly.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27437) TestHeapSize is flaky
[
https://issues.apache.org/jira/browse/HBASE-27437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623378#comment-17623378
]
Hudson commented on HBASE-27437:
Results for branch master
[build #705 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/705/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/705/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/705/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/705/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestHeapSize is flaky
> -
>
> Key: HBASE-27437
> URL: https://issues.apache.org/jira/browse/HBASE-27437
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> I believe it is just in memory computation, so it is weird that why it can be
> flaky.
> Need to dig more.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1289583075 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 51s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 52s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 1m 55s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 4m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 59s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 30s | the patch passed | | +1 :green_heart: | compile | 1m 51s | the patch passed | | +1 :green_heart: | javac | 1m 51s | the patch passed | | +1 :green_heart: | shadedjars | 4m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 55s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 232m 3s | root in the patch failed. | | | | 261m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b07d90560d2b 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 6d4e7fdfb7 | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/8/testReport/ | | Max. process+thread count | 2730 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27371) Bump spotbugs version
[
https://issues.apache.org/jira/browse/HBASE-27371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623388#comment-17623388
]
Hudson commented on HBASE-27371:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Bump spotbugs version
> -
>
> Key: HBASE-27371
> URL: https://issues.apache.org/jira/browse/HBASE-27371
> Project: HBase
> Issue Type: Task
> Components: build, pom
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> Recently there are strange spotbugs failures in pre commit builds, likely to
> be a false positive.
> https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4779/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
> Let's see if upgrading the spotbugs version can solve the problem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27370) Avoid decompressing blocks when reading from bucket cache prefetch threads
[
https://issues.apache.org/jira/browse/HBASE-27370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623392#comment-17623392
]
Hudson commented on HBASE-27370:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Avoid decompressing blocks when reading from bucket cache prefetch threads
> ---
>
> Key: HBASE-27370
> URL: https://issues.apache.org/jira/browse/HBASE-27370
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-4
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> When prefetching blocks into bucket cache, we had observed a consistent CPU
> usage around 70% with no other workloads ongoing. For large bucket caches
> (i.e. when using file based bucket cache), the prefetch can last for sometime
> and having such a high CPU usage may impact the database usage by client
> applications.
> Further analysis of the prefetch threads stack trace showed that very often,
> decompress logic is being executed by these threads:
> {noformat}
> "hfile-prefetch-1654895061122" #234 daemon prio=5 os_prio=0
> tid=0x557bb2907000 nid=0x406d runnable [0x7f294a504000]
> java.lang.Thread.State: RUNNABLE
> at
> org.apache.hadoop.io.compress.snappy.SnappyDecompressor.decompressBytesDirect(Native
> Method)
> at
> org.apache.hadoop.io.compress.snappy.SnappyDecompressor.decompress(SnappyDecompressor.java:235)
> at
> org.apache.hadoop.io.compress.BlockDecompressorStream.decompress(BlockDecompressorStream.java:88)
> at
> org.apache.hadoop.io.compress.DecompressorStream.read(DecompressorStream.java:105)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
> - locked <0x0002d24c0ae8> (a java.io.BufferedInputStream)
> at
> org.apache.hadoop.hbase.io.util.BlockIOUtils.readFullyWithHeapBuffer(BlockIOUtils.java:105)
> at
> org.apache.hadoop.hbase.io.compress.Compression.decompress(Compression.java:465)
> at
> org.apache.hadoop.hbase.io.encoding.HFileBlockDefaultDecodingContext.prepareDecoding(HFileBlockDefaultDecodingContext.java:90)
> at
> org.apache.hadoop.hbase.io.hfile.HFileBlock.unpack(HFileBlock.java:650)
> at
> org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(HFileReaderImpl.java:1342)
> {noformat}
> This is because *HFileReaderImpl.readBlock* is always decompressing blocks
> even when *hbase.block.data.cachecompressed* is set to true.
> This patch proposes an alternative flag to differentiate prefetch from normal
> reads, so that doesn't decompress DATA blocks when prefetching with
> *hbase.block.data.cachecompressed* set to true.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27393) Frequent and not useful "Final timeLimitDelta" log lines
[
https://issues.apache.org/jira/browse/HBASE-27393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623393#comment-17623393
]
Hudson commented on HBASE-27393:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Frequent and not useful "Final timeLimitDelta" log lines
>
>
> Key: HBASE-27393
> URL: https://issues.apache.org/jira/browse/HBASE-27393
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.4.14
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.4.15
>
>
> Introduced by HBASE-27205 Fix tests that rely on EnvironmentEdgeManager in
> branch-2.4.
> This line should be removed:
> https://github.com/apache/hbase/blob/e25b2a7cd0b0daddad5ab09a87cd7ed9f59c81b6/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L3236
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27373) Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
[
https://issues.apache.org/jira/browse/HBASE-27373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623390#comment-17623390
]
Hudson commented on HBASE-27373:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix new spotbugs warnings after upgrading spotbugs to 4.7.2
> ---
>
> Key: HBASE-27373
> URL: https://issues.apache.org/jira/browse/HBASE-27373
> Project: HBase
> Issue Type: Task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27365) Minimise block addition failures due to no space in bucket cache writers queue by introducing wait time
[
https://issues.apache.org/jira/browse/HBASE-27365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623399#comment-17623399
]
Hudson commented on HBASE-27365:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Minimise block addition failures due to no space in bucket cache writers
> queue by introducing wait time
> ---
>
> Key: HBASE-27365
> URL: https://issues.apache.org/jira/browse/HBASE-27365
> Project: HBase
> Issue Type: Improvement
> Components: BucketCache
>Affects Versions: 3.0.0-alpha-3
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> Currently in bucket cache asynchronous caching mechanism introduced where
> initially the blocks to be cached will be added to queue and writer threads
> consume the blocks from the queue and write to bucket cache. In case if block
> writing to bucket cache is slow then there is a chance that queue of writer
> threads become full and following block additions will be failed. In case of
> slower storages like s3 might introduce latencies even if we enable bigger
> sizes of bucket cache using ephemeral storages. So we can allow configurable
> wait time while adding blocks to queue so that chances of queue free up is
> possible during the wait time and block addition failures can be minimised.
> To avoid the performance impact of wait time in regular read paths we can use
> the wait time mainly during background operations like compactions, flushes
> or prefetches etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27411) Update and clean up bcprov-jdk15on dependency
[
https://issues.apache.org/jira/browse/HBASE-27411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623402#comment-17623402
]
Hudson commented on HBASE-27411:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update and clean up bcprov-jdk15on dependency
> --
>
> Key: HBASE-27411
> URL: https://issues.apache.org/jira/browse/HBASE-27411
> Project: HBase
> Issue Type: Task
> Components: build
>Affects Versions: 3.0.0-alpha-4
>Reporter: Nick Dimiduk
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> {noformat}
> $ env
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> mvn -T0.5C clean install -DskipTests
>
> [INFO] Scanning for projects...
>
>
> [WARNING]
>
>
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.hbase:hbase-server:jar:3.0.0-alpha-4-SNAPSHOT
>
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
> be unique: org.bouncycastle:bcprov-jdk15on:jar -> duplicate declaration of
> version (?) @ line 331, column 17
> [WARNING]
>
>
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
>
> [WARNING]
>
>
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.
>
> [WARNING]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27381) Still seeing 'Stuck' in static initialization creating RegionInfo instance
[
https://issues.apache.org/jira/browse/HBASE-27381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623398#comment-17623398
]
Hudson commented on HBASE-27381:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Still seeing 'Stuck' in static initialization creating RegionInfo instance
> --
>
> Key: HBASE-27381
> URL: https://issues.apache.org/jira/browse/HBASE-27381
> Project: HBase
> Issue Type: Bug
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Fix For: 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> See https://issues.apache.org/jira/browse/HBASE-24896 for the original
> description. Despite having that fix, we are seeing this issue in a
> 2.4.6-based deploy. We recently started seeing it as we were moving to
> centos8. I'm not sure why the centos version would affect this, otherwise the
> hbase server version and java versions were not changing.
> We're seeing this in a non-trivial number of new centos8 servers that we spin
> up. I'm pushing a hotfix which removes RegionInfo.UNDEFINED to see if that
> resolves our issue.
> As mentioned in my last comments on that jira, it could be that this field is
> still an issue because according to
> [https://stackoverflow.com/questions/28631656/runnable-thread-state-but-in-object-wait:]
> > Such deadlocks may be caused by a [typical
> > bug|https://bugs.openjdk.org/browse/JDK-8037567] when a subclass is
> > referenced from a static initializer.
> If that's true, in this case MutableRegionInfo is a subclass/implementer of
> RegionInfo, so that could trigger it. Granted the linked bug is marked "Not
> An Issue".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27407) Fixing check for "description" request param in JMXJsonServlet.java
[
https://issues.apache.org/jira/browse/HBASE-27407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623400#comment-17623400
]
Hudson commented on HBASE-27407:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fixing check for "description" request param in JMXJsonServlet.java
> ---
>
> Key: HBASE-27407
> URL: https://issues.apache.org/jira/browse/HBASE-27407
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 2.6.0, 3.0.0-alpha-3
>Reporter: Luca Kovacs
>Assignee: Luca Kovacs
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> When trying to access the JMX metrics' description via the "description=true"
> URL parameter, any value is accepted.
> The current version checks only if "description" is in the URL parameter, but
> doesn't check the parameter value.
> I would like to fix this via checking if the parameter value is 'true' and
> showing the description only when this condition is met.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27425) Run flaky test job more often
[
https://issues.apache.org/jira/browse/HBASE-27425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623411#comment-17623411
]
Hudson commented on HBASE-27425:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Run flaky test job more often
> -
>
> Key: HBASE-27425
> URL: https://issues.apache.org/jira/browse/HBASE-27425
> Project: HBase
> Issue Type: Task
> Components: test
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
> Attachments: ci-hbase-hbase-flaky-test-master-time-png.png,
> ci-hbase-hbase-load-chart-long.png
>
>
> We currently run the flaky tests once per 4 hours and keep a backlog of 50
> runs. That means it takes a perfect test a bit over 8 days to get back out of
> being penalized.
> we regularly are leaving a bunch of executors idle (see attached PNG) and I
> think we should run the tests more often.
> we use an executor per branch for a flaky test run. the duration depends on
> the specific tests that are flagged, but it has a timeout of 2 hours.
> as an example the master branch tests currently take < 30 minutes (see other
> attached PNG).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27159) Emit source metrics for BlockCacheExpressHitPercent
[
https://issues.apache.org/jira/browse/HBASE-27159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623410#comment-17623410
]
Hudson commented on HBASE-27159:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Emit source metrics for BlockCacheExpressHitPercent
> ---
>
> Key: HBASE-27159
> URL: https://issues.apache.org/jira/browse/HBASE-27159
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, metrics
>Affects Versions: 3.0.0-alpha-1, 2.0.0
>Reporter: David Manning
>Assignee: David Manning
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.16
>
>
> [https://github.com/apache/hbase/blob/d447fa01ba36a11d57927b78cce1bbca361b1d52/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java#L346-L400]
> {code:java}
> public double getHitCachingRatio() {
> double requestCachingCount = getRequestCachingCount();
> if (requestCachingCount == 0) {
> return 0;
> }
> return getHitCachingCount() / requestCachingCount;
> } {code}
> This code is responsible for the metric {{{}BlockCacheExpressHitPercent{}}}.
> The metric represents the percentage of requests which were cacheable, but
> not found in the cache. Unfortunately, since the counters are process-level
> counters, the ratio is for the lifetime of the process. This makes it less
> useful for looking at cache behavior during a smaller time period.
> The underlying counters are {{hitCachingCount}} and {{{}missCachingCount{}}}.
> Having access to the underlying counters allows for offline computation of
> the same metric for any given time period. But these counters are not emitted
> today from {{{}MetricsRegionServerWrapperImpl.java{}}}.
> Compare this to {{hitCount}} and {{missCount}} which are emitted as metrics
> {{blockCacheHitCount}} and {{{}blockCacheMissCount{}}}. But these are raw
> counts for the cache, which include requests that are not cacheable. The
> cacheable metrics are more interesting, since it can be common to miss on a
> request which is not cacheable.
> Interestingly, these metrics are emitted regularly as part of a log line in
> {{{}StatisticsThread.logStats{}}}.
> We should emit blockCache{{{}HitCachingCount{}}} and
> {{blockCacheMissCachingCount}} along with the current metrics.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27391) Downgrade ERROR log to DEBUG in ConnectionUtils.updateStats
[
https://issues.apache.org/jira/browse/HBASE-27391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623396#comment-17623396
]
Hudson commented on HBASE-27391:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Downgrade ERROR log to DEBUG in ConnectionUtils.updateStats
> ---
>
> Key: HBASE-27391
> URL: https://issues.apache.org/jira/browse/HBASE-27391
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Labels: patch-available
> Fix For: 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> This method logs with ERROR level if the MultiResponse does not include
> RegionLoadStats. These stats may be disabled on the server side, and really
> this doesn't seem like an error state. We should downgrade to DEBUG since
> it's an optional feature that is not enabled by default.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27420) Failure while connecting to zk if HBase is running in standalone mode in a container
[
https://issues.apache.org/jira/browse/HBASE-27420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623406#comment-17623406
]
Hudson commented on HBASE-27420:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Failure while connecting to zk if HBase is running in standalone mode in a
> container
>
>
> Key: HBASE-27420
> URL: https://issues.apache.org/jira/browse/HBASE-27420
> Project: HBase
> Issue Type: Bug
> Components: Zookeeper
>Reporter: Sanjeet Malhotra
>Assignee: Sanjeet Malhotra
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> With [this change|https://issues.apache.org/jira/browse/HBASE-23993]
> zookeeper will only listen for client connections on 127.0.0.1 in standalone
> mode. If HBase is running in standalone mode inside a docker container and
> docker port forwarding is being used to connect to HBase inside container
> then, any client trying to connect to zk will have destination IP as
> container's private IP rather than loopback IP. This will cause zk to reject
> all client connections being initiated from outside the container.
> Thus, we need a way to make zk listen for client connections on IP other than
> loopback. zk already provides a property named `clientPortAddress` to specify
> the address to listen for client connections. And, we can specify zk
> properties using `hbase.zookeeper.property.` prefix. Thus, the proposal is to
> allow user to specify the IP address that zk will listen on using
> `hbase.zookeeper.property.clientPortAddress` and if its not specified then
> default to loopback as per current behaviour.
> This way, the tests will still remain unimpacted and HBase can also be used
> in standalone mode in a container.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623401#comment-17623401
]
Hudson commented on HBASE-27401:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up current broken 'n's in our javadoc
> ---
>
> Key: HBASE-27401
> URL: https://issues.apache.org/jira/browse/HBASE-27401
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
> Attachments: ns_at_the_end, ns_in_the_middle
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27426) Region server abort with failing to list region servers.
[
https://issues.apache.org/jira/browse/HBASE-27426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623409#comment-17623409
]
Hudson commented on HBASE-27426:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Region server abort with failing to list region servers.
>
>
> Key: HBASE-27426
> URL: https://issues.apache.org/jira/browse/HBASE-27426
> Project: HBase
> Issue Type: Bug
> Components: Zookeeper
>Reporter: Victor Li
>Assignee: Victor Li
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.16
>
>
> During unit tests, clusters were created and destroyed, the region server
> could abort during shutdown with failing to list region servers.
>
> Logs:
>
> 2022-10-11 18:44:43,393 INFO [main] utility.HBaseClusterSetup(160): Starting
> mini cluster: singleCluster
> [master/victorli-wsl:0:becomeActiveMaster] INFO
> org.apache.hadoop.hbase.zookeeper.ZKWatcher - not a secure deployment,
> proceeding
> 2022-10-11 18:45:07,234 INFO [Listener at localhost/45185]
> utility.HBaseClusterSetup(177): Started mini cluster: singleCluster
> [Listener at localhost/45185] INFO
> org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close started.
> [Listener at localhost/45185] INFO
> org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close finished.
> [Listener at localhost/45185] INFO
> org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close started.
> [Listener at localhost/45185] INFO
> org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close finished.
> 2022-10-11 18:45:45,980 INFO [Listener at localhost/45185]
> utility.HBaseClusterSetup(132): Stopping mini cluster: singleCluster
> [RS:0;victorli-wsl:35113] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher -
> ZKWatcher close started.
> [zk-event-processor-pool-0] ERROR
> org.apache.hadoop.hbase.regionserver.HRegionServer - * ABORTING region
> server victorli-wsl,35113,1665539090704: failed to list region servers *
> [RS:0;victorli-wsl:35113] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher -
> ZKWatcher close finished.
> [M:0;victorli-wsl:42915] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher -
> ZKWatcher close started.
> [M:0;victorli-wsl:42915] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher -
> ZKWatcher close finished.
> 2022-10-11 18:45:57,208 INFO [Listener at localhost/45185]
> utility.HBaseClusterSetup(144): Stopped mini cluster: singleCluster
>
> Stack:
> [zk-event-processor-pool-0] WARN org.apache.hadoop.hbase.zookeeper.ZKUtil -
> regionserver:35113-0x101b6fed2a1, quorum=127.0.0.1:53028, baseZNode=/9
> Unable to list children of znode /9/rs
> java.lang.InterruptedException
> at java.lang.Object.wait(Native Method)
> at java.lang.Object.wait(Object.java:502)
> at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1601)
> at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1573)
> at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:2420)
> at
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.getChildren(RecoverableZooKeeper.java:341)
> at
> org.apache.hadoop.hbase.zookeeper.ZKUtil.listChildrenAndWatchForNewChildren(ZKUtil.java:190)
> at
> org.apache.hadoop.hbase.zookeeper.RegionServerAddressTracker.loadRegionServerList(RegionServerAddressTracker.java:54)
> at
> org.apache.hadoop.hbase.zookeeper.RegionServerAddressTracker.nodeChildrenChanged(RegionServerAddressTracker.java:71)
> at
> org.apache.hadoop.hbase.zookeeper.ZKWatcher.lambda$processEvent$0(ZKWatcher.java:586)
> at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187)
> at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177)
> at
> org.apache.hadoop.hbase.zookeeper.ZKWatcher.processEvent(ZKWatcher.java:554)
> at
> org.apache.hadoop.hbase.zookeeper.ZKWatcher.lambda$process$1(ZKWatcher.java:607)
> at
> org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(Tr
[jira] [Commented] (HBASE-27441) Use jdk 11.0.16 instead of 11.0.16.1 for branch-2.4
[
https://issues.apache.org/jira/browse/HBASE-27441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623412#comment-17623412
]
Hudson commented on HBASE-27441:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Use jdk 11.0.16 instead of 11.0.16.1 for branch-2.4
> ---
>
> Key: HBASE-27441
> URL: https://issues.apache.org/jira/browse/HBASE-27441
> Project: HBase
> Issue Type: Task
> Components: build, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.4.16
>
>
> In 2.4.x we still support hadoop 3.2.0, which is still on jetty 9.3.x, which
> can not parse jva version like 11.0.16.1
> https://github.com/eclipse/jetty.project/issues/2090
> This causes bunch of UT failures in nightly job for branch-2.4 and finally
> cause almost all UTs to be in flaky list.
> Usually for a mature minor release line, we will not bump its hadoop version,
> so let's downgrade the jdk 11 version to 11.0.16 to fix the nightly and flaky
> jobs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27421) Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule
[
https://issues.apache.org/jira/browse/HBASE-27421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623407#comment-17623407
]
Hudson commented on HBASE-27421:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc
> stubs' rule
>
>
> Key: HBASE-27421
> URL: https://issues.apache.org/jira/browse/HBASE-27421
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, pom
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> spotless maven 2.27.2 is released and it contains
> https://github.com/diffplug/spotless/issues/1359, which allows the
> replacement to be null, so we can add back the 'Remove unhelpful javadoc
> stubs' rule now.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27368) Do not need to throw IllegalStateException when peer is not active in ReplicationSource.initialize
[
https://issues.apache.org/jira/browse/HBASE-27368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623389#comment-17623389
]
Hudson commented on HBASE-27368:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Do not need to throw IllegalStateException when peer is not active in
> ReplicationSource.initialize
> --
>
> Key: HBASE-27368
> URL: https://issues.apache.org/jira/browse/HBASE-27368
> Project: HBase
> Issue Type: Bug
> Components: regionserver, Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> The only place where we can reset the sourceRunning flag to false is in
> terminate method, where we want to stop the replication source. And we
> already have a interrupted state check in the initialize method to not throw
> IllegalStateException when peer is terminating, so I think here we could just
> do not throw IllegalStateExeption at all.
> The reason why the interrupted state check does not work is that, in
> FutureUtils.get, we will wrap InterruptedException with
> InterruptedIOException, without restoring the interrupted state, but the
> upper layer does not treat InterruptedIOException specially so the
> interrupted state is lost. But anway, I do not think we should rely on the
> interrupted state to determine whether we should abort the region server...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27431) Remove TestRemoteTable.testLimitedScan
[
https://issues.apache.org/jira/browse/HBASE-27431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623408#comment-17623408
]
Hudson commented on HBASE-27431:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove TestRemoteTable.testLimitedScan
> --
>
> Key: HBASE-27431
> URL: https://issues.apache.org/jira/browse/HBASE-27431
> Project: HBase
> Issue Type: Task
> Components: REST, test
>Affects Versions: 2.6.0, 2.5.1, 2.4.15
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Trivial
> Fix For: 2.6.0, 2.5.1, 2.4.16
>
>
> The TestRemoteTable.testLimitedScan was originally added in HBASE-24267 for
> 3.0.0-alpha-1 but with the backport of HBASE-27401 the test was added to
> branch-2.4, branch-2.5, and branch-2 where the limit support is not available.
> This causes test failure on these branches.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27403) Remove 'Remove unhelpful javadoc stubs' spotless rule for now
[
https://issues.apache.org/jira/browse/HBASE-27403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623397#comment-17623397
]
Hudson commented on HBASE-27403:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove 'Remove unhelpful javadoc stubs' spotless rule for now
> -
>
> Key: HBASE-27403
> URL: https://issues.apache.org/jira/browse/HBASE-27403
> Project: HBase
> Issue Type: Sub-task
> Components: documentation, pom
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> Until we fix the spotless issue:
> https://github.com/diffplug/spotless/issues/1359
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27064) CME in TestRegionNormalizerWorkQueue
[
https://issues.apache.org/jira/browse/HBASE-27064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623395#comment-17623395
]
Hudson commented on HBASE-27064:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> CME in TestRegionNormalizerWorkQueue
>
>
> Key: HBASE-27064
> URL: https://issues.apache.org/jira/browse/HBASE-27064
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-3
>
>
> FAILURE! - in
> org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue
> {noformat}
> [ERROR]
> org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue.testTake
> Time elapsed: 0.065 s <<< ERROR!
> java.util.concurrent.ExecutionException:
> java.util.ConcurrentModificationException
> at
> java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
> at
> java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1928)
> at
> org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue.testTake(TestRegionNormalizerWorkQueue.java:211)
> Caused by: java.util.ConcurrentModificationException
> at
> java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
> at
> java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742)
> at
> org.apache.hadoop.hbase.master.normalizer.RegionNormalizerWorkQueue.take(RegionNormalizerWorkQueue.java:192)
> at
> org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue.lambda$testTake$3(TestRegionNormalizerWorkQueue.java:192)
> at
> java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1640)
> at
> java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1632)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> at
> java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
> at
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27419) Update to hbase-thirdparty 4.1.2
[
https://issues.apache.org/jira/browse/HBASE-27419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623403#comment-17623403
]
Hudson commented on HBASE-27419:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update to hbase-thirdparty 4.1.2
>
>
> Key: HBASE-27419
> URL: https://issues.apache.org/jira/browse/HBASE-27419
> Project: HBase
> Issue Type: Bug
> Components: dependencies
>Affects Versions: 2.5.0, 2.4.14
>Reporter: Andrew Kyle Purtell
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> Update to hbase-thirdparty 4.1.2 when it is released.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27384) Backport HBASE-27064 to branch 2.4
[
https://issues.apache.org/jira/browse/HBASE-27384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623394#comment-17623394
]
Hudson commented on HBASE-27384:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backport HBASE-27064 to branch 2.4
> ---
>
> Key: HBASE-27384
> URL: https://issues.apache.org/jira/browse/HBASE-27384
> Project: HBase
> Issue Type: Sub-task
> Components: Normalizer
>Affects Versions: 2.4.14
>Reporter: Aman Poonia
>Assignee: Aman Poonia
>Priority: Minor
> Fix For: 2.4.15
>
>
> {*}Error:
> java.util.ConcurrentModificationException{*}{{{}java.util.concurrent.ExecutionException:
> java.util.ConcurrentModificationException at
> java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
> at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1928) at
> org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue.testTake(TestRegionNormalizerWorkQueue.java:211)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498) at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at
> org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at
> org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at
> org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39) at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) at
> java.lang.Thread.run(Thread.java:750) Caused by:
> java.util.ConcurrentModificationException at
> java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
> at java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742) at
> org.apache.hadoop.hbase.master.normalizer.RegionNormalizerWorkQueue.take(RegionNormalizerWorkQueue.java:192)
> at
> org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue.lambda$testTake$3(TestRegionNormalizerWorkQueue.java:192)
> at
> java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1640)
> at
> java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1632)
> at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) at
> java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
> at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) at
> java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175){}}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27339) Improve sasl connection failure log message to include server
[
https://issues.apache.org/jira/browse/HBASE-27339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623405#comment-17623405
]
Hudson commented on HBASE-27339:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Improve sasl connection failure log message to include server
> -
>
> Key: HBASE-27339
> URL: https://issues.apache.org/jira/browse/HBASE-27339
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 1.7.2
>Reporter: Daniel Wong
>Assignee: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> We were seeing timeout issues in our deployment in the saslConnect path in
> the blockingRPC client. Knowing which server we failed to connect to would
> help isolate and understand the issue.
>
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server :
> java.io.IOException: Connection reset by peer {code}
>
>
> Change the log message to something like
>
> {code:java}
> ipc.BlockingRpcConnection - Exception encountered while connecting to the
> server myhost.realm.net:
> java.io.IOException: Connection reset by peer {code}
>
> See relevant code
> [here|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java#L398]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27424) Upgrade Jettison for CVE-2022-40149/40150
[
https://issues.apache.org/jira/browse/HBASE-27424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623404#comment-17623404
]
Hudson commented on HBASE-27424:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade Jettison for CVE-2022-40149/40150
> -
>
> Key: HBASE-27424
> URL: https://issues.apache.org/jira/browse/HBASE-27424
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
> Jettison versions <= 1.5.0 are subject to CVE-2022-40149 and CVE-2022-40150.
> Move jettison.version to 1.5.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27372) Update java versions in our Dockerfiles
[
https://issues.apache.org/jira/browse/HBASE-27372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623391#comment-17623391
]
Hudson commented on HBASE-27372:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update java versions in our Dockerfiles
> ---
>
> Key: HBASE-27372
> URL: https://issues.apache.org/jira/browse/HBASE-27372
> Project: HBase
> Issue Type: Task
> Components: build, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1289735099 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 14s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 1m 33s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | shadedjars | 3m 45s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 35s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 13s | the patch passed | | +1 :green_heart: | compile | 1m 35s | the patch passed | | +1 :green_heart: | javac | 1m 35s | the patch passed | | +1 :green_heart: | shadedjars | 3m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 377m 17s | root in the patch passed. | | | | 401m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e63a1f39a7c2 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 6d4e7fdfb7 | | Default Java | Temurin-1.8.0_345-b01 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/8/testReport/ | | Max. process+thread count | 4505 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/8/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4837: HBASE-25983 javadoc generation fails on openjdk-11.0.11+9
Apache-HBase commented on PR #4837: URL: https://github.com/apache/hbase/pull/4837#issuecomment-1289894931 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 45s | master passed | | -1 :x: | compile | 1m 7s | root in master failed. | | +1 :green_heart: | spotless | 0m 47s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 27s | the patch passed | | +1 :green_heart: | compile | 7m 16s | the patch passed | | -0 :warning: | javac | 7m 16s | root generated 703 new + 0 unchanged - 0 fixed = 703 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 10m 3s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 43s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 32m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4837/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4837 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux 78a51f6792ea 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2a3d5b160a | | Default Java | Temurin-1.8.0_345-b01 | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4837/2/artifact/yetus-general-check/output/branch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4837/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | Max. process+thread count | 140 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4837/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4808: HBASE-27218 Support rolling upgrading
Apache-HBase commented on PR #4808: URL: https://github.com/apache/hbase/pull/4808#issuecomment-1289966442 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 8s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 38s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 4s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 5m 52s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | checkstyle | 0m 56s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | spotless | 0m 37s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 11m 14s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 2s | the patch passed | | +1 :green_heart: | compile | 5m 55s | the patch passed | | +1 :green_heart: | cc | 5m 55s | the patch passed | | -0 :warning: | javac | 5m 55s | root generated 1 new + 703 unchanged - 1 fixed = 704 total (was 704) | | -0 :warning: | checkstyle | 0m 58s | root: The patch generated 2 new + 25 unchanged - 0 fixed = 27 total (was 25) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 8m 14s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 4m 3s | the patch passed | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 11m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 43s | The patch does not generate ASF License warnings. | | | | 65m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/9/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4808 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool xml | | uname | Linux 55eeca7cbd7f 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / 6d4e7fdfb7 | | Default Java | Temurin-1.8.0_345-b01 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/9/artifact/yetus-general-check/output/diff-compile-javac-root.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/9/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | Max. process+thread count | 139 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-replication hbase-procedure hbase-server . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4808/9/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.7.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27440) metrics method removeHistogramMetrics trigger serious memory leak
[
https://issues.apache.org/jira/browse/HBASE-27440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623559#comment-17623559
]
Hudson commented on HBASE-27440:
Results for branch branch-2.4
[build #447 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/447/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/447/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/447/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/447/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/447/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> metrics method removeHistogramMetrics trigger serious memory leak
> -
>
> Key: HBASE-27440
> URL: https://issues.apache.org/jira/browse/HBASE-27440
> Project: HBase
> Issue Type: Bug
> Components: metrics, regionserver
>Affects Versions: 2.4.15
>Reporter: Liuhe Tian
>Assignee: Liuhe Tian
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> the method removeHistogramMetrics will cause the metricsMap leak!
> because the put op in the map is the baseName but the remove is not , the
> origin code add the histogramSuffixe follow the baseName when remove.
> !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png!
> !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27434) Use $revision as placeholder for maven version to make it easier to control the version from command line
[
https://issues.apache.org/jira/browse/HBASE-27434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623563#comment-17623563
]
Hudson commented on HBASE-27434:
Results for branch branch-2
[build #668 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/668/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/668/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/668/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/668/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/668/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Use $revision as placeholder for maven version to make it easier to control
> the version from command line
> -
>
> Key: HBASE-27434
> URL: https://issues.apache.org/jira/browse/HBASE-27434
> Project: HBase
> Issue Type: Improvement
> Components: build, pom
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2
>
>
> https://stackoverflow.com/questions/10582054/maven-project-version-inheritance-do-i-have-to-specify-the-parent-version
> https://maven.apache.org/maven-ci-friendly.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27440) metrics method removeHistogramMetrics trigger serious memory leak
[
https://issues.apache.org/jira/browse/HBASE-27440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623564#comment-17623564
]
Hudson commented on HBASE-27440:
Results for branch branch-2
[build #668 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/668/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/668/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/668/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/668/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/668/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> metrics method removeHistogramMetrics trigger serious memory leak
> -
>
> Key: HBASE-27440
> URL: https://issues.apache.org/jira/browse/HBASE-27440
> Project: HBase
> Issue Type: Bug
> Components: metrics, regionserver
>Affects Versions: 2.4.15
>Reporter: Liuhe Tian
>Assignee: Liuhe Tian
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> the method removeHistogramMetrics will cause the metricsMap leak!
> because the put op in the map is the baseName but the remove is not , the
> origin code add the histogramSuffixe follow the baseName when remove.
> !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png!
> !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #4837: HBASE-25983 javadoc generation fails on openjdk-11.0.11+9
Apache-HBase commented on PR #4837: URL: https://github.com/apache/hbase/pull/4837#issuecomment-1290027261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 33s | master passed | | +1 :green_heart: | compile | 1m 42s | master passed | | +1 :green_heart: | shadedjars | 3m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 49s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 32s | the patch passed | | +1 :green_heart: | compile | 1m 42s | the patch passed | | +1 :green_heart: | javac | 1m 42s | the patch passed | | +1 :green_heart: | shadedjars | 3m 54s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 44s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 216m 24s | root in the patch failed. | | | | 238m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4837/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4837 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3b33be628b24 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2a3d5b160a | | Default Java | Eclipse Adoptium-11.0.16.1+1 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4837/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4837/2/testReport/ | | Max. process+thread count | 2838 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4837/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4837: HBASE-25983 javadoc generation fails on openjdk-11.0.11+9
Apache9 commented on PR #4837: URL: https://github.com/apache/hbase/pull/4837#issuecomment-1290037095 Yetus 0.14.1 is out, let's finish this issue. @ndimiduk I've updated the comment. PTAL again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25983) javadoc generation fails on openjdk-11.0.11+9
[
https://issues.apache.org/jira/browse/HBASE-25983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623581#comment-17623581
]
Duo Zhang commented on HBASE-25983:
---
Yetus 0.14.1 is out, the PR is ready.
PTAL.
Thanks.
> javadoc generation fails on openjdk-11.0.11+9
> -
>
> Key: HBASE-25983
> URL: https://issues.apache.org/jira/browse/HBASE-25983
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.4.3
> Environment: maven - 3.5.4 and 3.6.2
> java - openjdk 11.0.11+9
> centos6
> hbase - 2.4.3
>Reporter: Bryan Beaudreault
>Assignee: Duo Zhang
>Priority: Major
>
> I'm trying to build javadoc for HBase 2.4.3 on jdk11. The command I'm running
> is as follows:
> {code:java}
> JAVA_HOME=/usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/ mvn
> -Phadoop-3.0 -Phadoop.profile=3.0 -Dhadoop-three.version=3.2.2
> -Dhadoop.guava.version=27.0-jre -Dslf4j.version=1.7.25
> -Djetty.version=9.3.29.v20201019 -Dzookeeper.version=3.5.7 -DskipTests
> -Dcheckstyle.skip=true site{code}
> I've tried this with maven 3.5.4 and 3.6.2. Based on JAVA_HOME above,
> jdk11.0.11+9.
> {{The error is as follows:}}
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
> project hbase: Error generating maven-javadoc-plugin:3.2.0:aggregate-no-fork
> report:
> [ERROR] Exit code: 1 - javadoc: warning - The old Doclet and Taglet APIs in
> the packages
> [ERROR] com.sun.javadoc, com.sun.tools.doclets and their implementations
> [ERROR] are planned to be removed in a future JDK release. These
> [ERROR] components have been superseded by the new APIs in
> jdk.javadoc.doclet.
> [ERROR] Users are strongly recommended to migrate to the new APIs.
> [ERROR] javadoc: error - invalid flag: -author
> [ERROR]
> [ERROR] Command line was:
> /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/bin/javadoc -J-Xmx2G
> @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> '/hbase/rpm/build/BUILD/hbase-2.4.3/target/site/apidocs' dir.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]{code}
> I believe this is due to the yetus doclet
> org.apache.yetus.audience.tools.IncludePublicAnnotationsStandardDoclet.
> Commenting this doclet out from the userapi and testuserapi reportSets in
> pom.xml fixes the build.
>
> I noticed hbase 2.4.3 depends on audience-annotations 0.5.0, which is very
> old. I tried updating to 0.13.0, but that did not help.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache9 commented on a diff in pull request #4844: HBASE-27442 Change the way of bumping version in release scripts
Apache9 commented on code in PR #4844:
URL: https://github.com/apache/hbase/pull/4844#discussion_r1004051910
##
dev-support/create-release/release-util.sh:
##
@@ -678,8 +678,8 @@ function kick_gpg_agent {
# Do maven command to set version into local pom
function maven_set_version { #input:
local this_version="$1"
- log "${MVN[@]}" versions:set -DnewVersion="$this_version"
- "${MVN[@]}" versions:set -DnewVersion="$this_version" | grep -v "no value" #
silence logs
+ log "${MVN[@]}" versions:set-property -Dproperty=revision
-DnewVersion="$this_version" -DgenerateBackupPoms=false
Review Comment:
Ah, tried locally, seems OK, the -DnewVersion=xxx made me think it is going
to set the version field, but actually, it is used to specify the value of the
property...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4844: HBASE-27442 Change the way of bumping version in release scripts
Apache9 commented on PR #4844: URL: https://github.com/apache/hbase/pull/4844#issuecomment-1290048196 There is a pending problem that, for branch-2.4, we still need to use the old way to bump the version. Maybe we could try `grep '' pom.xml`, if it does not exist, we go with the old way, otherwise we use the new way. @ndimiduk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4837: HBASE-25983 javadoc generation fails on openjdk-11.0.11+9
Apache-HBase commented on PR #4837: URL: https://github.com/apache/hbase/pull/4837#issuecomment-1290065031 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 18s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 9s | master passed | | +1 :green_heart: | compile | 6m 18s | master passed | | +1 :green_heart: | spotless | 0m 39s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 8s | the patch passed | | +1 :green_heart: | compile | 6m 15s | the patch passed | | +1 :green_heart: | javac | 6m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 7m 45s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 36m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4837/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4837 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux 9beb6732b644 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2a3d5b160a | | Default Java | Temurin-1.8.0_345-b01 | | Max. process+thread count | 140 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4837/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-17099) Is there a plan to support auth connection by username/password like mysql or redis
[
https://issues.apache.org/jira/browse/HBASE-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623591#comment-17623591
]
Jack Yang commented on HBASE-17099:
---
Is the patch available now?
> Is there a plan to support auth connection by username/password like mysql or
> redis
> ---
>
> Key: HBASE-17099
> URL: https://issues.apache.org/jira/browse/HBASE-17099
> Project: HBase
> Issue Type: Brainstorming
> Components: security
>Reporter: liubangchen
>Priority: Trivial
>
> Product managers ask our hbase cluster to support auth connection by
> username/password.
> {code}
> private boolean authorizeConnection() throws IOException {
> try {
> // If auth method is DIGEST, the token was obtained by the
> // real user for the effective user, therefore not required to
> // authorize real user. doAs is allowed only for simple or kerberos
> // authentication
> if (user != null && user.getRealUser() != null
> && (authMethod != AuthMethod.DIGEST)) {
> ProxyUsers.authorize(user, this.getHostAddress(), conf);
> }
> authorize(user, connectionHeader, getHostInetAddress());
> metrics.authorizationSuccess();
> } catch (AuthorizationException ae) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Connection authorization failed: " + ae.getMessage(),
> ae);
> }
> metrics.authorizationFailure();
> setupResponse(authFailedResponse, authFailedCall,
> new AccessDeniedException(ae), ae.getMessage());
> responder.doRespond(authFailedCall);
> return false;
> }
> return true;
> }
> {code}
> Whether can add a connectionAuthorrizer in method authorizeConnection of
> class RpcServer to auth connection by init the handler from conf.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] ndimiduk commented on pull request #4844: HBASE-27442 Change the way of bumping version in release scripts
ndimiduk commented on PR #4844: URL: https://github.com/apache/hbase/pull/4844#issuecomment-1290067564 Yes good point. We also need to consider correct behavior for releasing our other projects. I've never released from our other repositories before. Let me spend some time on it, will propose a solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
