[GitHub] [hbase] ydodeja365 commented on pull request #5144: HBASE-27693 Support for Hadoop's LDAP Authentication mechanism
ydodeja365 commented on PR #5144: URL: https://github.com/apache/hbase/pull/5144#issuecomment-1498521003 Failures in pipeline are not relevant to this commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27662) Correct the line logged with flag hbase.procedure.upgrade-to-2-2 in docs
[ https://issues.apache.org/jira/browse/HBASE-27662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709207#comment-17709207 ] Yash Dodeja commented on HBASE-27662: - [~zhangduo] Thank you! > Correct the line logged with flag hbase.procedure.upgrade-to-2-2 in docs > > > Key: HBASE-27662 > URL: https://issues.apache.org/jira/browse/HBASE-27662 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Yash Dodeja >Assignee: Yash Dodeja >Priority: Minor > Fix For: 3.0.0-alpha-4 > > > The https://hbase.apache.org/book.html#upgrade2.2 doc says to search for a > "READY TO ROLLING UPGRADE" log in master after setting the flag whereas no > such log exists. The actual log line indicating that procedure store is empty > is "UPGRADE OK: All existed procedures have been finished, quit..." -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] mwkang commented on a diff in pull request #4720: HBASE-27315 Add timeout to JavaRegexEngine
mwkang commented on code in PR #4720:
URL: https://github.com/apache/hbase/pull/4720#discussion_r1159195873
##
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java:
##
@@ -255,11 +258,20 @@ static interface Engine {
* This is the default engine.
*/
static class JavaRegexEngine implements Engine {
+private static final Configuration conf = HBaseConfiguration.create();
Review Comment:
@Apache9
I think it is possible.
`RSRpcService` pass configuration to `ProtobufUtil`.
https://github.com/apache/hbase/blob/f27823e62ddea58e827f68bb75289dbe13a1bd37/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L2456
->
```java
Get clientGet = ProtobufUtil.toGet(get, regionServer.conf);
```
`ProtobufUtil#toComparator` pass configuration to `ByteArrayComparable` when
calling parseFrom method.
https://github.com/apache/hbase/blob/f27823e62ddea58e827f68bb75289dbe13a1bd37/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L1559
->
```java
public static ByteArrayComparable toComparator(ComparatorProtos.Comparator
proto, Configuration conf) {
return (ByteArrayComparable)parseFrom.invoke(null, value, conf);
}
```
I'll try to make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (HBASE-27781) AssertionError in AsyncRequestFutureImpl when timing out during location resolution
Bryan Beaudreault created HBASE-27781: - Summary: AssertionError in AsyncRequestFutureImpl when timing out during location resolution Key: HBASE-27781 URL: https://issues.apache.org/jira/browse/HBASE-27781 Project: HBase Issue Type: Bug Reporter: Bryan Beaudreault In AsyncFutureRequestImpl we fail fast when operation timeout is exceeded during location resolution [here|https://github.com/apache/hbase/blob/branch-2.5/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java#L460-L462]. In that handling, we loop all actions and set them as failed. The problem is, some number of actions may already finished when we get to this spot. So the actionsInProgress would have been decremented for those already, and now we're going to decrement by all actions. This causes an assertion error since we go negative [here|https://github.com/apache/hbase/blob/branch-2.5/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java#L1197] We still want to fail all actions, because none will be executed. But we need special handling to avoid this case. Maybe don't bother decrementing the actionsInProgress at all, instead set to 0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5157: HBASE-27775 Use a separate WAL provider for hbase:replication table
Apache-HBase commented on PR #5157: URL: https://github.com/apache/hbase/pull/5157#issuecomment-1498322243 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-27109/table_based_rqs Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 48s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | compile | 2m 45s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | checkstyle | 0m 41s | HBASE-27109/table_based_rqs passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 49s | HBASE-27109/table_based_rqs passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 32s | the patch passed | | +1 :green_heart: | compile | 2m 40s | the patch passed | | +1 :green_heart: | javac | 2m 40s | the patch passed | | +1 :green_heart: | checkstyle | 0m 39s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 2s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 42m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5157 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 9171c915f202 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-27109/table_based_rqs / f78fe5994a | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 81 (vs. ulimit of 3) | | modules | C: hbase-replication hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a diff in pull request #5155: HBASE-27536: add Scan to slow log payload
virajjasani commented on code in PR #5155:
URL: https://github.com/apache/hbase/pull/5155#discussion_r1159126757
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/OnlineLogRecord.java:
##
@@ -136,11 +153,20 @@ public int getMultiServiceCalls() {
return multiServiceCalls;
}
- private OnlineLogRecord(final long startTime, final int processingTime,
final int queueTime,
+ /**
+ * If {@value
org.apache.hadoop.hbase.HConstants#SLOW_LOG_SCAN_PAYLOAD_ENABLED} is enabled
then
+ * this value may be present and should represent the Scan that produced the
given
+ * {@link OnlineLogRecord}
+ */
+ public Optional getScan() {
+return scan;
+ }
+
+ protected OnlineLogRecord(final long startTime, final int processingTime,
final int queueTime,
Review Comment:
nit: remove `protected`
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/OnlineLogRecord.java:
##
@@ -52,6 +59,15 @@ final public class OnlineLogRecord extends LogEntry {
if (slowLogPayload.getMultiServiceCalls() == 0) {
jsonObj.remove("multiServiceCalls");
}
+if (slowLogPayload.getScan().isPresent()) {
+ try {
+jsonObj.add("scan",
JsonParser.parseString(slowLogPayload.getScan().get().toJSON()));
+ } catch (IOException e) {
+LOG.warn("Failed to serialize scan {}",
slowLogPayload.getScan().get(), e);
Review Comment:
Will this print byte[] ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-27774) Move Dockerfile and python-requirements.txt used only by flaky-tests job
[
https://issues.apache.org/jira/browse/HBASE-27774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709073#comment-17709073
]
Hudson commented on HBASE-27774:
Results for branch master
[build #811 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/811/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/811/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/811/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/811/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move Dockerfile and python-requirements.txt used only by flaky-tests job
>
>
> Key: HBASE-27774
> URL: https://issues.apache.org/jira/browse/HBASE-27774
> Project: HBase
> Issue Type: Task
> Components: build, community, documentation
>Affects Versions: 3.0.0-alpha-4
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0-alpha-4
>
>
> We have a Dockerfile floating around in dev-support. It looks like it's only
> used by the flaky-test Jenkins job, so move it under that directory. I think
> that it used to be used in multiple places, as way to package up the
> dev-support/python-requirements.txt file. However, that too seems to only be
> used by the flaky-tests job, so move it as well. Update the job for the new
> invocation form, and remove mentions of python-requirements.txt from the book
> -- an old, out-dated section about how to format patches for attachment to
> JIRA.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27765) Add biggest cell related info into web ui
[ https://issues.apache.org/jira/browse/HBASE-27765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708982#comment-17708982 ] Zheng Wang commented on HBASE-27765: Filled the release note yet. Thanks a lot for the review and push. [~zhangduo] > Add biggest cell related info into web ui > - > > Key: HBASE-27765 > URL: https://issues.apache.org/jira/browse/HBASE-27765 > Project: HBase > Issue Type: Improvement > Components: HFile, UI >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > Fix For: 2.6.0, 3.0.0-alpha-4 > > Attachments: screenshot-1.png, screenshot-2.png > > > There are some disadvantages to large cell, such as can't be cached or cause > memory fragmentation, but currently user can't easily to find them out. > My proposal is save len and key of the biggest cell into fileinfo of hfile, > and shown on web ui, including two places. > 1: Add "Len Of Biggest Cell" into main page of regionServer, in here we can > find out which regions has large cell by sorting. > 2: Add "Len Of Biggest Cell" and "Key Of Biggest Cell" into region page, in > here we can find out the exactly key and the hfile. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5158: HBASE-27778 Incorrect ReplicationSourceWALReader.totalBufferUsed may …
Apache-HBase commented on PR #5158: URL: https://github.com/apache/hbase/pull/5158#issuecomment-1497744915 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 1s | master passed | | +1 :green_heart: | compile | 0m 38s | master passed | | +1 :green_heart: | shadedjars | 4m 17s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 0m 38s | the patch passed | | +1 :green_heart: | javac | 0m 38s | the patch passed | | +1 :green_heart: | shadedjars | 4m 19s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 214m 32s | hbase-server in the patch passed. | | | | 236m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5158/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5158 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 43097088e1af 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5158/3/testReport/ | | Max. process+thread count | 2509 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5158/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27765) Add biggest cell related info into web ui
[ https://issues.apache.org/jira/browse/HBASE-27765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-27765: --- Release Note: Save len and key of the biggest cell into fileinfo when generate hfile, and shows them on webui for better monitor. > Add biggest cell related info into web ui > - > > Key: HBASE-27765 > URL: https://issues.apache.org/jira/browse/HBASE-27765 > Project: HBase > Issue Type: Improvement > Components: HFile, UI >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > Fix For: 2.6.0, 3.0.0-alpha-4 > > Attachments: screenshot-1.png, screenshot-2.png > > > There are some disadvantages to large cell, such as can't be cached or cause > memory fragmentation, but currently user can't easily to find them out. > My proposal is save len and key of the biggest cell into fileinfo of hfile, > and shown on web ui, including two places. > 1: Add "Len Of Biggest Cell" into main page of regionServer, in here we can > find out which regions has large cell by sorting. > 2: Add "Len Of Biggest Cell" and "Key Of Biggest Cell" into region page, in > here we can find out the exactly key and the hfile. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5158: HBASE-27778 Incorrect ReplicationSourceWALReader.totalBufferUsed may …
Apache-HBase commented on PR #5158: URL: https://github.com/apache/hbase/pull/5158#issuecomment-1497732355 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 26s | master passed | | +1 :green_heart: | compile | 0m 52s | master passed | | +1 :green_heart: | shadedjars | 5m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 4s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 205m 23s | hbase-server in the patch passed. | | | | 230m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5158/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5158 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ef86e2737d21 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5158/3/testReport/ | | Max. process+thread count | 2667 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5158/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[ https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708969#comment-17708969 ] Duo Zhang commented on HBASE-27109: --- Most development works have been done now. We still need to make the nightly more stable, and also add more documentation. Thanks. > Move replication queue storage from zookeeper to a separated HBase table > > > Key: HBASE-27109 > URL: https://issues.apache.org/jira/browse/HBASE-27109 > Project: HBase > Issue Type: New Feature > Components: Replication >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > This is a more specific issue based on the works which are already done in > HBASE-15867. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27623) Start a new ReplicationSyncUp after the previous failed
[ https://issues.apache.org/jira/browse/HBASE-27623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27623. --- Fix Version/s: HBASE-27109 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch HBASE-27109. Thanks [~heliangjun] for contributing! > Start a new ReplicationSyncUp after the previous failed > --- > > Key: HBASE-27623 > URL: https://issues.apache.org/jira/browse/HBASE-27623 > Project: HBase > Issue Type: Sub-task > Components: Replication, tooling >Reporter: Liangjun He >Assignee: Liangjun He >Priority: Major > Fix For: HBASE-27109 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 merged pull request #5150: HBASE-27623 Start a new ReplicationSyncUp after the previous failed
Apache9 merged PR #5150: URL: https://github.com/apache/hbase/pull/5150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #5150: HBASE-27623 Start a new ReplicationSyncUp after the previous failed
Apache9 commented on PR #5150: URL: https://github.com/apache/hbase/pull/5150#issuecomment-1497696219 The failed UT is TestClusterScopeQuotaThrottle, which should not be related, at least not related to the changes here. Let me merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-27662) Correct the line logged with flag hbase.procedure.upgrade-to-2-2 in docs
[ https://issues.apache.org/jira/browse/HBASE-27662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27662. --- Fix Version/s: 3.0.0-alpha-4 Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~yashdodeja] for contributing! > Correct the line logged with flag hbase.procedure.upgrade-to-2-2 in docs > > > Key: HBASE-27662 > URL: https://issues.apache.org/jira/browse/HBASE-27662 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Yash Dodeja >Assignee: Yash Dodeja >Priority: Minor > Fix For: 3.0.0-alpha-4 > > > The https://hbase.apache.org/book.html#upgrade2.2 doc says to search for a > "READY TO ROLLING UPGRADE" log in master after setting the flag whereas no > such log exists. The actual log line indicating that procedure store is empty > is "UPGRADE OK: All existed procedures have been finished, quit..." -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 commented on pull request #5159: HBASE-27662 Correct the line logged with flag hbase.procedure.upgrade-to-2-2 in docs
Apache9 commented on PR #5159: URL: https://github.com/apache/hbase/pull/5159#issuecomment-1497687911 Thanks for fixing this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #5159: HBASE-27662 Correct the line logged with flag hbase.procedure.upgrade-to-2-2 in docs
Apache9 merged PR #5159: URL: https://github.com/apache/hbase/pull/5159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-27765) Add biggest cell related info into web ui
[ https://issues.apache.org/jira/browse/HBASE-27765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27765. --- Fix Version/s: 2.6.0 Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~filtertip] for contributing! Please fill the release note about this change. Thanks. > Add biggest cell related info into web ui > - > > Key: HBASE-27765 > URL: https://issues.apache.org/jira/browse/HBASE-27765 > Project: HBase > Issue Type: Improvement > Components: HFile, UI >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > Fix For: 2.6.0, 3.0.0-alpha-4 > > Attachments: screenshot-1.png, screenshot-2.png > > > There are some disadvantages to large cell, such as can't be cached or cause > memory fragmentation, but currently user can't easily to find them out. > My proposal is save len and key of the biggest cell into fileinfo of hfile, > and shown on web ui, including two places. > 1: Add "Len Of Biggest Cell" into main page of regionServer, in here we can > find out which regions has large cell by sorting. > 2: Add "Len Of Biggest Cell" and "Key Of Biggest Cell" into region page, in > here we can find out the exactly key and the hfile. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27780) FileChangeWatcher improvements
[ https://issues.apache.org/jira/browse/HBASE-27780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27780: -- Description: HBASE-27347 ported FileChangeWatcher from ZK so that we can reload certificates when the keystore/truststore files change. I'd like to make a few improvements: # Add more context to the thread name, so that we can disambiguate when multiple are launched for different cluster connections or paths # We currently launch a separate FileChangeWatcher for each of keystorePath and truststorePath, but in many cases they may be the same path. The runnable which gets called is identical for these, so this just results in extra work for no reason. We should check the configured paths and only launch one FileChangeWatcher if the two paths are identical. # it currently watches the entire directory of the keystorePath. I could see this being useful if it could handle changes in various paths with a single watcher and only trigger the callback for the relevant path. That’s not what it does, so I think ideally it would just watch the file path. Or alternatively filter the events by the path. We put our keystores in the global tmp dir for various reasons, and as such this is triggering all the time for changes to totally unrelated paths in that global dir. was: HBASE-27347 ported FileChangeWatcher from ZK so that we can reload certificates when the keystore/truststore files change. I'd like to make a few improvements: # Add more context to the thread name, so that we can disambiguate when multiple are launched for different cluster connections or paths # We currently launch a separate FileChangeWatcher for each of keystorePath and truststorePath, but in many cases they may be the same path. The runnable which gets called is identical for these, so this just results in extra work for no reason. We should check the configured paths and only launch one FileChangeWatcher if the two paths are identical. > FileChangeWatcher improvements > -- > > Key: HBASE-27780 > URL: https://issues.apache.org/jira/browse/HBASE-27780 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Priority: Major > > HBASE-27347 ported FileChangeWatcher from ZK so that we can reload > certificates when the keystore/truststore files change. I'd like to make a > few improvements: > # Add more context to the thread name, so that we can disambiguate when > multiple are launched for different cluster connections or paths > # We currently launch a separate FileChangeWatcher for each of keystorePath > and truststorePath, but in many cases they may be the same path. The runnable > which gets called is identical for these, so this just results in extra work > for no reason. We should check the configured paths and only launch one > FileChangeWatcher if the two paths are identical. > # it currently watches the entire directory of the keystorePath. I could see > this being useful if it could handle changes in various paths with a single > watcher and only trigger the callback for the relevant path. That’s not what > it does, so I think ideally it would just watch the file path. Or > alternatively filter the events by the path. We put our keystores in the > global tmp dir for various reasons, and as such this is triggering all the > time for changes to totally unrelated paths in that global dir. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (HBASE-27776) Backport HBASE-27731 (Upgrade commons-validator to version 1.7) to branch-2.5
[ https://issues.apache.org/jira/browse/HBASE-27776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reopened HBASE-27776: --- > Backport HBASE-27731 (Upgrade commons-validator to version 1.7) to branch-2.5 > - > > Key: HBASE-27776 > URL: https://issues.apache.org/jira/browse/HBASE-27776 > Project: HBase > Issue Type: Task >Reporter: Wes Schuitema >Assignee: Wes Schuitema >Priority: Minor > > This is so we also fix these CVEs for 2.5 > - [CVE-2014-0114|https://nvd.nist.gov/vuln/detail/cve-2014-0114] > - [CVE-2019-10086|https://nvd.nist.gov/vuln/detail/cve-2019-10086] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27776) Backport HBASE-27731 (Upgrade commons-validator to version 1.7) to branch-2.5
[ https://issues.apache.org/jira/browse/HBASE-27776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-27776. --- Resolution: Invalid > Backport HBASE-27731 (Upgrade commons-validator to version 1.7) to branch-2.5 > - > > Key: HBASE-27776 > URL: https://issues.apache.org/jira/browse/HBASE-27776 > Project: HBase > Issue Type: Task >Reporter: Wes Schuitema >Assignee: Wes Schuitema >Priority: Minor > > This is so we also fix these CVEs for 2.5 > - [CVE-2014-0114|https://nvd.nist.gov/vuln/detail/cve-2014-0114] > - [CVE-2019-10086|https://nvd.nist.gov/vuln/detail/cve-2019-10086] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 commented on a diff in pull request #5158: HBASE-27778 Incorrect ReplicationSourceWALReader.totalBufferUsed may …
Apache9 commented on code in PR #5158:
URL: https://github.com/apache/hbase/pull/5158#discussion_r1158565853
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java:
##
@@ -145,43 +145,54 @@ public void run() {
source.getWALFileLengthProvider(), source.getSourceMetrics(),
walGroupId)) {
while (isReaderRunning()) { // loop here to keep reusing stream while
we can
batch = null;
- if (!source.isPeerEnabled()) {
-Threads.sleep(sleepForRetries);
-continue;
+ boolean successAddToQueue = false;
+ try {
+if (!source.isPeerEnabled()) {
+ Threads.sleep(sleepForRetries);
+ continue;
+}
+if (!checkQuota()) {
+ continue;
+}
+Path currentPath = entryStream.getCurrentPath();
+WALEntryStream.HasNext hasNext = entryStream.hasNext();
+if (hasNext == WALEntryStream.HasNext.NO) {
+ replicationDone();
+ return;
+}
+// first, check if we have switched a file, if so, we need to
manually add an EOF entry
+// batch to the queue
+if (currentPath != null && switched(entryStream, currentPath)) {
+ entryBatchQueue.put(WALEntryBatch.endOfFile(currentPath));
+ continue;
+}
+if (hasNext == WALEntryStream.HasNext.RETRY) {
+ // sleep and retry
+ sleepMultiplier = sleep(sleepMultiplier);
+ continue;
+}
+if (hasNext == WALEntryStream.HasNext.RETRY_IMMEDIATELY) {
+ // retry immediately, this usually means we have switched a file
+ continue;
+}
+// below are all for hasNext == YES
+batch = createBatch(entryStream);
+readWALEntries(entryStream, batch);
Review Comment:
Let's narrow the scope for the 'try catch' block? I think the only place
where we leak the WALEntryBatch is here, when calling readWALEntries, as it
could throw WALEntryFilterRetryableException, and only inside readWALEntries,
we will call acquireBufferQuota.
So I think we only need to use 'try catch' to wrap the readWALEntries, or at
least, wrap the code after createBatch, if you think
`entryBatchQueue.put(batch);` could also throw InterruptedException :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (HBASE-27780) FileChangeWatcher improvements
Bryan Beaudreault created HBASE-27780: - Summary: FileChangeWatcher improvements Key: HBASE-27780 URL: https://issues.apache.org/jira/browse/HBASE-27780 Project: HBase Issue Type: Improvement Reporter: Bryan Beaudreault HBASE-27347 ported FileChangeWatcher from ZK so that we can reload certificates when the keystore/truststore files change. I'd like to make a few improvements: # Add more context to the thread name, so that we can disambiguate when multiple are launched for different cluster connections or paths # We currently launch a separate FileChangeWatcher for each of keystorePath and truststorePath, but in many cases they may be the same path. The runnable which gets called is identical for these, so this just results in extra work for no reason. We should check the configured paths and only launch one FileChangeWatcher if the two paths are identical. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache9 commented on pull request #4827: HBASE-27422: Support replication for hbase:acl
Apache9 commented on PR #4827: URL: https://github.com/apache/hbase/pull/4827#issuecomment-1497516463 @taklwu Would you please merge this? I think you guys have some discussions offline so you would have more context on which branches should this PR go in. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 merged pull request #5151: HBASE-27765 Add biggest cell related info into web ui
Apache9 merged PR #5151: URL: https://github.com/apache/hbase/pull/5151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5158: HBASE-27778 Incorrect ReplicationSourceWALReader.totalBufferUsed may …
Apache-HBase commented on PR #5158: URL: https://github.com/apache/hbase/pull/5158#issuecomment-1497423703 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 17s | master passed | | +1 :green_heart: | compile | 2m 21s | master passed | | +1 :green_heart: | checkstyle | 0m 35s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 28s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | compile | 2m 21s | the patch passed | | +1 :green_heart: | javac | 2m 21s | the patch passed | | +1 :green_heart: | checkstyle | 0m 34s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 12s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 37m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5158/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5158 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 6d0add0e7c59 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5158/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5151: HBASE-27765 Add biggest cell related info into web ui
Apache-HBase commented on PR #5151: URL: https://github.com/apache/hbase/pull/5151#issuecomment-1497302321 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 35s | master passed | | +1 :green_heart: | compile | 0m 48s | master passed | | +1 :green_heart: | shadedjars | 4m 25s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | compile | 0m 47s | the patch passed | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | shadedjars | 4m 21s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 215m 55s | hbase-server in the patch passed. | | | | 239m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5151/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5151 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f7db23335a73 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5151/9/testReport/ | | Max. process+thread count | 2593 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5151/9/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5151: HBASE-27765 Add biggest cell related info into web ui
Apache-HBase commented on PR #5151: URL: https://github.com/apache/hbase/pull/5151#issuecomment-1497288370 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 42s | master passed | | +1 :green_heart: | compile | 0m 34s | master passed | | +1 :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 48s | the patch passed | | +1 :green_heart: | compile | 0m 35s | the patch passed | | +1 :green_heart: | javac | 0m 35s | the patch passed | | +1 :green_heart: | shadedjars | 4m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 206m 38s | hbase-server in the patch passed. | | | | 227m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5151/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5151 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1ca468e07ca6 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5151/9/testReport/ | | Max. process+thread count | 2466 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5151/9/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5155: HBASE-27536: add Scan to slow log payload
Apache-HBase commented on PR #5155: URL: https://github.com/apache/hbase/pull/5155#issuecomment-1497254196 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 19s | master passed | | +1 :green_heart: | compile | 2m 6s | master passed | | +1 :green_heart: | shadedjars | 4m 21s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 8s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | +1 :green_heart: | compile | 2m 3s | the patch passed | | +1 :green_heart: | javac | 2m 3s | the patch passed | | +1 :green_heart: | shadedjars | 4m 23s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 38s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 2m 7s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 1m 18s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 215m 20s | hbase-server in the patch passed. | | | | 247m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5155 | | JIRA Issue | HBASE-27536 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 294b9473cb04 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/5/testReport/ | | Max. process+thread count | 2560 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/5/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5155: HBASE-27536: add Scan to slow log payload
Apache-HBase commented on PR #5155: URL: https://github.com/apache/hbase/pull/5155#issuecomment-1497233921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 40s | master passed | | +1 :green_heart: | compile | 1m 26s | master passed | | +1 :green_heart: | shadedjars | 4m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 52s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 43s | the patch passed | | +1 :green_heart: | compile | 1m 26s | the patch passed | | +1 :green_heart: | javac | 1m 26s | the patch passed | | +1 :green_heart: | shadedjars | 4m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 27s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 43s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 202m 51s | hbase-server in the patch passed. | | | | 230m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5155 | | JIRA Issue | HBASE-27536 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6ae79af80bf0 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/5/testReport/ | | Max. process+thread count | 2683 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/5/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5159: HBASE-27662 Correct the line logged with flag hbase.procedure.upgrade-to-2-2 in docs
Apache-HBase commented on PR #5159: URL: https://github.com/apache/hbase/pull/5159#issuecomment-1497060557 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 21s | master passed | | +0 :ok: | refguide | 3m 42s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotless | 1m 0s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 56s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 3m 21s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotless | 1m 5s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. | | | | 23m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5159/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5159 | | Optional Tests | dupname asflicense refguide spotless | | uname | Linux fcc3cf3f7d2f 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5159/1/yetus-general-check/output/branch-site/book.html | | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5159/1/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5159/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5151: HBASE-27765 Add biggest cell related info into web ui
Apache-HBase commented on PR #5151: URL: https://github.com/apache/hbase/pull/5151#issuecomment-1497059538 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 40s | master passed | | +1 :green_heart: | compile | 2m 29s | master passed | | +1 :green_heart: | checkstyle | 0m 35s | master passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 31s | the patch passed | | +1 :green_heart: | compile | 2m 28s | the patch passed | | +1 :green_heart: | javac | 2m 28s | the patch passed | | +1 :green_heart: | checkstyle | 0m 33s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 44s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 7s | The patch does not generate ASF License warnings. | | | | 39m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5151/9/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5151 | | Optional Tests | dupname asflicense javac spotless spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3898a26228d3 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 80 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5151/9/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5159: HBASE-27662 Correct the line logged with flag hbase.procedure.upgrade-to-2-2 in docs
Apache-HBase commented on PR #5159: URL: https://github.com/apache/hbase/pull/5159#issuecomment-1497038464 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5159/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5159 | | Optional Tests | | | uname | Linux 811b17037ac1 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | Max. process+thread count | 29 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5159/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5159: HBASE-27662 Correct the line logged with flag hbase.procedure.upgrade-to-2-2 in docs
Apache-HBase commented on PR #5159: URL: https://github.com/apache/hbase/pull/5159#issuecomment-1497037957 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5159/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5159 | | Optional Tests | | | uname | Linux f5e9bfcfafe5 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | Max. process+thread count | 42 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5159/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5155: HBASE-27536: add Scan to slow log payload
Apache-HBase commented on PR #5155: URL: https://github.com/apache/hbase/pull/5155#issuecomment-1497015697 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 14s | master passed | | +1 :green_heart: | compile | 3m 54s | master passed | | +1 :green_heart: | checkstyle | 1m 1s | master passed | | +1 :green_heart: | spotless | 0m 37s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 4m 23s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 16s | the patch passed | | +1 :green_heart: | compile | 3m 59s | the patch passed | | +1 :green_heart: | cc | 3m 59s | the patch passed | | -0 :warning: | javac | 0m 34s | hbase-client generated 1 new + 36 unchanged - 0 fixed = 37 total (was 36) | | -0 :warning: | checkstyle | 0m 33s | hbase-server: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 41s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | hbaseprotoc | 1m 38s | the patch passed | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 0s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. | | | | 50m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5155 | | JIRA Issue | HBASE-27536 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool | | uname | Linux 85573a120d2b 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 308cdb08c7 | | Default Java | Eclipse Adoptium-11.0.17+8 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5155/5/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
