Apache9 commented on code in PR #5381: URL: https://github.com/apache/hbase/pull/5381#discussion_r1313830693
########## hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java: ########## @@ -670,11 +670,13 @@ public void takeSnapshot(SnapshotDescription snapshot) throws IOException { } } - public synchronized long takeSnapshot(SnapshotDescription snapshot, long nonceGroup, long nonce) + public long takeSnapshot(SnapshotDescription snapshot, long nonceGroup, long nonce) throws IOException { this.takingSnapshotLock.readLock().lock(); try { - return submitSnapshotProcedure(snapshot, nonceGroup, nonce); + synchronized(this){ Review Comment: I think we can just add a synchronized modifier on the submitSnapshotProcedure method? To align with other methods in the class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org