[jira] [Commented] (HBASE-28061) HBaseTestingUtility failed to start MiniHbaseCluster in case of Hadoop3.3.1
[
https://issues.apache.org/jira/browse/HBASE-28061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762979#comment-17762979
]
Ayush Saxena commented on HBASE-28061:
--
>From the full_output.txt
This looks like an NPE to me
```
Caused by: java.io.IOException: java.lang.NullPointerException
at
org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.shutdown(AbstractFSWAL.java:1012)
at
org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.close(AbstractFSWAL.java:1039)
at
org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:165)
... 13 more
Caused by: java.lang.NullPointerException
at
java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)
at
java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006)
at
org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.closeWriter(AsyncFSWAL.java:718)
at
org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.doShutdown(AsyncFSWAL.java:775)
at
org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$2.call(AbstractFSWAL.java:984)
at
org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$2.call(AbstractFSWAL.java:979)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
```
It is coming from the HBase code, may be some conflict with hadoop-3.3.x
release which hive uses vs 3.2.x which hbase uses
> HBaseTestingUtility failed to start MiniHbaseCluster in case of Hadoop3.3.1
> ---
>
> Key: HBASE-28061
> URL: https://issues.apache.org/jira/browse/HBASE-28061
> Project: HBase
> Issue Type: Bug
> Components: hadoop3, integration tests
>Reporter: zhangbutao
>Priority: Major
> Attachments: HbaseMiniClusterTest.java, full_output.txt, pom.xml
>
>
> Note: My test env is *Hadoop3.3.1* & Hbase2.5.5-hadoop3. And if I switch to
> *Hadoop3.1.4* or \{*}Hadoop3.2.4{*}, the test will be ok. I attached the
> source code and pom file.
>
> I just want to use *HBaseTestingUtility::startMiniHBaseCluster* to launch a
> mini hbase cluster in case of Hadoop.3.3.1, but failed with the following
> exception:
> {code:java}
> master.HMaster (MarkerIgnoringBase.java:error(159)) - Failed to become active
> master
> org.apache.hadoop.hbase.FailedCloseWALAfterInitializedErrorException: Failed
> close after init wal failed.
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:167)
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:62)
> at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:300)
> at
> org.apache.hadoop.hbase.master.region.MasterRegion.createWAL(MasterRegion.java:217)
> at
> org.apache.hadoop.hbase.master.region.MasterRegion.bootstrap(MasterRegion.java:240)
> at
> org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:398)
> at
> org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:132)
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:942)
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2405)
> at org.apache.hadoop.hbase.master.HMaster.lambda$null$0(HMaster.java:565)
> at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187)
> at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177)
> at org.apache.hadoop.hbase.master.HMaster.lambda$run$1(HMaster.java:562)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.io.IOException: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.shutdown(AbstractFSWAL.java:1012)
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.close(AbstractFSWAL.java:1039)
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:165)
> ... 13 more
> Caused by: java.lang.NullPointerException
> at
> java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)
> at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006)
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.closeWriter(AsyncFSWAL.java:718)
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.doShutdown(AsyncFSWAL.java:775)
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$2.call(AbstractFSWAL.java:984)
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$2.call(AbstractFSWAL.java:979)
> at java.util.concur
[GitHub] [hbase] bsglz commented on pull request #4390: HBASE-26987 The length of compact queue grows too big when the compac…
bsglz commented on PR #4390: URL: https://github.com/apache/hbase/pull/4390#issuecomment-1711391714 Ping @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.
bbeaudreault commented on code in PR #5228:
URL: https://github.com/apache/hbase/pull/5228#discussion_r1319809146
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncClientScanner.java:
##
@@ -172,6 +172,7 @@ private CompletableFuture
callOpenScanner(HBaseRpcControlle
}
CompletableFuture future = new
CompletableFuture<>();
try {
+controller.setTableName(loc.getRegion().getTable());
Review Comment:
I'm pretty sure this is unnecessary. This `callOpenScanner` ends up getting
called via AsyncSingleRequestRpcRetryingCaller, which does `resetCallTimeout()`
before calling the callable. So the change you made in that method should
handle this case
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:
##
@@ -121,7 +121,11 @@ protected final void resetCallTimeout() {
} else {
callTimeoutNs = rpcTimeoutNs;
}
-resetController(controller, callTimeoutNs, priority);
+if (getTableName().isPresent()) {
Review Comment:
could be simplified to one call, with `getTableName().orElse(null)`
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:
##
@@ -753,6 +787,40 @@ public void updateRpc(MethodDescriptor method, Message
param, CallStats stats, T
updateRpcGeneric(methodName.toString(), stats);
}
+ /** Report table rpc context to metrics system. */
+ private void updateTableMetric(String methodName, TableName tableName,
+HBaseProtos.RegionSpecifier regionSpecifier, Message param, CallStats
stats, Throwable e) {
+if (tableMetricsEnabled) {
+ if (methodName != null) {
+String table;
+if (tableName == null ||
StringUtils.isEmpty(tableName.getNameAsString())) {
+ // Fallback to get table name from region specifier.
Review Comment:
i think we can simplify this whole method (and above calls) now. I'm not
sure we need to handle fallback, since all cases should have a TableName in the
controller now. So we don't need to extract the region in updateRpc above, nor
do we have to to parse the tablename from the region here.
if we missed a spot, i think we'd consider that a bug and fix it. maybe you
could add end-to-end tests to ensure that each of the request types updates a
table metric?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (HBASE-28068) Normalizer should batch merging 0 sized regions
Ravi Kishore Valeti created HBASE-28068:
---
Summary: Normalizer should batch merging 0 sized regions
Key: HBASE-28068
URL: https://issues.apache.org/jira/browse/HBASE-28068
Project: HBase
Issue Type: Improvement
Components: Normalizer
Affects Versions: 2.5.5
Reporter: Ravi Kishore Valeti
Fix For: 2.6.0, 3.0.0
In our production environment, while investigating an issue, we observed that
the Noramlizer had scheduled one single merge procedure to an RS providing 27K+
empty regions of a table (this was a result of a failed copy table job that
left 27K+ empty regions of the table) to merge.
This action led the procedure to go to stuck state and eventually the procedure
framework bailed out after ~40mins. This was happening with each normalizer run
until we deleted the table manually.
Logs
Normalizer triggers a merge procedure
normalizer.RegionNormalizerWorker - NormalizationTarget[regionInfo=\{ENCODED =>
6e8606335a62f6bafceb017dc7edfdf5, NAME => 'TEST.TEST_TABLE,.', STARTKEY =>
'', ENDKEY => ''},{*}regionSizeMb=0{*}],
NormalizationTarget[regionInfo=\{ENCODED => 79607df308d7618e632abe8a12c1bf6b,
NAME => 'TEST.TEST_TABLE,', STARTKEY => 'XXYY', ENDKEY =>
'YYZZ'},{*}regionSizeMb=0]{*}]] resulting in *pid 21968356*
procedure immediately gets stuck
procedure2.ProcedureExecutor - Worker *stuck* PEWorker-56(pid=21968356), run
time 12.4850 sec
Finally fails after ~40 mins
procedure2.ProcedureExecutor - Worker *stuck* PEWorker-56(pid=21968356), run
time *40 mins, 58.055 sec*
Bails out with RuntimeException
procedure2.ProcedureExecutor - force=false
java.lang.UnsupportedOperationException: pid=21968356,
state=FAILED:MERGE_TABLE_REGIONS_UPDATE_META, locked=true,
exception=java.lang.{*}RuntimeException via CODE-BUG: Uncaught runtime
exception{*}: pid=21968356, state=RUNNABLE:MERGE_TABLE_REGIONS_UPDATE_META,
locked=true; MergeTableRegionsProcedure table=TEST.TEST_TABLE,
{*}regions={*}{*}[269a1b168af497cce9ba6d3d581568f2{*}
.
.
.
.
*27K+ regions printed here]*
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-28068) Normalizer should batch merging 0 sized/empty regions
[
https://issues.apache.org/jira/browse/HBASE-28068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Kishore Valeti updated HBASE-28068:
Summary: Normalizer should batch merging 0 sized/empty regions (was:
Normalizer should batch merging 0 sized regions)
> Normalizer should batch merging 0 sized/empty regions
> -
>
> Key: HBASE-28068
> URL: https://issues.apache.org/jira/browse/HBASE-28068
> Project: HBase
> Issue Type: Improvement
> Components: Normalizer
>Affects Versions: 2.5.5
>Reporter: Ravi Kishore Valeti
>Priority: Minor
> Fix For: 2.6.0, 3.0.0
>
>
> In our production environment, while investigating an issue, we observed that
> the Noramlizer had scheduled one single merge procedure to an RS providing
> 27K+ empty regions of a table (this was a result of a failed copy table job
> that left 27K+ empty regions of the table) to merge.
> This action led the procedure to go to stuck state and eventually the
> procedure framework bailed out after ~40mins. This was happening with each
> normalizer run until we deleted the table manually.
> Logs
> Normalizer triggers a merge procedure
> normalizer.RegionNormalizerWorker - NormalizationTarget[regionInfo=\{ENCODED
> => 6e8606335a62f6bafceb017dc7edfdf5, NAME => 'TEST.TEST_TABLE,.',
> STARTKEY => '', ENDKEY => ''},{*}regionSizeMb=0{*}],
> NormalizationTarget[regionInfo=\{ENCODED => 79607df308d7618e632abe8a12c1bf6b,
> NAME => 'TEST.TEST_TABLE,', STARTKEY => 'XXYY', ENDKEY =>
> 'YYZZ'},{*}regionSizeMb=0]{*}]] resulting in *pid 21968356*
> procedure immediately gets stuck
> procedure2.ProcedureExecutor - Worker *stuck* PEWorker-56(pid=21968356), run
> time 12.4850 sec
> Finally fails after ~40 mins
> procedure2.ProcedureExecutor - Worker *stuck* PEWorker-56(pid=21968356), run
> time *40 mins, 58.055 sec*
> Bails out with RuntimeException
> procedure2.ProcedureExecutor - force=false
> java.lang.UnsupportedOperationException: pid=21968356,
> state=FAILED:MERGE_TABLE_REGIONS_UPDATE_META, locked=true,
> exception=java.lang.{*}RuntimeException via CODE-BUG: Uncaught runtime
> exception{*}: pid=21968356, state=RUNNABLE:MERGE_TABLE_REGIONS_UPDATE_META,
> locked=true; MergeTableRegionsProcedure table=TEST.TEST_TABLE,
> {*}regions={*}{*}[269a1b168af497cce9ba6d3d581568f2{*}
> .
> .
> .
> .
> *27K+ regions printed here]*
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] ndimiduk commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases
ndimiduk commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1711851072 Added a new unit test that relies on a LocalFileSystem to mess with the hfile under the covers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases
Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1711873695 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | | -1 :x: | mvninstall | 1m 23s | root in branch-2.5 failed. | | -1 :x: | compile | 0m 22s | hbase-server in branch-2.5 failed. | | -1 :x: | shadedjars | 3m 14s | branch has 16 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 1s | root in the patch failed. | | -1 :x: | compile | 0m 22s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 22s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 3m 11s | patch has 16 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 24s | hbase-server in the patch failed. | | | | 12m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5384 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0fcebd90e598 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 4c1fd0d2e8 | | Default Java | Temurin-1.8.0_352-b08 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk8-hadoop2-check/output/branch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk8-hadoop2-check/output/branch-shadedjars.txt | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/testReport/ | | Max. process+thread count | 58 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases
Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1711874779 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.5 Compile Tests _ | | -1 :x: | mvninstall | 1m 31s | root in branch-2.5 failed. | | -1 :x: | compile | 0m 29s | hbase-server in branch-2.5 failed. | | +1 :green_heart: | checkstyle | 0m 32s | branch-2.5 passed | | +1 :green_heart: | spotless | 0m 40s | branch has no errors when running spotless:check. | | -1 :x: | spotbugs | 0m 27s | hbase-server in branch-2.5 failed. | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 15s | root in the patch failed. | | -1 :x: | compile | 0m 26s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 26s | hbase-server in the patch failed. | | -0 :warning: | checkstyle | 0m 33s | hbase-server: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 1m 18s | The patch causes 16 errors with Hadoop v2.10.2. | | -1 :x: | hadoopcheck | 2m 47s | The patch causes 16 errors with Hadoop v3.2.4. | | -1 :x: | hadoopcheck | 4m 22s | The patch causes 16 errors with Hadoop v3.3.5. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | | -1 :x: | spotbugs | 0m 24s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 13m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5384 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux d10fdf566a4e 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 4c1fd0d2e8 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/branch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/branch-compile-hbase-server.txt | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server.txt | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/patch-javac-2.10.2.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/patch-javac-3.2.4.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/patch-javac-3.3.5.txt | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an au
[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases
Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1711875338 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | | -1 :x: | mvninstall | 1m 34s | root in branch-2.5 failed. | | -1 :x: | compile | 0m 25s | hbase-server in branch-2.5 failed. | | -1 :x: | shadedjars | 3m 30s | branch has 16 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 11s | root in the patch failed. | | -1 :x: | compile | 0m 26s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 26s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 3m 31s | patch has 16 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 0m 27s | hbase-server in the patch failed. | | | | 13m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5384 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux dc700c653440 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 4c1fd0d2e8 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/testReport/ | | Max. process+thread count | 73 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.
zhuyaogai commented on code in PR #5228:
URL: https://github.com/apache/hbase/pull/5228#discussion_r1320499288
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:
##
@@ -753,6 +787,40 @@ public void updateRpc(MethodDescriptor method, Message
param, CallStats stats, T
updateRpcGeneric(methodName.toString(), stats);
}
+ /** Report table rpc context to metrics system. */
+ private void updateTableMetric(String methodName, TableName tableName,
+HBaseProtos.RegionSpecifier regionSpecifier, Message param, CallStats
stats, Throwable e) {
+if (tableMetricsEnabled) {
+ if (methodName != null) {
+String table;
+if (tableName == null ||
StringUtils.isEmpty(tableName.getNameAsString())) {
+ // Fallback to get table name from region specifier.
Review Comment:
@bbeaudreault hi, I have already modified the code according to your
requirements. Could you continue the code review for me if you are available?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
