[jira] [Commented] (HBASE-28605) Add ErrorProne ban on Hadoop shaded thirdparty jars
[ https://issues.apache.org/jira/browse/HBASE-28605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849189#comment-17849189 ] Hudson commented on HBASE-28605: Results for branch branch-2.6 [build #125 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/125/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/125/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/125/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/125/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/125/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Add ErrorProne ban on Hadoop shaded thirdparty jars > --- > > Key: HBASE-28605 > URL: https://issues.apache.org/jira/browse/HBASE-28605 > Project: HBase > Issue Type: Task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Labels: pull-request-available > Fix For: 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9 > > > Over on HBASE-28568 we got tripped up because we pulled in the shaded Guava > provided by Hadoop. This wasn't noticed until the backport to branch-2, which > builds against hadoop-2. We should make this a compile time failure. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28605) Add ErrorProne ban on Hadoop shaded thirdparty jars
[ https://issues.apache.org/jira/browse/HBASE-28605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849186#comment-17849186 ] Hudson commented on HBASE-28605: Results for branch branch-2 [build #1063 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1063/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1063/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1063/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1063/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1063/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Add ErrorProne ban on Hadoop shaded thirdparty jars > --- > > Key: HBASE-28605 > URL: https://issues.apache.org/jira/browse/HBASE-28605 > Project: HBase > Issue Type: Task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Labels: pull-request-available > Fix For: 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9 > > > Over on HBASE-28568 we got tripped up because we pulled in the shaded Guava > provided by Hadoop. This wasn't noticed until the backport to branch-2, which > builds against hadoop-2. We should make this a compile time failure. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28605) Add ErrorProne ban on Hadoop shaded thirdparty jars
[ https://issues.apache.org/jira/browse/HBASE-28605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849184#comment-17849184 ] Hudson commented on HBASE-28605: Results for branch branch-3 [build #212 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/212/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/212/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/212/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/212/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Add ErrorProne ban on Hadoop shaded thirdparty jars > --- > > Key: HBASE-28605 > URL: https://issues.apache.org/jira/browse/HBASE-28605 > Project: HBase > Issue Type: Task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Labels: pull-request-available > Fix For: 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9 > > > Over on HBASE-28568 we got tripped up because we pulled in the shaded Guava > provided by Hadoop. This wasn't noticed until the backport to branch-2, which > builds against hadoop-2. We should make this a compile time failure. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28605) Add ErrorProne ban on Hadoop shaded thirdparty jars
[ https://issues.apache.org/jira/browse/HBASE-28605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849146#comment-17849146 ] Hudson commented on HBASE-28605: Results for branch branch-2.5 [build #535 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/535/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/535/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/535/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/535/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/535/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Add ErrorProne ban on Hadoop shaded thirdparty jars > --- > > Key: HBASE-28605 > URL: https://issues.apache.org/jira/browse/HBASE-28605 > Project: HBase > Issue Type: Task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Labels: pull-request-available > Fix For: 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9 > > > Over on HBASE-28568 we got tripped up because we pulled in the shaded Guava > provided by Hadoop. This wasn't noticed until the backport to branch-2, which > builds against hadoop-2. We should make this a compile time failure. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28335 Expose CacheStats ageAtEviction histogram in jmx [hbase]
Apache-HBase commented on PR #5942: URL: https://github.com/apache/hbase/pull/5942#issuecomment-2127945298 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 51s | master passed | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | shadedjars | 6m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | compile | 1m 14s | the patch passed | | +1 :green_heart: | javac | 1m 14s | the patch passed | | +1 :green_heart: | shadedjars | 6m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 38s | hbase-hadoop-compat in the patch passed. | | -1 :x: | unit | 354m 33s | hbase-server in the patch failed. | | | | 383m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5942 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6233723bd20d 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5b581686d | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/testReport/ | | Max. process+thread count | 4482 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28577) Remove deprecated methods in KeyValue
[ https://issues.apache.org/jira/browse/HBASE-28577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849092#comment-17849092 ] Hudson commented on HBASE-28577: Results for branch master [build #1079 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1079/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1079/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1079/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1079/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Remove deprecated methods in KeyValue > - > > Key: HBASE-28577 > URL: https://issues.apache.org/jira/browse/HBASE-28577 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: lixiaobao >Priority: Major > Labels: pull-request-available > Fix For: 3.0.0-beta-2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27915) Update hbase_docker with an extra Dockerfile compatible with mac m1 platfrom
[ https://issues.apache.org/jira/browse/HBASE-27915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849093#comment-17849093 ] Hudson commented on HBASE-27915: Results for branch master [build #1079 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1079/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1079/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1079/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1079/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Update hbase_docker with an extra Dockerfile compatible with mac m1 platfrom > > > Key: HBASE-27915 > URL: https://issues.apache.org/jira/browse/HBASE-27915 > Project: HBase > Issue Type: Bug >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Labels: pull-request-available > > When trying to use the current Dockerfile under "./dev-support/hbase_docker" > on m1 macs, the docker build fails at the git clone & mvn build stage with > below error: > {noformat} > #0 8.214 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such > file or directory > {noformat} > It turns out for mac m1, we have to explicitly define the platform flag for > the ubuntu image. I thought we could add a note in this readme, together with > an "m1" subfolder containing a modified copy of this Dockerfile that works on > mac m1s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28335 Expose CacheStats ageAtEviction histogram in jmx [hbase]
Apache-HBase commented on PR #5942: URL: https://github.com/apache/hbase/pull/5942#issuecomment-2127914185 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 10s | master passed | | +1 :green_heart: | compile | 1m 24s | master passed | | +1 :green_heart: | shadedjars | 6m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 54s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 52s | the patch passed | | +1 :green_heart: | compile | 1m 25s | the patch passed | | +1 :green_heart: | javac | 1m 25s | the patch passed | | +1 :green_heart: | shadedjars | 6m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 2s | hbase-hadoop-compat in the patch passed. | | -1 :x: | unit | 331m 20s | hbase-server in the patch failed. | | | | 362m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5942 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6b2bbfec02c9 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5b581686d | | Default Java | Eclipse Adoptium-17.0.10+7 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/testReport/ | | Max. process+thread count | 4752 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27915) Update hbase_docker with an extra Dockerfile compatible with mac m1 platfrom
[ https://issues.apache.org/jira/browse/HBASE-27915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849079#comment-17849079 ] Hudson commented on HBASE-27915: Results for branch branch-3 [build #211 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/211/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/211/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/211/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/211/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Update hbase_docker with an extra Dockerfile compatible with mac m1 platfrom > > > Key: HBASE-27915 > URL: https://issues.apache.org/jira/browse/HBASE-27915 > Project: HBase > Issue Type: Bug >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Labels: pull-request-available > > When trying to use the current Dockerfile under "./dev-support/hbase_docker" > on m1 macs, the docker build fails at the git clone & mvn build stage with > below error: > {noformat} > #0 8.214 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such > file or directory > {noformat} > It turns out for mac m1, we have to explicitly define the platform flag for > the ubuntu image. I thought we could add a note in this readme, together with > an "m1" subfolder containing a modified copy of this Dockerfile that works on > mac m1s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28577) Remove deprecated methods in KeyValue
[ https://issues.apache.org/jira/browse/HBASE-28577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849078#comment-17849078 ] Hudson commented on HBASE-28577: Results for branch branch-3 [build #211 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/211/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/211/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/211/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/211/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Remove deprecated methods in KeyValue > - > > Key: HBASE-28577 > URL: https://issues.apache.org/jira/browse/HBASE-28577 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: lixiaobao >Priority: Major > Labels: pull-request-available > Fix For: 3.0.0-beta-2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27915) Update hbase_docker with an extra Dockerfile compatible with mac m1 platfrom
[ https://issues.apache.org/jira/browse/HBASE-27915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849068#comment-17849068 ] Hudson commented on HBASE-27915: Results for branch branch-2.5 [build #534 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/534/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/534/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/534/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/534/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/534/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Update hbase_docker with an extra Dockerfile compatible with mac m1 platfrom > > > Key: HBASE-27915 > URL: https://issues.apache.org/jira/browse/HBASE-27915 > Project: HBase > Issue Type: Bug >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Labels: pull-request-available > > When trying to use the current Dockerfile under "./dev-support/hbase_docker" > on m1 macs, the docker build fails at the git clone & mvn build stage with > below error: > {noformat} > #0 8.214 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such > file or directory > {noformat} > It turns out for mac m1, we have to explicitly define the platform flag for > the ubuntu image. I thought we could add a note in this readme, together with > an "m1" subfolder containing a modified copy of this Dockerfile that works on > mac m1s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28335 Expose CacheStats ageAtEviction histogram in jmx [hbase]
Apache-HBase commented on PR #5942: URL: https://github.com/apache/hbase/pull/5942#issuecomment-2127767790 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 58s | master passed | | +1 :green_heart: | compile | 1m 6s | master passed | | +1 :green_heart: | shadedjars | 5m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 44s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 5m 8s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 39s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 235m 48s | hbase-server in the patch passed. | | | | 261m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5942 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2f3815027115 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5b581686d | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/testReport/ | | Max. process+thread count | 4746 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2127439225 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +1 :green_heart: | compile | 0m 26s | master passed | | +1 :green_heart: | shadedjars | 6m 40s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 40s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed | | +1 :green_heart: | javac | 0m 21s | the patch passed | | +1 :green_heart: | shadedjars | 6m 42s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-rest generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 5m 3s | hbase-rest in the patch passed. | | | | 29m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5943 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 25bdf3f9912e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5b581686d | | Default Java | Eclipse Adoptium-11.0.17+8 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-rest.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/testReport/ | | Max. process+thread count | 1667 (vs. ulimit of 3) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2127433769 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 9s | master passed | | +1 :green_heart: | compile | 0m 20s | master passed | | +1 :green_heart: | shadedjars | 6m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | compile | 0m 23s | the patch passed | | +1 :green_heart: | javac | 0m 23s | the patch passed | | +1 :green_heart: | shadedjars | 6m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 4m 19s | hbase-rest in the patch passed. | | | | 26m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5943 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0994b4069d7d 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5b581686d | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/testReport/ | | Max. process+thread count | 1519 (vs. ulimit of 3) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2127429785 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 24s | master passed | | +1 :green_heart: | compile | 0m 22s | master passed | | +1 :green_heart: | shadedjars | 5m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 0s | the patch passed | | +1 :green_heart: | compile | 0m 18s | the patch passed | | +1 :green_heart: | javac | 0m 18s | the patch passed | | +1 :green_heart: | shadedjars | 5m 51s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 13s | hbase-rest generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 44s | hbase-rest in the patch passed. | | | | 24m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5943 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 350249c0a0d3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5b581686d | | Default Java | Eclipse Adoptium-17.0.10+7 | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/artifact/yetus-jdk17-hadoop3-check/output/diff-javadoc-javadoc-hbase-rest.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/testReport/ | | Max. process+thread count | 1698 (vs. ulimit of 3) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]
Apache-HBase commented on PR #5943: URL: https://github.com/apache/hbase/pull/5943#issuecomment-2127423289 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 57s | master passed | | +1 :green_heart: | compile | 0m 26s | master passed | | +1 :green_heart: | checkstyle | 0m 10s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 28s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 44s | the patch passed | | +1 :green_heart: | compile | 0m 25s | the patch passed | | +1 :green_heart: | javac | 0m 25s | the patch passed | | +1 :green_heart: | checkstyle | 0m 9s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 12s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 21m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5943 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 6fe40d69f8f2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5b581686d | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5943/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28613) Use streaming when marshalling protobuf REST output
[ https://issues.apache.org/jira/browse/HBASE-28613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated HBASE-28613: Status: Patch Available (was: Open) > Use streaming when marshalling protobuf REST output > --- > > Key: HBASE-28613 > URL: https://issues.apache.org/jira/browse/HBASE-28613 > Project: HBase > Issue Type: Improvement > Components: REST >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Labels: pull-request-available > > We are currently marshalling protobuf into a byte array, and then send that > to the client. > This is both slow and memory intensive. > I see a ~25% reduction in the REST server CPU usage for my benchmark with > this patch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28613) Use streaming when marshalling protobuf REST output
[ https://issues.apache.org/jira/browse/HBASE-28613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28613: --- Labels: pull-request-available (was: ) > Use streaming when marshalling protobuf REST output > --- > > Key: HBASE-28613 > URL: https://issues.apache.org/jira/browse/HBASE-28613 > Project: HBase > Issue Type: Improvement > Components: REST >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Labels: pull-request-available > > We are currently marshalling protobuf into a byte array, and then send that > to the client. > This is both slow and memory intensive. > I see a ~25% reduction in the REST server CPU usage for my benchmark with > this patch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] HBASE-28613 Use streaming when marshalling protobuf REST output [hbase]
stoty opened a new pull request, #5943: URL: https://github.com/apache/hbase/pull/5943 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28335 Expose CacheStats ageAtEviction histogram in jmx [hbase]
Apache-HBase commented on PR #5942: URL: https://github.com/apache/hbase/pull/5942#issuecomment-2127281751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 3s | master passed | | +1 :green_heart: | compile | 3m 56s | master passed | | +1 :green_heart: | checkstyle | 0m 53s | master passed | | +1 :green_heart: | spotless | 1m 3s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 47s | the patch passed | | +1 :green_heart: | compile | 3m 38s | the patch passed | | +1 :green_heart: | javac | 3m 38s | the patch passed | | +1 :green_heart: | checkstyle | 0m 56s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 6m 59s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 58s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 41m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5942 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 0d771a65cfa1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5b581686d | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-hadoop-compat hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5942/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28613) Use streaming when marshalling protobuf REST output
[ https://issues.apache.org/jira/browse/HBASE-28613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848961#comment-17848961 ] Istvan Toth commented on HBASE-28613: - By using CodedOutputStream directly, I was able to further improve performance by avoiding pre-computing the object size and tuning the buffer size in CodedOutputStream. > Use streaming when marshalling protobuf REST output > --- > > Key: HBASE-28613 > URL: https://issues.apache.org/jira/browse/HBASE-28613 > Project: HBase > Issue Type: Improvement > Components: REST >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > We are currently marshalling protobuf into a byte array, and then send that > to the client. > This is both slow and memory intensive. > I see a ~25% reduction in the REST server CPU usage for my benchmark with > this patch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28613) Use streaming when marshalling protobuf REST output
[ https://issues.apache.org/jira/browse/HBASE-28613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated HBASE-28613: Description: We are currently marshalling protobuf into a byte array, and then send that to the client. This is both slow and memory intensive. I see a ~25% reduction in the REST server CPU usage for my benchmark with this patch. was: We are currently marshalling protobuf into a byte array, and then send that to the client. This is both slow and memory intensive. I see a ~15% reduction in the REST server CPU usage for my benchmark with this patch. > Use streaming when marshalling protobuf REST output > --- > > Key: HBASE-28613 > URL: https://issues.apache.org/jira/browse/HBASE-28613 > Project: HBase > Issue Type: Improvement > Components: REST >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > We are currently marshalling protobuf into a byte array, and then send that > to the client. > This is both slow and memory intensive. > I see a ~25% reduction in the REST server CPU usage for my benchmark with > this patch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28335) Expose CacheStats ageAtEviction histogram in jmx
[ https://issues.apache.org/jira/browse/HBASE-28335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28335: --- Labels: pull-request-available (was: ) > Expose CacheStats ageAtEviction histogram in jmx > > > Key: HBASE-28335 > URL: https://issues.apache.org/jira/browse/HBASE-28335 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Chandra Sekhar K >Priority: Major > Labels: pull-request-available > > In CacheStats we keep track of the ageAtEviction in a histogram. This is > exposed in the UI, but not via jmx. Expose via jmx as well for easier > tracking over time. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Hbase 28467 Fix Unit test [hbase]
Apache-HBase commented on PR #5941: URL: https://github.com/apache/hbase/pull/5941#issuecomment-2126793676 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-28463 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 43s | HBASE-28463 passed | | +1 :green_heart: | compile | 0m 40s | HBASE-28463 passed | | +1 :green_heart: | shadedjars | 5m 40s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | HBASE-28463 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 24s | the patch passed | | +1 :green_heart: | compile | 0m 38s | the patch passed | | +1 :green_heart: | javac | 0m 38s | the patch passed | | +1 :green_heart: | shadedjars | 5m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 22s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 268m 40s | hbase-server in the patch failed. | | | | 292m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5941/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5941 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 50b37cdef6e3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-28463 / 3a701b933e | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5941/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5941/1/testReport/ | | Max. process+thread count | 4780 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5941/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Hbase 28467 Fix Unit test [hbase]
Apache-HBase commented on PR #5941: URL: https://github.com/apache/hbase/pull/5941#issuecomment-2126783407 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-28463 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 0s | HBASE-28463 passed | | +1 :green_heart: | compile | 0m 49s | HBASE-28463 passed | | +1 :green_heart: | shadedjars | 5m 18s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 28s | HBASE-28463 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | compile | 0m 50s | the patch passed | | +1 :green_heart: | javac | 0m 50s | the patch passed | | +1 :green_heart: | shadedjars | 5m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 262m 24s | hbase-server in the patch failed. | | | | 287m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5941/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5941 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c77aa8ce650e 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-28463 / 3a701b933e | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5941/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5941/1/testReport/ | | Max. process+thread count | 4951 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5941/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-28614) Introduce a field to display whether the snapshot is expired
guluo created HBASE-28614: - Summary: Introduce a field to display whether the snapshot is expired Key: HBASE-28614 URL: https://issues.apache.org/jira/browse/HBASE-28614 Project: HBase Issue Type: Improvement Components: shell, snapshots, UI Environment: hbase master Reporter: guluo HBase supports to create snapshot with TTL, and expired snapshots will be periodically deleted. This period is 30 min by default, as follow. {code:java} private static final String SNAPSHOT_CLEANER_INTERVAL = "hbase.master.cleaner.snapshot.interval"; private static final int SNAPSHOT_CLEANER_DEFAULT_INTERVAL = 1800 * 1000; // Default 30 min {code} Therefore, the following situation may occur: The expired snapshot would still exist for a period of time on hbase cluster, and would not be deleted until the next operation of the periodic thread. So, Sometimes, we may use the expired snapshot because we donot know whether the snapshot is expired. So, I think we can introduce a expired field for this situation in HBase UI. And on hbase shell ,adding snapshot TTL info and displaying expired if the snaphost has already expired. Or any better suggestions? Thanks a lot! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-23578) [UI] Master UI shows long stack traces when table is broken
[ https://issues.apache.org/jira/browse/HBASE-23578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuhei Yamasaki reassigned HBASE-23578: --- Assignee: Shuhei Yamasaki (was: Shuhei Yamasaki) > [UI] Master UI shows long stack traces when table is broken > --- > > Key: HBASE-23578 > URL: https://issues.apache.org/jira/browse/HBASE-23578 > Project: HBase > Issue Type: Improvement > Components: master, UI >Reporter: Shuhei Yamasaki >Assignee: Shuhei Yamasaki >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.5, 2.4.2 > > Attachments: stackCompact1_short.png, table_jsp.png > > > The table.jsp in Master UI shows long stack traces when table is broken. > (shown as table_jsp.png) > This messages are hard to read and web page is very wide because stack traces > displayed in a single line. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28613) Use streaming when marshalling protobuf REST output
[ https://issues.apache.org/jira/browse/HBASE-28613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848886#comment-17848886 ] Istvan Toth commented on HBASE-28613: - Updated the description with the correct (less spectacular) benchmark results. > Use streaming when marshalling protobuf REST output > --- > > Key: HBASE-28613 > URL: https://issues.apache.org/jira/browse/HBASE-28613 > Project: HBase > Issue Type: Improvement > Components: REST >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > We are currently marshalling protobuf into a byte array, and then send that > to the client. > This is both slow and memory intensive. > I see a ~15% reduction in the REST server CPU usage for my benchmark with > this patch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28613) Use streaming when marshalling protobuf REST output
[ https://issues.apache.org/jira/browse/HBASE-28613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated HBASE-28613: Description: We are currently marshalling protobuf into a byte array, and then send that to the client. This is both slow and memory intensive. I see a ~15% reduction in the REST server CPU usage for my benchmark with this patch. was: We are currently marshalling protobuf into a byte array, and then send that to the client. This is both slow and memory intensive. Using streaming instead results in huge perf improvements. In my bechnmark, both the wall clock time was almost halved, while the REST server CPU usage was reduced by 40%. wall clock: 120s ->65s Total REST CPU: 300s -> 180s > Use streaming when marshalling protobuf REST output > --- > > Key: HBASE-28613 > URL: https://issues.apache.org/jira/browse/HBASE-28613 > Project: HBase > Issue Type: Improvement > Components: REST >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > We are currently marshalling protobuf into a byte array, and then send that > to the client. > This is both slow and memory intensive. > I see a ~15% reduction in the REST server CPU usage for my benchmark with > this patch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform [hbase]
ndimiduk commented on code in PR #5286: URL: https://github.com/apache/hbase/pull/5286#discussion_r1611262805 ## dev-support/hbase_docker/m1/Dockerfile: ## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FROM --platform=linux/amd64 ubuntu:22.04 AS base_image Review Comment: I don't think this is the right way to do things. Instead, you should provide `--platform` to the docker command line invocation when building the image. That will cause it to pull down the ubuntu image of the specified platform. I left a comment on the Jira with an example of how to do a multi-platform docker image. It's not the only way to do it, but it's the style I've been using in the kustomize repo. Yetus project may have an alternative example of how to achieve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27915) Update hbase_docker with an extra Dockerfile compatible with mac m1 platfrom
[ https://issues.apache.org/jira/browse/HBASE-27915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848880#comment-17848880 ] Nick Dimiduk commented on HBASE-27915: -- Heya [~wchevreuil], I missed this ticket but I saw your commit land. If you're interested, I have an example of how to define a single dockerfile that can be used to build images for multiple platforms. And if the underlying build engine supports it, I believe it can be used to create a multi-platform image. https://github.com/apache/hbase-kustomize/tree/main/dockerfiles/kuttl > Update hbase_docker with an extra Dockerfile compatible with mac m1 platfrom > > > Key: HBASE-27915 > URL: https://issues.apache.org/jira/browse/HBASE-27915 > Project: HBase > Issue Type: Bug >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Labels: pull-request-available > > When trying to use the current Dockerfile under "./dev-support/hbase_docker" > on m1 macs, the docker build fails at the git clone & mvn build stage with > below error: > {noformat} > #0 8.214 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such > file or directory > {noformat} > It turns out for mac m1, we have to explicitly define the platform flag for > the ubuntu image. I thought we could add a note in this readme, together with > an "m1" subfolder containing a modified copy of this Dockerfile that works on > mac m1s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-28605) Add ErrorProne ban on Hadoop shaded thirdparty jars
[ https://issues.apache.org/jira/browse/HBASE-28605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-28605. -- Fix Version/s: 2.7.0 3.0.0-beta-2 2.6.1 2.5.9 Resolution: Fixed Pushed to branch-2.5+. Thanks for the quick reviews. > Add ErrorProne ban on Hadoop shaded thirdparty jars > --- > > Key: HBASE-28605 > URL: https://issues.apache.org/jira/browse/HBASE-28605 > Project: HBase > Issue Type: Task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Labels: pull-request-available > Fix For: 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9 > > > Over on HBASE-28568 we got tripped up because we pulled in the shaded Guava > provided by Hadoop. This wasn't noticed until the backport to branch-2, which > builds against hadoop-2. We should make this a compile time failure. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.5 [hbase]
ndimiduk merged PR #5935: URL: https://github.com/apache/hbase/pull/5935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2.6 [hbase]
ndimiduk merged PR #5934: URL: https://github.com/apache/hbase/pull/5934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-2 [hbase]
ndimiduk merged PR #5933: URL: https://github.com/apache/hbase/pull/5933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backport "HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)" to branch-3 [hbase]
ndimiduk merged PR #5932: URL: https://github.com/apache/hbase/pull/5932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28613) Use streaming when marshalling protobuf REST output
[ https://issues.apache.org/jira/browse/HBASE-28613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848862#comment-17848862 ] Istvan Toth commented on HBASE-28613: - Hmm, I have re-run the tests, and now I see similar results with the old code. Will need to investigate further. > Use streaming when marshalling protobuf REST output > --- > > Key: HBASE-28613 > URL: https://issues.apache.org/jira/browse/HBASE-28613 > Project: HBase > Issue Type: Improvement > Components: REST >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > We are currently marshalling protobuf into a byte array, and then send that > to the client. > This is both slow and memory intensive. > Using streaming instead results in huge perf improvements. In my bechnmark, > both the wall clock time was almost halved, while the REST server CPU usage > was reduced by 40%. > wall clock: 120s ->65s > Total REST CPU: 300s -> 180s -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28613) Use streaming when marshalling protobuf REST output
Istvan Toth created HBASE-28613: --- Summary: Use streaming when marshalling protobuf REST output Key: HBASE-28613 URL: https://issues.apache.org/jira/browse/HBASE-28613 Project: HBase Issue Type: Improvement Components: REST Reporter: Istvan Toth Assignee: Istvan Toth We are currently marshalling protobuf into a byte array, and then send that to the client. This is both slow and memory intensive. Using streaming instead results in huge perf improvements. In my bechnmark, both the wall clock time was almost halved, while the REST server CPU usage was reduced by 40%. wall clock: 120s ->65s Total REST CPU: 300s -> 180s -- This message was sent by Atlassian Jira (v8.20.10#820010)