[jira] [Commented] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087246#comment-13087246 ] Akash Ashok commented on HBASE-4008: Making it protected works for me. Because it isn't used by anything else currently. But I am thinking making it protected means only the class or the subclasses or the classes in the same package is able to call this method. So it means we are intending this method to be used only by subclasses or within same package. Just like isStopped() or isActiveMaster() even isAborted() has the potential to be called from somehwere outside the package. So based on how it could be called it could still be public. I would love to hear your thoughts on this. > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: HMaster > Fix For: 0.92.0 > > Attachments: HBase-4008-v2.patch, HBase-4008.patch > > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087465#comment-13087465 ] Akash Ashok commented on HBASE-4008: Ok sure This patch works for me. Thanks. Also about including the isAborted in the Abortable interface is there a JIRA already open for this? Could I take that up ? > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: HMaster > Fix For: 0.92.0 > > Attachments: HBase-4008-v2.patch, HBase-4008.patch > > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089609#comment-13089609 ] Akash Ashok commented on HBASE-4008: Also about including the isAborted in the Abortable interface is there a JIRA already open for this? Could I take that up ? No. Please. @Stack: I'm kinda confused. Just wanted to clarify. Did u mean another JIRA is not open and I could take it up. Or did u ask me not to take it up? :) :) > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: HMaster > Fix For: 0.92.0 > > Attachments: HBase-4008-v2.patch, HBase-4008.patch > > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-4247) Add isAborted method to the Abortable interface
Add isAborted method to the Abortable interface --- Key: HBASE-4247 URL: https://issues.apache.org/jira/browse/HBASE-4247 Project: HBase Issue Type: Task Reporter: Akash Ashok Assignee: Akash Ashok Priority: Minor Add a new method isAborted() to the Abortable interface -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4247) Add isAborted method to the Abortable interface
[ https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090990#comment-13090990 ] Akash Ashok commented on HBASE-4247: Firstly in the process of working on this. I have made the following assumptions 1. if abort() has a null implementation, then a. isAborted() will have a null implementation ( returns false ) 2. if abort() throws a RuntimeException(), then a. create a boolean abort b.set this to true in abort() c. return abort in isAbort() I hope this would be fine. Secondly there are Instances where in abort() implementation this.stopped and this.closed are manipulated. Shouldn't this be done in stop() and close() methods of Stoppable and Closable interfaces? This is a little misleading isn't it ? If it really has to be stopped when aborted then why not call stop() from abort(). I feel it makes it more meaningful > Add isAborted method to the Abortable interface > --- > > Key: HBASE-4247 > URL: https://issues.apache.org/jira/browse/HBASE-4247 > Project: HBase > Issue Type: Task >Reporter: Akash Ashok >Assignee: Akash Ashok >Priority: Minor > > Add a new method isAborted() to the Abortable interface -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-4247) Add isAborted method to the Abortable interface
[ https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-4247 started by Akash Ashok. > Add isAborted method to the Abortable interface > --- > > Key: HBASE-4247 > URL: https://issues.apache.org/jira/browse/HBASE-4247 > Project: HBase > Issue Type: Task >Reporter: Akash Ashok >Assignee: Akash Ashok >Priority: Minor > > Add a new method isAborted() to the Abortable interface -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4247) Add isAborted method to the Abortable interface
[ https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092453#comment-13092453 ] Akash Ashok commented on HBASE-4247: I just made the changes and ran tests. There's one issue. In HConnectionManagerImpl as I mentioned before this.closed is being set to true in the abort() method and I changed this to call close(stopProxy) method indeed instead of manipulating this.closed to true. But unfortunatly TestMergeTool started failing because of this change. So my question is that was this intended closed in the first place ?? > Add isAborted method to the Abortable interface > --- > > Key: HBASE-4247 > URL: https://issues.apache.org/jira/browse/HBASE-4247 > Project: HBase > Issue Type: Task >Reporter: Akash Ashok >Assignee: Akash Ashok >Priority: Minor > > Add a new method isAborted() to the Abortable interface -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4247) Add isAborted method to the Abortable interface
[
https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092492#comment-13092492
]
Akash Ashok commented on HBASE-4247:
TestMerge tool is failing because of the changes I made I am sure.
The change is basically this:
Original
@Override
public void abort(final String msg, Throwable t) {
if (t instanceof KeeperException.SessionExpiredException) {
try {
LOG.info("This client just lost it's session with ZooKeeper, trying" +
" to reconnect.");
resetZooKeeperTrackers();
LOG.info("Reconnected successfully. This disconnect could have been" +
" caused by a network partition or a long-running GC pause," +
" either way it's recommended that you verify your environment.");
return;
} catch (ZooKeeperConnectionException e) {
LOG.error("Could not reconnect to ZooKeeper after session" +
" expiration, aborting");
t = e;
}
}
if (t != null) LOG.fatal(msg, t);
else LOG.fatal(msg);
this.closed=true;
}
Changed
@Override
public void abort(final String msg, Throwable t) {
if (t instanceof KeeperException.SessionExpiredException) {
try {
LOG.info("This client just lost it's session with ZooKeeper, trying" +
" to reconnect.");
resetZooKeeperTrackers();
LOG.info("Reconnected successfully. This disconnect could have been" +
" caused by a network partition or a long-running GC pause," +
" either way it's recommended that you verify your environment.");
return;
} catch (ZooKeeperConnectionException e) {
LOG.error("Could not reconnect to ZooKeeper after session" +
" expiration, aborting");
t = e;
}
}
if (t != null) LOG.fatal(msg, t);
else LOG.fatal(msg);
close(false);
}
My question is close is closing zookeeper session and other thing. But does
changing this leads to other test cases like TestMergeTool failing.
Does setting this.closed=true have any meaning at all in abort without actually
closing ?
> Add isAborted method to the Abortable interface
> ---
>
> Key: HBASE-4247
> URL: https://issues.apache.org/jira/browse/HBASE-4247
> Project: HBase
> Issue Type: Task
>Reporter: Akash Ashok
>Assignee: Akash Ashok
>Priority: Minor
> Fix For: 0.94.0
>
>
> Add a new method isAborted() to the Abortable interface
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4247) Add isAborted method to the Abortable interface
[ https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092493#comment-13092493 ] Akash Ashok commented on HBASE-4247: Plz excuse me about the formatting. I didn't know the Markup tags the codes should be placed under > Add isAborted method to the Abortable interface > --- > > Key: HBASE-4247 > URL: https://issues.apache.org/jira/browse/HBASE-4247 > Project: HBase > Issue Type: Task >Reporter: Akash Ashok >Assignee: Akash Ashok >Priority: Minor > Fix For: 0.94.0 > > > Add a new method isAborted() to the Abortable interface -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4247) Add isAborted method to the Abortable interface
[ https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092502#comment-13092502 ] Akash Ashok commented on HBASE-4247: HConnectionImplementation implements HConnection which inturn implements Abortable > Add isAborted method to the Abortable interface > --- > > Key: HBASE-4247 > URL: https://issues.apache.org/jira/browse/HBASE-4247 > Project: HBase > Issue Type: Task >Reporter: Akash Ashok >Assignee: Akash Ashok >Priority: Minor > Fix For: 0.94.0 > > > Add a new method isAborted() to the Abortable interface -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4247) Add isAborted method to the Abortable interface
[ https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093857#comment-13093857 ] Akash Ashok commented on HBASE-4247: I agree with that. But on a more logical level doesn't setting this.closed = true mean that close() method was called on it and the zookeeper session itself was closed ? setting this.closed = true without executing close() shouldn't be done even for special cases right ? If such is that case then this.aborted itself should be used instead of closed right ?? > Add isAborted method to the Abortable interface > --- > > Key: HBASE-4247 > URL: https://issues.apache.org/jira/browse/HBASE-4247 > Project: HBase > Issue Type: Task >Reporter: Akash Ashok >Assignee: Akash Ashok >Priority: Minor > Fix For: 0.94.0 > > > Add a new method isAborted() to the Abortable interface -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4224) Need a flush by regionserver rather than by table option
[ https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096584#comment-13096584 ] Akash Ashok commented on HBASE-4224: Hey Stack, I would actually like to work on this. I don't know If I am able to grasp the true gravity and understand how big a problem this is or even If I am equipped enough to handle this. But with a little help I could work on this. Please let me know. > Need a flush by regionserver rather than by table option > > > Key: HBASE-4224 > URL: https://issues.apache.org/jira/browse/HBASE-4224 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: stack > > This evening needed to clean out logs on the cluster. logs are by > regionserver. to let go of logs, we need to have all edits emptied from > memory. only flush is by table or region. We need to be able to flush the > regionserver. Need to add this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4247) Add isAborted method to the Abortable interface
[
https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100320#comment-13100320
]
Akash Ashok commented on HBASE-4247:
In HConnectionManager.java under the subclass HConnectionManagerImplementation
{code}
@Override
public void abort(final String msg, Throwable t) {
if (t instanceof KeeperException.SessionExpiredException) {
try {
LOG.info("This client just lost it's session with ZooKeeper, trying" +
" to reconnect.");
resetZooKeeperTrackers();
LOG.info("Reconnected successfully. This disconnect could have been" +
" caused by a network partition or a long-running GC pause," +
" either way it's recommended that you verify your environment.");
return;
} catch (ZooKeeperConnectionException e) {
LOG.error("Could not reconnect to ZooKeeper after session" +
" expiration, aborting");
t = e;
}
}
if (t != null) LOG.fatal(msg, t);
else LOG.fatal(msg);
this.closed = true;
}
{code}
If we call close() instead of this tests are failing( one of them being
TestMergeTools ). I was wondering if some change should be made out here.
Somehow I feel its not right set this.closed out here? Or if this is some
special case and could be left untouched.
Thanks
> Add isAborted method to the Abortable interface
> ---
>
> Key: HBASE-4247
> URL: https://issues.apache.org/jira/browse/HBASE-4247
> Project: HBase
> Issue Type: Task
>Reporter: Akash Ashok
>Assignee: Akash Ashok
>Priority: Minor
> Fix For: 0.94.0
>
>
> Add a new method isAborted() to the Abortable interface
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4224) Need a flush by regionserver rather than by table option
[ https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100437#comment-13100437 ] Akash Ashok commented on HBASE-4224: Thanks Stack. I'll start workin on it then. > Need a flush by regionserver rather than by table option > > > Key: HBASE-4224 > URL: https://issues.apache.org/jira/browse/HBASE-4224 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: stack > > This evening needed to clean out logs on the cluster. logs are by > regionserver. to let go of logs, we need to have all edits emptied from > memory. only flush is by table or region. We need to be able to flush the > regionserver. Need to add this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4224) Need a flush by regionserver rather than by table option
[ https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok reassigned HBASE-4224: -- Assignee: Akash Ashok > Need a flush by regionserver rather than by table option > > > Key: HBASE-4224 > URL: https://issues.apache.org/jira/browse/HBASE-4224 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: stack >Assignee: Akash Ashok > > This evening needed to clean out logs on the cluster. logs are by > regionserver. to let go of logs, we need to have all edits emptied from > memory. only flush is by table or region. We need to be able to flush the > regionserver. Need to add this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4247) Add isAborted method to the Abortable interface
[ https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4247: --- Attachment: HBase-4247.patch > Add isAborted method to the Abortable interface > --- > > Key: HBASE-4247 > URL: https://issues.apache.org/jira/browse/HBASE-4247 > Project: HBase > Issue Type: Task >Reporter: Akash Ashok >Assignee: Akash Ashok >Priority: Minor > Fix For: 0.94.0 > > Attachments: HBase-4247.patch > > > Add a new method isAborted() to the Abortable interface -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4247) Add isAborted method to the Abortable interface
[ https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4247: --- Status: Patch Available (was: In Progress) > Add isAborted method to the Abortable interface > --- > > Key: HBASE-4247 > URL: https://issues.apache.org/jira/browse/HBASE-4247 > Project: HBase > Issue Type: Task >Reporter: Akash Ashok >Assignee: Akash Ashok >Priority: Minor > Fix For: 0.94.0 > > Attachments: HBase-4247.patch > > > Add a new method isAborted() to the Abortable interface -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4247) Add isAborted method to the Abortable interface
[ https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4247: --- Attachment: HBase-4247-v2.patch Adding Javadoc to the isAbortable() method in Abortable Interface > Add isAborted method to the Abortable interface > --- > > Key: HBASE-4247 > URL: https://issues.apache.org/jira/browse/HBASE-4247 > Project: HBase > Issue Type: Task >Reporter: Akash Ashok >Assignee: Akash Ashok >Priority: Minor > Fix For: 0.94.0 > > Attachments: HBase-4247-v2.patch, HBase-4247.patch > > > Add a new method isAborted() to the Abortable interface -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-4224) Need a flush by regionserver rather than by table option
[ https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-4224 started by Akash Ashok. > Need a flush by regionserver rather than by table option > > > Key: HBASE-4224 > URL: https://issues.apache.org/jira/browse/HBASE-4224 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: stack >Assignee: Akash Ashok > > This evening needed to clean out logs on the cluster. logs are by > regionserver. to let go of logs, we need to have all edits emptied from > memory. only flush is by table or region. We need to be able to flush the > regionserver. Need to add this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-4486) Improve Javadoc for HTableDescriptor
Improve Javadoc for HTableDescriptor Key: HBASE-4486 URL: https://issues.apache.org/jira/browse/HBASE-4486 Project: HBase Issue Type: Improvement Components: client, documentation Reporter: Akash Ashok Assignee: Akash Ashok Priority: Minor -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-2965) Implement MultipleTableInputs which is analogous to MultipleInputs in Hadoop
[
https://issues.apache.org/jira/browse/HBASE-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990891#comment-12990891
]
Akash Ashok commented on HBASE-2965:
Hi, I was lookin for the exact same thing. As we are moving from just
processing on hadoop to using Hbase, we are in dire need of this
MultipleTableInputs for our reduce side joins. Could some1 please temme as to
when this will be implemented .
Also can I move this feature from Minor to Major as this is a very important
feature?
> Implement MultipleTableInputs which is analogous to MultipleInputs in Hadoop
>
>
> Key: HBASE-2965
> URL: https://issues.apache.org/jira/browse/HBASE-2965
> Project: HBase
> Issue Type: New Feature
> Components: mapred, mapreduce
>Reporter: Adam Warrington
>Priority: Minor
>
> This feature would be helpful for doing reduce side joins, or even passing
> similarly structured data from multiple tables through map reduce. The API I
> envision would be very similar to the already existent MultipleInputs, parts
> of which could be reused.
> MultipleTableInputs would have a public api like:
> class MultipleTableInputs {
> public static void addInputTable(Job job, Table table, Scan scan, Class extends TableInputFormatBase> inputFormatClass, Class
> mapperClass);
> };
> MultipleTableInputs would build a mapping of Tables to configured
> TableInputFormats the same way MultipleInputs builds a mapping between Paths
> and InputFormats. Since most people will probably use TableInputFormat.class
> as the input format class, the MultipleTableInput implementation will have to
> replace the TableInputFormatBase's private scan and table members that are
> configured when an instance of TableInputFormat is created (from within its
> setConf() method) by calling setScan and setHTable with the table and scan
> that are passed into addInputTable above. MultipleTableInputFormat's
> addInputTable() member function would also set the input format for the job
> to DelegatingTableInputFormat, described below.
> A new class called DelegatingTableInputFormat would be analogous to
> DelegatingInputFormat, where getSplits() would return TaggedInputSplits (same
> TaggedInputSplit object that the Hadoop DelegatingInputFormat uses), which
> tag the split with its InputFormat and Mapper. These are created by looping
> through the HTable to InputFormat mappings, and calling getSplits on each
> input format, and using the split, the input format, and mapper as
> constructor args to TaggedInputSplits.
> The createRecordReader() function in DelegatingTableInputFormat could have
> the same implementation as the Hadoop DelegatingInputFormat.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-2965) Implement MultipleTableInputs which is analogous to MultipleInputs in Hadoop
[
https://issues.apache.org/jira/browse/HBASE-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993807#comment-12993807
]
Akash Ashok commented on HBASE-2965:
I have not yet started workin on it. Will start next Saturday if no one else
has taken it up.
> Implement MultipleTableInputs which is analogous to MultipleInputs in Hadoop
>
>
> Key: HBASE-2965
> URL: https://issues.apache.org/jira/browse/HBASE-2965
> Project: HBase
> Issue Type: New Feature
> Components: mapred, mapreduce
>Reporter: Adam Warrington
>Assignee: Ophir Cohen
>Priority: Minor
>
> This feature would be helpful for doing reduce side joins, or even passing
> similarly structured data from multiple tables through map reduce. The API I
> envision would be very similar to the already existent MultipleInputs, parts
> of which could be reused.
> MultipleTableInputs would have a public api like:
> class MultipleTableInputs {
> public static void addInputTable(Job job, Table table, Scan scan, Class extends TableInputFormatBase> inputFormatClass, Class
> mapperClass);
> };
> MultipleTableInputs would build a mapping of Tables to configured
> TableInputFormats the same way MultipleInputs builds a mapping between Paths
> and InputFormats. Since most people will probably use TableInputFormat.class
> as the input format class, the MultipleTableInput implementation will have to
> replace the TableInputFormatBase's private scan and table members that are
> configured when an instance of TableInputFormat is created (from within its
> setConf() method) by calling setScan and setHTable with the table and scan
> that are passed into addInputTable above. MultipleTableInputFormat's
> addInputTable() member function would also set the input format for the job
> to DelegatingTableInputFormat, described below.
> A new class called DelegatingTableInputFormat would be analogous to
> DelegatingInputFormat, where getSplits() would return TaggedInputSplits (same
> TaggedInputSplit object that the Hadoop DelegatingInputFormat uses), which
> tag the split with its InputFormat and Mapper. These are created by looping
> through the HTable to InputFormat mappings, and calling getSplits on each
> input format, and using the split, the input format, and mapper as
> constructor args to TaggedInputSplits.
> The createRecordReader() function in DelegatingTableInputFormat could have
> the same implementation as the Hadoop DelegatingInputFormat.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4008: --- Description: stop-hbase.sh stops the server successfully if and only if the server is instantiated properly. When u Run start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues ) Whereas when u run start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly ) was: stop-hbase.sh stops the server successfully if and only if the server is instantiate properly. When u Run start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues ) Whereas when u run start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly ) > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Priority: Minor > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-4008) Problem while stopping HBase
Problem while stopping HBase Key: HBASE-4008 URL: https://issues.apache.org/jira/browse/HBASE-4008 Project: HBase Issue Type: Bug Components: scripts Reporter: Akash Ashok Priority: Minor stop-hbase.sh stops the server successfully if and only if the server is instantiate properly. When u Run start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no issues ) Whereas when u run start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052433#comment-13052433 ] Akash Ashok commented on HBASE-4008: Also this problem exists with the current startup of HMaster that if any Exception is thrown during the startup of the master then HMaster will still be running as a process but its meaningless. stop-hbase.sh fails even then. Shouldn't it be the case that if a serious exception is thrown the HMaster process should die? > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Priority: Minor > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-4013) Make ZooKeeperListener Abstract !
Make ZooKeeperListener Abstract ! - Key: HBASE-4013 URL: https://issues.apache.org/jira/browse/HBASE-4013 Project: HBase Issue Type: Task Components: zookeeper Reporter: Akash Ashok Priority: Minor org.apache.hadoop.hbase.zookeeper.ZooKeeperListener seems to have all unimplemented methods. This should be made an abstract class. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4013) Make ZooKeeperListener Abstract
[ https://issues.apache.org/jira/browse/HBASE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4013: --- Status: Patch Available (was: Open) > Make ZooKeeperListener Abstract > --- > > Key: HBASE-4013 > URL: https://issues.apache.org/jira/browse/HBASE-4013 > Project: HBase > Issue Type: Task > Components: zookeeper >Reporter: Akash Ashok >Priority: Minor > Labels: zookeeper > > org.apache.hadoop.hbase.zookeeper.ZooKeeperListener seems to have all > unimplemented methods. This should be made an abstract class. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4013) Make ZooKeeperListener Abstract
[ https://issues.apache.org/jira/browse/HBASE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4013: --- Status: Open (was: Patch Available) > Make ZooKeeperListener Abstract > --- > > Key: HBASE-4013 > URL: https://issues.apache.org/jira/browse/HBASE-4013 > Project: HBase > Issue Type: Task > Components: zookeeper >Reporter: Akash Ashok >Priority: Minor > Labels: zookeeper > > org.apache.hadoop.hbase.zookeeper.ZooKeeperListener seems to have all > unimplemented methods. This should be made an abstract class. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4013) Make ZooKeeperListener Abstract
[ https://issues.apache.org/jira/browse/HBASE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4013: --- Attachment: hbase-4013.patch ZooKeeperListener made abstract > Make ZooKeeperListener Abstract > --- > > Key: HBASE-4013 > URL: https://issues.apache.org/jira/browse/HBASE-4013 > Project: HBase > Issue Type: Task > Components: zookeeper >Reporter: Akash Ashok >Priority: Minor > Labels: zookeeper > Attachments: hbase-4013.patch > > > org.apache.hadoop.hbase.zookeeper.ZooKeeperListener seems to have all > unimplemented methods. This should be made an abstract class. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4013) Make ZooKeeperListener Abstract
[ https://issues.apache.org/jira/browse/HBASE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4013: --- Status: Patch Available (was: Open) > Make ZooKeeperListener Abstract > --- > > Key: HBASE-4013 > URL: https://issues.apache.org/jira/browse/HBASE-4013 > Project: HBase > Issue Type: Task > Components: zookeeper >Reporter: Akash Ashok >Priority: Minor > Labels: zookeeper > Attachments: hbase-4013.patch > > > org.apache.hadoop.hbase.zookeeper.ZooKeeperListener seems to have all > unimplemented methods. This should be made an abstract class. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053773#comment-13053773 ] Akash Ashok commented on HBASE-4008: If such is the case, can I change this bug priority to Major? > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Priority: Minor > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok reassigned HBASE-4008: -- Assignee: Akash Ashok > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok >Priority: Minor > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-4029) Inappropriate checkin of Logging Mode in HRegionServer
Inappropriate checkin of Logging Mode in HRegionServer -- Key: HBASE-4029 URL: https://issues.apache.org/jira/browse/HBASE-4029 Project: HBase Issue Type: Bug Reporter: Akash Ashok There is a condition check for Debug mode logging in HRegionServer.java . Because of this the region server never closes the META region while stopping hbase and thus never stops, if DEBUG mode is not enable in logging. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4029) Inappropriate checking of Logging Mode in HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok reassigned HBASE-4029: -- Assignee: Akash Ashok > Inappropriate checking of Logging Mode in HRegionServer > --- > > Key: HBASE-4029 > URL: https://issues.apache.org/jira/browse/HBASE-4029 > Project: HBase > Issue Type: Bug >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > > There is a condition check for Debug mode logging in HRegionServer.java . > Because of this the region server never closes the META region while stopping > hbase and thus never stops, if DEBUG mode is not enable in logging. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4029) Inappropriate checking of Logging Mode in HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054557#comment-13054557 ] Akash Ashok commented on HBASE-4029: Sure. I am workin on it. > Inappropriate checking of Logging Mode in HRegionServer > --- > > Key: HBASE-4029 > URL: https://issues.apache.org/jira/browse/HBASE-4029 > Project: HBase > Issue Type: Bug >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > > There is a condition check for Debug mode logging in HRegionServer.java . > Because of this the region server never closes the META region while stopping > hbase and thus never stops, if DEBUG mode is not enable in logging. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-4034) HRegionServer should be stopped even if no META regions are hosted by the HRegionServer
HRegionServer should be stopped even if no META regions are hosted by the HRegionServer --- Key: HBASE-4034 URL: https://issues.apache.org/jira/browse/HBASE-4034 Project: HBase Issue Type: Bug Reporter: Akash Ashok HRegionServer always makes sure one META region is hosted for it to stop. This should be changed so that even if no META regions are hosted, the HRegionServer should be stopped once all user regions are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-4029) Inappropriate checking of Logging Mode in HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-4029 started by Akash Ashok. > Inappropriate checking of Logging Mode in HRegionServer > --- > > Key: HBASE-4029 > URL: https://issues.apache.org/jira/browse/HBASE-4029 > Project: HBase > Issue Type: Bug >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > > There is a condition check for Debug mode logging in HRegionServer.java . > Because of this the region server never closes the META region while stopping > hbase and thus never stops, if DEBUG mode is not enable in logging. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4029) Inappropriate checking of Logging Mode in HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4029: --- Attachment: hbase-4029.patch > Inappropriate checking of Logging Mode in HRegionServer > --- > > Key: HBASE-4029 > URL: https://issues.apache.org/jira/browse/HBASE-4029 > Project: HBase > Issue Type: Bug >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > Attachments: hbase-4029.patch > > > There is a condition check for Debug mode logging in HRegionServer.java . > Because of this the region server never closes the META region while stopping > hbase and thus never stops, if DEBUG mode is not enable in logging. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4029) Inappropriate checking of Logging Mode in HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4029: --- Status: Patch Available (was: In Progress) > Inappropriate checking of Logging Mode in HRegionServer > --- > > Key: HBASE-4029 > URL: https://issues.apache.org/jira/browse/HBASE-4029 > Project: HBase > Issue Type: Bug >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > Attachments: hbase-4029.patch > > > There is a condition check for Debug mode logging in HRegionServer.java . > Because of this the region server never closes the META region while stopping > hbase and thus never stops, if DEBUG mode is not enable in logging. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4029) Inappropriate checking of Logging Mode in HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4029: --- Component/s: regionserver > Inappropriate checking of Logging Mode in HRegionServer > --- > > Key: HBASE-4029 > URL: https://issues.apache.org/jira/browse/HBASE-4029 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > Attachments: hbase-4029.patch > > > There is a condition check for Debug mode logging in HRegionServer.java . > Because of this the region server never closes the META region while stopping > hbase and thus never stops, if DEBUG mode is not enable in logging. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4034) HRegionServer should be stopped even if no META regions are hosted by the HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok reassigned HBASE-4034: -- Assignee: Akash Ashok > HRegionServer should be stopped even if no META regions are hosted by the > HRegionServer > --- > > Key: HBASE-4034 > URL: https://issues.apache.org/jira/browse/HBASE-4034 > Project: HBase > Issue Type: Bug >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > > HRegionServer always makes sure one META region is hosted for it to stop. > This should be changed so that even if no META regions are hosted, the > HRegionServer should be stopped once all user regions are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-4034) HRegionServer should be stopped even if no META regions are hosted by the HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-4034 started by Akash Ashok. > HRegionServer should be stopped even if no META regions are hosted by the > HRegionServer > --- > > Key: HBASE-4034 > URL: https://issues.apache.org/jira/browse/HBASE-4034 > Project: HBase > Issue Type: Bug >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > > HRegionServer always makes sure one META region is hosted for it to stop. > This should be changed so that even if no META regions are hosted, the > HRegionServer should be stopped once all user regions are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4034) HRegionServer should be stopped even if no META regions are hosted by the HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4034: --- Attachment: hbase-4034.patch > HRegionServer should be stopped even if no META regions are hosted by the > HRegionServer > --- > > Key: HBASE-4034 > URL: https://issues.apache.org/jira/browse/HBASE-4034 > Project: HBase > Issue Type: Bug >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Attachments: hbase-4034.patch > > > HRegionServer always makes sure one META region is hosted for it to stop. > This should be changed so that even if no META regions are hosted, the > HRegionServer should be stopped once all user regions are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4034) HRegionServer should be stopped even if no META regions are hosted by the HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4034: --- Component/s: regionserver > HRegionServer should be stopped even if no META regions are hosted by the > HRegionServer > --- > > Key: HBASE-4034 > URL: https://issues.apache.org/jira/browse/HBASE-4034 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > Attachments: hbase-4034.patch > > > HRegionServer always makes sure one META region is hosted for it to stop. > This should be changed so that even if no META regions are hosted, the > HRegionServer should be stopped once all user regions are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4034) HRegionServer should be stopped even if no META regions are hosted by the HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4034: --- Fix Version/s: 0.92.0 Status: Patch Available (was: In Progress) > HRegionServer should be stopped even if no META regions are hosted by the > HRegionServer > --- > > Key: HBASE-4034 > URL: https://issues.apache.org/jira/browse/HBASE-4034 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > Attachments: hbase-4034.patch > > > HRegionServer always makes sure one META region is hosted for it to stop. > This should be changed so that even if no META regions are hosted, the > HRegionServer should be stopped once all user regions are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4034) HRegionServer should be stopped even if no META regions are hosted by the HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4034: --- Attachment: hbase-4029.patch > HRegionServer should be stopped even if no META regions are hosted by the > HRegionServer > --- > > Key: HBASE-4034 > URL: https://issues.apache.org/jira/browse/HBASE-4034 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > Attachments: hbase-4034.patch > > > HRegionServer always makes sure one META region is hosted for it to stop. > This should be changed so that even if no META regions are hosted, the > HRegionServer should be stopped once all user regions are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4034) HRegionServer should be stopped even if no META regions are hosted by the HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4034: --- Attachment: (was: hbase-4029.patch) > HRegionServer should be stopped even if no META regions are hosted by the > HRegionServer > --- > > Key: HBASE-4034 > URL: https://issues.apache.org/jira/browse/HBASE-4034 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > Attachments: hbase-4034.patch > > > HRegionServer always makes sure one META region is hosted for it to stop. > This should be changed so that even if no META regions are hosted, the > HRegionServer should be stopped once all user regions are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4034) HRegionServer should be stopped even if no META regions are hosted by the HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4034: --- Attachment: hbase-4034_v2.patch > HRegionServer should be stopped even if no META regions are hosted by the > HRegionServer > --- > > Key: HBASE-4034 > URL: https://issues.apache.org/jira/browse/HBASE-4034 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > Attachments: hbase-4034.patch, hbase-4034_v2.patch > > > HRegionServer always makes sure one META region is hosted for it to stop. > This should be changed so that even if no META regions are hosted, the > HRegionServer should be stopped once all user regions are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4034) HRegionServer should be stopped even if no META regions are hosted by the HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057361#comment-13057361 ] Akash Ashok commented on HBASE-4034: I have made the change and I have attached the new patch. I have run the test suite. 2 Tests DisabledTestRegionServerExit and TestSplitTransactionOnCluster FAILED before and after the patch. So I believe it wasn't caused by the patch. > HRegionServer should be stopped even if no META regions are hosted by the > HRegionServer > --- > > Key: HBASE-4034 > URL: https://issues.apache.org/jira/browse/HBASE-4034 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > Attachments: hbase-4034.patch, hbase-4034_v2.patch > > > HRegionServer always makes sure one META region is hosted for it to stop. > This should be changed so that even if no META regions are hosted, the > HRegionServer should be stopped once all user regions are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4034) HRegionServer should be stopped even if no META regions are hosted by the HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057363#comment-13057363 ] Akash Ashok commented on HBASE-4034: I ran only the regionsserver tests. That should be fine right ? > HRegionServer should be stopped even if no META regions are hosted by the > HRegionServer > --- > > Key: HBASE-4034 > URL: https://issues.apache.org/jira/browse/HBASE-4034 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: regionserver > Fix For: 0.92.0 > > Attachments: hbase-4034.patch, hbase-4034_v2.patch > > > HRegionServer always makes sure one META region is hosted for it to stop. > This should be changed so that even if no META regions are hosted, the > HRegionServer should be stopped once all user regions are closed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4008: --- Priority: Major (was: Minor) > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062091#comment-13062091 ] Akash Ashok commented on HBASE-4008: I think the main issue is in HMaster.run() method which on throwing an exception aborts all the HMaster threads and neatly executes finally block and exits which in turn would result in HMasterCommandLine thinking that HMaster has started because it hasn't thrown an exception and returns 0. I think we have to throw any exception within HMaster.run() and let it rise thru the stack and let HMasterCommandLine also handle it. > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062098#comment-13062098 ] Akash Ashok commented on HBASE-4008: yeah was thinking of that. Would that result in any issues ? > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062121#comment-13062121 ] Akash Ashok commented on HBASE-4008: Only thing I fear is catching the exception thrown from the HMaster threads using an UncaughtExceptionHandler. So that should be a fairly simple change. Would check it out ! > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062314#comment-13062314 ] Akash Ashok commented on HBASE-4008: Hey I am not sure how to handle if any Exceptions were thrown by the HMaster threads as these any Exceptions just terminate the threads leaving the HMasterCommandLine thinking that Master has started successfully. These Exceptions can't be propogated to HMasterCommandLine. Any idea on how this could be handled ? > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066098#comment-13066098 ] Akash Ashok commented on HBASE-4008: I have a question regarding the standalone HBase which might not be a real world scenario but fixing this issue I need to know what the behaviour should be after the fix. So for a standalone HBase setup if the HMaster throws a severe exception and master doesn't come up then HBase doesn't stop and goes to an inconsistent. In the case of True Distributed Mode only HMaster goes down as it runs on a separate JVM. But how about a standalone case where exiting the JVM causes the RegionServer threads also to be terminated ? In such a case master fails whole standalone HBase setup goes down. This makes logical sense as its a single node setup. Just wanted to clarify if this is ok. > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4008: --- Attachment: HBase-4008.patch > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > Attachments: HBase-4008.patch > > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-4008 started by Akash Ashok. > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > Attachments: HBase-4008-v2.patch, HBase-4008.patch > > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4008: --- Attachment: HBase-4008-v2.patch > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > Attachments: HBase-4008-v2.patch, HBase-4008.patch > > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066575#comment-13066575 ] Akash Ashok commented on HBASE-4008: Attaching HBase-4008-v2.patch as the first one had an extra unused import. > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > Attachments: HBase-4008-v2.patch, HBase-4008.patch > > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4008) Problem while stopping HBase
[ https://issues.apache.org/jira/browse/HBASE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Ashok updated HBASE-4008: --- Fix Version/s: 0.92.0 Labels: HMaster (was: ) Status: Patch Available (was: In Progress) > Problem while stopping HBase > > > Key: HBASE-4008 > URL: https://issues.apache.org/jira/browse/HBASE-4008 > Project: HBase > Issue Type: Bug > Components: scripts >Reporter: Akash Ashok >Assignee: Akash Ashok > Labels: HMaster > Fix For: 0.92.0 > > Attachments: HBase-4008-v2.patch, HBase-4008.patch > > > stop-hbase.sh stops the server successfully if and only if the server is > instantiated properly. > When u Run > start-hbase.sh; sleep 10; stop-hbase.sh; ( This works totally fine and has no > issues ) > Whereas when u run > start-hbase.sh; stop-hbase.sh; ( This never stops the server and neither the > server gets initialized and starts properly ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
