[jira] [Created] (HBASE-14899) Create custom Streaming ReplicationEndpoint
Cody Marcel created HBASE-14899: --- Summary: Create custom Streaming ReplicationEndpoint Key: HBASE-14899 URL: https://issues.apache.org/jira/browse/HBASE-14899 Project: HBase Issue Type: Sub-task Affects Versions: 2.0.0 Reporter: Cody Marcel Assignee: Cody Marcel Create a custom Replication Endpoint that streams WALEntry directly through client API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14899) Create custom Streaming ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-14899: Issue Type: New Feature (was: Sub-task) Parent: (was: HBASE-14379) > Create custom Streaming ReplicationEndpoint > --- > > Key: HBASE-14899 > URL: https://issues.apache.org/jira/browse/HBASE-14899 > Project: HBase > Issue Type: New Feature > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel > Fix For: 2.0.0 > > > Create a custom Replication Endpoint that streams WALEntry directly through > client API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14900) Make global config option for ReplicationEndpoint
Cody Marcel created HBASE-14900: --- Summary: Make global config option for ReplicationEndpoint Key: HBASE-14900 URL: https://issues.apache.org/jira/browse/HBASE-14900 Project: HBase Issue Type: Sub-task Affects Versions: 2.0.0 Reporter: Cody Marcel Assignee: Cody Marcel Priority: Minor Currently ReplicationEndpoint implementations can only be configured through the HBase shell. We should be able to to use a property in the hbase-site.xml to globally set an alternate default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14900) Make global config option for ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034378#comment-15034378 ] Cody Marcel commented on HBASE-14900: - Plan for the order of override for the implementation property. [~enis] [~apurtell] Let me know what you think. Global site property is overridden by the admin if defined through the shell. Otherwise we default back to HBaseInterClusterReplicationEndpoint. > Make global config option for ReplicationEndpoint > - > > Key: HBASE-14900 > URL: https://issues.apache.org/jira/browse/HBASE-14900 > Project: HBase > Issue Type: Sub-task > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Fix For: 2.0.0 > > > Currently ReplicationEndpoint implementations can only be configured through > the HBase shell. We should be able to to use a property in the hbase-site.xml > to globally set an alternate default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14899) Create custom Streaming ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034408#comment-15034408 ] Cody Marcel commented on HBASE-14899: - No. I am still working out the details, but this more simple than that. Instead of shipping the edits in batches to a random RS, which then goes through the client API, It will just stream directly into the buddies client directly. I am thinking to move the client writing out of the Sink and into the end point. > Create custom Streaming ReplicationEndpoint > --- > > Key: HBASE-14899 > URL: https://issues.apache.org/jira/browse/HBASE-14899 > Project: HBase > Issue Type: New Feature > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel > Fix For: 2.0.0 > > > Create a custom Replication Endpoint that streams WALEntry directly through > client API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14899) Create custom Streaming ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036399#comment-15036399 ] Cody Marcel commented on HBASE-14899: - I am still working on the details. AFAIK, V2 (HBASE-14379) is just a set of guidelines that we want to follow while improving replication. Has there been some propositions for interface changes? Please let me know if there are, but I am not aware of any. This patch would definitely conform to the requirements outlined in the V2 jira. It would be plugable and as minimally invasive as possible. You are correct though. It will probably be closer to "streaming-like" rather than actual streaming. I think I'd still work with the WALEdit. > Create custom Streaming ReplicationEndpoint > --- > > Key: HBASE-14899 > URL: https://issues.apache.org/jira/browse/HBASE-14899 > Project: HBase > Issue Type: New Feature > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel > Fix For: 2.0.0 > > > Create a custom Replication Endpoint that streams WALEntry directly through > client API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14900) Make global config option for ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041764#comment-15041764 ] Cody Marcel commented on HBASE-14900: - I should have a patch today. I got side tracked. I was also trying to refactor the existing tests a little to leverage those. Unsurprisingly that's taking longer than the few lines for the code change ;) > Make global config option for ReplicationEndpoint > - > > Key: HBASE-14900 > URL: https://issues.apache.org/jira/browse/HBASE-14900 > Project: HBase > Issue Type: Sub-task > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Fix For: 2.0.0 > > > Currently ReplicationEndpoint implementations can only be configured through > the HBase shell. We should be able to to use a property in the hbase-site.xml > to globally set an alternate default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14900) Make global config option for ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047252#comment-15047252 ] Cody Marcel commented on HBASE-14900: - So it seems changing the test to check where the property is pulled from is not as easy as I anticipated. ReplicationSourceManager is call when minicluster is created, which happens in @BeforeClass. By the time the test is called, the impl has already been applied. This change is fairly trivial anyway so having a test is less important. Running all tests now to make sure I didn't break anything. Patch will be up shortly. > Make global config option for ReplicationEndpoint > - > > Key: HBASE-14900 > URL: https://issues.apache.org/jira/browse/HBASE-14900 > Project: HBase > Issue Type: Sub-task > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Fix For: 2.0.0 > > > Currently ReplicationEndpoint implementations can only be configured through > the HBase shell. We should be able to to use a property in the hbase-site.xml > to globally set an alternate default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14899) Create custom Streaming ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-14899: Attachment: HBASE-14900.master.patch > Create custom Streaming ReplicationEndpoint > --- > > Key: HBASE-14899 > URL: https://issues.apache.org/jira/browse/HBASE-14899 > Project: HBase > Issue Type: New Feature > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel > Fix For: 2.0.0 > > Attachments: HBASE-14900.master.patch > > > Create a custom Replication Endpoint that streams WALEntry directly through > client API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14899) Create custom Streaming ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-14899: Status: Patch Available (was: Open) patch v1 > Create custom Streaming ReplicationEndpoint > --- > > Key: HBASE-14899 > URL: https://issues.apache.org/jira/browse/HBASE-14899 > Project: HBase > Issue Type: New Feature > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel > Fix For: 2.0.0 > > Attachments: HBASE-14900.master.patch > > > Create a custom Replication Endpoint that streams WALEntry directly through > client API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14899) Create custom Streaming ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-14899: Attachment: (was: HBASE-14900.master.patch) > Create custom Streaming ReplicationEndpoint > --- > > Key: HBASE-14899 > URL: https://issues.apache.org/jira/browse/HBASE-14899 > Project: HBase > Issue Type: New Feature > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel > Fix For: 2.0.0 > > > Create a custom Replication Endpoint that streams WALEntry directly through > client API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14900) Make global config option for ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-14900: Attachment: HBASE-14900.master.patch patch v1 > Make global config option for ReplicationEndpoint > - > > Key: HBASE-14900 > URL: https://issues.apache.org/jira/browse/HBASE-14900 > Project: HBase > Issue Type: Sub-task > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14900.master.patch > > > Currently ReplicationEndpoint implementations can only be configured through > the HBase shell. We should be able to to use a property in the hbase-site.xml > to globally set an alternate default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14899) Create custom Streaming ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-14899: Status: Open (was: Patch Available) > Create custom Streaming ReplicationEndpoint > --- > > Key: HBASE-14899 > URL: https://issues.apache.org/jira/browse/HBASE-14899 > Project: HBase > Issue Type: New Feature > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel > Fix For: 2.0.0 > > > Create a custom Replication Endpoint that streams WALEntry directly through > client API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14900) Make global config option for ReplicationEndpoint
[ https://issues.apache.org/jira/browse/HBASE-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-14900: Labels: easyfix patch (was: ) Status: Patch Available (was: Open) > Make global config option for ReplicationEndpoint > - > > Key: HBASE-14900 > URL: https://issues.apache.org/jira/browse/HBASE-14900 > Project: HBase > Issue Type: Sub-task > Components: Replication >Affects Versions: 2.0.0 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Labels: easyfix, patch > Fix For: 2.0.0 > > Attachments: HBASE-14900.master.patch > > > Currently ReplicationEndpoint implementations can only be configured through > the HBase shell. We should be able to to use a property in the hbase-site.xml > to globally set an alternate default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462009#comment-13462009 ] Cody Marcel commented on HBASE-5961: We should add this to the src. > New standard HBase code formatter > - > > Key: HBASE-5961 > URL: https://issues.apache.org/jira/browse/HBASE-5961 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Jesse Yates >Priority: Minor > Attachments: HBase-Formmatter.xml > > > There is currently no good way of passing out the formmatter currently the > 'standard' in HBase. The standard Apache formatter is actually not very close > to what we are considering 'good'/'pretty' code. Further, its not trivial to > get a good formatter setup. > Proposing two things: > 1) Adding a formmatter to the dev tools and calling out the formmatter usage > in the docs > 2) Move to a 'better' formmatter that is not the standard apache formmatter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-3896: --- Assignee: Cody Marcel > Make AssignmentManager standalone testable by having its constructor take > Interfaces rather than a CatalogTracker and a ServerManager > - > > Key: HBASE-3896 > URL: https://issues.apache.org/jira/browse/HBASE-3896 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: Cody Marcel > > If we could stand up an instance of AssignmentManager, a core fat class that > has a bunch of critical logic managing state transitions, then it'd be easier > writing unit tests around its logic. Currently its hard because it takes a > ServerManager and a CatalogTracker, but a little bit of work could turn these > into Interfaces. SM looks easy to do. Changing CT into an Interface instead > might ripple a little through the code base but it'd probably be well worth > it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462156#comment-13462156 ] Cody Marcel commented on HBASE-3896: Mockito allows you to work with the class directly, but it seems that there is still advantage to working on an interface. It would certainly make it more injection friendly later. This is what I had in mind for the ServerManger. Rename ServerManager -> BaseServerManager extract interface from that and name it ServerManager. > Make AssignmentManager standalone testable by having its constructor take > Interfaces rather than a CatalogTracker and a ServerManager > - > > Key: HBASE-3896 > URL: https://issues.apache.org/jira/browse/HBASE-3896 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: Cody Marcel > > If we could stand up an instance of AssignmentManager, a core fat class that > has a bunch of critical logic managing state transitions, then it'd be easier > writing unit tests around its logic. Currently its hard because it takes a > ServerManager and a CatalogTracker, but a little bit of work could turn these > into Interfaces. SM looks easy to do. Changing CT into an Interface instead > might ripple a little through the code base but it'd probably be well worth > it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462851#comment-13462851 ] Cody Marcel commented on HBASE-5961: Nice! > New standard HBase code formatter > - > > Key: HBASE-5961 > URL: https://issues.apache.org/jira/browse/HBASE-5961 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Jesse Yates >Priority: Minor > Attachments: HBase-Formmatter.xml > > > There is currently no good way of passing out the formmatter currently the > 'standard' in HBase. The standard Apache formatter is actually not very close > to what we are considering 'good'/'pretty' code. Further, its not trivial to > get a good formatter setup. > Proposing two things: > 1) Adding a formmatter to the dev tools and calling out the formmatter usage > in the docs > 2) Move to a 'better' formmatter that is not the standard apache formmatter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463953#comment-13463953 ] Cody Marcel commented on HBASE-3896: I looked into splitting SM up a bit on the interface. There doesn't seem to be a clear logical line between the methods used by HMaster vs. AM. There is also some overlap of methods used in both. i.e. isClusterShutdown isServerOnline createDestinationServersList getDeadServers > Make AssignmentManager standalone testable by having its constructor take > Interfaces rather than a CatalogTracker and a ServerManager > - > > Key: HBASE-3896 > URL: https://issues.apache.org/jira/browse/HBASE-3896 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: Cody Marcel > > If we could stand up an instance of AssignmentManager, a core fat class that > has a bunch of critical logic managing state transitions, then it'd be easier > writing unit tests around its logic. Currently its hard because it takes a > ServerManager and a CatalogTracker, but a little bit of work could turn these > into Interfaces. SM looks easy to do. Changing CT into an Interface instead > might ripple a little through the code base but it'd probably be well worth > it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-6886) Extract Interface from ServerManager
Cody Marcel created HBASE-6886: -- Summary: Extract Interface from ServerManager Key: HBASE-6886 URL: https://issues.apache.org/jira/browse/HBASE-6886 Project: HBase Issue Type: Sub-task Reporter: Cody Marcel Making a subtask for ServerManager to keep changelists smaller -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463968#comment-13463968 ] Cody Marcel commented on HBASE-3896: I am making subtasks for this to break the changes up into smaller change lists. > Make AssignmentManager standalone testable by having its constructor take > Interfaces rather than a CatalogTracker and a ServerManager > - > > Key: HBASE-3896 > URL: https://issues.apache.org/jira/browse/HBASE-3896 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: Cody Marcel > > If we could stand up an instance of AssignmentManager, a core fat class that > has a bunch of critical logic managing state transitions, then it'd be easier > writing unit tests around its logic. Currently its hard because it takes a > ServerManager and a CatalogTracker, but a little bit of work could turn these > into Interfaces. SM looks easy to do. Changing CT into an Interface instead > might ripple a little through the code base but it'd probably be well worth > it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-3896 started by Cody Marcel. > Make AssignmentManager standalone testable by having its constructor take > Interfaces rather than a CatalogTracker and a ServerManager > - > > Key: HBASE-3896 > URL: https://issues.apache.org/jira/browse/HBASE-3896 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: Cody Marcel > > If we could stand up an instance of AssignmentManager, a core fat class that > has a bunch of critical logic managing state transitions, then it'd be easier > writing unit tests around its logic. Currently its hard because it takes a > ServerManager and a CatalogTracker, but a little bit of work could turn these > into Interfaces. SM looks easy to do. Changing CT into an Interface instead > might ripple a little through the code base but it'd probably be well worth > it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6886) Extract Interface from ServerManager
[ https://issues.apache.org/jira/browse/HBASE-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-6886: --- Assignee: Cody Marcel > Extract Interface from ServerManager > > > Key: HBASE-6886 > URL: https://issues.apache.org/jira/browse/HBASE-6886 > Project: HBase > Issue Type: Sub-task >Reporter: Cody Marcel >Assignee: Cody Marcel > Labels: noob > > Making a subtask for ServerManager to keep changelists smaller -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-6886) Extract Interface from ServerManager
[ https://issues.apache.org/jira/browse/HBASE-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-6886 started by Cody Marcel. > Extract Interface from ServerManager > > > Key: HBASE-6886 > URL: https://issues.apache.org/jira/browse/HBASE-6886 > Project: HBase > Issue Type: Sub-task >Reporter: Cody Marcel >Assignee: Cody Marcel > Labels: noob > > Making a subtask for ServerManager to keep changelists smaller -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5961) New standard HBase code formatter
[ https://issues.apache.org/jira/browse/HBASE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464124#comment-13464124 ] Cody Marcel commented on HBASE-5961: +1 to adding the licences. > New standard HBase code formatter > - > > Key: HBASE-5961 > URL: https://issues.apache.org/jira/browse/HBASE-5961 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Jesse Yates >Priority: Minor > Fix For: 0.96.0 > > Attachments: 5961-addendum.txt, HBase-Formmatter.xml > > > There is currently no good way of passing out the formmatter currently the > 'standard' in HBase. The standard Apache formatter is actually not very close > to what we are considering 'good'/'pretty' code. Further, its not trivial to > get a good formatter setup. > Proposing two things: > 1) Adding a formmatter to the dev tools and calling out the formmatter usage > in the docs > 2) Move to a 'better' formmatter that is not the standard apache formmatter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464144#comment-13464144 ] Cody Marcel commented on HBASE-3896: I still think it would be an overall cleaner solution to have interfaces and true mock implementations that can be reused elsewhere, but I don't have strong opinions on it. Any advantage would be minimal at best. I was mainly looking for something easy to get my feet wet. I will close this. > Make AssignmentManager standalone testable by having its constructor take > Interfaces rather than a CatalogTracker and a ServerManager > - > > Key: HBASE-3896 > URL: https://issues.apache.org/jira/browse/HBASE-3896 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: Cody Marcel > > If we could stand up an instance of AssignmentManager, a core fat class that > has a bunch of critical logic managing state transitions, then it'd be easier > writing unit tests around its logic. Currently its hard because it takes a > ServerManager and a CatalogTracker, but a little bit of work could turn these > into Interfaces. SM looks easy to do. Changing CT into an Interface instead > might ripple a little through the code base but it'd probably be well worth > it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work stopped] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-3896 stopped by Cody Marcel. > Make AssignmentManager standalone testable by having its constructor take > Interfaces rather than a CatalogTracker and a ServerManager > - > > Key: HBASE-3896 > URL: https://issues.apache.org/jira/browse/HBASE-3896 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: Cody Marcel > > If we could stand up an instance of AssignmentManager, a core fat class that > has a bunch of critical logic managing state transitions, then it'd be easier > writing unit tests around its logic. Currently its hard because it takes a > ServerManager and a CatalogTracker, but a little bit of work could turn these > into Interfaces. SM looks easy to do. Changing CT into an Interface instead > might ripple a little through the code base but it'd probably be well worth > it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager
[ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel resolved HBASE-3896. Resolution: Won't Fix > Make AssignmentManager standalone testable by having its constructor take > Interfaces rather than a CatalogTracker and a ServerManager > - > > Key: HBASE-3896 > URL: https://issues.apache.org/jira/browse/HBASE-3896 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: Cody Marcel > > If we could stand up an instance of AssignmentManager, a core fat class that > has a bunch of critical logic managing state transitions, then it'd be easier > writing unit tests around its logic. Currently its hard because it takes a > ServerManager and a CatalogTracker, but a little bit of work could turn these > into Interfaces. SM looks easy to do. Changing CT into an Interface instead > might ripple a little through the code base but it'd probably be well worth > it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work stopped] (HBASE-6886) Extract Interface from ServerManager
[ https://issues.apache.org/jira/browse/HBASE-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-6886 stopped by Cody Marcel. > Extract Interface from ServerManager > > > Key: HBASE-6886 > URL: https://issues.apache.org/jira/browse/HBASE-6886 > Project: HBase > Issue Type: Sub-task >Reporter: Cody Marcel >Assignee: Cody Marcel > Labels: noob > > Making a subtask for ServerManager to keep changelists smaller -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-6886) Extract Interface from ServerManager
[ https://issues.apache.org/jira/browse/HBASE-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel resolved HBASE-6886. Resolution: Won't Fix see parent comments > Extract Interface from ServerManager > > > Key: HBASE-6886 > URL: https://issues.apache.org/jira/browse/HBASE-6886 > Project: HBase > Issue Type: Sub-task >Reporter: Cody Marcel >Assignee: Cody Marcel > Labels: noob > > Making a subtask for ServerManager to keep changelists smaller -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-9506) Backup masters hyperlinks missing the http.
Cody Marcel created HBASE-9506: -- Summary: Backup masters hyperlinks missing the http. Key: HBASE-9506 URL: https://issues.apache.org/jira/browse/HBASE-9506 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.94.10 Reporter: Cody Marcel Priority: Minor Hyperlinks for the backup masters are missing the http. This is causing the host names to be interpreted as the protocol in the web browser. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9506) Backup masters hyperlinks missing the http.
[ https://issues.apache.org/jira/browse/HBASE-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764729#comment-13764729 ] Cody Marcel commented on HBASE-9506: [~jdcryans] Do you want to back port your patch? Otherwise I can do it. > Backup masters hyperlinks missing the http. > --- > > Key: HBASE-9506 > URL: https://issues.apache.org/jira/browse/HBASE-9506 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 0.94.10 >Reporter: Cody Marcel >Priority: Minor > > Hyperlinks for the backup masters are missing the http. This is causing the > host names to be interpreted as the protocol in the web browser. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9506) Backup masters hyperlinks missing the http.
[ https://issues.apache.org/jira/browse/HBASE-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764706#comment-13764706 ] Cody Marcel commented on HBASE-9506: BTW, this only effect the UI. It should be a minor fix to the jamon pages. > Backup masters hyperlinks missing the http. > --- > > Key: HBASE-9506 > URL: https://issues.apache.org/jira/browse/HBASE-9506 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 0.94.10 >Reporter: Cody Marcel >Priority: Minor > > Hyperlinks for the backup masters are missing the http. This is causing the > host names to be interpreted as the protocol in the web browser. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: Trunk_Master.png > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, master.png, > Trunk_Master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: Trunk_Backup_Master.png > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: (was: Trunk_Backup_Master.png) > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: (was: Trunk_Master.png) > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: Trunk_Master.png Trunk_Backup_Master.png > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, master.png, > Trunk_Backup_Master.png, Trunk_Master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686858#comment-13686858 ] Cody Marcel commented on HBASE-5083: I added some screen shots for how trunk will look with the changes. I am getting the patch ready now. Let me know if there is something you don't like about the layout. > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, master.png, > Trunk_Backup_Master.png, Trunk_Master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: HBASE-5083_trunk.patch Trunk patch added. > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, HBASE-5083_trunk.patch, > master.png, Trunk_Backup_Master.png, Trunk_Master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687081#comment-13687081 ] Cody Marcel commented on HBASE-5083: [~saint@gmail.com] I can split it up if you, but I didn't see a clean dividing line since this changes the UI to display different things based on whether it is active or not. If you feel strongly about it, I am happy to oblige. Otherwise, I thinks it's good to go. > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, HBASE-5083_trunk.patch, > master.png, Trunk_Backup_Master.png, Trunk_Master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687261#comment-13687261 ] Cody Marcel commented on HBASE-5083: The latest patch has the trunk version of the files. I am not sure why Hadoop QA didn't run on it. The trunk version should pass. > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, HBASE-5083_trunk.patch, > master.png, Trunk_Backup_Master.png, Trunk_Master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692357#comment-13692357 ] Cody Marcel commented on HBASE-5083: Thanks for fixing up the spaces. > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: 5083-0.94-v2.txt, 5083-trunk-v2.txt, backup_master.png, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083_trunk.patch, HBASE-5083_trunk.patch, > HBASE-5083_trunk.patch, master.png, Trunk_Backup_Master.png, Trunk_Master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HBASE-10285) All for configurable policies in ChaosMonkey
Cody Marcel created HBASE-10285: --- Summary: All for configurable policies in ChaosMonkey Key: HBASE-10285 URL: https://issues.apache.org/jira/browse/HBASE-10285 Project: HBase Issue Type: Improvement Components: test Affects Versions: 0.94.16 Reporter: Cody Marcel Assignee: Cody Marcel Priority: Minor Fix For: 0.94.16 For command line runs of ChaosMonkey, we should be able to pass policies. They are currently hard coded to EVERY_MINUTE_RANDOM_ACTION_POLICY. I have made this policy the default, but now if you supply a policy as an option on the command line, it will work. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10285) All for configurable policies in ChaosMonkey
[ https://issues.apache.org/jira/browse/HBASE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-10285: Status: Patch Available (was: In Progress) > All for configurable policies in ChaosMonkey > > > Key: HBASE-10285 > URL: https://issues.apache.org/jira/browse/HBASE-10285 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.16 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Fix For: 0.94.16 > > > For command line runs of ChaosMonkey, we should be able to pass policies. > They are currently hard coded to EVERY_MINUTE_RANDOM_ACTION_POLICY. I have > made this policy the default, but now if you supply a policy as an option on > the command line, it will work. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Work started] (HBASE-10285) All for configurable policies in ChaosMonkey
[ https://issues.apache.org/jira/browse/HBASE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-10285 started by Cody Marcel. > All for configurable policies in ChaosMonkey > > > Key: HBASE-10285 > URL: https://issues.apache.org/jira/browse/HBASE-10285 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.16 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Fix For: 0.94.16 > > > For command line runs of ChaosMonkey, we should be able to pass policies. > They are currently hard coded to EVERY_MINUTE_RANDOM_ACTION_POLICY. I have > made this policy the default, but now if you supply a policy as an option on > the command line, it will work. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10285) All for configurable policies in ChaosMonkey
[ https://issues.apache.org/jira/browse/HBASE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863554#comment-13863554 ] Cody Marcel commented on HBASE-10285: - It's a pretty small change to make this work on 0.94. Patch is coming. > All for configurable policies in ChaosMonkey > > > Key: HBASE-10285 > URL: https://issues.apache.org/jira/browse/HBASE-10285 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.16 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Fix For: 0.94.16 > > > For command line runs of ChaosMonkey, we should be able to pass policies. > They are currently hard coded to EVERY_MINUTE_RANDOM_ACTION_POLICY. I have > made this policy the default, but now if you supply a policy as an option on > the command line, it will work. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-10285) All for configurable policies in ChaosMonkey
[ https://issues.apache.org/jira/browse/HBASE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-10285: Attachment: HBASE-10285 > All for configurable policies in ChaosMonkey > > > Key: HBASE-10285 > URL: https://issues.apache.org/jira/browse/HBASE-10285 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.16 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Fix For: 0.94.16 > > Attachments: HBASE-10285 > > > For command line runs of ChaosMonkey, we should be able to pass policies. > They are currently hard coded to EVERY_MINUTE_RANDOM_ACTION_POLICY. I have > made this policy the default, but now if you supply a policy as an option on > the command line, it will work. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10285) All for configurable policies in ChaosMonkey
[ https://issues.apache.org/jira/browse/HBASE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863572#comment-13863572 ] Cody Marcel commented on HBASE-10285: - the syntax would be "-policy EVERY_MINUTE_RANDOM_ACTION_POLICY" > All for configurable policies in ChaosMonkey > > > Key: HBASE-10285 > URL: https://issues.apache.org/jira/browse/HBASE-10285 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.16 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Fix For: 0.94.16 > > Attachments: HBASE-10285 > > > For command line runs of ChaosMonkey, we should be able to pass policies. > They are currently hard coded to EVERY_MINUTE_RANDOM_ACTION_POLICY. I have > made this policy the default, but now if you supply a policy as an option on > the command line, it will work. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10285) All for configurable policies in ChaosMonkey
[ https://issues.apache.org/jira/browse/HBASE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863573#comment-13863573 ] Cody Marcel commented on HBASE-10285: - Including [~enis] [~jesse_yates] > All for configurable policies in ChaosMonkey > > > Key: HBASE-10285 > URL: https://issues.apache.org/jira/browse/HBASE-10285 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.16 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Fix For: 0.94.16 > > Attachments: HBASE-10285 > > > For command line runs of ChaosMonkey, we should be able to pass policies. > They are currently hard coded to EVERY_MINUTE_RANDOM_ACTION_POLICY. I have > made this policy the default, but now if you supply a policy as an option on > the command line, it will work. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10285) All for configurable policies in ChaosMonkey
[ https://issues.apache.org/jira/browse/HBASE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863701#comment-13863701 ] Cody Marcel commented on HBASE-10285: - This works quite a bit differently in trunk. What would you recommend there? > All for configurable policies in ChaosMonkey > > > Key: HBASE-10285 > URL: https://issues.apache.org/jira/browse/HBASE-10285 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.16 >Reporter: Cody Marcel >Assignee: Cody Marcel >Priority: Minor > Fix For: 0.94.16 > > Attachments: HBASE-10285, HBASE-10285.txt > > > For command line runs of ChaosMonkey, we should be able to pass policies. > They are currently hard coded to EVERY_MINUTE_RANDOM_ACTION_POLICY. I have > made this policy the default, but now if you supply a policy as an option on > the command line, it will work. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Assignee: Cody Marcel > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: master.png backup_master.png Screen shots for the UI > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.8 > > Attachments: backup_master.png, master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Fix Version/s: 0.94.8 Release Note: This patch includes adding a table for the backup masters to the UI of the master server. It also has a link from the backup master server's UI to point to the primary. Status: Patch Available (was: Open) I tried setting up a review for this, but it failed: The file 'src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon' (r238d2ad) could not be found in the repository > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.8 > > Attachments: backup_master.png, master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: HBASE-5083.patch > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.8 > > Attachments: backup_master.png, HBASE-5083.patch, master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: HBASE-5083.patch Merged local commits to correct the diff. > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.8 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668791#comment-13668791 ] Cody Marcel commented on HBASE-5083: [~jmhsieh] THis already exists in trunk, mostly. I am backporting to 0.94. > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.8 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5083) Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668796#comment-13668796 ] Cody Marcel commented on HBASE-5083: Review board is up now with the fixed diff. > Backup HMaster should have http infoport open with link to the active master > > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.8 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backport from trunk: Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Summary: Backport from trunk: Backup HMaster should have http infoport open with link to the active master (was: Backup HMaster should have http infoport open with link to the active master) > Backport from trunk: Backup HMaster should have http infoport open with link > to the active master > - > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.8 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backport from trunk: Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: HBASE-5083.patch Added a test fix to the patch. > Backport from trunk: Backup HMaster should have http infoport open with link > to the active master > - > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backport from trunk: Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: HBASE-5083.patch Fixed hard coded port. > Backport from trunk: Backup HMaster should have http infoport open with link > to the active master > - > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5083) Backport from trunk: Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-5083: --- Attachment: HBASE-5083.patch > Backport from trunk: Backup HMaster should have http infoport open with link > to the active master > - > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5083) Backport from trunk: Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676078#comment-13676078 ] Cody Marcel commented on HBASE-5083: Sorry, I accidentally left the last commit off the diff. This one should no longer have any hard coded. > Backport from trunk: Backup HMaster should have http infoport open with link > to the active master > - > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5083) Backport from trunk: Backup HMaster should have http infoport open with link to the active master
[ https://issues.apache.org/jira/browse/HBASE-5083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676535#comment-13676535 ] Cody Marcel commented on HBASE-5083: I believe [~jesse_yates] said that hadoopqa goes against trunk so it will fail. Maybe I have it wrong though. Is there a flag I need to add when generating the diff? > Backport from trunk: Backup HMaster should have http infoport open with link > to the active master > - > > Key: HBASE-5083 > URL: https://issues.apache.org/jira/browse/HBASE-5083 > Project: HBase > Issue Type: Improvement > Components: master >Affects Versions: 0.92.0 >Reporter: Jonathan Hsieh >Assignee: Cody Marcel > Fix For: 0.94.9 > > Attachments: backup_master.png, HBASE-5083.patch, HBASE-5083.patch, > HBASE-5083.patch, HBASE-5083.patch, HBASE-5083.patch, master.png > > > Without ssh'ing and jps/ps'ing, it is difficult to see if a backup hmaster is > up. It seems like it would be good for a backup hmaster to have a basic web > page up on the info port so that users could see that it is up. Also it > should probably either provide a link to the active master or automatically > forward to the active master. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6990) Pretty print TTL
[ https://issues.apache.org/jira/browse/HBASE-6990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507532#comment-13507532 ] Cody Marcel commented on HBASE-6990: Do you know what class this is being logged from? The only place I have found that is logging ttl is TimeToLiveHFileCleaner. > Pretty print TTL > > > Key: HBASE-6990 > URL: https://issues.apache.org/jira/browse/HBASE-6990 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.92.2, 0.94.2 >Reporter: Jean-Daniel Cryans >Assignee: Kevin Odell >Priority: Minor > Fix For: 0.92.3, 0.96.0, 0.94.4 > > > I've seen a lot of users getting confused by the TTL configuration and I > think that if we just pretty printed it it would solve most of the issues. > For example, let's say a user wanted to set a TTL of 90 days. That would be > 7776000. But let's say that it was typo'd to 7776 instead, it gives you > 900 days! > So when we print the TTL we could do something like "x days, x hours, x > minutes, x seconds (real_ttl_value)". This would also help people when they > use ms instead of seconds as they would see really big values in there. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
