[jira] Updated: (HBASE-2495) Allow record filtering with selected row key values in HBase Export

2011-03-14 Thread Ian Knome (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ian Knome updated HBASE-2495:
-

Attachment: 
HBASE-2495_-_Allow_record_filtering_with_selected_row_key_values_in_HBase_Export.patch

 Allow record filtering with selected row key values in HBase Export
 ---

 Key: HBASE-2495
 URL: https://issues.apache.org/jira/browse/HBASE-2495
 Project: HBase
  Issue Type: Improvement
  Components: util
Affects Versions: 0.20.3
Reporter: Ted Yu
  Labels: moved_from_0_20_5
 Fix For: 0.92.0

 Attachments: 
 HBASE-2495_-_Allow_record_filtering_with_selected_row_key_values_in_HBase_Export.patch


 It is desirable to add record filtering capability to HBase Export.
 The following code is an example (s is the Scan):
   byte [] prefix = Bytes.toBytes(args[5]);
   if (args[5].startsWith(^))
   {
   s.setFilter(new RowFilter(CompareOp.EQUAL, new 
 RegexStringComparator(args[5])));
   }
   else s.setFilter(new PrefixFilter(prefix));

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Commented: (HBASE-2495) Allow record filtering with selected row key values in HBase Export

2011-03-14 Thread Ian Knome (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006791#comment-13006791
 ] 

Ian Knome commented on HBASE-2495:
--

First version of patch for review.

I have tested the fix on my local cluster and the export now works with an 
optional filter criteria.

I am not sure about unit tests for this. Any thoughts? Suggestions?

 Allow record filtering with selected row key values in HBase Export
 ---

 Key: HBASE-2495
 URL: https://issues.apache.org/jira/browse/HBASE-2495
 Project: HBase
  Issue Type: Improvement
  Components: util
Affects Versions: 0.20.3
Reporter: Ted Yu
  Labels: moved_from_0_20_5
 Fix For: 0.92.0

 Attachments: 
 HBASE-2495_-_Allow_record_filtering_with_selected_row_key_values_in_HBase_Export.patch


 It is desirable to add record filtering capability to HBase Export.
 The following code is an example (s is the Scan):
   byte [] prefix = Bytes.toBytes(args[5]);
   if (args[5].startsWith(^))
   {
   s.setFilter(new RowFilter(CompareOp.EQUAL, new 
 RegexStringComparator(args[5])));
   }
   else s.setFilter(new PrefixFilter(prefix));

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Updated: (HBASE-3538) Column families allow to have slashes in name

2011-03-11 Thread Ian Knome (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ian Knome updated HBASE-3538:
-

Attachment: 
HBASE-3538_-_ColumnFamily_names_to_not_have_slashes_in_their_names_.patch

1. First draft to ignore back as well as forward slashes in column family names.

2. Added a simple test to validate that column family name does not include 
slashes.

 Column families allow to have slashes in name
 -

 Key: HBASE-3538
 URL: https://issues.apache.org/jira/browse/HBASE-3538
 Project: HBase
  Issue Type: Bug
  Components: regionserver
Affects Versions: 0.90.0
Reporter: Lars George
 Fix For: 0.92.0

 Attachments: 
 HBASE-3538_-_ColumnFamily_names_to_not_have_slashes_in_their_names_.patch


 The check in HColumnDescriptor.isLegalFamilyName() does not check for slashes 
 and may cause issue.
 {code}
 create 'test2', 'cf/am/2'
 $ bin/hadoop dfs -lsr /hbase/test2/d1da5042d2b233f056f7604398f29537
 drwxr-xr-x   - larsgeorge supergroup  0 2011-02-15 21:12 
 /hbase/test2/d1da5042d2b233f056f7604398f29537/.oldlogs
 -rw-r--r--   3 larsgeorge supergroup124 2011-02-15 21:12 
 /hbase/test2/d1da5042d2b233f056f7604398f29537/.oldlogs/hlog.1297800748239
 -rw-r--r--   3 larsgeorge supergroup714 2011-02-15 21:12 
 /hbase/test2/d1da5042d2b233f056f7604398f29537/.regioninfo
 drwxr-xr-x   - larsgeorge supergroup  0 2011-02-15 21:12 
 /hbase/test2/d1da5042d2b233f056f7604398f29537/cf
 drwxr-xr-x   - larsgeorge supergroup  0 2011-02-15 21:12 
 /hbase/test2/d1da5042d2b233f056f7604398f29537/cf/am
 drwxr-xr-x   - larsgeorge supergroup  0 2011-02-15 21:12 
 /hbase/test2/d1da5042d2b233f056f7604398f29537/cf/am/2
 {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Updated: (HBASE-3580) Remove RS from DeadServer when new instance checks in

2011-03-04 Thread Ian Knome (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ian Knome updated HBASE-3580:
-

Attachment: 
HBASE-3580_-_Remove_RS_from_dead_server_when_the_RS_when_new_instance_checks_in3.patch

1. Added test cases
2. Fixed the logic as per jdcryans suggestions.

 Remove RS from DeadServer when new instance checks in
 -

 Key: HBASE-3580
 URL: https://issues.apache.org/jira/browse/HBASE-3580
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.0
Reporter: Jean-Daniel Cryans
 Fix For: 0.90.2

 Attachments: 
 HBASE-3580-Remove-RS-from-DeadServer-when-new-instance-checks-in.patch, 
 HBASE-3580_-_Remove_RS_from_dead_server_when_the_RS_when_new_instance_checks_in3.patch


 Keeping the servers in DeadServer until it reaches some maximum isn't super 
 friendly, it confuses even the best of our users:
 {quote}
 09:27  gbowyer Hi all, I have apparently three dead RS in my cluster, I 
 cannot find references to them in HDFS or in ZK, how do I still report dead RS
 09:27  gbowyer also the same nodes are reported as live region servers
 {quote}
 The subtil startcode difference can be hard to catch, also this behavior 
 differs from 0.20 (so old users get confused, like I did when debugging this 
 problem) and it also differs from Hadoop's handling of dead DataNodes. It was 
 introduced in HBASE-3282.
 I think this should be improved by doing like Hadoop does, removing the RS 
 from DeadServers when a new instance with the same hostname+port checks in. 
 Stack says we should do it in ServerManager.checkIsDead

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (HBASE-3580) Remove RS from DeadServer when new instance checks in

2011-03-01 Thread Ian Knome (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ian Knome updated HBASE-3580:
-

Attachment: 
HBASE-3580-Remove-RS-from-DeadServer-when-new-instance-checks-in.patch

As per conversation with jdcryans:
1. Removed the deadServerList
2. Check whether the server reporting for duty is a dead one coming back alive, 
and if so, update the deadserverList and remove this server. 

 Remove RS from DeadServer when new instance checks in
 -

 Key: HBASE-3580
 URL: https://issues.apache.org/jira/browse/HBASE-3580
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.0
Reporter: Jean-Daniel Cryans
 Fix For: 0.90.2

 Attachments: 
 HBASE-3580-Remove-RS-from-DeadServer-when-new-instance-checks-in.patch


 Keeping the servers in DeadServer until it reaches some maximum isn't super 
 friendly, it confuses even the best of our users:
 {quote}
 09:27  gbowyer Hi all, I have apparently three dead RS in my cluster, I 
 cannot find references to them in HDFS or in ZK, how do I still report dead RS
 09:27  gbowyer also the same nodes are reported as live region servers
 {quote}
 The subtil startcode difference can be hard to catch, also this behavior 
 differs from 0.20 (so old users get confused, like I did when debugging this 
 problem) and it also differs from Hadoop's handling of dead DataNodes. It was 
 introduced in HBASE-3282.
 I think this should be improved by doing like Hadoop does, removing the RS 
 from DeadServers when a new instance with the same hostname+port checks in. 
 Stack says we should do it in ServerManager.checkIsDead

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (HBASE-3580) Remove RS from DeadServer when new instance checks in

2011-03-01 Thread Ian Knome (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001217#comment-13001217
 ] 

Ian Knome commented on HBASE-3580:
--

Submitted first draft of the patch. 

Will include/update necessary test cases based on review comments. 

 Remove RS from DeadServer when new instance checks in
 -

 Key: HBASE-3580
 URL: https://issues.apache.org/jira/browse/HBASE-3580
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.0
Reporter: Jean-Daniel Cryans
 Fix For: 0.90.2

 Attachments: 
 HBASE-3580-Remove-RS-from-DeadServer-when-new-instance-checks-in.patch


 Keeping the servers in DeadServer until it reaches some maximum isn't super 
 friendly, it confuses even the best of our users:
 {quote}
 09:27  gbowyer Hi all, I have apparently three dead RS in my cluster, I 
 cannot find references to them in HDFS or in ZK, how do I still report dead RS
 09:27  gbowyer also the same nodes are reported as live region servers
 {quote}
 The subtil startcode difference can be hard to catch, also this behavior 
 differs from 0.20 (so old users get confused, like I did when debugging this 
 problem) and it also differs from Hadoop's handling of dead DataNodes. It was 
 introduced in HBASE-3282.
 I think this should be improved by doing like Hadoop does, removing the RS 
 from DeadServers when a new instance with the same hostname+port checks in. 
 Stack says we should do it in ServerManager.checkIsDead

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira