[jira] [Created] (HBASE-9820) Method Replication.decorateMasterConfiguration can fail with NPE in case that property HBASE_MASTER_LOGCLEANER_PLUGINS is not defined
Jarek Jarcec Cecho created HBASE-9820: - Summary: Method Replication.decorateMasterConfiguration can fail with NPE in case that property HBASE_MASTER_LOGCLEANER_PLUGINS is not defined Key: HBASE-9820 URL: https://issues.apache.org/jira/browse/HBASE-9820 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: Jarek Jarcec Cecho While upgrading HBase dependency on Pig via PIG-3529, I've noticed that method {{Replication.decorateMasterConfiguration()}} can throw {{NullPointerException}} ([code|https://github.com/apache/hbase/blob/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java]) in case when property HBASE_MASTER_LOGCLEANER_PLUGINS won't be defined. The issue was more on a pig side where we weren't propagating default HBase configuration resources (such as {{hbase-default.xml}}), but I was curious if it's expected that this property will be always defined? We might want to tweak the code a bit if this property can be null. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-9744) Set io.serializations correctly in HFileOutputFormat.configureIncrementalLoad
[ https://issues.apache.org/jira/browse/HBASE-9744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13792102#comment-13792102 ] Jarek Jarcec Cecho commented on HBASE-9744: --- Thank you both [~jdcryans] for helping me out with this and [~ndimiduk] for the quick review! Set io.serializations correctly in HFileOutputFormat.configureIncrementalLoad - Key: HBASE-9744 URL: https://issues.apache.org/jira/browse/HBASE-9744 Project: HBase Issue Type: Improvement Affects Versions: 0.96.0 Reporter: Jean-Daniel Cryans Assignee: Jean-Daniel Cryans Priority: Minor Fix For: 0.96.1 Attachments: HBASE-9744.patch HFileOutputFormat.configureIncrementalLoad is not setting all the io serializations correctly so custom bulk loaders (like ImportTsv) need to set it. Simple fix, just add what's missing. In case someone doesn't get this patch but upgrades to an old RC, this is what you'll see when running via YARN (or similar if MR1): {noformat} 2013-10-10 09:48:13,836 WARN [main] org.apache.hadoop.mapred.YarnChild: Exception running child : java.lang.NullPointerException at org.apache.hadoop.mapred.MapTask$MapOutputBuffer.init(MapTask.java:989) at org.apache.hadoop.mapred.MapTask.createSortingCollector(MapTask.java:390) at org.apache.hadoop.mapred.MapTask.access$100(MapTask.java:79) at org.apache.hadoop.mapred.MapTask$NewOutputCollector.init(MapTask.java:674) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:746) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:339) at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:165) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:415) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1485) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:160) {noformat} Kudos to [~jarcec] for finding the issue. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-8462) Custom timestamps should not be allowed to be negative
[ https://issues.apache.org/jira/browse/HBASE-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758836#comment-13758836 ] Jarek Jarcec Cecho commented on HBASE-8462: --- The fixVersion is currently set to 0.98.0 and 0.96.0, however the patch also seems to be available in 0.95. So I'm wondering whether it would make sense to add 0.95.3 to fixVersion as well? Custom timestamps should not be allowed to be negative -- Key: HBASE-8462 URL: https://issues.apache.org/jira/browse/HBASE-8462 Project: HBase Issue Type: Bug Components: Client Reporter: Enis Soztutar Assignee: Enis Soztutar Fix For: 0.98.0, 0.96.0 Attachments: hbase-8462_v1.patch, hbase-8462_v2.patch, hbase-8462_v3.patch Client supplied timestamps should not be allowed to be negative, otherwise unpredictable results will follow. Especially, since we are encoding the ts using Bytes.Bytes(long), negative timestamps are sorted after positive ones. Plus, the new PB messages define ts' as uint64. Credit goes to Huned Lokhandwala for reporting this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8462) Custom timestamps should not be allowed to be negative
[ https://issues.apache.org/jira/browse/HBASE-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13759073#comment-13759073 ] Jarek Jarcec Cecho commented on HBASE-8462: --- [~stack], I see, understood, thank you for your feedback sir! Custom timestamps should not be allowed to be negative -- Key: HBASE-8462 URL: https://issues.apache.org/jira/browse/HBASE-8462 Project: HBase Issue Type: Bug Components: Client Reporter: Enis Soztutar Assignee: Enis Soztutar Fix For: 0.98.0, 0.96.0 Attachments: hbase-8462_v1.patch, hbase-8462_v2.patch, hbase-8462_v3.patch Client supplied timestamps should not be allowed to be negative, otherwise unpredictable results will follow. Especially, since we are encoding the ts using Bytes.Bytes(long), negative timestamps are sorted after positive ones. Plus, the new PB messages define ts' as uint64. Credit goes to Huned Lokhandwala for reporting this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6929) Publish Hbase 0.94 artifacts build against hadoop-2.0
[ https://issues.apache.org/jira/browse/HBASE-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497422#comment-13497422 ] Jarek Jarcec Cecho commented on HBASE-6929: --- I definitely agree with Hari - forcing users to build their own HBase in order to test Sqoop do not seems as a good way to go, so I would prefer available upstream jar if possible. I don't mind having version hbase-0.94.2-hadoop2-SNAPSHOT with the SNAPSHOT part. I'll properly document why we're depending on SNAPSHOT and link this issue for better understanding... Jarcec Publish Hbase 0.94 artifacts build against hadoop-2.0 - Key: HBASE-6929 URL: https://issues.apache.org/jira/browse/HBASE-6929 Project: HBase Issue Type: Task Components: build Affects Versions: 0.94.2 Reporter: Enis Soztutar Attachments: 6929.txt, hbase-6929_v2.patch Downstream projects (flume, hive, pig, etc) depends on hbase, but since the hbase binaries build with hadoop-2.0 are not pushed to maven, they cannot depend on them. AFAIK, hadoop 1 and 2 are not binary compatible, so we should also push hbase jars build with hadoop2.0 profile into maven, possibly with version string like 0.94.2-hadoop2.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6929) Publish Hbase 0.94 artifacts build against hadoop-2.0
[ https://issues.apache.org/jira/browse/HBASE-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481755#comment-13481755 ] Jarek Jarcec Cecho commented on HBASE-6929: --- Another idea - version number can contain string. So instead of creating special dot release, what about creating release ${normalversion}-hadoop2? Publish Hbase 0.94 artifacts build against hadoop-2.0 - Key: HBASE-6929 URL: https://issues.apache.org/jira/browse/HBASE-6929 Project: HBase Issue Type: Task Components: build Affects Versions: 0.94.2 Reporter: Enis Soztutar Attachments: 6929.txt, hbase-6929_v2.patch Downstream projects (flume, hive, pig, etc) depends on hbase, but since the hbase binaries build with hadoop-2.0 are not pushed to maven, they cannot depend on them. AFAIK, hadoop 1 and 2 are not binary compatible, so we should also push hbase jars build with hadoop2.0 profile into maven, possibly with version string like 0.94.2-hadoop2.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6929) Publish Hbase 0.94 artifacts build against hadoop-2.0
[ https://issues.apache.org/jira/browse/HBASE-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481845#comment-13481845 ] Jarek Jarcec Cecho commented on HBASE-6929: --- [~enis] I see, I originally thought that you want to increase the version number. Adding -hadoop2 suffix seems as a reasonable workaround to me, but it's up to you HBase guys to agree on the final solution :-) Publish Hbase 0.94 artifacts build against hadoop-2.0 - Key: HBASE-6929 URL: https://issues.apache.org/jira/browse/HBASE-6929 Project: HBase Issue Type: Task Components: build Affects Versions: 0.94.2 Reporter: Enis Soztutar Attachments: 6929.txt, hbase-6929_v2.patch Downstream projects (flume, hive, pig, etc) depends on hbase, but since the hbase binaries build with hadoop-2.0 are not pushed to maven, they cannot depend on them. AFAIK, hadoop 1 and 2 are not binary compatible, so we should also push hbase jars build with hadoop2.0 profile into maven, possibly with version string like 0.94.2-hadoop2.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6929) Publish Hbase 0.94 artifacts build against hadoop-2.0
[ https://issues.apache.org/jira/browse/HBASE-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13478415#comment-13478415 ] Jarek Jarcec Cecho commented on HBASE-6929: --- Another possible solution would be to provide artifact hbase-test that would have classifier either hadoop1 or hadoop2 based on for which version it was compiled. This solution would be probably step back as for example hadoop was using it in the past and has moved to classifiers, but it should be working without need to have special version for testing artifact compiled against hadoop2. Jarcec Publish Hbase 0.94 artifacts build against hadoop-2.0 - Key: HBASE-6929 URL: https://issues.apache.org/jira/browse/HBASE-6929 Project: HBase Issue Type: Task Components: build Affects Versions: 0.94.2 Reporter: Enis Soztutar Attachments: 6929.txt, hbase-6929_v2.patch Downstream projects (flume, hive, pig, etc) depends on hbase, but since the hbase binaries build with hadoop-2.0 are not pushed to maven, they cannot depend on them. AFAIK, hadoop 1 and 2 are not binary compatible, so we should also push hbase jars build with hadoop2.0 profile into maven, possibly with version string like 0.94.2-hadoop2.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6929) Publish Hbase 0.94 artifacts build against hadoop-2.0
[ https://issues.apache.org/jira/browse/HBASE-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13476176#comment-13476176 ] Jarek Jarcec Cecho commented on HBASE-6929: --- I can confirm that Sqoop needs this testing package to test hbase import feature. Jarcec Publish Hbase 0.94 artifacts build against hadoop-2.0 - Key: HBASE-6929 URL: https://issues.apache.org/jira/browse/HBASE-6929 Project: HBase Issue Type: Task Components: build Affects Versions: 0.94.2 Reporter: Enis Soztutar Attachments: 6929.txt Downstream projects (flume, hive, pig, etc) depends on hbase, but since the hbase binaries build with hadoop-2.0 are not pushed to maven, they cannot depend on them. AFAIK, hadoop 1 and 2 are not binary compatible, so we should also push hbase jars build with hadoop2.0 profile into maven, possibly with version string like 0.94.2-hadoop2.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6929) Publish Hbase 0.94 artifacts build against hadoop-2.0
[ https://issues.apache.org/jira/browse/HBASE-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475764#comment-13475764 ] Jarek Jarcec Cecho commented on HBASE-6929: --- Hi Sir, thank you very much for your time on this issue. Would you mind also providing test artifact compiled against hadoop 2? Jarcec Publish Hbase 0.94 artifacts build against hadoop-2.0 - Key: HBASE-6929 URL: https://issues.apache.org/jira/browse/HBASE-6929 Project: HBase Issue Type: Task Components: build Affects Versions: 0.94.2 Reporter: Enis Soztutar Attachments: 6929.txt Downstream projects (flume, hive, pig, etc) depends on hbase, but since the hbase binaries build with hadoop-2.0 are not pushed to maven, they cannot depend on them. AFAIK, hadoop 1 and 2 are not binary compatible, so we should also push hbase jars build with hadoop2.0 profile into maven, possibly with version string like 0.94.2-hadoop2.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6929) Publish Hbase 0.94 artifacts build against hadoop-2.0
[ https://issues.apache.org/jira/browse/HBASE-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475328#comment-13475328 ] Jarek Jarcec Cecho commented on HBASE-6929: --- I would like to support this ticket as Sqoop project also have issues with missing hbase jars compiled against hadoop 2. I would greatly appreciate if this will happen :-) Jarcec Publish Hbase 0.94 artifacts build against hadoop-2.0 - Key: HBASE-6929 URL: https://issues.apache.org/jira/browse/HBASE-6929 Project: HBase Issue Type: Task Components: build Affects Versions: 0.94.2 Reporter: Enis Soztutar Downstream projects (flume, hive, pig, etc) depends on hbase, but since the hbase binaries build with hadoop-2.0 are not pushed to maven, they cannot depend on them. AFAIK, hadoop 1 and 2 are not binary compatible, so we should also push hbase jars build with hadoop2.0 profile into maven, possibly with version string like 0.94.2-hadoop2.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira