[jira] [Updated] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingjie Lai updated HBASE-5514: --- Attachment: HBASE-5514-4.patch Per Ted's request: removed the redundant null check. Can we extract the new code into a helper class or method in org.apache.hadoop.hbase.regionserver.wal package ? It only occurs for 2 test cases, and the code duplication is quite small. Do you really think we should have one method to cover them? Compile against hadoop 0.24-SNAPSHOT Key: HBASE-5514 URL: https://issues.apache.org/jira/browse/HBASE-5514 Project: HBase Issue Type: Bug Components: build, test Affects Versions: 0.92.0, 0.94.0 Reporter: Mingjie Lai Assignee: Mingjie Lai Priority: Minor Fix For: 0.94.0 Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514-4.patch, HBASE-5514.patch Need to compile hbase against the latest hadoop trunk which just had NN HA merged in. 1) add a hadoop 0.24 profile 2) HBASE-5480 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingjie Lai updated HBASE-5514: --- Attachment: HBASE-5514-3.patch New patch: - add 0.24 profile to pom.xml - use reflection to determine which sync method to use in TestHLog and TestHLogSplit. Compile against hadoop 0.24-SNAPSHOT Key: HBASE-5514 URL: https://issues.apache.org/jira/browse/HBASE-5514 Project: HBase Issue Type: Bug Components: build, test Affects Versions: 0.92.0, 0.94.0 Reporter: Mingjie Lai Assignee: Mingjie Lai Priority: Minor Fix For: 0.94.0 Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514.patch Need to compile hbase against the latest hadoop trunk which just had NN HA merged in. 1) add a hadoop 0.24 profile 2) HBASE-5480 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingjie Lai updated HBASE-5514: --- Description: Need to compile hbase against the latest hadoop trunk which just had NN HA merged in. 1) add a hadoop 0.24 profile 2) HBASE-5480 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass. was:HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass. Summary: Compile against hadoop 0.24-SNAPSHOT (was: Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()) @Zhihong, thanks for pointing it out. I thought hadoop hflush() was brought at 0.20, but actually 0.21. As Zhihong mentioned, the scope is broader than I originally expected. Rename the title from ``Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()'' - ``Compile against hadoop 0.24-SNAPSHOT''. Compile against hadoop 0.24-SNAPSHOT Key: HBASE-5514 URL: https://issues.apache.org/jira/browse/HBASE-5514 Project: HBase Issue Type: Bug Components: build, test Affects Versions: 0.92.0, 0.94.0 Reporter: Mingjie Lai Assignee: Mingjie Lai Priority: Minor Fix For: 0.94.0 Attachments: HBASE-5514-2.patch, HBASE-5514.patch Need to compile hbase against the latest hadoop trunk which just had NN HA merged in. 1) add a hadoop 0.24 profile 2) HBASE-5480 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingjie Lai updated HBASE-5514: --- Attachment: HBASE-5514.patch Patch for trunk, 0.92. Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync() --- Key: HBASE-5514 URL: https://issues.apache.org/jira/browse/HBASE-5514 Project: HBase Issue Type: Bug Components: build, test Affects Versions: 0.92.0, 0.94.0 Reporter: Mingjie Lai Assignee: Mingjie Lai Priority: Minor Fix For: 0.94.0 Attachments: HBASE-5514.patch HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5514) Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync()
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingjie Lai updated HBASE-5514: --- Attachment: HBASE-5514-2.patch patch generated with --no-prefix Minor fixes to compile against Hadoop 0.24-SNAPSHOT: replace deprecated Syncable.sync() --- Key: HBASE-5514 URL: https://issues.apache.org/jira/browse/HBASE-5514 Project: HBase Issue Type: Bug Components: build, test Affects Versions: 0.92.0, 0.94.0 Reporter: Mingjie Lai Assignee: Mingjie Lai Priority: Minor Fix For: 0.94.0 Attachments: HBASE-5514-2.patch, HBASE-5514.patch HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call the deprecated sync(). Need to replace it with hflush() so the compilation can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4554) Allow set/unset coprocessor table attributes from shell.
[
https://issues.apache.org/jira/browse/HBASE-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingjie Lai updated HBASE-4554:
---
Status: Patch Available (was: In Progress)
Allow set/unset coprocessor table attributes from shell.
Key: HBASE-4554
URL: https://issues.apache.org/jira/browse/HBASE-4554
Project: HBase
Issue Type: Improvement
Components: coprocessors
Reporter: Mingjie Lai
Assignee: Mingjie Lai
Fix For: 0.92.0
Table/region level coprocessor -- RegionObserver -- can be configured by
setting a HTD's attribute which matches Coprocessor$*.
Current shell -- alter -- cannot support to set/unset a table's arbitrary
attribute. We need it in order to configure region level coprocessors to a
table.
Proposed new shell:
{code}
hbase shell alter 't1', METHOD = 'table_att', COPROCESSOR$1 =
'hdfs://cp/foo.jar|org.apache.hadoop.hbase.sample|1|'
hbase shell describe 't1'
{NAME = 't1', COPROCESSOR$1 =
'hdfs://cp/foo.jar|org.apache.hadoop.hbase.sample|1|', MAX_FILESIZE =
'134217728', ...}
hbase shell alter 't1', METHOD = 'table_att_unset', COPROCESSOR$1
hbase shell describe 't1'
{NAME = 't1', MAX_FILESIZE = '134217728', ...}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4555) TestShell seems passed, but actually errors seen in test output file
[
https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingjie Lai updated HBASE-4555:
---
Attachment: 4555.diff
Patch 1.
TestShell seems passed, but actually errors seen in test output file
Key: HBASE-4555
URL: https://issues.apache.org/jira/browse/HBASE-4555
Project: HBase
Issue Type: Test
Components: test
Reporter: Mingjie Lai
Assignee: Mingjie Lai
Attachments: 4555.diff
When I was making test cases for 4554, I saw a weird issue that TestShell
seems to pass, but actually I saw error messages in the output file.
{code}
---
T E S T S
---
Running org.apache.hadoop.hbase.client.TestShell
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
{code}
Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
{code}
...
6) Error:
test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
ArgumentError: There should be at least one argument but the table name
/home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in
`alter'
./src/test/ruby/hbase/admin_test.rb:271:in
`test_alter_should_support_shortcut_DELETE_alter_specs'
org/jruby/RubyProc.java:268:in `call'
org/jruby/RubyKernel.java:2038:in `send'
org/jruby/RubyArray.java:1572:in `each'
org/jruby/RubyArray.java:1572:in `each'
7) Error:
test_split_should_work(Hbase::AdminMethodsTest):
ArgumentError: wrong number of arguments (1 for 2)
./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
org/jruby/RubyProc.java:268:in `call'
org/jruby/RubyKernel.java:2038:in `send'
org/jruby/RubyArray.java:1572:in `each'
org/jruby/RubyArray.java:1572:in `each'
192 tests, 259 assertions, 1 failures, 6 errors
Done with tests! Shutting down the cluster...
2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting
down minicluster
2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down
HBase Cluster
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4555) TestShell seems passed, but actually errors seen in test output file
[
https://issues.apache.org/jira/browse/HBASE-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingjie Lai updated HBASE-4555:
---
Attachment: HBase-4555-trunk-0.92.patch
TestShell seems passed, but actually errors seen in test output file
Key: HBASE-4555
URL: https://issues.apache.org/jira/browse/HBASE-4555
Project: HBase
Issue Type: Test
Components: test
Reporter: Mingjie Lai
Assignee: Mingjie Lai
Attachments: 4555.diff, HBase-4555-trunk-0.92.patch
When I was making test cases for 4554, I saw a weird issue that TestShell
seems to pass, but actually I saw error messages in the output file.
{code}
---
T E S T S
---
Running org.apache.hadoop.hbase.client.TestShell
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.252 sec
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
{code}
Error messages in org.apache.hadoop.hbase.client.TestShell-output.txt:
{code}
...
6) Error:
test_alter_should_support_shortcut_DELETE_alter_specs(Hbase::AdminAlterTableTest):
ArgumentError: There should be at least one argument but the table name
/home/mlai/git/hbase-private/src/test/ruby/../../main/ruby/hbase/admin.rb:307:in
`alter'
./src/test/ruby/hbase/admin_test.rb:271:in
`test_alter_should_support_shortcut_DELETE_alter_specs'
org/jruby/RubyProc.java:268:in `call'
org/jruby/RubyKernel.java:2038:in `send'
org/jruby/RubyArray.java:1572:in `each'
org/jruby/RubyArray.java:1572:in `each'
7) Error:
test_split_should_work(Hbase::AdminMethodsTest):
ArgumentError: wrong number of arguments (1 for 2)
./src/test/ruby/hbase/admin_test.rb:99:in `test_split_should_work'
org/jruby/RubyProc.java:268:in `call'
org/jruby/RubyKernel.java:2038:in `send'
org/jruby/RubyArray.java:1572:in `each'
org/jruby/RubyArray.java:1572:in `each'
192 tests, 259 assertions, 1 failures, 6 errors
Done with tests! Shutting down the cluster...
2011-10-07 16:46:14,760 INFO [main] hbase.HBaseTestingUtility(551): Shutting
down minicluster
2011-10-07 16:46:14,760 DEBUG [main] util.JVMClusterUtil(214): Shutting down
HBase Cluster
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4554) Allow set/unset coprocessor table attributes from shell.
[
https://issues.apache.org/jira/browse/HBASE-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingjie Lai updated HBASE-4554:
---
Summary: Allow set/unset coprocessor table attributes from shell. (was:
Allow set/unset arbitrary table attributes from shell.)
Rename the jira title from ``Allow set/unset arbitrary table attributes from
shell.'' ``Allow set/unset coprocessor table attributes from shell.''.
Allow set/unset coprocessor table attributes from shell.
Key: HBASE-4554
URL: https://issues.apache.org/jira/browse/HBASE-4554
Project: HBase
Issue Type: Improvement
Components: coprocessors
Reporter: Mingjie Lai
Assignee: Mingjie Lai
Fix For: 0.92.0
Table/region level coprocessor -- RegionObserver -- can be configured by
setting a HTD's attribute which matches Coprocessor$*.
Current shell -- alter -- cannot support to set/unset a table's arbitrary
attribute. We need it in order to configure region level coprocessors to a
table.
Proposed new shell:
{code}
hbase shell alter 't1', METHOD = 'table_att', COPROCESSOR$1 =
'hdfs://cp/foo.jar|org.apache.hadoop.hbase.sample|1|'
hbase shell describe 't1'
{NAME = 't1', COPROCESSOR$1 =
'hdfs://cp/foo.jar|org.apache.hadoop.hbase.sample|1|', MAX_FILESIZE =
'134217728', ...}
hbase shell alter 't1', METHOD = 'table_att_unset', COPROCESSOR$1
hbase shell describe 't1'
{NAME = 't1', MAX_FILESIZE = '134217728', ...}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
