[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827321#comment-16827321 ] Nate Edel commented on HBASE-14964: --- I haven't been active on here in a long time; [~eclark] may have some context on whether this ever got followed up on. > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Priority: Minor > Fix For: 1.5.0 > > Attachments: HBASE-14964-branch-1.1.patch, > HBASE-14964.1.branch-1.patch, HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel reassigned HBASE-14964: - Assignee: (was: Nate Edel) > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Priority: Minor > Fix For: 1.5.0 > > Attachments: HBASE-14964-branch-1.1.patch, > HBASE-14964.1.branch-1.patch, HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060948#comment-15060948 ] Nate Edel commented on HBASE-14964: --- Thanks for fixing my patch name and kicking off the tests, [~busbey]]! I'll wait for the tests to come back, and assuming those are clean, clean up the imports to fix the checkstyle. > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.2.0, 1.3.0 > > Attachments: HBASE-14964-branch-1.1.patch, HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14964: -- Attachment: HBASE-14964.patch > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 1.3.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.3.0 > > Attachments: HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14964: -- Status: Patch Available (was: Open) > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.2.0, 1.3.0 > > Attachments: HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14964: -- Affects Version/s: (was: 1.3.0) Fix Version/s: 1.2.0 Issue Type: Improvement (was: Bug) > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.2.0, 1.3.0 > > Attachments: HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14964: -- Affects Version/s: (was: 2.0.0) 1.3.0 Fix Version/s: (was: 2.0.0) 1.3.0 > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 1.3.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.3.0 > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14964: -- Description: There is duplicated code from MobUtils.createEncryptionContext in HStore, and there is a subset of that code in HFileReaderImpl. Refactored key selection Moved both to EncryptionUtil.java Can't figure out how to write a unit test for this, but there's no new code just refactoring. A lot of the Mob stuff hasn't been backported, so this is a very small patch. was: There is duplicated code from MobUtils.createEncryptionContext in HStore, and there is a subset of that code in HFileReaderImpl. Refactored key selection Moved both to EncryptionUtil.java Can't figure out how to write a unit test for this, but there's no new code just refactoring. > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
Nate Edel created HBASE-14964: - Summary: Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys Key: HBASE-14964 URL: https://issues.apache.org/jira/browse/HBASE-14964 Project: HBase Issue Type: Bug Components: encryption Affects Versions: 2.0.0 Reporter: Nate Edel Assignee: Nate Edel Priority: Minor Fix For: 2.0.0 There is duplicated code from MobUtils.createEncryptionContext in HStore, and there is a subset of that code in HFileReaderImpl. Refactored key selection Moved both to EncryptionUtil.java Can't figure out how to write a unit test for this, but there's no new code just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14910) Create base hbase-mapred and hbase-io modules, move HTableInputFormat and HTableOutputFormat
[ https://issues.apache.org/jira/browse/HBASE-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046025#comment-15046025 ] Nate Edel commented on HBASE-14910: --- https://reviews.facebook.net/D51297 for those who prefer a visual diff. > Create base hbase-mapred and hbase-io modules, move HTableInputFormat and > HTableOutputFormat > > > Key: HBASE-14910 > URL: https://issues.apache.org/jira/browse/HBASE-14910 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nate Edel >Assignee: Nate Edel > Fix For: 2.0.0 > > Attachments: HBASE-14910.unready.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11843) MapReduce classes shouldn't be in hbase-server
[ https://issues.apache.org/jira/browse/HBASE-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046034#comment-15046034 ] Nate Edel commented on HBASE-11843: --- Initial patch for first subtask is in : HBASE-14910 > MapReduce classes shouldn't be in hbase-server > -- > > Key: HBASE-11843 > URL: https://issues.apache.org/jira/browse/HBASE-11843 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Keegan Witt >Assignee: Nate Edel >Priority: Critical > Fix For: 2.0.0 > > > I'm opening this to continue the discussion I started a while back: > http://mail-archives.apache.org/mod_mbox/hbase-user/201405.mbox/%3ccamuu0w_xooxeg779rrfjturau+uxeavunzxkw9dxfo-gh5y...@mail.gmail.com%3E. > To summarize, I think the MapReduce classes used by clients (like > TableMapper, TableReducer, etc) don't belong in hbase-server. This forces > the user to pull in a rather large artifact for a relatively small number of > classes. These should either be put in hbase-client, or possibly an artifact > of their own (like the hbase-mapreduce idea Enis suggested). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14910) Create base hbase-mapred and hbase-io modules, move HTableInputFormat and HTableOutputFormat
[ https://issues.apache.org/jira/browse/HBASE-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046035#comment-15046035 ] Nate Edel commented on HBASE-14910: --- Biggest issue so far is that there are dependencies in TableMapReduceUtil (both under .mapred. and .mapreduce. to the snapshot code) -- this should all move to hbase-mapreduce, but it has a TON of dependencies. Right now those are in a new subclass ServerTableMapReduceUtils I can't imagine we want to break the API, and when I (or someone else) get to the snapshot work real soon now, these should move down to the base versions and ServerTableMapReduceUtils can be removed. There's also some nastiness to the FSUtils/ServerFSUtils split, but since that's InterfaceAudience.Private and FSUtils was already kind of a kitchen sink class, I'd imagine it's OK to split -- all the instanced stuff and FSHDFS/MapR specific stuff remains in hbase-server. > Create base hbase-mapred and hbase-io modules, move HTableInputFormat and > HTableOutputFormat > > > Key: HBASE-14910 > URL: https://issues.apache.org/jira/browse/HBASE-14910 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nate Edel >Assignee: Nate Edel > Fix For: 2.0.0 > > Attachments: HBASE-14910.unready.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14910) Create base hbase-mapred and hbase-io modules, move HTableInputFormat and HTableOutputFormat
[ https://issues.apache.org/jira/browse/HBASE-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14910: -- Attachment: HBASE-14910.unready.patch > Create base hbase-mapred and hbase-io modules, move HTableInputFormat and > HTableOutputFormat > > > Key: HBASE-14910 > URL: https://issues.apache.org/jira/browse/HBASE-14910 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nate Edel >Assignee: Nate Edel > Fix For: 2.0.0 > > Attachments: HBASE-14910.unready.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14910) Create base hbase-mapred and hbase-io modules, move HTableInputFormat and HTableOutputFormat
[ https://issues.apache.org/jira/browse/HBASE-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14910: -- Status: Patch Available (was: Open) NOT ready for full review yet, but any early comments appreciated. Mostly looking to get unit test feedback and I know it will fail Checkstyle and file header checks... > Create base hbase-mapred and hbase-io modules, move HTableInputFormat and > HTableOutputFormat > > > Key: HBASE-14910 > URL: https://issues.apache.org/jira/browse/HBASE-14910 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nate Edel >Assignee: Nate Edel > Fix For: 2.0.0 > > Attachments: HBASE-14910.unready.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Status: Patch Available (was: Open) > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch, HBASE-14901.5.patch, HBASE-14901.6.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Attachment: HBASE-14901.6.patch Merge in HStore from change yesterday... > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch, HBASE-14901.5.patch, HBASE-14901.6.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Status: Open (was: Patch Available) > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch, HBASE-14901.5.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Status: Patch Available (was: Open) > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch, HBASE-14901.5.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Attachment: HBASE-14901.5.patch Didn't re-queue after cancel/subit; re-uploading the same patch (no change from .4) and resubmitting. > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch, HBASE-14901.5.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Attachment: (was: HBASE-14901.4.patch) > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Status: Open (was: Patch Available) > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Status: Patch Available (was: Open) > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch, HBASE-14901.4.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Status: Open (was: Patch Available) > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch, HBASE-14901.4.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14910) Create base hbase-mapred and hbase-io modules, move HTableInputFormat and HTableOutputFormat
Nate Edel created HBASE-14910: - Summary: Create base hbase-mapred and hbase-io modules, move HTableInputFormat and HTableOutputFormat Key: HBASE-14910 URL: https://issues.apache.org/jira/browse/HBASE-14910 Project: HBase Issue Type: Sub-task Reporter: Nate Edel Assignee: Nate Edel -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14912) Move functionality needed to read WAL without RegionServer dependency
Nate Edel created HBASE-14912: - Summary: Move functionality needed to read WAL without RegionServer dependency Key: HBASE-14912 URL: https://issues.apache.org/jira/browse/HBASE-14912 Project: HBase Issue Type: Sub-task Reporter: Nate Edel -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14913) Enable testing I/O without regionserver or threads.
Nate Edel created HBASE-14913: - Summary: Enable testing I/O without regionserver or threads. Key: HBASE-14913 URL: https://issues.apache.org/jira/browse/HBASE-14913 Project: HBase Issue Type: Sub-task Reporter: Nate Edel Assignee: Nate Edel -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14914) Move functionality needed to handle Snapshots without RegionServer dependency
Nate Edel created HBASE-14914: - Summary: Move functionality needed to handle Snapshots without RegionServer dependency Key: HBASE-14914 URL: https://issues.apache.org/jira/browse/HBASE-14914 Project: HBase Issue Type: Sub-task Reporter: Nate Edel -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14911) Move functionality needed to write HFiles without RegionServer dependency
Nate Edel created HBASE-14911: - Summary: Move functionality needed to write HFiles without RegionServer dependency Key: HBASE-14911 URL: https://issues.apache.org/jira/browse/HBASE-14911 Project: HBase Issue Type: Sub-task Reporter: Nate Edel Assignee: Nate Edel -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11843) MapReduce classes shouldn't be in hbase-server
[ https://issues.apache.org/jira/browse/HBASE-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036441#comment-15036441 ] Nate Edel commented on HBASE-11843: --- This is looking bigger, and probably difficult to review especially coming from a relative newb. I've broken things up into subtasks, and this should be easier to review. > MapReduce classes shouldn't be in hbase-server > -- > > Key: HBASE-11843 > URL: https://issues.apache.org/jira/browse/HBASE-11843 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Keegan Witt >Assignee: Nate Edel >Priority: Critical > Fix For: 2.0.0 > > > I'm opening this to continue the discussion I started a while back: > http://mail-archives.apache.org/mod_mbox/hbase-user/201405.mbox/%3ccamuu0w_xooxeg779rrfjturau+uxeavunzxkw9dxfo-gh5y...@mail.gmail.com%3E. > To summarize, I think the MapReduce classes used by clients (like > TableMapper, TableReducer, etc) don't belong in hbase-server. This forces > the user to pull in a rather large artifact for a relatively small number of > classes. These should either be put in hbase-client, or possibly an artifact > of their own (like the hbase-mapreduce idea Enis suggested). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Attachment: HBASE-14901.3.patch > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Status: Open (was: Patch Available) > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Status: Patch Available (was: Open) Fixed checkstyle errors (bad imports.) Fixed some existing checkstyle errors (bad import order, no private constructor on EncryptionUtil and MobUtils). Fixed "protected" LOG on EncryptionUtil to private > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Status: Open (was: Patch Available) > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Attachment: HBASE-14901.4.patch Cascading checkstyles errors... added final to the two utility classes. QABot, what say you? > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch, HBASE-14901.4.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Status: Patch Available (was: Open) > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch, > HBASE-14901.3.patch, HBASE-14901.4.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Attachment: HBASE-14901.patch > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034875#comment-15034875 ] Nate Edel commented on HBASE-14901: --- [~ghelmling] or [~eclark] can one of you take a quick look at this? > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14901) There is duplicated code to create/manage encryption keys
Nate Edel created HBASE-14901: - Summary: There is duplicated code to create/manage encryption keys Key: HBASE-14901 URL: https://issues.apache.org/jira/browse/HBASE-14901 Project: HBase Issue Type: Bug Components: encryption Affects Versions: 2.0.0 Reporter: Nate Edel Assignee: Nate Edel Priority: Minor Fix For: 2.0.0 There is duplicated code from MobUtils.createEncryptionContext in HStore, and there is a subset of that code in HFileReaderImpl. Refactored key selection Moved both to EncryptionUtil.java Can't figure out how to write a unit test for this, but there's no new code just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Attachment: (was: HBASE-14901.patch) > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Attachment: HBASE-14901.1.patch Bad imports when applied to an unmodified tree; trying again. > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Attachment: HBASE-14901.2.patch > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14901) There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-14901: -- Status: Patch Available (was: Open) Changes made as requested to name and (yes, that's much better naming) and JavaDoc added. Submitting to get QABot's opinion. :) [~apurtell] - EncryptionUtil.java is already in hbase-client; is there anything else that should be moved? > There is duplicated code to create/manage encryption keys > - > > Key: HBASE-14901 > URL: https://issues.apache.org/jira/browse/HBASE-14901 > Project: HBase > Issue Type: Bug > Components: encryption >Affects Versions: 2.0.0 >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-8978) Restore TestLogRollAbort upon review
[ https://issues.apache.org/jira/browse/HBASE-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-8978: - Description: Gary, would you mind taking a look? No rush. The test was added by HBASE-4282. It is a good test against data loss but it is around deferred flush which has changed a bunch since test was originally written. I removed it over in hbase-8977 because I caught it hanging and breaking our build (hbase-8939). If you run it, you'll see it can't shutdown. We are bound up waiting on a regionserver to exit. was: Gary, would you mind taking a look? No rush. The test was added by HBASE-4282. It is a good test against data loss but it is around deferred flush which has changed a bunch since test was originally written. I removed it over in hbase-8977 because I caught it hanging and breaking our build (hbase-8939). If you run it, you'll see it can't shutdown. We are bound up waiting on a regionserver to exit. > Restore TestLogRollAbort upon review > > > Key: HBASE-8978 > URL: https://issues.apache.org/jira/browse/HBASE-8978 > Project: HBase > Issue Type: Task > Components: test >Reporter: stack >Assignee: Gary Helmling > Fix For: 0.98.0, 0.95.2 > > Attachments: 8978.txt, 8978v2.txt > > > Gary, would you mind taking a look? No rush. > The test was added by HBASE-4282. It is a good test against data loss but it > is around deferred flush which has changed a bunch since test was originally > written. > I removed it over in hbase-8977 because I caught it hanging and breaking our > build (hbase-8939). If you run it, you'll see it can't shutdown. We are > bound up waiting on a regionserver to exit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-11843) MapReduce classes shouldn't be in hbase-server
[ https://issues.apache.org/jira/browse/HBASE-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel reassigned HBASE-11843: - Assignee: Nate Edel Picking this up at the suggestion of [~eclark]. > MapReduce classes shouldn't be in hbase-server > -- > > Key: HBASE-11843 > URL: https://issues.apache.org/jira/browse/HBASE-11843 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Keegan Witt >Assignee: Nate Edel >Priority: Critical > Fix For: 2.0.0 > > > I'm opening this to continue the discussion I started a while back: > http://mail-archives.apache.org/mod_mbox/hbase-user/201405.mbox/%3ccamuu0w_xooxeg779rrfjturau+uxeavunzxkw9dxfo-gh5y...@mail.gmail.com%3E. > To summarize, I think the MapReduce classes used by clients (like > TableMapper, TableReducer, etc) don't belong in hbase-server. This forces > the user to pull in a rather large artifact for a relatively small number of > classes. These should either be put in hbase-client, or possibly an artifact > of their own (like the hbase-mapreduce idea Enis suggested). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-8725) Add total time RPC call metrics
[ https://issues.apache.org/jira/browse/HBASE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-8725: - Status: Open (was: Patch Available) Add total time RPC call metrics --- Key: HBASE-8725 URL: https://issues.apache.org/jira/browse/HBASE-8725 Project: HBase Issue Type: Bug Components: metrics Affects Versions: 0.98.9 Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-8275.patch, HBASE-8725-r1.patch Right now we have: * queueCallTime ** exposes the ammount of time that a call is in the queue * processCallTime ** exposes how long a call was processing We don't have a stat for total time. It's pretty easy to think that the two metrics might not track together so getting a total time could be useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-8725) Add total time RPC call metrics
[ https://issues.apache.org/jira/browse/HBASE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-8725: - Status: Patch Available (was: Open) Add total time RPC call metrics --- Key: HBASE-8725 URL: https://issues.apache.org/jira/browse/HBASE-8725 Project: HBase Issue Type: Bug Components: metrics Affects Versions: 0.98.9 Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-8275.patch, HBASE-8725-r1.patch Right now we have: * queueCallTime ** exposes the ammount of time that a call is in the queue * processCallTime ** exposes how long a call was processing We don't have a stat for total time. It's pretty easy to think that the two metrics might not track together so getting a total time could be useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-8725) Add total time RPC call metrics
[ https://issues.apache.org/jira/browse/HBASE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-8725: - Attachment: HBASE-8725-r1.patch Rebased patch. Need to let tests run. Add total time RPC call metrics --- Key: HBASE-8725 URL: https://issues.apache.org/jira/browse/HBASE-8725 Project: HBase Issue Type: Bug Components: metrics Affects Versions: 0.98.9 Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-8275.patch, HBASE-8725-r1.patch Right now we have: * queueCallTime ** exposes the ammount of time that a call is in the queue * processCallTime ** exposes how long a call was processing We don't have a stat for total time. It's pretty easy to think that the two metrics might not track together so getting a total time could be useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12751) Allow RowLock to be reader writer
[ https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376453#comment-14376453 ] Nate Edel commented on HBASE-12751: --- org.apache.hadoop.hbase.TestAcidGuarantees appears to have non-deterministic freezing behaviors when running locally. Could this be related to HBASE-13295 ? Allow RowLock to be reader writer - Key: HBASE-12751 URL: https://issues.apache.org/jira/browse/HBASE-12751 Project: HBase Issue Type: Bug Components: regionserver Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-12751-v1.patch, HBASE-12751.patch Right now every write operation grabs a row lock. This is to prevent values from changing during a read modify write operation (increment or check and put). However it limits parallelism in several different scenarios. If there are several puts to the same row but different columns or stores then this is very limiting. If there are puts to the same column then mvcc number should ensure a consistent ordering. So locking is not needed. However locking for check and put or increment is still needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12751) Allow RowLock to be reader writer
[ https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-12751: -- Attachment: (was: HBASE-12751-v1.patch) Allow RowLock to be reader writer - Key: HBASE-12751 URL: https://issues.apache.org/jira/browse/HBASE-12751 Project: HBase Issue Type: Bug Components: regionserver Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-12751-v1.patch, HBASE-12751.patch Right now every write operation grabs a row lock. This is to prevent values from changing during a read modify write operation (increment or check and put). However it limits parallelism in several different scenarios. If there are several puts to the same row but different columns or stores then this is very limiting. If there are puts to the same column then mvcc number should ensure a consistent ordering. So locking is not needed. However locking for check and put or increment is still needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12751) Allow RowLock to be reader writer
[ https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-12751: -- Attachment: HBASE-12751-v1.patch Re-queuing Allow RowLock to be reader writer - Key: HBASE-12751 URL: https://issues.apache.org/jira/browse/HBASE-12751 Project: HBase Issue Type: Bug Components: regionserver Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-12751-v1.patch, HBASE-12751.patch Right now every write operation grabs a row lock. This is to prevent values from changing during a read modify write operation (increment or check and put). However it limits parallelism in several different scenarios. If there are several puts to the same row but different columns or stores then this is very limiting. If there are puts to the same column then mvcc number should ensure a consistent ordering. So locking is not needed. However locking for check and put or increment is still needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12751) Allow RowLock to be reader writer
[ https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-12751: -- Attachment: HBASE-12751.patch Workflow failure, sorry -- clicked submit patch before adding attachment. Allow RowLock to be reader writer - Key: HBASE-12751 URL: https://issues.apache.org/jira/browse/HBASE-12751 Project: HBase Issue Type: Bug Components: regionserver Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-12751.patch Right now every write operation grabs a row lock. This is to prevent values from changing during a read modify write operation (increment or check and put). However it limits parallelism in several different scenarios. If there are several puts to the same row but different columns or stores then this is very limiting. If there are puts to the same column then mvcc number should ensure a consistent ordering. So locking is not needed. However locking for check and put or increment is still needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12751) Allow RowLock to be reader writer
[ https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-12751: -- Status: Patch Available (was: Open) Allow RowLock to be reader writer - Key: HBASE-12751 URL: https://issues.apache.org/jira/browse/HBASE-12751 Project: HBase Issue Type: Bug Components: regionserver Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-12751.patch Right now every write operation grabs a row lock. This is to prevent values from changing during a read modify write operation (increment or check and put). However it limits parallelism in several different scenarios. If there are several puts to the same row but different columns or stores then this is very limiting. If there are puts to the same column then mvcc number should ensure a consistent ordering. So locking is not needed. However locking for check and put or increment is still needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12751) Allow RowLock to be reader writer
[ https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-12751: -- Status: Patch Available (was: In Progress) Allow RowLock to be reader writer - Key: HBASE-12751 URL: https://issues.apache.org/jira/browse/HBASE-12751 Project: HBase Issue Type: Bug Components: regionserver Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-12751-v1.patch, HBASE-12751.patch Right now every write operation grabs a row lock. This is to prevent values from changing during a read modify write operation (increment or check and put). However it limits parallelism in several different scenarios. If there are several puts to the same row but different columns or stores then this is very limiting. If there are puts to the same column then mvcc number should ensure a consistent ordering. So locking is not needed. However locking for check and put or increment is still needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12751) Allow RowLock to be reader writer
[ https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-12751: -- Attachment: HBASE-12751-v1.patch Fix line-length style bugs Actually call read lock in doMiniBatchMutation Reviewed code to ensure that a request for a read lock in a thread already in a write lock behaves as expected in remaining in a write lock. Allow RowLock to be reader writer - Key: HBASE-12751 URL: https://issues.apache.org/jira/browse/HBASE-12751 Project: HBase Issue Type: Bug Components: regionserver Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-12751-v1.patch, HBASE-12751.patch Right now every write operation grabs a row lock. This is to prevent values from changing during a read modify write operation (increment or check and put). However it limits parallelism in several different scenarios. If there are several puts to the same row but different columns or stores then this is very limiting. If there are puts to the same column then mvcc number should ensure a consistent ordering. So locking is not needed. However locking for check and put or increment is still needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12751) Allow RowLock to be reader writer
[ https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-12751: -- Status: In Progress (was: Patch Available) Allow RowLock to be reader writer - Key: HBASE-12751 URL: https://issues.apache.org/jira/browse/HBASE-12751 Project: HBase Issue Type: Bug Components: regionserver Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-12751-v1.patch, HBASE-12751.patch Right now every write operation grabs a row lock. This is to prevent values from changing during a read modify write operation (increment or check and put). However it limits parallelism in several different scenarios. If there are several puts to the same row but different columns or stores then this is very limiting. If there are puts to the same column then mvcc number should ensure a consistent ordering. So locking is not needed. However locking for check and put or increment is still needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12751) Allow RowLock to be reader writer
[ https://issues.apache.org/jira/browse/HBASE-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368150#comment-14368150 ] Nate Edel commented on HBASE-12751: --- Good catch, yes thanks. I'd had isPutMutation and removed it; looking now at whether it's safe to put true vs adding an isDeleteMutation and putting isPutMutation || isDeleteMutation Allow RowLock to be reader writer - Key: HBASE-12751 URL: https://issues.apache.org/jira/browse/HBASE-12751 Project: HBase Issue Type: Bug Components: regionserver Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-12751.patch Right now every write operation grabs a row lock. This is to prevent values from changing during a read modify write operation (increment or check and put). However it limits parallelism in several different scenarios. If there are several puts to the same row but different columns or stores then this is very limiting. If there are puts to the same column then mvcc number should ensure a consistent ordering. So locking is not needed. However locking for check and put or increment is still needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-8725) Add total time RPC call metrics
[ https://issues.apache.org/jira/browse/HBASE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Edel updated HBASE-8725: - Attachment: HBASE-8275.patch Add total time RPC call metrics --- Key: HBASE-8725 URL: https://issues.apache.org/jira/browse/HBASE-8725 Project: HBase Issue Type: Bug Components: metrics Affects Versions: 0.98.9 Reporter: Elliott Clark Assignee: Nate Edel Attachments: HBASE-8275.patch Right now we have: * queueCallTime ** exposes the ammount of time that a call is in the queue * processCallTime ** exposes how long a call was processing We don't have a stat for total time. It's pretty easy to think that the two metrics might not track together so getting a total time could be useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
