[jira] [Commented] (HBASE-23320) Upgrade surefire plugin to 3.0.0-M4
[ https://issues.apache.org/jira/browse/HBASE-23320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993691#comment-16993691 ] Rabi Kumar K C commented on HBASE-23320: Hi [~psomogyi] I did ugrade the surefire to 3.0.0-M4 but there were errors due to xml so tried downgrading it to 3.0.0-M3 but same error persists. How do you suggest should we move forward?? Should we stick with current version?? > Upgrade surefire plugin to 3.0.0-M4 > --- > > Key: HBASE-23320 > URL: https://issues.apache.org/jira/browse/HBASE-23320 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-23348) Spark's createTable method throws an exception while the table is being split
[
https://issues.apache.org/jira/browse/HBASE-23348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23348 started by Rabi Kumar K C.
--
> Spark's createTable method throws an exception while the table is being split
> -
>
> Key: HBASE-23348
> URL: https://issues.apache.org/jira/browse/HBASE-23348
> Project: HBase
> Issue Type: Bug
> Components: hbase-connectors
>Affects Versions: connector-1.0.0
>Reporter: Balazs Meszaros
>Assignee: Rabi Kumar K C
>Priority: Major
> Labels: beginner
>
> {{HBaseRelation.createTable}} checks table existence with
> {{HBaseAdmin.isTableAvailable}} method
> [here|https://github.com/apache/hbase-connectors/blob/master/spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/DefaultSource.scala#L167].
> This is unfortunate, because it can return {{false}} while splitting, so
> {{createTable}} will fail. It should use {{tableExists}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-23348) Spark's createTable method throws an exception while the table is being split
[
https://issues.apache.org/jira/browse/HBASE-23348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rabi Kumar K C reassigned HBASE-23348:
--
Assignee: Rabi Kumar K C
> Spark's createTable method throws an exception while the table is being split
> -
>
> Key: HBASE-23348
> URL: https://issues.apache.org/jira/browse/HBASE-23348
> Project: HBase
> Issue Type: Bug
> Components: hbase-connectors
>Affects Versions: connector-1.0.0
>Reporter: Balazs Meszaros
>Assignee: Rabi Kumar K C
>Priority: Major
> Labels: beginner
>
> {{HBaseRelation.createTable}} checks table existence with
> {{HBaseAdmin.isTableAvailable}} method
> [here|https://github.com/apache/hbase-connectors/blob/master/spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/DefaultSource.scala#L167].
> This is unfortunate, because it can return {{false}} while splitting, so
> {{createTable}} will fail. It should use {{tableExists}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-23320) Upgrade surefire plugin to 3.0.0-M4
[ https://issues.apache.org/jira/browse/HBASE-23320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rabi Kumar K C reassigned HBASE-23320: -- Assignee: Rabi Kumar K C > Upgrade surefire plugin to 3.0.0-M4 > --- > > Key: HBASE-23320 > URL: https://issues.apache.org/jira/browse/HBASE-23320 > Project: HBase > Issue Type: Sub-task > Components: test >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-18439 started by Rabi Kumar K C.
--
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-23250) Log message about CleanerChore delegate initialization should be at INFO
[
https://issues.apache.org/jira/browse/HBASE-23250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23250 started by Rabi Kumar K C.
--
> Log message about CleanerChore delegate initialization should be at INFO
>
>
> Key: HBASE-23250
> URL: https://issues.apache.org/jira/browse/HBASE-23250
> Project: HBase
> Issue Type: Task
> Components: master, Operability
>Reporter: Sean Busbey
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
>
> Right now we log a DEBUG message as we initialize the delegates that decide
> on cleaner decisions:
> {code}
> 2019-10-30 07:30:01,594 DEBUG
> org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize
> cleaner=org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner
> 2019-10-30 07:30:01,597 DEBUG
> org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize
> cleaner=org.apache.hadoop.hbase.master.snapshot.SnapshotLogCleaner
> 2019-10-30 07:30:01,600 DEBUG
> org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize
> cleaner=org.apache.hadoop.hbase.master.cleaner.HFileLinkCleaner
> 2019-10-30 07:30:01,601 DEBUG
> org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize
> cleaner=org.apache.hadoop.hbase.master.snapshot.SnapshotHFileCleaner
> 2019-10-30 07:30:01,602 DEBUG
> org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize
> cleaner=org.apache.hadoop.hbase.master.cleaner.TimeToLiveHFileCleaner
> {code}
> Done here in CleanerChore.java:
> {code}
> private void initCleanerChain(String confKey) {
> this.cleanersChain = new LinkedList<>();
> String[] logCleaners = conf.getStrings(confKey);
> if (logCleaners != null) {
> for (String className : logCleaners) {
> T logCleaner = newFileCleaner(className, conf);
> if (logCleaner != null) {
> LOG.debug("Initialize cleaner={}", className);
> this.cleanersChain.add(logCleaner);
> }
> }
> }
> }
> {code}
> This message should be at INFO. it doesn't happen often and knowing what
> plugins decide about file deletions is important all the time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967602#comment-16967602
]
Rabi Kumar K C commented on HBASE-18439:
Assigning the ticket to myself as this has remained stale for a while. Will
open a PR soon for this. Hopefully this is still required.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rabi Kumar K C reassigned HBASE-18439:
--
Assignee: Rabi Kumar K C (was: Jui-Yu Hsieh)
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-23250) Log message about CleanerChore delegate initialization should be at INFO
[
https://issues.apache.org/jira/browse/HBASE-23250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rabi Kumar K C reassigned HBASE-23250:
--
Assignee: Rabi Kumar K C
> Log message about CleanerChore delegate initialization should be at INFO
>
>
> Key: HBASE-23250
> URL: https://issues.apache.org/jira/browse/HBASE-23250
> Project: HBase
> Issue Type: Task
> Components: master, Operability
>Reporter: Sean Busbey
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
>
> Right now we log a DEBUG message as we initialize the delegates that decide
> on cleaner decisions:
> {code}
> 2019-10-30 07:30:01,594 DEBUG
> org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize
> cleaner=org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner
> 2019-10-30 07:30:01,597 DEBUG
> org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize
> cleaner=org.apache.hadoop.hbase.master.snapshot.SnapshotLogCleaner
> 2019-10-30 07:30:01,600 DEBUG
> org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize
> cleaner=org.apache.hadoop.hbase.master.cleaner.HFileLinkCleaner
> 2019-10-30 07:30:01,601 DEBUG
> org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize
> cleaner=org.apache.hadoop.hbase.master.snapshot.SnapshotHFileCleaner
> 2019-10-30 07:30:01,602 DEBUG
> org.apache.hadoop.hbase.master.cleaner.CleanerChore: initialize
> cleaner=org.apache.hadoop.hbase.master.cleaner.TimeToLiveHFileCleaner
> {code}
> Done here in CleanerChore.java:
> {code}
> private void initCleanerChain(String confKey) {
> this.cleanersChain = new LinkedList<>();
> String[] logCleaners = conf.getStrings(confKey);
> if (logCleaners != null) {
> for (String className : logCleaners) {
> T logCleaner = newFileCleaner(className, conf);
> if (logCleaner != null) {
> LOG.debug("Initialize cleaner={}", className);
> this.cleanersChain.add(logCleaner);
> }
> }
> }
> }
> {code}
> This message should be at INFO. it doesn't happen often and knowing what
> plugins decide about file deletions is important all the time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23102) Improper Usage of Map putIfAbsent
[
https://issues.apache.org/jira/browse/HBASE-23102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942771#comment-16942771
]
Rabi Kumar K C commented on HBASE-23102:
[~wchevreuil] If ticket is about changing putIfAbsent to ComputeIfAbsent on the
given classes then maybe I can take this up. Is it Okay [~belugabehr]??
> Improper Usage of Map putIfAbsent
> -
>
> Key: HBASE-23102
> URL: https://issues.apache.org/jira/browse/HBASE-23102
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.3.0
>Reporter: David Mollitor
>Priority: Minor
> Labels: newbie, noob
>
> When using {{Map#putIfAbsent}}, the argument should not be a {{new}} object.
> Otherwise, if the item is present, the object that was instantiated is
> immediately thrown away. Instead, use {{Map#computeIfAbsent}} so that the
> object is only instantiated if it is needed.
> There exists a good example in the {{Map}} JavaDoc:
> https://docs.oracle.com/javase/8/docs/api/java/util/Map.html#computeIfAbsent-K-java.util.function.Function-
>
> h2. Locations
> https://github.com/apache/hbase/blob/9370347efea5b09e2fa8f4e5d82fa32491e1181b/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java#L227-L236
> https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/StoreHotnessProtector.java#L124-L129
> https://github.com/apache/hbase/blob/1170f28122d9d36e511ba504a5263ec62e11ef6a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L555
> https://github.com/apache/hbase/blob/4ca760fe9dd373b8d8a4c48db15e42424920653c/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java#L584-L586
> https://github.com/apache/hbase/blob/4ca760fe9dd373b8d8a4c48db15e42424920653c/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java#L585
> https://github.com/apache/hbase/blob/5b01e613fbbb92e243e99a1d199b4ffbb21ed2d9/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java#L834
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927630#comment-16927630 ] Rabi Kumar K C commented on HBASE-22338: I have created a PR under the same ticket. [~busbey] please have a look at it. I have added license and notice files as mentioned above in my comment however main license and notice files remain untouched. Please do let me know what needs to be changed then I can add them in the main license and notice file if need be. > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Critical > Fix For: connector-1.0.1 > > Attachments: hbase-connectors-dependency.html > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22338) LICENSE file only contains Apache 2.0
[
https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926780#comment-16926780
]
Rabi Kumar K C commented on HBASE-22338:
Regarding the progress of license and notice aggregation, I added
{{src/main/appended-resources/META-INF/}} in hbase-kafka-proxy and
hbase-kafka-model and added the aggregated non-ALv2 licenses and notices. Yes,
there are some GPL, LGPL but they are in combination with other licenses. I
will finish the license aggregation for sub-modules of hbase-spark by tomorrow
and will create the pull request for review. And I am putting together the
licenses and notice files manually. If I find any dependency with public domain
or unknown license then will update here
Please do let me know [~busbey] if what I am doing is correct.
> LICENSE file only contains Apache 2.0
> -
>
> Key: HBASE-22338
> URL: https://issues.apache.org/jira/browse/HBASE-22338
> Project: HBase
> Issue Type: Bug
> Components: hbase-connectors
>Affects Versions: connector-1.0.0
>Reporter: Peter Somogyi
>Assignee: Rabi Kumar K C
>Priority: Critical
> Fix For: connector-1.0.1
>
> Attachments: hbase-connectors-dependency.html
>
>
> LICENSE.md file has only Apache 2.0 licenses but we package dependencies that
> use different ones. For example jcodings uses MIT.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923490#comment-16923490 ] Rabi Kumar K C edited comment on HBASE-22338 at 9/9/19 1:01 PM: Yes in hbase-connectors-assembly, all licenses for hbase project have been aggregated. Regarding the dependencies other than ALv2 please take a look at the attached file [~busbey]. And please do let me know what would be the effective way to handle this. Should we add license and notice files manually or in another way?? was (Author: rabikumar.kc): Yes in hbase-connectors-assembly, all licenses for project have been aggregated. Regarding the dependencies other than ALv2 please take a look at the attached file [~busbey]. And please do let me know what would be the effective way to handle this. > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Critical > Fix For: connector-1.0.1 > > Attachments: hbase-connectors-dependency.html > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923490#comment-16923490 ] Rabi Kumar K C commented on HBASE-22338: Yes in hbase-connectors-assembly, all licenses for project have been aggregated. Regarding the dependencies other than ALv2 please take a look at the attached file [~busbey]. And please do let me know what would be the effective way to handle this. > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Critical > Fix For: connector-1.0.1 > > Attachments: hbase-connectors-dependency.html > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rabi Kumar K C updated HBASE-22338: --- Attachment: hbase-connectors-dependency.html > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Critical > Fix For: connector-1.0.1 > > Attachments: hbase-connectors-dependency.html > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rabi Kumar K C updated HBASE-22338: --- Attachment: (was: hbase-connectors-dependency.html) > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Critical > Fix For: connector-1.0.1 > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rabi Kumar K C updated HBASE-22338: --- Attachment: hbase-connectors-dependency.html > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Critical > Fix For: connector-1.0.1 > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22026) Update hbase_nightly_source to point to new build script... currently follows refguide content.
[ https://issues.apache.org/jira/browse/HBASE-22026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922462#comment-16922462 ] Rabi Kumar K C commented on HBASE-22026: Thank You for the information [~stack]. Will follow your suggestion sir. > Update hbase_nightly_source to point to new build script... currently follows > refguide content. > --- > > Key: HBASE-22026 > URL: https://issues.apache.org/jira/browse/HBASE-22026 > Project: HBase > Issue Type: Bug >Reporter: stack >Priority: Major > > Update the script after parent lands. Change hbase_nightly_source... to use > the new stuff. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22927) Upgrade mockito version for Java 11 compatibility
[ https://issues.apache.org/jira/browse/HBASE-22927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922459#comment-16922459 ] Rabi Kumar K C commented on HBASE-22927: I re-ran tests after updating mockito version 2.23.0 but errors were still there. However, none of the test classes used mockito. So will create a PR under the same ticket [~stack]. > Upgrade mockito version for Java 11 compatibility > - > > Key: HBASE-22927 > URL: https://issues.apache.org/jira/browse/HBASE-22927 > Project: HBase > Issue Type: Task >Reporter: Sakthi >Assignee: Rabi Kumar K C >Priority: Major > > Pasting the discussion from HBASE-22534 here: > "Currently mockito-core version is at 2.1.0. According to > [https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md], > looks like Java 11 compatibility was introduced in 2.19+. And 2.23.2 claims > to have full java 11 support after byte-buddy fix etc." -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922374#comment-16922374 ] Rabi Kumar K C commented on HBASE-22338: So far I have created dependencies.html file for each of the sub-module present in hbase-connectors. And there are multiple licenses along with MIT as well. Should I extend our License.txt file by including each of these licenses? [~psomogyi] would you please let me know how this should be handled?? > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Critical > Fix For: connector-1.0.1 > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work started] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22338 started by Rabi Kumar K C. -- > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Critical > Fix For: connector-1.0.1 > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rabi Kumar K C reassigned HBASE-22338: -- Assignee: Rabi Kumar K C > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Critical > Fix For: connector-1.0.1 > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921437#comment-16921437 ] Rabi Kumar K C commented on HBASE-22338: Hello [~psomogyi] I think you mean License.txt and also regarding jcodings being under MIT, how should we add it to License.txt in our project?? Also we should figure out which other dependencies are under which license? Do you have any suggestions on this?? > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Priority: Critical > Fix For: connector-1.0.1 > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921263#comment-16921263
]
Rabi Kumar K C edited comment on HBASE-18439 at 9/3/19 9:27 AM:
Hi [~mdrob] If this is not done yet and still needs to be finished then can I
take this up?? I am planning to create logger for each sub class of Action and
create a private LoggerFactory.getLogger(.class) and remove static
present in Logger of Action class.
was (Author: rabikumar.kc):
Hi [~mdrob] If this is not done yet and still needs to be finished can I take
this up?? I am planning to create logger for each sub class of Action and
create a private LoggerFactory.getLogger(.class) and remove static
present in Logger of Action class.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Jui-Yu Hsieh
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921263#comment-16921263
]
Rabi Kumar K C commented on HBASE-18439:
Hi [~mdrob] If this is not done yet and still needs to be finished can I take
this up?? I am planning to create logger for each sub class of Action and
create a private LoggerFactory.getLogger(.class) and remove static
present in Logger of Action class.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Jui-Yu Hsieh
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (HBASE-21760) Unify the upper/lower case for title
[ https://issues.apache.org/jira/browse/HBASE-21760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920916#comment-16920916 ] Rabi Kumar K C edited comment on HBASE-21760 at 9/2/19 4:24 PM: Hi [~xubo245], Is it okay if I take this one?? Do you want me to look on other parts as well, exception to above png attached?? was (Author: rabikumar.kc): Hi [~xubo245], Is it okay if I take this one?? Do you want me to look on other parts as well exception to above png attached?? > Unify the upper/lower case for title > > > Key: HBASE-21760 > URL: https://issues.apache.org/jira/browse/HBASE-21760 > Project: HBase > Issue Type: Bug >Reporter: xubo245 >Assignee: xubo245 >Priority: Major > Attachments: hbase.png > > > Unify the upper/lower case for title -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-21760) Unify the upper/lower case for title
[ https://issues.apache.org/jira/browse/HBASE-21760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920916#comment-16920916 ] Rabi Kumar K C commented on HBASE-21760: Hi [~xubo245], Is it okay if I take this one?? Do you want me to look on other parts as well exception to above png attached?? > Unify the upper/lower case for title > > > Key: HBASE-21760 > URL: https://issues.apache.org/jira/browse/HBASE-21760 > Project: HBase > Issue Type: Bug >Reporter: xubo245 >Assignee: xubo245 >Priority: Major > Attachments: hbase.png > > > Unify the upper/lower case for title -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22026) Update hbase_nightly_source to point to new build script... currently follows refguide content.
[ https://issues.apache.org/jira/browse/HBASE-22026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920838#comment-16920838 ] Rabi Kumar K C commented on HBASE-22026: Hi [~stack], Would you kindly please elaborate on the task here?? > Update hbase_nightly_source to point to new build script... currently follows > refguide content. > --- > > Key: HBASE-22026 > URL: https://issues.apache.org/jira/browse/HBASE-22026 > Project: HBase > Issue Type: Bug >Reporter: stack >Priority: Major > > Update the script after parent lands. Change hbase_nightly_source... to use > the new stuff. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work started] (HBASE-22927) Upgrade mockito version for Java 11 compatibility
[ https://issues.apache.org/jira/browse/HBASE-22927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22927 started by Rabi Kumar K C. -- > Upgrade mockito version for Java 11 compatibility > - > > Key: HBASE-22927 > URL: https://issues.apache.org/jira/browse/HBASE-22927 > Project: HBase > Issue Type: Task >Reporter: Sakthi >Assignee: Rabi Kumar K C >Priority: Major > > Pasting the discussion from HBASE-22534 here: > "Currently mockito-core version is at 2.1.0. According to > [https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md], > looks like Java 11 compatibility was introduced in 2.19+. And 2.23.2 claims > to have full java 11 support after byte-buddy fix etc." -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22927) Upgrade mockito version for Java 11 compatibility
[ https://issues.apache.org/jira/browse/HBASE-22927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919673#comment-16919673 ] Rabi Kumar K C commented on HBASE-22927: Hi [~jatsakthi], I updated the mockito-core version to 2.23.0 ran the tests for java 11.0.1 and tests failed for following classes: * org.apache.hadoop.hbase.util.TestFutureUtils * org.apache.hadoop.hbase.io.hfile.TestHFile * org.apache.hadoop.hbase.http.log.TestLogLevel * org.apache.hadoop.hbase.io.hfile.TestHFileScannerImplReferenceCount * org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint * org.apache.hadoop.hbase.coprocessor.TestSecureExport But none of the errors were due to updation of mockito version. Do you have any suggestions on how to proceed or should i run another test just to be sure?? > Upgrade mockito version for Java 11 compatibility > - > > Key: HBASE-22927 > URL: https://issues.apache.org/jira/browse/HBASE-22927 > Project: HBase > Issue Type: Task >Reporter: Sakthi >Assignee: Rabi Kumar K C >Priority: Major > > Pasting the discussion from HBASE-22534 here: > "Currently mockito-core version is at 2.1.0. According to > [https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md], > looks like Java 11 compatibility was introduced in 2.19+. And 2.23.2 claims > to have full java 11 support after byte-buddy fix etc." -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work started] (HBASE-22900) Multiple httpcore and httpclient versions included in binary package (branch-1.3)
[
https://issues.apache.org/jira/browse/HBASE-22900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-22900 started by Rabi Kumar K C.
--
> Multiple httpcore and httpclient versions included in binary package
> (branch-1.3)
> -
>
> Key: HBASE-22900
> URL: https://issues.apache.org/jira/browse/HBASE-22900
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Andrew Purtell
>Assignee: Rabi Kumar K C
>Priority: Minor
> Fix For: 1.3.6, 1.4.11
>
>
> We are including multiple versions of httpcore and httpclient in the binary
> package.
> {noformat}
> httpclient-4.1.2.jar
> httpclient-4.2.5.jar
> httpclient-4.4.1.jar
> httpcore-4.1.2.jar
> httpcore-4.2.4.jar
> httpcore-4.4.1.jar
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work started] (HBASE-20688) Refguide has "HBase Backup" section and a chapter named "Backup and Restore"; neither refers to the other
[ https://issues.apache.org/jira/browse/HBASE-20688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-20688 started by Rabi Kumar K C. -- > Refguide has "HBase Backup" section and a chapter named "Backup and Restore"; > neither refers to the other > - > > Key: HBASE-20688 > URL: https://issues.apache.org/jira/browse/HBASE-20688 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: Rabi Kumar K C >Priority: Major > > The two backup sections are not connected or related. It'd be confusing to > the user. Needs addressing. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-20688) Refguide has "HBase Backup" section and a chapter named "Backup and Restore"; neither refers to the other
[ https://issues.apache.org/jira/browse/HBASE-20688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918422#comment-16918422 ] Rabi Kumar K C commented on HBASE-20688: [~stack] Okay then I will add link of "Backup and Restore" chapter in "HBase Backup" Section for folks who wants to know more. > Refguide has "HBase Backup" section and a chapter named "Backup and Restore"; > neither refers to the other > - > > Key: HBASE-20688 > URL: https://issues.apache.org/jira/browse/HBASE-20688 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: Rabi Kumar K C >Priority: Major > > The two backup sections are not connected or related. It'd be confusing to > the user. Needs addressing. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22893) Change the comment in HBaseClassTestRule to reflect change in default test timeouts
[
https://issues.apache.org/jira/browse/HBASE-22893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rabi Kumar K C updated HBASE-22893:
---
Attachment: HBASE-22893.patch
Status: Patch Available (was: Reopened)
Patch for changes in documentation.
> Change the comment in HBaseClassTestRule to reflect change in default test
> timeouts
> ---
>
> Key: HBASE-22893
> URL: https://issues.apache.org/jira/browse/HBASE-22893
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Rabi Kumar K C
>Priority: Trivial
> Labels: beginner, noob
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22893.patch
>
>
> The default timeout is 13 minutes. Change the comment accordingly.
> {code}
> // All tests have a 10minute timeout.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22893) Change the comment in HBaseClassTestRule to reflect change in default test timeouts
[
https://issues.apache.org/jira/browse/HBASE-22893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rabi Kumar K C updated HBASE-22893:
---
Attachment: (was: HBASE-22893.patch)
> Change the comment in HBaseClassTestRule to reflect change in default test
> timeouts
> ---
>
> Key: HBASE-22893
> URL: https://issues.apache.org/jira/browse/HBASE-22893
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Rabi Kumar K C
>Priority: Trivial
> Labels: beginner, noob
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
>
> The default timeout is 13 minutes. Change the comment accordingly.
> {code}
> // All tests have a 10minute timeout.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22893) Change the comment in HBaseClassTestRule to reflect change in default test timeouts
[
https://issues.apache.org/jira/browse/HBASE-22893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rabi Kumar K C updated HBASE-22893:
---
Attachment: HBASE-22893.patch
> Change the comment in HBaseClassTestRule to reflect change in default test
> timeouts
> ---
>
> Key: HBASE-22893
> URL: https://issues.apache.org/jira/browse/HBASE-22893
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Rabi Kumar K C
>Priority: Trivial
> Labels: beginner, noob
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22893.patch
>
>
> The default timeout is 13 minutes. Change the comment accordingly.
> {code}
> // All tests have a 10minute timeout.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Assigned] (HBASE-20688) Refguide has "HBase Backup" section and a chapter named "Backup and Restore"; neither refers to the other
[ https://issues.apache.org/jira/browse/HBASE-20688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rabi Kumar K C reassigned HBASE-20688: -- Assignee: Rabi Kumar K C > Refguide has "HBase Backup" section and a chapter named "Backup and Restore"; > neither refers to the other > - > > Key: HBASE-20688 > URL: https://issues.apache.org/jira/browse/HBASE-20688 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: Rabi Kumar K C >Priority: Major > > The two backup sections are not connected or related. It'd be confusing to > the user. Needs addressing. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-20688) Refguide has "HBase Backup" section and a chapter named "Backup and Restore"; neither refers to the other
[ https://issues.apache.org/jira/browse/HBASE-20688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917760#comment-16917760 ] Rabi Kumar K C commented on HBASE-20688: Hi [~stack], Do you have any suggestions on how to address this?? I will work on this ticket. > Refguide has "HBase Backup" section and a chapter named "Backup and Restore"; > neither refers to the other > - > > Key: HBASE-20688 > URL: https://issues.apache.org/jira/browse/HBASE-20688 > Project: HBase > Issue Type: Bug >Reporter: stack >Priority: Major > > The two backup sections are not connected or related. It'd be confusing to > the user. Needs addressing. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22893) Change the comment in HBaseClassTestRule to reflect change in default test timeouts
[
https://issues.apache.org/jira/browse/HBASE-22893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917610#comment-16917610
]
Rabi Kumar K C commented on HBASE-22893:
Hi [~jatsakthi] I changed ten minutes to thirteen minutes under the section
that you have mentioned and have created a GPR under the same ticketId
> Change the comment in HBaseClassTestRule to reflect change in default test
> timeouts
> ---
>
> Key: HBASE-22893
> URL: https://issues.apache.org/jira/browse/HBASE-22893
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Rabi Kumar K C
>Priority: Trivial
> Labels: beginner, noob
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
>
> The default timeout is 13 minutes. Change the comment accordingly.
> {code}
> // All tests have a 10minute timeout.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Assigned] (HBASE-22900) Multiple httpcore and httpclient versions included in binary package (branch-1.3)
[
https://issues.apache.org/jira/browse/HBASE-22900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rabi Kumar K C reassigned HBASE-22900:
--
Assignee: Rabi Kumar K C
> Multiple httpcore and httpclient versions included in binary package
> (branch-1.3)
> -
>
> Key: HBASE-22900
> URL: https://issues.apache.org/jira/browse/HBASE-22900
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Andrew Purtell
>Assignee: Rabi Kumar K C
>Priority: Minor
> Fix For: 1.3.6, 1.4.11
>
>
> We are including multiple versions of httpcore and httpclient in the binary
> package.
> {noformat}
> httpclient-4.1.2.jar
> httpclient-4.2.5.jar
> httpclient-4.4.1.jar
> httpcore-4.1.2.jar
> httpcore-4.2.4.jar
> httpcore-4.4.1.jar
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Assigned] (HBASE-22927) Upgrade mockito version for Java 11 compatibility
[ https://issues.apache.org/jira/browse/HBASE-22927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rabi Kumar K C reassigned HBASE-22927: -- Assignee: Rabi Kumar K C > Upgrade mockito version for Java 11 compatibility > - > > Key: HBASE-22927 > URL: https://issues.apache.org/jira/browse/HBASE-22927 > Project: HBase > Issue Type: Task >Reporter: Sakthi >Assignee: Rabi Kumar K C >Priority: Major > > Pasting the discussion from HBASE-22534 here: > "Currently mockito-core version is at 2.1.0. According to > [https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md], > looks like Java 11 compatibility was introduced in 2.19+. And 2.23.2 claims > to have full java 11 support after byte-buddy fix etc." -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22893) Change the comment in HBaseClassTestRule to reflect change in default test timeouts
[
https://issues.apache.org/jira/browse/HBASE-22893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916487#comment-16916487
]
Rabi Kumar K C commented on HBASE-22893:
Thank you for the response. I did check in the whole project but didn't find
any. I have edited the comment and made a git PR.
> Change the comment in HBaseClassTestRule to reflect change in default test
> timeouts
> ---
>
> Key: HBASE-22893
> URL: https://issues.apache.org/jira/browse/HBASE-22893
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Rabi Kumar K C
>Priority: Trivial
> Labels: beginner, noob
>
> The default timeout is 13 minutes. Change the comment accordingly.
> {code}
> // All tests have a 10minute timeout.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work started] (HBASE-22899) logging improvements for snapshot operations w/large manifests
[
https://issues.apache.org/jira/browse/HBASE-22899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-22899 started by Rabi Kumar K C.
--
> logging improvements for snapshot operations w/large manifests
> --
>
> Key: HBASE-22899
> URL: https://issues.apache.org/jira/browse/HBASE-22899
> Project: HBase
> Issue Type: Improvement
> Components: snapshots
>Reporter: Sean Busbey
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
>
> working through some issues with snapshotting in the presence of a
> substantial (millions-of) hfiles.
> log messages about the state of creating or restoring span multiple hundreds
> of MB of logs, so more context in individual lines would make it easier to
> orient myself.
> RestoreSnapshotHelper has a few different stanzas that essentially all say
> "I'm creating an HFileLink for this thing". e.g.
> {code}
> for (SnapshotRegionManifest.FamilyFiles familyFiles:
> manifest.getFamilyFilesList()) {
> Path familyDir = new Path(regionDir,
> familyFiles.getFamilyName().toStringUtf8());
> for (SnapshotRegionManifest.StoreFile storeFile:
> familyFiles.getStoreFilesList()) {
> LOG.info("Adding HFileLink " + storeFile.getName() + " to table=" +
> tableName);
> restoreStoreFile(familyDir, snapshotRegionInfo, storeFile,
> createBackRefs);
> }
> }
> {code}
> If would be helpful if
> 1) these stanzas offered something in the logged text to tell them apart (I
> think the coincidentally differ in log level, but that's esoteric and easy to
> lose over time)
> 2) it would be nice if we included the snapshot name in the log message so I
> can more easily pull out all log lines related to the snapshot
> 3) these stanzas indicated "progress" of sorts by giving how many storefiles
> are present and where we are in that list.
> sort of like this bit we log when creating the snapshot manifest:
> {code}
> // 2.2. iterate through all the store's files and create "references".
> for (int i = 0, sz = storeFiles.size(); i < sz; i++) {
> HStoreFile storeFile = storeFiles.get(i);
> monitor.rethrowException();
> // create "reference" to this store file.
> LOG.debug("Adding reference for file (" + (i+1) + "/" + sz + "): " +
> storeFile.getPath());
> visitor.storeFile(regionData, familyData, storeFile.getFileInfo());
> }
> {code}
> And speaking of the above bit in SnapshotManifest, it would be nice if it
> included the name of the snapshot in the log message so it's easier to pull
> out all log lines related to the snapshot.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work started] (HBASE-22886) Code Coverage Improvement: Create Unit Tests for ConnectionId
[ https://issues.apache.org/jira/browse/HBASE-22886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-22886 started by Rabi Kumar K C. -- > Code Coverage Improvement: Create Unit Tests for ConnectionId > - > > Key: HBASE-22886 > URL: https://issues.apache.org/jira/browse/HBASE-22886 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Rabi Kumar K C >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work started] (HBASE-22893) Change the comment in HBaseClassTestRule to reflect change in default test timeouts
[
https://issues.apache.org/jira/browse/HBASE-22893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-22893 started by Rabi Kumar K C.
--
> Change the comment in HBaseClassTestRule to reflect change in default test
> timeouts
> ---
>
> Key: HBASE-22893
> URL: https://issues.apache.org/jira/browse/HBASE-22893
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Rabi Kumar K C
>Priority: Trivial
> Labels: beginner, noob
>
> The default timeout is 13 minutes. Change the comment accordingly.
> {code}
> // All tests have a 10minute timeout.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Assigned] (HBASE-22899) logging improvements for snapshot operations w/large manifests
[
https://issues.apache.org/jira/browse/HBASE-22899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rabi Kumar K C reassigned HBASE-22899:
--
Assignee: Rabi Kumar K C
> logging improvements for snapshot operations w/large manifests
> --
>
> Key: HBASE-22899
> URL: https://issues.apache.org/jira/browse/HBASE-22899
> Project: HBase
> Issue Type: Improvement
> Components: snapshots
>Reporter: Sean Busbey
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
>
> working through some issues with snapshotting in the presence of a
> substantial (millions-of) hfiles.
> log messages about the state of creating or restoring span multiple hundreds
> of MB of logs, so more context in individual lines would make it easier to
> orient myself.
> RestoreSnapshotHelper has a few different stanzas that essentially all say
> "I'm creating an HFileLink for this thing". e.g.
> {code}
> for (SnapshotRegionManifest.FamilyFiles familyFiles:
> manifest.getFamilyFilesList()) {
> Path familyDir = new Path(regionDir,
> familyFiles.getFamilyName().toStringUtf8());
> for (SnapshotRegionManifest.StoreFile storeFile:
> familyFiles.getStoreFilesList()) {
> LOG.info("Adding HFileLink " + storeFile.getName() + " to table=" +
> tableName);
> restoreStoreFile(familyDir, snapshotRegionInfo, storeFile,
> createBackRefs);
> }
> }
> {code}
> If would be helpful if
> 1) these stanzas offered something in the logged text to tell them apart (I
> think the coincidentally differ in log level, but that's esoteric and easy to
> lose over time)
> 2) it would be nice if we included the snapshot name in the log message so I
> can more easily pull out all log lines related to the snapshot
> 3) these stanzas indicated "progress" of sorts by giving how many storefiles
> are present and where we are in that list.
> sort of like this bit we log when creating the snapshot manifest:
> {code}
> // 2.2. iterate through all the store's files and create "references".
> for (int i = 0, sz = storeFiles.size(); i < sz; i++) {
> HStoreFile storeFile = storeFiles.get(i);
> monitor.rethrowException();
> // create "reference" to this store file.
> LOG.debug("Adding reference for file (" + (i+1) + "/" + sz + "): " +
> storeFile.getPath());
> visitor.storeFile(regionData, familyData, storeFile.getFileInfo());
> }
> {code}
> And speaking of the above bit in SnapshotManifest, it would be nice if it
> included the name of the snapshot in the log message so it's easier to pull
> out all log lines related to the snapshot.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22893) Change the comment in HBaseClassTestRule to reflect change in default test timeouts
[
https://issues.apache.org/jira/browse/HBASE-22893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915638#comment-16915638
]
Rabi Kumar K C commented on HBASE-22893:
Hi [~jatsakthi] I changed the comment present in HBaseClassTestRule from "All
tests have a 10minute timeout" to "All tests have 13 minutes timeout". Is it
necessary to search for the similar kind of comments in other files as well??
> Change the comment in HBaseClassTestRule to reflect change in default test
> timeouts
> ---
>
> Key: HBASE-22893
> URL: https://issues.apache.org/jira/browse/HBASE-22893
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Rabi Kumar K C
>Priority: Trivial
> Labels: beginner, noob
>
> The default timeout is 13 minutes. Change the comment accordingly.
> {code}
> // All tests have a 10minute timeout.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Assigned] (HBASE-22893) Change the comment in HBaseClassTestRule to reflect change in default test timeouts
[
https://issues.apache.org/jira/browse/HBASE-22893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rabi Kumar K C reassigned HBASE-22893:
--
Assignee: Rabi Kumar K C
> Change the comment in HBaseClassTestRule to reflect change in default test
> timeouts
> ---
>
> Key: HBASE-22893
> URL: https://issues.apache.org/jira/browse/HBASE-22893
> Project: HBase
> Issue Type: Bug
>Reporter: Sakthi
>Assignee: Rabi Kumar K C
>Priority: Trivial
> Labels: beginner, noob
>
> The default timeout is 13 minutes. Change the comment accordingly.
> {code}
> // All tests have a 10minute timeout.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22886) Code Coverage Improvement: Create Unit Tests for ConnectionId
[ https://issues.apache.org/jira/browse/HBASE-22886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rabi Kumar K C updated HBASE-22886: --- Summary: Code Coverage Improvement: Create Unit Tests for ConnectionId (was: Code Coverage Improvement: Create Unit Tests for BitComparator) > Code Coverage Improvement: Create Unit Tests for ConnectionId > - > > Key: HBASE-22886 > URL: https://issues.apache.org/jira/browse/HBASE-22886 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Rabi Kumar K C >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (HBASE-22886) Code Coverage Improvement: Create Unit Tests for BitComparator
[ https://issues.apache.org/jira/browse/HBASE-22886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rabi Kumar K C reassigned HBASE-22886: -- Assignee: Rabi Kumar K C (was: Murtaza Hassan) > Code Coverage Improvement: Create Unit Tests for BitComparator > -- > > Key: HBASE-22886 > URL: https://issues.apache.org/jira/browse/HBASE-22886 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Rabi Kumar K C >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.3.2#803003)
