[jira] [Commented] (HBASE-11064) Odd behaviors of TableName for empty namespace
[
https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068223#comment-14068223
]
Rekha Joshi commented on HBASE-11064:
-
[~enis] Seems infra issue.The latest patch(.3) was not built.Can you pick it
up?Thanks.
Odd behaviors of TableName for empty namespace
--
Key: HBASE-11064
URL: https://issues.apache.org/jira/browse/HBASE-11064
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.3
Reporter: Hiroshi Ikeda
Assignee: Rekha Joshi
Priority: Trivial
Fix For: 0.99.0, 1.0.0, 0.98.5
Attachments: HBASE-11064.1.patch, HBASE-11064.2.patch,
HBASE-11064.2.patch, HBASE-11064.3.patch
In the class TableName,
{code}
public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
...
int namespaceDelimIndex = ...
if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
isLegalTableQualifierName(tableName);
} else {
...
{code}
That means, for example, giving :a as the argument throws an exception
which says invalid qualifier, instead of invalid namespace.
Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance
with empty namespace, which is inconsistent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11064) Odd behaviors of TableName for empty namespace
[
https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-11064:
Attachment: HBASE-11064.3.patch
attached patch.thanks
Odd behaviors of TableName for empty namespace
--
Key: HBASE-11064
URL: https://issues.apache.org/jira/browse/HBASE-11064
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.3
Reporter: Hiroshi Ikeda
Assignee: Rekha Joshi
Priority: Trivial
Fix For: 0.99.0, 1.0.0, 0.98.5
Attachments: HBASE-11064.1.patch, HBASE-11064.2.patch,
HBASE-11064.2.patch, HBASE-11064.3.patch
In the class TableName,
{code}
public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
...
int namespaceDelimIndex = ...
if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
isLegalTableQualifierName(tableName);
} else {
...
{code}
That means, for example, giving :a as the argument throws an exception
which says invalid qualifier, instead of invalid namespace.
Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance
with empty namespace, which is inconsistent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11064) Odd behaviors of TableName for empty namespace
[
https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-11064:
Attachment: HBASE-11064.2.patch
[~enis] [~apurtell]: just saw ping.attached patch with test added/tested.thanks
Odd behaviors of TableName for empty namespace
--
Key: HBASE-11064
URL: https://issues.apache.org/jira/browse/HBASE-11064
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.3
Reporter: Hiroshi Ikeda
Assignee: Rekha Joshi
Priority: Trivial
Fix For: 0.99.0, 1.0.0, 0.98.5
Attachments: HBASE-11064.1.patch, HBASE-11064.2.patch
In the class TableName,
{code}
public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
...
int namespaceDelimIndex = ...
if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
isLegalTableQualifierName(tableName);
} else {
...
{code}
That means, for example, giving :a as the argument throws an exception
which says invalid qualifier, instead of invalid namespace.
Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance
with empty namespace, which is inconsistent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11064) Odd behaviors of TableName for empty namespace
[
https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-11064:
Attachment: HBASE-11064.2.patch
Odd behaviors of TableName for empty namespace
--
Key: HBASE-11064
URL: https://issues.apache.org/jira/browse/HBASE-11064
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.3
Reporter: Hiroshi Ikeda
Assignee: Rekha Joshi
Priority: Trivial
Fix For: 0.99.0, 1.0.0, 0.98.5
Attachments: HBASE-11064.1.patch, HBASE-11064.2.patch
In the class TableName,
{code}
public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
...
int namespaceDelimIndex = ...
if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
isLegalTableQualifierName(tableName);
} else {
...
{code}
That means, for example, giving :a as the argument throws an exception
which says invalid qualifier, instead of invalid namespace.
Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance
with empty namespace, which is inconsistent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11064) Odd behaviors of TableName for empty namespace
[
https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-11064:
Attachment: (was: HBASE-11064.2.patch)
Odd behaviors of TableName for empty namespace
--
Key: HBASE-11064
URL: https://issues.apache.org/jira/browse/HBASE-11064
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.3
Reporter: Hiroshi Ikeda
Assignee: Rekha Joshi
Priority: Trivial
Fix For: 0.99.0, 1.0.0, 0.98.5
Attachments: HBASE-11064.1.patch, HBASE-11064.2.patch
In the class TableName,
{code}
public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
...
int namespaceDelimIndex = ...
if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
isLegalTableQualifierName(tableName);
} else {
...
{code}
That means, for example, giving :a as the argument throws an exception
which says invalid qualifier, instead of invalid namespace.
Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance
with empty namespace, which is inconsistent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Work stopped] (HBASE-11064) Odd behaviors of TableName for empty namespace
[
https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-11064 stopped by Rekha Joshi.
Odd behaviors of TableName for empty namespace
--
Key: HBASE-11064
URL: https://issues.apache.org/jira/browse/HBASE-11064
Project: HBase
Issue Type: Bug
Reporter: Hiroshi Ikeda
Assignee: Rekha Joshi
Priority: Trivial
In the class TableName,
{code}
public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
...
int namespaceDelimIndex = ...
if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
isLegalTableQualifierName(tableName);
} else {
...
{code}
That means, for example, giving :a as the argument throws an exception
which says invalid qualifier, instead of invalid namespace.
Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance
with empty namespace, which is inconsistent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Work started] (HBASE-11064) Odd behaviors of TableName for empty namespace
[
https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-11064 started by Rekha Joshi.
Odd behaviors of TableName for empty namespace
--
Key: HBASE-11064
URL: https://issues.apache.org/jira/browse/HBASE-11064
Project: HBase
Issue Type: Bug
Reporter: Hiroshi Ikeda
Assignee: Rekha Joshi
Priority: Trivial
In the class TableName,
{code}
public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
...
int namespaceDelimIndex = ...
if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
isLegalTableQualifierName(tableName);
} else {
...
{code}
That means, for example, giving :a as the argument throws an exception
which says invalid qualifier, instead of invalid namespace.
Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance
with empty namespace, which is inconsistent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11064) Odd behaviors of TableName for empty namespace
[
https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-11064:
Fix Version/s: 0.98.4
Affects Version/s: 0.98.3
Status: Patch Available (was: Open)
Attached patch.
Odd behaviors of TableName for empty namespace
--
Key: HBASE-11064
URL: https://issues.apache.org/jira/browse/HBASE-11064
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.3
Reporter: Hiroshi Ikeda
Assignee: Rekha Joshi
Priority: Trivial
Fix For: 0.98.4
Attachments: HBASE-11064.1.patch
In the class TableName,
{code}
public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
...
int namespaceDelimIndex = ...
if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
isLegalTableQualifierName(tableName);
} else {
...
{code}
That means, for example, giving :a as the argument throws an exception
which says invalid qualifier, instead of invalid namespace.
Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance
with empty namespace, which is inconsistent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-11064) Odd behaviors of TableName for empty namespace
[
https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-11064:
Attachment: HBASE-11064.1.patch
Attached patch.
For second part for valueOf(), it takes the default namespace
NamespaceDescriptor.DEFAULT_NAMESPACE_NAME which seems ok.
Odd behaviors of TableName for empty namespace
--
Key: HBASE-11064
URL: https://issues.apache.org/jira/browse/HBASE-11064
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.3
Reporter: Hiroshi Ikeda
Assignee: Rekha Joshi
Priority: Trivial
Fix For: 0.98.4
Attachments: HBASE-11064.1.patch
In the class TableName,
{code}
public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
...
int namespaceDelimIndex = ...
if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
isLegalTableQualifierName(tableName);
} else {
...
{code}
That means, for example, giving :a as the argument throws an exception
which says invalid qualifier, instead of invalid namespace.
Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance
with empty namespace, which is inconsistent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11166) Categorize tests in hbase-prefix-tree module
[ https://issues.apache.org/jira/browse/HBASE-11166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000845#comment-14000845 ] Rekha Joshi commented on HBASE-11166: - Thanks [~tedyu].Updated for all tests under prefix-tree. Categorize tests in hbase-prefix-tree module Key: HBASE-11166 URL: https://issues.apache.org/jira/browse/HBASE-11166 Project: HBase Issue Type: Test Affects Versions: 0.98.2 Reporter: Ted Yu Assignee: Rekha Joshi Priority: Minor Attachments: 11166-v2.txt, HBASE-11166.1.patch Jeff Bowles discovered that tests in hbase-prefix-tree module, e.g. TestTimestampEncoder, don't have test category -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11166) Categorize tests in hbase-prefix-tree module
[ https://issues.apache.org/jira/browse/HBASE-11166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-11166: Attachment: HBASE-11166.3.patch Thanks Ted. Updated patch for tests under hbase-prefix. Categorize tests in hbase-prefix-tree module Key: HBASE-11166 URL: https://issues.apache.org/jira/browse/HBASE-11166 Project: HBase Issue Type: Test Affects Versions: 0.98.2 Reporter: Ted Yu Assignee: Rekha Joshi Priority: Minor Attachments: 11166-v2.txt, HBASE-11166.1.patch, HBASE-11166.3.patch Jeff Bowles discovered that tests in hbase-prefix-tree module, e.g. TestTimestampEncoder, don't have test category -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (HBASE-11166) TestTimestampEncoder doesn't have category
[ https://issues.apache.org/jira/browse/HBASE-11166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reassigned HBASE-11166: --- Assignee: Rekha Joshi TestTimestampEncoder doesn't have category -- Key: HBASE-11166 URL: https://issues.apache.org/jira/browse/HBASE-11166 Project: HBase Issue Type: Test Affects Versions: 0.98.2 Reporter: Ted Yu Assignee: Rekha Joshi Priority: Minor Jeff Bowles discovered that TestTimestampEncoder doesn't have category -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11166) TestTimestampEncoder doesn't have category
[ https://issues.apache.org/jira/browse/HBASE-11166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-11166: Affects Version/s: 0.98.2 Status: Patch Available (was: Open) TestTimestampEncoder doesn't have category -- Key: HBASE-11166 URL: https://issues.apache.org/jira/browse/HBASE-11166 Project: HBase Issue Type: Test Affects Versions: 0.98.2 Reporter: Ted Yu Assignee: Rekha Joshi Priority: Minor Jeff Bowles discovered that TestTimestampEncoder doesn't have category -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11166) TestTimestampEncoder doesn't have category
[ https://issues.apache.org/jira/browse/HBASE-11166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-11166: Attachment: HBASE-11166.1.patch Attached patch. TestTimestampEncoder doesn't have category -- Key: HBASE-11166 URL: https://issues.apache.org/jira/browse/HBASE-11166 Project: HBase Issue Type: Test Affects Versions: 0.98.2 Reporter: Ted Yu Assignee: Rekha Joshi Priority: Minor Attachments: HBASE-11166.1.patch Jeff Bowles discovered that TestTimestampEncoder doesn't have category -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11107) Provide utility method equivalent to 0.92's Result.getBytes().getSize()
[
https://issues.apache.org/jira/browse/HBASE-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13994413#comment-13994413
]
Rekha Joshi commented on HBASE-11107:
-
[~gustavoanatoly] : got work to be done for now, so sure.please go ahead.
Provide utility method equivalent to 0.92's Result.getBytes().getSize()
---
Key: HBASE-11107
URL: https://issues.apache.org/jira/browse/HBASE-11107
Project: HBase
Issue Type: Task
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Trivial
Currently user has to write code similar to the following for replacement of
Result.getBytes().getSize() :
{code}
+Cell[] cellValues = resultRow.rawCells();
+
+long size = 0L;
+if (null != cellValues) {
+ for (Cell cellValue : cellValues) {
+size += KeyValueUtil.ensureKeyValue(cellValue).heapSize();
+ }
+}
{code}
In ClientScanner, we have:
{code}
for (Cell kv : rs.rawCells()) {
// TODO make method in Cell or CellUtil
remainingResultSize -=
KeyValueUtil.ensureKeyValue(kv).heapSize();
}
{code}
A utility method should be provided which computes summation of Cell sizes in
a Result.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-11107) Provide utility method equivalent to 0.92's Result.getBytes().getSize()
[
https://issues.apache.org/jira/browse/HBASE-11107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi reassigned HBASE-11107:
---
Assignee: Rekha Joshi
Provide utility method equivalent to 0.92's Result.getBytes().getSize()
---
Key: HBASE-11107
URL: https://issues.apache.org/jira/browse/HBASE-11107
Project: HBase
Issue Type: Task
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Trivial
Currently user has to write code similar to the following for replacement of
Result.getBytes().getSize() :
{code}
+Cell[] cellValues = resultRow.rawCells();
+
+long size = 0L;
+if (null != cellValues) {
+ for (Cell cellValue : cellValues) {
+size += KeyValueUtil.ensureKeyValue(cellValue).heapSize();
+ }
+}
{code}
In ClientScanner, we have:
{code}
for (Cell kv : rs.rawCells()) {
// TODO make method in Cell or CellUtil
remainingResultSize -=
KeyValueUtil.ensureKeyValue(kv).heapSize();
}
{code}
A utility method should be provided which computes summation of Cell sizes in
a Result.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-11113) clone_snapshot command prints wrong name upon error
[ https://issues.apache.org/jira/browse/HBASE-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reassigned HBASE-3: --- Assignee: Rekha Joshi clone_snapshot command prints wrong name upon error --- Key: HBASE-3 URL: https://issues.apache.org/jira/browse/HBASE-3 Project: HBase Issue Type: Bug Affects Versions: 0.98.2 Reporter: Andrew Purtell Assignee: Rekha Joshi Priority: Trivial Fix For: 0.99.0, 0.98.3 hbase clone_snapshot 'snapshot', 'existing_table_name' ERROR: Table already exists: snapshot! -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (HBASE-11064) Odd behaviors of TableName for empty namespace
[
https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi reassigned HBASE-11064:
---
Assignee: Rekha Joshi
Odd behaviors of TableName for empty namespace
--
Key: HBASE-11064
URL: https://issues.apache.org/jira/browse/HBASE-11064
Project: HBase
Issue Type: Bug
Reporter: Hiroshi Ikeda
Assignee: Rekha Joshi
Priority: Trivial
In the class TableName,
{code}
public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
...
int namespaceDelimIndex = ...
if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
isLegalTableQualifierName(tableName);
} else {
...
{code}
That means, for example, giving :a as the argument throws an exception
which says invalid qualifier, instead of invalid namespace.
Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance
with empty namespace, which is inconsistent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-10611) Description for hbase:acl table is wrong on master-status#catalogTables
[
https://issues.apache.org/jira/browse/HBASE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-10611:
Attachment: HBASE-10611.2.patch
Attached patch.Thanks.
Description for hbase:acl table is wrong on master-status#catalogTables
---
Key: HBASE-10611
URL: https://issues.apache.org/jira/browse/HBASE-10611
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Minor
Labels: patch
Fix For: 0.99.0, 0.98.2
Attachments: HBASE-10611.1.patch, HBASE-10611.1.patch,
HBASE-10611.2.patch
On master-status#catalogTables, I see:
hbase:acl The .NAMESPACE. table holds information about namespaces.
In MasterStatusTmpl.jamon, we have:
{code}
if (tableName.equals(TableName.META_TABLE_NAME)){
description = The hbase:meta table holds references to all User
Table regions;
} else {
description = The .NAMESPACE. table holds information about
namespaces.;
}
{code}
The above check doesn't cover hbase:acl table.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Reopened] (HBASE-10653) Incorrect table status in HBase shell Describe
[ https://issues.apache.org/jira/browse/HBASE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reopened HBASE-10653: - Incorrect table status in HBase shell Describe -- Key: HBASE-10653 URL: https://issues.apache.org/jira/browse/HBASE-10653 Project: HBase Issue Type: Bug Components: shell Affects Versions: 0.94.17 Reporter: Biju Nair Assignee: Rekha Joshi Labels: HbaseShell, describe Fix For: 0.98.0 Attachments: HBASE-10653.1.patch, HBASE-10653.2.patch Describe output of table which is disabled shows as enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-10653) Incorrect table status in HBase shell Describe
[ https://issues.apache.org/jira/browse/HBASE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-10653: Status: Patch Available (was: Reopened) Incorrect table status in HBase shell Describe -- Key: HBASE-10653 URL: https://issues.apache.org/jira/browse/HBASE-10653 Project: HBase Issue Type: Bug Components: shell Affects Versions: 0.94.17 Reporter: Biju Nair Assignee: Rekha Joshi Labels: HbaseShell, describe Fix For: 0.98.0 Attachments: HBASE-10653.1.patch, HBASE-10653.2.patch Describe output of table which is disabled shows as enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (HBASE-11078) [AccessController] Consider new permission for read visible
[ https://issues.apache.org/jira/browse/HBASE-11078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reassigned HBASE-11078: --- Assignee: Rekha Joshi [AccessController] Consider new permission for read visible - Key: HBASE-11078 URL: https://issues.apache.org/jira/browse/HBASE-11078 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Assignee: Rekha Joshi Fix For: 0.99.0 See parent for the whole story. Consider a new permission with the semantics being able to read only granted cells, perhaps called READ_VISIBLE. Maybe consider a symmetric new permission for writes. The lack of default READ perm should prevent users from launching scanners. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10611) Description for hbase:acl table is wrong on master-status#catalogTables
[
https://issues.apache.org/jira/browse/HBASE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984123#comment-13984123
]
Rekha Joshi commented on HBASE-10611:
-
[~anoop.hbase] - not sure i understand.think i modified the correct file -
/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
Description for hbase:acl table is wrong on master-status#catalogTables
---
Key: HBASE-10611
URL: https://issues.apache.org/jira/browse/HBASE-10611
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Minor
Labels: patch
Fix For: 0.99.0, 0.98.2
Attachments: HBASE-10611.1.patch, HBASE-10611.1.patch,
HBASE-10611.2.patch
On master-status#catalogTables, I see:
hbase:acl The .NAMESPACE. table holds information about namespaces.
In MasterStatusTmpl.jamon, we have:
{code}
if (tableName.equals(TableName.META_TABLE_NAME)){
description = The hbase:meta table holds references to all User
Table regions;
} else {
description = The .NAMESPACE. table holds information about
namespaces.;
}
{code}
The above check doesn't cover hbase:acl table.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-11034) Get path validates column families twice
[ https://issues.apache.org/jira/browse/HBASE-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reassigned HBASE-11034: --- Assignee: Rekha Joshi Get path validates column families twice Key: HBASE-11034 URL: https://issues.apache.org/jira/browse/HBASE-11034 Project: HBase Issue Type: Improvement Components: regionserver Reporter: Nick Dimiduk Assignee: Rekha Joshi Priority: Minor HRegion#get(Get) adds/validates column families. The resulting RegionScanner goes through the same validation dance a second time. That second implementation is slightly less efficient, always checking the families, even if there were no user-provided families and the prepareScanner() call already did this. The current logic in HRegion#get() is smarter actually. Let's do the work only once. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11034) Get path validates column families twice
[ https://issues.apache.org/jira/browse/HBASE-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-11034: Affects Version/s: 0.98.0 Status: Patch Available (was: Open) Get path validates column families twice Key: HBASE-11034 URL: https://issues.apache.org/jira/browse/HBASE-11034 Project: HBase Issue Type: Improvement Components: regionserver Affects Versions: 0.98.0 Reporter: Nick Dimiduk Assignee: Rekha Joshi Priority: Minor HRegion#get(Get) adds/validates column families. The resulting RegionScanner goes through the same validation dance a second time. That second implementation is slightly less efficient, always checking the families, even if there were no user-provided families and the prepareScanner() call already did this. The current logic in HRegion#get() is smarter actually. Let's do the work only once. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-11034) Get path validates column families twice
[ https://issues.apache.org/jira/browse/HBASE-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-11034: Attachment: HBASE-11034.1.patch Attached patch.Not so for to applying it though, as checkFamily is a defensive check, and good practice. Also the guard condition on checkFamily() and prepareScanner() are exact opposite, this patch should only be applied if we are very sure the scan.hasFamilies() is ALWAYS false when prepareScan is initiated. Get path validates column families twice Key: HBASE-11034 URL: https://issues.apache.org/jira/browse/HBASE-11034 Project: HBase Issue Type: Improvement Components: regionserver Affects Versions: 0.98.0 Reporter: Nick Dimiduk Assignee: Rekha Joshi Priority: Minor Attachments: HBASE-11034.1.patch HRegion#get(Get) adds/validates column families. The resulting RegionScanner goes through the same validation dance a second time. That second implementation is slightly less efficient, always checking the families, even if there were no user-provided families and the prepareScanner() call already did this. The current logic in HRegion#get() is smarter actually. Let's do the work only once. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11082) Potential unclosed TraceScope in FSHLog#replaceWriter()
[
https://issues.apache.org/jira/browse/HBASE-11082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984159#comment-13984159
]
Rekha Joshi commented on HBASE-11082:
-
:-) np [~ndimiduk]
Potential unclosed TraceScope in FSHLog#replaceWriter()
---
Key: HBASE-11082
URL: https://issues.apache.org/jira/browse/HBASE-11082
Project: HBase
Issue Type: Bug
Affects Versions: 0.99.0
Reporter: Ted Yu
Assignee: Nick Dimiduk
Priority: Minor
Fix For: 0.99.0
Attachments: HBASE-11082.00.patch
In the finally block starting at line 924:
{code}
} finally {
// Let the writer thread go regardless, whether error or not.
if (zigzagLatch != null) {
zigzagLatch.releaseSafePoint();
// It will be null if we failed our wait on safe point above.
if (syncFuture != null) blockOnSync(syncFuture);
}
scope.close();
{code}
If blockOnSync() throws IOException, the TraceScope would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-10611) Description for hbase:acl table is wrong on master-status#catalogTables
[
https://issues.apache.org/jira/browse/HBASE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-10611:
Resolution: Fixed
Release Note: (was:
)
Status: Resolved (was: Patch Available)
Attached patch with visibility label.
Description for hbase:acl table is wrong on master-status#catalogTables
---
Key: HBASE-10611
URL: https://issues.apache.org/jira/browse/HBASE-10611
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Minor
Labels: patch
Fix For: 0.99.0, 0.98.2
Attachments: HBASE-10611.1.patch, HBASE-10611.1.patch
On master-status#catalogTables, I see:
hbase:acl The .NAMESPACE. table holds information about namespaces.
In MasterStatusTmpl.jamon, we have:
{code}
if (tableName.equals(TableName.META_TABLE_NAME)){
description = The hbase:meta table holds references to all User
Table regions;
} else {
description = The .NAMESPACE. table holds information about
namespaces.;
}
{code}
The above check doesn't cover hbase:acl table.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-10611) Description for hbase:acl table is wrong on master-status#catalogTables
[
https://issues.apache.org/jira/browse/HBASE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-10611:
Attachment: HBASE-10611.1.patch
Attached patch with visibility label.Thanks
Description for hbase:acl table is wrong on master-status#catalogTables
---
Key: HBASE-10611
URL: https://issues.apache.org/jira/browse/HBASE-10611
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Minor
Labels: patch
Fix For: 0.99.0, 0.98.2
Attachments: HBASE-10611.1.patch, HBASE-10611.1.patch
On master-status#catalogTables, I see:
hbase:acl The .NAMESPACE. table holds information about namespaces.
In MasterStatusTmpl.jamon, we have:
{code}
if (tableName.equals(TableName.META_TABLE_NAME)){
description = The hbase:meta table holds references to all User
Table regions;
} else {
description = The .NAMESPACE. table holds information about
namespaces.;
}
{code}
The above check doesn't cover hbase:acl table.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-10653) Incorrect table status in HBase shell Describe
[ https://issues.apache.org/jira/browse/HBASE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-10653: Attachment: HBASE-10653.2.patch Attached patch using terminal table/suggestion form Stack.Thanks Incorrect table status in HBase shell Describe -- Key: HBASE-10653 URL: https://issues.apache.org/jira/browse/HBASE-10653 Project: HBase Issue Type: Bug Components: shell Affects Versions: 0.94.17 Reporter: Biju Nair Assignee: Rekha Joshi Labels: HbaseShell, describe Fix For: 0.98.0 Attachments: HBASE-10653.1.patch, HBASE-10653.2.patch Describe output of table which is disabled shows as enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-10653) Incorrect table status in HBase shell Describe
[ https://issues.apache.org/jira/browse/HBASE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-10653: Resolution: Fixed Fix Version/s: (was: 0.94.20) 0.98.0 Status: Resolved (was: Patch Available) Attached patch with suggestion form stack.Thanks Incorrect table status in HBase shell Describe -- Key: HBASE-10653 URL: https://issues.apache.org/jira/browse/HBASE-10653 Project: HBase Issue Type: Bug Components: shell Affects Versions: 0.94.17 Reporter: Biju Nair Assignee: Rekha Joshi Labels: HbaseShell, describe Fix For: 0.98.0 Attachments: HBASE-10653.1.patch Describe output of table which is disabled shows as enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (HBASE-11082) Potential unclosed TraceScope in FSHLog#replaceWriter()
[
https://issues.apache.org/jira/browse/HBASE-11082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi reassigned HBASE-11082:
---
Assignee: Rekha Joshi
Potential unclosed TraceScope in FSHLog#replaceWriter()
---
Key: HBASE-11082
URL: https://issues.apache.org/jira/browse/HBASE-11082
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Minor
In the finally block starting at line 924:
{code}
} finally {
// Let the writer thread go regardless, whether error or not.
if (zigzagLatch != null) {
zigzagLatch.releaseSafePoint();
// It will be null if we failed our wait on safe point above.
if (syncFuture != null) blockOnSync(syncFuture);
}
scope.close();
{code}
If blockOnSync() throws IOException, the TraceScope would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (HBASE-10908) On CompactionRequest, reader can be null on recalculateSize
Rekha Joshi created HBASE-10908:
---
Summary: On CompactionRequest, reader can be null on
recalculateSize
Key: HBASE-10908
URL: https://issues.apache.org/jira/browse/HBASE-10908
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Rekha Joshi
Priority: Minor
Comment from Honghua Feng
{code}
private void recalculateSize() {
long sz = 0;
for (StoreFile sf : this.filesToCompact) {
sz += sf.getReader().length();
}
this.totalSize = sz;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-10908) On CompactionRequest, reader can be null on recalculateSize
[
https://issues.apache.org/jira/browse/HBASE-10908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi reassigned HBASE-10908:
---
Assignee: Rekha Joshi
On CompactionRequest, reader can be null on recalculateSize
---
Key: HBASE-10908
URL: https://issues.apache.org/jira/browse/HBASE-10908
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Rekha Joshi
Assignee: Rekha Joshi
Priority: Minor
Comment from Honghua Feng
{code}
private void recalculateSize() {
long sz = 0;
for (StoreFile sf : this.filesToCompact) {
sz += sf.getReader().length();
}
this.totalSize = sz;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-10908) On CompactionRequest, reader can be null on recalculateSize
[
https://issues.apache.org/jira/browse/HBASE-10908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-10908:
Status: Patch Available (was: Open)
Attached patch
On CompactionRequest, reader can be null on recalculateSize
---
Key: HBASE-10908
URL: https://issues.apache.org/jira/browse/HBASE-10908
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Rekha Joshi
Assignee: Rekha Joshi
Priority: Minor
Attachments: HBASE-10908.1.patch
Comment from Honghua Feng
{code}
private void recalculateSize() {
long sz = 0;
for (StoreFile sf : this.filesToCompact) {
sz += sf.getReader().length();
}
this.totalSize = sz;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-10908) On CompactionRequest, reader can be null on recalculateSize
[
https://issues.apache.org/jira/browse/HBASE-10908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-10908:
Attachment: HBASE-10908.1.patch
Attached patch.
On CompactionRequest, reader can be null on recalculateSize
---
Key: HBASE-10908
URL: https://issues.apache.org/jira/browse/HBASE-10908
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Rekha Joshi
Assignee: Rekha Joshi
Priority: Minor
Attachments: HBASE-10908.1.patch
Comment from Honghua Feng
{code}
private void recalculateSize() {
long sz = 0;
for (StoreFile sf : this.filesToCompact) {
sz += sf.getReader().length();
}
this.totalSize = sz;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-10705) CompactionRequest#toString() may throw NullPointerException
[
https://issues.apache.org/jira/browse/HBASE-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-10705:
Fix Version/s: 0.96.0
Affects Version/s: 0.96.0
Status: Patch Available (was: Open)
Attached patch.
CompactionRequest#toString() may throw NullPointerException
---
Key: HBASE-10705
URL: https://issues.apache.org/jira/browse/HBASE-10705
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Minor
Fix For: 0.96.0
I found the following in
hbase-server/target/surefire-reports/org.apache.hadoop.hbase.util.TestMergeTable-output.txt
:
{code}
2014-03-08 01:22:35,311 INFO [IPC Server handler 0 on 39151]
blockmanagement.BlockManager(1009): BLOCK* addToInvalidates:
blk_1073741852_1028 127.0.0.1:58684
2014-03-08 01:22:35,312 INFO
[RS:0;kiyo:45971-shortCompactions-1394241753752] regionserver.HRegion(1393):
compaction interrupted
java.io.InterruptedIOException: Aborting compaction of store contents in
region test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582. because it was
interrupted.
at
org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:81)
at
org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:109)
at
org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1131)
at
org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:1390)
at
org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:475)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:724)
2014-03-08 01:22:35,314 DEBUG [RS_CLOSE_REGION-kiyo:45971-0]
regionserver.HRegion(1069): Updates disabled for region
test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582.
2014-03-08 01:22:35,316 INFO
[StoreCloserThread-test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582.-1]
regionserver.HStore(793): Closed contents
2014-03-08 01:22:35,316 ERROR
[RS:0;kiyo:45971-shortCompactions-1394241753752]
regionserver.CompactSplitThread$CompactionRunner(496): Compaction failed
Request = regionName=test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582.,
storeName=contents, fileCount=7, fileSize=71.3 M (10.2 M, 10.2 M, 10.2 M,
10.2 M, 10.2 M), priority=3, time=8144240699213330
java.lang.NullPointerException
at
org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest$2.apply(CompactionRequest.java:213)
at
org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest$2.apply(CompactionRequest.java:211)
at com.google.common.collect.Iterators$9.transform(Iterators.java:845)
at
com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48)
at com.google.common.base.Joiner.appendTo(Joiner.java:125)
at com.google.common.base.Joiner.appendTo(Joiner.java:186)
at com.google.common.base.Joiner.join(Joiner.java:243)
at com.google.common.base.Joiner.join(Joiner.java:232)
at
org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.toString(CompactionRequest.java:204)
at java.lang.String.valueOf(String.java:2854)
at java.lang.StringBuilder.append(StringBuilder.java:128)
at
org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.toString(CompactSplitThread.java:425)
at java.lang.String.valueOf(String.java:2854)
at java.lang.StringBuilder.append(StringBuilder.java:128)
at
org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:477)
{code}
The exception came from apply() method:
{code}
}), new FunctionStoreFile, String() {
public String apply(StoreFile sf) {
return StringUtils.humanReadableInt(sf.getReader().length());
}
}));
{code}
Looks like sf.getReader() might become null when
StringUtils.humanReadableInt() is called
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-10705) CompactionRequest#toString() may throw NullPointerException
[
https://issues.apache.org/jira/browse/HBASE-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-10705:
Attachment: HBASE-10705.1.patch
Attached patch.
CompactionRequest#toString() may throw NullPointerException
---
Key: HBASE-10705
URL: https://issues.apache.org/jira/browse/HBASE-10705
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Minor
Fix For: 0.96.0
Attachments: HBASE-10705.1.patch
I found the following in
hbase-server/target/surefire-reports/org.apache.hadoop.hbase.util.TestMergeTable-output.txt
:
{code}
2014-03-08 01:22:35,311 INFO [IPC Server handler 0 on 39151]
blockmanagement.BlockManager(1009): BLOCK* addToInvalidates:
blk_1073741852_1028 127.0.0.1:58684
2014-03-08 01:22:35,312 INFO
[RS:0;kiyo:45971-shortCompactions-1394241753752] regionserver.HRegion(1393):
compaction interrupted
java.io.InterruptedIOException: Aborting compaction of store contents in
region test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582. because it was
interrupted.
at
org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:81)
at
org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:109)
at
org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1131)
at
org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:1390)
at
org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:475)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:724)
2014-03-08 01:22:35,314 DEBUG [RS_CLOSE_REGION-kiyo:45971-0]
regionserver.HRegion(1069): Updates disabled for region
test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582.
2014-03-08 01:22:35,316 INFO
[StoreCloserThread-test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582.-1]
regionserver.HStore(793): Closed contents
2014-03-08 01:22:35,316 ERROR
[RS:0;kiyo:45971-shortCompactions-1394241753752]
regionserver.CompactSplitThread$CompactionRunner(496): Compaction failed
Request = regionName=test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582.,
storeName=contents, fileCount=7, fileSize=71.3 M (10.2 M, 10.2 M, 10.2 M,
10.2 M, 10.2 M), priority=3, time=8144240699213330
java.lang.NullPointerException
at
org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest$2.apply(CompactionRequest.java:213)
at
org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest$2.apply(CompactionRequest.java:211)
at com.google.common.collect.Iterators$9.transform(Iterators.java:845)
at
com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48)
at com.google.common.base.Joiner.appendTo(Joiner.java:125)
at com.google.common.base.Joiner.appendTo(Joiner.java:186)
at com.google.common.base.Joiner.join(Joiner.java:243)
at com.google.common.base.Joiner.join(Joiner.java:232)
at
org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.toString(CompactionRequest.java:204)
at java.lang.String.valueOf(String.java:2854)
at java.lang.StringBuilder.append(StringBuilder.java:128)
at
org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.toString(CompactSplitThread.java:425)
at java.lang.String.valueOf(String.java:2854)
at java.lang.StringBuilder.append(StringBuilder.java:128)
at
org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:477)
{code}
The exception came from apply() method:
{code}
}), new FunctionStoreFile, String() {
public String apply(StoreFile sf) {
return StringUtils.humanReadableInt(sf.getReader().length());
}
}));
{code}
Looks like sf.getReader() might become null when
StringUtils.humanReadableInt() is called
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-10611) Description for hbase:acl table is wrong on master-status#catalogTables
[
https://issues.apache.org/jira/browse/HBASE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-10611:
Fix Version/s: 0.96.0
Labels: patch (was: )
Affects Version/s: 0.96.0
Release Note:
Status: Patch Available (was: Open)
Attached patch on 0.96
Description for hbase:acl table is wrong on master-status#catalogTables
---
Key: HBASE-10611
URL: https://issues.apache.org/jira/browse/HBASE-10611
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Minor
Labels: patch
Fix For: 0.96.0
On master-status#catalogTables, I see:
hbase:acl The .NAMESPACE. table holds information about namespaces.
In MasterStatusTmpl.jamon, we have:
{code}
if (tableName.equals(TableName.META_TABLE_NAME)){
description = The hbase:meta table holds references to all User
Table regions;
} else {
description = The .NAMESPACE. table holds information about
namespaces.;
}
{code}
The above check doesn't cover hbase:acl table.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-10611) Description for hbase:acl table is wrong on master-status#catalogTables
[
https://issues.apache.org/jira/browse/HBASE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-10611:
Attachment: HBASE-10611.1.patch
Attached patch on 0.96
(Anoop - Hi. Visibility label is on latest, 0.98.facing some issues on latest
build)
Description for hbase:acl table is wrong on master-status#catalogTables
---
Key: HBASE-10611
URL: https://issues.apache.org/jira/browse/HBASE-10611
Project: HBase
Issue Type: Bug
Affects Versions: 0.96.0
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Minor
Labels: patch
Fix For: 0.96.0
Attachments: HBASE-10611.1.patch
On master-status#catalogTables, I see:
hbase:acl The .NAMESPACE. table holds information about namespaces.
In MasterStatusTmpl.jamon, we have:
{code}
if (tableName.equals(TableName.META_TABLE_NAME)){
description = The hbase:meta table holds references to all User
Table regions;
} else {
description = The .NAMESPACE. table holds information about
namespaces.;
}
{code}
The above check doesn't cover hbase:acl table.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10653) Incorrect table status in HBase shell Describe
[ https://issues.apache.org/jira/browse/HBASE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925548#comment-13925548 ] Rekha Joshi commented on HBASE-10653: - Sure Stack.Good points.I will check output with table_print/terminal_table and update. Please note playing with the latest and greatest of OSX Mavericks 10.9.1, my m/c has all crashed :-( into re-imaging(this time with 10.9.2 :-)) will re-setup my box and get the patch soon.Thanks! Incorrect table status in HBase shell Describe -- Key: HBASE-10653 URL: https://issues.apache.org/jira/browse/HBASE-10653 Project: HBase Issue Type: Bug Components: shell Affects Versions: 0.94.17 Reporter: Biju Nair Assignee: Rekha Joshi Labels: HbaseShell, describe Fix For: 0.94.17 Attachments: HBASE-10653.1.patch Describe output of table which is disabled shows as enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (HBASE-10705) CompactionRequest#toString() may throw NullPointerException
[
https://issues.apache.org/jira/browse/HBASE-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi reassigned HBASE-10705:
---
Assignee: Rekha Joshi
CompactionRequest#toString() may throw NullPointerException
---
Key: HBASE-10705
URL: https://issues.apache.org/jira/browse/HBASE-10705
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Minor
I found the following in
hbase-server/target/surefire-reports/org.apache.hadoop.hbase.util.TestMergeTable-output.txt
:
{code}
2014-03-08 01:22:35,311 INFO [IPC Server handler 0 on 39151]
blockmanagement.BlockManager(1009): BLOCK* addToInvalidates:
blk_1073741852_1028 127.0.0.1:58684
2014-03-08 01:22:35,312 INFO
[RS:0;kiyo:45971-shortCompactions-1394241753752] regionserver.HRegion(1393):
compaction interrupted
java.io.InterruptedIOException: Aborting compaction of store contents in
region test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582. because it was
interrupted.
at
org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:81)
at
org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:109)
at
org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1131)
at
org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:1390)
at
org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:475)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:724)
2014-03-08 01:22:35,314 DEBUG [RS_CLOSE_REGION-kiyo:45971-0]
regionserver.HRegion(1069): Updates disabled for region
test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582.
2014-03-08 01:22:35,316 INFO
[StoreCloserThread-test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582.-1]
regionserver.HStore(793): Closed contents
2014-03-08 01:22:35,316 ERROR
[RS:0;kiyo:45971-shortCompactions-1394241753752]
regionserver.CompactSplitThread$CompactionRunner(496): Compaction failed
Request = regionName=test,,1394241738901.edbcdf3be9dd27c52b1fca1b09a5a582.,
storeName=contents, fileCount=7, fileSize=71.3 M (10.2 M, 10.2 M, 10.2 M,
10.2 M, 10.2 M), priority=3, time=8144240699213330
java.lang.NullPointerException
at
org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest$2.apply(CompactionRequest.java:213)
at
org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest$2.apply(CompactionRequest.java:211)
at com.google.common.collect.Iterators$9.transform(Iterators.java:845)
at
com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48)
at com.google.common.base.Joiner.appendTo(Joiner.java:125)
at com.google.common.base.Joiner.appendTo(Joiner.java:186)
at com.google.common.base.Joiner.join(Joiner.java:243)
at com.google.common.base.Joiner.join(Joiner.java:232)
at
org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.toString(CompactionRequest.java:204)
at java.lang.String.valueOf(String.java:2854)
at java.lang.StringBuilder.append(StringBuilder.java:128)
at
org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.toString(CompactSplitThread.java:425)
at java.lang.String.valueOf(String.java:2854)
at java.lang.StringBuilder.append(StringBuilder.java:128)
at
org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:477)
{code}
The exception came from apply() method:
{code}
}), new FunctionStoreFile, String() {
public String apply(StoreFile sf) {
return StringUtils.humanReadableInt(sf.getReader().length());
}
}));
{code}
Looks like sf.getReader() might become null when
StringUtils.humanReadableInt() is called
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-10711) Savepoint, Rollback features on Hbase Shell and API
[ https://issues.apache.org/jira/browse/HBASE-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reassigned HBASE-10711: --- Assignee: Rekha Joshi Savepoint, Rollback features on Hbase Shell and API --- Key: HBASE-10711 URL: https://issues.apache.org/jira/browse/HBASE-10711 Project: HBase Issue Type: New Feature Components: Admin, shell Affects Versions: 0.94.17 Reporter: Rekha Joshi Assignee: Rekha Joshi In parallel to SQLWorld, Hbase needs to have easy feature to savepoint/rollback/commit. This functionality can help retrieve table state before a set of commands are executed.Especially if one inadvertently drops a table, rollback is a lifesaver. SAVEPOINT savepoint_name ; ROLLBACK [TO SAVEPOINT savepoint_name]; COMMIT; This internally will take a snapshot of table(s) when a command 'savepoint' is executed on hbase shell/api.Each savepoint takes the snapshot , and stores the map with savepoint id to snapshot taken.Will need a retrieval from the last-est savepoint id. Given that it might take some time, this savepoint is the users option if one is into too many operations and one operation goes wrong, they can still start from save point.For better perf, it would be nice to provide command set tables 'a','b','c' and the savepoint command then takes the snapshots of only those tables rather than all. Maybe i am a burnt child dreading the fire, but thoughts? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (HBASE-10711) Savepoint, Rollback features on Hbase Shell and API
Rekha Joshi created HBASE-10711: --- Summary: Savepoint, Rollback features on Hbase Shell and API Key: HBASE-10711 URL: https://issues.apache.org/jira/browse/HBASE-10711 Project: HBase Issue Type: New Feature Components: Admin, shell Affects Versions: 0.94.17 Reporter: Rekha Joshi In parallel to SQLWorld, Hbase needs to have easy feature to savepoint/rollback/commit. This functionality can help retrieve table state before a set of commands are executed.Especially if one inadvertently drops a table, rollback is a lifesaver. SAVEPOINT savepoint_name ; ROLLBACK [TO SAVEPOINT savepoint_name]; COMMIT; This internally will take a snapshot of table(s) when a command 'savepoint' is executed on hbase shell/api.Each savepoint takes the snapshot , and stores the map with savepoint id to snapshot taken.Will need a retrieval from the last-est savepoint id. Given that it might take some time, this savepoint is the users option if one is into too many operations and one operation goes wrong, they can still start from save point.For better perf, it would be nice to provide command set tables 'a','b','c' and the savepoint command then takes the snapshots of only those tables rather than all. Maybe i am a burnt child dreading the fire, but thoughts? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (HBASE-10611) Description for hbase:acl table is wrong on master-status#catalogTables
[
https://issues.apache.org/jira/browse/HBASE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi reassigned HBASE-10611:
---
Assignee: Rekha Joshi
Description for hbase:acl table is wrong on master-status#catalogTables
---
Key: HBASE-10611
URL: https://issues.apache.org/jira/browse/HBASE-10611
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Rekha Joshi
Priority: Minor
On master-status#catalogTables, I see:
hbase:acl The .NAMESPACE. table holds information about namespaces.
In MasterStatusTmpl.jamon, we have:
{code}
if (tableName.equals(TableName.META_TABLE_NAME)){
description = The hbase:meta table holds references to all User
Table regions;
} else {
description = The .NAMESPACE. table holds information about
namespaces.;
}
{code}
The above check doesn't cover hbase:acl table.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-10588) Remove deprecated public facing classes/methods related to KeyValue
[ https://issues.apache.org/jira/browse/HBASE-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reassigned HBASE-10588: --- Assignee: Rekha Joshi Remove deprecated public facing classes/methods related to KeyValue --- Key: HBASE-10588 URL: https://issues.apache.org/jira/browse/HBASE-10588 Project: HBase Issue Type: Sub-task Reporter: Jimmy Xiang Assignee: Rekha Joshi Fix For: 0.99.0 Due to backward compatibility issue, old public facing classes/methods related to KeyValue are deprecated. We should clean them up after they have been deprecated for a while. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-8604) improve reporting of incorrect peer address in replication
[ https://issues.apache.org/jira/browse/HBASE-8604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-8604: --- Attachment: HBASE-8604.1.patch Patch available. improve reporting of incorrect peer address in replication -- Key: HBASE-8604 URL: https://issues.apache.org/jira/browse/HBASE-8604 Project: HBase Issue Type: Improvement Components: Replication Affects Versions: 0.94.6 Reporter: Roman Shaposhnik Assignee: Rekha Joshi Priority: Minor Fix For: 0.94.19 Attachments: HBASE-8604.1.patch I was running some replication code that incorrectly advertised the peer address for replication. HBase complained that the format of the record was NOT what it was expecting but it didn't include what it saw in the exception message. Including that string would help cutting down the time it takes to debug issues like that. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-8604) improve reporting of incorrect peer address in replication
[ https://issues.apache.org/jira/browse/HBASE-8604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-8604: --- Fix Version/s: 0.94.19 Assignee: Rekha Joshi Status: Patch Available (was: Open) Patch available. improve reporting of incorrect peer address in replication -- Key: HBASE-8604 URL: https://issues.apache.org/jira/browse/HBASE-8604 Project: HBase Issue Type: Improvement Components: Replication Affects Versions: 0.94.6 Reporter: Roman Shaposhnik Assignee: Rekha Joshi Priority: Minor Fix For: 0.94.19 Attachments: HBASE-8604.1.patch I was running some replication code that incorrectly advertised the peer address for replication. HBase complained that the format of the record was NOT what it was expecting but it didn't include what it saw in the exception message. Including that string would help cutting down the time it takes to debug issues like that. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (HBASE-9270) [0.94] FSTableDescriptors caching is racy
[
https://issues.apache.org/jira/browse/HBASE-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi reassigned HBASE-9270:
--
Assignee: Rekha Joshi
[0.94] FSTableDescriptors caching is racy
-
Key: HBASE-9270
URL: https://issues.apache.org/jira/browse/HBASE-9270
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.11
Reporter: Andrew Purtell
Assignee: Rekha Joshi
Priority: Minor
Attachments: HBASE-9270.1.patch
An occasionally failing test in 0.92 branch that concurrently executes master
operations on a single table found this problem in FSTableDescriptors:
{code}
diff --git src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
index e882621..b0042cd 100644
--- src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
+++ src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
@@ -221,8 +221,15 @@ public class FSTableDescriptors implements
TableDescriptors {
if
(HConstants.HBASE_NON_USER_TABLE_DIRS.contains(htd.getNameAsString())) {
throw new NotImplementedException();
}
-if (!this.fsreadonly) updateHTableDescriptor(this.fs, this.rootdir, htd);
-long modtime = getTableInfoModtime(this.fs, this.rootdir,
htd.getNameAsString());
+if (fsreadonly) {
+ // Cannot cache here.
+ // We can't know if a modtime from the most recent file found in a
+ // directory listing at some arbitrary point in time still corresponds
+ // to the latest, nor that our htd is the latest.
+ return;
+}
+// Cache with the modtime of the descriptor we wrote
+long modtime = updateHTableDescriptor(this.fs, this.rootdir,
htd).getModificationTime();
this.cache.put(htd.getNameAsString(), new
TableDescriptorModtime(modtime, htd));
}
{code}
After HBASE-7305 master operations are serialized by a write lock on the
table.
However, 0.94 has code with the same issue:
{code}
@Override
public void add(HTableDescriptor htd) throws IOException {
if (Bytes.equals(HConstants.ROOT_TABLE_NAME, htd.getName())) {
throw new NotImplementedException();
}
if (Bytes.equals(HConstants.META_TABLE_NAME, htd.getName())) {
throw new NotImplementedException();
}
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(htd.getNameAsString()))
{
throw new NotImplementedException();
}
if (!this.fsreadonly) updateHTableDescriptor(this.fs, this.rootdir, htd);
String tableName = htd.getNameAsString();
long modtime = getTableInfoModtime(this.fs, this.rootdir, tableName);
long dirmodtime = getTableDirModtime(this.fs, this.rootdir, tableName);
this.cache.put(tableName, new TableDescriptorModtime(modtime, dirmodtime,
htd));
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-7193) [89-fb] Print the detail exceptions info from the RetriesExhaustedException
[ https://issues.apache.org/jira/browse/HBASE-7193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reassigned HBASE-7193: -- Assignee: Rekha Joshi [89-fb] Print the detail exceptions info from the RetriesExhaustedException --- Key: HBASE-7193 URL: https://issues.apache.org/jira/browse/HBASE-7193 Project: HBase Issue Type: Improvement Reporter: Liyin Tang Assignee: Rekha Joshi Priority: Minor The hbase client only prints the name of exception for the RetriesExhaustedException logging purpose, which failed to provide any useful debug information. So this jira is to enhance the logging to print the entire stack track of the exception to help on issue investigation. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-7193) [89-fb] Print the detail exceptions info from the RetriesExhaustedException
[ https://issues.apache.org/jira/browse/HBASE-7193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920733#comment-13920733 ] Rekha Joshi commented on HBASE-7193: just a thought, would not RetriesExhaustedWithDetailsException and its methods suffice for your use-case? [89-fb] Print the detail exceptions info from the RetriesExhaustedException --- Key: HBASE-7193 URL: https://issues.apache.org/jira/browse/HBASE-7193 Project: HBase Issue Type: Improvement Reporter: Liyin Tang Assignee: Rekha Joshi Priority: Minor The hbase client only prints the name of exception for the RetriesExhaustedException logging purpose, which failed to provide any useful debug information. So this jira is to enhance the logging to print the entire stack track of the exception to help on issue investigation. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (HBASE-10668) TestExportSnapshot runs too long
[
https://issues.apache.org/jira/browse/HBASE-10668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi reassigned HBASE-10668:
---
Assignee: Rekha Joshi
TestExportSnapshot runs too long
Key: HBASE-10668
URL: https://issues.apache.org/jira/browse/HBASE-10668
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: Rekha Joshi
Fix For: 0.98.1, 0.99.0
332 seconds
{noformat}
Forking command line: /bin/sh -c cd /data/src/hbase/hbase-server
/usr/lib/jvm/java-1.7.0.45-oracle-amd64/jre/bin/java -enableassertions
-Xmx1900m -XX:MaxPermSize=100m -Djava.security.egd=file:/dev/./urandom
-Djava.net.preferIPv4Stack=true -Djava.awt.headless=true -jar
/data/src/hbase/hbase-server/target/surefire/surefirebooter1668068702110669265.jar
/data/src/hbase/hbase-server/target/surefire/surefire5744357307851892501tmp
/data/src/hbase/hbase-server/target/surefire/surefire_3661340119563945183029tmp
Running org.apache.hadoop.hbase.snapshot.TestExportSnapshot
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 332.421 sec
{noformat}
Slim down or split up.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-10664) TestImportExport runs too long
[
https://issues.apache.org/jira/browse/HBASE-10664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi reassigned HBASE-10664:
---
Assignee: Rekha Joshi
TestImportExport runs too long
--
Key: HBASE-10664
URL: https://issues.apache.org/jira/browse/HBASE-10664
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: Rekha Joshi
Fix For: 0.98.1, 0.99.0
Debugging with -Dsurefire.firstPartForkMode=always
-Dsurefire.secondPartForkMode=always looking for a hanging test.
388 seconds.
{noformat}
Forking command line: /bin/sh -c cd /data/src/hbase/hbase-server
/usr/lib/jvm/java-1.7.0.45-oracle-amd64/jre/bin/java -enableassertions
-Xmx1900m -XX:MaxPermSize=100m -Djava.security.egd=file:/dev/./urandom
-Djava.net.preferIPv4Stack=true -Djava.awt.headless=true -jar
/data/src/hbase/hbase-server/target/surefire/surefirebooter7637958208277391169.jar
/data/src/hbase/hbase-server/target/surefire/surefire6877889026110956843tmp
/data/src/hbase/hbase-server/target/surefire/surefire_1907837210788480451831tmp
Running org.apache.hadoop.hbase.mapreduce.TestImportExport
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 388.246 sec
{noformat}
Slim down or break it up.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-10667) TestEncodedSeekers runs too long
[
https://issues.apache.org/jira/browse/HBASE-10667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi reassigned HBASE-10667:
---
Assignee: Rekha Joshi
TestEncodedSeekers runs too long
Key: HBASE-10667
URL: https://issues.apache.org/jira/browse/HBASE-10667
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.0
Reporter: Andrew Purtell
Assignee: Rekha Joshi
Fix For: 0.98.1, 0.99.0
214 seconds, borderline
{noformat}
Forking command line: /bin/sh -c cd /data/src/hbase/hbase-server
/usr/lib/jvm/java-1.7.0.45-oracle-amd64/jre/bin/java -enableassertions
-Xmx1900m -XX:MaxPermSize=100m -Djava.security.egd=file:/dev/./urandom
-Djava.net.preferIPv4Stack=true -Djava.awt.headless=true -jar
/data/src/hbase/hbase-server/target/surefire/surefirebooter309171614766381235.jar
/data/src/hbase/hbase-server/target/surefire/surefire1759919541562435761tmp
/data/src/hbase/hbase-server/target/surefire/surefire_274515185028609451271tmp
Running org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 214.105 sec
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-10653) Incorrect table status in HBase shell Describe
[ https://issues.apache.org/jira/browse/HBASE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reassigned HBASE-10653: --- Assignee: Rekha Joshi Incorrect table status in HBase shell Describe -- Key: HBASE-10653 URL: https://issues.apache.org/jira/browse/HBASE-10653 Project: HBase Issue Type: Bug Components: shell Reporter: Biju Nair Assignee: Rekha Joshi Labels: HbaseShell, describe Describe output of table which is disabled shows as enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-10653) Incorrect table status in HBase shell Describe
[ https://issues.apache.org/jira/browse/HBASE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-10653: Fix Version/s: 0.94.17 Affects Version/s: 0.94.17 Status: Patch Available (was: In Progress) Attached quick patch to have ENABLED set in separate line to avoid confusion. Incorrect table status in HBase shell Describe -- Key: HBASE-10653 URL: https://issues.apache.org/jira/browse/HBASE-10653 Project: HBase Issue Type: Bug Components: shell Affects Versions: 0.94.17 Reporter: Biju Nair Assignee: Rekha Joshi Labels: HbaseShell, describe Fix For: 0.94.17 Attachments: HBASE-10653.1.patch Describe output of table which is disabled shows as enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-10653) Incorrect table status in HBase shell Describe
[
https://issues.apache.org/jira/browse/HBASE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-10653:
Attachment: HBASE-10653.1.patch
Verified and enabled(true,here) is not clear.
{noformat}
describe 'ripple_dnb_test'
DESCRIPTION
ENABLED
{NAME = 'ripple_dnb_test', FAMILIES = [{NAME = 'master',
DATA_BLOCK_ENCODING = 'NONE', BLOOMFILTER = 'NONE', REPLICATION true
_SCOPE = '0', VERSIONS = '3', COMPRESSION = 'NONE', MIN_VERSIONS = '0',
TTL = '2147483647', KEEP_DELETED_CELLS = 'false
', BLOCKSIZE = '65536', IN_MEMORY = 'false', ENCODE_ON_DISK = 'true',
BLOCKCACHE = 'true'}]}
1 row(s) in 0.2660 seconds
{noformat}
Attached quick patch to have ENABLED set in separate line to avoid confusion.
Incorrect table status in HBase shell Describe
--
Key: HBASE-10653
URL: https://issues.apache.org/jira/browse/HBASE-10653
Project: HBase
Issue Type: Bug
Components: shell
Affects Versions: 0.94.17
Reporter: Biju Nair
Assignee: Rekha Joshi
Labels: HbaseShell, describe
Fix For: 0.94.17
Attachments: HBASE-10653.1.patch
Describe output of table which is disabled shows as enabled.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Work started] (HBASE-10653) Incorrect table status in HBase shell Describe
[ https://issues.apache.org/jira/browse/HBASE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-10653 started by Rekha Joshi. Incorrect table status in HBase shell Describe -- Key: HBASE-10653 URL: https://issues.apache.org/jira/browse/HBASE-10653 Project: HBase Issue Type: Bug Components: shell Affects Versions: 0.94.17 Reporter: Biju Nair Assignee: Rekha Joshi Labels: HbaseShell, describe Fix For: 0.94.17 Attachments: HBASE-10653.1.patch Describe output of table which is disabled shows as enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10653) Incorrect table status in HBase shell Describe
[ https://issues.apache.org/jira/browse/HBASE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920783#comment-13920783 ] Rekha Joshi commented on HBASE-10653: - Towards format changes, think we may introduce –noformat option on shell (hbase noformat RETURN or ./bin/hbase shell –noformat option) 1.Towards that approach, stipulate changes mainly in shell.rb/or couple files and passed effect.But more testing needed to check if –noformat has no adverse effect on multiple cmds. 2.Or Should we think to have options like RDBMS(SQLWorld), provide user to set column format, line size etc (sqlcolumn column_name format a30 ; sqlset line size 300, etc) What do you think? Incorrect table status in HBase shell Describe -- Key: HBASE-10653 URL: https://issues.apache.org/jira/browse/HBASE-10653 Project: HBase Issue Type: Bug Components: shell Affects Versions: 0.94.17 Reporter: Biju Nair Assignee: Rekha Joshi Labels: HbaseShell, describe Fix For: 0.94.17 Attachments: HBASE-10653.1.patch Describe output of table which is disabled shows as enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-9270) [0.94] FSTableDescriptors caching is racy
[
https://issues.apache.org/jira/browse/HBASE-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-9270:
---
Attachment: HBASE-9270.1.patch
Patch has only forced return, as 0.94 has refined getTableInfoModtime(),
getTableDirModtime(), and overloaded getTableInfoPath() methods.
[0.94] FSTableDescriptors caching is racy
-
Key: HBASE-9270
URL: https://issues.apache.org/jira/browse/HBASE-9270
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.11
Reporter: Andrew Purtell
Priority: Minor
Attachments: HBASE-9270.1.patch
An occasionally failing test in 0.92 branch that concurrently executes master
operations on a single table found this problem in FSTableDescriptors:
{code}
diff --git src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
index e882621..b0042cd 100644
--- src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
+++ src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
@@ -221,8 +221,15 @@ public class FSTableDescriptors implements
TableDescriptors {
if
(HConstants.HBASE_NON_USER_TABLE_DIRS.contains(htd.getNameAsString())) {
throw new NotImplementedException();
}
-if (!this.fsreadonly) updateHTableDescriptor(this.fs, this.rootdir, htd);
-long modtime = getTableInfoModtime(this.fs, this.rootdir,
htd.getNameAsString());
+if (fsreadonly) {
+ // Cannot cache here.
+ // We can't know if a modtime from the most recent file found in a
+ // directory listing at some arbitrary point in time still corresponds
+ // to the latest, nor that our htd is the latest.
+ return;
+}
+// Cache with the modtime of the descriptor we wrote
+long modtime = updateHTableDescriptor(this.fs, this.rootdir,
htd).getModificationTime();
this.cache.put(htd.getNameAsString(), new
TableDescriptorModtime(modtime, htd));
}
{code}
After HBASE-7305 master operations are serialized by a write lock on the
table.
However, 0.94 has code with the same issue:
{code}
@Override
public void add(HTableDescriptor htd) throws IOException {
if (Bytes.equals(HConstants.ROOT_TABLE_NAME, htd.getName())) {
throw new NotImplementedException();
}
if (Bytes.equals(HConstants.META_TABLE_NAME, htd.getName())) {
throw new NotImplementedException();
}
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(htd.getNameAsString()))
{
throw new NotImplementedException();
}
if (!this.fsreadonly) updateHTableDescriptor(this.fs, this.rootdir, htd);
String tableName = htd.getNameAsString();
long modtime = getTableInfoModtime(this.fs, this.rootdir, tableName);
long dirmodtime = getTableDirModtime(this.fs, this.rootdir, tableName);
this.cache.put(tableName, new TableDescriptorModtime(modtime, dirmodtime,
htd));
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-9270) [0.94] FSTableDescriptors caching is racy
[
https://issues.apache.org/jira/browse/HBASE-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-9270:
---
Status: Patch Available (was: Open)
Patch has only forced return, as 0.94 has refined getTableInfoModtime(),
getTableDirModtime(), and overloaded getTableInfoPath() methods.
[0.94] FSTableDescriptors caching is racy
-
Key: HBASE-9270
URL: https://issues.apache.org/jira/browse/HBASE-9270
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.11
Reporter: Andrew Purtell
Priority: Minor
Attachments: HBASE-9270.1.patch
An occasionally failing test in 0.92 branch that concurrently executes master
operations on a single table found this problem in FSTableDescriptors:
{code}
diff --git src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
index e882621..b0042cd 100644
--- src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
+++ src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
@@ -221,8 +221,15 @@ public class FSTableDescriptors implements
TableDescriptors {
if
(HConstants.HBASE_NON_USER_TABLE_DIRS.contains(htd.getNameAsString())) {
throw new NotImplementedException();
}
-if (!this.fsreadonly) updateHTableDescriptor(this.fs, this.rootdir, htd);
-long modtime = getTableInfoModtime(this.fs, this.rootdir,
htd.getNameAsString());
+if (fsreadonly) {
+ // Cannot cache here.
+ // We can't know if a modtime from the most recent file found in a
+ // directory listing at some arbitrary point in time still corresponds
+ // to the latest, nor that our htd is the latest.
+ return;
+}
+// Cache with the modtime of the descriptor we wrote
+long modtime = updateHTableDescriptor(this.fs, this.rootdir,
htd).getModificationTime();
this.cache.put(htd.getNameAsString(), new
TableDescriptorModtime(modtime, htd));
}
{code}
After HBASE-7305 master operations are serialized by a write lock on the
table.
However, 0.94 has code with the same issue:
{code}
@Override
public void add(HTableDescriptor htd) throws IOException {
if (Bytes.equals(HConstants.ROOT_TABLE_NAME, htd.getName())) {
throw new NotImplementedException();
}
if (Bytes.equals(HConstants.META_TABLE_NAME, htd.getName())) {
throw new NotImplementedException();
}
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(htd.getNameAsString()))
{
throw new NotImplementedException();
}
if (!this.fsreadonly) updateHTableDescriptor(this.fs, this.rootdir, htd);
String tableName = htd.getNameAsString();
long modtime = getTableInfoModtime(this.fs, this.rootdir, tableName);
long dirmodtime = getTableDirModtime(this.fs, this.rootdir, tableName);
this.cache.put(tableName, new TableDescriptorModtime(modtime, dirmodtime,
htd));
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-9294) NPE in /rs-status during RS shutdown
[ https://issues.apache.org/jira/browse/HBASE-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-9294: --- Labels: patch (was: ) Status: Patch Available (was: Open) Patch available NPE in /rs-status during RS shutdown Key: HBASE-9294 URL: https://issues.apache.org/jira/browse/HBASE-9294 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.95.2 Reporter: Steve Loughran Priority: Minor Labels: patch Attachments: HBASE-9294.1.patch While hitting reload to see when a kill-initiated RS shutdown would make the Web UI go away, I got a stack trace from an NPE -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-9294) NPE in /rs-status during RS shutdown
[ https://issues.apache.org/jira/browse/HBASE-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated HBASE-9294: --- Attachment: HBASE-9294.1.patch Patch available. NPE in /rs-status during RS shutdown Key: HBASE-9294 URL: https://issues.apache.org/jira/browse/HBASE-9294 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.95.2 Reporter: Steve Loughran Priority: Minor Labels: patch Attachments: HBASE-9294.1.patch While hitting reload to see when a kill-initiated RS shutdown would make the Web UI go away, I got a stack trace from an NPE -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (HBASE-9355) HBaseTestingUtility#cleanupDataTestDirOnTestFS() doesn't close the FileSystem
[
https://issues.apache.org/jira/browse/HBASE-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-9355:
---
Affects Version/s: 0.92.2
Status: Patch Available (was: Open)
Attached patch.
Think the configuration parameter - fs.automatic.close set to true seems
better, rather than the boilerplate.What do you think?
HBaseTestingUtility#cleanupDataTestDirOnTestFS() doesn't close the FileSystem
-
Key: HBASE-9355
URL: https://issues.apache.org/jira/browse/HBASE-9355
Project: HBase
Issue Type: Test
Affects Versions: 0.92.2
Reporter: Ted Yu
Priority: Minor
Attachments: HBASE-9355.1.patch
Here is related code:
{code}
public boolean cleanupDataTestDirOnTestFS() throws IOException {
boolean ret = getTestFileSystem().delete(dataTestDirOnTestFS, true);
if (ret)
dataTestDirOnTestFS = null;
return ret;
}
{code}
The FileSystem returned by getTestFileSystem() is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HBASE-9355) HBaseTestingUtility#cleanupDataTestDirOnTestFS() doesn't close the FileSystem
[
https://issues.apache.org/jira/browse/HBASE-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-9355:
---
Attachment: HBASE-9355.1.patch
Attached patch.
Think the configuration parameter - fs.automatic.close set to true seems
better, rather than the boilerplate.What do you think?
HBaseTestingUtility#cleanupDataTestDirOnTestFS() doesn't close the FileSystem
-
Key: HBASE-9355
URL: https://issues.apache.org/jira/browse/HBASE-9355
Project: HBase
Issue Type: Test
Affects Versions: 0.92.2
Reporter: Ted Yu
Priority: Minor
Attachments: HBASE-9355.1.patch
Here is related code:
{code}
public boolean cleanupDataTestDirOnTestFS() throws IOException {
boolean ret = getTestFileSystem().delete(dataTestDirOnTestFS, true);
if (ret)
dataTestDirOnTestFS = null;
return ret;
}
{code}
The FileSystem returned by getTestFileSystem() is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (HBASE-9294) NPE in /rs-status during RS shutdown
[ https://issues.apache.org/jira/browse/HBASE-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reassigned HBASE-9294: -- Assignee: Rekha Joshi NPE in /rs-status during RS shutdown Key: HBASE-9294 URL: https://issues.apache.org/jira/browse/HBASE-9294 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.95.2 Reporter: Steve Loughran Assignee: Rekha Joshi Priority: Minor Labels: patch Attachments: HBASE-9294.1.patch While hitting reload to see when a kill-initiated RS shutdown would make the Web UI go away, I got a stack trace from an NPE -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10599) Replace System.currentMillis() with EnvironmentEdge.currentTimeMillis in memstore flusher and related places
[ https://issues.apache.org/jira/browse/HBASE-10599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911454#comment-13911454 ] Rekha Joshi commented on HBASE-10599: - This class patch may go through, but some interesting history here: HBASE-6476 Rather than one at a time, Lars, Chris attempted this change for across codebase in single script, some concerns. Replace System.currentMillis() with EnvironmentEdge.currentTimeMillis in memstore flusher and related places Key: HBASE-10599 URL: https://issues.apache.org/jira/browse/HBASE-10599 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0, 0.96.1.1 Reporter: ramkrishna.s.vasudevan Assignee: ramkrishna.s.vasudevan Fix For: 0.96.2, 0.98.1, 0.99.0 Memstoreflusher still uses System.currentMillis. Better to replace it with EnvironmentEdge.currentMillis(), -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HBASE-9979) TestUsersOperationsWithSecureHadoop should be medium test
[
https://issues.apache.org/jira/browse/HBASE-9979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-9979:
---
Labels: test (was: )
Affects Version/s: 0.96.1.1
Release Note: TestUsersOperationsWithSecureHadoop marked Medium.
Status: Patch Available (was: Open)
Attached patch
TestUsersOperationsWithSecureHadoop should be medium test
-
Key: HBASE-9979
URL: https://issues.apache.org/jira/browse/HBASE-9979
Project: HBase
Issue Type: Test
Affects Versions: 0.96.1.1
Reporter: Ted Yu
Priority: Minor
Labels: test
Attachments: HBASE-9979.1.patch
From https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/838/console :
{code}
Running org.apache.hadoop.hbase.security.TestUsersOperationsWithSecureHadoop
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 152.96 sec
{code}
TestUsersOperationsWithSecureHadoop should be marked as medium test
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HBASE-9979) TestUsersOperationsWithSecureHadoop should be medium test
[
https://issues.apache.org/jira/browse/HBASE-9979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rekha Joshi updated HBASE-9979:
---
Attachment: HBASE-9979.1.patch
TestUsersOperationsWithSecureHadoop should be medium test
-
Key: HBASE-9979
URL: https://issues.apache.org/jira/browse/HBASE-9979
Project: HBase
Issue Type: Test
Affects Versions: 0.96.1.1
Reporter: Ted Yu
Priority: Minor
Labels: test
Attachments: HBASE-9979.1.patch
From https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/838/console :
{code}
Running org.apache.hadoop.hbase.security.TestUsersOperationsWithSecureHadoop
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 152.96 sec
{code}
TestUsersOperationsWithSecureHadoop should be marked as medium test
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
