[jira] [Commented] (HBASE-5736) ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252845#comment-13252845 ] Scott Chen commented on HBASE-5736: --- Thanks for doing the 94 patch > ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly > - > > Key: HBASE-5736 > URL: https://issues.apache.org/jira/browse/HBASE-5736 > Project: HBase > Issue Type: Bug >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0, 0.96.0 > > Attachments: 5736-94.txt, HBASE-5736.D2649.1.patch, > HBASE-5736.D2649.2.patch, HBASE-5736.D2649.3.patch > > > We have fixed similar bug in > https://issues.apache.org/jira/browse/HBASE-5507 > It uses ByteBuffer.array() to read the ByteBuffer. > This will ignore the offset return the whole underlying byte array. > The bug can be triggered by using framed Transport thrift servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5736) ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248556#comment-13248556 ] Scott Chen commented on HBASE-5736: --- The test got timeout. It makes sense because I am adding more steps to the test. Increasing the timeout should fix this. > ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly > - > > Key: HBASE-5736 > URL: https://issues.apache.org/jira/browse/HBASE-5736 > Project: HBase > Issue Type: Bug >Reporter: Scott Chen >Assignee: Scott Chen > Attachments: HBASE-5736.D2649.1.patch, HBASE-5736.D2649.2.patch, > HBASE-5736.D2649.3.patch > > > We have fixed similar bug in > https://issues.apache.org/jira/browse/HBASE-5507 > It uses ByteBuffer.array() to read the ByteBuffer. > This will ignore the offset return the whole underlying byte array. > The bug can be triggered by using framed Transport thrift servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5736) ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248548#comment-13248548 ] Scott Chen commented on HBASE-5736: --- Failed test seems related. I will take a look. > ThriftServerRunner.HbaseHandler.mutateRow() does not use ByteBuffer correctly > - > > Key: HBASE-5736 > URL: https://issues.apache.org/jira/browse/HBASE-5736 > Project: HBase > Issue Type: Bug >Reporter: Scott Chen >Assignee: Scott Chen > Attachments: HBASE-5736.D2649.1.patch, HBASE-5736.D2649.2.patch > > > We have fixed similar bug in > https://issues.apache.org/jira/browse/HBASE-5507 > It uses ByteBuffer.array() to read the ByteBuffer. > This will ignore the offset return the whole underlying byte array. > The bug can be triggered by using framed Transport thrift servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5674) add support in HBase to overwrite hbase timestamp to a version number during major compaction
[
https://issues.apache.org/jira/browse/HBASE-5674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242851#comment-13242851
]
Scott Chen commented on HBASE-5674:
---
{quote}
The timestamp takes 8 bytes for every column.
{quote}
I meant to say
the timestamp takes 8 bytes for every keyvalue.
> add support in HBase to overwrite hbase timestamp to a version number during
> major compaction
> -
>
> Key: HBASE-5674
> URL: https://issues.apache.org/jira/browse/HBASE-5674
> Project: HBase
> Issue Type: Improvement
>Reporter: He Yongqiang
>Assignee: He Yongqiang
>
> Right now, a millisecond-level timestamp is attached to every record.
> In our case, we only need a version number (mostly it will be just zero etc).
> A millisecond timestamp is too heavy to carry. We should add support to
> overwrite it to zero during major compaction.
> KVs before major compaction will remain using system timestamp. And this
> should be configurable, so that we should not mess up if the hbase timestamp
> is specified by application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5674) add support in HBase to overwrite hbase timestamp to a version number during major compaction
[ https://issues.apache.org/jira/browse/HBASE-5674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242850#comment-13242850 ] Scott Chen commented on HBASE-5674: --- > Can you not just have your client specify timestamp of 0? We still need the timestamp when the write was happening for versioning. But after major compaction we don't need the exact timestamp. We only need to know it's version is old. The timestamp takes 8 bytes for every column. And the last digits of these timestamps are very random so it cannot be compressed well. In our tests, the space it consumed can be quite significant. I believe in a lot of use cases, these millisecond resolution timestamp may not be useful after compaction. It will be nice to have the ability to remove them to save some spaces. > add support in HBase to overwrite hbase timestamp to a version number during > major compaction > - > > Key: HBASE-5674 > URL: https://issues.apache.org/jira/browse/HBASE-5674 > Project: HBase > Issue Type: Improvement >Reporter: He Yongqiang >Assignee: He Yongqiang > > Right now, a millisecond-level timestamp is attached to every record. > In our case, we only need a version number (mostly it will be just zero etc). > A millisecond timestamp is too heavy to carry. We should add support to > overwrite it to zero during major compaction. > KVs before major compaction will remain using system timestamp. And this > should be configurable, so that we should not mess up if the hbase timestamp > is specified by application. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5544) Add metrics to HRegion.processRow()
[ https://issues.apache.org/jira/browse/HBASE-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240797#comment-13240797 ] Scott Chen commented on HBASE-5544: --- Thanks, Ted > Add metrics to HRegion.processRow() > --- > > Key: HBASE-5544 > URL: https://issues.apache.org/jira/browse/HBASE-5544 > Project: HBase > Issue Type: New Feature >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5544.D2457.1.patch, HBASE-5544.D2457.2.patch, > HBASE-5544.D2457.2.patch > > > Add metrics of > 1. time for waiting for the lock > 2. processing time (scan time) > 3. time spent while holding the lock > 4. total call time > 5. number of failures / calls -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5613) ThriftServer getTableRegions does not return serverName and port
[ https://issues.apache.org/jira/browse/HBASE-5613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236822#comment-13236822 ] Scott Chen commented on HBASE-5613: --- @Ted: You're right. I haven't rebase this branch. Let me do that and update the patch. > ThriftServer getTableRegions does not return serverName and port > > > Key: HBASE-5613 > URL: https://issues.apache.org/jira/browse/HBASE-5613 > Project: HBase > Issue Type: Bug > Components: thrift >Reporter: Scott Chen >Assignee: Scott Chen >Priority: Minor > Fix For: 0.94.0, 0.96.0 > > Attachments: HBASE-5613.0.94.txt, HBASE-5613.D2403.1.patch, > HBASE-5613.D2403.2.patch, HBASE-5613.D2403.3.patch, HBASE-5613.D2403.4.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5613) ThriftServer getTableRegions does not return serverName and port
[ https://issues.apache.org/jira/browse/HBASE-5613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236180#comment-13236180 ] Scott Chen commented on HBASE-5613: --- Upload the patch for 0.94 > ThriftServer getTableRegions does not return serverName and port > > > Key: HBASE-5613 > URL: https://issues.apache.org/jira/browse/HBASE-5613 > Project: HBase > Issue Type: Bug > Components: thrift >Reporter: Scott Chen >Assignee: Scott Chen >Priority: Minor > Fix For: 0.94.0, 0.96.0 > > Attachments: HBASE-5613.0.94.txt, HBASE-5613.D2403.1.patch, > HBASE-5613.D2403.2.patch, HBASE-5613.D2403.3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5613) ThriftServer getTableRegions does not return serverName and port
[ https://issues.apache.org/jira/browse/HBASE-5613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235828#comment-13235828 ] Scott Chen commented on HBASE-5613: --- TestThriftServerCmdLine should be related. I will fix it. > ThriftServer getTableRegions does not return serverName and port > > > Key: HBASE-5613 > URL: https://issues.apache.org/jira/browse/HBASE-5613 > Project: HBase > Issue Type: Bug > Components: thrift >Reporter: Scott Chen >Assignee: Scott Chen >Priority: Minor > Attachments: HBASE-5613.D2403.1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
[ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235821#comment-13235821 ] Scott Chen commented on HBASE-5542: --- @Lars: Synced and run TestAtomicOperation and TestRowProcessorEndpoint. It works fine. Thanks! > Unify HRegion.mutateRowsWithLocks() and HRegion.processRow() > > > Key: HBASE-5542 > URL: https://issues.apache.org/jira/browse/HBASE-5542 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5542.2.txt, HBASE-5542.3.txt, HBASE-5542.4.txt, > HBASE-5542.4.txt, HBASE-5542.4.txt, HBASE-5542.D2217.1.patch, > HBASE-5542.D2217.10.patch, HBASE-5542.D2217.11.patch, > HBASE-5542.D2217.12.patch, HBASE-5542.D2217.13.patch, > HBASE-5542.D2217.14.patch, HBASE-5542.D2217.15.patch, > HBASE-5542.D2217.2.patch, HBASE-5542.D2217.3.patch, HBASE-5542.D2217.4.patch, > HBASE-5542.D2217.5.patch, HBASE-5542.D2217.6.patch, HBASE-5542.D2217.7.patch, > HBASE-5542.D2217.8.patch, HBASE-5542.D2217.9.patch, HBASE-5542.txt > > > mutateRowsWithLocks() does atomic mutations on multiple rows. > processRow() does atomic read-modify-writes on a single row. > It will be useful to generalize both and have a > processRowsWithLocks() that does atomic read-modify-writes on multiple rows. > This also helps reduce some redundancy in the codes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
[ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235808#comment-13235808 ] Scott Chen commented on HBASE-5542: --- Thanks for committing this :) > Unify HRegion.mutateRowsWithLocks() and HRegion.processRow() > > > Key: HBASE-5542 > URL: https://issues.apache.org/jira/browse/HBASE-5542 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5542.2.txt, HBASE-5542.3.txt, HBASE-5542.4.txt, > HBASE-5542.4.txt, HBASE-5542.4.txt, HBASE-5542.D2217.1.patch, > HBASE-5542.D2217.10.patch, HBASE-5542.D2217.11.patch, > HBASE-5542.D2217.12.patch, HBASE-5542.D2217.13.patch, > HBASE-5542.D2217.14.patch, HBASE-5542.D2217.15.patch, > HBASE-5542.D2217.2.patch, HBASE-5542.D2217.3.patch, HBASE-5542.D2217.4.patch, > HBASE-5542.D2217.5.patch, HBASE-5542.D2217.6.patch, HBASE-5542.D2217.7.patch, > HBASE-5542.D2217.8.patch, HBASE-5542.D2217.9.patch, HBASE-5542.txt > > > mutateRowsWithLocks() does atomic mutations on multiple rows. > processRow() does atomic read-modify-writes on a single row. > It will be useful to generalize both and have a > processRowsWithLocks() that does atomic read-modify-writes on multiple rows. > This also helps reduce some redundancy in the codes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
[ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235807#comment-13235807 ] Scott Chen commented on HBASE-5542: --- @Lars: No problem. Let me do that right away. > Unify HRegion.mutateRowsWithLocks() and HRegion.processRow() > > > Key: HBASE-5542 > URL: https://issues.apache.org/jira/browse/HBASE-5542 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5542.2.txt, HBASE-5542.3.txt, HBASE-5542.4.txt, > HBASE-5542.4.txt, HBASE-5542.4.txt, HBASE-5542.D2217.1.patch, > HBASE-5542.D2217.10.patch, HBASE-5542.D2217.11.patch, > HBASE-5542.D2217.12.patch, HBASE-5542.D2217.13.patch, > HBASE-5542.D2217.14.patch, HBASE-5542.D2217.15.patch, > HBASE-5542.D2217.2.patch, HBASE-5542.D2217.3.patch, HBASE-5542.D2217.4.patch, > HBASE-5542.D2217.5.patch, HBASE-5542.D2217.6.patch, HBASE-5542.D2217.7.patch, > HBASE-5542.D2217.8.patch, HBASE-5542.D2217.9.patch, HBASE-5542.txt > > > mutateRowsWithLocks() does atomic mutations on multiple rows. > processRow() does atomic read-modify-writes on a single row. > It will be useful to generalize both and have a > processRowsWithLocks() that does atomic read-modify-writes on multiple rows. > This also helps reduce some redundancy in the codes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5565) Refactoring doMiniBatchPut()
[ https://issues.apache.org/jira/browse/HBASE-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235739#comment-13235739 ] Scott Chen commented on HBASE-5565: --- @Lars: Feel free to assign this back to me if you don't have time for this. I will be more than happy to review your patch also. > Refactoring doMiniBatchPut() > > > Key: HBASE-5565 > URL: https://issues.apache.org/jira/browse/HBASE-5565 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Lars Hofhansl > Fix For: 0.96.0 > > > HBASE-5542 introduce a RowProcessor interface that can handle multi-row > transaction. > It will make the code cleaner if we can make doMiniBatchPut() to be covered > by RowProcessor. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5298) Add thrift metrics to thrift2
[ https://issues.apache.org/jira/browse/HBASE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235103#comment-13235103 ] Scott Chen commented on HBASE-5298: --- 0.96 is fine with me. @apurtell: What do you think? > Add thrift metrics to thrift2 > - > > Key: HBASE-5298 > URL: https://issues.apache.org/jira/browse/HBASE-5298 > Project: HBase > Issue Type: Improvement > Components: metrics, thrift >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0 > > Attachments: 5298-v3.txt, HBASE-5298.D1629.1.patch, > HBASE-5298.D1629.2.patch, HBASE-5298.D1629.3.patch, HBASE-5298.D1629.4.patch > > > We have added thrift metrics collection in HBASE-5186. > It will be good to have them in thrift2 as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
[ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234919#comment-13234919 ] Scott Chen commented on HBASE-5542: --- @Ted: Thanks. I will keep working on this. Sorry for the trouble. > Unify HRegion.mutateRowsWithLocks() and HRegion.processRow() > > > Key: HBASE-5542 > URL: https://issues.apache.org/jira/browse/HBASE-5542 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5542.2.txt, HBASE-5542.3.txt, > HBASE-5542.D2217.1.patch, HBASE-5542.D2217.10.patch, > HBASE-5542.D2217.11.patch, HBASE-5542.D2217.12.patch, > HBASE-5542.D2217.13.patch, HBASE-5542.D2217.14.patch, > HBASE-5542.D2217.15.patch, HBASE-5542.D2217.2.patch, > HBASE-5542.D2217.3.patch, HBASE-5542.D2217.4.patch, HBASE-5542.D2217.5.patch, > HBASE-5542.D2217.6.patch, HBASE-5542.D2217.7.patch, HBASE-5542.D2217.8.patch, > HBASE-5542.D2217.9.patch, HBASE-5542.txt > > > mutateRowsWithLocks() does atomic mutations on multiple rows. > processRow() does atomic read-modify-writes on a single row. > It will be useful to generalize both and have a > processRowsWithLocks() that does atomic read-modify-writes on multiple rows. > This also helps reduce some redundancy in the codes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
[ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234891#comment-13234891 ] Scott Chen commented on HBASE-5542: --- I ran the unit test many times and they passed. I will keep investigating this. But I don't think it is a big issue now. > Unify HRegion.mutateRowsWithLocks() and HRegion.processRow() > > > Key: HBASE-5542 > URL: https://issues.apache.org/jira/browse/HBASE-5542 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5542.2.txt, HBASE-5542.3.txt, > HBASE-5542.D2217.1.patch, HBASE-5542.D2217.10.patch, > HBASE-5542.D2217.11.patch, HBASE-5542.D2217.12.patch, > HBASE-5542.D2217.13.patch, HBASE-5542.D2217.14.patch, > HBASE-5542.D2217.15.patch, HBASE-5542.D2217.2.patch, > HBASE-5542.D2217.3.patch, HBASE-5542.D2217.4.patch, HBASE-5542.D2217.5.patch, > HBASE-5542.D2217.6.patch, HBASE-5542.D2217.7.patch, HBASE-5542.D2217.8.patch, > HBASE-5542.D2217.9.patch, HBASE-5542.txt > > > mutateRowsWithLocks() does atomic mutations on multiple rows. > processRow() does atomic read-modify-writes on a single row. > It will be useful to generalize both and have a > processRowsWithLocks() that does atomic read-modify-writes on multiple rows. > This also helps reduce some redundancy in the codes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
[ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234873#comment-13234873 ] Scott Chen commented on HBASE-5542: --- Sorry for the trouble. I will fix this right now. > Unify HRegion.mutateRowsWithLocks() and HRegion.processRow() > > > Key: HBASE-5542 > URL: https://issues.apache.org/jira/browse/HBASE-5542 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5542.2.txt, HBASE-5542.3.txt, > HBASE-5542.D2217.1.patch, HBASE-5542.D2217.10.patch, > HBASE-5542.D2217.11.patch, HBASE-5542.D2217.12.patch, > HBASE-5542.D2217.13.patch, HBASE-5542.D2217.14.patch, > HBASE-5542.D2217.15.patch, HBASE-5542.D2217.2.patch, > HBASE-5542.D2217.3.patch, HBASE-5542.D2217.4.patch, HBASE-5542.D2217.5.patch, > HBASE-5542.D2217.6.patch, HBASE-5542.D2217.7.patch, HBASE-5542.D2217.8.patch, > HBASE-5542.D2217.9.patch, HBASE-5542.txt > > > mutateRowsWithLocks() does atomic mutations on multiple rows. > processRow() does atomic read-modify-writes on a single row. > It will be useful to generalize both and have a > processRowsWithLocks() that does atomic read-modify-writes on multiple rows. > This also helps reduce some redundancy in the codes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
[ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228989#comment-13228989 ] Scott Chen commented on HBASE-5542: --- @Ted: I manually upload the patch HBASE-5542.txt. I have verified the patch applies to the svn checkout. > Unify HRegion.mutateRowsWithLocks() and HRegion.processRow() > > > Key: HBASE-5542 > URL: https://issues.apache.org/jira/browse/HBASE-5542 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5542.D2217.1.patch, HBASE-5542.D2217.10.patch, > HBASE-5542.D2217.11.patch, HBASE-5542.D2217.12.patch, > HBASE-5542.D2217.13.patch, HBASE-5542.D2217.14.patch, > HBASE-5542.D2217.2.patch, HBASE-5542.D2217.3.patch, HBASE-5542.D2217.4.patch, > HBASE-5542.D2217.5.patch, HBASE-5542.D2217.6.patch, HBASE-5542.D2217.7.patch, > HBASE-5542.D2217.8.patch, HBASE-5542.D2217.9.patch, HBASE-5542.txt > > > mutateRowsWithLocks() does atomic mutations on multiple rows. > processRow() does atomic read-modify-writes on a single row. > It will be useful to generalize both and have a > processRowsWithLocks() that does atomic read-modify-writes on multiple rows. > This also helps reduce some redundancy in the codes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
[
https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226474#comment-13226474
]
Scott Chen commented on HBASE-5542:
---
@Lars: It seems to me that the major difference in doMiniBatchPut is that it
gets the locks with non-block option and process the locked rows. It remembers
a index of processed row and keeps continuing.
How about making MultiRowProcessor having an atomic option?
{code}
interface MultiRowProcessor {
boolean isAtomic();
Collection rowsToLock();
// need to tell processor which rows to process in the non-atomic mode
process(Collection rowsLocked);
}
{code}
In HRegion, we check if the processor is atomic.
If it is not, we get as many lock as possible and process them in a loop.
{code}
HRegion.processRowsWithLocks(MultiRowProcessor processor) {
while (done) {
if (processor.isAtomic()) {
// get all locks with blocking option
} else {
// get as many locks with non-blocking option
}
processor.process(lockedRows);
if (/*we process all the rows*/) {
done = true;
}
}
}
{code}
What do you think?
> Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
>
>
> Key: HBASE-5542
> URL: https://issues.apache.org/jira/browse/HBASE-5542
> Project: HBase
> Issue Type: Improvement
>Reporter: Scott Chen
>Assignee: Scott Chen
> Fix For: 0.96.0
>
> Attachments: HBASE-5542.D2217.1.patch, HBASE-5542.D2217.2.patch,
> HBASE-5542.D2217.3.patch
>
>
> mutateRowsWithLocks() does atomic mutations on multiple rows.
> processRow() does atomic read-modify-writes on a single row.
> It will be useful to generalize both and have a
> processRowsWithLocks() that does atomic read-modify-writes on multiple rows.
> This also helps reduce some redundancy in the codes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
[ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226387#comment-13226387 ] Scott Chen commented on HBASE-5542: --- @Stack: Thanks for the review! We will get this done :) > Unify HRegion.mutateRowsWithLocks() and HRegion.processRow() > > > Key: HBASE-5542 > URL: https://issues.apache.org/jira/browse/HBASE-5542 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5542.D2217.1.patch, HBASE-5542.D2217.2.patch > > > mutateRowsWithLocks() does atomic mutations on multiple rows. > processRow() does atomic read-modify-writes on a single row. > It will be useful to generalize both and have a > processRowsWithLocks() that does atomic read-modify-writes on multiple rows. > This also helps reduce some redundancy in the codes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
[ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226386#comment-13226386 ] Scott Chen commented on HBASE-5542: --- @Ted: Thanks for the help. I will rebase this one right away. @Lars: I just see your work in HBASE-5541. That's pretty nice. I will double check with it to make sure I am also doing the right thing in this one. Thanks! > Unify HRegion.mutateRowsWithLocks() and HRegion.processRow() > > > Key: HBASE-5542 > URL: https://issues.apache.org/jira/browse/HBASE-5542 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5542.D2217.1.patch, HBASE-5542.D2217.2.patch > > > mutateRowsWithLocks() does atomic mutations on multiple rows. > processRow() does atomic read-modify-writes on a single row. > It will be useful to generalize both and have a > processRowsWithLocks() that does atomic read-modify-writes on multiple rows. > This also helps reduce some redundancy in the codes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5515) Add a processRow API that supports atomic multiple reads and writes on a row
[ https://issues.apache.org/jira/browse/HBASE-5515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225921#comment-13225921 ] Scott Chen commented on HBASE-5515: --- @Lars: Yes, 0.96 sounds good to me. > Add a processRow API that supports atomic multiple reads and writes on a row > > > Key: HBASE-5515 > URL: https://issues.apache.org/jira/browse/HBASE-5515 > Project: HBase > Issue Type: New Feature >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5515.D2067.1.patch, HBASE-5515.D2067.10.patch, > HBASE-5515.D2067.11.patch, HBASE-5515.D2067.12.patch, > HBASE-5515.D2067.13.patch, HBASE-5515.D2067.14.patch, > HBASE-5515.D2067.15.patch, HBASE-5515.D2067.16.patch, > HBASE-5515.D2067.17.patch, HBASE-5515.D2067.18.patch, > HBASE-5515.D2067.19.patch, HBASE-5515.D2067.2.patch, > HBASE-5515.D2067.20.patch, HBASE-5515.D2067.21.patch, > HBASE-5515.D2067.22.patch, HBASE-5515.D2067.3.patch, > HBASE-5515.D2067.4.patch, HBASE-5515.D2067.5.patch, HBASE-5515.D2067.6.patch, > HBASE-5515.D2067.7.patch, HBASE-5515.D2067.8.patch, HBASE-5515.D2067.9.patch > > > We have modified HRegion.java internally to do some atomic row processing. It > will be nice to have a plugable API for this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507) ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222798#comment-13222798 ] Scott Chen commented on HBASE-5507: --- Ted: Yes. I will make a patch and upload here. Thanks! > ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not > use ByteBuffer correctly > - > > Key: HBASE-5507 > URL: https://issues.apache.org/jira/browse/HBASE-5507 > Project: HBase > Issue Type: Bug > Components: thrift >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0 > > Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, > HBASE-5507.D2073.3.patch > > > We observed that when with "framed transport" option. The thrift call > ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter > (some garbage string attached to the beginning). This may be a thrift bug > requires further investigation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5508) Add an option to allow test output to show on the terminal
[ https://issues.apache.org/jira/browse/HBASE-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221154#comment-13221154 ] Scott Chen commented on HBASE-5508: --- Lars and Stack: Thanks for the review. Ted: Thanks for integrating this. > Add an option to allow test output to show on the terminal > -- > > Key: HBASE-5508 > URL: https://issues.apache.org/jira/browse/HBASE-5508 > Project: HBase > Issue Type: Improvement > Components: test >Reporter: Scott Chen >Assignee: Scott Chen >Priority: Minor > Fix For: 0.96.0 > > Attachments: HBASE-5508.D2037.1.patch > > > Sometimes it is useful to directly see the test results on the terminal. > We can add a property to achieve that. > mvn test -Dtest.output.tofile=false -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
[
https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221150#comment-13221150
]
Scott Chen commented on HBASE-5506:
---
Ted:
Yes, that's the bug.
The parameter should be
{code}
tableA,rowA,99\x0
{code}
But we are seeing some string attach to it and this is causing the failure
{code}
\x80\x01\x00\x01\x00\x00\x00\x0DgetRegionInfo\x00\x00\x00\x12\x0B\x00\x01\x00\x00\x00\x1AtableA,rowA,99\x0
{code}
Thanks for the review Ted, Stack and Dhruba!
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
>Reporter: Scott Chen
>Assignee: Scott Chen
>Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch,
> HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives
> corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507) ThriftServerRunner.HbaseHandler.getRegionInfo() gets error for the case of (framed, compact) = (true, false)
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220713#comment-13220713 ] Scott Chen commented on HBASE-5507: --- I also created a thrift JIRA https://issues.apache.org/jira/browse/THRIFT-1531 > ThriftServerRunner.HbaseHandler.getRegionInfo() gets error for the case of > (framed, compact) = (true, false) > > > Key: HBASE-5507 > URL: https://issues.apache.org/jira/browse/HBASE-5507 > Project: HBase > Issue Type: Bug > Components: thrift >Reporter: Scott Chen >Assignee: Scott Chen > > We observed that when with "framed transport" option. The thrift call > ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter > (some garbage string attached to the beginning). This may be a thrift bug > requires further investigation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5441) HRegionThriftServer may not start because of a race-condition
[ https://issues.apache.org/jira/browse/HBASE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219647#comment-13219647 ] Scott Chen commented on HBASE-5441: --- Thanks for the review and commit, Ted. > HRegionThriftServer may not start because of a race-condition > - > > Key: HBASE-5441 > URL: https://issues.apache.org/jira/browse/HBASE-5441 > Project: HBase > Issue Type: Bug > Components: thrift >Reporter: Scott Chen >Assignee: Scott Chen >Priority: Minor > Attachments: 5441-v5.txt, HBASE-5441.D1845.1.patch, > HBASE-5441.D1845.2.patch, HBASE-5441.D1857.2.patch, HBASE-5441.D1857.3.patch, > HBASE-5441.D1857.4.patch > > > This happens because the master is not started when ThriftServerRunner tries > to create an HBaseAdmin. > org.apache.hadoop.ipc.RemoteException: > org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not > running yet > at > org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1333) > at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:899) > at > org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:150) > at $Proxy8.getProtocolVersion(Unknown Source) > at > org.apache.hadoop.hbase.ipc.WritableRpcEngine.getProxy(WritableRpcEngine.java:183) > at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:303) > at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:280) > at org.apache.hadoop.hbase.ipc.HBaseRPC.getProxy(HBaseRPC.java:332) > at > org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:649) > at > org.apache.hadoop.hbase.client.HBaseAdmin.(HBaseAdmin.java:108) > at > org.apache.hadoop.hbase.thrift.ThriftServerRunner$HBaseHandler.(ThriftServerRunner.java:516) > at > org.apache.hadoop.hbase.regionserver.HRegionThriftServer$HBaseHandlerRegion.(HRegionThriftServer.java:104) > at > org.apache.hadoop.hbase.regionserver.HRegionThriftServer.(HRegionThriftServer.java:74) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658) > at java.lang.Thread.run(Thread.java:662) > 2012-02-21 16:38:18,223 INFO org.apache.hadoop.hba -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5437) HRegionThriftServer does not start because of a bug in HbaseHandlerMetricsProxy
[ https://issues.apache.org/jira/browse/HBASE-5437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214271#comment-13214271 ] Scott Chen commented on HBASE-5437: --- @Zhihong: Thanks. I posted the wrong patch. I will upload the patch soon. Sorry for the confusion. > HRegionThriftServer does not start because of a bug in > HbaseHandlerMetricsProxy > --- > > Key: HBASE-5437 > URL: https://issues.apache.org/jira/browse/HBASE-5437 > Project: HBase > Issue Type: Bug > Components: metrics, thrift >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0 > > Attachments: HBASE-5437.D1857.1.patch > > > 3.facebook.com,60020,1329865516120: Initialization of RS failed. Hence > aborting RS. > java.lang.ClassCastException: $Proxy9 cannot be cast to > org.apache.hadoop.hbase.thrift.generated.Hbase$Iface > at > org.apache.hadoop.hbase.thrift.HbaseHandlerMetricsProxy.newInstance(HbaseHandlerMetricsProxy.java:47) > at > org.apache.hadoop.hbase.thrift.ThriftServerRunner.(ThriftServerRunner.java:239) > at > org.apache.hadoop.hbase.regionserver.HRegionThriftServer.(HRegionThriftServer.java:74) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.initializeThreads(HRegionServer.java:646) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:546) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:658) > at java.lang.Thread.run(Thread.java:662) > 2012-02-21 15:05:18,749 FATAL org.apache.hadoop.h -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5186) Add metrics to ThriftServer
[ https://issues.apache.org/jira/browse/HBASE-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199558#comment-13199558 ] Scott Chen commented on HBASE-5186: --- Ted: Thanks for the review on this patch. That helped a lot. > Add metrics to ThriftServer > --- > > Key: HBASE-5186 > URL: https://issues.apache.org/jira/browse/HBASE-5186 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0 > > Attachments: 5186-v10.txt, 5186-v11.txt, 5186-v12.txt, 5186-v9.txt, > HBASE-5186.D1461.1.patch, HBASE-5186.D1461.2.patch, HBASE-5186.D1461.3.patch, > HBASE-5186.D1461.4.patch, HBASE-5186.D1461.5.patch, HBASE-5186.D1461.6.patch, > HBASE-5186.D1461.7.patch, HBASE-5186.D1461.8.patch > > > It will be useful to have some metrics (queue length, waiting time, > processing time ...) similar to Hadoop RPC server. This allows us to monitor > system health also provide a tool to diagnose the problem where thrift calls > are slow. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5186) Add metrics to ThriftServer
[ https://issues.apache.org/jira/browse/HBASE-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196027#comment-13196027 ] Scott Chen commented on HBASE-5186: --- I have opened HBASE-5298 for thrift2 metrics. > Add metrics to ThriftServer > --- > > Key: HBASE-5186 > URL: https://issues.apache.org/jira/browse/HBASE-5186 > Project: HBase > Issue Type: Improvement >Reporter: Scott Chen >Assignee: Scott Chen > Attachments: HBASE-5186.D1461.1.patch, HBASE-5186.D1461.2.patch, > HBASE-5186.D1461.3.patch, HBASE-5186.D1461.4.patch, HBASE-5186.D1461.5.patch > > > It will be useful to have some metrics (queue length, waiting time, > processing time ...) similar to Hadoop RPC server. This allows us to monitor > system health also provide a tool to diagnose the problem where thrift calls > are slow. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5297) Update metrics numOpenConnections and callQueueLen directly in HBaseServer
[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195401#comment-13195401 ] Scott Chen commented on HBASE-5297: --- Zhihong: Thanks for pointing this out. I will fix the problem. > Update metrics numOpenConnections and callQueueLen directly in HBaseServer > -- > > Key: HBASE-5297 > URL: https://issues.apache.org/jira/browse/HBASE-5297 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: Scott Chen >Assignee: Scott Chen >Priority: Minor > Attachments: HBASE-5297.D1509.1.patch > > > It's better to directly update the metrics outside HBaseRpcMetrics so that > HBaseRpcMetrics doesn't have to hold reference to HBaseServer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5246) Regenerate codes with thrift 0.8.0
[
https://issues.apache.org/jira/browse/HBASE-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190568#comment-13190568
]
Scott Chen commented on HBASE-5246:
---
All codes are auto-generated.
Here is what I did
{code}
thrift --gen java -o /tmp/generated
./src/main/resources/org/apache/hadoop/hbase/thrift/hbase.thrift
thrift --gen java -o /tmp/generated
./src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
rm ./src/main/java/org/apache/hadoop/hbase/thrift/generated/*
rm ./src/main/java/org/apache/hadoop/hbase/thrift2/generated/*
cp -r /tmp/generated/gen-java/ src/main/java
{code}
> Regenerate codes with thrift 0.8.0
> --
>
> Key: HBASE-5246
> URL: https://issues.apache.org/jira/browse/HBASE-5246
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Reporter: Scott Chen
>Assignee: Scott Chen
>Priority: Minor
> Attachments: HBASE-5246.D1371.1.patch
>
>
> In HBASE-5201, We have upgrated libthrift.jar to 0.8.0.
> The source codes generated from "*.thrift" should be upgraded also.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5201) Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer
[ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188445#comment-13188445 ] Scott Chen commented on HBASE-5201: --- Added one more config to the release note. > Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and > HRegionThriftServer > - > > Key: HBASE-5201 > URL: https://issues.apache.org/jira/browse/HBASE-5201 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0 > > Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, > HBASE-5201.txt > > > TThreadedSelectorServer is good for RPC-heavy situation because IO are not > limited to one CPU. See > https://issues.apache.org/jira/browse/Thrift-1167 > I am porting the related classes form thrift trunk (it is not there in > thrift-0.7.0). > There are lots of repeat codes in ThriftServer and HRegionThriftServer. > These codes are now moved to a Runnable called ThriftServerRunner. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5201) Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and HRegionThriftServer
[ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188102#comment-13188102 ] Scott Chen commented on HBASE-5201: --- Thanks for the help Zhihong. I will add the documentation soon. > Utilize TThreadedSelectorServer and remove redundant code in ThriftServer and > HRegionThriftServer > - > > Key: HBASE-5201 > URL: https://issues.apache.org/jira/browse/HBASE-5201 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0 > > Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201-v4.txt, > HBASE-5201.txt > > > TThreadedSelectorServer is good for RPC-heavy situation because IO are not > limited to one CPU. See > https://issues.apache.org/jira/browse/Thrift-1167 > I am porting the related classes form thrift trunk (it is not there in > thrift-0.7.0). > There are lots of repeat codes in ThriftServer and HRegionThriftServer. > These codes are now moved to a Runnable called ThriftServerRunner. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
[ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186551#comment-13186551 ] Scott Chen commented on HBASE-5201: --- @Ted: Thanks. I will do "Submit Patch". > Add TThreadedSelectorServer and remove repeat codes in ThriftServer and > HRegionThriftServer > --- > > Key: HBASE-5201 > URL: https://issues.apache.org/jira/browse/HBASE-5201 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0 > > Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201.txt > > > TThreadedSelectorServer is good for RPC-heavy situation because IO are not > limited to one CPU. See > https://issues.apache.org/jira/browse/Thrift-1167 > I am porting the related classes form thrift trunk (it is not there in > thrift-0.7.0). > There are lots of repeat codes in ThriftServer and HRegionThriftServer. > These codes are now moved to a Runnable called ThriftServerRunner. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
[ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186460#comment-13186460 ] Scott Chen commented on HBASE-5201: --- Thanks, Dhruba! > Add TThreadedSelectorServer and remove repeat codes in ThriftServer and > HRegionThriftServer > --- > > Key: HBASE-5201 > URL: https://issues.apache.org/jira/browse/HBASE-5201 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0 > > Attachments: HBASE-5201-v2.txt, HBASE-5201-v3.txt, HBASE-5201.txt > > > TThreadedSelectorServer is good for RPC-heavy situation because IO are not > limited to one CPU. See > https://issues.apache.org/jira/browse/Thrift-1167 > I am porting the related classes form thrift trunk (it is not there in > thrift-0.7.0). > There are lots of repeat codes in ThriftServer and HRegionThriftServer. > These codes are now moved to a Runnable called ThriftServerRunner. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
[ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186384#comment-13186384 ] Scott Chen commented on HBASE-5201: --- Zhihong: Here is the phabricator link: https://reviews.facebook.net/D1257 > Add TThreadedSelectorServer and remove repeat codes in ThriftServer and > HRegionThriftServer > --- > > Key: HBASE-5201 > URL: https://issues.apache.org/jira/browse/HBASE-5201 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0 > > Attachments: HBASE-5201-v2.txt, HBASE-5201.txt > > > TThreadedSelectorServer is good for RPC-heavy situation because IO are not > limited to one CPU. See > https://issues.apache.org/jira/browse/Thrift-1167 > I am porting the related classes form thrift trunk (it is not there in > thrift-0.7.0). > There are lots of repeat codes in ThriftServer and HRegionThriftServer. > These codes are now moved to a Runnable called ThriftServerRunner. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
[
https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186377#comment-13186377
]
Scott Chen commented on HBASE-5201:
---
Yeah. I am trying to do that. I am n00b to this.
Got some error saying cannot find .arc_jira_lib.
Do you happend to know how to solve this problem?
{code}
$arc diff
Usage Exception: Failed to load library "arclib" at location ".arc_jira_lib".
Please check the "phutil_libraries" setting in your .arcconfig file. Refer to
page http://phabricator.com/docs/arcanist/article/Setting_Up_.arcconfig.html
for more info.
{code}
> Add TThreadedSelectorServer and remove repeat codes in ThriftServer and
> HRegionThriftServer
> ---
>
> Key: HBASE-5201
> URL: https://issues.apache.org/jira/browse/HBASE-5201
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Reporter: Scott Chen
>Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5201-v2.txt, HBASE-5201.txt
>
>
> TThreadedSelectorServer is good for RPC-heavy situation because IO are not
> limited to one CPU. See
> https://issues.apache.org/jira/browse/Thrift-1167
> I am porting the related classes form thrift trunk (it is not there in
> thrift-0.7.0).
> There are lots of repeat codes in ThriftServer and HRegionThriftServer.
> These codes are now moved to a Runnable called ThriftServerRunner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
[ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186371#comment-13186371 ] Scott Chen commented on HBASE-5201: --- Cool. I will use 0.8.0 instead. That is better. > Add TThreadedSelectorServer and remove repeat codes in ThriftServer and > HRegionThriftServer > --- > > Key: HBASE-5201 > URL: https://issues.apache.org/jira/browse/HBASE-5201 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0 > > Attachments: HBASE-5201.txt > > > TThreadedSelectorServer is good for RPC-heavy situation because IO are not > limited to one CPU. See > https://issues.apache.org/jira/browse/Thrift-1167 > I am porting the related classes form thrift trunk (it is not there in > thrift-0.7.0). > There are lots of repeat codes in ThriftServer and HRegionThriftServer. > These codes are now moved to a Runnable called ThriftServerRunner. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5201) Add TThreadedSelectorServer and remove repeat codes in ThriftServer and HRegionThriftServer
[ https://issues.apache.org/jira/browse/HBASE-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186363#comment-13186363 ] Scott Chen commented on HBASE-5201: --- TThreadedSelectorServer is available in thrift-0.8.0. I am not sure about the policy of upgrading thrift in this project. So I just ported the source codes from thrift trunk. > Add TThreadedSelectorServer and remove repeat codes in ThriftServer and > HRegionThriftServer > --- > > Key: HBASE-5201 > URL: https://issues.apache.org/jira/browse/HBASE-5201 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Scott Chen >Assignee: Scott Chen > Fix For: 0.94.0 > > Attachments: HBASE-5201.txt > > > TThreadedSelectorServer is good for RPC-heavy situation because IO are not > limited to one CPU. See > https://issues.apache.org/jira/browse/Thrift-1167 > I am porting the related classes form thrift trunk (it is not there in > thrift-0.7.0). > There are lots of repeat codes in ThriftServer and HRegionThriftServer. > These codes are now moved to a Runnable called ThriftServerRunner. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5182) TBoundedThreadPoolServer threadKeepAliveTimeSec is not configured properly
[ https://issues.apache.org/jira/browse/HBASE-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184485#comment-13184485 ] Scott Chen commented on HBASE-5182: --- Wow. That's super fast. Thanks, Zhihong :) > TBoundedThreadPoolServer threadKeepAliveTimeSec is not configured properly > -- > > Key: HBASE-5182 > URL: https://issues.apache.org/jira/browse/HBASE-5182 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Scott Chen >Assignee: Scott Chen >Priority: Minor > Fix For: 0.94.0 > > Attachments: hbase-5182.txt > > > TBoundedThreadPoolServer does not take the configured threadKeepAliveTimeSec. > It uses the default value instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
