[jira] [Updated] (HBASE-14166) Per-Region metrics can be stale
[ https://issues.apache.org/jira/browse/HBASE-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-14166: - Description: # We're seeing some machines that are reporting only old region metrics. It seems like at some point the Hadoop metrics system decided which metrics to display and which not to. From then on it was not changing. (was: We're seeing some machines that are reporting only old region metrics. It seems like at some point the Hadoop metrics system decided which metrics to display and which not to. From then on it was not changing.) > Per-Region metrics can be stale > --- > > Key: HBASE-14166 > URL: https://issues.apache.org/jira/browse/HBASE-14166 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 1.1.0.1 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14166.patch, HBASE-14166-v1.patch, > HBASE-14166-v2.patch, HBASE-14166-v3.patch, HBASE-14166-v4.patch, > HBASE-14166-v5.patch > > > # We're seeing some machines that are reporting only old region metrics. It > seems like at some point the Hadoop metrics system decided which metrics to > display and which not to. From then on it was not changing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144673#comment-16144673
]
Shibin Zhang commented on HBASE-18568:
--
thanks for the review ,[~tedyu] [~carp84]
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can not put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18568:
-
Description:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can not put or remove the object correctly.
it will be better like this :
{code:java}
hashCode = regionWrapper.getRegionHashCode();
agg.register(this);
{code}
was:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can put or remove the object correctly.
it will be better like this :
{code:java}
hashCode = regionWrapper.getRegionHashCode();
agg.register(this);
{code}
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can not put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144658#comment-16144658
]
Shibin Zhang commented on HBASE-18568:
--
[~ted_yu] It looks like a concurrency problem.After the change,it works well
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18568) Correct Regions metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144629#comment-16144629
]
Shibin Zhang edited comment on HBASE-18568 at 8/29/17 1:25 AM:
---
[~tedyu] [~carp84] Is this a problem ?
was (Author: zhangshibin):
[~tedyu]Is this a problem ?
> Correct Regions metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18568) Correct Regions metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144629#comment-16144629
]
Shibin Zhang commented on HBASE-18568:
--
[~tedyu]Is this a problem ?
> Correct Regions metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18701) Optimize reference guide to use cell acl conveniently
[ https://issues.apache.org/jira/browse/HBASE-18701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-18701: - Attachment: HBASE-18701.patch > Optimize reference guide to use cell acl conveniently > - > > Key: HBASE-18701 > URL: https://issues.apache.org/jira/browse/HBASE-18701 > Project: HBase > Issue Type: Improvement >Reporter: Shibin Zhang >Priority: Trivial > Attachments: HBASE-18701.patch > > > When i use cell acl,i found it didn't work ,and without related settings > explain in hbase reference guide. After i read the code , i found we need to > change two option value in hbase-site.xml.It is user unfriendly to use cell > acl function.So, i think we need to explain how to enable this function in > reference guide. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18701) Optimize reference guide to use cell acl conveniently
Shibin Zhang created HBASE-18701: Summary: Optimize reference guide to use cell acl conveniently Key: HBASE-18701 URL: https://issues.apache.org/jira/browse/HBASE-18701 Project: HBase Issue Type: Improvement Reporter: Shibin Zhang Priority: Trivial When i use cell acl,i found it didn't work ,and without related settings explain in hbase reference guide. After i read the code , i found we need to change two option value in hbase-site.xml.It is user unfriendly to use cell acl function.So, i think we need to explain how to enable this function in reference guide. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18568) Correct Regions metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18568:
-
Attachment: HBASE-18568-V1.patch
> Correct Regions metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18568) Correct Regions metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18568:
-
Description:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can put or remove the object correctly.
it will be better like this :
{code:java}
hashCode = regionWrapper.getRegionHashCode();
agg.register(this);
{code}
was:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
{code:java}
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code}
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can put or remove the object correctly.
it will be better like this :
{code:java}
hashCode = regionWrapper.getRegionHashCode();
agg.register(this);
{code}
> Correct Regions metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18568) Correct Regions metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18568:
-
Description:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
{code:java}
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code}
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can put or remove the object correctly.
it will be better like this :
{code:java}
hashCode = regionWrapper.getRegionHashCode();
agg.register(this);
{code}
was:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can put or remove the object correctly.
it will be better like this :
{code:java}
hashCode = regionWrapper.getRegionHashCode();
agg.register(this);
{code}
> Correct Regions metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> {code:java}
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code}
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18568) Correct Regions metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18568:
-
Description:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can put or remove the object correctly.
it will be better like this :
{code:java}
hashCode = regionWrapper.getRegionHashCode();
agg.register(this);
{code}
was:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can put or remove the object correctly.
it will be better like this :
{code:java}
hashCode = regionWrapper.getRegionHashCode();
...
agg.register(this);
{code}
> Correct Regions metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18568) Correct Regions metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18568:
-
Description:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can put or remove the object correctly.
it will be better like this :
{code:java}
hashCode = regionWrapper.getRegionHashCode();
...
agg.register(this);
{code}
was:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can put or remove the object correctly.
it will be better to move
{code:java}
hashCode = regionWrapper.getRegionHashCode();
{code}
above
{code:java}
agg.register(this);
{code}
> Correct Regions metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> ...
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-18568) Correct Regions metric of numRegions
Shibin Zhang created HBASE-18568:
Summary: Correct Regions metric of numRegions
Key: HBASE-18568
URL: https://issues.apache.org/jira/browse/HBASE-18568
Project: HBase
Issue Type: Bug
Components: metrics
Affects Versions: 3.0.0
Reporter: Shibin Zhang
Assignee: Shibin Zhang
Priority: Critical
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can put or remove the object correctly.
it will be better to move
{code:java}
hashCode = regionWrapper.getRegionHashCode();
{code}
above
{code:java}
agg.register(this);
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18469) Correct RegionServer metric of totalRequestCount
[ https://issues.apache.org/jira/browse/HBASE-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106726#comment-16106726 ] Shibin Zhang commented on HBASE-18469: -- [~abhishek.chouhan] the totalRequestCount of a RegionServer should be large than the sum of readRequestcount and writeRequestcount > Correct RegionServer metric of totalRequestCount > -- > > Key: HBASE-18469 > URL: https://issues.apache.org/jira/browse/HBASE-18469 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0 >Reporter: Shibin Zhang >Priority: Critical > > when i get the metric ,i found this three metric may be have some error as > follow : > "totalRequestCount" : 17541, > "readRequestCount" : 17483, > "writeRequestCount" : 1633, -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18469) Correct RegionServer metric of totalRequestCount
[ https://issues.apache.org/jira/browse/HBASE-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-18469: - Priority: Critical (was: Minor) > Correct RegionServer metric of totalRequestCount > -- > > Key: HBASE-18469 > URL: https://issues.apache.org/jira/browse/HBASE-18469 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0 >Reporter: Shibin Zhang >Priority: Critical > > when i get the metric ,i found this three metric may be have some error as > follow : > "totalRequestCount" : 17541, > "readRequestCount" : 17483, > "writeRequestCount" : 1633, -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18469) Correct RegionServer metric of totalRequestCount
Shibin Zhang created HBASE-18469: Summary: Correct RegionServer metric of totalRequestCount Key: HBASE-18469 URL: https://issues.apache.org/jira/browse/HBASE-18469 Project: HBase Issue Type: Bug Affects Versions: 1.2.0 Reporter: Shibin Zhang Priority: Minor when i get the metric ,i found this three metric may be have some error as follow : "totalRequestCount" : 17541, "readRequestCount" : 17483, "writeRequestCount" : 1633, -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099384#comment-16099384
]
Shibin Zhang commented on HBASE-18323:
--
[~elserj] thanks for codereview , here attach a new one
https://issues.apache.org/jira/secure/attachment/12878728/HBASE-18323-V5.patch
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch, HBASE-18323-V4.patch, HBASE-18323-V5.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18323:
-
Attachment: HBASE-18323-V5.patch
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch, HBASE-18323-V4.patch, HBASE-18323-V5.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097136#comment-16097136 ] Shibin Zhang edited comment on HBASE-17822 at 7/22/17 6:51 AM: --- yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way to get badrows ? was (Author: zhangshibin): [~stack] yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way to get badrows ? > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097136#comment-16097136 ] Shibin Zhang edited comment on HBASE-17822 at 7/22/17 6:50 AM: --- [~stack] yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way to get badrows ? was (Author: zhangshibin): [~stackoverflowindia1] yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way to get badrows ? > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097136#comment-16097136 ] Shibin Zhang edited comment on HBASE-17822 at 7/22/17 6:49 AM: --- [~stackoverflowindia1] yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way to get badrows ? was (Author: zhangshibin): stack yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way to get badrows ? > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097136#comment-16097136 ] Shibin Zhang edited comment on HBASE-17822 at 7/22/17 6:49 AM: --- stack yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way to get badrows ? was (Author: zhangshibin): yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way get badrows ? > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097136#comment-16097136 ] Shibin Zhang edited comment on HBASE-17822 at 7/22/17 6:48 AM: --- [~stacke] yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way get badrows ? was (Author: zhangshibin): [~rms332] yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way get badrows ? > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097136#comment-16097136 ] Shibin Zhang edited comment on HBASE-17822 at 7/22/17 6:47 AM: --- [~bstack] yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way get badrows ? was (Author: zhangshibin): @stack yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way get badrows ? > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097136#comment-16097136 ] Shibin Zhang edited comment on HBASE-17822 at 7/22/17 6:48 AM: --- yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way get badrows ? was (Author: zhangshibin): [~stacke] yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way get badrows ? > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097136#comment-16097136 ] Shibin Zhang edited comment on HBASE-17822 at 7/22/17 6:47 AM: --- [~rms332] yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way get badrows ? was (Author: zhangshibin): [~bstack] yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way get badrows ? > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097136#comment-16097136 ] Shibin Zhang commented on HBASE-17822: -- @stack yeah,the default behavior is that you said,should we provide a more convenient way and user friendly way get badrows ? > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097105#comment-16097105
]
Shibin Zhang commented on HBASE-18323:
--
[~elserj] thanks for your advice and review , i also submit a patch with test
https://issues.apache.org/jira/secure/attachment/12878450/HBASE-18323-V4.patch
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch, HBASE-18323-V4.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18323:
-
Attachment: HBASE-18323-V4.patch
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch, HBASE-18323-V4.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095738#comment-16095738
]
Shibin Zhang edited comment on HBASE-18323 at 7/21/17 3:58 AM:
---
[~elserj] sorry to feedback so late, could you help me codereview , how about
this way :
{code:java}
String hbaseUser = null;
try {
hbaseUser =
UserGroupInformation.getCurrentUser().getShortUserName();
} catch (IOException e) {
LOG.warn("Current Service User could not get.", e);
}
if (superUsers != null) {
List groups = new ArrayList<>();
for (String user : superUsers) {
if (AuthUtil.isGroupPrincipal(user)) {
// TODO: Set node ACL for groups when ZK supports this feature
groups.add(user);
} else {
if(!user.equals(hbaseUser)) {
acls.add(new ACL(Perms.ALL, new Id("sasl", user)));
}
}
}
if (!groups.isEmpty()) {
LOG.warn("Znode ACL setting for group " + groups
+ " is skipped, ZooKeeper doesn't support this feature
presently.");
}
}
{code}
was (Author: zhangshibin):
{code:java}
[~elserj] sorry to feedback so late, could you help me codereview , how about
this way :
{code:java}
String hbaseUser = null;
{color:#d04437} try {
hbaseUser =
UserGroupInformation.getCurrentUser().getShortUserName();
} catch (IOException e) {
LOG.warn("Current Service User could not get.", e);
}{color}
if (superUsers != null) {
List groups = new ArrayList<>();
for (String user : superUsers) {
if (AuthUtil.isGroupPrincipal(user)) {
// TODO: Set node ACL for groups when ZK supports this feature
groups.add(user);
} else {
{color:#d04437} if(!user.equals(hbaseUser)) {
acls.add(new ACL(Perms.ALL, new Id("sasl", user)));
}{color}
}
}
if (!groups.isEmpty()) {
LOG.warn("Znode ACL setting for group " + groups
+ " is skipped, ZooKeeper doesn't support this feature
presently.");
}
}
{code}
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095738#comment-16095738
]
Shibin Zhang edited comment on HBASE-18323 at 7/21/17 3:58 AM:
---
[~elserj] sorry to feedback so late, could you help me codereview , how about
this way :
{code:java}
String hbaseUser = null;
try {
hbaseUser =
UserGroupInformation.getCurrentUser().getShortUserName();
} catch (IOException e) {
LOG.warn("Current Service User could not get.", e);
}
if (superUsers != null) {
List groups = new ArrayList<>();
for (String user : superUsers) {
if (AuthUtil.isGroupPrincipal(user)) {
// TODO: Set node ACL for groups when ZK supports this feature
groups.add(user);
} else {
if(!user.equals(hbaseUser)) {
acls.add(new ACL(Perms.ALL, new Id("sasl", user)));
}
}
}
if (!groups.isEmpty()) {
LOG.warn("Znode ACL setting for group " + groups
+ " is skipped, ZooKeeper doesn't support this feature
presently.");
}
}
{code}
was (Author: zhangshibin):
[~elserj] sorry to feedback so late, could you help me codereview , how about
this way :
{code:java}
String hbaseUser = null;
try {
hbaseUser =
UserGroupInformation.getCurrentUser().getShortUserName();
} catch (IOException e) {
LOG.warn("Current Service User could not get.", e);
}
if (superUsers != null) {
List groups = new ArrayList<>();
for (String user : superUsers) {
if (AuthUtil.isGroupPrincipal(user)) {
// TODO: Set node ACL for groups when ZK supports this feature
groups.add(user);
} else {
if(!user.equals(hbaseUser)) {
acls.add(new ACL(Perms.ALL, new Id("sasl", user)));
}
}
}
if (!groups.isEmpty()) {
LOG.warn("Znode ACL setting for group " + groups
+ " is skipped, ZooKeeper doesn't support this feature
presently.");
}
}
{code}
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095738#comment-16095738
]
Shibin Zhang edited comment on HBASE-18323 at 7/21/17 3:57 AM:
---
{code:java}
[~elserj] sorry to feedback so late, could you help me codereview , how about
this way :
{code:java}
String hbaseUser = null;
{color:#d04437} try {
hbaseUser =
UserGroupInformation.getCurrentUser().getShortUserName();
} catch (IOException e) {
LOG.warn("Current Service User could not get.", e);
}{color}
if (superUsers != null) {
List groups = new ArrayList<>();
for (String user : superUsers) {
if (AuthUtil.isGroupPrincipal(user)) {
// TODO: Set node ACL for groups when ZK supports this feature
groups.add(user);
} else {
{color:#d04437} if(!user.equals(hbaseUser)) {
acls.add(new ACL(Perms.ALL, new Id("sasl", user)));
}{color}
}
}
if (!groups.isEmpty()) {
LOG.warn("Znode ACL setting for group " + groups
+ " is skipped, ZooKeeper doesn't support this feature
presently.");
}
}
{code}
was (Author: zhangshibin):
[~elserj] sorry to feedback so late, could you help me codereview , how about
this way :
String hbaseUser = null;
{color:#d04437} try {
hbaseUser =
UserGroupInformation.getCurrentUser().getShortUserName();
} catch (IOException e) {
LOG.warn("Current Service User could not get.", e);
}{color}
if (superUsers != null) {
List groups = new ArrayList<>();
for (String user : superUsers) {
if (AuthUtil.isGroupPrincipal(user)) {
// TODO: Set node ACL for groups when ZK supports this feature
groups.add(user);
} else {
{color:#d04437} if(!user.equals(hbaseUser)) {
acls.add(new ACL(Perms.ALL, new Id("sasl", user)));
}{color}
}
}
if (!groups.isEmpty(){color:#d04437}colored text{color}) {
LOG.warn("Znode ACL setting for group " + groups
+ " is skipped, ZooKeeper doesn't support this feature
presently.");
}
}
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095738#comment-16095738
]
Shibin Zhang commented on HBASE-18323:
--
[~elserj] sorry to feedback so late, could you help me codereview , how about
this way :
String hbaseUser = null;
{color:#d04437} try {
hbaseUser =
UserGroupInformation.getCurrentUser().getShortUserName();
} catch (IOException e) {
LOG.warn("Current Service User could not get.", e);
}{color}
if (superUsers != null) {
List groups = new ArrayList<>();
for (String user : superUsers) {
if (AuthUtil.isGroupPrincipal(user)) {
// TODO: Set node ACL for groups when ZK supports this feature
groups.add(user);
} else {
{color:#d04437} if(!user.equals(hbaseUser)) {
acls.add(new ACL(Perms.ALL, new Id("sasl", user)));
}{color}
}
}
if (!groups.isEmpty(){color:#d04437}colored text{color}) {
LOG.warn("Znode ACL setting for group " + groups
+ " is skipped, ZooKeeper doesn't support this feature
presently.");
}
}
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078960#comment-16078960
]
Shibin Zhang edited comment on HBASE-18323 at 7/8/17 5:34 AM:
--
[~elserj] " always use CREATOR_ALL_ACL, just avoid setting the explicit
ACL for the same user"
sorry , i don't know what's your meaning in above ,how to
avoid setting ?
" we definitely need some unit test additions for this
change "
could you give me some advice? what kind of unit test for
change? some logic maybe confused me.
was (Author: zhangshibin):
[~elserj] " always use CREATOR_ALL_ACL, just avoid setting the explicit
ACL for the same user"
sorry , i don't know what's your meaning in above ,how to avoid
setting ?
" we definitely need some unit test additions for this
change "
could you give me some advice? what kind of unit test for change?
some logic maybe confused me.
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078960#comment-16078960
]
Shibin Zhang commented on HBASE-18323:
--
[~elserj] " always use CREATOR_ALL_ACL, just avoid setting the explicit
ACL for the same user"
sorry , i don't know what's your meaning in above ,how to avoid
setting ?
" we definitely need some unit test additions for this
change "
could you give me some advice? what kind of unit test for change?
some logic maybe confused to me.
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078960#comment-16078960
]
Shibin Zhang edited comment on HBASE-18323 at 7/8/17 5:33 AM:
--
[~elserj] " always use CREATOR_ALL_ACL, just avoid setting the explicit
ACL for the same user"
sorry , i don't know what's your meaning in above ,how to avoid
setting ?
" we definitely need some unit test additions for this
change "
could you give me some advice? what kind of unit test for change?
some logic maybe confused me.
was (Author: zhangshibin):
[~elserj] " always use CREATOR_ALL_ACL, just avoid setting the explicit
ACL for the same user"
sorry , i don't know what's your meaning in above ,how to avoid
setting ?
" we definitely need some unit test additions for this
change "
could you give me some advice? what kind of unit test for change?
some logic maybe confused to me.
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077523#comment-16077523
]
Shibin Zhang commented on HBASE-18323:
--
[~elserj] how about this way in ZKUtil.createAcl :
String[] superUsers =
zkw.getConfiguration().getStrings(Superusers.SUPERUSER_CONF_KEY);
String hbaseUser =
UserGroupInformation.getCurrentUser().getShortUserName();
if(!ArrayUtils.contains(superUsers,hbaseUser)){
acls.addAll(Ids.CREATOR_ALL_ACL);
}
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076124#comment-16076124
]
Shibin Zhang commented on HBASE-18323:
--
attach for new one ,sorry to attach a whitespace
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18323:
-
Attachment: HBASE-18323-V3.patch
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch,
> HBASE-18323-V3.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18323:
-
Attachment: HBASE-18323-V2.patch
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch, HBASE-18323-V2.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075887#comment-16075887
]
Shibin Zhang commented on HBASE-18323:
--
[~elserj] hi, why we use Ids.CREATOR_ALL_ACL ? maybe ,it's reasonable for
user to set the servcie user the same as superuser.
If we set the service user not the same as superuser , this service user may
be add to znode acl
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18323:
-
Affects Version/s: 1.2.0
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18323:
-
Priority: Minor (was: Critical)
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.0, 3.0.0
>Reporter: Shibin Zhang
>Priority: Minor
> Attachments: HBASE-18323.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
[
https://issues.apache.org/jira/browse/HBASE-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18323:
-
Attachment: HBASE-18323.patch
> Remove multiple ACLs for the same user in kerberos
> --
>
> Key: HBASE-18323
> URL: https://issues.apache.org/jira/browse/HBASE-18323
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18323.patch
>
>
> When deploy hbase in kerberos way ,there will be multiple acls in znode :
> 'world,'anyone
> : r
> 'sasl,'hbase
> : cdrwa
> 'sasl,'hbase
> : cdrwa
> I also see the related issue and apply the patch, like
> https://issues.apache.org/jira/browse/HBASE-17717
> but in my environment ,this situation still appear,
> After dig into the code , i found the reason in source code ZKUtil.createAcl
> is
> if (zkw.isClientReadable(node)) {
> LOG.error("isSecureZooKeeper user: clientReadable");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> acls.addAll(Ids.READ_ACL_UNSAFE);
> } else {
> LOG.error("isSecureZooKeeper user: clientReadable no");
> acls.addAll(Ids.CREATOR_ALL_ACL);
> }
> acls.addAll(Ids.CREATOR_ALL_ACL);
>
> Id AUTH_IDS = new Id("auth", "");
> ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
> ACL(31, AUTH_IDS)));
> AUTH_IDS with "auth " will result current connection auth user add to
> znode acl ,
> so it will appear multiple acls for same users.
> I think this line of code we can remove :
> acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-18323) Remove multiple ACLs for the same user in kerberos
Shibin Zhang created HBASE-18323:
Summary: Remove multiple ACLs for the same user in kerberos
Key: HBASE-18323
URL: https://issues.apache.org/jira/browse/HBASE-18323
Project: HBase
Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Shibin Zhang
Priority: Critical
When deploy hbase in kerberos way ,there will be multiple acls in znode :
'world,'anyone
: r
'sasl,'hbase
: cdrwa
'sasl,'hbase
: cdrwa
I also see the related issue and apply the patch, like
https://issues.apache.org/jira/browse/HBASE-17717
but in my environment ,this situation still appear,
After dig into the code , i found the reason in source code ZKUtil.createAcl
is
if (zkw.isClientReadable(node)) {
LOG.error("isSecureZooKeeper user: clientReadable");
acls.addAll(Ids.CREATOR_ALL_ACL);
acls.addAll(Ids.READ_ACL_UNSAFE);
} else {
LOG.error("isSecureZooKeeper user: clientReadable no");
acls.addAll(Ids.CREATOR_ALL_ACL);
}
acls.addAll(Ids.CREATOR_ALL_ACL);
Id AUTH_IDS = new Id("auth", "");
ArrayList CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new
ACL(31, AUTH_IDS)));
AUTH_IDS with "auth " will result current connection auth user add to
znode acl ,
so it will appear multiple acls for same users.
I think this line of code we can remove : acls.addAll(Ids.CREATOR_ALL_ACL);
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070964#comment-16070964 ] Shibin Zhang edited comment on HBASE-17822 at 7/3/17 6:58 AM: -- [~stack] the first version patch based on master i already submit . may be there's a lot of limitations in patch, please give me some advice. https://issues.apache.org/jira/secure/attachment/12875358/HBASE-17822-V1.patch was (Author: zhangshibin): [~stack] the first version patch based on master i already submit . may be there's a lot of limitations in patch, please give me some advice. > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070964#comment-16070964 ] Shibin Zhang commented on HBASE-17822: -- [~stack] the first version patch based on master i already submit . may be there's a lot of limitations in patch, please give me some advice. > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-17822: - Attachment: HBASE-17822-V1.patch > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch, HBASE-17822-V1.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-17822: - Attachment: 2017-06-30_110915.png 2017-06-30_110905.png > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: 2017-06-30_110905.png, 2017-06-30_110915.png, > HBASE-17822-master.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17822) Set maxBadRows and outputDirectory option for VerifyReplication
[ https://issues.apache.org/jira/browse/HBASE-17822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069405#comment-16069405 ] Shibin Zhang commented on HBASE-17822: -- [~stack] i add two option outputDir and maxBadRows.The outputDir set the mapreduce output files,the maxBadRows to limit max bad rows to print like this: hbase org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication --outputfile=/tmp --maxbadrows=5 1 tt the result in hdfs cat the output, in attatch picture but in my later code ,i change the outputDir default value to "/hbase-$verify" > Set maxBadRows and outputDirectory option for VerifyReplication > > > Key: HBASE-17822 > URL: https://issues.apache.org/jira/browse/HBASE-17822 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Shibin Zhang >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-17822-master.patch > > > Currently,this tool will print too many rowkey as badrows if source and peer > table have many inconsistent row.So,it is necessay to set maxBadRows to print. > Also,look for badrows rowkey is inconvenient in MR job log .It might be > useful to set a reduce to aggregate badrowkeys which will be print in MR job > output file. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15577) there need be a mechanism to enable ZK's ACL check when the authentication strategy is simple
[
https://issues.apache.org/jira/browse/HBASE-15577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068043#comment-16068043
]
Shibin Zhang commented on HBASE-15577:
--
Is this patch available?
> there need be a mechanism to enable ZK's ACL check when the authentication
> strategy is simple
> -
>
> Key: HBASE-15577
> URL: https://issues.apache.org/jira/browse/HBASE-15577
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.1.3
>Reporter: chenxu
>Assignee: chenxu
> Attachments: HBASE-15577-02.patch, HBASE-15577-03.patch,
> HBASE-15577.patch, zk-set-acl.patch
>
>
> if the hbase.security.authentication is set to simple, the ZKUtil.createACL
> just return Ids.OPEN_ACL_UNSAFE, means that there is no ACL check on the ZK's
> node.
> we can refactoring this to enables the ACL's check function
> manual steps to verify the patch
> *1.set this property in the hbase-site.xml*
> {quote}
>hbase.security.authentication(simple)
>hbase.zookeeper.acl (digest:admin:0DPiKuNIrrVmD8IUCuw1hQxNqZc=:cdrwa)
>hbase.zookeeper.auth(digest:admin)
> {quote}
> the digest can generate by the
> DigestAuthenticationProvider.generateDigest("admin")
> *2.start the cluster*
> *3.verify the zk's node*
> {quote}
>(1)getAcl /hbase, result is:
>'digest,'admin:0DPiKuNIrrVmD8IUCuw1hQxNqZc= : cdrwa
>'world,'anyone: r
>(2)getAcl /hbase/table-lock, result is:
>'digest,'admin:0DPiKuNIrrVmD8IUCuw1hQxNqZc= : cdrwa
> {quote}
> if the node is below, all the client can read the node, but only the
> server(Regionserver & Master which has the auth info) can modify it
> {quote}
> /hbase
> /hbase/meta-region-server
> /hbase/master
> /hbase/hbaseid
> /hbase/rs
> /hbase/table
> /hbase/table/$tableName
> {quote}
> otherwise, only the server can read and modify the node, the Client can't see
> them
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18265) Correct the link unuseful in regionServer's region state UI
[ https://issues.apache.org/jira/browse/HBASE-18265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-18265: - Attachment: HBASE-18265.patch > Correct the link unuseful in regionServer's region state UI > --- > > Key: HBASE-18265 > URL: https://issues.apache.org/jira/browse/HBASE-18265 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0 >Reporter: Shibin Zhang >Priority: Trivial > Attachments: HBASE-18265.patch > > > when i watch for region state ,i found this link maybe update in > regionserver's region state UI > IP:60030/rs-status is in RegionListTmpl.jamon > See http://hbase.org";>HBase Home for further explication. > http://hbase.org is unuseful , should update to http://hbase.apache.org -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18265) Correct the link unuseful in regionServer's region state UI
[ https://issues.apache.org/jira/browse/HBASE-18265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-18265: - Assignee: Shibin Zhang Status: Patch Available (was: Open) > Correct the link unuseful in regionServer's region state UI > --- > > Key: HBASE-18265 > URL: https://issues.apache.org/jira/browse/HBASE-18265 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0 >Reporter: Shibin Zhang >Assignee: Shibin Zhang >Priority: Trivial > Attachments: HBASE-18265.patch > > > when i watch for region state ,i found this link maybe update in > regionserver's region state UI > IP:60030/rs-status is in RegionListTmpl.jamon > See http://hbase.org";>HBase Home for further explication. > http://hbase.org is unuseful , should update to http://hbase.apache.org -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18265) Correct the link unuseful in regionServer's region state UI
Shibin Zhang created HBASE-18265: Summary: Correct the link unuseful in regionServer's region state UI Key: HBASE-18265 URL: https://issues.apache.org/jira/browse/HBASE-18265 Project: HBase Issue Type: Bug Components: UI Affects Versions: 3.0.0 Reporter: Shibin Zhang Priority: Trivial when i watch for region state ,i found this link maybe update in regionserver's region state UI IP:60030/rs-status is in RegionListTmpl.jamon See http://hbase.org";>HBase Home for further explication. http://hbase.org is unuseful , should update to http://hbase.apache.org -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18263) Resolve NPE in backup Master UI when access to procedures.jsp
[ https://issues.apache.org/jira/browse/HBASE-18263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061865#comment-16061865 ] Shibin Zhang edited comment on HBASE-18263 at 6/24/17 8:46 AM: --- [~te...@apache.org] ,it may be unrelated with my patch ,could you help me see why https://builds.apache.org/job/PreCommit-HBASE-Build/7311/testReport/ Failed to read test report file /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed.xml org.dom4j.DocumentException: Error on line 167 of document file:///home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed.xml : XML document structures must start and end within the same entity. Nested exception: XML document structures must start and end within the same entity. was (Author: zhangshibin): Ted Yu ,it may be unrelated with my patch ,could you help me see why https://builds.apache.org/job/PreCommit-HBASE-Build/7311/testReport/ Failed to read test report file /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed.xml org.dom4j.DocumentException: Error on line 167 of document file:///home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed.xml : XML document structures must start and end within the same entity. Nested exception: XML document structures must start and end within the same entity. > Resolve NPE in backup Master UI when access to procedures.jsp > - > > Key: HBASE-18263 > URL: https://issues.apache.org/jira/browse/HBASE-18263 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 1.2.0, 2.0.0-alpha-1 >Reporter: Shibin Zhang >Priority: Trivial > Attachments: HBASE-18263.patch > > > When accessing procedures.jsp ,the NPE comes in backup master UI: > HTTP ERROR 500 > Problem accessing /procedures.jsp. Reason: > INTERNAL_SERVER_ERROR > Caused by: > java.lang.NullPointerException > at > org.apache.hadoop.hbase.generated.master.procedures_jsp._jspService(procedures_jsp.java:67) > at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) > at > org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221) > at > org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:113) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1354) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399) > In server ,only the active master initialize procedureStore in HMaster. > so ,i think it will be better to remove procedures.jsp link in backup Master > UI -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18263) Resolve NPE in backup Master UI when access to procedures.jsp
[ https://issues.apache.org/jira/browse/HBASE-18263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061865#comment-16061865 ] Shibin Zhang commented on HBASE-18263: -- Ted Yu ,it may be unrelated with my patch ,could you help me see why https://builds.apache.org/job/PreCommit-HBASE-Build/7311/testReport/ Failed to read test report file /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed.xml org.dom4j.DocumentException: Error on line 167 of document file:///home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/hbase-server/target/surefire-reports/TEST-org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed.xml : XML document structures must start and end within the same entity. Nested exception: XML document structures must start and end within the same entity. > Resolve NPE in backup Master UI when access to procedures.jsp > - > > Key: HBASE-18263 > URL: https://issues.apache.org/jira/browse/HBASE-18263 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 1.2.0, 2.0.0-alpha-1 >Reporter: Shibin Zhang >Priority: Trivial > Attachments: HBASE-18263.patch > > > When accessing procedures.jsp ,the NPE comes in backup master UI: > HTTP ERROR 500 > Problem accessing /procedures.jsp. Reason: > INTERNAL_SERVER_ERROR > Caused by: > java.lang.NullPointerException > at > org.apache.hadoop.hbase.generated.master.procedures_jsp._jspService(procedures_jsp.java:67) > at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) > at > org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221) > at > org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:113) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1354) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399) > In server ,only the active master initialize procedureStore in HMaster. > so ,i think it will be better to remove procedures.jsp link in backup Master > UI -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18263) Resolve NPE in backup Master UI when access to procedures.jsp
[ https://issues.apache.org/jira/browse/HBASE-18263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-18263: - Status: Patch Available (was: Open) > Resolve NPE in backup Master UI when access to procedures.jsp > - > > Key: HBASE-18263 > URL: https://issues.apache.org/jira/browse/HBASE-18263 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 2.0.0-alpha-1, 1.2.0 >Reporter: Shibin Zhang >Priority: Trivial > Attachments: HBASE-18263.patch > > > When accessing procedures.jsp ,the NPE comes in backup master UI: > HTTP ERROR 500 > Problem accessing /procedures.jsp. Reason: > INTERNAL_SERVER_ERROR > Caused by: > java.lang.NullPointerException > at > org.apache.hadoop.hbase.generated.master.procedures_jsp._jspService(procedures_jsp.java:67) > at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) > at > org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221) > at > org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:113) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1354) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399) > In server ,only the active master initialize procedureStore in HMaster. > so ,i think it will be better to remove procedures.jsp link in backup Master > UI -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18263) Resolve NPE in backup Master UI when access to procedures.jsp
[ https://issues.apache.org/jira/browse/HBASE-18263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-18263: - Attachment: HBASE-18263.patch > Resolve NPE in backup Master UI when access to procedures.jsp > - > > Key: HBASE-18263 > URL: https://issues.apache.org/jira/browse/HBASE-18263 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 1.2.0, 2.0.0-alpha-1 >Reporter: Shibin Zhang >Priority: Trivial > Attachments: HBASE-18263.patch > > > When accessing procedures.jsp ,the NPE comes in backup master UI: > HTTP ERROR 500 > Problem accessing /procedures.jsp. Reason: > INTERNAL_SERVER_ERROR > Caused by: > java.lang.NullPointerException > at > org.apache.hadoop.hbase.generated.master.procedures_jsp._jspService(procedures_jsp.java:67) > at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) > at > org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221) > at > org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:113) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1354) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) > at > org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) > at > org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399) > In server ,only the active master initialize procedureStore in HMaster. > so ,i think it will be better to remove procedures.jsp link in backup Master > UI -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18263) Resolve NPE in backup Master UI when access to procedures.jsp
Shibin Zhang created HBASE-18263: Summary: Resolve NPE in backup Master UI when access to procedures.jsp Key: HBASE-18263 URL: https://issues.apache.org/jira/browse/HBASE-18263 Project: HBase Issue Type: Bug Components: UI Affects Versions: 2.0.0-alpha-1, 1.2.0 Reporter: Shibin Zhang Priority: Trivial When accessing procedures.jsp ,the NPE comes in backup master UI: HTTP ERROR 500 Problem accessing /procedures.jsp. Reason: INTERNAL_SERVER_ERROR Caused by: java.lang.NullPointerException at org.apache.hadoop.hbase.generated.master.procedures_jsp._jspService(procedures_jsp.java:67) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221) at org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:113) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1354) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399) In server ,only the active master initialize procedureStore in HMaster. so ,i think it will be better to remove procedures.jsp link in backup Master UI -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17982) Is the word "occured" should be "occurred ?
[ https://issues.apache.org/jira/browse/HBASE-17982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-17982: - Component/s: hbase > Is the word "occured" should be "occurred ? > - > > Key: HBASE-17982 > URL: https://issues.apache.org/jira/browse/HBASE-17982 > Project: HBase > Issue Type: Bug > Components: hbase >Affects Versions: 2.0.0 >Reporter: Shibin Zhang >Priority: Trivial > Fix For: 2.0.0 > > Attachments: 2017-05-02_141956.png, HBASE-17982.patch > > > I have find some spelling may have a problem -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17982) Is the word "occured" should be "occurred ?
[ https://issues.apache.org/jira/browse/HBASE-17982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-17982: - Attachment: HBASE-17982.patch > Is the word "occured" should be "occurred ? > - > > Key: HBASE-17982 > URL: https://issues.apache.org/jira/browse/HBASE-17982 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Shibin Zhang >Priority: Trivial > Fix For: 2.0.0 > > Attachments: 2017-05-02_141956.png, HBASE-17982.patch > > > I have find some spelling may have a problem -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17982) Is the word "occured" should be "occurred ?
[ https://issues.apache.org/jira/browse/HBASE-17982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-17982: - Fix Version/s: 2.0.0 > Is the word "occured" should be "occurred ? > - > > Key: HBASE-17982 > URL: https://issues.apache.org/jira/browse/HBASE-17982 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Shibin Zhang >Priority: Trivial > Fix For: 2.0.0 > > Attachments: 2017-05-02_141956.png > > > I have find some spelling may have a problem -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17982) Is the word "occured" should be "occurred ?
[ https://issues.apache.org/jira/browse/HBASE-17982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-17982: - Affects Version/s: 2.0.0 > Is the word "occured" should be "occurred ? > - > > Key: HBASE-17982 > URL: https://issues.apache.org/jira/browse/HBASE-17982 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Shibin Zhang >Priority: Trivial > Fix For: 2.0.0 > > Attachments: 2017-05-02_141956.png > > > I have find some spelling may have a problem -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17982) Is the word "occured" should be "occurred ?
[ https://issues.apache.org/jira/browse/HBASE-17982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-17982: - Attachment: 2017-05-02_141956.png > Is the word "occured" should be "occurred ? > - > > Key: HBASE-17982 > URL: https://issues.apache.org/jira/browse/HBASE-17982 > Project: HBase > Issue Type: Bug >Reporter: Shibin Zhang >Priority: Trivial > Attachments: 2017-05-02_141956.png > > > I have find some spelling may have a problem -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (HBASE-17982) Is the word "occured" should be "occurred ?
Shibin Zhang created HBASE-17982: Summary: Is the word "occured" should be "occurred ? Key: HBASE-17982 URL: https://issues.apache.org/jira/browse/HBASE-17982 Project: HBase Issue Type: Bug Reporter: Shibin Zhang Priority: Trivial I have find some spelling may have a problem -- This message was sent by Atlassian JIRA (v6.3.15#6346)
