[jira] [Commented] (HBASE-5577) improve 'patch submission' section in HBase book
[ https://issues.apache.org/jira/browse/HBASE-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240052#comment-13240052 ] Sujee Maniyam commented on HBASE-5577: -- hmm, looks like build system is trying to apply this 'patch' against trunk. should I have pasted the doc-changes, in the comment section? > improve 'patch submission' section in HBase book > > > Key: HBASE-5577 > URL: https://issues.apache.org/jira/browse/HBASE-5577 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Sujee Maniyam >Assignee: Sujee Maniyam > Labels: documentation > Attachments: HBASE-5577-v1.txt, HBASE-5577-v2.txt > > > Improve patch section in the book > http://hbase.apache.org/book/submitting.patches.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4440) add an option to presplit table to PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184329#comment-13184329 ] Sujee Maniyam commented on HBASE-4440: -- sounds good. I will submit a patch. couple of newbie logistical questions: 1) should I create a new patch against the trunk? the original patch is already committed in trunk / 0.94. 2) do I leave old patch attachments in the JIRA or should I delete them (to reduce clutter) thanks JD > add an option to presplit table to PerformanceEvaluation > > > Key: HBASE-4440 > URL: https://issues.apache.org/jira/browse/HBASE-4440 > Project: HBase > Issue Type: Improvement > Components: util >Reporter: Sujee Maniyam >Assignee: Sujee Maniyam >Priority: Minor > Labels: benchmark > Fix For: 0.94.0 > > Attachments: PerformanceEvaluation.java, > PerformanceEvaluation_HBASE_4440.patch, > PerformanceEvaluation_HBASE_4440_2.patch > > > PerformanceEvaluation a quick way to 'benchmark' a HBase cluster. The > current 'write*' operations do not pre-split the table. Pre splitting the > table will really boost the insert performance. > It would be nice to have an option to enable pre-splitting table before the > inserts begin. > it would look something like: > (a) hbase ...PerformanceEvaluation --presplit=10 > (b) hbase ...PerformanceEvaluation --presplit > (b) will try to presplit the table on some default value (say number of > region servers) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4440) add an option to presplit table to PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184309#comment-13184309 ] Sujee Maniyam commented on HBASE-4440: -- I see. looks good. If the table exists, and presplit option is supplied, it will have no effect. It might mislead the user in believing the pre-split option took effect, while in fact it didn't. may be a WARN would suffice to notify the user? > add an option to presplit table to PerformanceEvaluation > > > Key: HBASE-4440 > URL: https://issues.apache.org/jira/browse/HBASE-4440 > Project: HBase > Issue Type: Improvement > Components: util >Reporter: Sujee Maniyam >Assignee: Sujee Maniyam >Priority: Minor > Labels: benchmark > Fix For: 0.94.0 > > Attachments: PerformanceEvaluation.java, > PerformanceEvaluation_HBASE_4440.patch, > PerformanceEvaluation_HBASE_4440_2.patch > > > PerformanceEvaluation a quick way to 'benchmark' a HBase cluster. The > current 'write*' operations do not pre-split the table. Pre splitting the > table will really boost the insert performance. > It would be nice to have an option to enable pre-splitting table before the > inserts begin. > it would look something like: > (a) hbase ...PerformanceEvaluation --presplit=10 > (b) hbase ...PerformanceEvaluation --presplit > (b) will try to presplit the table on some default value (say number of > region servers) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4440) add an option to presplit table to PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184284#comment-13184284 ] Sujee Maniyam commented on HBASE-4440: -- so you are proposing that 1) whether we use presplit option or not, table has to be recreated for all write-mode tests. This changes the behavior for all write-tests. Currently table is only created if it doesn't exist. 2) or pre-split should try to split the table without re-creating it. > add an option to presplit table to PerformanceEvaluation > > > Key: HBASE-4440 > URL: https://issues.apache.org/jira/browse/HBASE-4440 > Project: HBase > Issue Type: Improvement > Components: util >Reporter: Sujee Maniyam >Assignee: Sujee Maniyam >Priority: Minor > Labels: benchmark > Fix For: 0.94.0 > > Attachments: PerformanceEvaluation.java, > PerformanceEvaluation_HBASE_4440.patch, > PerformanceEvaluation_HBASE_4440_2.patch > > > PerformanceEvaluation a quick way to 'benchmark' a HBase cluster. The > current 'write*' operations do not pre-split the table. Pre splitting the > table will really boost the insert performance. > It would be nice to have an option to enable pre-splitting table before the > inserts begin. > it would look something like: > (a) hbase ...PerformanceEvaluation --presplit=10 > (b) hbase ...PerformanceEvaluation --presplit > (b) will try to presplit the table on some default value (say number of > region servers) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4440) add an option to presplit table to PerformanceEvaluation
[ https://issues.apache.org/jira/browse/HBASE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183805#comment-13183805 ] Sujee Maniyam commented on HBASE-4440: -- @JD --presplit drops and re-creates the table with splits. is this what you mean? > add an option to presplit table to PerformanceEvaluation > > > Key: HBASE-4440 > URL: https://issues.apache.org/jira/browse/HBASE-4440 > Project: HBase > Issue Type: Improvement > Components: util >Reporter: Sujee Maniyam >Assignee: Sujee Maniyam >Priority: Minor > Labels: benchmark > Fix For: 0.94.0 > > Attachments: PerformanceEvaluation.java, > PerformanceEvaluation_HBASE_4440.patch, > PerformanceEvaluation_HBASE_4440_2.patch > > > PerformanceEvaluation a quick way to 'benchmark' a HBase cluster. The > current 'write*' operations do not pre-split the table. Pre splitting the > table will really boost the insert performance. > It would be nice to have an option to enable pre-splitting table before the > inserts begin. > it would look something like: > (a) hbase ...PerformanceEvaluation --presplit=10 > (b) hbase ...PerformanceEvaluation --presplit > (b) will try to presplit the table on some default value (say number of > region servers) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
