[jira] [Commented] (HBASE-5694) getRowsWithColumnsTs() in Thrift service handles timestamps incorrectly

2012-04-02 Thread Wouter Bolsterlee (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244704#comment-13244704
 ] 

Wouter Bolsterlee commented on HBASE-5694:
--

I seriously doubt that my patch causes these test failures. From a quick glance 
I see no Thrift code at all in the stack traces of the failed tests...

> getRowsWithColumnsTs() in Thrift service handles timestamps incorrectly
> ---
>
> Key: HBASE-5694
> URL: https://issues.apache.org/jira/browse/HBASE-5694
> Project: HBase
>  Issue Type: Bug
>  Components: thrift
>Affects Versions: 0.92.1
>Reporter: Wouter Bolsterlee
> Fix For: 0.94.0
>
> Attachments: HBASE-5694-trunk-20120402.patch, HBASE-5694.patch
>
>
> The getRowsWithColumnsTs() method in the Thrift interface only applies the 
> timestamp if columns are explicitly specified. However, this method also 
> allows for columns to be unspecified (this is even used internally to 
> implement e.g. getRows()). The cause of the bug is a minor scoping issue: the 
> time range is set inside a wrong if statement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5694) getRowsWithColumnsTs function Thrift service incorrectly handles time range

2012-04-01 Thread Wouter Bolsterlee (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243873#comment-13243873
 ] 

Wouter Bolsterlee commented on HBASE-5694:
--

For some reason, JIRA doesn't accept my patch file in the upload dialog. Here 
it is:


--- ThriftServer.java.orig  2012-04-01 23:41:16.881172406 +0200
+++ ThriftServer.java   2012-04-01 23:41:30.177238337 +0200
@@ -477,8 +477,8 @@
 get.addColumn(famAndQf[0], famAndQf[1]);
   }
 }
-get.setTimeRange(Long.MIN_VALUE, timestamp);
   }
+  get.setTimeRange(Long.MIN_VALUE, timestamp);
   gets.add(get);
 }
 Result[] result = table.get(gets);


> getRowsWithColumnsTs function Thrift service incorrectly handles time range
> ---
>
> Key: HBASE-5694
> URL: https://issues.apache.org/jira/browse/HBASE-5694
> Project: HBase
>  Issue Type: Bug
>  Components: thrift
>Affects Versions: 0.92.1
>Reporter: Wouter Bolsterlee
> Fix For: 0.92.2
>
>
> The getRowsWithColumnsTs() method in the Thrift interface only applies the 
> timestamp if columns are explicitly specified. However, this method also 
> allows for columns to be unspecified (this is even used internally to 
> implement e.g. getRows()). The cause of the bug is a minor scoping issue: the 
> time range is set inside a wrong if statement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira