[jira] [Commented] (HBASE-7826) Improve Hbase Thrift v1 to return results in sorted order

[Wouter Bolsterlee (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-7826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752792#comment-13752792
 ] 

Wouter Bolsterlee commented on HBASE-7826:
--

Is it really safe to convert a previously required field to an optional one? 
Parsers using the old definition file might unconditionally expect the field 
when handling input generated using the newer definitions.

 Improve Hbase Thrift v1 to return results in sorted order
 -

 Key: HBASE-7826
 URL: https://issues.apache.org/jira/browse/HBASE-7826
 Project: HBase
  Issue Type: New Feature
  Components: Thrift
Affects Versions: 0.94.0
Reporter: Shivendra Pratap Singh
Assignee: Shivendra Pratap Singh
Priority: Minor
  Labels: Hbase, Thrift
 Fix For: 0.98.0, 0.95.2, 0.94.11

 Attachments: 7826-v6.patch, HBASE-7826-0.94-v7.patch, 
 hbase_7826.patch, hbase_7826.patch, HBASE-7826.patch, 
 hbase_7826_sortcolumnFlag.1.patch, hbase_7826_sortcolumnFlag.2.patch, 
 hbase_7826_sortcolumnFlag.3.patch, hbase_7826_sortcolumnFlag.4.patch, 
 hbase_7826_sortcolumnFlag.5.patch, hbase_7826_sortcolumnFlag.patch, 
 hbase_7826_trunk.patch


 Hbase natively stores columns sorted based on the column qualifier. A scan is 
 guaranteed to return sorted columns. The Java API works fine but the Thrift 
 API is broken. Hbase uses TreeMap that ensures that sort order is maintained. 
 However Hbase thrift specification uses a simple Map to store the data. A 
 map, since it is unordered doesn't result in columns being returned in a sort 
 order that is consistent with their storage in Hbase.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5694) getRowsWithColumnsTs() in Thrift service handles timestamps incorrectly

[Wouter Bolsterlee (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13584386#comment-13584386
 ] 

Wouter Bolsterlee commented on HBASE-5694:
--

Guido, I think this patch has never made it into 0.92.x series, only to trunk 
at the time of committing (ended up in 0.94+ I think), so your observation that 
this bug is still present in 0.92.1 is correct.

 getRowsWithColumnsTs() in Thrift service handles timestamps incorrectly
 ---

 Key: HBASE-5694
 URL: https://issues.apache.org/jira/browse/HBASE-5694
 Project: HBase
  Issue Type: Bug
  Components: Thrift
Affects Versions: 0.92.1
Reporter: Wouter Bolsterlee
 Fix For: 0.94.0

 Attachments: HBASE-5694.patch, HBASE-5694-trunk-20120402.patch


 The getRowsWithColumnsTs() method in the Thrift interface only applies the 
 timestamp if columns are explicitly specified. However, this method also 
 allows for columns to be unspecified (this is even used internally to 
 implement e.g. getRows()). The cause of the bug is a minor scoping issue: the 
 time range is set inside a wrong if statement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira