[jira] [Commented] (HBASE-23669) ZNodeClearer#clear() throws IllegalArgumentException
[ https://issues.apache.org/jira/browse/HBASE-23669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469662#comment-17469662 ] kangkang.guo commented on HBASE-23669: -- [~zhangduo] Thanks for the comment, I have opened the PR. > ZNodeClearer#clear() throws IllegalArgumentException > - > > Key: HBASE-23669 > URL: https://issues.apache.org/jira/browse/HBASE-23669 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.5 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Major > Attachments: HBASE-23669.branch-2.1.0001.patch, > HBASE-23669.master.patch > > > Precondition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > In case of master-rs collocation HBASE_ZNODE_FILE is overwritten by > regionserver process in HRegionServer#handleReportForDutyResponse() here is > how it looks on master server: > [hadoop@master-node data]$ cat hbase-hadoop-master.znode > /hbase/rs/master-node,16000,1578371505720 > When ZNodeClearer#clear(), the rsZNode is also splicing with the contents of > the file, causing an exception: > java.lang.IllegalArgumentException: Invalid path string > "/hbase/rs//hbase/rs/master-node,16000,1578371503003" caused by empty node > name specified @10 > at > org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99) > at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:851) > at > org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:166) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1259) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1251) > at org.apache.hadoop.hbase.ZNodeClearer.clear(ZNodeClearer.java:188) > at > org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at > org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) > at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3117) > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (HBASE-25954) When graceful_stop a regionserver, RegionMover always retry to move the regions to other rsgoup's regionservers
[ https://issues.apache.org/jira/browse/HBASE-25954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo reassigned HBASE-25954: Assignee: kangkang.guo > When graceful_stop a regionserver, RegionMover always retry to move the > regions to other rsgoup's regionservers > --- > > Key: HBASE-25954 > URL: https://issues.apache.org/jira/browse/HBASE-25954 > Project: HBase > Issue Type: Bug >Reporter: Zezhen Jia >Assignee: kangkang.guo >Priority: Critical > > [had...@bigdata-hbase-master003.prod.com bin]$ ./graceful_stop.sh > bigdata-hbase-rs105.prod.com 2021-05-28T11:05:06 Disabling load balancer > SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in > [jar:file:/home/hadoop/cloud/hadoop/share/hadoop/common/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: Found binding in > [jar:file:/home/hadoop/cloud/hbase/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: See [http://www.slf4j.org/codes.html#multiple_bindings] for an > explanation. SLF4J: Actual binding is of type > [org.slf4j.impl.Log4jLoggerFactory] 2021-05-28T11:05:12 Previous balancer > state was true 2021-05-28T11:05:12 Unloading bigdata-hbase-rs105.prod.com > region(s) SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found > binding in > [jar:file:/home/hadoop/cloud/hadoop/share/hadoop/common/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: Found binding in > [jar:file:/home/hadoop/cloud/hbase/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: See [http://www.slf4j.org/codes.html#multiple_bindings] for an > explanation. SLF4J: Actual binding is of type > [org.slf4j.impl.Log4jLoggerFactory] 2021-05-28 11:05:13,990 INFO > [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] > zookeeper.ZooKeeper: Client > environment:zookeeper.version=3.4.10-39d3a4f269333c922ed3db283be479f9deacaa0f, > built on 03/23/2017 10:13 GMT 2021-05-28 11:05:13,991 INFO > [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] > zookeeper.ZooKeeper: Client > environment:host.name=bigdata-hbase-master003.prod.com 2021-05-28 > 11:05:13,991 INFO > [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] > zookeeper.ZooKeeper: Client environment:java.version=1.8.0_241 2021-05-28 > 11:05:13,991 INFO > [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] > zookeeper.ZooKeeper: Client environment:java.vendor=Oracle Corporation > 2021-05-28 11:05:13,991 INFO > [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] > zookeeper.ZooKeeper: Client > environment:java.home=/home/hadoop/cloud/jdk1.8.0_241/jre 2021-05-28 > 11:05:13,991 INFO > [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] > zookeeper.ZooKeeper: > adoop/mapreduce/lib/jackson-mapper-asl-1.9.13.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-core-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-2.9.2-tests.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-examples-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-shuffle-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-hs-plugins-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-hs-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-app-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-common-2.9.2.jar:/home/hadoop/cloud/hadoop/contrib/capacity-scheduler/*.jar:/home/hadoop/cloud/hbase/lib/client-facing-thirdparty/slf4j-log
[jira] [Work started] (HBASE-23045) currentPath may be stitched in a loop in replication source code.
[ https://issues.apache.org/jira/browse/HBASE-23045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23045 started by kangkang.guo. > currentPath may be stitched in a loop in replication source code. > -- > > Key: HBASE-23045 > URL: https://issues.apache.org/jira/browse/HBASE-23045 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.2.6.1 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Critical > Fix For: 1.2.6.1 > > Attachments: 0001-fix-ReplicationSource-bug.patch > > > When the openReader encounters a FileNotFoundException, we may go to all > possible directories to find the current hlog. When found, the path may be > wrong, and it is looped together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23045) currentPath may be stitched in a loop in replication source code.
kangkang.guo created HBASE-23045: Summary: currentPath may be stitched in a loop in replication source code. Key: HBASE-23045 URL: https://issues.apache.org/jira/browse/HBASE-23045 Project: HBase Issue Type: Bug Components: Replication Affects Versions: 1.2.6.1 Reporter: kangkang.guo Assignee: kangkang.guo Fix For: 1.2.6.1 Attachments: 0001-fix-ReplicationSource-bug.patch When the openReader encounters a FileNotFoundException, we may go to all possible directories to find the current hlog. When found, the path may be wrong, and it is looped together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23045) currentPath may be stitched in a loop in replication source code.
[ https://issues.apache.org/jira/browse/HBASE-23045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-23045: - Attachment: 0001-fix-ReplicationSource-bug.patch Status: Patch Available (was: In Progress) > currentPath may be stitched in a loop in replication source code. > -- > > Key: HBASE-23045 > URL: https://issues.apache.org/jira/browse/HBASE-23045 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.2.6.1 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Critical > Fix For: 1.2.6.1 > > Attachments: 0001-fix-ReplicationSource-bug.patch, > 0001-fix-ReplicationSource-bug.patch > > > When the openReader encounters a FileNotFoundException, we may go to all > possible directories to find the current hlog. When found, the path may be > wrong, and it is looped together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23045) currentPath may be stitched in a loop in replication source code.
[ https://issues.apache.org/jira/browse/HBASE-23045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-23045: - Attachment: HBASE-23045.branch-1.2.0001.patch > currentPath may be stitched in a loop in replication source code. > -- > > Key: HBASE-23045 > URL: https://issues.apache.org/jira/browse/HBASE-23045 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.2.6.1 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Critical > Fix For: 1.2.6.1 > > Attachments: HBASE-23045.branch-1.2.0001.patch > > > When the openReader encounters a FileNotFoundException, we may go to all > possible directories to find the current hlog. When found, the path may be > wrong, and it is looped together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23045) currentPath may be stitched in a loop in replication source code.
[ https://issues.apache.org/jira/browse/HBASE-23045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-23045: - Attachment: (was: 0001-fix-ReplicationSource-bug.patch) > currentPath may be stitched in a loop in replication source code. > -- > > Key: HBASE-23045 > URL: https://issues.apache.org/jira/browse/HBASE-23045 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.2.6.1 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Critical > Fix For: 1.2.6.1 > > Attachments: HBASE-23045.branch-1.2.0001.patch > > > When the openReader encounters a FileNotFoundException, we may go to all > possible directories to find the current hlog. When found, the path may be > wrong, and it is looped together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23045) currentPath may be stitched in a loop in replication source code.
[ https://issues.apache.org/jira/browse/HBASE-23045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-23045: - Attachment: (was: 0001-fix-ReplicationSource-bug.patch) > currentPath may be stitched in a loop in replication source code. > -- > > Key: HBASE-23045 > URL: https://issues.apache.org/jira/browse/HBASE-23045 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.2.6.1 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Critical > Fix For: 1.2.6.1 > > Attachments: HBASE-23045.branch-1.2.0001.patch > > > When the openReader encounters a FileNotFoundException, we may go to all > possible directories to find the current hlog. When found, the path may be > wrong, and it is looped together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24067) [RSGroup] Error logs appear when the table is created
kangkang.guo created HBASE-24067: Summary: [RSGroup] Error logs appear when the table is created Key: HBASE-24067 URL: https://issues.apache.org/jira/browse/HBASE-24067 Project: HBase Issue Type: Improvement Components: rsgroup Affects Versions: 2.2.4, 2.2.3, 2.1.8, 2.1.7 Reporter: kangkang.guo Assignee: kangkang.guo Will create table assigned to the corresponding rsgroup, appear TableStateNotFoundException: 2020-03-27 15:49:21,959 INFO [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default 2020-03-27 15:49:21,971 ERROR [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] master.TableStateManager: Unable to get table Test:t3 state org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: Test:t3 at org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215) at org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347) at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2043) at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134) at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2026) at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:659) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) 2020-03-27 15:49:21,971 INFO [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] rsgroup.RSGroupAdminServer: Moving region(s) for table Test:t3 to RSGroup default 2020-03-27 15:49:21,972 INFO [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] master.MasterRpcServices: Client=hbase//**.**.**.** procedure request for creating table: namespace: "Test" qualifier: "t3" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24067) [RSGroup] Error logs appear when the table is created
[ https://issues.apache.org/jira/browse/HBASE-24067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-24067: - Description: Will create table assigned to the corresponding rsgroup, appear TableStateNotFoundException. This doesn't seem to cause any problems, but I think it's best to avoid error logs like this was: Will create table assigned to the corresponding rsgroup, appear TableStateNotFoundException: 2020-03-27 15:49:21,959 INFO [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default 2020-03-27 15:49:21,971 ERROR [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] master.TableStateManager: Unable to get table Test:t3 state org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: Test:t3 at org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215) at org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347) at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2043) at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134) at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2026) at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:659) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) 2020-03-27 15:49:21,971 INFO [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] rsgroup.RSGroupAdminServer: Moving region(s) for table Test:t3 to RSGroup default 2020-03-27 15:49:21,972 INFO [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] master.MasterRpcServices: Client=hbase//**.**.**.** procedure request for creating table: namespace: "Test" qualifier: "t3" > [RSGroup] Error logs appear when the table is created > - > > Key: HBASE-24067 > URL: https://issues.apache.org/jira/browse/HBASE-24067 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.1.7, 2.1.8, 2.2.3, 2.2.4 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Minor > > Will create table assigned to the corresponding rsgroup, appear > TableStateNotFoundException. > This doesn't seem to cause any problems, but I think it's best to avoid error > logs like this -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24067) [RSGroup] Error logs appear when the table is created
[ https://issues.apache.org/jira/browse/HBASE-24067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-24067: - Attachment: 99FB1BA0-701B-11EA-8BFA-0BB11286B49120200327_S.jpg > [RSGroup] Error logs appear when the table is created > - > > Key: HBASE-24067 > URL: https://issues.apache.org/jira/browse/HBASE-24067 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.1.7, 2.1.8, 2.2.3, 2.2.4 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Minor > Attachments: 99FB1BA0-701B-11EA-8BFA-0BB11286B49120200327_S.jpg > > > Will create table assigned to the corresponding rsgroup, appear > TableStateNotFoundException. > This doesn't seem to cause any problems, but I think it's best to avoid error > logs like this -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24067) [RSGroup] Error logs appear when the table is created
[ https://issues.apache.org/jira/browse/HBASE-24067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-24067: - Description: Will create table assigned to the corresponding rsgroup, appear TableStateNotFoundException: 2020-03-27 15:49:21,959 INFO [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default 2020-03-27 15:49:21,971 ERROR [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] master.TableStateManager: Unable to get table Test:t3 state org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: Test:t3 at org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215) at org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347) at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2043) at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134) at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2026) at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:659) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) 2020-03-27 15:49:21,971 INFO [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] rsgroup.RSGroupAdminServer: Moving region(s) for table Test:t3 to RSGroup default This doesn't seem to cause any problems, but I think it's best to avoid error logs like this was: Will create table assigned to the corresponding rsgroup, appear TableStateNotFoundException. This doesn't seem to cause any problems, but I think it's best to avoid error logs like this > [RSGroup] Error logs appear when the table is created > - > > Key: HBASE-24067 > URL: https://issues.apache.org/jira/browse/HBASE-24067 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.1.7, 2.1.8, 2.2.3, 2.2.4 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Minor > > Will create table assigned to the corresponding rsgroup, appear > TableStateNotFoundException: > 2020-03-27 15:49:21,959 INFO > [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] > rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default > 2020-03-27 15:49:21,971 ERROR > [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] > master.TableStateManager: Unable to get table Test:t3 state > org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: > Test:t3 > at > org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215) > at > org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147) > at > org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoi
[jira] [Updated] (HBASE-24067) [RSGroup] Error logs appear when the table is created
[ https://issues.apache.org/jira/browse/HBASE-24067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-24067: - Attachment: (was: 99FB1BA0-701B-11EA-8BFA-0BB11286B49120200327_S.jpg) > [RSGroup] Error logs appear when the table is created > - > > Key: HBASE-24067 > URL: https://issues.apache.org/jira/browse/HBASE-24067 > Project: HBase > Issue Type: Improvement > Components: rsgroup >Affects Versions: 2.1.7, 2.1.8, 2.2.3, 2.2.4 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Minor > > Will create table assigned to the corresponding rsgroup, appear > TableStateNotFoundException: > 2020-03-27 15:49:21,959 INFO > [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] > rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default > 2020-03-27 15:49:21,971 ERROR > [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] > master.TableStateManager: Unable to get table Test:t3 state > org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: > Test:t3 > at > org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215) > at > org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147) > at > org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470) > at > org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350) > at > org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625) > at > org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347) > at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2043) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134) > at > org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2026) > at > org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:659) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) > 2020-03-27 15:49:21,971 INFO > [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] > rsgroup.RSGroupAdminServer: Moving region(s) for table Test:t3 to RSGroup > default > > This doesn't seem to cause any problems, but I think it's best to avoid error > logs like this -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24067) [RSGroup] Error logs appear when the table is created
[ https://issues.apache.org/jira/browse/HBASE-24067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-24067: - Issue Type: Bug (was: Improvement) > [RSGroup] Error logs appear when the table is created > - > > Key: HBASE-24067 > URL: https://issues.apache.org/jira/browse/HBASE-24067 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.1.7, 2.1.8, 2.2.3, 2.2.4 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Minor > > Will create table assigned to the corresponding rsgroup, appear > TableStateNotFoundException: > 2020-03-27 15:49:21,959 INFO > [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] > rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default > 2020-03-27 15:49:21,971 ERROR > [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] > master.TableStateManager: Unable to get table Test:t3 state > org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: > Test:t3 > at > org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215) > at > org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147) > at > org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447) > at > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470) > at > org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350) > at > org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625) > at > org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347) > at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2043) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134) > at > org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2026) > at > org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:659) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) > 2020-03-27 15:49:21,971 INFO > [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] > rsgroup.RSGroupAdminServer: Moving region(s) for table Test:t3 to RSGroup > default > > This doesn't seem to cause any problems, but I think it's best to avoid error > logs like this -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24067) [RSGroup] Error logs appear when the table is created
[ https://issues.apache.org/jira/browse/HBASE-24067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-24067: - Description: Will create table assigned to the corresponding rsgroup, appear TableStateNotFoundException: {code:java} 2020-03-27 15:49:21,959 INFO [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default 2020-03-27 15:49:21,971 ERROR [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] master.TableStateManager: Unable to get table Test:t3 state org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: Test:t3 at org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215) at org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347) at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2043) at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134) at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2026) at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:659) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) 2020-03-27 15:49:21,971 INFO [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] rsgroup.RSGroupAdminServer: Moving region(s) for table Test:t3 to RSGroup default {code} This doesn't seem to cause any problems, but I think it's best to avoid error logs like this was: Will create table assigned to the corresponding rsgroup, appear TableStateNotFoundException: 2020-03-27 15:49:21,959 INFO [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default 2020-03-27 15:49:21,971 ERROR [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] master.TableStateManager: Unable to get table Test:t3 state org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: Test:t3 at org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215) at org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(M
[jira] [Created] (HBASE-24151) [rsgroup] The master server aborted for IllegalThreadStateException
kangkang.guo created HBASE-24151: Summary: [rsgroup] The master server aborted for IllegalThreadStateException Key: HBASE-24151 URL: https://issues.apache.org/jira/browse/HBASE-24151 Project: HBase Issue Type: Bug Components: rsgroup Affects Versions: 2.2.3, 2.1.7 Reporter: kangkang.guo Assignee: kangkang.guo if 'hbase.master.loadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer' and 'hbase.rsgroup.grouploadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer', The master server will aborted for IllegalThreadStateException. {code:java} 2020-04-09 11:24:26,142 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.lang.IllegalThreadStateException at java.lang.Thread.start(Thread.java:705) at org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.start(RSGroupInfoManagerImpl.java:172) at org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:417) at org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:430) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:968) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2275) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:584) at java.lang.Thread.run(Thread.java:745) 2020-04-09 11:24:26,144 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster] master.HMaster: Master server abort: loaded coprocessors are: [org.apache.hadoop.hbase.security.access.AccessController, org.apache.hadoop.hbase.quotas.MasterQuotasObserver, org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint]{code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24151) [rsgroup] The master server aborted for IllegalThreadStateException
[ https://issues.apache.org/jira/browse/HBASE-24151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-24151: - Affects Version/s: 2.3.0 > [rsgroup] The master server aborted for IllegalThreadStateException > > > Key: HBASE-24151 > URL: https://issues.apache.org/jira/browse/HBASE-24151 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.3.0, 2.1.7, 2.2.3 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Minor > > if > 'hbase.master.loadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer' > and > 'hbase.rsgroup.grouploadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer', > The master server will aborted for IllegalThreadStateException. > {code:java} > 2020-04-09 11:24:26,142 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster] > master.HMaster: Failed to become active master > java.lang.IllegalThreadStateException > at java.lang.Thread.start(Thread.java:705) > at > org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.start(RSGroupInfoManagerImpl.java:172) > at > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:417) > at > org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:430) > at > org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:968) > at > org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2275) > at > org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:584) > at java.lang.Thread.run(Thread.java:745) > 2020-04-09 11:24:26,144 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster] > master.HMaster: Master server abort: loaded coprocessors are: > [org.apache.hadoop.hbase.security.access.AccessController, > org.apache.hadoop.hbase.quotas.MasterQuotasObserver, > org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint]{code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23045) currentPath may be stitched in a loop in replication source code.
[ https://issues.apache.org/jira/browse/HBASE-23045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011511#comment-17011511 ] kangkang.guo commented on HBASE-23045: -- Hi Zheng hu, Sorry for taking so long to reply to you, I cannot provide a unit test to reproduce this bug for the time being, I will try to do so, and I have submitted a PR > currentPath may be stitched in a loop in replication source code. > -- > > Key: HBASE-23045 > URL: https://issues.apache.org/jira/browse/HBASE-23045 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.2.6.1 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Critical > Fix For: 1.2.6.1 > > Attachments: HBASE-23045.branch-1.2.0001.patch > > > When the openReader encounters a FileNotFoundException, we may go to all > possible directories to find the current hlog. When found, the path may be > wrong, and it is looped together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-23045) currentPath may be stitched in a loop in replication source code.
[ https://issues.apache.org/jira/browse/HBASE-23045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011511#comment-17011511 ] kangkang.guo edited comment on HBASE-23045 at 1/9/20 7:35 AM: -- Hi Zheng Hu, Sorry for taking so long to reply to you, I cannot provide a unit test to reproduce this bug for the time being, I will try to do so, and I have submitted a PR was (Author: gk_coder): Hi Zheng hu, Sorry for taking so long to reply to you, I cannot provide a unit test to reproduce this bug for the time being, I will try to do so, and I have submitted a PR > currentPath may be stitched in a loop in replication source code. > -- > > Key: HBASE-23045 > URL: https://issues.apache.org/jira/browse/HBASE-23045 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.2.6.1 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Critical > Fix For: 1.2.6.1 > > Attachments: HBASE-23045.branch-1.2.0001.patch > > > When the openReader encounters a FileNotFoundException, we may go to all > possible directories to find the current hlog. When found, the path may be > wrong, and it is looped together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-23045) currentPath may be stitched in a loop in replication source code.
[ https://issues.apache.org/jira/browse/HBASE-23045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011511#comment-17011511 ] kangkang.guo edited comment on HBASE-23045 at 1/9/20 7:37 AM: -- Hi [~openinx] , Sorry for taking so long to reply to you, I cannot provide a unit test to reproduce this bug for the time being, I will try to do so, and I have submitted a PR was (Author: gk_coder): Hi Zheng Hu, Sorry for taking so long to reply to you, I cannot provide a unit test to reproduce this bug for the time being, I will try to do so, and I have submitted a PR > currentPath may be stitched in a loop in replication source code. > -- > > Key: HBASE-23045 > URL: https://issues.apache.org/jira/browse/HBASE-23045 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.2.6.1 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Critical > Fix For: 1.2.6.1 > > Attachments: HBASE-23045.branch-1.2.0001.patch > > > When the openReader encounters a FileNotFoundException, we may go to all > possible directories to find the current hlog. When found, the path may be > wrong, and it is looped together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23669) ZNodeClearer#clear() throws IllegalArgumentException
kangkang.guo created HBASE-23669: Summary: ZNodeClearer#clear() throws IllegalArgumentException Key: HBASE-23669 URL: https://issues.apache.org/jira/browse/HBASE-23669 Project: HBase Issue Type: Bug Affects Versions: 2.1.5 Reporter: kangkang.guo Assignee: kangkang.guo Precondition: hbase.balancer.tablesOnMaster = true hbase.balancer.tablesOnMaster.systemTablesOnly = true In case of master-rs collocation HBASE_ZNODE_FILE is overwritten by regionserver process in HRegionServer#handleReportForDutyResponse() here is how it looks on master server: [hadoop@master-node data]$ cat hbase-hadoop-master.znode /hbase/rs/master-node,16000,1578371505720 When ZNodeClearer#clear(), the rsZNode is also splicing with the contents of the file, causing an exception: java.lang.IllegalArgumentException: Invalid path string "/hbase/rs//hbase/rs/master-node,16000,1578371503003" caused by empty node name specified @10 at org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99) at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:851) at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:166) at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1259) at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1251) at org.apache.hadoop.hbase.ZNodeClearer.clear(ZNodeClearer.java:188) at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3117) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23669) ZNodeClearer#clear() throws IllegalArgumentException
[ https://issues.apache.org/jira/browse/HBASE-23669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-23669: - Attachment: HBASE-23669.branch-2.1.0001.patch Fix Version/s: 2.1.5 2.1.6 2.1.8 Status: Patch Available (was: Open) > ZNodeClearer#clear() throws IllegalArgumentException > - > > Key: HBASE-23669 > URL: https://issues.apache.org/jira/browse/HBASE-23669 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.5 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Major > Fix For: 2.1.8, 2.1.6, 2.1.5 > > Attachments: HBASE-23669.branch-2.1.0001.patch > > > Precondition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > In case of master-rs collocation HBASE_ZNODE_FILE is overwritten by > regionserver process in HRegionServer#handleReportForDutyResponse() here is > how it looks on master server: > [hadoop@master-node data]$ cat hbase-hadoop-master.znode > /hbase/rs/master-node,16000,1578371505720 > When ZNodeClearer#clear(), the rsZNode is also splicing with the contents of > the file, causing an exception: > java.lang.IllegalArgumentException: Invalid path string > "/hbase/rs//hbase/rs/master-node,16000,1578371503003" caused by empty node > name specified @10 > at > org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99) > at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:851) > at > org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:166) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1259) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1251) > at org.apache.hadoop.hbase.ZNodeClearer.clear(ZNodeClearer.java:188) > at > org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at > org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) > at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3117) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23669) ZNodeClearer#clear() throws IllegalArgumentException
[ https://issues.apache.org/jira/browse/HBASE-23669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-23669: - Attachment: HBASE-23669.master.patch > ZNodeClearer#clear() throws IllegalArgumentException > - > > Key: HBASE-23669 > URL: https://issues.apache.org/jira/browse/HBASE-23669 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.5 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Major > Fix For: 2.1.5, 2.1.6, 2.1.8 > > Attachments: HBASE-23669.branch-2.1.0001.patch, > HBASE-23669.master.patch > > > Precondition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > In case of master-rs collocation HBASE_ZNODE_FILE is overwritten by > regionserver process in HRegionServer#handleReportForDutyResponse() here is > how it looks on master server: > [hadoop@master-node data]$ cat hbase-hadoop-master.znode > /hbase/rs/master-node,16000,1578371505720 > When ZNodeClearer#clear(), the rsZNode is also splicing with the contents of > the file, causing an exception: > java.lang.IllegalArgumentException: Invalid path string > "/hbase/rs//hbase/rs/master-node,16000,1578371503003" caused by empty node > name specified @10 > at > org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99) > at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:851) > at > org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:166) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1259) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1251) > at org.apache.hadoop.hbase.ZNodeClearer.clear(ZNodeClearer.java:188) > at > org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at > org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) > at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3117) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23045) currentPath may be stitched in a loop in replication source code.
[ https://issues.apache.org/jira/browse/HBASE-23045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-23045: - Resolution: Fixed Status: Resolved (was: Patch Available) > currentPath may be stitched in a loop in replication source code. > -- > > Key: HBASE-23045 > URL: https://issues.apache.org/jira/browse/HBASE-23045 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.2.6.1 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Critical > Fix For: 1.2.6.1 > > Attachments: HBASE-23045.branch-1.2.0001.patch > > > When the openReader encounters a FileNotFoundException, we may go to all > possible directories to find the current hlog. When found, the path may be > wrong, and it is looped together. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23669) ZNodeClearer#clear() throws IllegalArgumentException
[ https://issues.apache.org/jira/browse/HBASE-23669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014842#comment-17014842 ] kangkang.guo commented on HBASE-23669: -- I think this is an obvious problem. Can anyone review it? > ZNodeClearer#clear() throws IllegalArgumentException > - > > Key: HBASE-23669 > URL: https://issues.apache.org/jira/browse/HBASE-23669 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.5 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Major > Fix For: 2.1.5, 2.1.6, 2.1.8 > > Attachments: HBASE-23669.branch-2.1.0001.patch, > HBASE-23669.master.patch > > > Precondition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > In case of master-rs collocation HBASE_ZNODE_FILE is overwritten by > regionserver process in HRegionServer#handleReportForDutyResponse() here is > how it looks on master server: > [hadoop@master-node data]$ cat hbase-hadoop-master.znode > /hbase/rs/master-node,16000,1578371505720 > When ZNodeClearer#clear(), the rsZNode is also splicing with the contents of > the file, causing an exception: > java.lang.IllegalArgumentException: Invalid path string > "/hbase/rs//hbase/rs/master-node,16000,1578371503003" caused by empty node > name specified @10 > at > org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99) > at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:851) > at > org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:166) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1259) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1251) > at org.apache.hadoop.hbase.ZNodeClearer.clear(ZNodeClearer.java:188) > at > org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at > org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) > at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3117) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23669) ZNodeClearer#clear() throws IllegalArgumentException
[ https://issues.apache.org/jira/browse/HBASE-23669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043196#comment-17043196 ] kangkang.guo commented on HBASE-23669: -- [~stack] Thanks for the review. Yes, I think it still needs to be fixed, because this is the error that occurred when the master deleted its corresponding znode when exiting, regardless of whether there was any region on the master > ZNodeClearer#clear() throws IllegalArgumentException > - > > Key: HBASE-23669 > URL: https://issues.apache.org/jira/browse/HBASE-23669 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.5 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Major > Fix For: 2.1.5, 2.1.6, 2.1.8 > > Attachments: HBASE-23669.branch-2.1.0001.patch, > HBASE-23669.master.patch > > > Precondition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > In case of master-rs collocation HBASE_ZNODE_FILE is overwritten by > regionserver process in HRegionServer#handleReportForDutyResponse() here is > how it looks on master server: > [hadoop@master-node data]$ cat hbase-hadoop-master.znode > /hbase/rs/master-node,16000,1578371505720 > When ZNodeClearer#clear(), the rsZNode is also splicing with the contents of > the file, causing an exception: > java.lang.IllegalArgumentException: Invalid path string > "/hbase/rs//hbase/rs/master-node,16000,1578371503003" caused by empty node > name specified @10 > at > org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99) > at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:851) > at > org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:166) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1259) > at > org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1251) > at org.apache.hadoop.hbase.ZNodeClearer.clear(ZNodeClearer.java:188) > at > org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144) > at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) > at > org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) > at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3117) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24355) Fix typos in the HStore#compact annotation
kangkang.guo created HBASE-24355: Summary: Fix typos in the HStore#compact annotation Key: HBASE-24355 URL: https://issues.apache.org/jira/browse/HBASE-24355 Project: HBase Issue Type: Improvement Affects Versions: 1.4.13, 1.3.6, 1.2.6.1 Reporter: kangkang.guo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-24355) Fix typos in the HStore#compact annotation
[ https://issues.apache.org/jira/browse/HBASE-24355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo reassigned HBASE-24355: Assignee: kangkang.guo > Fix typos in the HStore#compact annotation > -- > > Key: HBASE-24355 > URL: https://issues.apache.org/jira/browse/HBASE-24355 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.2.6.1, 1.3.6, 1.4.13 >Reporter: kangkang.guo >Assignee: kangkang.guo >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24447) Contribute a Test class that shows some examples for using the Async Client API
[ https://issues.apache.org/jira/browse/HBASE-24447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-24447: - Description: 类似于 [https://github.com/apache/hbase/blob/master/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/AsyncClientExample.java] 但最初是以测试的形式进行,以使验证和环境变得容易。 这基本上是一些示例,说明如何将CompletableFuture API与Async Client一起使用-鉴于CompletableFuture API的表达力和大小,从头开始做一个新手可能会有些痛苦,但是使用其他示例代码要容易得多建立或修补。 was: Kind of along the lines of [https://github.com/apache/hbase/blob/master/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/AsyncClientExample.java] but initially in the form of a test to make verification and env easy. This is basically some examples of how you can use the CompletableFuture API with the Async Client - it can be a little painful to do from scratch for a noobie given the expressivness and size of the CompletableFuture API, but is much easier with some more example code to build on or tinker with. > Contribute a Test class that shows some examples for using the Async Client > API > --- > > Key: HBASE-24447 > URL: https://issues.apache.org/jira/browse/HBASE-24447 > Project: HBase > Issue Type: Test > Components: test >Reporter: Mark Robert Miller >Priority: Minor > > 类似于 > [https://github.com/apache/hbase/blob/master/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/AsyncClientExample.java] > 但最初是以测试的形式进行,以使验证和环境变得容易。 > 这基本上是一些示例,说明如何将CompletableFuture API与Async Client一起使用-鉴于CompletableFuture > API的表达力和大小,从头开始做一个新手可能会有些痛苦,但是使用其他示例代码要容易得多建立或修补。 -- This message was sent by Atlassian Jira (v8.3.4#803005)