[jira] [Commented] (HBASE-21381) Document the hadoop versions using which backup and restore feature works
[ https://issues.apache.org/jira/browse/HBASE-21381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676090#comment-16676090 ] liubangchen commented on HBASE-21381: - Not at all . If some thing I can do it just say . Thanks. > Document the hadoop versions using which backup and restore feature works > - > > Key: HBASE-21381 > URL: https://issues.apache.org/jira/browse/HBASE-21381 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-21381-1.patch, HBASE-21381-2.patch, > HBASE-21381-3.patch > > > HADOOP-15850 fixes a bug where CopyCommitter#concatFileChunks unconditionally > tried to concatenate the files being DistCp'ed to target cluster (though the > files are independent). > Following is the log snippet of the failed concatenation attempt: > {code} > 2018-10-13 14:09:25,351 WARN [Thread-936] mapred.LocalJobRunner$Job(590): > job_local1795473782_0004 > java.io.IOException: Inconsistent sequence file: current chunk file > org.apache.hadoop.tools.CopyListingFileStatus@bb8826ee{hdfs://localhost:42796/user/hbase/test-data/ > > 160aeab5-6bca-9f87-465e-2517a0c43119/data/default/test-1539439707496/96b5a3613d52f4df1ba87a1cef20684c/f/a7599081e835440eb7bf0dd3ef4fd7a5_SeqId_205_ > length = 5100 aclEntries = null, xAttrs = null} doesnt match prior entry > org.apache.hadoop.tools.CopyListingFileStatus@243d544d{hdfs://localhost:42796/user/hbase/test-data/160aeab5-6bca-9f87-465e- > > 2517a0c43119/data/default/test-1539439707496/96b5a3613d52f4df1ba87a1cef20684c/f/394e6d39a9b94b148b9089c4fb967aad_SeqId_205_ > length = 5142 aclEntries = null, xAttrs = null} > at > org.apache.hadoop.tools.mapred.CopyCommitter.concatFileChunks(CopyCommitter.java:276) > at > org.apache.hadoop.tools.mapred.CopyCommitter.commitJob(CopyCommitter.java:100) > at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:567) > {code} > Backup and Restore uses DistCp to transfer files between clusters. > Without the fix from HADOOP-15850, the transfer would fail. > This issue is to document the hadoop versions which contain HADOOP-15850 so > that user of Backup and Restore feature knows which hadoop versions they can > use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21381) Document the hadoop versions using which backup and restore feature works
[ https://issues.apache.org/jira/browse/HBASE-21381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-21381: Attachment: HBASE-21381-3.patch > Document the hadoop versions using which backup and restore feature works > - > > Key: HBASE-21381 > URL: https://issues.apache.org/jira/browse/HBASE-21381 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-21381-1.patch, HBASE-21381-2.patch, > HBASE-21381-3.patch > > > HADOOP-15850 fixes a bug where CopyCommitter#concatFileChunks unconditionally > tried to concatenate the files being DistCp'ed to target cluster (though the > files are independent). > Following is the log snippet of the failed concatenation attempt: > {code} > 2018-10-13 14:09:25,351 WARN [Thread-936] mapred.LocalJobRunner$Job(590): > job_local1795473782_0004 > java.io.IOException: Inconsistent sequence file: current chunk file > org.apache.hadoop.tools.CopyListingFileStatus@bb8826ee{hdfs://localhost:42796/user/hbase/test-data/ > > 160aeab5-6bca-9f87-465e-2517a0c43119/data/default/test-1539439707496/96b5a3613d52f4df1ba87a1cef20684c/f/a7599081e835440eb7bf0dd3ef4fd7a5_SeqId_205_ > length = 5100 aclEntries = null, xAttrs = null} doesnt match prior entry > org.apache.hadoop.tools.CopyListingFileStatus@243d544d{hdfs://localhost:42796/user/hbase/test-data/160aeab5-6bca-9f87-465e- > > 2517a0c43119/data/default/test-1539439707496/96b5a3613d52f4df1ba87a1cef20684c/f/394e6d39a9b94b148b9089c4fb967aad_SeqId_205_ > length = 5142 aclEntries = null, xAttrs = null} > at > org.apache.hadoop.tools.mapred.CopyCommitter.concatFileChunks(CopyCommitter.java:276) > at > org.apache.hadoop.tools.mapred.CopyCommitter.commitJob(CopyCommitter.java:100) > at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:567) > {code} > Backup and Restore uses DistCp to transfer files between clusters. > Without the fix from HADOOP-15850, the transfer would fail. > This issue is to document the hadoop versions which contain HADOOP-15850 so > that user of Backup and Restore feature knows which hadoop versions they can > use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21381) Document the hadoop versions using which backup and restore feature works
[ https://issues.apache.org/jira/browse/HBASE-21381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-21381: Attachment: HBASE-21381-2.patch > Document the hadoop versions using which backup and restore feature works > - > > Key: HBASE-21381 > URL: https://issues.apache.org/jira/browse/HBASE-21381 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-21381-1.patch, HBASE-21381-2.patch > > > HADOOP-15850 fixes a bug where CopyCommitter#concatFileChunks unconditionally > tried to concatenate the files being DistCp'ed to target cluster (though the > files are independent). > Following is the log snippet of the failed concatenation attempt: > {code} > 2018-10-13 14:09:25,351 WARN [Thread-936] mapred.LocalJobRunner$Job(590): > job_local1795473782_0004 > java.io.IOException: Inconsistent sequence file: current chunk file > org.apache.hadoop.tools.CopyListingFileStatus@bb8826ee{hdfs://localhost:42796/user/hbase/test-data/ > > 160aeab5-6bca-9f87-465e-2517a0c43119/data/default/test-1539439707496/96b5a3613d52f4df1ba87a1cef20684c/f/a7599081e835440eb7bf0dd3ef4fd7a5_SeqId_205_ > length = 5100 aclEntries = null, xAttrs = null} doesnt match prior entry > org.apache.hadoop.tools.CopyListingFileStatus@243d544d{hdfs://localhost:42796/user/hbase/test-data/160aeab5-6bca-9f87-465e- > > 2517a0c43119/data/default/test-1539439707496/96b5a3613d52f4df1ba87a1cef20684c/f/394e6d39a9b94b148b9089c4fb967aad_SeqId_205_ > length = 5142 aclEntries = null, xAttrs = null} > at > org.apache.hadoop.tools.mapred.CopyCommitter.concatFileChunks(CopyCommitter.java:276) > at > org.apache.hadoop.tools.mapred.CopyCommitter.commitJob(CopyCommitter.java:100) > at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:567) > {code} > Backup and Restore uses DistCp to transfer files between clusters. > Without the fix from HADOOP-15850, the transfer would fail. > This issue is to document the hadoop versions which contain HADOOP-15850 so > that user of Backup and Restore feature knows which hadoop versions they can > use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21381) Document the hadoop versions using which backup and restore feature works
[ https://issues.apache.org/jira/browse/HBASE-21381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-21381: Attachment: HBASE-21381-1.patch Status: Patch Available (was: Open) > Document the hadoop versions using which backup and restore feature works > - > > Key: HBASE-21381 > URL: https://issues.apache.org/jira/browse/HBASE-21381 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-21381-1.patch > > > HADOOP-15850 fixes a bug where CopyCommitter#concatFileChunks unconditionally > tried to concatenate the files being DistCp'ed to target cluster (though the > files are independent). > Following is the log snippet of the failed concatenation attempt: > {code} > 2018-10-13 14:09:25,351 WARN [Thread-936] mapred.LocalJobRunner$Job(590): > job_local1795473782_0004 > java.io.IOException: Inconsistent sequence file: current chunk file > org.apache.hadoop.tools.CopyListingFileStatus@bb8826ee{hdfs://localhost:42796/user/hbase/test-data/ > > 160aeab5-6bca-9f87-465e-2517a0c43119/data/default/test-1539439707496/96b5a3613d52f4df1ba87a1cef20684c/f/a7599081e835440eb7bf0dd3ef4fd7a5_SeqId_205_ > length = 5100 aclEntries = null, xAttrs = null} doesnt match prior entry > org.apache.hadoop.tools.CopyListingFileStatus@243d544d{hdfs://localhost:42796/user/hbase/test-data/160aeab5-6bca-9f87-465e- > > 2517a0c43119/data/default/test-1539439707496/96b5a3613d52f4df1ba87a1cef20684c/f/394e6d39a9b94b148b9089c4fb967aad_SeqId_205_ > length = 5142 aclEntries = null, xAttrs = null} > at > org.apache.hadoop.tools.mapred.CopyCommitter.concatFileChunks(CopyCommitter.java:276) > at > org.apache.hadoop.tools.mapred.CopyCommitter.commitJob(CopyCommitter.java:100) > at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:567) > {code} > Backup and Restore uses DistCp to transfer files between clusters. > Without the fix from HADOOP-15850, the transfer would fail. > This issue is to document the hadoop versions which contain HADOOP-15850 so > that user of Backup and Restore feature knows which hadoop versions they can > use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-21381) Document the hadoop versions using which backup and restore feature works
[ https://issues.apache.org/jira/browse/HBASE-21381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen reassigned HBASE-21381: --- Assignee: liubangchen > Document the hadoop versions using which backup and restore feature works > - > > Key: HBASE-21381 > URL: https://issues.apache.org/jira/browse/HBASE-21381 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > > HADOOP-15850 fixes a bug where CopyCommitter#concatFileChunks unconditionally > tried to concatenate the files being DistCp'ed to target cluster (though the > files are independent). > Following is the log snippet of the failed concatenation attempt: > {code} > 2018-10-13 14:09:25,351 WARN [Thread-936] mapred.LocalJobRunner$Job(590): > job_local1795473782_0004 > java.io.IOException: Inconsistent sequence file: current chunk file > org.apache.hadoop.tools.CopyListingFileStatus@bb8826ee{hdfs://localhost:42796/user/hbase/test-data/ > > 160aeab5-6bca-9f87-465e-2517a0c43119/data/default/test-1539439707496/96b5a3613d52f4df1ba87a1cef20684c/f/a7599081e835440eb7bf0dd3ef4fd7a5_SeqId_205_ > length = 5100 aclEntries = null, xAttrs = null} doesnt match prior entry > org.apache.hadoop.tools.CopyListingFileStatus@243d544d{hdfs://localhost:42796/user/hbase/test-data/160aeab5-6bca-9f87-465e- > > 2517a0c43119/data/default/test-1539439707496/96b5a3613d52f4df1ba87a1cef20684c/f/394e6d39a9b94b148b9089c4fb967aad_SeqId_205_ > length = 5142 aclEntries = null, xAttrs = null} > at > org.apache.hadoop.tools.mapred.CopyCommitter.concatFileChunks(CopyCommitter.java:276) > at > org.apache.hadoop.tools.mapred.CopyCommitter.commitJob(CopyCommitter.java:100) > at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:567) > {code} > Backup and Restore uses DistCp to transfer files between clusters. > Without the fix from HADOOP-15850, the transfer would fail. > This issue is to document the hadoop versions which contain HADOOP-15850 so > that user of Backup and Restore feature knows which hadoop versions they can > use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21230) BackupUtils#checkTargetDir doesn't compose error message correctly
[ https://issues.apache.org/jira/browse/HBASE-21230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641320#comment-16641320 ] liubangchen commented on HBASE-21230: - I think so. Let me fix it. > BackupUtils#checkTargetDir doesn't compose error message correctly > -- > > Key: HBASE-21230 > URL: https://issues.apache.org/jira/browse/HBASE-21230 > Project: HBase > Issue Type: Bug > Components: backuprestore >Reporter: Ted Yu >Assignee: liubangchen >Priority: Minor > Attachments: HBASE-21230-1.patch > > > Here is related code from BackupUtils#checkTargetDir: > {code} > String expMsg = e.getMessage(); > String newMsg = null; > if (expMsg.contains("No FileSystem for scheme")) { > newMsg = > "Unsupported filesystem scheme found in the backup target url. > Error Message: " > + newMsg; > {code} > I think the intention was to concatenate expMsg at the end of newMsg. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21230) BackupUtils#checkTargetDir doesn't compose error message correctly
[ https://issues.apache.org/jira/browse/HBASE-21230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-21230: Attachment: HBASE-21230-1.patch Status: Patch Available (was: Open) > BackupUtils#checkTargetDir doesn't compose error message correctly > -- > > Key: HBASE-21230 > URL: https://issues.apache.org/jira/browse/HBASE-21230 > Project: HBase > Issue Type: Bug > Components: backuprestore >Reporter: Ted Yu >Assignee: liubangchen >Priority: Minor > Attachments: HBASE-21230-1.patch > > > Here is related code from BackupUtils#checkTargetDir: > {code} > String expMsg = e.getMessage(); > String newMsg = null; > if (expMsg.contains("No FileSystem for scheme")) { > newMsg = > "Unsupported filesystem scheme found in the backup target url. > Error Message: " > + newMsg; > {code} > I think the intention was to concatenate expMsg at the end of newMsg. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-21230) BackupUtils#checkTargetDir doesn't compose error message correctly
[ https://issues.apache.org/jira/browse/HBASE-21230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen reassigned HBASE-21230: --- Assignee: liubangchen > BackupUtils#checkTargetDir doesn't compose error message correctly > -- > > Key: HBASE-21230 > URL: https://issues.apache.org/jira/browse/HBASE-21230 > Project: HBase > Issue Type: Bug > Components: backuprestore >Reporter: Ted Yu >Assignee: liubangchen >Priority: Minor > > Here is related code: > {code} > String expMsg = e.getMessage(); > String newMsg = null; > if (expMsg.contains("No FileSystem for scheme")) { > newMsg = > "Unsupported filesystem scheme found in the backup target url. > Error Message: " > + newMsg; > {code} > I think the intention was to concatenate expMsg at the end of newMsg. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-21160: Attachment: HBASE-21160-5.patch > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > Fix For: 3.0.0 > > Attachments: HBASE-21160-1.patch, HBASE-21160-2.patch, > HBASE-21160-3.patch, HBASE-21160-4.patch, HBASE-21160-5.patch > > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-21160: Attachment: HBASE-21160-4.patch > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > Attachments: HBASE-21160-1.patch, HBASE-21160-2.patch, > HBASE-21160-3.patch, HBASE-21160-4.patch > > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-21160: Attachment: HBASE-21160-3.patch > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > Attachments: HBASE-21160-1.patch, HBASE-21160-2.patch, > HBASE-21160-3.patch > > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-21160: Attachment: HBASE-21160-2.patch > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > Attachments: HBASE-21160-1.patch, HBASE-21160-2.patch > > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614557#comment-16614557 ] liubangchen edited comment on HBASE-21160 at 9/14/18 9:16 AM: -- Areadly has run with commd : {code} mvn -Dtest=org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes surefire-report:report test {code} And result is: {code} Unable to find source-code formatter for language: shell. Available languages are: actionscript, ada, applescript, bash, c, c#, c++, cpp, css, erlang, go, groovy, haskell, html, java, javascript, js, json, lua, none, nyan, objc, perl, php, python, r, rainbow, ruby, scala, sh, sql, swift, visualbasic, xml, yaml[INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes [INFO] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 86.421 s - in org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes [INFO] [INFO] Results: [INFO] [INFO] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- maven-surefire-plugin:2.21.0:test (secondPartTestsExecution) @ hbase-server --- [INFO] Tests are skipped. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 03:59 min [INFO] Finished at: 2018-09-14T14:13:15+08:00 [INFO] {code} was (Author: liubangchen): Areadly has run with commd : {code:shell} mvn -Dtest=org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes surefire-report:report test {code} And result is: {code:shell} [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes [INFO] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 86.421 s - in org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes [INFO] [INFO] Results: [INFO] [INFO] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- maven-surefire-plugin:2.21.0:test (secondPartTestsExecution) @ hbase-server --- [INFO] Tests are skipped. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 03:59 min [INFO] Finished at: 2018-09-14T14:13:15+08:00 [INFO] {code} > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > Attachments: HBASE-21160-1.patch > > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614557#comment-16614557 ] liubangchen commented on HBASE-21160: - Areadly has run with commd : {code:shell} mvn -Dtest=org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes surefire-report:report test {code} And result is: {code:shell} [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes [INFO] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 86.421 s - in org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes [INFO] [INFO] Results: [INFO] [INFO] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- maven-surefire-plugin:2.21.0:test (secondPartTestsExecution) @ hbase-server --- [INFO] Tests are skipped. [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 03:59 min [INFO] Finished at: 2018-09-14T14:13:15+08:00 [INFO] {code} > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > Attachments: HBASE-21160-1.patch > > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-21160: Attachment: HBASE-21160-1.patch Status: Patch Available (was: Open) > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > Attachments: HBASE-21160-1.patch > > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614271#comment-16614271 ] liubangchen edited comment on HBASE-21160 at 9/14/18 2:44 AM: -- Hi [~yuzhih...@gmail.com] code review link is here [reviews-68699|https://reviews.apache.org/r/68699/] was (Author: liubangchen): Hi [~yuzhih...@gmail.com] code review link is here [#https://reviews.apache.org/r/68699/] > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614271#comment-16614271 ] liubangchen commented on HBASE-21160: - Hi [~yuzhih...@gmail.com] code review link is here [#https://reviews.apache.org/r/68699/] > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613394#comment-16613394 ] liubangchen commented on HBASE-21160: - Hi [~yuzhih...@gmail.com] I found so many re-throws blocks in the file of TestVisibilityLabelsWithDeletes.java . Should we resolve it all? > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611808#comment-16611808 ] liubangchen commented on HBASE-21160: - What about change Throwable to IOException ? what is you opinion?[~yuzhih...@gmail.com] > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-21160) Assertion in TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels is ignored
[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen reassigned HBASE-21160: --- Assignee: liubangchen > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > --- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: liubangchen >Priority: Trivial > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction scanAction = new > PrivilegedExceptionAction() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591041#comment-16591041 ] liubangchen commented on HBASE-19008: - I have in bed last night, Thank you very much [~reidchan] [~yuzhih...@gmail.com] . If anything I can do just say it. > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Fix For: 3.0.0, 2.2.0 > > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch, > HBASE-19008-17.patch, HBASE-19008-18.patch, HBASE-19008-2.patch, > HBASE-19008-20.patch, HBASE-19008-21.patch, HBASE-19008-3.patch, > HBASE-19008-4.patch, HBASE-19008-5.patch, HBASE-19008-6.patch, > HBASE-19008-7.patch, HBASE-19008-8.patch, HBASE-19008-9.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-21.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Fix For: 3.0.0, 2.2.0 > > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch, > HBASE-19008-17.patch, HBASE-19008-18.patch, HBASE-19008-2.patch, > HBASE-19008-20.patch, HBASE-19008-21.patch, HBASE-19008-3.patch, > HBASE-19008-4.patch, HBASE-19008-5.patch, HBASE-19008-6.patch, > HBASE-19008-7.patch, HBASE-19008-8.patch, HBASE-19008-9.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589645#comment-16589645 ] liubangchen commented on HBASE-19008: - I get it. Thank you very much [~reidchan] [~yuzhih...@gmail.com] > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Fix For: 3.0.0, 2.2.0 > > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch, > HBASE-19008-17.patch, HBASE-19008-18.patch, HBASE-19008-2.patch, > HBASE-19008-20.patch, HBASE-19008-3.patch, HBASE-19008-4.patch, > HBASE-19008-5.patch, HBASE-19008-6.patch, HBASE-19008-7.patch, > HBASE-19008-8.patch, HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589619#comment-16589619 ] liubangchen commented on HBASE-19008: - Does is correct to use git diff command to generate patch? Thanks. > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Fix For: 3.0.0, 2.2.0 > > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch, > HBASE-19008-17.patch, HBASE-19008-18.patch, HBASE-19008-2.patch, > HBASE-19008-20.patch, HBASE-19008-3.patch, HBASE-19008-4.patch, > HBASE-19008-5.patch, HBASE-19008-6.patch, HBASE-19008-7.patch, > HBASE-19008-8.patch, HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589581#comment-16589581 ] liubangchen commented on HBASE-19008: - [~reidchan] [~yuzhih...@gmail.com] Thank you for you help. :) > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch, > HBASE-19008-17.patch, HBASE-19008-18.patch, HBASE-19008-2.patch, > HBASE-19008-20.patch, HBASE-19008-3.patch, HBASE-19008-4.patch, > HBASE-19008-5.patch, HBASE-19008-6.patch, HBASE-19008-7.patch, > HBASE-19008-8.patch, HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-20.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch, > HBASE-19008-17.patch, HBASE-19008-18.patch, HBASE-19008-2.patch, > HBASE-19008-20.patch, HBASE-19008-3.patch, HBASE-19008-4.patch, > HBASE-19008-5.patch, HBASE-19008-6.patch, HBASE-19008-7.patch, > HBASE-19008-8.patch, HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-18.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch, > HBASE-19008-17.patch, HBASE-19008-18.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008-8.patch, > HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-17.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch, > HBASE-19008-17.patch, HBASE-19008-2.patch, HBASE-19008-3.patch, > HBASE-19008-4.patch, HBASE-19008-5.patch, HBASE-19008-6.patch, > HBASE-19008-7.patch, HBASE-19008-8.patch, HBASE-19008-9.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-16.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-16.patch, > HBASE-19008-2.patch, HBASE-19008-3.patch, HBASE-19008-4.patch, > HBASE-19008-5.patch, HBASE-19008-6.patch, HBASE-19008-7.patch, > HBASE-19008-8.patch, HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-15.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008-8.patch, > HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586910#comment-16586910 ] liubangchen commented on HBASE-19008: - [~reidchan] Thank you for you help . I will fix it and submit patch. > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-2.patch, HBASE-19008-3.patch, > HBASE-19008-4.patch, HBASE-19008-5.patch, HBASE-19008-6.patch, > HBASE-19008-7.patch, HBASE-19008-8.patch, HBASE-19008-9.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: (was: HBASE-19008-15.patch) > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-2.patch, HBASE-19008-3.patch, > HBASE-19008-4.patch, HBASE-19008-5.patch, HBASE-19008-6.patch, > HBASE-19008-7.patch, HBASE-19008-8.patch, HBASE-19008-9.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584699#comment-16584699 ] liubangchen commented on HBASE-19008: - Hi, [~reidchan] cloud help me to to find format and importOrder profile located in hbase project? > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008-8.patch, > HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-15.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008-8.patch, > HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-14.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-14.patch, HBASE-19008-2.patch, HBASE-19008-3.patch, > HBASE-19008-4.patch, HBASE-19008-5.patch, HBASE-19008-6.patch, > HBASE-19008-7.patch, HBASE-19008-8.patch, HBASE-19008-9.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-13.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, > HBASE-19008-2.patch, HBASE-19008-3.patch, HBASE-19008-4.patch, > HBASE-19008-5.patch, HBASE-19008-6.patch, HBASE-19008-7.patch, > HBASE-19008-8.patch, HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-12.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008-8.patch, > HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-11.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-11.patch, HBASE-19008-2.patch, HBASE-19008-3.patch, > HBASE-19008-4.patch, HBASE-19008-5.patch, HBASE-19008-6.patch, > HBASE-19008-7.patch, HBASE-19008-8.patch, HBASE-19008-9.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579784#comment-16579784 ] liubangchen commented on HBASE-19008: - Use dev-support/hbase_eclipse_formatter.xml as format profile and IDE is Eclipse to fix checkStyle issues. > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-2.patch, HBASE-19008-3.patch, HBASE-19008-4.patch, > HBASE-19008-5.patch, HBASE-19008-6.patch, HBASE-19008-7.patch, > HBASE-19008-8.patch, HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-10.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, > HBASE-19008-2.patch, HBASE-19008-3.patch, HBASE-19008-4.patch, > HBASE-19008-5.patch, HBASE-19008-6.patch, HBASE-19008-7.patch, > HBASE-19008-8.patch, HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-9.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008-8.patch, > HBASE-19008-9.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578494#comment-16578494 ] liubangchen commented on HBASE-19008: - I use Emacs and google-code-style. Now I use IDEA to format code to fix findbug issues. > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008-8.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-8.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008-8.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571482#comment-16571482 ] liubangchen commented on HBASE-19008: - Fix issues for checkstyle. > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-7.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570216#comment-16570216 ] liubangchen commented on HBASE-19008: - Fix issues for FindBugs and CheckStyle. > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-6.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008-6.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-5.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569678#comment-16569678 ] liubangchen commented on HBASE-19008: - Fix issues for Hadoop QA. > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-4.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-3.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567943#comment-16567943 ] liubangchen commented on HBASE-19008: - [~liuml07] Thank you for you suggestion.I have resolved all issues. > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-2.patch > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567686#comment-16567686 ] liubangchen commented on HBASE-19008: - [~reidchan] Thank you for reminding. I have resolved all Filters. > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-19008: Attachment: HBASE-19008-1.patch Status: Patch Available (was: In Progress) > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564927#comment-16564927 ] liubangchen edited comment on HBASE-19008 at 8/1/18 8:11 AM: - [~Jan Hentschel] Thanks . Add equals and hashCode for Filters as below: - ColumnPaginationFilter - ColumnCountGetFilter - MultiRowRangeFilter - KeyOnlyFilter - MultipleColumnPrefixFilter - ColumnPrefixFilter - SingleColumnValueFilter - FuzzyRowFilter - FirstKeyOnlyFilter - RandomRowFilter - PrefixFilter - CompareFilter - - FilterList - TimestampsFilter - ColumnRangeFilter Code Review Link: https://reviews.apache.org/r/68079/ was (Author: liubangchen): [~Jan Hentschel] Thanks . Add equals and hashCode for Filters as below: - ColumnPaginationFilter - ColumnCountGetFilter - MultiRowRangeFilter - KeyOnlyFilter - MultipleColumnPrefixFilter - ColumnPrefixFilter - SingleColumnValueFilter - FuzzyRowFilter - FirstKeyOnlyFilter - RandomRowFilter - PrefixFilter - CompareFilter - FilterList - TimestampsFilter - ColumnRangeFilter Code Review Link: https://reviews.apache.org/r/68079/ > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564927#comment-16564927 ] liubangchen commented on HBASE-19008: - [~Jan Hentschel] Thanks . Add equals and hashCode for Filters as below: - ColumnPaginationFilter - ColumnCountGetFilter - MultiRowRangeFilter - KeyOnlyFilter - MultipleColumnPrefixFilter - ColumnPrefixFilter - SingleColumnValueFilter - FuzzyRowFilter - FirstKeyOnlyFilter - RandomRowFilter - PrefixFilter - CompareFilter - FilterList - TimestampsFilter - ColumnRangeFilter Code Review Link: https://reviews.apache.org/r/68079/ > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Labels: filter > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559198#comment-16559198 ] liubangchen commented on HBASE-19008: - [~Jan Hentschel] If you have no time, I can take this issure.Thanks. > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Jan Hentschel >Priority: Major > Labels: filter > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations
[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558088#comment-16558088 ] liubangchen commented on HBASE-19008: - ping [~Jan Hentschel] , Could I can resolve this issure ? > Add missing equals or hashCode method(s) to stock Filter implementations > > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Jan Hentschel >Priority: Major > Labels: filter > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497670#comment-16497670 ] liubangchen commented on HBASE-20654: - I unstand it . Thanks > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: 1.png, HBASE-20654-1.patch, HBASE-20654-2.patch, > HBASE-20654-3.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497531#comment-16497531 ] liubangchen commented on HBASE-20654: - When hbase as a PAAS service,users can not login any server.But when regionserver restart or crash some region may me in state failed open or failed close ,then client will get exception NotServingRegionException . But it very difficult to find these failed open regions with out use hbck . We hope quickly find these failded open or failed close and show at web console in order to assign these regions again by users . We gather metrics by GangliaSink31 or jmx , and our case as follow: !1.png! logs on server {code:java} 2017-07-08 08:43:54,821 WARN [AM.-pool1-t138] master.RegionStates: Failed to open/close 3ecca5a149b8813ce97cd97629775f07 on emr-10-112-99-101,16010,1497344643126, set to FAILED_CLOSE 2017-07-08 08:43:54,821 WARN [AM.-pool1-t130] master.RegionStates: Failed to open/close 4535a4fb157ccff13e5da275cc79a952 on emr-10-112-99-101,16010,1497344643126, set to FAILED_CLOSE {code} > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: 1.png, HBASE-20654-1.patch, HBASE-20654-2.patch, > HBASE-20654-3.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-20654: Attachment: 1.png > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: 1.png, HBASE-20654-1.patch, HBASE-20654-2.patch, > HBASE-20654-3.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-20654: Attachment: HBASE-20654-3.patch > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-20654-1.patch, HBASE-20654-2.patch, > HBASE-20654-3.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496095#comment-16496095 ] liubangchen commented on HBASE-20654: - When Hbase as cloud product,we need gather many metrics by jmx . regions state info is very important metrics . If expose these regions state info to jxm is very useful. > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-20654-1.patch, HBASE-20654-2.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495057#comment-16495057 ] liubangchen commented on HBASE-20654: - I've already attached the latest patch . Wait for QA to run. Thank you very much. > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-20654-1.patch, HBASE-20654-2.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-20654: Attachment: HBASE-20654-2.patch > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-20654-1.patch, HBASE-20654-2.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494865#comment-16494865 ] liubangchen commented on HBASE-20654: - This is my first independent submission of patchs, and I need your guidance. The exported jmx example is as follows: {code:json} { "beans" : [ { "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", "modelerType" : "Master,sub=AssignmentManager", "tag.regionsOffline" : "default_t2_1b48dede1f20e6d4a61g08499d3sa52i", "tag.regionsOpening" : "", "tag.regionsOpen" : "", "tag.regionsClosing" : "", "tag.regionsClosed" : "default_t1_1b48dede1f20e6d4a61308499b3ba523", "tag.regionsSplitting" : "", "tag.regionsSplit" : "", "tag.regionsFailedOpen" : "", "tag.regionsFailedClose" : "", "tag.regionsMerging" : "", "tag.regionsMerged" : "", "tag.regionsSplittingNew" : "", "tag.Context" : "master", "tag.Hostname" : "LIUBANGCHEN-MB1", "operationCount" : 2, "ritOldestAge" : 300341, "RitDuration_num_ops" : 0, "RitDuration_min" : 0, "RitDuration_max" : 0, "RitDuration_mean" : 0, "RitDuration_25th_percentile" : 0, "RitDuration_median" : 0, "RitDuration_75th_percentile" : 0, "RitDuration_90th_percentile" : 0, "RitDuration_95th_percentile" : 0, "RitDuration_98th_percentile" : 0, "RitDuration_99th_percentile" : 0, "RitDuration_99.9th_percentile" : 0, "ritCountOverThreshold" : 1, "ritCount" : 1 } ] } {code} qyr=Hadoop:service=HBase,name=Master,sub=AssignmentManager > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-20654-1.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494633#comment-16494633 ] liubangchen commented on HBASE-20654: - Code review link : [https://reviews.apache.org/r/67376/diff/1#index_header] Under your suggestions, I modified the code.Could you help me review it? Thanks. > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-20654-1.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-20654: Attachment: (was: HBASE-20654-1.patch) > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-20654-1.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-20654: Attachment: HBASE-20654-1.patch Status: Patch Available (was: Open) > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-20654-1.patch, HBASE-20654-1.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-20654: Attachment: HBASE-20654-1.patch > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > Attachments: HBASE-20654-1.patch, HBASE-20654-1.patch > > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493514#comment-16493514 ] liubangchen commented on HBASE-20654: - Expose metrics to tag of Hadoop:service=HBase,name=Master,sub=AssignmentManager: {code:json} "beans" : [ { "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", "modelerType" : "Master,sub=AssignmentManager", "tag.regionsOffline" : "Namespace_tablename_regionname,Namespace_tablename_regionname", "tag.regionsOpening" : "", "tag.regionsOpen" : "", "tag.regionsClosing" : "", "tag.regionsClosed" : "", "tag.regionsSplitting" : "", "tag.regionsSplit" : "", "tag.regionsFailedOpen" : "", "tag.regionsFailedClose" : "", "tag.regionsMerging" : "", "tag.regionsMerged" : "", "tag.regionsSplittingNew" : "", "ritCount" : 0 } ] } {code} 1. Add metrics tags, add attributes to interface MetricsAssignmentManagerSource {code:java} String REGIONS_STATE_OFFLINE="regionsOffline"; String REGIONS_STATE_OFFLINE_DESC="Regions with state OFFLINE"; String REGIONS_STATE_OPENING="regionsOpening"; String REGIONS_STATE_OPENING_DESC="Regions with state OPENING"; String REGIONS_STATE_OPEN="regionsOpen"; String REGIONS_STATE_OPEN_DESC="Regions with state OPEN"; String REGIONS_STATE_CLOSING="regionsClosing"; String REGIONS_STATE_CLOSING_DESC="Regions with state CLOSING"; String REGIONS_STATE_CLOSED="regionsClosed"; String REGIONS_STATE_CLOSED_DESC="Regions with state CLOSED"; String REGIONS_STATE_SPLITTING="regionsSplitting"; String REGIONS_STATE_SPLITTING_DESC="Regions with state SPLITTING"; String REGIONS_STATE_SPLIT="regionsSplit"; String REGIONS_STATE_SPLIT_DESC="Regions with state SPLIT"; String REGIONS_STATE_FAILED_OPEN="regionsFailedOpen"; String REGIONS_STATE_FAILED_OPEN_DESC="Regions with state failed open"; String REGIONS_STATE_FAILED_CLOSE="regionsFailedClose"; String REGIONS_STATE_FAILED_CLOSE_DESC="Regions with state failed close"; String REGIONS_STATE_MERGING="regionsMerging"; String REGIONS_STATE_MERGING_DESC="Regions with state merging"; String REGIONS_STATE_MERGED="regionsMerged"; String REGIONS_STATE_MERGED_DESC="Regions with state merged"; String REGIONS_STATE_SPLITTING_NEW="regionsSplittingNew"; String REGIONS_STATE_SPLITTING_NEW_DESC="Regions with state"; {code} 2. Modify class MetricsAssignmentManagerSourceImpl {code:java} @Override public void getMetrics(MetricsCollector metricsCollector, boolean all) { MetricsRecordBuilder metricsRecordBuilder = metricsCollector.addRecord(metricsName); if(metricsRecordBuilder!=null){ metricsRecordBuilder.tag(Interns.info(REGIONS_STATE_OFFLINE,REGIONS_STATE_OFFLINE_DESC),metricsAssignmentWrapper.getOfflineRegions()); metricsRegistry.snapshot(metricsRecordBuilder, all); } {code} 3. Add new config is to control the number of region names in each region state. How about naming the config: hbase.assignment.metric.maxmum.regions.in.each.state 4. Get metrics by class MetricsAssignmentWrapperImpl {code:java} private String getRegionsListByState(RegionState.State state) { List regions = new LinkedList(); RegionStates rstates = this.am.getRegionStates(); if (rstates == null) { return ""; } List list = rstates.getRegionsInTransition(); if (list == null || list.isEmpty()) { return ""; } List metalist = new LinkedList(); List datalist = new LinkedList(); int i = 0; for (RegionStates.RegionStateNode rsn : list) { if (rsn.getTable().isSystemTable()) { metalist.add(rsn); } else { datalist.add(rsn); } } datalist.addAll(metalist); for (RegionStates.RegionStateNode rsn : datalist) { if (rsn.getState().equals(state)) { regions.add(String.format("%s_%s_%s", rsn.getTable().getNamespaceAsString(), rsn.getTable().getNameAsString(), rsn.getRegionInfo() == null ? "" : rsn.getRegionInfo().getEncodedName())); i++; } if (i > this.am.getMaxnumRegionInEachState()) { break; } } return StringUtils.join(regions, ","); } {code} [~yuzhih...@gmail.com] Can you give me some suggestions? Let me submit a patch. you can help me review it. thanks. > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the
[jira] [Comment Edited] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492669#comment-16492669 ] liubangchen edited comment on HBASE-20654 at 5/28/18 1:28 PM: -- expose metrics like this: {code} { "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManger", "modelerType" : "Master,sub=AssignmentManger", "tag.Context" : "master", "tag.Hostname" : "10.59.168.84", "ritOldestAge" : 0, "ritCount" : 0, "tag.RegionState.Namespace_Tablename_Regiona":"OFFLINE", "tag.RegionState.Namespace_Tablename_Regionb":"OPEN", "tag.RegionState.Namespace_Tablename_Regionc":"CLOSED", ... {code} Code implementation: 1. Add a method to class MetricsAssignmentManagerSource {code:java} void updateRegionState(String regionname,String state); {code} 2. Add a method to class MetricsAssignmentManagerSourceImpl {code:java} @Override public void updateRegionState(String regionname,String state){ metricsRegistry.tag(regionname,"",state,true); } {code} 3. Add a method to class MetricsAssignmentManager {code:java} public void updateRegionState(String regionname,String state){ assignmentManagerSource.updateRegionState(regionname,state); } {code} 4. Modify the updateRegionsInTransitionMetrics method of class AssignmentManager and add the parameter name hbase.assignment.metric.regionstate.maxmum.expose to control the maximum number of exports [~yuzhih...@gmail.com] What's your opinion? was (Author: liubangchen): expose metrics like this: {code:json} { "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManger", "modelerType" : "Master,sub=AssignmentManger", "tag.Context" : "master", "tag.Hostname" : "10.59.168.84", "ritOldestAge" : 0, "ritCount" : 0, "tag.RegionState.Namespace_Tablename_Regiona":" "OFFLINE", "tag.RegionState.Namespace_Tablename_Regionb":" "OPEN", "tag.RegionState.Namespace_Tablename_Regionc":" "CLOSED", ... {code} Code implementation: 1. Add a method to class MetricsAssignmentManagerSource {code:java} void updateRegionState(String regionname,String state); {code} 2. Add a method to class MetricsAssignmentManagerSourceImpl {code:java} @Override public void updateRegionState(String regionname,String state){ metricsRegistry.tag(regionname,"",state,true); } {code} 3. Add a method to class MetricsAssignmentManager {code:java} public void updateRegionState(String regionname,String state){ assignmentManagerSource.updateRegionState(regionname,state); } {code} 4. Modify the updateRegionsInTransitionMetrics method of class AssignmentManager and add the parameter name hbase.assignment.metric.regionstate.maxmum.expose to control the maximum number of exports [~yuzhih...@gmail.com] What's your opinion? > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492669#comment-16492669 ] liubangchen commented on HBASE-20654: - expose metrics like this: {code:json} { "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManger", "modelerType" : "Master,sub=AssignmentManger", "tag.Context" : "master", "tag.Hostname" : "10.59.168.84", "ritOldestAge" : 0, "ritCount" : 0, "tag.RegionState.Namespace_Tablename_Regiona":" "OFFLINE", "tag.RegionState.Namespace_Tablename_Regionb":" "OPEN", "tag.RegionState.Namespace_Tablename_Regionc":" "CLOSED", ... {code} Code implementation: 1. Add a method to class MetricsAssignmentManagerSource {code:java} void updateRegionState(String regionname,String state); {code} 2. Add a method to class MetricsAssignmentManagerSourceImpl {code:java} @Override public void updateRegionState(String regionname,String state){ metricsRegistry.tag(regionname,"",state,true); } {code} 3. Add a method to class MetricsAssignmentManager {code:java} public void updateRegionState(String regionname,String state){ assignmentManagerSource.updateRegionState(regionname,state); } {code} 4. Modify the updateRegionsInTransitionMetrics method of class AssignmentManager and add the parameter name hbase.assignment.metric.regionstate.maxmum.expose to control the maximum number of exports [~yuzhih...@gmail.com] What's your opinion? > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-20654) Expose regions in transition thru JMX
[ https://issues.apache.org/jira/browse/HBASE-20654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen reassigned HBASE-20654: --- Assignee: liubangchen > Expose regions in transition thru JMX > - > > Key: HBASE-20654 > URL: https://issues.apache.org/jira/browse/HBASE-20654 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: liubangchen >Priority: Major > > Currently only the count of regions in transition is exposed thru JMX. > Here is a sample snippet of the /jmx output: > {code} > { > "beans" : [ { > ... > }, { > "name" : "Hadoop:service=HBase,name=Master,sub=AssignmentManager", > "modelerType" : "Master,sub=AssignmentManager", > "tag.Context" : "master", > ... > "ritCount" : 3 > {code} > It would be desirable to expose region name, state for the regions in > transition as well. > We can place configurable upper bound on the number of entries returned in > case there're a lot of regions in transition. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-16993) BucketCache throw java.io.IOException: Invalid HFile block magic when DATA_BLOCK_ENCODING set to DIFF
[ https://issues.apache.org/jira/browse/HBASE-16993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083485#comment-16083485 ] liubangchen commented on HBASE-16993: - Hi Anoop Sam John,you can prepare that patch,thank you very much > BucketCache throw java.io.IOException: Invalid HFile block magic when > DATA_BLOCK_ENCODING set to DIFF > - > > Key: HBASE-16993 > URL: https://issues.apache.org/jira/browse/HBASE-16993 > Project: HBase > Issue Type: Bug > Components: BucketCache, io >Affects Versions: 1.1.3 > Environment: hbase version 1.1.3 >Reporter: liubangchen >Assignee: liubangchen > Fix For: 2.0.0 > > Attachments: HBASE-16993.000.patch, HBASE-16993.001.patch, > HBASE-16993.master.001.patch, HBASE-16993.master.002.patch, > HBASE-16993.master.003.patch, HBASE-16993.master.004.patch, > HBASE-16993.master.005.patch > > Original Estimate: 336h > Remaining Estimate: 336h > > hbase-site.xml setting > > hbase.bucketcache.bucket.sizes > 16384,32768,40960, > 46000,49152,51200,65536,131072,524288 > > > hbase.bucketcache.size > 16384 > > > hbase.bucketcache.ioengine > offheap > > > hfile.block.cache.size > 0.3 > > > hfile.block.bloom.cacheonwrite > true > > > hbase.rs.cacheblocksonwrite > true > > > hfile.block.index.cacheonwrite > true > n_splits = 200 > create 'usertable',{NAME =>'family', COMPRESSION => 'snappy', VERSIONS => > 1,DATA_BLOCK_ENCODING => 'DIFF',CONFIGURATION => > {'hbase.hregion.memstore.block.multiplier' => 5}},{DURABILITY => > 'SKIP_WAL'},{SPLITS => (1..n_splits).map {|i| > "user#{1000+i*(-1000)/n_splits}"}} > load data > bin/ycsb load hbase10 -P workloads/workloada -p table=usertable -p > columnfamily=family -p fieldcount=10 -p fieldlength=100 -p > recordcount=2 -p insertorder=hashed -p insertstart=0 -p > clientbuffering=true -p durability=SKIP_WAL -threads 20 -s > run > bin/ycsb run hbase10 -P workloads/workloadb -p table=usertable -p > columnfamily=family -p fieldcount=10 -p fieldlength=100 -p > operationcount=2000 -p readallfields=true -p clientbuffering=true -p > requestdistribution=zipfian -threads 10 -s > log info > 2016-11-02 20:20:20,261 ERROR > [RW.default.readRpcServer.handler=36,queue=21,port=6020] bucket.BucketCache: > Failed reading block fdcc7ed6f3b2498b9ef316cc8206c233_44819759 from bucket > cache > java.io.IOException: Invalid HFile block magic: > \x00\x00\x00\x00\x00\x00\x00\x00 > at > org.apache.hadoop.hbase.io.hfile.BlockType.parse(BlockType.java:154) > at org.apache.hadoop.hbase.io.hfile.BlockType.read(BlockType.java:167) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock.(HFileBlock.java:273) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:134) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:121) > at > org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.getBlock(BucketCache.java:427) > at > org.apache.hadoop.hbase.io.hfile.CombinedBlockCache.getBlock(CombinedBlockCache.java:85) > at > org.apache.hadoop.hbase.io.hfile.HFileReaderV2.getCachedBlock(HFileReaderV2.java:266) > at > org.apache.hadoop.hbase.io.hfile.HFileReaderV2.readBlock(HFileReaderV2.java:403) > at > org.apache.hadoop.hbase.io.hfile.HFileBlockIndex$BlockIndexReader.loadDataBlockWithScanInfo(HFileBlockIndex.java:269) > at > org.apache.hadoop.hbase.io.hfile.HFileReaderV2$AbstractScannerV2.seekTo(HFileReaderV2.java:634) > at > org.apache.hadoop.hbase.io.hfile.HFileReaderV2$AbstractScannerV2.seekTo(HFileReaderV2.java:584) > at > org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekAtOrAfter(StoreFileScanner.java:247) > at > org.apache.hadoop.hbase.regionserver.StoreFileScanner.seek(StoreFileScanner.java:156) > at > org.apache.hadoop.hbase.regionserver.StoreScanner.seekScanners(StoreScanner.java:363) > at > org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:217) > at > org.apache.hadoop.hbase.regionserver.HStore.getScanner(HStore.java:2071) > at > org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.(HRegion.java:5369) > at > org.apache.hadoop.hbase.regionserver.HRegion.instantiateRegionScanner(HRegion.java:2546) > at > org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2532) > at > org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2514) > at org.apache.hadoop.hbase.regionserver.HRegion.get(HRegion.java:6558) > at
[jira] [Commented] (HBASE-16993) BucketCache throw java.io.IOException: Invalid HFile block magic when DATA_BLOCK_ENCODING set to DIFF
[ https://issues.apache.org/jira/browse/HBASE-16993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083306#comment-16083306 ] liubangchen commented on HBASE-16993: - Our expected is the offset(the bucketAllocator.allocateBlock return value) close to the len of datablock. {code} long offset = bucketAllocator.allocateBlock(len); BucketEntry bucketEntry = new BucketEntry(offset, len, accessCounter, inMemory); bucketEntry.setDeserialiserReference(data.getDeserializer(), deserialiserMap); try { if (data instanceof HFileBlock) { HFileBlock block = (HFileBlock) data; ByteBuffer sliceBuf = block.getBufferReadOnlyWithHeader(); sliceBuf.rewind(); assert len == sliceBuf.limit() + HFileBlock.EXTRA_SERIALIZATION_SPACE || len == sliceBuf.limit() + block.headerSize() + HFileBlock.EXTRA_SERIALIZATION_SPACE; ByteBuffer extraInfoBuffer = ByteBuffer.allocate(HFileBlock.EXTRA_SERIALIZATION_SPACE); block.serializeExtraInfo(extraInfoBuffer); ioEngine.write(sliceBuf, offset); ioEngine.write(extraInfoBuffer, offset + len - HFileBlock.EXTRA_SERIALIZATION_SPACE); } else { ByteBuffer bb = ByteBuffer.allocate(len); data.serialize(bb); ioEngine.write(bb, offset); } } catch (IOException ioe) { // free it in bucket allocator bucketAllocator.freeBlock(offset); throw ioe; } {code} the len(length of datablock) <= bucket_j, There is no problem with bucket value(s) must be multiples of 256,but if a data block is 45kb and bucket value(s) is [...,32k,48k,] then the datablcok will be in bucket 48k and the offset is multiples of 48k,one block will waster 3kb These are my views,thinks. By the way can u help me to review HBASE-18124? > BucketCache throw java.io.IOException: Invalid HFile block magic when > DATA_BLOCK_ENCODING set to DIFF > - > > Key: HBASE-16993 > URL: https://issues.apache.org/jira/browse/HBASE-16993 > Project: HBase > Issue Type: Bug > Components: BucketCache, io >Affects Versions: 1.1.3 > Environment: hbase version 1.1.3 >Reporter: liubangchen >Assignee: liubangchen > Fix For: 2.0.0 > > Attachments: HBASE-16993.000.patch, HBASE-16993.001.patch, > HBASE-16993.master.001.patch, HBASE-16993.master.002.patch, > HBASE-16993.master.003.patch, HBASE-16993.master.004.patch, > HBASE-16993.master.005.patch > > Original Estimate: 336h > Remaining Estimate: 336h > > hbase-site.xml setting > > hbase.bucketcache.bucket.sizes > 16384,32768,40960, > 46000,49152,51200,65536,131072,524288 > > > hbase.bucketcache.size > 16384 > > > hbase.bucketcache.ioengine > offheap > > > hfile.block.cache.size > 0.3 > > > hfile.block.bloom.cacheonwrite > true > > > hbase.rs.cacheblocksonwrite > true > > > hfile.block.index.cacheonwrite > true > n_splits = 200 > create 'usertable',{NAME =>'family', COMPRESSION => 'snappy', VERSIONS => > 1,DATA_BLOCK_ENCODING => 'DIFF',CONFIGURATION => > {'hbase.hregion.memstore.block.multiplier' => 5}},{DURABILITY => > 'SKIP_WAL'},{SPLITS => (1..n_splits).map {|i| > "user#{1000+i*(-1000)/n_splits}"}} > load data > bin/ycsb load hbase10 -P workloads/workloada -p table=usertable -p > columnfamily=family -p fieldcount=10 -p fieldlength=100 -p > recordcount=2 -p insertorder=hashed -p insertstart=0 -p > clientbuffering=true -p durability=SKIP_WAL -threads 20 -s > run > bin/ycsb run hbase10 -P workloads/workloadb -p table=usertable -p > columnfamily=family -p fieldcount=10 -p fieldlength=100 -p > operationcount=2000 -p readallfields=true -p clientbuffering=true -p > requestdistribution=zipfian -threads 10 -s > log info > 2016-11-02 20:20:20,261 ERROR > [RW.default.readRpcServer.handler=36,queue=21,port=6020] bucket.BucketCache: > Failed reading block fdcc7ed6f3b2498b9ef316cc8206c233_44819759 from bucket > cache > java.io.IOException: Invalid HFile block magic: > \x00\x00\x00\x00\x00\x00\x00\x00 > at > org.apache.hadoop.hbase.io.hfile.BlockType.parse(BlockType.java:154) > at org.apache.hadoop.hbase.io.hfile.BlockType.read(BlockType.java:167) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock.(HFileBlock.java:273) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:134) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:121) > at > org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.getBlock(BucketCache.java:427) > at >
[jira] [Commented] (HBASE-18124) Make Hbase Communication Support Virtual Network
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031113#comment-16031113 ] liubangchen commented on HBASE-18124: - Hi,[~ted_yu], by the way ,why not keep both host(used as vip) and ipc address(used as physical ip address)? > Make Hbase Communication Support Virtual Network > > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode used by name or hostname. > I'm a engineer of cloud computing , and I'm in charge of to make Hbase as a > cloud service. > Our Hbase cloud service architecture shown as follows: 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT > Network Address Translation, vip(Virtual Network Address) to pip > (Physical Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > Vm use vip to communicate with hbase cluster, but hbase have only one > way to communicate with each server using host which is setting by parameters > hbase.regionserver.hostname or hbase.master.hostname. When HMaster startup > will publish master address and meta region server address in zookeeper, > then the address is pip(Physical Network Address) . Because hbase cluster > work in physical network. But the problem is that when vm get the address > from zookeeper is pip, not vip. If I set host as vip, it will has problems > for hbase cluster communication inside. so it needs two ways for > communication setting by parameters. > Solution > 1. protocol extend > change strcut ServerName as > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; //new field > } > {code} > It will be publish in zookeeper. We can choose host_name or name > configured by parameters hbase.client.use.hostname > 2. metatable extend >Add a column to hbase:meta named info:namelocation . So the original > column info:server configured with hbase.regionserver.hostname, and the new > column info:namelocation configured with hbase.regionserver.servername > 3. hbase-server >When regionserver startup, configured hbase.regionserver.hostname as > pip and configured hbase.regionserver.servername as vip. Then > hbase.regionserver.hostname will be writed in ServerName's host_name, and > hbase.regionserver.servername will be writed in ServerName's name.When > hmaster startup, configured hbase.hmaster.hostname as pip and configured > hbase.hmaster.servername as vip. Then hbase.hmaster.hostname will be writed > in ServerName's host_name, and hbase.hmaster.servername will be writed in > ServerName's name. > 4. hbase-client > Add a parameters named hbase.client.use.hostname to use vip or pip. > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (HBASE-17099) Is there a plan to support auth connection by username/password like mysql or redis
[ https://issues.apache.org/jira/browse/HBASE-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen resolved HBASE-17099. - Resolution: Invalid > Is there a plan to support auth connection by username/password like mysql or > redis > --- > > Key: HBASE-17099 > URL: https://issues.apache.org/jira/browse/HBASE-17099 > Project: HBase > Issue Type: Brainstorming > Components: security >Reporter: liubangchen >Priority: Trivial > > Product managers ask our hbase cluster to support auth connection by > username/password. > {code} > private boolean authorizeConnection() throws IOException { > try { > // If auth method is DIGEST, the token was obtained by the > // real user for the effective user, therefore not required to > // authorize real user. doAs is allowed only for simple or kerberos > // authentication > if (user != null && user.getRealUser() != null > && (authMethod != AuthMethod.DIGEST)) { > ProxyUsers.authorize(user, this.getHostAddress(), conf); > } > authorize(user, connectionHeader, getHostInetAddress()); > metrics.authorizationSuccess(); > } catch (AuthorizationException ae) { > if (LOG.isDebugEnabled()) { > LOG.debug("Connection authorization failed: " + ae.getMessage(), > ae); > } > metrics.authorizationFailure(); > setupResponse(authFailedResponse, authFailedCall, > new AccessDeniedException(ae), ae.getMessage()); > responder.doRespond(authFailedCall); > return false; > } > return true; > } > {code} > Whether can add a connectionAuthorrizer in method authorizeConnection of > class RpcServer to auth connection by init the handler from conf. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18124) Make Hbase Communication Support Virtual Network
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Attachment: (was: HBASE-18124.patch) > Make Hbase Communication Support Virtual Network > > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode used by name or hostname. > I'm a engineer of cloud computing , and I'm in charge of to make Hbase as a > cloud service. > Our Hbase cloud service architecture shown as follows: 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT > Network Address Translation, vip(Virtual Network Address) to pip > (Physical Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > Vm use vip to communicate with hbase cluster, but hbase have only one > way to communicate with each server using host which is setting by parameters > hbase.regionserver.hostname or hbase.master.hostname. When HMaster startup > will publish master address and meta region server address in zookeeper, > then the address is pip(Physical Network Address) . Because hbase cluster > work in physical network. But the problem is that when vm get the address > from zookeeper is pip, not vip. If I set host as vip, it will has problems > for hbase cluster communication inside. so it needs two ways for > communication setting by parameters. > Solution > 1. protocol extend > change strcut ServerName as > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; //new field > } > {code} > It will be publish in zookeeper. We can choose host_name or name > configured by parameters hbase.client.use.hostname > 2. metatable extend >Add a column to hbase:meta named info:namelocation . So the original > column info:server configured with hbase.regionserver.hostname, and the new > column info:namelocation configured with hbase.regionserver.servername > 3. hbase-server >When regionserver startup, configured hbase.regionserver.hostname as > pip and configured hbase.regionserver.servername as vip. Then > hbase.regionserver.hostname will be writed in ServerName's host_name, and > hbase.regionserver.servername will be writed in ServerName's name.When > hmaster startup, configured hbase.hmaster.hostname as pip and configured > hbase.hmaster.servername as vip. Then hbase.hmaster.hostname will be writed > in ServerName's host_name, and hbase.hmaster.servername will be writed in > ServerName's name. > 4. hbase-client > Add a parameters named hbase.client.use.hostname to use vip or pip. > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (HBASE-18124) Make Hbase Communication Support Virtual Network
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen resolved HBASE-18124. - Resolution: Duplicate Release Note: supported by HBASE-12954 > Make Hbase Communication Support Virtual Network > > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode used by name or hostname. > I'm a engineer of cloud computing , and I'm in charge of to make Hbase as a > cloud service. > Our Hbase cloud service architecture shown as follows: 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT > Network Address Translation, vip(Virtual Network Address) to pip > (Physical Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > Vm use vip to communicate with hbase cluster, but hbase have only one > way to communicate with each server using host which is setting by parameters > hbase.regionserver.hostname or hbase.master.hostname. When HMaster startup > will publish master address and meta region server address in zookeeper, > then the address is pip(Physical Network Address) . Because hbase cluster > work in physical network. But the problem is that when vm get the address > from zookeeper is pip, not vip. If I set host as vip, it will has problems > for hbase cluster communication inside. so it needs two ways for > communication setting by parameters. > Solution > 1. protocol extend > change strcut ServerName as > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; //new field > } > {code} > It will be publish in zookeeper. We can choose host_name or name > configured by parameters hbase.client.use.hostname > 2. metatable extend >Add a column to hbase:meta named info:namelocation . So the original > column info:server configured with hbase.regionserver.hostname, and the new > column info:namelocation configured with hbase.regionserver.servername > 3. hbase-server >When regionserver startup, configured hbase.regionserver.hostname as > pip and configured hbase.regionserver.servername as vip. Then > hbase.regionserver.hostname will be writed in ServerName's host_name, and > hbase.regionserver.servername will be writed in ServerName's name.When > hmaster startup, configured hbase.hmaster.hostname as pip and configured > hbase.hmaster.servername as vip. Then hbase.hmaster.hostname will be writed > in ServerName's host_name, and hbase.hmaster.servername will be writed in > ServerName's name. > 4. hbase-client > Add a parameters named hbase.client.use.hostname to use vip or pip. > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18124) Make Hbase Communication Support Virtual Network
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Status: Open (was: Patch Available) > Make Hbase Communication Support Virtual Network > > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.patch, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode used by name or hostname. > I'm a engineer of cloud computing , and I'm in charge of to make Hbase as a > cloud service. > Our Hbase cloud service architecture shown as follows: 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT > Network Address Translation, vip(Virtual Network Address) to pip > (Physical Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > Vm use vip to communicate with hbase cluster, but hbase have only one > way to communicate with each server using host which is setting by parameters > hbase.regionserver.hostname or hbase.master.hostname. When HMaster startup > will publish master address and meta region server address in zookeeper, > then the address is pip(Physical Network Address) . Because hbase cluster > work in physical network. But the problem is that when vm get the address > from zookeeper is pip, not vip. If I set host as vip, it will has problems > for hbase cluster communication inside. so it needs two ways for > communication setting by parameters. > Solution > 1. protocol extend > change strcut ServerName as > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; //new field > } > {code} > It will be publish in zookeeper. We can choose host_name or name > configured by parameters hbase.client.use.hostname > 2. metatable extend >Add a column to hbase:meta named info:namelocation . So the original > column info:server configured with hbase.regionserver.hostname, and the new > column info:namelocation configured with hbase.regionserver.servername > 3. hbase-server >When regionserver startup, configured hbase.regionserver.hostname as > pip and configured hbase.regionserver.servername as vip. Then > hbase.regionserver.hostname will be writed in ServerName's host_name, and > hbase.regionserver.servername will be writed in ServerName's name.When > hmaster startup, configured hbase.hmaster.hostname as pip and configured > hbase.hmaster.servername as vip. Then hbase.hmaster.hostname will be writed > in ServerName's host_name, and hbase.hmaster.servername will be writed in > ServerName's name. > 4. hbase-client > Add a parameters named hbase.client.use.hostname to use vip or pip. > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (HBASE-18124) Make Hbase Communication Support Virtual Network
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027286#comment-16027286 ] liubangchen edited comment on HBASE-18124 at 5/27/17 3:26 PM: -- Hi,[~ted_yu],I think this feature is different with HBASE-12954,our requirement is like this: 1. use hbase.regionserver.hostname or hbase.master.hostname to locate server in physical network 2. use other address to locate server in virtual network 3. must vip (virtual ip address ) and pip (physical ip address) to be published in zookeeper I am not good at English,I will modify the description later ,thanks. was (Author: liubangchen): Hi,[~ted_yu],I think this feature is different with HBASE-12954,our requirement is like this: 1. use hbase.regionserver.hostname or hbase.master.hostname or locate server in physical network 2. use other address to locate server in virtual network 3. must vip (virtual ip address ) and pip (physical ip address) to be published in zookeeper I am not good at English,I will modify the description later ,thanks. > Make Hbase Communication Support Virtual Network > > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.patch, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode used by name or hostname. > I'm a engineer of cloud computing , and I'm in charge of to make Hbase as a > cloud service. > Our Hbase cloud service architecture shown as follows: 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT > Network Address Translation, vip(Virtual Network Address) to pip > (Physical Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > Vm use vip to communicate with hbase cluster, but hbase have only one > way to communicate with each server using host which is setting by parameters > hbase.regionserver.hostname or hbase.master.hostname. When HMaster startup > will publish master address and meta region server address in zookeeper, > then the address is pip(Physical Network Address) . Because hbase cluster > work in physical network. But the problem is that when vm get the address > from zookeeper is pip, not vip. If I set host as vip, it will has problems > for hbase cluster communication inside. so it needs two ways for > communication setting by parameters. > Solution > 1. protocol extend > change strcut ServerName as > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; //new field > } > {code} > It will be publish in zookeeper. We can choose host_name or name > configured by parameters hbase.client.use.hostname > 2. metatable extend >Add a column to hbase:meta named info:namelocation . So the original > column info:server configured with hbase.regionserver.hostname, and the new > column info:namelocation configured with hbase.regionserver.servername > 3. hbase-server >When regionserver startup, configured hbase.regionserver.hostname as > pip and configured hbase.regionserver.servername as vip. Then > hbase.regionserver.hostname will be writed in ServerName's host_name, and > hbase.regionserver.servername will be writed in ServerName's name.When > hmaster startup, configured hbase.hmaster.hostname as pip and configured > hbase.hmaster.servername as vip. Then hbase.hmaster.hostname will be writed > in ServerName's host_name, and hbase.hmaster.servername will be writed in > ServerName's name. > 4. hbase-client > Add a parameters named hbase.client.use.hostname to use vip or pip. > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18124) Make Hbase Communication Support Virtual Network
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Description: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode used by name or hostname. I'm a engineer of cloud computing , and I'm in charge of to make Hbase as a cloud service. Our Hbase cloud service architecture shown as follows: 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem Vm use vip to communicate with hbase cluster, but hbase have only one way to communicate with each server using host which is setting by parameters hbase.regionserver.hostname or hbase.master.hostname. When HMaster startup will publish master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) . Because hbase cluster work in physical network. But the problem is that when vm get the address from zookeeper is pip, not vip. If I set host as vip, it will has problems for hbase cluster communication inside. so it needs two ways for communication setting by parameters. Solution 1. protocol extend change strcut ServerName as {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; //new field } {code} It will be publish in zookeeper. We can choose host_name or name configured by parameters hbase.client.use.hostname 2. metatable extend Add a column to hbase:meta named info:namelocation . So the original column info:server configured with hbase.regionserver.hostname, and the new column info:namelocation configured with hbase.regionserver.servername 3. hbase-server When regionserver startup, configured hbase.regionserver.hostname as pip and configured hbase.regionserver.servername as vip. Then hbase.regionserver.hostname will be writed in ServerName's host_name, and hbase.regionserver.servername will be writed in ServerName's name.When hmaster startup, configured hbase.hmaster.hostname as pip and configured hbase.hmaster.servername as vip. Then hbase.hmaster.hostname will be writed in ServerName's host_name, and hbase.hmaster.servername will be writed in ServerName's name. 4. hbase-client Add a parameters named hbase.client.use.hostname to use vip or pip. This patch is base on Hbase-1.3.0 was: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Our Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info:namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code}
[jira] [Updated] (HBASE-18124) Make Hbase Communication Support Virtual Network
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Attachment: HBASE-18124.pdf > Make Hbase Communication Support Virtual Network > > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.patch, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode use by name or hostname. > I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a > cloud service,when we make hbase as a cloud service we need hbase support > other way to support locate hmaster or hregionserver > Our Hbase cloud service architectue shown as follows 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT >Network Address Translation, vip(Virtual Network Address) to pip (Physical > Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > 1. View on vm > On vm side vm use vip to communication,but hbase have only one way > to communication use struct named > ServerName. When Hmaster startup will store master address and meta > region server address in zookeeper, >then the address is pip(Physical Network Address) because hbase > cluster work in physical network . when vm > get the address from zookeeper will not work because vm use vip to > communication,one way to solve this is to > make physical machine host as vip like 192.168.0.1,but is not better to > make this. > 2. View on Physical machine > Physical machine use pip to communication > Solution > 1. protocol extend change proto message to below: > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; > } > {code} > add a filed named name like hdfs’s datablock location > 2. metatable extend >add column to hbase:meta named info:namelocation > 3. hbase-server > add params > {code} > hbase.regionserver.servername > > hbase.regionserver.servername > 10.0.1.1 > > {code} > to regionserver namelocation > add params > {code} >hbase.master.servername > >hbase.master.servername >10.0.1.2 > > {code} >to set master namelocation > 4. hbase-client > add params > {code} > hbase.client.use.hostname > > hbase.client.use.hostname > true > > {code} > to choose which address to use > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18124) Make Hbase Communication Support Virtual Network
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Attachment: (was: HBASE-18124.pdf) > Make Hbase Communication Support Virtual Network > > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.patch > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode use by name or hostname. > I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a > cloud service,when we make hbase as a cloud service we need hbase support > other way to support locate hmaster or hregionserver > Our Hbase cloud service architectue shown as follows 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT >Network Address Translation, vip(Virtual Network Address) to pip (Physical > Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > 1. View on vm > On vm side vm use vip to communication,but hbase have only one way > to communication use struct named > ServerName. When Hmaster startup will store master address and meta > region server address in zookeeper, >then the address is pip(Physical Network Address) because hbase > cluster work in physical network . when vm > get the address from zookeeper will not work because vm use vip to > communication,one way to solve this is to > make physical machine host as vip like 192.168.0.1,but is not better to > make this. > 2. View on Physical machine > Physical machine use pip to communication > Solution > 1. protocol extend change proto message to below: > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; > } > {code} > add a filed named name like hdfs’s datablock location > 2. metatable extend >add column to hbase:meta named info:namelocation > 3. hbase-server > add params > {code} > hbase.regionserver.servername > > hbase.regionserver.servername > 10.0.1.1 > > {code} > to regionserver namelocation > add params > {code} >hbase.master.servername > >hbase.master.servername >10.0.1.2 > > {code} >to set master namelocation > 4. hbase-client > add params > {code} > hbase.client.use.hostname > > hbase.client.use.hostname > true > > {code} > to choose which address to use > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18124) Make Hbase Communication Support Virtual Network
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Summary: Make Hbase Communication Support Virtual Network (was: Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer) > Make Hbase Communication Support Virtual Network > > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.patch, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode use by name or hostname. > I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a > cloud service,when we make hbase as a cloud service we need hbase support > other way to support locate hmaster or hregionserver > Our Hbase cloud service architectue shown as follows 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT >Network Address Translation, vip(Virtual Network Address) to pip (Physical > Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > 1. View on vm > On vm side vm use vip to communication,but hbase have only one way > to communication use struct named > ServerName. When Hmaster startup will store master address and meta > region server address in zookeeper, >then the address is pip(Physical Network Address) because hbase > cluster work in physical network . when vm > get the address from zookeeper will not work because vm use vip to > communication,one way to solve this is to > make physical machine host as vip like 192.168.0.1,but is not better to > make this. > 2. View on Physical machine > Physical machine use pip to communication > Solution > 1. protocol extend change proto message to below: > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; > } > {code} > add a filed named name like hdfs’s datablock location > 2. metatable extend >add column to hbase:meta named info:namelocation > 3. hbase-server > add params > {code} > hbase.regionserver.servername > > hbase.regionserver.servername > 10.0.1.1 > > {code} > to regionserver namelocation > add params > {code} >hbase.master.servername > >hbase.master.servername >10.0.1.2 > > {code} >to set master namelocation > 4. hbase-client > add params > {code} > hbase.client.use.hostname > > hbase.client.use.hostname > true > > {code} > to choose which address to use > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027286#comment-16027286 ] liubangchen edited comment on HBASE-18124 at 5/27/17 7:27 AM: -- Hi,[~ted_yu],I think this feature is different with HBASE-12954,our requirement is like this: 1. use hbase.regionserver.hostname or hbase.master.hostname or locate server in physical network 2. use other address to locate server in virtual network 3. must vip (virtual ip address ) and pip (physical ip address) to be published in zookeeper I am not good at English,I will modify the description later ,thanks. was (Author: liubangchen): Hi,[~ted_yu],I think this feature is different with HBASE-12954,our requirement is like this: 1. use hbase.regionserver.hostname or hbase.master.hostname or locate server in physical network 2. use other address to locate server in virtual network 3. must vip (virtual ip address ) and pip (physical ip address) to be published in zookeeper I am not good at English,I will modify the Description later ,thanks. > Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer > - > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.patch, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode use by name or hostname. > I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a > cloud service,when we make hbase as a cloud service we need hbase support > other way to support locate hmaster or hregionserver > Our Hbase cloud service architectue shown as follows 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT >Network Address Translation, vip(Virtual Network Address) to pip (Physical > Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > 1. View on vm > On vm side vm use vip to communication,but hbase have only one way > to communication use struct named > ServerName. When Hmaster startup will store master address and meta > region server address in zookeeper, >then the address is pip(Physical Network Address) because hbase > cluster work in physical network . when vm > get the address from zookeeper will not work because vm use vip to > communication,one way to solve this is to > make physical machine host as vip like 192.168.0.1,but is not better to > make this. > 2. View on Physical machine > Physical machine use pip to communication > Solution > 1. protocol extend change proto message to below: > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; > } > {code} > add a filed named name like hdfs’s datablock location > 2. metatable extend >add column to hbase:meta named info:namelocation > 3. hbase-server > add params > {code} > hbase.regionserver.servername > > hbase.regionserver.servername > 10.0.1.1 > > {code} > to regionserver namelocation > add params > {code} >hbase.master.servername > >hbase.master.servername >10.0.1.2 > > {code} >to set master namelocation > 4. hbase-client > add params > {code} > hbase.client.use.hostname > > hbase.client.use.hostname > true > > {code} > to choose which address to use > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Description: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Our Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info:namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname hbase.client.use.hostname true {code} to choose which address to use This patch is base on Hbase-1.3.0 was: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Our Hbase cloud service architectue shown as follows {image} 1.jpg {image} 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info:namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname hbase.client.use.hostname true {code} to choose which address to use This patch is base on Hbase-1.3.0 > Add Property name Of
[jira] [Updated] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Description: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Our Hbase cloud service architectue shown as follows {image} 1.jpg {image} 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info:namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname hbase.client.use.hostname true {code} to choose which address to use This patch is base on Hbase-1.3.0 was: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Our Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info:namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname hbase.client.use.hostname true {code} to choose which address to use This patch is base on Hbase-1.3.0 > Add Property name Of
[jira] [Updated] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Description: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Our Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info:namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname hbase.client.use.hostname true {code} to choose which address to use This patch is base on Hbase-1.3.0 was: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Tencent Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info:namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname hbase.client.use.hostname true {code} to choose which address to use This patch is base on Hbase-1.3.0 > Add Property name Of Strcut
[jira] [Updated] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Attachment: HBASE-18124.pdf > Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer > - > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.patch, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode use by name or hostname. > I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a > cloud service,when we make hbase as a cloud service we need hbase support > other way to support locate hmaster or hregionserver > Tencent Hbase cloud service architectue shown as follows 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT >Network Address Translation, vip(Virtual Network Address) to pip (Physical > Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > 1. View on vm > On vm side vm use vip to communication,but hbase have only one way > to communication use struct named > ServerName. When Hmaster startup will store master address and meta > region server address in zookeeper, >then the address is pip(Physical Network Address) because hbase > cluster work in physical network . when vm > get the address from zookeeper will not work because vm use vip to > communication,one way to solve this is to > make physical machine host as vip like 192.168.0.1,but is not better to > make this. > 2. View on Physical machine > Physical machine use pip to communication > Solution > 1. protocol extend change proto message to below: > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; > } > {code} > add a filed named name like hdfs’s datablock location > 2. metatable extend >add column to hbase:meta named info:namelocation > 3. hbase-server > add params > {code} > hbase.regionserver.servername > > hbase.regionserver.servername > 10.0.1.1 > > {code} > to regionserver namelocation > add params > {code} >hbase.master.servername > >hbase.master.servername >10.0.1.2 > > {code} >to set master namelocation > 4. hbase-client > add params > {code} > hbase.client.use.hostname > > hbase.client.use.hostname > true > > {code} > to choose which address to use > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Attachment: (was: HBASE-18124.pdf) > Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer > - > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.patch > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode use by name or hostname. > I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a > cloud service,when we make hbase as a cloud service we need hbase support > other way to support locate hmaster or hregionserver > Tencent Hbase cloud service architectue shown as follows 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT >Network Address Translation, vip(Virtual Network Address) to pip (Physical > Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > 1. View on vm > On vm side vm use vip to communication,but hbase have only one way > to communication use struct named > ServerName. When Hmaster startup will store master address and meta > region server address in zookeeper, >then the address is pip(Physical Network Address) because hbase > cluster work in physical network . when vm > get the address from zookeeper will not work because vm use vip to > communication,one way to solve this is to > make physical machine host as vip like 192.168.0.1,but is not better to > make this. > 2. View on Physical machine > Physical machine use pip to communication > Solution > 1. protocol extend change proto message to below: > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; > } > {code} > add a filed named name like hdfs’s datablock location > 2. metatable extend >add column to hbase:meta named info:namelocation > 3. hbase-server > add params > {code} > hbase.regionserver.servername > > hbase.regionserver.servername > 10.0.1.1 > > {code} > to regionserver namelocation > add params > {code} >hbase.master.servername > >hbase.master.servername >10.0.1.2 > > {code} >to set master namelocation > 4. hbase-client > add params > {code} > hbase.client.use.hostname > > hbase.client.use.hostname > true > > {code} > to choose which address to use > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Description: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Tencent Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info:namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname hbase.client.use.hostname true {code} to choose which address to use This patch is base on Hbase-1.3.0 was: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of tencent cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Tencent Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info:namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname hbase.client.use.hostname true {code} to choose which address to use This patch is base on Hbase-1.3.0 > Add Property name Of
[jira] [Commented] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027292#comment-16027292 ] liubangchen commented on HBASE-18124: - our requirement is like hdfs datanode block location ,for ex: Name: 10.11.9.130:4001 (10.11.9.130) Hostname: 10.11.9.130 Decommission Status : Normal which address to use rpc call thought parameter dfs.datanode.use.datanode.hostname false use name and true use hostname > Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer > - > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.patch, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode use by name or hostname. > I’m a engineer of tencent cloud computing , and I’m in charge of to make > Hbase as a cloud service,when we make hbase as a cloud service we need hbase > support other way to support locate hmaster or hregionserver > Tencent Hbase cloud service architectue shown as follows 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT >Network Address Translation, vip(Virtual Network Address) to pip (Physical > Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > 1. View on vm > On vm side vm use vip to communication,but hbase have only one way > to communication use struct named > ServerName. When Hmaster startup will store master address and meta > region server address in zookeeper, >then the address is pip(Physical Network Address) because hbase > cluster work in physical network . when vm > get the address from zookeeper will not work because vm use vip to > communication,one way to solve this is to > make physical machine host as vip like 192.168.0.1,but is not better to > make this. > 2. View on Physical machine > Physical machine use pip to communication > Solution > 1. protocol extend change proto message to below: > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; > } > {code} > add a filed named name like hdfs’s datablock location > 2. metatable extend >add column to hbase:meta named info:namelocation > 3. hbase-server > add params > {code} > hbase.regionserver.servername > > hbase.regionserver.servername > 10.0.1.1 > > {code} > to regionserver namelocation > add params > {code} >hbase.master.servername > >hbase.master.servername >10.0.1.2 > > {code} >to set master namelocation > 4. hbase-client > add params > {code} > hbase.client.use.hostname > > hbase.client.use.hostname > true > > {code} > to choose which address to use > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027286#comment-16027286 ] liubangchen commented on HBASE-18124: - Hi,[~ted_yu],I think this feature is different with HBASE-12954,our requirement is like this: 1. use hbase.regionserver.hostname or hbase.master.hostname or locate server in physical network 2. use other address to locate server in virtual network 3. must vip (virtual ip address ) and pip (physical ip address) to be published in zookeeper I am not good at English,I will modify the Description later ,thanks. > Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer > - > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.patch, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode use by name or hostname. > I’m a engineer of tencent cloud computing , and I’m in charge of to make > Hbase as a cloud service,when we make hbase as a cloud service we need hbase > support other way to support locate hmaster or hregionserver > Tencent Hbase cloud service architectue shown as follows 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT >Network Address Translation, vip(Virtual Network Address) to pip (Physical > Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > 1. View on vm > On vm side vm use vip to communication,but hbase have only one way > to communication use struct named > ServerName. When Hmaster startup will store master address and meta > region server address in zookeeper, >then the address is pip(Physical Network Address) because hbase > cluster work in physical network . when vm > get the address from zookeeper will not work because vm use vip to > communication,one way to solve this is to > make physical machine host as vip like 192.168.0.1,but is not better to > make this. > 2. View on Physical machine > Physical machine use pip to communication > Solution > 1. protocol extend change proto message to below: > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; > } > {code} > add a filed named name like hdfs’s datablock location > 2. metatable extend >add column to hbase:meta named info:namelocation > 3. hbase-server > add params > {code} > hbase.regionserver.servername > > hbase.regionserver.servername > 10.0.1.1 > > {code} > to regionserver namelocation > add params > {code} >hbase.master.servername > >hbase.master.servername >10.0.1.2 > > {code} >to set master namelocation > 4. hbase-client > add params > {code} > hbase.client.use.hostname > > hbase.client.use.hostname > true > > {code} > to choose which address to use > This patch is base on Hbase-1.3.0 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Description: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of tencent cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Tencent Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info:namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname hbase.client.use.hostname true {code} to choose which address to use This patch is base on Hbase-1.3.0 was: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of tencent cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Tencent Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname hbase.client.use.hostname true {code} to choose which address to use This patch is base on Hbase-1.3.0 > Add Property
[jira] [Updated] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Description: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of tencent cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Tencent Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname hbase.client.use.hostname true {code} to choose which address to use This patch is base on Hbase-1.3.0 was: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of tencent cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Tencent Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname {code} to choose which address to use This patch is base on Hbase-1.3.0 > Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer >
[jira] [Updated] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Description: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of tencent cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Tencent Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info namelocation 3. hbase-server add params {code} hbase.regionserver.servername hbase.regionserver.servername 10.0.1.1 {code} to regionserver namelocation add params {code} hbase.master.servername hbase.master.servername 10.0.1.2 {code} to set master namelocation 4. hbase-client add params {code} hbase.client.use.hostname {code} to choose which address to use This patch is base on Hbase-1.3.0 was: Hbase only have one way to locate hmaster or hregionserver not like hdfs has two way to locate datanode use by name or hostname. I’m a engineer of tencent cloud computing , and I’m in charge of to make Hbase as a cloud service,when we make hbase as a cloud service we need hbase support other way to support locate hmaster or hregionserver Tencent Hbase cloud service architectue shown as follows 1.jpg 1.VM User’s Hbase client work in vm and use virtual ip address to access hbase cluster. 2.NAT Network Address Translation, vip(Virtual Network Address) to pip (Physical Network Address) 3. HbaseCluster Service HbaseCluster Service work in physical network Problem 1. View on vm On vm side vm use vip to communication,but hbase have only one way to communication use struct named ServerName. When Hmaster startup will store master address and meta region server address in zookeeper, then the address is pip(Physical Network Address) because hbase cluster work in physical network . when vm get the address from zookeeper will not work because vm use vip to communication,one way to solve this is to make physical machine host as vip like 192.168.0.1,but is not better to make this. 2. View on Physical machine Physical machine use pip to communication Solution 1. protocol extend change proto message to below: {code} message ServerName { required string host_name = 1; optional uint32 port = 2; optional uint64 start_code = 3; optional string name=4; } {code} add a filed named name like hdfs’s datablock location 2. metatable extend add column to hbase:meta named info namelocation 3. hbase-server add params hbase.regionserver.servername to regionserver namelocation add params hbase.master.servername to set master namelocation 4. hbase-client add params hbase.client.use.hostname to choose which address to use > Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer > - > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen >
[jira] [Updated] (HBASE-18124) Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer
[ https://issues.apache.org/jira/browse/HBASE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubangchen updated HBASE-18124: Attachment: HBASE-18124.patch > Add Property name Of Strcut ServerName To Locate HMaster Or HRegionServer > - > > Key: HBASE-18124 > URL: https://issues.apache.org/jira/browse/HBASE-18124 > Project: HBase > Issue Type: New Feature > Components: Client, hbase, master >Reporter: liubangchen >Assignee: liubangchen > Attachments: 1.jpg, HBASE-18124.patch, HBASE-18124.pdf > > > Hbase only have one way to locate hmaster or hregionserver not like hdfs has > two way to locate datanode use by name or hostname. > I’m a engineer of tencent cloud computing , and I’m in charge of to make > Hbase as a cloud service,when we make hbase as a cloud service we need hbase > support other way to support locate hmaster or hregionserver > Tencent Hbase cloud service architectue shown as follows 1.jpg > 1.VM > User’s Hbase client work in vm and use virtual ip address to access hbase > cluster. > 2.NAT >Network Address Translation, vip(Virtual Network Address) to pip (Physical > Network Address) > 3. HbaseCluster Service > HbaseCluster Service work in physical network > Problem > 1. View on vm > On vm side vm use vip to communication,but hbase have only one way > to communication use struct named > ServerName. When Hmaster startup will store master address and meta > region server address in zookeeper, >then the address is pip(Physical Network Address) because hbase > cluster work in physical network . when vm > get the address from zookeeper will not work because vm use vip to > communication,one way to solve this is to > make physical machine host as vip like 192.168.0.1,but is not better to > make this. > 2. View on Physical machine > Physical machine use pip to communication > Solution > 1. protocol extend change proto message to below: > {code} > message ServerName { > required string host_name = 1; > optional uint32 port = 2; > optional uint64 start_code = 3; > optional string name=4; > } > {code} > add a filed named name like hdfs’s datablock location > 2. metatable extend >add column to hbase:meta named info namelocation > 3. hbase-server > add params hbase.regionserver.servername to regionserver namelocation > add params hbase.master.servername to set master namelocation > 4. hbase-client > add params hbase.client.use.hostname to choose which address to use -- This message was sent by Atlassian JIRA (v6.3.15#6346)