[jira] [Commented] (HBASE-22440) HRegionServer#getWalGroupsReplicationStatus() throws NPE
[ https://issues.apache.org/jira/browse/HBASE-22440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843130#comment-16843130 ] puleya7 commented on HBASE-22440: - Thanks for review, [~Apache9]. It is better. Updated the master patch. > HRegionServer#getWalGroupsReplicationStatus() throws NPE > > > Key: HBASE-22440 > URL: https://issues.apache.org/jira/browse/HBASE-22440 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.4 >Reporter: puleya7 >Assignee: puleya7 >Priority: Major > Attachments: HBASE-22440.branch-1.001.patch, > HBASE-22440.branch-2.patch, HBASE-22440.master.002.patch, > HBASE-22440.master.patch > > > Precondition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > > Open the rs page of the master throws NullPointException, because > replicationSourceHandler never initialized. > HRegionServer#getWalGroupsReplicationStatus() need check [is HMaster && CAN'T > host user region]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22440) HRegionServer#getWalGroupsReplicationStatus() throws NPE
[ https://issues.apache.org/jira/browse/HBASE-22440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] puleya7 updated HBASE-22440: Attachment: HBASE-22440.master.002.patch > HRegionServer#getWalGroupsReplicationStatus() throws NPE > > > Key: HBASE-22440 > URL: https://issues.apache.org/jira/browse/HBASE-22440 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.4 >Reporter: puleya7 >Assignee: puleya7 >Priority: Major > Attachments: HBASE-22440.branch-1.001.patch, > HBASE-22440.branch-2.patch, HBASE-22440.master.002.patch, > HBASE-22440.master.patch > > > Precondition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > > Open the rs page of the master throws NullPointException, because > replicationSourceHandler never initialized. > HRegionServer#getWalGroupsReplicationStatus() need check [is HMaster && CAN'T > host user region]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22440) HRegionServer#getWalGroupsReplicationStatus() throws NPE
[ https://issues.apache.org/jira/browse/HBASE-22440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] puleya7 updated HBASE-22440: Description: Precondition: hbase.balancer.tablesOnMaster = true hbase.balancer.tablesOnMaster.systemTablesOnly = true Open the rs page of the master throws NullPointException, because replicationSourceHandler never initialized. HRegionServer#getWalGroupsReplicationStatus() need check [is HMaster && CAN'T host user region]. was: Condition: hbase.balancer.tablesOnMaster = true hbase.balancer.tablesOnMaster.systemTablesOnly = true Open the rs page of the master throws NullPointException, because replicationSourceHandler never initialized. HRegionServer#getWalGroupsReplicationStatus() need check isMasterNoTableOrSystemTableOnly. > HRegionServer#getWalGroupsReplicationStatus() throws NPE > > > Key: HBASE-22440 > URL: https://issues.apache.org/jira/browse/HBASE-22440 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.4 >Reporter: puleya7 >Assignee: puleya7 >Priority: Major > Attachments: HBASE-22440.branch-1.001.patch, > HBASE-22440.branch-2.patch, HBASE-22440.master.patch > > > Precondition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > > Open the rs page of the master throws NullPointException, because > replicationSourceHandler never initialized. > HRegionServer#getWalGroupsReplicationStatus() need check [is HMaster && CAN'T > host user region]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22440) HRegionServer#getWalGroupsReplicationStatus() throws NPE
[ https://issues.apache.org/jira/browse/HBASE-22440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] puleya7 updated HBASE-22440: Attachment: HBASE-22440.branch-2.patch > HRegionServer#getWalGroupsReplicationStatus() throws NPE > > > Key: HBASE-22440 > URL: https://issues.apache.org/jira/browse/HBASE-22440 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.4 >Reporter: puleya7 >Assignee: puleya7 >Priority: Major > Attachments: HBASE-22440.branch-1.001.patch, > HBASE-22440.branch-2.patch, HBASE-22440.master.patch > > > Condition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > > Open the rs page of the master throws NullPointException, because > replicationSourceHandler never initialized. > HRegionServer#getWalGroupsReplicationStatus() need check > isMasterNoTableOrSystemTableOnly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22440) HRegionServer#getWalGroupsReplicationStatus() throws NPE
[ https://issues.apache.org/jira/browse/HBASE-22440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] puleya7 updated HBASE-22440: Attachment: HBASE-22440.branch-1.001.patch > HRegionServer#getWalGroupsReplicationStatus() throws NPE > > > Key: HBASE-22440 > URL: https://issues.apache.org/jira/browse/HBASE-22440 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.4 >Reporter: puleya7 >Assignee: puleya7 >Priority: Major > Attachments: HBASE-22440.branch-1.001.patch, HBASE-22440.master.patch > > > Condition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > > Open the rs page of the master throws NullPointException, because > replicationSourceHandler never initialized. > HRegionServer#getWalGroupsReplicationStatus() need check > isMasterNoTableOrSystemTableOnly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22440) HRegionServer#getWalGroupsReplicationStatus() throws NPE
[
https://issues.apache.org/jira/browse/HBASE-22440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842003#comment-16842003
]
puleya7 commented on HBASE-22440:
-
{code:java}
2019-05-17 15:03:49,080 WARN [qtp1577067350-284] servlet.ServletHandler:
/rs-status
java.lang.NullPointerException
at
org.apache.hadoop.hbase.regionserver.HRegionServer.getWalGroupsReplicationStatus(HRegionServer.java:3012)
at
org.apache.hadoop.hbase.tmpl.regionserver.ReplicationStatusTmplImpl.renderNoFlush(ReplicationStatusTmplImpl.java:38)
at
org.apache.hadoop.hbase.tmpl.regionserver.ReplicationStatusTmpl.renderNoFlush(ReplicationStatusTmpl.java:119)
at
org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmplImpl.renderNoFlush(RSStatusTmplImpl.java:160)
at
org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmpl.renderNoFlush(RSStatusTmpl.java:226)
at
org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmpl.render(RSStatusTmpl.java:217)
at
org.apache.hadoop.hbase.regionserver.RSStatusServlet.doGet(RSStatusServlet.java:58)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780)
at
org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
at
org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:48)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
at
org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1391)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
at
org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
at
org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:49)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767)
at
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548)
at
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226)
at
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180)
at
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513)
at
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
at
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112)
at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119)
at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134)
at org.eclipse.jetty.server.Server.handle(Server.java:539)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333)
at
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
at
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108)
at
org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93)
at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303)
at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148)
at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136)
at
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671)
at
org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589)
at java.base/java.lang.Thread.run(Thread.java:834)
{code}
> HRegionServer#getWalGroupsReplicationStatus() throws NPE
>
>
> Key: HBASE-22440
> URL: https://issues.apache.org/jira/browse/HBASE-22440
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.1.4
>Reporter: pule
[jira] [Updated] (HBASE-22440) HRegionServer#getWalGroupsReplicationStatus() throws NPE
[ https://issues.apache.org/jira/browse/HBASE-22440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] puleya7 updated HBASE-22440: Assignee: puleya7 Attachment: HBASE-22440.master.patch Status: Patch Available (was: Open) > HRegionServer#getWalGroupsReplicationStatus() throws NPE > > > Key: HBASE-22440 > URL: https://issues.apache.org/jira/browse/HBASE-22440 > Project: HBase > Issue Type: Bug >Affects Versions: 2.1.4 >Reporter: puleya7 >Assignee: puleya7 >Priority: Major > Attachments: HBASE-22440.master.patch > > > Condition: > hbase.balancer.tablesOnMaster = true > hbase.balancer.tablesOnMaster.systemTablesOnly = true > > Open the rs page of the master throws NullPointException, because > replicationSourceHandler never initialized. > HRegionServer#getWalGroupsReplicationStatus() need check > isMasterNoTableOrSystemTableOnly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22440) HRegionServer#getWalGroupsReplicationStatus() throws NPE
puleya7 created HBASE-22440: --- Summary: HRegionServer#getWalGroupsReplicationStatus() throws NPE Key: HBASE-22440 URL: https://issues.apache.org/jira/browse/HBASE-22440 Project: HBase Issue Type: Bug Affects Versions: 2.1.4 Reporter: puleya7 Condition: hbase.balancer.tablesOnMaster = true hbase.balancer.tablesOnMaster.systemTablesOnly = true Open the rs page of the master throws NullPointException, because replicationSourceHandler never initialized. HRegionServer#getWalGroupsReplicationStatus() need check isMasterNoTableOrSystemTableOnly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22392) Remove extra/useless +
[
https://issues.apache.org/jira/browse/HBASE-22392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837389#comment-16837389
]
puleya7 commented on HBASE-22392:
-
Thanks [~Jan Hentschel]
> Remove extra/useless +
> ---
>
> Key: HBASE-22392
> URL: https://issues.apache.org/jira/browse/HBASE-22392
> Project: HBase
> Issue Type: Improvement
>Reporter: puleya7
>Assignee: puleya7
>Priority: Trivial
> Attachments: HBASE-22392.branch-1.001.patch,
> HBASE-22392.master.001.patch
>
>
> {code:java}
> [HRegion.java]
> LOG.info("Flushing " + + storesToFlush.size() + "/" + stores.size() + "
> column families," +
> [HStore.java]
> ", sequenceid=" + +storeFile.getReader().getSequenceID() + ", filesize="
> [LoadIncrementalHFiles.java]
> LOG.info("Split occurred while grouping HFiles, retry attempt " + +count + "
> with " +{code}
>
> Has 3 extra/useless "+".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HBASE-22392) Remove extra/useless +
[
https://issues.apache.org/jira/browse/HBASE-22392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 reassigned HBASE-22392:
---
Assignee: puleya7
> Remove extra/useless +
> ---
>
> Key: HBASE-22392
> URL: https://issues.apache.org/jira/browse/HBASE-22392
> Project: HBase
> Issue Type: Improvement
>Reporter: puleya7
>Assignee: puleya7
>Priority: Trivial
> Attachments: HBASE-22392.branch-1.001.patch,
> HBASE-22392.master.001.patch
>
>
> {code:java}
> [HRegion.java]
> LOG.info("Flushing " + + storesToFlush.size() + "/" + stores.size() + "
> column families," +
> [HStore.java]
> ", sequenceid=" + +storeFile.getReader().getSequenceID() + ", filesize="
> [LoadIncrementalHFiles.java]
> LOG.info("Split occurred while grouping HFiles, retry attempt " + +count + "
> with " +{code}
>
> Has 3 extra/useless "+".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22392) Remove extra/useless +
[
https://issues.apache.org/jira/browse/HBASE-22392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837066#comment-16837066
]
puleya7 commented on HBASE-22392:
-
branch-1 has't
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/LoadIncrementalHFiles.java
> Remove extra/useless +
> ---
>
> Key: HBASE-22392
> URL: https://issues.apache.org/jira/browse/HBASE-22392
> Project: HBase
> Issue Type: Improvement
>Reporter: puleya7
>Assignee: puleya7
>Priority: Trivial
> Attachments: HBASE-22392.branch-1.001.patch,
> HBASE-22392.master.001.patch
>
>
> {code:java}
> [HRegion.java]
> LOG.info("Flushing " + + storesToFlush.size() + "/" + stores.size() + "
> column families," +
> [HStore.java]
> ", sequenceid=" + +storeFile.getReader().getSequenceID() + ", filesize="
> [LoadIncrementalHFiles.java]
> LOG.info("Split occurred while grouping HFiles, retry attempt " + +count + "
> with " +{code}
>
> Has 3 extra/useless "+".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22392) Remove extra/useless +
[
https://issues.apache.org/jira/browse/HBASE-22392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22392:
Attachment: HBASE-22392.branch-1.001.patch
> Remove extra/useless +
> ---
>
> Key: HBASE-22392
> URL: https://issues.apache.org/jira/browse/HBASE-22392
> Project: HBase
> Issue Type: Improvement
>Reporter: puleya7
>Priority: Trivial
> Attachments: HBASE-22392.branch-1.001.patch,
> HBASE-22392.master.001.patch
>
>
> {code:java}
> [HRegion.java]
> LOG.info("Flushing " + + storesToFlush.size() + "/" + stores.size() + "
> column families," +
> [HStore.java]
> ", sequenceid=" + +storeFile.getReader().getSequenceID() + ", filesize="
> [LoadIncrementalHFiles.java]
> LOG.info("Split occurred while grouping HFiles, retry attempt " + +count + "
> with " +{code}
>
> Has 3 extra/useless "+".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22392) Remove extra/useless +
[
https://issues.apache.org/jira/browse/HBASE-22392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22392:
Attachment: HBASE-22392.master.001.patch
Status: Patch Available (was: Open)
> Remove extra/useless +
> ---
>
> Key: HBASE-22392
> URL: https://issues.apache.org/jira/browse/HBASE-22392
> Project: HBase
> Issue Type: Improvement
>Reporter: puleya7
>Priority: Trivial
> Attachments: HBASE-22392.master.001.patch
>
>
> {code:java}
> [HRegion.java]
> LOG.info("Flushing " + + storesToFlush.size() + "/" + stores.size() + "
> column families," +
> [HStore.java]
> ", sequenceid=" + +storeFile.getReader().getSequenceID() + ", filesize="
> [LoadIncrementalHFiles.java]
> LOG.info("Split occurred while grouping HFiles, retry attempt " + +count + "
> with " +{code}
>
> Has 3 extra/useless "+".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22392) Remove extra/useless +
puleya7 created HBASE-22392:
---
Summary: Remove extra/useless +
Key: HBASE-22392
URL: https://issues.apache.org/jira/browse/HBASE-22392
Project: HBase
Issue Type: Improvement
Reporter: puleya7
{code:java}
[HRegion.java]
LOG.info("Flushing " + + storesToFlush.size() + "/" + stores.size() + " column
families," +
[HStore.java]
", sequenceid=" + +storeFile.getReader().getSequenceID() + ", filesize="
[LoadIncrementalHFiles.java]
LOG.info("Split occurred while grouping HFiles, retry attempt " + +count + "
with " +{code}
Has 3 extra/useless "+".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
[
https://issues.apache.org/jira/browse/HBASE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22367:
Attachment: HBASE-22367.branch-1.patch
Status: Patch Available (was: In Progress)
> Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses
> if hitCount is not 0
>
>
> Key: HBASE-22367
> URL: https://issues.apache.org/jira/browse/HBASE-22367
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.2.12, 2.1.4, 1.3.4, 1.4.10, 1.5.1
>Reporter: puleya7
>Assignee: puleya7
>Priority: Minor
> Attachments: HBASE-22367.branch-1.patch, HBASE-22367.master.patch,
> hits.is.0.png, hits.not.0.png
>
>
>
> LruBlockCache#logStats()
> {code:java}
> "hitRatio=" + (stats.getHitCount() == 0 ? "0" :
> (StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
> "cachingAccesses="
> {code}
> if hitCount is not 0, the log will have 2 commas between hitRatio and
> cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work started] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
[
https://issues.apache.org/jira/browse/HBASE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-22367 started by puleya7.
---
> Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses
> if hitCount is not 0
>
>
> Key: HBASE-22367
> URL: https://issues.apache.org/jira/browse/HBASE-22367
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.4.10, 1.3.4, 2.1.4, 1.2.12, 1.5.1
>Reporter: puleya7
>Assignee: puleya7
>Priority: Minor
> Attachments: HBASE-22367.master.patch, hits.is.0.png, hits.not.0.png
>
>
>
> LruBlockCache#logStats()
> {code:java}
> "hitRatio=" + (stats.getHitCount() == 0 ? "0" :
> (StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
> "cachingAccesses="
> {code}
> if hitCount is not 0, the log will have 2 commas between hitRatio and
> cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
[
https://issues.apache.org/jira/browse/HBASE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 reassigned HBASE-22367:
---
Assignee: puleya7
> Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses
> if hitCount is not 0
>
>
> Key: HBASE-22367
> URL: https://issues.apache.org/jira/browse/HBASE-22367
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.4.10, 1.3.4, 2.1.4, 1.2.12, 1.5.1
>Reporter: puleya7
>Assignee: puleya7
>Priority: Minor
> Attachments: HBASE-22367.master.patch, hits.is.0.png, hits.not.0.png
>
>
>
> LruBlockCache#logStats()
> {code:java}
> "hitRatio=" + (stats.getHitCount() == 0 ? "0" :
> (StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
> "cachingAccesses="
> {code}
> if hitCount is not 0, the log will have 2 commas between hitRatio and
> cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
[
https://issues.apache.org/jira/browse/HBASE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22367:
Attachment: hits.not.0.png
> Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses
> if hitCount is not 0
>
>
> Key: HBASE-22367
> URL: https://issues.apache.org/jira/browse/HBASE-22367
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.4.10, 1.3.4, 2.1.4, 1.2.12, 1.5.1
>Reporter: puleya7
>Priority: Minor
> Attachments: HBASE-22367.master.patch, hits.is.0.png, hits.not.0.png
>
>
>
> LruBlockCache#logStats()
> {code:java}
> "hitRatio=" + (stats.getHitCount() == 0 ? "0" :
> (StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
> "cachingAccesses="
> {code}
> if hitCount is not 0, the log will have 2 commas between hitRatio and
> cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
[
https://issues.apache.org/jira/browse/HBASE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22367:
Attachment: hits.is.0.png
> Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses
> if hitCount is not 0
>
>
> Key: HBASE-22367
> URL: https://issues.apache.org/jira/browse/HBASE-22367
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.4.10, 1.3.4, 2.1.4, 1.2.12, 1.5.1
>Reporter: puleya7
>Priority: Minor
> Attachments: HBASE-22367.master.patch, hits.is.0.png, hits.not.0.png
>
>
>
> LruBlockCache#logStats()
> {code:java}
> "hitRatio=" + (stats.getHitCount() == 0 ? "0" :
> (StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
> "cachingAccesses="
> {code}
> if hitCount is not 0, the log will have 2 commas between hitRatio and
> cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (HBASE-22339) BucketCache capacity limit may be wrong
[
https://issues.apache.org/jira/browse/HBASE-22339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 resolved HBASE-22339.
-
Resolution: Not A Problem
> BucketCache capacity limit may be wrong
> ---
>
> Key: HBASE-22339
> URL: https://issues.apache.org/jira/browse/HBASE-22339
> Project: HBase
> Issue Type: Improvement
> Components: BucketCache
>Reporter: puleya7
>Priority: Trivial
> Labels: cache
>
> In the constructor of BC, the capacity limit looks like 32TB, code as follow:
>
> {code:java}
> long blockNumCapacity = capacity / blockSize;
> if (blockNumCapacity >= Integer.MAX_VALUE) {
> // Enough for about 32TB of cache!
> throw new IllegalArgumentException("Cache capacity is too large, only
> support 32TB now");
> }
> {code}
> Default blockSize is 64*1024
> Integer.MAX_VALUE is 2147483647
> blockNumCapacity >= Integer.MAX_VALUE means capacity >= 127.99TB, not 32TB.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
[
https://issues.apache.org/jira/browse/HBASE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22367:
Attachment: HBASE-22367.master.patch
> Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses
> if hitCount is not 0
>
>
> Key: HBASE-22367
> URL: https://issues.apache.org/jira/browse/HBASE-22367
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.4.10, 1.3.4, 2.1.4, 1.2.12, 1.5.1
>Reporter: puleya7
>Priority: Minor
> Attachments: HBASE-22367.master.patch
>
>
>
> LruBlockCache#logStats()
> {code:java}
> "hitRatio=" + (stats.getHitCount() == 0 ? "0" :
> (StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
> "cachingAccesses="
> {code}
> if hitCount is not 0, the log will have 2 commas between hitRatio and
> cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
[
https://issues.apache.org/jira/browse/HBASE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22367:
Attachment: (was: HBASE-22367.patch)
> Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses
> if hitCount is not 0
>
>
> Key: HBASE-22367
> URL: https://issues.apache.org/jira/browse/HBASE-22367
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.4.10, 1.3.4, 2.1.4, 1.2.12, 1.5.1
>Reporter: puleya7
>Priority: Minor
> Attachments: HBASE-22367.master.patch
>
>
>
> LruBlockCache#logStats()
> {code:java}
> "hitRatio=" + (stats.getHitCount() == 0 ? "0" :
> (StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
> "cachingAccesses="
> {code}
> if hitCount is not 0, the log will have 2 commas between hitRatio and
> cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
[
https://issues.apache.org/jira/browse/HBASE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833660#comment-16833660
]
puleya7 commented on HBASE-22367:
-
similar to HBASE-8404
> Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses
> if hitCount is not 0
>
>
> Key: HBASE-22367
> URL: https://issues.apache.org/jira/browse/HBASE-22367
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.4.10, 1.3.4, 2.1.4, 1.2.12, 1.5.1
>Reporter: puleya7
>Priority: Minor
> Attachments: HBASE-22367.patch
>
>
>
> LruBlockCache#logStats()
> {code:java}
> "hitRatio=" + (stats.getHitCount() == 0 ? "0" :
> (StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
> "cachingAccesses="
> {code}
> if hitCount is not 0, the log will have 2 commas between hitRatio and
> cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
puleya7 created HBASE-22367:
---
Summary: Extra commas in LruBlockCache.logStats between hitRatio
and cachingAccesses if hitCount is not 0
Key: HBASE-22367
URL: https://issues.apache.org/jira/browse/HBASE-22367
Project: HBase
Issue Type: Improvement
Components: BlockCache
Affects Versions: 1.2.12, 2.1.4, 1.3.4, 1.4.10, 1.5.1
Reporter: puleya7
LruBlockCache#logStats()
{code:java}
"hitRatio=" + (stats.getHitCount() == 0 ? "0" :
(StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
"cachingAccesses="
{code}
if hitCount is not 0, the log will have 2 commas between hitRatio and
cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
[
https://issues.apache.org/jira/browse/HBASE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22367:
Attachment: (was: HBASE-22367)
> Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses
> if hitCount is not 0
>
>
> Key: HBASE-22367
> URL: https://issues.apache.org/jira/browse/HBASE-22367
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.4.10, 1.3.4, 2.1.4, 1.2.12, 1.5.1
>Reporter: puleya7
>Priority: Minor
>
>
> LruBlockCache#logStats()
> {code:java}
> "hitRatio=" + (stats.getHitCount() == 0 ? "0" :
> (StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
> "cachingAccesses="
> {code}
> if hitCount is not 0, the log will have 2 commas between hitRatio and
> cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
[
https://issues.apache.org/jira/browse/HBASE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22367:
Attachment: HBASE-22367
> Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses
> if hitCount is not 0
>
>
> Key: HBASE-22367
> URL: https://issues.apache.org/jira/browse/HBASE-22367
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.4.10, 1.3.4, 2.1.4, 1.2.12, 1.5.1
>Reporter: puleya7
>Priority: Minor
>
>
> LruBlockCache#logStats()
> {code:java}
> "hitRatio=" + (stats.getHitCount() == 0 ? "0" :
> (StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
> "cachingAccesses="
> {code}
> if hitCount is not 0, the log will have 2 commas between hitRatio and
> cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22367) Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses if hitCount is not 0
[
https://issues.apache.org/jira/browse/HBASE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22367:
Attachment: HBASE-22367.patch
> Extra commas in LruBlockCache.logStats between hitRatio and cachingAccesses
> if hitCount is not 0
>
>
> Key: HBASE-22367
> URL: https://issues.apache.org/jira/browse/HBASE-22367
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache
>Affects Versions: 1.4.10, 1.3.4, 2.1.4, 1.2.12, 1.5.1
>Reporter: puleya7
>Priority: Minor
> Attachments: HBASE-22367.patch
>
>
>
> LruBlockCache#logStats()
> {code:java}
> "hitRatio=" + (stats.getHitCount() == 0 ? "0" :
> (StringUtils.formatPercent(stats.getHitRatio(), 2)+ ", ")) + ", " +
> "cachingAccesses="
> {code}
> if hitCount is not 0, the log will have 2 commas between hitRatio and
> cachingAccesses
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22339) BucketCache capacity limit may be wrong
[
https://issues.apache.org/jira/browse/HBASE-22339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833529#comment-16833529
]
puleya7 commented on HBASE-22339:
-
I don't want to, [~openinx]. I just think the exception msg is not rigorous
enough.
The value of blockNumCapacity used to be capacity/16384, and 32TB msg was
correct. It changed to capacity/blockSize since HBASE-10138.
Maybe we should make the msg more precise.
> BucketCache capacity limit may be wrong
> ---
>
> Key: HBASE-22339
> URL: https://issues.apache.org/jira/browse/HBASE-22339
> Project: HBase
> Issue Type: Improvement
> Components: BucketCache
>Reporter: puleya7
>Priority: Trivial
> Labels: cache
>
> In the constructor of BC, the capacity limit looks like 32TB, code as follow:
>
> {code:java}
> long blockNumCapacity = capacity / blockSize;
> if (blockNumCapacity >= Integer.MAX_VALUE) {
> // Enough for about 32TB of cache!
> throw new IllegalArgumentException("Cache capacity is too large, only
> support 32TB now");
> }
> {code}
> Default blockSize is 64*1024
> Integer.MAX_VALUE is 2147483647
> blockNumCapacity >= Integer.MAX_VALUE means capacity >= 127.99TB, not 32TB.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22339) BucketCache capacity limit may be wrong
[
https://issues.apache.org/jira/browse/HBASE-22339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830180#comment-16830180
]
puleya7 commented on HBASE-22339:
-
I'm not very confident about this problem. Am I made a mistake?:)
> BucketCache capacity limit may be wrong
> ---
>
> Key: HBASE-22339
> URL: https://issues.apache.org/jira/browse/HBASE-22339
> Project: HBase
> Issue Type: Improvement
> Components: BucketCache
>Reporter: puleya7
>Priority: Trivial
>
> In the constructor of BC, the capacity limit looks like 32TB, code as follow:
>
> {code:java}
> long blockNumCapacity = capacity / blockSize;
> if (blockNumCapacity >= Integer.MAX_VALUE) {
> // Enough for about 32TB of cache!
> throw new IllegalArgumentException("Cache capacity is too large, only
> support 32TB now");
> }
> {code}
> Default blockSize is 64*1024
> Integer.MAX_VALUE is 2147483647
> blockNumCapacity >= Integer.MAX_VALUE means capacity >= 127.99TB, not 32TB.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (HBASE-22339) BucketCache capacity limit may be wrong
[
https://issues.apache.org/jira/browse/HBASE-22339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 reopened HBASE-22339:
-
> BucketCache capacity limit may be wrong
> ---
>
> Key: HBASE-22339
> URL: https://issues.apache.org/jira/browse/HBASE-22339
> Project: HBase
> Issue Type: Improvement
> Components: BucketCache
>Reporter: puleya7
>Priority: Trivial
>
> In the constructor of BC, the capacity limit looks like 32TB, code as follow:
>
> {code:java}
> long blockNumCapacity = capacity / blockSize;
> if (blockNumCapacity >= Integer.MAX_VALUE) {
> // Enough for about 32TB of cache!
> throw new IllegalArgumentException("Cache capacity is too large, only
> support 32TB now");
> }
> {code}
> Default blockSize is 64*1024
> Integer.MAX_VALUE is 2147483647
> blockNumCapacity >= Integer.MAX_VALUE means capacity >= 127.99TB, not 32TB.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22339) BucketCache capacity limit may be wrong
[
https://issues.apache.org/jira/browse/HBASE-22339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22339:
Description:
In the constructor of BC, the capacity limit looks like 32TB, code as follow:
{code:java}
long blockNumCapacity = capacity / blockSize;
if (blockNumCapacity >= Integer.MAX_VALUE) {
// Enough for about 32TB of cache!
throw new IllegalArgumentException("Cache capacity is too large, only support
32TB now");
}
{code}
Default blockSize is 64*1024
Integer.MAX_VALUE is 2147483647
blockNumCapacity >= Integer.MAX_VALUE means capacity >= 127.99TB, not 32TB.
Component/s: BucketCache
Summary: BucketCache capacity limit may be wrong (was: mistake)
> BucketCache capacity limit may be wrong
> ---
>
> Key: HBASE-22339
> URL: https://issues.apache.org/jira/browse/HBASE-22339
> Project: HBase
> Issue Type: Improvement
> Components: BucketCache
>Reporter: puleya7
>Priority: Trivial
>
> In the constructor of BC, the capacity limit looks like 32TB, code as follow:
>
> {code:java}
> long blockNumCapacity = capacity / blockSize;
> if (blockNumCapacity >= Integer.MAX_VALUE) {
> // Enough for about 32TB of cache!
> throw new IllegalArgumentException("Cache capacity is too large, only
> support 32TB now");
> }
> {code}
> Default blockSize is 64*1024
> Integer.MAX_VALUE is 2147483647
> blockNumCapacity >= Integer.MAX_VALUE means capacity >= 127.99TB, not 32TB.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (HBASE-22339) mistake
[ https://issues.apache.org/jira/browse/HBASE-22339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] puleya7 resolved HBASE-22339. - Resolution: Fixed > mistake > --- > > Key: HBASE-22339 > URL: https://issues.apache.org/jira/browse/HBASE-22339 > Project: HBase > Issue Type: Improvement >Reporter: puleya7 >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22339) mistake
[
https://issues.apache.org/jira/browse/HBASE-22339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22339:
Priority: Trivial (was: Minor)
Description: (was:
{code:java}
BucketCache#constructor()：
long blockNumCapacity = capacity / blockSize;
if (blockNumCapacity >= Integer.MAX_VALUE) {
// Enough for about 32TB of cache!
throw new IllegalArgumentException("Cache capacity is too large, only support
32TB now");
}
{code}
default blockSize is 64*1024
blockNumCapacity >= Integer.MAX_VALUE means capacity >= 127.99TB, not 32TB)
Component/s: (was: BucketCache)
Summary: mistake (was: BC capacity is not limited to 32TB)
> mistake
> ---
>
> Key: HBASE-22339
> URL: https://issues.apache.org/jira/browse/HBASE-22339
> Project: HBase
> Issue Type: Improvement
>Reporter: puleya7
>Priority: Trivial
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22339) mistake
[ https://issues.apache.org/jira/browse/HBASE-22339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] puleya7 updated HBASE-22339: Attachment: (was: HBASE-22339.patch) > mistake > --- > > Key: HBASE-22339 > URL: https://issues.apache.org/jira/browse/HBASE-22339 > Project: HBase > Issue Type: Improvement >Reporter: puleya7 >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22339) BC capacity is not limited to 32TB
[
https://issues.apache.org/jira/browse/HBASE-22339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
puleya7 updated HBASE-22339:
Attachment: HBASE-22339.patch
> BC capacity is not limited to 32TB
> --
>
> Key: HBASE-22339
> URL: https://issues.apache.org/jira/browse/HBASE-22339
> Project: HBase
> Issue Type: Improvement
> Components: BucketCache
>Reporter: puleya7
>Priority: Minor
> Attachments: HBASE-22339.patch
>
>
>
> {code:java}
> BucketCache#constructor()：
> long blockNumCapacity = capacity / blockSize;
> if (blockNumCapacity >= Integer.MAX_VALUE) {
> // Enough for about 32TB of cache!
> throw new IllegalArgumentException("Cache capacity is too large, only
> support 32TB now");
> }
> {code}
>
> default blockSize is 64*1024
> blockNumCapacity >= Integer.MAX_VALUE means capacity >= 127.99TB, not 32TB
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (HBASE-22339) BC capacity is not limited to 32TB
puleya7 created HBASE-22339:
---
Summary: BC capacity is not limited to 32TB
Key: HBASE-22339
URL: https://issues.apache.org/jira/browse/HBASE-22339
Project: HBase
Issue Type: Improvement
Components: BucketCache
Reporter: puleya7
{code:java}
BucketCache#constructor()：
long blockNumCapacity = capacity / blockSize;
if (blockNumCapacity >= Integer.MAX_VALUE) {
// Enough for about 32TB of cache!
throw new IllegalArgumentException("Cache capacity is too large, only support
32TB now");
}
{code}
default blockSize is 64*1024
blockNumCapacity >= Integer.MAX_VALUE means capacity >= 127.99TB, not 32TB
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (HBASE-22273) Include queuetime in the condition of reponseTooSlow
[ https://issues.apache.org/jira/browse/HBASE-22273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] puleya7 resolved HBASE-22273. - Resolution: Not A Problem > Include queuetime in the condition of reponseTooSlow > > > Key: HBASE-22273 > URL: https://issues.apache.org/jira/browse/HBASE-22273 > Project: HBase > Issue Type: Improvement > Components: logging, regionserver >Reporter: puleya7 >Priority: Minor > Attachments: HBASE-22273.patch > > > I think the condition of responseTooSlow should include queuetime, > occasionally requests queued too much due to bad callqueue config, but there > is no slow log because processingTime is short. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22273) Include queuetime in the condition of reponseTooSlow
[
https://issues.apache.org/jira/browse/HBASE-22273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822384#comment-16822384
]
puleya7 commented on HBASE-22273:
-
{code:java}
boolean queueTooLong = (qTime > warnQueueTime && warnQueueTime > -1);
if (tooSlow || tooLarge || queueTooLong) {
logResponse();
}{code}
Looks bad.:)
If slow queue happened, there won't be only one request, Most logs will be
useless.
> Include queuetime in the condition of reponseTooSlow
>
>
> Key: HBASE-22273
> URL: https://issues.apache.org/jira/browse/HBASE-22273
> Project: HBase
> Issue Type: Improvement
> Components: logging, regionserver
>Reporter: puleya7
>Priority: Minor
> Attachments: HBASE-22273.patch
>
>
> I think the condition of responseTooSlow should include queuetime,
> occasionally requests queued too much due to bad callqueue config, but there
> is no slow log because processingTime is short.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22273) Include queuetime in the condition of reponseTooSlow
[ https://issues.apache.org/jira/browse/HBASE-22273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] puleya7 updated HBASE-22273: Attachment: HBASE-22273.patch > Include queuetime in the condition of reponseTooSlow > > > Key: HBASE-22273 > URL: https://issues.apache.org/jira/browse/HBASE-22273 > Project: HBase > Issue Type: Improvement > Components: logging, regionserver >Reporter: puleya7 >Priority: Minor > Attachments: HBASE-22273.patch > > > I think the condition of responseTooSlow should include queuetime, > occasionally requests queued too much due to bad callqueue config, but there > is no slow log because processingTime is short. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22273) Include queuetime in the condition of reponseTooSlow
puleya7 created HBASE-22273: --- Summary: Include queuetime in the condition of reponseTooSlow Key: HBASE-22273 URL: https://issues.apache.org/jira/browse/HBASE-22273 Project: HBase Issue Type: Improvement Components: logging, regionserver Reporter: puleya7 I think the condition of responseTooSlow should include queuetime, occasionally requests queued too much due to bad callqueue config, but there is no slow log because processingTime is short. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22270) master's jmx.clusterRequests could be negative in branch-1
puleya7 created HBASE-22270: --- Summary: master's jmx.clusterRequests could be negative in branch-1 Key: HBASE-22270 URL: https://issues.apache.org/jira/browse/HBASE-22270 Project: HBase Issue Type: Bug Components: master, regionserver Affects Versions: 1.2.12, 1.3.4, 1.4.9 Reporter: puleya7 In 1.x branch, regionserver could report a negative (overflow) requestCount to master, causing the master's jmx.clusterRequests to become smaller even negative HBASE-12444 fixed, but missed a little when backport to branch-1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
