Re: [PR] HBASE-28389 HBase backup yarn queue parameter ignored [hbase]

2024-07-29 Thread via GitHub


Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257476559

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 43s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 10s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 18s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 14s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 56s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 57s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 19s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 19s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 14s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 58s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  11m 27s |  |  hbase-backup in the patch 
passed.  |
   |  |   |  32m 26s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6130/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6130 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 7f39f84c6acc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / a5cf8972d7c1f6139595e72c7aefbf32e06eaef7 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6130/1/testReport/
 |
   | Max. process+thread count | 3710 (vs. ulimit of 3) |
   | modules | C: hbase-backup U: hbase-backup |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6130/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28389 HBase backup yarn queue parameter ignored [hbase]

2024-07-29 Thread via GitHub


Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257474705

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 20s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  8s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 22s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 17s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 30s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 21s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 21s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 15s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 36s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  10m 40s |  |  hbase-backup in the patch 
passed.  |
   |  |   |  30m 35s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6130/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6130 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux e4c3fd1a7bb8 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / a5cf8972d7c1f6139595e72c7aefbf32e06eaef7 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6130/1/testReport/
 |
   | Max. process+thread count | 3182 (vs. ulimit of 3) |
   | modules | C: hbase-backup U: hbase-backup |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6130/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28389 HBase backup yarn queue parameter ignored [hbase]

2024-07-29 Thread via GitHub


Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257474240

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 42s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 38s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 19s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 15s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 59s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 30s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 18s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 18s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 14s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m  1s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  11m 55s |  |  hbase-backup in the patch 
passed.  |
   |  |   |  30m  2s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6130/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6130 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux d6bfaca083af 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / a5cf8972d7c1f6139595e72c7aefbf32e06eaef7 |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6130/1/testReport/
 |
   | Max. process+thread count | 3410 (vs. ulimit of 3) |
   | modules | C: hbase-backup U: hbase-backup |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6130/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28389 HBase backup yarn queue parameter ignored [hbase]

2024-07-29 Thread via GitHub


Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257472872

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 48s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  5s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 30s |  |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotbugs  |   0m 34s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   0m 46s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 27s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 27s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   0m 40s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  15m 39s |  |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 44s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 11s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  28m 30s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6130/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6130 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux be2d5f8823d2 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 
12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / a5cf8972d7c1f6139595e72c7aefbf32e06eaef7 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 83 (vs. ulimit of 3) |
   | modules | C: hbase-backup U: hbase-backup |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6130/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28389 HBase backup yarn queue parameter ignored [hbase]

2024-07-29 Thread via GitHub


2005hithlj commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257444254

   @DieterDP-ng  @Apache9   Could you take a look? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] HBASE-28389 HBase backup yarn queue parameter ignored [hbase]

2024-07-29 Thread via GitHub


2005hithlj opened a new pull request, #6130:
URL: https://github.com/apache/hbase/pull/6130

   https://issues.apache.org/jira/browse/HBASE-28389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2.5) [hbase]

2024-07-29 Thread via GitHub


Apache9 merged PR #6123:
URL: https://github.com/apache/hbase/pull/6123


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28754 verify the first argument passed to compaction_switch [hbase]

2024-07-29 Thread via GitHub


Apache9 commented on PR #6119:
URL: https://github.com/apache/hbase/pull/6119#issuecomment-2257370244

   Can we add a UT to verify the added code actually works?
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28758 Remove the aarch64 profile [hbase]

2024-07-29 Thread via GitHub


Apache9 merged PR #6128:
URL: https://github.com/apache/hbase/pull/6128


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-29 Thread via GitHub


Apache9 commented on code in PR #6129:
URL: https://github.com/apache/hbase/pull/6129#discussion_r1696193548


##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java:
##
@@ -471,9 +476,10 @@ public ServerOperation(RemoteProcedure remoteProcedure, 
long procId, Class rs
   this.rsProcData = rsProcData;
 }
 
-public RemoteProcedureRequest buildRequest() {
+public RemoteProcedureRequest buildRequestWithMasterStartCode(long 
masterStartCode) {

Review Comment:
   Do not need to change the method I suppose.



##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:
##
@@ -2567,6 +2573,17 @@ public ReportProcedureDoneResponse 
reportProcedureDone(RpcController controller,
 return ReportProcedureDoneResponse.getDefaultInstance();
   }
 
+  private void throwOnOldMasterStartCode(Stream masterStartCodeStream)

Review Comment:
   Could use LongStream here, but for me I prefer we log more about the 
procedures here, like which procedure's master start code is greater than 
current master's start code, and also log the start codes for better debugging.



##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java:
##
@@ -93,11 +93,14 @@ class PostOpenDeployContext {
 private final HRegion region;
 private final long openProcId;
 private final long masterSystemTime;
+private final long masterStartCode;

Review Comment:
   Better add some comments or give it a more clear name so developers will 
know that this is the start code of the master which scheduled this procedure, 
for fencing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-29 Thread via GitHub


Apache-HBase commented on PR #6129:
URL: https://github.com/apache/hbase/pull/6129#issuecomment-2257344128

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 40s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 56s |  |  master passed  |
   | +1 :green_heart: |  compile  |   1m 59s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 59s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 20s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  1s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  0s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  0s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 59s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 18s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 38s |  |  hbase-protocol-shaded in the 
patch passed.  |
   | +1 :green_heart: |  unit  |   1m 36s |  |  hbase-client in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 222m 12s |  |  hbase-server in the patch 
passed.  |
   |  |   | 253m  6s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6129 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 7c4b9dcca2c1 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 
12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 2a4203f6fcb63b4563ea660fb03b0b9648b944ac |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/2/testReport/
 |
   | Max. process+thread count | 5722 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-29 Thread via GitHub


Apache-HBase commented on PR #6129:
URL: https://github.com/apache/hbase/pull/6129#issuecomment-2257161403

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 26s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  buf  |   0m  0s |  |  buf was not available.  |
   | +0 :ok: |  buf  |   0m  0s |  |  buf was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  1s |  |  master passed  |
   | +1 :green_heart: |  compile  |   4m 23s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 57s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   4m 31s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 43s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  0s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 24s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   4m 24s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 24s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 56s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   4m 56s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  11m 23s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  hbaseprotoc  |   1m 33s |  |  the patch passed  |
   | +1 :green_heart: |  spotless  |   0m 43s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 24s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  49m  6s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6129 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat 
hbaseprotoc |
   | uname | Linux 51007c278fa7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 2a4203f6fcb63b4563ea660fb03b0b9648b944ac |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 86 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-29 Thread via GitHub


Apache-HBase commented on PR #6129:
URL: https://github.com/apache/hbase/pull/6129#issuecomment-2257107545

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 39s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  9s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  |  master passed  |
   | +1 :green_heart: |  compile  |   1m 59s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m  0s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 21s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 52s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  0s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  0s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 59s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 20s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 38s |  |  hbase-protocol-shaded in the 
patch passed.  |
   | +1 :green_heart: |  unit  |   1m 37s |  |  hbase-client in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 223m 39s |  |  hbase-server in the patch 
passed.  |
   |  |   | 254m 35s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6129 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux a2f3b35df3e9 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 
12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / c3e35e1214d9d294a84bbdcdac6157a7874a4dce |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/1/testReport/
 |
   | Max. process+thread count | 5531 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-29 Thread via GitHub


Apache-HBase commented on PR #6129:
URL: https://github.com/apache/hbase/pull/6129#issuecomment-2256677851

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 27s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  buf  |   0m  0s |  |  buf was not available.  |
   | +0 :ok: |  buf  |   0m  0s |  |  buf was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  9s |  |  master passed  |
   | +1 :green_heart: |  compile  |   4m 24s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 57s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   4m 39s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 45s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  2s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 21s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   4m 21s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 21s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 58s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   4m 49s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  11m 41s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  hbaseprotoc  |   1m 32s |  |  the patch passed  |
   | +1 :green_heart: |  spotless  |   0m 42s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 25s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  50m  5s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6129 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat 
hbaseprotoc |
   | uname | Linux b3f783cab393 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / c3e35e1214d9d294a84bbdcdac6157a7874a4dce |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 86 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] HBASE-28690 added masterStartCode as fencing token for remote procedures [hbase]

2024-07-29 Thread via GitHub


Umeshkumar9414 opened a new pull request, #6129:
URL: https://github.com/apache/hbase/pull/6129

   masterStartCode as a fencing token for remote procedures
   There are 3 flows that I checked regionOpen, regionClose, and other remote 
Procedures. In might not be needed in the third flow but I added 
masterStartCode in all three.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28758 Remove the aarch64 profile [hbase]

2024-07-29 Thread via GitHub


Apache-HBase commented on PR #6128:
URL: https://github.com/apache/hbase/pull/6128#issuecomment-2256259093

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 54s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 32s |  |  master passed  |
   | +1 :green_heart: |  compile  |   3m 23s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   3m 15s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   7m 30s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 11s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 50s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   7m 21s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 301m 11s |  |  root in the patch passed.  |
   |  |   | 345m 11s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6128/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6128 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux d637c5ac1a4c 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 
12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / ca3c1e9ad24c42389895efed41971d9b32327426 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6128/1/testReport/
 |
   | Max. process+thread count | 8768 (vs. ulimit of 3) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6128/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28758 Remove the aarch64 profile [hbase]

2024-07-29 Thread via GitHub


Apache-HBase commented on PR #6128:
URL: https://github.com/apache/hbase/pull/6128#issuecomment-2255604790

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 54s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 34s |  |  master passed  |
   | +1 :green_heart: |  compile  |  11m 23s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 52s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 57s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  11m 56s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |  11m 56s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  xmllint  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  hadoopcheck  |  15m 31s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   1m 19s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 26s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  58m 23s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6128/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6128 |
   | Optional Tests | dupname asflicense javac codespell detsecrets xmllint 
hadoopcheck spotless compile |
   | uname | Linux 53b576f2aafa 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 
12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / ca3c1e9ad24c42389895efed41971d9b32327426 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 191 (vs. ulimit of 3) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6128/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28587 Remove deprecated methods in Cell [hbase]

2024-07-29 Thread via GitHub


Apache-HBase commented on PR #6125:
URL: https://github.com/apache/hbase/pull/6125#issuecomment-2255504700

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 52s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 16s |  |  master passed  |
   | +1 :green_heart: |  compile  |   2m 50s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m 38s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 35s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 19s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 59s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 59s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 29s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 54s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   3m 28s |  |  hbase-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   2m 33s |  |  hbase-client in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 284m  3s |  |  hbase-server in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  25m 12s |  |  hbase-mapreduce in the patch 
passed.  |
   |  |   | 352m 27s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6125/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6125 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 1fc4a7fb5fdb 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / d3d3f32e3bc3aa6110c287161492b94dc60800fc |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6125/2/testReport/
 |
   | Max. process+thread count | 5067 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-client hbase-server hbase-mapreduce U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6125/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE [hbase]

2024-07-29 Thread via GitHub


NihalJain commented on PR #6127:
URL: https://github.com/apache/hbase/pull/6127#issuecomment-2255130959

   > This is good for review, except licensing changes, if any, need to analyse!
   
   Just verified, we do not need any licensing changes as apparently ruby 
licensing is already in place: 
https://github.com/ruby/irb/blob/v1.4.2/LICENSE.txt is already there in our 
LICENSE.txt: 
https://github.com/apache/hbase/blob/836f2d9a5b3ae013ecd84efb457bf7ff20cdd997/LICENSE.txt#L617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28587 Remove deprecated methods in Cell [hbase]

2024-07-28 Thread via GitHub


Apache-HBase commented on PR #6125:
URL: https://github.com/apache/hbase/pull/6125#issuecomment-2254941500

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 26s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 14s |  |  master passed  |
   | +1 :green_heart: |  compile  |   5m  5s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 15s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   3m 16s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 44s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  1s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 57s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 57s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   1m 15s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   3m 41s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  11m 27s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 43s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 33s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  47m 40s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6125/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6125 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux be179573fcbf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / d3d3f32e3bc3aa6110c287161492b94dc60800fc |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 85 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-client hbase-server hbase-mapreduce U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6125/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28584 RS SIGSEGV under heavy replication load [hbase]

2024-07-28 Thread via GitHub


virajjasani commented on code in PR #6124:
URL: https://github.com/apache/hbase/pull/6124#discussion_r1694486251


##
hbase-common/src/main/java/org/apache/hadoop/hbase/PrivateCellUtil.java:
##
@@ -2261,6 +2261,18 @@ public static int writeFlatKey(ExtendedCell cell, 
OutputStream out) throws IOExc
   + Bytes.SIZEOF_BYTE;
   }
 
+  /**
+   * Deep clones the given cell if the cell supports deep cloning
+   * @param cell the cell to be cloned
+   * @return the cloned cell

Review Comment:
   nit: javadoc to include `@throws`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE [hbase]

2024-07-28 Thread via GitHub


Apache-HBase commented on PR #6127:
URL: https://github.com/apache/hbase/pull/6127#issuecomment-2254781762

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 35s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  6s |  |  master passed  |
   | +1 :green_heart: |  compile  |   2m 12s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   2m 19s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 26s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  1s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 19s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 23s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 301m 35s |  |  root in the patch passed.  |
   |  |   | 335m 24s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6127/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6127 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 67cf6d6fda85 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 879fd86be33979ab0c8b6b64f902ef2c07b3aa26 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6127/1/testReport/
 |
   | Max. process+thread count | 8833 (vs. ulimit of 3) |
   | modules | C: hbase-shell . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6127/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE [hbase]

2024-07-28 Thread via GitHub


Apache-HBase commented on PR #6127:
URL: https://github.com/apache/hbase/pull/6127#issuecomment-2254639789

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 37s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  6s |  |  master passed  |
   | +1 :green_heart: |  compile  |   8m  8s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 45s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 57s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   8m  7s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   8m  7s |  |  the patch passed  |
   | -0 :warning: |  blanks  |   0m  0s | 
[/blanks-eol.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6127/1/artifact/yetus-general-check/output/blanks-eol.txt)
 |  The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix 
<>. Refer https://git-scm.com/docs/git-apply  |
   | -0 :warning: |  rubocop  |   0m  3s | 
[/results-rubocop.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6127/1/artifact/yetus-general-check/output/results-rubocop.txt)
 |  The patch generated 17 new + 23 unchanged - 22 fixed = 40 total (was 45)  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  hadoopcheck  |  10m 46s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 44s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 23s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  42m 26s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6127/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6127 |
   | Optional Tests | dupname asflicense javac codespell detsecrets rubocop 
spotless xmllint hadoopcheck compile |
   | uname | Linux 7d84631ce7e3 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 
22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 879fd86be33979ab0c8b6b64f902ef2c07b3aa26 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 190 (vs. ulimit of 3) |
   | modules | C: hbase-shell . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6127/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 rubocop=1.37.1 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE [hbase]

2024-07-28 Thread via GitHub


NihalJain commented on code in PR #6127:
URL: https://github.com/apache/hbase/pull/6127#discussion_r1694314177


##
pom.xml:
##
@@ -859,7 +859,7 @@
 2.1.1
 2.3.2
 3.0.1-b08
-9.3.13.0
+9.4.8.0

Review Comment:
   jcoding and joni changes were not needed, hence no change around that here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE [hbase]

2024-07-28 Thread via GitHub


NihalJain commented on PR #6127:
URL: https://github.com/apache/hbase/pull/6127#issuecomment-2254626442

   This is good for review, except licensing changes, if any, need to analyse!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE [hbase]

2024-07-28 Thread via GitHub


NihalJain commented on PR #6127:
URL: https://github.com/apache/hbase/pull/6127#issuecomment-2254626078

   Please see https://issues.apache.org/jira/browse/HBASE-28250 for RCA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28729 Change the generic type of List in InternalScanner.next [hbase]

2024-07-28 Thread via GitHub


Apache-HBase commented on PR #6126:
URL: https://github.com/apache/hbase/pull/6126#issuecomment-2254618663

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   2m 50s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  1s |  |  master passed  |
   | +1 :green_heart: |  compile  |   1m 31s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 54s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 37s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 50s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 31s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 31s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 54s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 31s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 206m  4s |  |  hbase-server in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  18m 40s |  |  hbase-mapreduce in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   1m 50s |  |  hbase-examples in the patch 
passed.  |
   |  |   | 256m  9s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6126/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6126 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 69e57356377f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 4e456876e3b4f4f00f36301e4358b63a7acba1d4 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6126/1/testReport/
 |
   | Max. process+thread count | 5159 (vs. ulimit of 3) |
   | modules | C: hbase-server hbase-mapreduce hbase-examples U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6126/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28587 Remove deprecated methods in Cell [hbase]

2024-07-28 Thread via GitHub


Apache-HBase commented on PR #6125:
URL: https://github.com/apache/hbase/pull/6125#issuecomment-2254610199

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 36s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  9s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  0s |  |  master passed  |
   | +1 :green_heart: |  compile  |   2m  6s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m 23s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 19s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  5s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  5s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 22s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 17s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 18s |  |  hbase-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   1m 36s |  |  hbase-client in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 230m 59s |  |  hbase-server in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  22m  5s |  |  hbase-mapreduce in the patch 
passed.  |
   |  |   | 287m 23s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6125/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6125 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux f597db0d05e3 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 
12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 55d661345dbac7423d542a6baa2542512820cf7a |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6125/1/testReport/
 |
   | Max. process+thread count | 4890 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-client hbase-server hbase-mapreduce U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6125/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28729 Change the generic type of List in InternalScanner.next [hbase]

2024-07-28 Thread via GitHub


Apache-HBase commented on PR #6126:
URL: https://github.com/apache/hbase/pull/6126#issuecomment-2254562208

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 31s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  2s |  |  master passed  |
   | +1 :green_heart: |  compile  |   4m  0s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 55s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   2m 27s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 43s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 59s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 59s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 35s | 
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6126/1/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
 |  hbase-server: The patch generated 2 new + 57 unchanged - 2 fixed = 59 total 
(was 59)  |
   | +1 :green_heart: |  spotbugs  |   2m 47s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  10m 54s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 25s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  41m 47s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6126/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6126 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux e9a0ce89fa10 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 4e456876e3b4f4f00f36301e4358b63a7acba1d4 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 85 (vs. ulimit of 3) |
   | modules | C: hbase-server hbase-mapreduce hbase-examples U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6126/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28587 Remove deprecated methods in Cell [hbase]

2024-07-28 Thread via GitHub


Apache-HBase commented on PR #6125:
URL: https://github.com/apache/hbase/pull/6125#issuecomment-2254549345

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 31s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m  0s |  |  master passed  |
   | +1 :green_heart: |  compile  |   6m 10s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 43s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   4m  9s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 53s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 32s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 40s |  |  the patch passed  |
   | -0 :warning: |  javac  |   0m 49s | 
[/results-compile-javac-hbase-common.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6125/1/artifact/yetus-general-check/output/results-compile-javac-hbase-common.txt)
 |  hbase-common generated 4 new + 66 unchanged - 0 fixed = 70 total (was 66)  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   2m  3s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   4m 46s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  13m 11s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 52s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 39s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  58m 40s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6125/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6125 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux d37dd1f5b667 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 55d661345dbac7423d542a6baa2542512820cf7a |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 85 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-client hbase-server hbase-mapreduce U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6125/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] HBASE-28729 Change the generic type of List in InternalScanner.next [hbase]

2024-07-28 Thread via GitHub


Apache9 opened a new pull request, #6126:
URL: https://github.com/apache/hbase/pull/6126

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] HBASE-28587 Remove deprecated methods in Cell [hbase]

2024-07-28 Thread via GitHub


Apache9 opened a new pull request, #6125:
URL: https://github.com/apache/hbase/pull/6125

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28750 Region normalizer should work in off peak if config [hbase]

2024-07-28 Thread via GitHub


Apache-HBase commented on PR #6113:
URL: https://github.com/apache/hbase/pull/6113#issuecomment-2254483500

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 32s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 57s |  |  master passed  |
   | +1 :green_heart: |  compile  |   0m 58s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 23s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  0s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 59s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 59s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 23s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 223m 35s |  |  hbase-server in the patch 
passed.  |
   |  |   | 248m 27s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6113 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 42adfebb16c2 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / e066a2927b88a9014bf6ac1373a462356179f983 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/3/testReport/
 |
   | Max. process+thread count | 5576 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/3/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28750 Region normalizer should work in off peak if config [hbase]

2024-07-28 Thread via GitHub


Apache-HBase commented on PR #6113:
URL: https://github.com/apache/hbase/pull/6113#issuecomment-2254383688

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   4m  2s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  1s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 56s |  |  master passed  |
   | +1 :green_heart: |  compile  |   2m 56s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 37s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   1m 32s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 43s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 53s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 55s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 55s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 37s | 
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/3/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
 |  hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total 
(was 0)  |
   | +1 :green_heart: |  spotbugs  |   1m 39s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  10m 33s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | -1 :x: |  spotless  |   0m 39s |  |  patch has 23 errors when running 
spotless:check, run spotless:apply to fix.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  38m 50s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6113 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 008f7cf66619 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 
12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / e066a2927b88a9014bf6ac1373a462356179f983 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | spotless | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/3/artifact/yetus-general-check/output/patch-spotless.txt
 |
   | Max. process+thread count | 83 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/3/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28584 RS SIGSEGV under heavy replication load [hbase]

2024-07-28 Thread via GitHub


Apache9 commented on PR #6124:
URL: https://github.com/apache/hbase/pull/6124#issuecomment-2254364110

   OK, in ServerCall class, we have a retainByWAL method, where we will count 
the extra references of the ServerCall, mainly the CellScanners.
   
   I think we can just change the method to retain, which means we want to 
retain it for other usage even after the rpc call is done, and also use it here.
   
   Anyway, since the current PR has been well tested in producation, I think we 
can apply it first, and open another issue for optimizing.
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28584 RS SIGSEGV under heavy replication load [hbase]

2024-07-28 Thread via GitHub


Apache-HBase commented on PR #6124:
URL: https://github.com/apache/hbase/pull/6124#issuecomment-2254362250

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   4m 11s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  9s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 33s |  |  master passed  |
   | +1 :green_heart: |  compile  |   1m 43s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m 15s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 12s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  0s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 21s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 21s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 47s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 20s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 29s |  |  hbase-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 229m 24s |  |  hbase-server in the patch 
passed.  |
   |  |   | 265m 42s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6124/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6124 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 265f2a29681d 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 
22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / e0a31621f67dec9c6da8a0607e9bdb28783afca5 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6124/1/testReport/
 |
   | Max. process+thread count | 5172 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6124/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28584 RS SIGSEGV under heavy replication load [hbase]

2024-07-28 Thread via GitHub


Apache9 commented on PR #6124:
URL: https://github.com/apache/hbase/pull/6124#issuecomment-2254361692

   OK, in ServerCall class, we have a retainByWAL method, where we will count 
the extra references of the ServerCall, mainly the CellScanners.
   
   I think we can just change the method to retain, which means we want to 
retain it for other usage even after the rpc call is done, and also use it here.
   
   Anyway, since the current PR has been well tested in producation, I think we 
can apply it first, and open another issue for optimizing.
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28719 Use ExtendedCell in WALEdit [hbase]

2024-07-27 Thread via GitHub


Apache9 merged PR #6108:
URL: https://github.com/apache/hbase/pull/6108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28748 Replication blocking: InvalidProtocolBufferException: Pro… [hbase]

2024-07-27 Thread via GitHub


Apache9 merged PR #6116:
URL: https://github.com/apache/hbase/pull/6116


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28748 Replication blocking: InvalidProtocolBufferException: Pro… [hbase]

2024-07-27 Thread via GitHub


Apache9 merged PR #6115:
URL: https://github.com/apache/hbase/pull/6115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28584 RS SIGSEGV under heavy replication load [hbase]

2024-07-27 Thread via GitHub


Apache-HBase commented on PR #6124:
URL: https://github.com/apache/hbase/pull/6124#issuecomment-2254322602

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 41s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 22s |  |  master passed  |
   | +1 :green_heart: |  compile  |   4m 30s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m  8s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   2m 42s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 59s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 36s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 16s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 16s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   1m  4s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   2m 46s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  12m 56s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 45s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 21s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  48m 41s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6124/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6124 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 30055f172d95 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / e0a31621f67dec9c6da8a0607e9bdb28783afca5 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 84 (vs. ulimit of 3) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6124/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28754 verify the first argument passed to compaction_switch [hbase]

2024-07-27 Thread via GitHub


Apache-HBase commented on PR #6119:
URL: https://github.com/apache/hbase/pull/6119#issuecomment-2254316785

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 34s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 14s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 14s |  |  master passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 27s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 12s |  |  the patch passed  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   7m 57s |  |  hbase-shell in the patch 
passed.  |
   |  |   |  16m 33s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6119 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux bc0c398ab12d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 5e4289b61babc8b55d14788189ab1c9a6fce6afe |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/2/testReport/
 |
   | Max. process+thread count | 2035 (vs. ulimit of 3) |
   | modules | C: hbase-shell U: hbase-shell |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28754 verify the first argument passed to compaction_switch [hbase]

2024-07-27 Thread via GitHub


Apache-HBase commented on PR #6119:
URL: https://github.com/apache/hbase/pull/6119#issuecomment-2254316664

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   4m 20s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 36s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   1m  3s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 54s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  rubocop  |   0m  6s | 
[/results-rubocop.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/2/artifact/yetus-general-check/output/results-rubocop.txt)
 |  The patch generated 1 new + 408 unchanged - 0 fixed = 409 total (was 408)  |
   | +1 :green_heart: |  spotless  |   0m 50s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  16m  7s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6119 |
   | Optional Tests | dupname asflicense javac codespell detsecrets rubocop 
spotless |
   | uname | Linux c7df37e42cbb 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 
22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 5e4289b61babc8b55d14788189ab1c9a6fce6afe |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 82 (vs. ulimit of 3) |
   | modules | C: hbase-shell U: hbase-shell |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 rubocop=1.37.1 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28754 verify the first argument passed to compaction_switch [hbase]

2024-07-27 Thread via GitHub


ether1984 commented on code in PR #6119:
URL: https://github.com/apache/hbase/pull/6119#discussion_r1694045788


##
hbase-shell/src/main/ruby/hbase/admin.rb:
##
@@ -114,6 +114,9 @@ def compact(table_or_region_name, family = nil, type = 
'NORMAL')
 
#--
 # Switch compaction on/off at runtime on a region server
 def compaction_switch(on_or_off, regionserver_names)
+  unless /true|false/i.match?(on_or_off)
+raise ArgumentError, 'compactionSwitch first argument only accepts 
"true" or "false"'

Review Comment:
   Yes this would be better, thx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28584 RS SIGSEGV under heavy replication load [hbase]

2024-07-27 Thread via GitHub


apurtell commented on PR #6124:
URL: https://github.com/apache/hbase/pull/6124#issuecomment-2254309100

   See also 
https://issues.apache.org/jira/browse/HBASE-28584?focusedCommentId=17869030=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17869030


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2.5) [hbase]

2024-07-27 Thread via GitHub


Apache-HBase commented on PR #6123:
URL: https://github.com/apache/hbase/pull/6123#issuecomment-2254213092

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 43s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2.5 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 31s |  |  branch-2.5 passed  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  |  branch-2.5 passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 25s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  |  the patch passed  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 216m 33s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 227m 39s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6123 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux d7b6fac4d22d 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 
22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.5 / ed001cbe0a0eac7d98e85fef4e31ad72b5dc3f29 |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/testReport/
 |
   | Max. process+thread count | 4385 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2.5) [hbase]

2024-07-27 Thread via GitHub


Apache-HBase commented on PR #6123:
URL: https://github.com/apache/hbase/pull/6123#issuecomment-2254210273

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 18s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2.5 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  |  branch-2.5 passed  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  |  branch-2.5 passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 47s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  |  the patch passed  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 203m 51s |  |  hbase-server in the patch 
passed.  |
   |  |   | 215m 17s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6123 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux b196fedf2e23 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.5 / ed001cbe0a0eac7d98e85fef4e31ad72b5dc3f29 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/testReport/
 |
   | Max. process+thread count | 4726 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2.5) [hbase]

2024-07-27 Thread via GitHub


Apache-HBase commented on PR #6123:
URL: https://github.com/apache/hbase/pull/6123#issuecomment-2254206015

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 44s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2.5 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  4s |  |  branch-2.5 passed  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  |  branch-2.5 passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 53s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  |  the patch passed  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 186m 47s |  |  hbase-server in the patch 
passed.  |
   |  |   | 198m 22s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6123 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 4d471bb38806 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.5 / ed001cbe0a0eac7d98e85fef4e31ad72b5dc3f29 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/testReport/
 |
   | Max. process+thread count | 4421 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28754 verify the first argument passed to compaction_switch [hbase]

2024-07-27 Thread via GitHub


ether1984 commented on PR #6119:
URL: https://github.com/apache/hbase/pull/6119#issuecomment-2254198106

   > Is this the correct jira issue number?
   I made a mistake the correct jira issue is: 
   [https://issues.apache.org/jira/browse/HBASE-28754](url)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28522 UNASSIGN proc indefinitely stuck on dead rs [hbase]

2024-07-27 Thread via GitHub


Apache9 merged PR #5995:
URL: https://github.com/apache/hbase/pull/5995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28522 UNASSIGN proc indefinitely stuck on dead rs [hbase]

2024-07-27 Thread via GitHub


Apache9 merged PR #6122:
URL: https://github.com/apache/hbase/pull/6122


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2.5) [hbase]

2024-07-27 Thread via GitHub


Apache-HBase commented on PR #6123:
URL: https://github.com/apache/hbase/pull/6123#issuecomment-2254161197

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 44s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ branch-2.5 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  4s |  |  branch-2.5 passed  |
   | +1 :green_heart: |  spotless  |   0m 44s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 44s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  spotless  |   0m 41s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |   9m 36s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6123 |
   | Optional Tests | dupname asflicense javac codespell detsecrets spotless |
   | uname | Linux 4e1c979faedb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.5 / ed001cbe0a0eac7d98e85fef4e31ad72b5dc3f29 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6123/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-6028 verify the first argument passed to compaction_switch [hbase]

2024-07-27 Thread via GitHub


guluo2016 commented on code in PR #6119:
URL: https://github.com/apache/hbase/pull/6119#discussion_r1693962526


##
hbase-shell/src/main/ruby/hbase/admin.rb:
##
@@ -114,6 +114,9 @@ def compact(table_or_region_name, family = nil, type = 
'NORMAL')
 
#--
 # Switch compaction on/off at runtime on a region server
 def compaction_switch(on_or_off, regionserver_names)
+  unless /true|false/i.match?(on_or_off)
+raise ArgumentError, 'compactionSwitch first argument only accepts 
"true" or "false"'

Review Comment:
   `compactionSwitch first argument  ...`   -> `compaction_switch first 
argument ...`,would this be better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28522 UNASSIGN proc indefinitely stuck on dead rs [hbase]

2024-07-27 Thread via GitHub


Apache-HBase commented on PR #6122:
URL: https://github.com/apache/hbase/pull/6122#issuecomment-2254097229

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 48s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  9s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  8s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 31s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 49s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 50s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  2s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 31s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 31s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 40s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 29s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 33s |  |  hbase-protocol-shaded in the 
patch passed.  |
   | -1 :x: |  unit  | 228m 16s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 256m 59s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6122 |
   | Optional Tests | unit javac javadoc compile shadedjars |
   | uname | Linux e375b88bf193 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 
12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 3b0e37d9e90a6a02db073c38e61b4e42555813e3 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/testReport/
 |
   | Max. process+thread count | 4300 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28522 UNASSIGN proc indefinitely stuck on dead rs [hbase]

2024-07-27 Thread via GitHub


Apache-HBase commented on PR #6122:
URL: https://github.com/apache/hbase/pull/6122#issuecomment-2254096126

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 42s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 20s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 22s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 36s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   6m 13s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 10s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 23s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 23s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 12s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 32s |  |  hbase-protocol-shaded in the 
patch passed.  |
   | +1 :green_heart: |  unit  | 222m 58s |  |  hbase-server in the patch 
passed.  |
   |  |   | 251m 43s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6122 |
   | Optional Tests | unit javac javadoc compile shadedjars |
   | uname | Linux c803a7b533f8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 3b0e37d9e90a6a02db073c38e61b4e42555813e3 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/testReport/
 |
   | Max. process+thread count | 4379 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28522 UNASSIGN proc indefinitely stuck on dead rs [hbase]

2024-07-27 Thread via GitHub


Apache-HBase commented on PR #6122:
URL: https://github.com/apache/hbase/pull/6122#issuecomment-2254092783

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 45s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 30s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m  3s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 33s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 11s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 21s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  5s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  5s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m  8s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 23s |  |  hbase-protocol-shaded in the 
patch passed.  |
   | +1 :green_heart: |  unit  | 212m 44s |  |  hbase-server in the patch 
passed.  |
   |  |   | 237m 19s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6122 |
   | Optional Tests | unit javac javadoc compile shadedjars |
   | uname | Linux fa260b371183 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 3b0e37d9e90a6a02db073c38e61b4e42555813e3 |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/testReport/
 |
   | Max. process+thread count | 4284 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28742 Fixes NPE for CompactionTool when mslab enabled [hbase]

2024-07-27 Thread via GitHub


Apache9 merged PR #6109:
URL: https://github.com/apache/hbase/pull/6109


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28742 Fixes NPE for CompactionTool when mslab enabled [hbase]

2024-07-27 Thread via GitHub


Apache9 merged PR #6097:
URL: https://github.com/apache/hbase/pull/6097


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) [hbase]

2024-07-27 Thread via GitHub


Apache9 merged PR #6118:
URL: https://github.com/apache/hbase/pull/6118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region [hbase]

2024-07-27 Thread via GitHub


Apache9 merged PR #6117:
URL: https://github.com/apache/hbase/pull/6117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28522 UNASSIGN proc indefinitely stuck on dead rs [hbase]

2024-07-27 Thread via GitHub


Apache-HBase commented on PR #6122:
URL: https://github.com/apache/hbase/pull/6122#issuecomment-2253823326

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 47s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  buf  |   0m  0s |  |  buf was not available.  |
   | +0 :ok: |  buf  |   0m  0s |  |  buf was not available.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 54s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   3m 44s |  |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 50s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotbugs  |   4m  6s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   0m 56s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 42s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 48s |  |  the patch passed  |
   | +1 :green_heart: |  cc  |   3m 48s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 48s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 46s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   4m 20s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  18m 10s |  |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6 3.4.0.  |
   | +1 :green_heart: |  hbaseprotoc  |   1m 22s |  |  the patch passed  |
   | +1 :green_heart: |  spotless  |   0m 53s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 20s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  50m 20s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6122 |
   | Optional Tests | dupname asflicense cc buflint bufcompat codespell 
detsecrets hbaseprotoc spotless javac spotbugs checkstyle compile hadoopcheck 
hbaseanti |
   | uname | Linux d6ceeb4c1f94 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 3b0e37d9e90a6a02db073c38e61b4e42555813e3 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6122/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region [hbase]

2024-07-26 Thread via GitHub


pankaj72981 commented on PR #6117:
URL: https://github.com/apache/hbase/pull/6117#issuecomment-2253784617

   > @pankaj72981 Do you have any other concerns?
   > 
   > Thanks.
   
   No more suggestions, we are good to go now. Thanks @guluo2016 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-6028 verify the first argument passed to compaction_switch [hbase]

2024-07-26 Thread via GitHub


Apache9 commented on PR #6119:
URL: https://github.com/apache/hbase/pull/6119#issuecomment-2253777312

   Is this the correct jira issue number?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28522 UNASSIGN proc indefinitely stuck on dead rs [hbase]

2024-07-26 Thread via GitHub


virajjasani commented on code in PR #5995:
URL: https://github.com/apache/hbase/pull/5995#discussion_r1693760005


##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/AbstractCloseTableRegionsProcedure.java:
##
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.procedure;
+
+import java.io.IOException;
+import java.util.function.Consumer;
+import org.apache.commons.lang3.mutable.MutableBoolean;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure;
+import org.apache.hadoop.hbase.procedure2.ProcedureSuspendedException;
+import org.apache.hadoop.hbase.procedure2.ProcedureUtil;
+import org.apache.hadoop.hbase.procedure2.ProcedureYieldException;
+import org.apache.hadoop.hbase.util.RetryCounter;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ProcedureProtos;
+
+/**
+ * Base class for unassigning table regions.
+ */
+@InterfaceAudience.Private
+public abstract class AbstractCloseTableRegionsProcedure>
+  extends AbstractStateMachineTableProcedure {
+
+  private static final Logger LOG =
+LoggerFactory.getLogger(AbstractCloseTableRegionsProcedure.class);
+
+  protected TableName tableName;
+
+  private RetryCounter retryCounter;
+
+  protected AbstractCloseTableRegionsProcedure() {
+  }
+
+  protected AbstractCloseTableRegionsProcedure(TableName tableName) {
+this.tableName = tableName;
+  }
+
+  @Override
+  public TableName getTableName() {
+return tableName;
+  }
+
+  @Override
+  public TableOperationType getTableOperationType() {
+return TableOperationType.REGION_EDIT;
+  }
+
+  private Flow schedule(MasterProcedureEnv env) throws 
ProcedureSuspendedException {
+MutableBoolean submitted = new MutableBoolean(false);
+int inTransitionCount = submitUnassignProcedure(env, p -> {
+  submitted.setTrue();
+  addChildProcedure(p);
+});
+if (inTransitionCount > 0 && submitted.isFalse()) {
+  // we haven't scheduled any unassign procedures and there are still 
regions in
+  // transition, sleep for a while and try again
+  if (retryCounter == null) {
+retryCounter = 
ProcedureUtil.createRetryCounter(env.getMasterConfiguration());
+  }
+  long backoffMillis = retryCounter.getBackoffTimeAndIncrementAttempts();
+  LOG.info(
+"There are still {} region(s) in transition for closing regions of 
table {}"
+  + " when executing {}, suspend {}secs and try again later",
+inTransitionCount, tableName, getClass().getSimpleName(), 
backoffMillis / 1000);

Review Comment:
   Nice, this will be helpful



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region [hbase]

2024-07-26 Thread via GitHub


Apache9 commented on PR #6117:
URL: https://github.com/apache/hbase/pull/6117#issuecomment-2253724020

   @pankaj72981 Do you have any other concerns?
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28643 An unbounded backup failure message can cause an irrecoverable state for the given backup [hbase]

2024-07-26 Thread via GitHub


Apache-HBase commented on PR #6088:
URL: https://github.com/apache/hbase/pull/6088#issuecomment-2253018937

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 31s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 41s |  |  master passed  |
   | +1 :green_heart: |  compile  |   0m 26s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 21s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 19s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 19s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 13s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 36s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  10m 27s |  |  hbase-backup in the patch 
passed.  |
   |  |   |  32m 22s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6088/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6088 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 1400486ce2b8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 2cd3a229e9f6bb993a27850219549d80ad371784 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6088/2/testReport/
 |
   | Max. process+thread count | 3851 (vs. ulimit of 3) |
   | modules | C: hbase-backup U: hbase-backup |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6088/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28643 An unbounded backup failure message can cause an irrecoverable state for the given backup [hbase]

2024-07-26 Thread via GitHub


Apache-HBase commented on PR #6088:
URL: https://github.com/apache/hbase/pull/6088#issuecomment-2253011033

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 15s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  4s |  |  master passed  |
   | +1 :green_heart: |  compile  |   0m 32s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   0m 32s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 45s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 55s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 30s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 30s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 11s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   0m 39s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  10m 29s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 43s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 11s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  27m 33s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6088/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6088 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 550e0e2c0a19 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 2cd3a229e9f6bb993a27850219549d80ad371784 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 83 (vs. ulimit of 3) |
   | modules | C: hbase-backup U: hbase-backup |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6088/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) [hbase]

2024-07-26 Thread via GitHub


Apache-HBase commented on PR #6118:
URL: https://github.com/apache/hbase/pull/6118#issuecomment-2252871397

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 44s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 59s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  |  branch-2 passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 18s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  |  the patch passed  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 254m  7s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 266m 51s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6118 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux b312fb87ead8 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 
22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 994e0b8cdc34a6284c16b7f5a5732b28431df15b |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/testReport/
 |
   | Max. process+thread count | 4592 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) [hbase]

2024-07-26 Thread via GitHub


Apache-HBase commented on PR #6118:
URL: https://github.com/apache/hbase/pull/6118#issuecomment-2252859805

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 21s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 47s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 37s |  |  branch-2 passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  6s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 41s |  |  the patch passed  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 245m 20s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 260m 30s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6118 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 7c3fe92744ed 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 994e0b8cdc34a6284c16b7f5a5732b28431df15b |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/testReport/
 |
   | Max. process+thread count | 4418 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) [hbase]

2024-07-26 Thread via GitHub


Apache-HBase commented on PR #6118:
URL: https://github.com/apache/hbase/pull/6118#issuecomment-2252796004

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 24s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  6s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  |  branch-2 passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 15s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  |  the patch passed  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 219m 26s |  |  hbase-server in the patch 
passed.  |
   |  |   | 232m 56s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6118 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 84c223810c30 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 994e0b8cdc34a6284c16b7f5a5732b28431df15b |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/testReport/
 |
   | Max. process+thread count | 4617 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28750 Region normalizer should work in off peak if config [hbase]

2024-07-26 Thread via GitHub


Apache-HBase commented on PR #6113:
URL: https://github.com/apache/hbase/pull/6113#issuecomment-2252786523

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 36s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  4s |  |  master passed  |
   | +1 :green_heart: |  compile  |   0m 59s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 31s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 25s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 58s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 58s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 17s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 232m 20s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 257m 23s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6113 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux ab85b4fb8cf5 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 37b8af734b0dfcf9591ddc33fc22ff7e831b371f |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/2/testReport/
 |
   | Max. process+thread count | 5251 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region [hbase]

2024-07-26 Thread via GitHub


Apache-HBase commented on PR #6117:
URL: https://github.com/apache/hbase/pull/6117#issuecomment-2252758977

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 28s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 23s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  |  master passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  5s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  |  the patch passed  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 216m  8s |  |  hbase-server in the patch 
passed.  |
   |  |   | 227m 58s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6117 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 5419c8db0a30 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 084cc4b1b12f1c5cb404f974cb1301d3339a5348 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/2/testReport/
 |
   | Max. process+thread count | 5258 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) [hbase]

2024-07-26 Thread via GitHub


Apache-HBase commented on PR #6118:
URL: https://github.com/apache/hbase/pull/6118#issuecomment-2252423525

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 56s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 15s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   1m 23s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 56s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  spotless  |   1m 22s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 19s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  16m  3s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6118 |
   | Optional Tests | dupname asflicense javac codespell detsecrets spotless |
   | uname | Linux 8402cfad4280 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 994e0b8cdc34a6284c16b7f5a5732b28431df15b |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/3/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28750 Region normalizer should work in off peak if config [hbase]

2024-07-26 Thread via GitHub


Apache-HBase commented on PR #6113:
URL: https://github.com/apache/hbase/pull/6113#issuecomment-2252394762

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 38s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  5s |  |  master passed  |
   | +1 :green_heart: |  compile  |   2m 56s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 38s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   1m 34s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 46s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 56s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 55s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 55s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 38s | 
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/2/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
 |  hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total 
(was 0)  |
   | +1 :green_heart: |  spotbugs  |   1m 40s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  10m 43s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | -1 :x: |  spotless  |   0m 39s |  |  patch has 23 errors when running 
spotless:check, run spotless:apply to fix.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 12s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  35m 59s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6113 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux f5cf9d63837f 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 
12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 37b8af734b0dfcf9591ddc33fc22ff7e831b371f |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | spotless | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/2/artifact/yetus-general-check/output/patch-spotless.txt
 |
   | Max. process+thread count | 85 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6113/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region [hbase]

2024-07-26 Thread via GitHub


Apache-HBase commented on PR #6117:
URL: https://github.com/apache/hbase/pull/6117#issuecomment-2252369746

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 39s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  5s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 45s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 51s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  spotless  |   0m 45s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 12s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |   9m 28s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6117 |
   | Optional Tests | dupname asflicense javac codespell detsecrets spotless |
   | uname | Linux 3d4559709192 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 
12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 084cc4b1b12f1c5cb404f974cb1301d3339a5348 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 83 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28750 Region normalizer should work in off peak if config [hbase]

2024-07-26 Thread via GitHub


1458451310 commented on PR #6113:
URL: https://github.com/apache/hbase/pull/6113#issuecomment-2252317657

   > This is a nice addition. Is it possible add test for this condition in 
TestRegionNormalizerWorker?
   
   It is ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28756 RegionSizeCalculator ignored the size of memstore, which … [hbase]

2024-07-26 Thread via GitHub


ddupg merged PR #6120:
URL: https://github.com/apache/hbase/pull/6120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region [hbase]

2024-07-25 Thread via GitHub


guluo2016 commented on code in PR #6117:
URL: https://github.com/apache/hbase/pull/6117#discussion_r1692357447


##
hbase-server/src/main/resources/hbase-webapps/regionserver/region.jsp:
##
@@ -79,17 +86,20 @@
Len Of Biggest Cell
Key Of Biggest Cell
  
-   <%   for(StoreFile sf : storeFiles) { %>
+   <% int count = 0;
+  for(StoreFile sf : storeFiles) {
+if (!fs.exists(sf.getPath())) continue;

Review Comment:
   Make sense, I will update it, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #6118:
URL: https://github.com/apache/hbase/pull/6118#issuecomment-2251359643

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 23s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  8s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 28s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 52s |  |  branch-2 passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 59s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 38s |  |  the patch passed  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 320m 10s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 335m 59s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6118 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 0d6b933d6197 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 3462c250ddeb3722c23a32a36c6efe1205402f1f |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/testReport/
 |
   | Max. process+thread count | 4358 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28564 Move Reference file read/creation to SFT interface [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #5939:
URL: https://github.com/apache/hbase/pull/5939#issuecomment-2251357125

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 16s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  2s |  |  master passed  |
   | +1 :green_heart: |  compile  |   0m 58s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 24s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
   | -0 :warning: |  patch  |   5m 34s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 56s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  0s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  0s |  |  the patch passed  |
   | -0 :warning: |  javadoc  |   0m 29s | 
[/results-javadoc-javadoc-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5939/13/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-hbase-server.txt)
 |  hbase-server generated 6 new + 48 unchanged - 0 fixed = 54 total (was 48)  |
   | +1 :green_heart: |  shadedjars  |   5m 19s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 337m 50s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5939/13/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 363m 49s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5939/13/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5939 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux bd810c02b920 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3be02a24255481b669bf730e71166f4cc0dd2794 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5939/13/testReport/
 |
   | Max. process+thread count | 4996 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5939/13/console
 |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #6118:
URL: https://github.com/apache/hbase/pull/6118#issuecomment-2251225025

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 18s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 49s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 33s |  |  branch-2 passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 39s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 31s |  |  the patch passed  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 230m 36s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 245m 56s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6118 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux bca5d8a33abe 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 3462c250ddeb3722c23a32a36c6efe1205402f1f |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/testReport/
 |
   | Max. process+thread count | 4406 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #6118:
URL: https://github.com/apache/hbase/pull/6118#issuecomment-2251212823

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 42s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 59s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  |  branch-2 passed  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 59s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  |  the patch passed  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 226m 55s |  |  hbase-server in the patch 
passed.  |
   |  |   | 238m 59s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6118 |
   | Optional Tests | javac javadoc unit |
   | uname | Linux 6f73ab5b0250 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 
22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 3462c250ddeb3722c23a32a36c6efe1205402f1f |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/testReport/
 |
   | Max. process+thread count | 4560 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28655 IllegalArgumentException: Illegal bufferSize thrown when hbase.io.compress.zstd.buffersize is not configured [hbase]

2024-07-25 Thread via GitHub


pankaj72981 merged PR #6121:
URL: https://github.com/apache/hbase/pull/6121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28655 IllegalArgumentException: Illegal bufferSize thrown when hbase.io.compress.zstd.buffersize is not configured [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #6121:
URL: https://github.com/apache/hbase/pull/6121#issuecomment-2251088388

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 58s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 36s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 56s |  |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 21s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotbugs  |   0m 57s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   0m 55s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 23s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 38s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 38s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 17s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   1m 20s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  18m 21s |  |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 42s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 17s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  36m 14s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6121 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 8a70dcf5e300 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 2ed3a816fa1f4e035e85aa5a4dd9f74307b585e5 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 77 (vs. ulimit of 3) |
   | modules | C: hbase-compression/hbase-compression-aircompressor 
hbase-compression/hbase-compression-zstd U: hbase-compression |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28655 IllegalArgumentException: Illegal bufferSize thrown when hbase.io.compress.zstd.buffersize is not configured [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #6121:
URL: https://github.com/apache/hbase/pull/6121#issuecomment-2251080270

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 48s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 35s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 53s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 32s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   7m 20s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 52s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 34s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 34s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 21s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 11s |  |  hbase-compression-aircompressor 
in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 11s |  |  hbase-compression-zstd in the 
patch passed.  |
   |  |   |  31m 33s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6121 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux daeae706e1d7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 2ed3a816fa1f4e035e85aa5a4dd9f74307b585e5 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/testReport/
 |
   | Max. process+thread count | 760 (vs. ulimit of 3) |
   | modules | C: hbase-compression/hbase-compression-aircompressor 
hbase-compression/hbase-compression-zstd U: hbase-compression |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28655 IllegalArgumentException: Illegal bufferSize thrown when hbase.io.compress.zstd.buffersize is not configured [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #6121:
URL: https://github.com/apache/hbase/pull/6121#issuecomment-2251069002

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 48s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  9s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  3s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 35s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 37s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  4s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 35s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 35s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 34s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  0s |  |  hbase-compression-aircompressor 
in the patch passed.  |
   | +1 :green_heart: |  unit  |   2m 52s |  |  hbase-compression-zstd in the 
patch passed.  |
   |  |   |  25m 53s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6121 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 19d2a8eaf5a4 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 2ed3a816fa1f4e035e85aa5a4dd9f74307b585e5 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/testReport/
 |
   | Max. process+thread count | 915 (vs. ulimit of 3) |
   | modules | C: hbase-compression/hbase-compression-aircompressor 
hbase-compression/hbase-compression-zstd U: hbase-compression |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28655 IllegalArgumentException: Illegal bufferSize thrown when hbase.io.compress.zstd.buffersize is not configured [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #6121:
URL: https://github.com/apache/hbase/pull/6121#issuecomment-2251063732

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 42s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 34s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 26s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 22s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 21s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 23s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 26s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 26s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 21s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 18s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 57s |  |  hbase-compression-aircompressor 
in the patch passed.  |
   | +1 :green_heart: |  unit  |   2m 28s |  |  hbase-compression-zstd in the 
patch passed.  |
   |  |   |  23m  1s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6121 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 7b7c77780406 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 2ed3a816fa1f4e035e85aa5a4dd9f74307b585e5 |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/testReport/
 |
   | Max. process+thread count | 761 (vs. ulimit of 3) |
   | modules | C: hbase-compression/hbase-compression-aircompressor 
hbase-compression/hbase-compression-zstd U: hbase-compression |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] HBASE-28655 IllegalArgumentException: Illegal bufferSize thrown when hbase.io.compress.zstd.buffersize is not configured [hbase]

2024-07-25 Thread via GitHub


pankaj72981 opened a new pull request, #6121:
URL: https://github.com/apache/hbase/pull/6121

   HADOOP-18810 added io.compression.codec.zstd.buffersize in core-default.xml 
with default value as 0, so default value of hbase.io.compress.zstd.buffersize 
will become 0 instead of ZSTD_BUFFER_SIZE_DEFAULT (256 * 1024) when not 
configured in hbase-site.xml.
   
   (cherry picked from commit 73f2710e47557218dcf92cc3e7b1788dfbb57fd2)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28655 IllegalArgumentException: Illegal bufferSize thrown when hbase.io.compress.zstd.buffersize is not configured [hbase]

2024-07-25 Thread via GitHub


pankaj72981 merged PR #6114:
URL: https://github.com/apache/hbase/pull/6114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28346: Expose checkQuota to Coprocessor Endpoints [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #6066:
URL: https://github.com/apache/hbase/pull/6066#issuecomment-2250949883

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 39s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 53s |  |  master passed  |
   | +1 :green_heart: |  compile  |   1m 10s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 38s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 45s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  6s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  6s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 32s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 27s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 246m 48s |  |  hbase-server in the patch 
passed.  |
   |  |   | 276m 31s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6066/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6066 |
   | JIRA Issue | HBASE-28346 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 1b8e3056948b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 2825e301735cbd7047d870e9b2ebd0e5832efe7d |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6066/5/testReport/
 |
   | Max. process+thread count | 4437 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6066/5/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region [hbase]

2024-07-25 Thread via GitHub


pankaj72981 commented on code in PR #6117:
URL: https://github.com/apache/hbase/pull/6117#discussion_r1691774182


##
hbase-server/src/main/resources/hbase-webapps/regionserver/region.jsp:
##
@@ -79,17 +86,20 @@
Len Of Biggest Cell
Key Of Biggest Cell
  
-   <%   for(StoreFile sf : storeFiles) { %>
+   <% int count = 0;
+  for(StoreFile sf : storeFiles) {
+if (!fs.exists(sf.getPath())) continue;

Review Comment:
   IMO it's worth to add a primary region check, we will save unnecessary RPCs 
to Namenode.
   
   We can extract to a boolean variable, and use here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region [hbase]

2024-07-25 Thread via GitHub


pankaj72981 commented on code in PR #6117:
URL: https://github.com/apache/hbase/pull/6117#discussion_r1691774182


##
hbase-server/src/main/resources/hbase-webapps/regionserver/region.jsp:
##
@@ -79,17 +86,20 @@
Len Of Biggest Cell
Key Of Biggest Cell
  
-   <%   for(StoreFile sf : storeFiles) { %>
+   <% int count = 0;
+  for(StoreFile sf : storeFiles) {
+if (!fs.exists(sf.getPath())) continue;

Review Comment:
   IMO it's worth to add a primary region check, we will save unnecessary RPCs 
to Namenode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #6118:
URL: https://github.com/apache/hbase/pull/6118#issuecomment-2250654723

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 27s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 48s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   1m 10s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 26s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -1 :x: |  spotless  |   1m  7s |  |  patch has 1 errors when running 
spotless:check, run spotless:apply to fix.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 24s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  13m 39s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6118 |
   | Optional Tests | dupname asflicense javac codespell detsecrets spotless |
   | uname | Linux f1fc99a1dc04 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 
12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 3462c250ddeb3722c23a32a36c6efe1205402f1f |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | spotless | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/artifact/yetus-general-check/output/patch-spotless.txt
 |
   | Max. process+thread count | 78 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6118/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28564 Move Reference file read/creation to SFT interface [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #5939:
URL: https://github.com/apache/hbase/pull/5939#issuecomment-2250647218

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 30s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 42s |  |  master passed  |
   | +1 :green_heart: |  compile  |   3m 21s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 40s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   1m 53s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 52s |  |  branch has no errors when 
running spotless:check.  |
   | -0 :warning: |  patch  |   0m 59s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 36s |  |  the patch passed  |
   | -1 :x: |  compile  |   1m 32s | 
[/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5939/13/artifact/yetus-general-check/output/patch-compile-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   1m 32s | 
[/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5939/13/artifact/yetus-general-check/output/patch-compile-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 40s | 
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5939/13/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
 |  hbase-server: The patch generated 4 new + 128 unchanged - 2 fixed = 132 
total (was 130)  |
   | -1 :x: |  spotbugs  |   2m 33s | 
[/new-spotbugs-hbase-server.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5939/13/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html)
 |  hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)  |
   | +1 :green_heart: |  hadoopcheck  |  12m 19s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 50s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 11s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  40m 21s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | SpotBugs | module:hbase-server |
   |  |  Null pointer dereference of storeFileInfo in 
org.apache.hadoop.hbase.regionserver.HRegion.replayWALBulkLoadEventMarker(WALProtos$BulkLoadDescriptor)
  Dereferenced at HRegion.java:in 
org.apache.hadoop.hbase.regionserver.HRegion.replayWALBulkLoadEventMarker(WALProtos$BulkLoadDescriptor)
  Dereferenced at HRegion.java:[line 6521] |
   |  |  Load of known null value in 
org.apache.hadoop.hbase.regionserver.HRegion.replayWALBulkLoadEventMarker(WALProtos$BulkLoadDescriptor)
  At HRegion.java:in 
org.apache.hadoop.hbase.regionserver.HRegion.replayWALBulkLoadEventMarker(WALProtos$BulkLoadDescriptor)
  At HRegion.java:[line 6521] |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5939/13/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/5939 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux e79f50abcd15 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 3be02a24255481b669bf730e71166f4cc0dd2794 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 86 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5939/13/console
 |
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was 

Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region [hbase]

2024-07-25 Thread via GitHub


Apache9 commented on PR #6117:
URL: https://github.com/apache/hbase/pull/6117#issuecomment-2250623631

   If it is simple you can just fix it in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region [hbase]

2024-07-25 Thread via GitHub


pankaj72981 commented on code in PR #6117:
URL: https://github.com/apache/hbase/pull/6117#discussion_r1691629008


##
hbase-server/src/main/resources/hbase-webapps/regionserver/region.jsp:
##
@@ -79,17 +86,20 @@
Len Of Biggest Cell
Key Of Biggest Cell
  
-   <%   for(StoreFile sf : storeFiles) { %>
+   <% int count = 0;
+  for(StoreFile sf : storeFiles) {
+if (!fs.exists(sf.getPath())) continue;

Review Comment:
   Do we need to check the file existence for primary region also?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region [hbase]

2024-07-25 Thread via GitHub


guluo2016 commented on PR #6117:
URL: https://github.com/apache/hbase/pull/6117#issuecomment-2250612044

   Hi @Apache9 , I also found that type conversion is no need in region.jsp, as 
fallow.
   ```
   List stores = region.getStores();
   for (Store store : stores) {
  String cf = store.getColumnFamilyName();
  Collection storeFiles = store.getStorefiles(); %>
   ```
   
   Maybe we can also fix it in this PR ,  Or we can open a new PR ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) [hbase]

2024-07-25 Thread via GitHub


guluo2016 commented on PR #6118:
URL: https://github.com/apache/hbase/pull/6118#issuecomment-2250558283

   > Please fix the blanks issues?
   
   Excuse me, Where is the blank issue ?  I didn't find it ...
   
   > Please fix the blanks issues?
   
   Thanks for your review, already fixed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) [hbase]

2024-07-25 Thread via GitHub


Apache9 commented on PR #6118:
URL: https://github.com/apache/hbase/pull/6118#issuecomment-2250407238

   Please fix the blanks issues?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] HBASE-28346: Expose checkQuota to Coprocessor Endpoints [hbase]

2024-07-25 Thread via GitHub


Apache-HBase commented on PR #6066:
URL: https://github.com/apache/hbase/pull/6066#issuecomment-2250239021

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 48s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  4s |  |  master passed  |
   | +1 :green_heart: |  compile  |   3m 46s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 49s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   1m 52s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 48s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 30s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  5s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m  5s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 39s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   2m  0s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  12m  7s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 44s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 11s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  40m 51s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.46 ServerAPI=1.46 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6066/5/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6066 |
   | JIRA Issue | HBASE-28346 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 4f7e6ac185cc 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 
12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 2825e301735cbd7047d870e9b2ebd0e5832efe7d |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 84 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6066/5/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   3   4   5   6   7   8   9   10   >