[GitHub] [hbase] Apache-HBase commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite
Apache-HBase commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite URL: https://github.com/apache/hbase/pull/678#issuecomment-537632320 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 51s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 41s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 6m 40s | master passed | | :green_heart: | compile | 1m 23s | master passed | | :green_heart: | checkstyle | 1m 59s | master passed | | :green_heart: | shadedjars | 5m 27s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 56s | master passed | | :blue_heart: | spotbugs | 4m 50s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 5m 44s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 16s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 7m 12s | the patch passed | | :green_heart: | compile | 1m 33s | the patch passed | | :green_heart: | javac | 1m 33s | the patch passed | | :green_heart: | checkstyle | 0m 29s | The patch passed checkstyle in hbase-common | | :green_heart: | checkstyle | 1m 44s | hbase-server: The patch generated 0 new + 51 unchanged - 1 fixed = 51 total (was 52) | | :broken_heart: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | :green_heart: | shadedjars | 5m 40s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 20s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 57s | the patch passed | | :green_heart: | findbugs | 5m 27s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 2m 56s | hbase-common in the patch passed. | | :broken_heart: | unit | 295m 18s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 56s | The patch does not generate ASF License warnings. | | | | 371m 48s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaSameHosts | | | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.client.TestMobSnapshotCloneIndependence | | | hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaHighReplication | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/678 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux cea581fd47ab 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-678/out/precommit/personality/provided.sh | | git revision | master / 2ebdcbc3b0 | | Default Java | 1.8.0_181 | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/1/artifact/out/whitespace-eol.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/1/testReport/ | | Max. process+thread count | 5299 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.
[GitHub] [hbase] Apache-HBase commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite
Apache-HBase commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite URL: https://github.com/apache/hbase/pull/678#issuecomment-537813270 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 38s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 15s | master passed | | :green_heart: | compile | 1m 21s | master passed | | :green_heart: | checkstyle | 1m 46s | master passed | | :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 1s | master passed | | :blue_heart: | spotbugs | 4m 5s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 51s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 4m 54s | the patch passed | | :green_heart: | compile | 1m 18s | the patch passed | | :green_heart: | javac | 1m 18s | the patch passed | | :green_heart: | checkstyle | 0m 27s | The patch passed checkstyle in hbase-common | | :green_heart: | checkstyle | 1m 17s | hbase-server: The patch generated 0 new + 51 unchanged - 1 fixed = 51 total (was 52) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 38s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 15m 35s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 58s | the patch passed | | :green_heart: | findbugs | 5m 1s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 3m 6s | hbase-common in the patch passed. | | :broken_heart: | unit | 163m 19s | hbase-server in the patch failed. | | :green_heart: | asflicense | 1m 11s | The patch does not generate ASF License warnings. | | | | 228m 44s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/678 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e81ffae7ac33 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-678/out/precommit/personality/provided.sh | | git revision | master / 7ee6d59ef8 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/2/testReport/ | | Max. process+thread count | 4839 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite
Apache-HBase commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite URL: https://github.com/apache/hbase/pull/678#issuecomment-539373318 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 44s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 34s | master passed | | :green_heart: | compile | 1m 19s | master passed | | :green_heart: | checkstyle | 1m 46s | master passed | | :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 4s | master passed | | :blue_heart: | spotbugs | 4m 5s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 50s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 4m 58s | the patch passed | | :green_heart: | compile | 1m 19s | the patch passed | | :green_heart: | javac | 1m 19s | the patch passed | | :green_heart: | checkstyle | 0m 26s | The patch passed checkstyle in hbase-common | | :green_heart: | checkstyle | 1m 17s | hbase-server: The patch generated 0 new + 51 unchanged - 1 fixed = 51 total (was 52) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 37s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 15m 48s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 1m 1s | the patch passed | | :green_heart: | findbugs | 4m 58s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 3m 7s | hbase-common in the patch passed. | | :green_heart: | unit | 158m 33s | hbase-server in the patch passed. | | :green_heart: | asflicense | 1m 8s | The patch does not generate ASF License warnings. | | | | 224m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/678 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d246644b10d1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-678/out/precommit/personality/provided.sh | | git revision | master / 10180e232e | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/3/testReport/ | | Max. process+thread count | 4647 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite
Apache-HBase commented on issue #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite URL: https://github.com/apache/hbase/pull/678#issuecomment-541295646 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 51s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 42s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 7m 21s | master passed | | :green_heart: | compile | 1m 36s | master passed | | :green_heart: | checkstyle | 2m 9s | master passed | | :green_heart: | shadedjars | 5m 58s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 8s | master passed | | :blue_heart: | spotbugs | 4m 56s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 5m 53s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 16s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 6m 49s | the patch passed | | :green_heart: | compile | 1m 38s | the patch passed | | :green_heart: | javac | 1m 38s | the patch passed | | :green_heart: | checkstyle | 0m 30s | The patch passed checkstyle in hbase-common | | :green_heart: | checkstyle | 1m 37s | hbase-server: The patch generated 0 new + 51 unchanged - 1 fixed = 51 total (was 52) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 51s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 19m 57s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 1m 7s | the patch passed | | :green_heart: | findbugs | 5m 38s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 3m 7s | hbase-common in the patch passed. | | :green_heart: | unit | 170m 14s | hbase-server in the patch passed. | | :green_heart: | asflicense | 0m 58s | The patch does not generate ASF License warnings. | | | | 251m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/678 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 673179e62674 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-678/out/precommit/personality/provided.sh | | git revision | master / 1aee5f0552 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/4/testReport/ | | Max. process+thread count | 5063 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-678/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services