[GitHub] [hbase] Apache9 commented on a change in pull request #2614: HBASE-25216 The client zk syncer should deal with meta replica count …

2020-11-04 Thread GitBox 


Apache9 commented on a change in pull request #2614:
URL: https://github.com/apache/hbase/pull/2614#discussion_r517161164



##
File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSeparateClientZKCluster.java
##
@@ -255,7 +260,20 @@ public void testAsyncTable() throws Exception {
   Get get = new Get(row);
   Result result = table.get(get).get();
   LOG.debug("Result: " + Bytes.toString(result.getValue(family, 
qualifier)));
-  Assert.assertArrayEquals(value, result.getValue(family, qualifier));
+  assertArrayEquals(value, result.getValue(family, qualifier));
+}
+  }
+
+  @Test
+  public void testChangeMetaReplicaCount() throws Exception {

Review comment:
   RegionLocator will go to ConnectionRegistry to ask for the meta 
locations and we have already set the ConnectionRegistry to 
ZKConnectionRegistry against the client zk in the setup method, so it is 
testing the ClientZKSyncer logics, you could try comment out the set data logic 
in ClientZKSyncer, the test will fail with timeout...





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on a change in pull request #2614: HBASE-25216 The client zk syncer should deal with meta replica count …

2020-11-03 Thread GitBox 


Apache9 commented on a change in pull request #2614:
URL: https://github.com/apache/hbase/pull/2614#discussion_r517078074



##
File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSeparateClientZKCluster.java
##
@@ -255,7 +260,20 @@ public void testAsyncTable() throws Exception {
   Get get = new Get(row);
   Result result = table.get(get).get();
   LOG.debug("Result: " + Bytes.toString(result.getValue(family, 
qualifier)));
-  Assert.assertArrayEquals(value, result.getValue(family, qualifier));
+  assertArrayEquals(value, result.getValue(family, qualifier));
+}
+  }
+
+  @Test
+  public void testChangeMetaReplicaCount() throws Exception {

Review comment:
   In the test we increase from 1 to 3, and then reduce back to 2, you mean 
we should add one more assert to reduce to 1?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on a change in pull request #2614: HBASE-25216 The client zk syncer should deal with meta replica count …

2020-11-03 Thread GitBox 


Apache9 commented on a change in pull request #2614:
URL: https://github.com/apache/hbase/pull/2614#discussion_r517077805



##
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/zksyncer/ClientZKSyncer.java
##
@@ -145,8 +177,7 @@ private final void setDataForClientZkUntilSuccess(String 
node, byte[] data)
   LOG.warn(
 "Failed to create znode " + node + " due to: " + e.getMessage() + 
", will retry later");
 }
-  } catch (KeeperException.ConnectionLossException
-  | KeeperException.SessionExpiredException ee) {
+  } catch (KeeperException.SessionExpiredException see) {

Review comment:
   ConnectionLoss just means the connection is broken, the zk library will 
reconnect automatically to resume the session if possible.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org