[GitHub] [hbase] Apache9 commented on a change in pull request #3656: HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin…
Apache9 commented on a change in pull request #3656:
URL: https://github.com/apache/hbase/pull/3656#discussion_r703416594
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/storefiletracker/TestMigrationStoreFileTracker.java
##
@@ -0,0 +1,179 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.storefiletracker;
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Get;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.RegionInfoBuilder;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.regionserver.ChunkCreator;
+import org.apache.hadoop.hbase.regionserver.HRegion;
+import org.apache.hadoop.hbase.regionserver.MemStoreLAB;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RegionServerTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.wal.WAL;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameter;
+import org.junit.runners.Parameterized.Parameters;
+
+import org.apache.hbase.thirdparty.com.google.common.io.Closeables;
+
+@RunWith(Parameterized.class)
+@Category({ RegionServerTests.class, MediumTests.class })
+public class TestMigrationStoreFileTracker {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestMigrationStoreFileTracker.class);
+
+ private static final HBaseTestingUtil UTIL = new HBaseTestingUtil();
+
+ private static final byte[] CF = Bytes.toBytes("cf");
+
+ private static final byte[] CQ = Bytes.toBytes("cq");
+
+ private static final TableDescriptor TD =
+TableDescriptorBuilder.newBuilder(TableName.valueOf("file_based_tracker"))
+ .setColumnFamily(ColumnFamilyDescriptorBuilder.of(CF)).build();
+
+ private static final RegionInfo RI =
RegionInfoBuilder.newBuilder(TD.getTableName()).build();
+
+ @Rule
+ public TestName name = new TestName();
+
+ @Parameter(0)
+ public Class srcImplClass;
+
+ @Parameter(1)
+ public Class dstImplClass;
+
+ private HRegion region;
+
+ private Path rootDir;
+
+ private WAL wal;
+
+ @Parameters(name = "{index}: src={0}, dst={1}")
+ public static List params() {
+List> impls =
+ Arrays.asList(DefaultStoreFileTracker.class,
FileBasedStoreFileTracker.class);
+List params = new ArrayList<>();
+for (Class src : impls) {
+ for (Class dst : impls) {
+if (src.equals(dst)) {
+ continue;
+}
+params.add(new Object[] { src, dst });
+ }
+}
+return params;
+ }
+
+ @BeforeClass
+ public static void setUpBeforeClass() {
+ChunkCreator.initialize(MemStoreLAB.CHUNK_SIZE_DEFAULT, false, 0, 0, 0,
null,
+ MemStoreLAB.INDEX_CHUNK_SIZE_PERCENTAGE_DEFAULT);
+ }
+
+ @Before
+ public void setUp() throws IOException {
+Configuration conf = UTIL.getConfiguration();
+conf.setClass(MigrationStoreFileTracker.SRC_IMPL, srcImplClass,
StoreFileTrackerBase.class);
+conf.setClass(MigrationStoreFileTracker.DST_IMPL, dstImplClass,
StoreFileTrackerBase.class);
+rootDir = UTIL.getDataTestDir(name.getMethodName().replaceAll("[=:\\[ ]",
"_"));
+wal = HBaseTestingUtil.createWal(conf, rootDir, RI);
+ }
+
+ @
[GitHub] [hbase] Apache9 commented on a change in pull request #3656: HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin…
Apache9 commented on a change in pull request #3656:
URL: https://github.com/apache/hbase/pull/3656#discussion_r703416310
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/storefiletracker/TestMigrationStoreFileTracker.java
##
@@ -0,0 +1,179 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.storefiletracker;
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Get;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.RegionInfoBuilder;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.regionserver.ChunkCreator;
+import org.apache.hadoop.hbase.regionserver.HRegion;
+import org.apache.hadoop.hbase.regionserver.MemStoreLAB;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.testclassification.RegionServerTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.wal.WAL;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameter;
+import org.junit.runners.Parameterized.Parameters;
+
+import org.apache.hbase.thirdparty.com.google.common.io.Closeables;
+
+@RunWith(Parameterized.class)
+@Category({ RegionServerTests.class, MediumTests.class })
+public class TestMigrationStoreFileTracker {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestMigrationStoreFileTracker.class);
+
+ private static final HBaseTestingUtil UTIL = new HBaseTestingUtil();
+
+ private static final byte[] CF = Bytes.toBytes("cf");
+
+ private static final byte[] CQ = Bytes.toBytes("cq");
+
+ private static final TableDescriptor TD =
+TableDescriptorBuilder.newBuilder(TableName.valueOf("file_based_tracker"))
+ .setColumnFamily(ColumnFamilyDescriptorBuilder.of(CF)).build();
+
+ private static final RegionInfo RI =
RegionInfoBuilder.newBuilder(TD.getTableName()).build();
+
+ @Rule
+ public TestName name = new TestName();
+
+ @Parameter(0)
+ public Class srcImplClass;
+
+ @Parameter(1)
+ public Class dstImplClass;
+
+ private HRegion region;
+
+ private Path rootDir;
+
+ private WAL wal;
+
+ @Parameters(name = "{index}: src={0}, dst={1}")
+ public static List params() {
+List> impls =
+ Arrays.asList(DefaultStoreFileTracker.class,
FileBasedStoreFileTracker.class);
+List params = new ArrayList<>();
+for (Class src : impls) {
+ for (Class dst : impls) {
+if (src.equals(dst)) {
+ continue;
+}
+params.add(new Object[] { src, dst });
+ }
Review comment:
We will soon have a RegionBasedStoreFileTracker right? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #3656: HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin…
Apache9 commented on a change in pull request #3656:
URL: https://github.com/apache/hbase/pull/3656#discussion_r703416005
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/MigrationStoreFileTracker.java
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.storefiletracker;
+
+import java.io.IOException;
+import java.util.Collection;
+import java.util.List;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.regionserver.StoreContext;
+import org.apache.hadoop.hbase.regionserver.StoreFileInfo;
+import org.apache.yetus.audience.InterfaceAudience;
+
+import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+
+/**
+ * A store file tracker used for migrating between store file tracker
implementations.
+ */
+@InterfaceAudience.Private
+class MigrationStoreFileTracker extends StoreFileTrackerBase {
+
+ public static final String SRC_IMPL =
"hbase.store.file-tracker.migration.src.impl";
+
+ public static final String DST_IMPL =
"hbase.store.file-tracker.migration.dst.impl";
+
+ private final StoreFileTrackerBase src;
+
+ private final StoreFileTrackerBase dst;
+
+ public MigrationStoreFileTracker(Configuration conf, boolean
isPrimaryReplica, StoreContext ctx) {
+super(conf, isPrimaryReplica, ctx);
+this.src = StoreFileTrackerFactory.create(conf, SRC_IMPL,
isPrimaryReplica, ctx);
+this.dst = StoreFileTrackerFactory.create(conf, DST_IMPL,
isPrimaryReplica, ctx);
+Preconditions.checkArgument(!src.getClass().equals(dst.getClass()),
+ "src and dst is the same: %s", src.getClass());
+ }
+
+ @Override
+ public List load() throws IOException {
+List files = src.load();
+// we must call load to initialize the store file tracker, but we do not
care the result, just
+// ignore.
+dst.load();
Review comment:
This is a bit implementation specific.
For DefaultStoreFileTracker we do not need to call load first, it is only
for FileBasedStoreFileTracker, let me see if we could implement the
initialization logic in FileBasedStoreFileTracker itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
