[GitHub] [hbase] Apache9 commented on a diff in pull request #5401: HBASE-28061 HBaseTestingUtility failed to start MiniHbaseCluster in c…

[via GitHub]

Apache9 commented on code in PR #5401:
URL: https://github.com/apache/hbase/pull/5401#discussion_r1325466758


##
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:
##
@@ -383,7 +400,7 @@ private static List> 
connectToDataNodes(Configuration conf, DFSC
 BlockConstructionStage stage, DataChecksum summer, EventLoopGroup 
eventLoopGroup,
 Class channelClass) {
 StorageType[] storageTypes = locatedBlock.getStorageTypes();
-DatanodeInfo[] datanodeInfos = locatedBlock.getLocations();
+DatanodeInfo[] datanodeInfos = getLocatedBlockLocations(locatedBlock);

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on a diff in pull request #5401: HBASE-28061 HBaseTestingUtility failed to start MiniHbaseCluster in c…

[via GitHub]

Apache9 commented on code in PR #5401:
URL: https://github.com/apache/hbase/pull/5401#discussion_r1325503532


##
hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java:
##
@@ -17,6 +17,8 @@
  */
 package org.apache.hadoop.hbase.fs;
 
+import static org.apache.hadoop.hbase.util.LocatedBlockHelper.*;

Review Comment:
   Seems the eclipse formatter spotless plugin will not expand the star imports 
automatically...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org