[GitHub] [hbase] Apache9 commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-03 Thread GitBox 


Apache9 commented on pull request #1830:
URL: https://github.com/apache/hbase/pull/1830#issuecomment-638006266


   The failed UT is caused by a serious problem of our RegionInfo related API.
   
   Let me open a new issue for fixing it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-02 Thread GitBox 


Apache9 commented on pull request #1830:
URL: https://github.com/apache/hbase/pull/1830#issuecomment-637905684


   The method too long checkstyle warning is not introduced by the PR here.
   
   Can open a follow on issue to remove HBaseTestCase and rewrite 
TestHStoreFile.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-02 Thread GitBox 


Apache9 commented on pull request #1830:
URL: https://github.com/apache/hbase/pull/1830#issuecomment-637897472


   > Seems the ut was not trigger in previous HBase QA?
   
   There are failurs for small tests so the medium and large tests are skipped. 
Let me take a look.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-02 Thread GitBox 


Apache9 commented on pull request #1830:
URL: https://github.com/apache/hbase/pull/1830#issuecomment-637651053


   Could pass compile. Let's see the UTs.
   
   And I guess we also need to deal with hbase-shell.
   
   Will take a look soon.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org