[GitHub] [hbase] Apache9 commented on pull request #3969: HBASE-26614 Refactor code related to "dump"ing ZK nodes
Apache9 commented on pull request #3969: URL: https://github.com/apache/hbase/pull/3969#issuecomment-1007868254 > > I think this error prone failure is not related to my change. Mike is working on a fix/upgrade over on #3979 > > It is related. > > You call MetaTableLocator.getMetaRegionLocation in ZKDump but the method has a RestrictedApi annotation which only allow calling from ZKUtil and tests code. Since you just move some code in ZKUtil out to a separated class, you need to change the RestrictedApi annotation in MetaTableLocator. > > Thanks. Have you seen this comment? @ndimiduk Please update the RestrictedApi annotation in MetaTableLocator. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3969: HBASE-26614 Refactor code related to "dump"ing ZK nodes
Apache9 commented on pull request #3969: URL: https://github.com/apache/hbase/pull/3969#issuecomment-1007868254 > > I think this error prone failure is not related to my change. Mike is working on a fix/upgrade over on #3979 > > It is related. > > You call MetaTableLocator.getMetaRegionLocation in ZKDump but the method has a RestrictedApi annotation which only allow calling from ZKUtil and tests code. Since you just move some code in ZKUtil out to a separated class, you need to change the RestrictedApi annotation in MetaTableLocator. > > Thanks. Have you seen this comment? @ndimiduk Please update the RestrictedApi annotation in MetaTableLocator. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #3969: HBASE-26614 Refactor code related to "dump"ing ZK nodes
Apache9 commented on pull request #3969: URL: https://github.com/apache/hbase/pull/3969#issuecomment-1006347167 > I think this error prone failure is not related to my change. Mike is working on a fix/upgrade over on #3979 It is related. You call MetaTableLocator.getMetaRegionLocation in ZKDump but the method has a RestrictedApi annotation which only allow calling from ZKUtil and tests code. Since you just move some code in ZKUtil out to a separated class, you need to change the RestrictedApi annotation in MetaTableLocator. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
