[GitHub] [hbase] Apache9 commented on pull request #4003: HBASE-26646 WALPlayer should obtain token from filesystem

2022-01-08 Thread GitBox 


Apache9 commented on pull request #4003:
URL: https://github.com/apache/hbase/pull/4003#issuecomment-1007251677






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on pull request #4003: HBASE-26646 WALPlayer should obtain token from filesystem

2022-01-07 Thread GitBox 


Apache9 commented on pull request #4003:
URL: https://github.com/apache/hbase/pull/4003#issuecomment-1007263953


   > > So could this solve your problem?
   > 
   > Yes, it works in our cluster.
   
   OK, good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on pull request #4003: HBASE-26646 WALPlayer should obtain token from filesystem

2022-01-07 Thread GitBox 


Apache9 commented on pull request #4003:
URL: https://github.com/apache/hbase/pull/4003#issuecomment-1007251677


   So could this solve your problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on pull request #4003: HBASE-26646 WALPlayer should obtain token from filesystem

2022-01-06 Thread GitBox 


Apache9 commented on pull request #4003:
URL: https://github.com/apache/hbase/pull/4003#issuecomment-1006549533


   I think this should be done in WALInputFormat.
   
   Looking at the code of FileInputFormat, TokenCache.obtainTokensForNamenodes 
will be called in listStatus method, which will be called in getSplits method. 
So I think for WALInputFormat, we should also call 
TokenCache.obtainTokensForNamenodes in getSplits method?
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org