[GitHub] [hbase] Apache9 commented on pull request #4005: HBASE-26643 AssignmentManager should check for empty result returned …
Apache9 commented on pull request #4005: URL: https://github.com/apache/hbase/pull/4005#issuecomment-1007395143 > Should we also modify `randomAssignment` to return `BOGUS_SERVER_NAME` instead of null for unified？ I think this is fine... As null is enough to tell the upper layer we can not assign a region. BOGUS_SERVER_NAME is used in Map since put null key to map is not a good practise usually... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4005: HBASE-26643 AssignmentManager should check for empty result returned …
Apache9 commented on pull request #4005: URL: https://github.com/apache/hbase/pull/4005#issuecomment-1007395143 > Should we also modify `randomAssignment` to return `BOGUS_SERVER_NAME` instead of null for unified？ I think this is fine... As null is enough to tell the upper layer we can not assign a region. BOGUS_SERVER_NAME is used in Map since put null key to map is not a good practise usually... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4005: HBASE-26643 AssignmentManager should check for empty result returned …
Apache9 commented on pull request #4005: URL: https://github.com/apache/hbase/pull/4005#issuecomment-1006710848 Ah, there is a problem. For RSGroupLoadBalancer, we have to use BOGUS_SERVER_NAME to indicate the upper layer that some regions can not be assigned, otherwise the upper layer needs iterator over all the regions to check wheter there are missing ones. Otherwise we need to redesign the return value to make it possible to tell upper layer that some regions are not assigned, through other ways... So I suppose we should not return empty map to upper layer then, we should use BOGUS_SERVER_NAME to record the regions which can not be assigned. Let me provide a new patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
