[GitHub] [hbase] Apache9 commented on pull request #4050: HBASE-26691 Replacing log4j with reload4j for branch-2.x
Apache9 commented on pull request #4050: URL: https://github.com/apache/hbase/pull/4050#issuecomment-1057619529 > how about we get this in place for branches-2 now, so that we can stop shipping hbase 2 releases with an EOL log4j 1, but we plan for the log4j 2 changes to be the preferred path for whatever the next minor 2.x release is after the backport lands. (presuming the testing goes well.) Fine by me~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4050: HBASE-26691 Replacing log4j with reload4j for branch-2.x
Apache9 commented on pull request #4050: URL: https://github.com/apache/hbase/pull/4050#issuecomment-1057589064 So do we plan to use reload4j for 2.x, or we plan to directly upgrade to log4j2? I plan to backport the log4j2 changes to branch-2 and try to see if using the old log4j.properties is fine with log4j-1.2-api in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4050: HBASE-26691 Replacing log4j with reload4j for branch-2.x
Apache9 commented on pull request #4050: URL: https://github.com/apache/hbase/pull/4050#issuecomment-1022859891 > I am testing my Hadoop reload4j patch, and then realized there are a lot of gotchas when building downstream applications. Please try build HBase downstream applications with this change. I tried to merge this PR in my internal branch and then test but we're too far away from branch-2 and resulted lots of conflicts. For HBase we have tried out best to not introduce log4j dependencies to our downstream users, they will only pull in slf4j, so I do not think it will break our users too much. But it is true that hadoop and zookeeper will introduce log4j and slf4j-log4j12 dependencies to downstreamer users, I suggest we do a round of cleanup, to avoid introducing these dependencies. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #4050: HBASE-26691 Replacing log4j with reload4j for branch-2.x
Apache9 commented on pull request #4050: URL: https://github.com/apache/hbase/pull/4050#issuecomment-1018314305 > does it also ban transitive dependencies on log4j and slf4j-log4j12? Yes, if you do not want to ban transitive dependency, just add `false` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
