[GitHub] [hbase] HorizonNet commented on a change in pull request #2616: HBASE-25235 Cleanup the deprecated methods in TimeRange

[GitBox]

HorizonNet commented on a change in pull request #2616:
URL: https://github.com/apache/hbase/pull/2616#discussion_r516851115



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
##########
@@ -162,10 +162,9 @@ public Append addColumn(byte[] family, byte[] qualifier, 
byte[] value) {
 
   /**
    * Add column and value to this Append operation.
-   * @param cell
    * @return This instance
    */
-  @SuppressWarnings("unchecked")
+  @Override

Review comment:
       Seems to be unrelated to the actual change.

##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java
##########
@@ -18,24 +18,23 @@
 
 package org.apache.hadoop.hbase.io;
 
-import org.apache.hadoop.hbase.util.Bytes;
 import org.apache.yetus.audience.InterfaceAudience;
 
 /**
  * Represents an interval of version timestamps. Presumes timestamps between
  * {@link #INITIAL_MIN_TIMESTAMP} and {@link #INITIAL_MAX_TIMESTAMP} only. 
Gets freaked out if
  * passed a timestamp that is < {@link #INITIAL_MIN_TIMESTAMP},
- * <p>
+ * <p/>
  * Evaluated according to minStamp &lt;= timestamp &lt; maxStamp or 
[minStamp,maxStamp) in interval
  * notation.
- * <p>
+ * <p/>
  * Can be returned and read by clients. Should not be directly created by 
clients. Thus, all
  * constructors are purposely @InterfaceAudience.Private.
- * <p>
+ * <p/>
  * Immutable. Thread-safe.
  */
 @InterfaceAudience.Public
-public class TimeRange {
+public final class TimeRange {

Review comment:
       Probably this needs to be called out separately in the release notes as 
it is not binary-compatible. Shouldn't matter as it is introduced in major 
release, but probably worth it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org