[GitHub] [hbase] Joseph295 commented on pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…
Joseph295 commented on pull request #2568: URL: https://github.com/apache/hbase/pull/2568#issuecomment-716932347 > Can we change the jira title/description, as this really deals with recovered edits, not hfiles? > > And just giving a second thought on this issue: here we log only once the corruption is first detected, then mark it and never log it again, silently ignoring it. I'm wondering if we should rather stay verbose, in this case, given it may imply data loss. I checked the code, and find it is not essential for recovered edits as every time we begin to deal with recover edits, we will clear the files first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Joseph295 commented on pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…
Joseph295 commented on pull request #2568: URL: https://github.com/apache/hbase/pull/2568#issuecomment-716931810 > Can we change the jira title/description, as this really deals with recovered edits, not hfiles? > > And just giving a second thought on this issue: here we log only once the corruption is first detected, then mark it and never log it again, silently ignoring it. I'm wondering if we should rather stay verbose, in this case, given it may imply data loss. Do you have other concerns? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
