[GitHub] [hbase] PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule
PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#issuecomment-542698253 I added a test to load the rule files from HDFS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule
PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#issuecomment-542290169 Thanks @wchevreuil, I updated the PR. Normally I should now have the right checkstyle in Intellij. I had another extension(Save actions) which created the mess :thinking: I added some testcases, I now need to work on the file part, to make it available from either HDFS or localFS. Thank you for your comments about this BTW. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule
PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#issuecomment-538896872 Yes sorry about that auto-formatted thing. I will do that asap, thank you for the explanations @wchevreuil This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule
PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#issuecomment-538878306 Wow, so much checkstyles failed Sorry for the disturbance @wchevreuil, I took into account most of your comments, thank you again I will import checkstyles into Intellij to avoid pushing useless commits and fix it asap. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule
PierreZ commented on issue #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#issuecomment-537695399 I need to add a few more tests before it can be merged, for example load the rule file from HDFS, and more cases on the balancing itself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services