[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-615051883 Thanks @virajjasani , we finally get here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-615007594 Rebased branch-1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-614726682 Thanks @busbey ! Oh, there're two findbugs..., oversight. OK, let me remove the suppress and if the fix works. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-614514636 This ``` Inconsistent synchronization of org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 66% of time Bug type IS2_INCONSISTENT_SYNC (click for details) In class org.apache.hadoop.hbase.ipc.RpcServerField org.apache.hadoop.hbase.ipc.RpcServer.authManagerSynchronized 66% of the time Unsynchronized access at RpcServer.java:[line 2270] Unsynchronized access at RpcServer.java:[line 2271] ``` 2270 and 2271 line is the original code without patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-614480182 I just found the findbug's line number doesn't match. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-614409136 so buggyhaving no clue.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-613966670 > Oh ok, it seems we will have to put it over where we define authManager. Interesting! Let's see if this works :) Tried, the previous commit... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-613966915 the 2nd commit suppressed on definition This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-613963466 The suppress doesn't work?... o_0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-612822619 Let me check how does the branch-2 suppress the warning...( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1
Reidd commented on issue #1494: HBASE-24174 Fix findbugs warning in branch-1 URL: https://github.com/apache/hbase/pull/1494#issuecomment-612777321 Let's see if the warning fade, after this commit.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
