[GitHub] [hbase] YutSean commented on pull request #5352: HBASE-26780 HFileBlock.verifyOnDiskSizeMatchesHeader throw IOException: Passed in onDiskSizeWithHeader= A != 33
YutSean commented on PR #5352: URL: https://github.com/apache/hbase/pull/5352#issuecomment-1709486972 > How have you tested this? Could we write a unit test which demonstrates the intended behavior? As it is an unreproducible case, it is hard to simulate the error we met. The normal use case is already covered by our existing UTs. So that I did not write a UT. As for testing, we just pushed this change to our production environment. It works so far so good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] YutSean commented on pull request #5352: HBASE-26780 HFileBlock.verifyOnDiskSizeMatchesHeader throw IOException: Passed in onDiskSizeWithHeader= A != 33
YutSean commented on PR #5352: URL: https://github.com/apache/hbase/pull/5352#issuecomment-1679851089 The failed UT is unrelated to the change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
