[GitHub] [hbase] anmolnar commented on a diff in pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client
anmolnar commented on code in PR #5370:
URL: https://github.com/apache/hbase/pull/5370#discussion_r1315565341
##
hbase-common/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java:
##
@@ -330,4 +341,27 @@ public static String
getClientZKQuorumServersString(Configuration conf) {
final String[] serverHosts = StringUtils.getStrings(clientQuromServers);
return buildZKQuorumServerString(serverHosts, clientZkClientPort);
}
+
+ private static void setZooKeeperClientSystemProperties(String prefix,
Configuration conf) {
Review Comment:
@wchevreuil @Apache9 Sorry, I couldn't look here over the weekend. Since the
patch already has everything to submit I wouldn't make any change for now.
There's chance to have more ZK properties to add here which are not TLS
related, so hopefully not a big deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] anmolnar commented on a diff in pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client
anmolnar commented on code in PR #5370:
URL: https://github.com/apache/hbase/pull/5370#discussion_r1315565341
##
hbase-common/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java:
##
@@ -330,4 +341,27 @@ public static String
getClientZKQuorumServersString(Configuration conf) {
final String[] serverHosts = StringUtils.getStrings(clientQuromServers);
return buildZKQuorumServerString(serverHosts, clientZkClientPort);
}
+
+ private static void setZooKeeperClientSystemProperties(String prefix,
Configuration conf) {
Review Comment:
@wchevreuil @Apache9 Sorry, I couldn't look here over the weekend. Since the
patch already has everything to submit I wouldn't make any change it for now.
There's chance to have more ZK properties to add here which are not TLS
related, so hopefully not a big deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] anmolnar commented on a diff in pull request #5370: HBASE-28038 Add TLS settings to ZooKeeper client
anmolnar commented on code in PR #5370:
URL: https://github.com/apache/hbase/pull/5370#discussion_r1307105359
##
hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java:
##
@@ -219,6 +222,12 @@ public enum OperationStatusCode {
public static final String CLIENT_ZOOKEEPER_CLIENT_PORT =
"hbase.client.zookeeper.property.clientPort";
+ /** Supported ZooKeeper client TLS properties */
+ public static final Set ZOOKEEPER_CLIENT_TLS_PROPERTIES =
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
