[GitHub] [hbase] arshadmohammad commented on a change in pull request #1592: HBASE-24244 Move Region Command fails to move region of a table to another RS which is a part of different RSGroup without

2020-07-31 Thread GitBox 


arshadmohammad commented on a change in pull request #1592:
URL: https://github.com/apache/hbase/pull/1592#discussion_r463734520



##
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -2085,6 +2085,10 @@ public void move(final byte[] encodedRegionName, byte[] 
destServerName) throws I
 return;
   }
 }
+if (dest.equals(LoadBalancer.BOGUS_SERVER_NAME)) {

Review comment:
   Added comment in code.
   Force pushed to correct author name in previous commit





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] arshadmohammad commented on a change in pull request #1592: HBASE-24244 Move Region Command fails to move region of a table to another RS which is a part of different RSGroup without

2020-05-22 Thread GitBox 


arshadmohammad commented on a change in pull request #1592:
URL: https://github.com/apache/hbase/pull/1592#discussion_r429383780



##
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -2085,6 +2085,10 @@ public void move(final byte[] encodedRegionName, byte[] 
destServerName) throws I
 return;
   }
 }
+if (dest.equals(LoadBalancer.BOGUS_SERVER_NAME)) {

Review comment:
   When rsgroup is enabled a region can be moved to same rsgroup servers 
only. It means that region's current server and target server must belong to 
the same rsgroup.
   
   Currently while moving a region to different rsgroup server, balancer 
assigns invalid target server named as BOGUS_SERVER_NAME (localhost,1,1.). Even 
though it is invalid server region move procedure is submitted and finally 
region move fails.
   
   This PR proposes to fail fast, in case of target server is BOGUS_SERVER_NAME 
log info and return. No need to submit region move procedure
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org